From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, dyroneteng@gmail.com
Subject: Re: packfile-uri.txt: fix blobPackfileUri description
Date: Tue, 25 May 2021 09:34:25 +0900 [thread overview]
Message-ID: <xmqqsg2birce.fsf@gitster.g> (raw)
In-Reply-To: <20210524154354.268200-1-jonathantanmy@google.com> (Jonathan Tan's message of "Mon, 24 May 2021 08:43:54 -0700")
Jonathan Tan <jonathantanmy@google.com> writes:
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>> > Teng Long <dyroneteng@gmail.com> writes:
>> >
>> >> Fix the 'uploadpack.blobPackfileUri' description in packfile-uri.txt
>> >> and the correct format also can be seen in t5702.
>> >>
>> >> Signed-off-by: Teng Long <dyroneteng@gmail.com>
>> >> ---
>> >> Documentation/technical/packfile-uri.txt | 15 ++++++++-------
>> >> 1 file changed, 8 insertions(+), 7 deletions(-)
>> >
>> > Will queue; thanks.
>> >
>> > Jonathan, how does this look?
>>
>> Ping?
>
> Sorry, I just got back on vacation. This looks good - it's exactly the
> same as the change I approved previously [1].
Thanks.
>
> Teng Long, for future reviews, the review would go faster if you
> mentioned the changes in between versions (e.g. in this case, you
> updated the commit message following my suggestions).
>
> [1] https://lore.kernel.org/git/20210506164728.336409-1-jonathantanmy@google.com/
prev parent reply other threads:[~2021-05-25 0:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 7:33 [PATCH] Optimize the description of the configuration in packfile-uris doc Teng Long
2021-05-06 16:47 ` Jonathan Tan
2021-05-06 21:39 ` Junio C Hamano
2021-05-11 6:45 ` [PATCH v2] packfile-uri.txt: fix blobPackfileUri description Teng Long
2021-05-11 20:50 ` Junio C Hamano
2021-05-12 14:10 ` Long Teng
2021-05-12 23:32 ` Junio C Hamano
2021-05-13 7:15 ` Teng Long
2021-05-13 21:33 ` Junio C Hamano
2021-05-18 0:44 ` Junio C Hamano
2021-05-24 15:43 ` Jonathan Tan
2021-05-25 0:34 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsg2birce.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).