From: Junio C Hamano <gitster@pobox.com> To: larsxschneider@gmail.com Cc: git@vger.kernel.org, peff@peff.net, jnareb@gmail.com, tboegi@web.de Subject: Re: [PATCH v1 0/3] Git filter protocol Date: Fri, 22 Jul 2016 14:39:57 -0700 Message-ID: <xmqqshv18i8i.fsf@gitster.mtv.corp.google.com> (raw) In-Reply-To: <20160722154900.19477-1-larsxschneider@gmail.com> (larsxschneider@gmail.com's message of "Fri, 22 Jul 2016 17:48:57 +0200") larsxschneider@gmail.com writes: > The first two patches are cleanup patches which are not really necessary > for the feature. These two looked trivially good. I think I can agree with what 3/3 wants to do in principle, but * "protocol" is not quite the right word. The current way to interact with clean and smudge filters can be considered using a different "protocol", that conveys the data and the options via the command line and pipe. The most distinguishing feature that differentiates the old way and the new style this change allows is that it allows you to have a single instance of the process running that can be reused? * I am not sure what's the pros-and-cons in forcing people writing a single program that can do both cleaning and smudging. You cannot have only "smudge" side that uses the long-running process while "clean" side that runs single-shot invocation with this design, which I'd imagine would be a downside. If you are going to use a long-running process interface for both sides, this design allows you to do it with fewer number of processes, which may be an upside. * The way the serialized access to these long-running processes work in 3/3 would make it harder or impossible to later parallelize conversion? I am imagining a far future where we would run "git checkout ." using (say) two threads, one responsible for active_cache[0..active_nr/2] and the other responsible for the remainder. > You will notice that I do not check the exact number of "clean" filter > invocations in the tests. That is a good thing to do. You shouldn't really care for the proper operation of the feature, reducing the number of them would be an independent topic (see the work of Peff earlier today), and we may even find a need to make _more_ calls for correctness (again, see the work of Peff earlier today -- to a person who wants to keep the number of requests to the attribute system low, the change may look like a regression, but it is necessary for the overall system; you may find a similar need to running "clean" more for some need of the overall system that you do not anticipate right now).
next prev parent reply index Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-22 15:48 larsxschneider 2016-07-22 15:48 ` [PATCH v1 1/3] convert: quote filter names in error messages larsxschneider 2016-07-22 15:48 ` [PATCH v1 2/3] convert: modernize tests larsxschneider 2016-07-26 15:18 ` Remi Galan Alfonso 2016-07-26 20:40 ` Junio C Hamano 2016-07-22 15:49 ` [PATCH v1 3/3] convert: add filter.<driver>.useProtocol option larsxschneider 2016-07-22 22:32 ` Torsten Bögershausen 2016-07-24 12:09 ` Lars Schneider 2016-07-22 23:19 ` Ramsay Jones 2016-07-22 23:28 ` Ramsay Jones 2016-07-24 17:16 ` Lars Schneider 2016-07-24 22:36 ` Ramsay Jones 2016-07-24 23:22 ` Jakub Narębski 2016-07-25 20:32 ` Lars Schneider 2016-07-26 10:58 ` Jakub Narębski 2016-07-25 20:24 ` Lars Schneider 2016-07-23 0:11 ` Jakub Narębski 2016-07-23 7:27 ` Eric Wong 2016-07-26 20:00 ` Jeff King 2016-07-24 18:36 ` Lars Schneider 2016-07-24 20:14 ` Jakub Narębski 2016-07-24 21:30 ` Jakub Narębski 2016-07-25 20:16 ` Lars Schneider 2016-07-26 12:24 ` Jakub Narębski 2016-07-25 20:09 ` Lars Schneider 2016-07-26 14:18 ` Jakub Narębski 2016-07-23 8:14 ` Eric Wong 2016-07-24 19:11 ` Lars Schneider 2016-07-25 7:27 ` Eric Wong 2016-07-25 15:48 ` Duy Nguyen 2016-07-22 21:39 ` Junio C Hamano [this message] 2016-07-24 11:24 ` [PATCH v1 0/3] Git filter protocol Lars Schneider 2016-07-26 20:11 ` Jeff King 2016-07-27 0:06 ` [PATCH v2 0/5] " larsxschneider 2016-07-27 0:06 ` [PATCH v2 1/5] convert: quote filter names in error messages larsxschneider 2016-07-27 20:01 ` Jakub Narębski 2016-07-28 8:23 ` Lars Schneider 2016-07-27 0:06 ` [PATCH v2 2/5] convert: modernize tests larsxschneider 2016-07-27 0:06 ` [PATCH v2 3/5] pkt-line: extract and use `set_packet_header` function larsxschneider 2016-07-27 0:20 ` Junio C Hamano 2016-07-27 9:13 ` Lars Schneider 2016-07-27 16:31 ` Junio C Hamano 2016-07-27 0:06 ` [PATCH v2 4/5] convert: generate large test files only once larsxschneider 2016-07-27 2:35 ` Torsten Bögershausen 2016-07-27 13:32 ` Jeff King 2016-07-27 16:50 ` Lars Schneider 2016-07-27 0:06 ` [PATCH v2 5/5] convert: add filter.<driver>.process option larsxschneider 2016-07-27 1:32 ` Jeff King 2016-07-27 17:31 ` Lars Schneider 2016-07-27 18:11 ` Jeff King 2016-07-28 12:10 ` Lars Schneider 2016-07-28 13:35 ` Jeff King 2016-07-27 9:41 ` Eric Wong 2016-07-29 10:38 ` Lars Schneider 2016-07-29 11:24 ` Jakub Narębski 2016-07-29 11:31 ` Lars Schneider 2016-08-05 18:55 ` Eric Wong 2016-08-05 23:26 ` Lars Schneider 2016-08-05 23:38 ` Eric Wong 2016-07-27 23:31 ` Jakub Narębski 2016-07-29 8:04 ` Lars Schneider 2016-07-29 17:35 ` Junio C Hamano 2016-07-29 23:11 ` Jakub Narębski 2016-07-29 23:44 ` Lars Schneider 2016-07-30 9:32 ` Jakub Narębski 2016-07-28 10:32 ` Torsten Bögershausen 2016-07-27 19:08 ` [PATCH v2 0/5] Git filter protocol Jakub Narębski 2016-07-28 7:16 ` Lars Schneider 2016-07-28 10:42 ` Jakub Narębski 2016-07-28 13:29 ` Jeff King 2016-07-29 7:40 ` Jakub Narębski 2016-07-29 8:14 ` Lars Schneider 2016-07-29 15:57 ` Jeff King 2016-07-29 16:20 ` Lars Schneider 2016-07-29 16:50 ` Jeff King 2016-07-29 17:43 ` Lars Schneider 2016-07-29 18:27 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=xmqqshv18i8i.fsf@gitster.mtv.corp.google.com \ --to=gitster@pobox.com \ --cc=git@vger.kernel.org \ --cc=jnareb@gmail.com \ --cc=larsxschneider@gmail.com \ --cc=peff@peff.net \ --cc=tboegi@web.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Mailing List Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/git/0 git/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 git git/ https://lore.kernel.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git