* [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
@ 2017-03-03 10:57 Sebastian Schuberth
2017-03-03 11:21 ` Jeff King
2017-03-03 15:32 ` Marc Branchaud
0 siblings, 2 replies; 6+ messages in thread
From: Sebastian Schuberth @ 2017-03-03 10:57 UTC (permalink / raw)
To: git
It does not make sense for these placeholder scripts to depend on Python
just because the real scripts do. At the example of Git for Windows, we
would not even be able to see those warnings as it does not ship with
Python. So just use plain shell scripts instead.
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
---
contrib/remote-helpers/git-remote-bzr | 16 +++++++---------
contrib/remote-helpers/git-remote-hg | 16 +++++++---------
2 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
index 712a137..ccc4aea 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@ -1,13 +1,11 @@
-#!/usr/bin/env python
+#!/bin/sh
-import sys
-
-sys.stderr.write('WARNING: git-remote-bzr is now maintained independently.\n')
-sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-bzr\n')
-
-sys.stderr.write('''WARNING:
+cat <<'EOT'
+WARNING: git-remote-bzr is now maintained independently.
+WARNING: For more information visit https://github.com/felipec/git-remote-bzr
+WARNING:
WARNING: You can pick a directory on your $PATH and download it, e.g.:
-WARNING: $ wget -O $HOME/bin/git-remote-bzr \\
+WARNING: $ wget -O $HOME/bin/git-remote-bzr \
WARNING: https://raw.github.com/felipec/git-remote-bzr/master/git-remote-bzr
WARNING: $ chmod +x $HOME/bin/git-remote-bzr
-''')
+EOT
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index 4255ad6..dfda44f 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -1,13 +1,11 @@
-#!/usr/bin/env python
+#!/bin/sh
-import sys
-
-sys.stderr.write('WARNING: git-remote-hg is now maintained independently.\n')
-sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-hg\n')
-
-sys.stderr.write('''WARNING:
+cat <<'EOT'
+WARNING: git-remote-hg is now maintained independently.
+WARNING: For more information visit https://github.com/felipec/git-remote-hg
+WARNING:
WARNING: You can pick a directory on your $PATH and download it, e.g.:
-WARNING: $ wget -O $HOME/bin/git-remote-hg \\
+WARNING: $ wget -O $HOME/bin/git-remote-hg \
WARNING: https://raw.github.com/felipec/git-remote-hg/master/git-remote-hg
WARNING: $ chmod +x $HOME/bin/git-remote-hg
-''')
+EOT
--
https://github.com/git/git/pull/333
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
2017-03-03 10:57 [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts Sebastian Schuberth
@ 2017-03-03 11:21 ` Jeff King
2017-03-03 19:06 ` Junio C Hamano
2017-03-03 15:32 ` Marc Branchaud
1 sibling, 1 reply; 6+ messages in thread
From: Jeff King @ 2017-03-03 11:21 UTC (permalink / raw)
To: Sebastian Schuberth; +Cc: git
On Fri, Mar 03, 2017 at 10:57:46AM +0000, Sebastian Schuberth wrote:
> It does not make sense for these placeholder scripts to depend on Python
> just because the real scripts do. At the example of Git for Windows, we
> would not even be able to see those warnings as it does not ship with
> Python. So just use plain shell scripts instead.
Yeah, this seems like an obvious improvement. I think we got here
because the originals issued a warning but kept working, and then it was
slowly whittled down to remove the "working" part.
At some point these can probably go away. It's been 3 years since they
turned into nothing but warnings, so presumably most people have
upgraded by now (I know people often go a long time on old
distro-packaged versions, but the distro packagers would presumably
figure this out in the meantime).
OTOH, it is not really hurting much, so I do not mind keeping them
around for another 3 years (or more) just to catch any stragglers.
-Peff
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
2017-03-03 11:21 ` Jeff King
@ 2017-03-03 19:06 ` Junio C Hamano
0 siblings, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2017-03-03 19:06 UTC (permalink / raw)
To: Jeff King; +Cc: Sebastian Schuberth, git
Jeff King <peff@peff.net> writes:
> On Fri, Mar 03, 2017 at 10:57:46AM +0000, Sebastian Schuberth wrote:
>
>> It does not make sense for these placeholder scripts to depend on Python
>> just because the real scripts do. At the example of Git for Windows, we
>> would not even be able to see those warnings as it does not ship with
>> Python. So just use plain shell scripts instead.
>
> Yeah, this seems like an obvious improvement. I think we got here
> because the originals issued a warning but kept working, and then it was
> slowly whittled down to remove the "working" part.
> ...
> OTOH, it is not really hurting much, so I do not mind keeping them
> around for another 3 years (or more) just to catch any stragglers.
Yup, let's queue it and remove it in a few years.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
2017-03-03 10:57 [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts Sebastian Schuberth
2017-03-03 11:21 ` Jeff King
@ 2017-03-03 15:32 ` Marc Branchaud
2017-03-03 19:10 ` Junio C Hamano
1 sibling, 1 reply; 6+ messages in thread
From: Marc Branchaud @ 2017-03-03 15:32 UTC (permalink / raw)
To: Sebastian Schuberth, git
On 2017-03-03 05:57 AM, Sebastian Schuberth wrote:
> It does not make sense for these placeholder scripts to depend on Python
> just because the real scripts do. At the example of Git for Windows, we
> would not even be able to see those warnings as it does not ship with
> Python. So just use plain shell scripts instead.
Just a niggle: This change moves the warning message from stderr to stdout.
M.
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
> ---
> contrib/remote-helpers/git-remote-bzr | 16 +++++++---------
> contrib/remote-helpers/git-remote-hg | 16 +++++++---------
> 2 files changed, 14 insertions(+), 18 deletions(-)
>
> diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
> index 712a137..ccc4aea 100755
> --- a/contrib/remote-helpers/git-remote-bzr
> +++ b/contrib/remote-helpers/git-remote-bzr
> @@ -1,13 +1,11 @@
> -#!/usr/bin/env python
> +#!/bin/sh
>
> -import sys
> -
> -sys.stderr.write('WARNING: git-remote-bzr is now maintained independently.\n')
> -sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-bzr\n')
> -
> -sys.stderr.write('''WARNING:
> +cat <<'EOT'
> +WARNING: git-remote-bzr is now maintained independently.
> +WARNING: For more information visit https://github.com/felipec/git-remote-bzr
> +WARNING:
> WARNING: You can pick a directory on your $PATH and download it, e.g.:
> -WARNING: $ wget -O $HOME/bin/git-remote-bzr \\
> +WARNING: $ wget -O $HOME/bin/git-remote-bzr \
> WARNING: https://raw.github.com/felipec/git-remote-bzr/master/git-remote-bzr
> WARNING: $ chmod +x $HOME/bin/git-remote-bzr
> -''')
> +EOT
> diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
> index 4255ad6..dfda44f 100755
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -1,13 +1,11 @@
> -#!/usr/bin/env python
> +#!/bin/sh
>
> -import sys
> -
> -sys.stderr.write('WARNING: git-remote-hg is now maintained independently.\n')
> -sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-hg\n')
> -
> -sys.stderr.write('''WARNING:
> +cat <<'EOT'
> +WARNING: git-remote-hg is now maintained independently.
> +WARNING: For more information visit https://github.com/felipec/git-remote-hg
> +WARNING:
> WARNING: You can pick a directory on your $PATH and download it, e.g.:
> -WARNING: $ wget -O $HOME/bin/git-remote-hg \\
> +WARNING: $ wget -O $HOME/bin/git-remote-hg \
> WARNING: https://raw.github.com/felipec/git-remote-hg/master/git-remote-hg
> WARNING: $ chmod +x $HOME/bin/git-remote-hg
> -''')
> +EOT
>
> --
> https://github.com/git/git/pull/333
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
2017-03-03 15:32 ` Marc Branchaud
@ 2017-03-03 19:10 ` Junio C Hamano
2017-03-03 20:13 ` Sebastian Schuberth
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2017-03-03 19:10 UTC (permalink / raw)
To: Marc Branchaud; +Cc: Sebastian Schuberth, git
Marc Branchaud <marcnarc@xiplink.com> writes:
> On 2017-03-03 05:57 AM, Sebastian Schuberth wrote:
>> It does not make sense for these placeholder scripts to depend on Python
>> just because the real scripts do. At the example of Git for Windows, we
>> would not even be able to see those warnings as it does not ship with
>> Python. So just use plain shell scripts instead.
>
> Just a niggle: This change moves the warning message from stderr to stdout.
Right. Here is what I'll queue.
-- >8 --
From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Fri, 3 Mar 2017 10:57:46 +0000
Subject: [PATCH] contrib: git-remote-{bzr,hg} placeholders don't need Python
It does not make sense for these placeholder scripts to depend on Python
just because the real scripts do. At the example of Git for Windows, we
would not even be able to see those warnings as it does not ship with
Python. So just use plain shell scripts instead.
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
contrib/remote-helpers/git-remote-bzr | 16 +++++++---------
contrib/remote-helpers/git-remote-hg | 16 +++++++---------
2 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
index 712a1377e2..ccc4aea362 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@ -1,13 +1,11 @@
-#!/usr/bin/env python
+#!/bin/sh
-import sys
-
-sys.stderr.write('WARNING: git-remote-bzr is now maintained independently.\n')
-sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-bzr\n')
-
-sys.stderr.write('''WARNING:
+cat >&2 <<'EOT'
+WARNING: git-remote-bzr is now maintained independently.
+WARNING: For more information visit https://github.com/felipec/git-remote-bzr
+WARNING:
WARNING: You can pick a directory on your $PATH and download it, e.g.:
-WARNING: $ wget -O $HOME/bin/git-remote-bzr \\
+WARNING: $ wget -O $HOME/bin/git-remote-bzr \
WARNING: https://raw.github.com/felipec/git-remote-bzr/master/git-remote-bzr
WARNING: $ chmod +x $HOME/bin/git-remote-bzr
-''')
+EOT
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index 4255ad6312..dfda44f311 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -1,13 +1,11 @@
-#!/usr/bin/env python
+#!/bin/sh
-import sys
-
-sys.stderr.write('WARNING: git-remote-hg is now maintained independently.\n')
-sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-hg\n')
-
-sys.stderr.write('''WARNING:
+cat >&2 <<'EOT'
+WARNING: git-remote-hg is now maintained independently.
+WARNING: For more information visit https://github.com/felipec/git-remote-hg
+WARNING:
WARNING: You can pick a directory on your $PATH and download it, e.g.:
-WARNING: $ wget -O $HOME/bin/git-remote-hg \\
+WARNING: $ wget -O $HOME/bin/git-remote-hg \
WARNING: https://raw.github.com/felipec/git-remote-hg/master/git-remote-hg
WARNING: $ chmod +x $HOME/bin/git-remote-hg
-''')
+EOT
--
2.12.0-368-g85767a6c71
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
2017-03-03 19:10 ` Junio C Hamano
@ 2017-03-03 20:13 ` Sebastian Schuberth
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Schuberth @ 2017-03-03 20:13 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Marc Branchaud, Git Mailing List
On Fri, Mar 3, 2017 at 8:10 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Just a niggle: This change moves the warning message from stderr to stdout.
>
> Right. Here is what I'll queue.
Indeed, thanks for the note, and also Junio for fixing while queuing.
--
Sebastian Schuberth
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-03 20:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-03 10:57 [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts Sebastian Schuberth
2017-03-03 11:21 ` Jeff King
2017-03-03 19:06 ` Junio C Hamano
2017-03-03 15:32 ` Marc Branchaud
2017-03-03 19:10 ` Junio C Hamano
2017-03-03 20:13 ` Sebastian Schuberth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).