From: Junio C Hamano <gitster@pobox.com>
To: "Jean-Noël Avila" <jn.avila@free.fr>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] i18n: fix mistakes in translated strings
Date: Thu, 23 Aug 2018 14:28:55 -0700 [thread overview]
Message-ID: <xmqqwosghiw8.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180823210056.27489-1-jn.avila@free.fr> (=?utf-8?Q?=22Jean-?= =?utf-8?Q?No=C3=ABl?= Avila"'s message of "Thu, 23 Aug 2018 23:00:56 +0200")
Jean-Noël Avila <jn.avila@free.fr> writes:
> - die(_("run_command returned non-zero status while"
> + die(_("run_command returned non-zero status while "
> "recursing in the nested submodules of %s\n."),
Obviously good.
> diff --git a/config.c b/config.c
> index 9a0b10d4bc..3461993f0a 100644
> --- a/config.c
> +++ b/config.c
> @@ -124,7 +124,7 @@ static const char include_depth_advice[] = N_(
> " %s\n"
> "from\n"
> " %s\n"
> -"Do you have circular includes?");
> +"This might be due to circular includes.");
OK.
> diff --git a/sequencer.c b/sequencer.c
> index 65d371c746..84bf598c3e 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -720,7 +720,7 @@ static const char *read_author_ident(struct strbuf *buf)
> /* dequote values and construct ident line in-place */
> for (in = buf->buf; i < 3 && in - buf->buf < buf->len; i++) {
> if (!skip_prefix(in, keys[i], (const char **)&in)) {
> - warning(_("could not parse '%s' (looking for '%s'"),
> + warning(_("could not parse '%s' (looking for '%s')"),
Good. Thanks.
next prev parent reply other threads:[~2018-08-23 21:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 21:00 [PATCH] i18n: fix mistakes in translated strings Jean-Noël Avila
2018-08-23 21:28 ` Junio C Hamano [this message]
2018-09-03 17:52 ` Jean-Noël AVILA
2018-09-04 1:01 ` [L10N] Kickoff for Git 2.19.0 round 2 Jiang Xin
2018-09-04 1:52 ` [PATCH] i18n: fix mistakes in translated strings Jiang Xin
2018-09-04 14:18 ` [PATCH] i18n: fix dangling dot in die() messages Jean-Noel Avila
2018-09-04 15:05 ` Ævar Arnfjörð Bjarmason
2018-09-04 15:13 ` Jean-Noël Avila
2018-09-04 19:47 ` Junio C Hamano
2018-09-04 15:16 ` Duy Nguyen
2018-09-04 19:32 ` [PATCH] i18n: fix mistakes in translated strings Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwosghiw8.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jn.avila@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).