* [PATCH v1 1/2] doc: dt-binding: mxs-usb-phy: fix fsl,tx-cal-45-dn-ohms max and min value
@ 2022-08-29 15:31 Frank Li
2022-08-29 15:31 ` [PATCH v1 2/2] usb: phy: mxs: fix MXS_PHY_TX_CAL45_MIN and MXS_PHY_TX_CAL45_MAX Frank Li
2022-08-30 9:44 ` [PATCH v1 1/2] doc: dt-binding: mxs-usb-phy: fix fsl,tx-cal-45-dn-ohms max and min value Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Frank Li @ 2022-08-29 15:31 UTC (permalink / raw)
To: kishon, vkoul, robh+dt, krzysztof.kozlowski+dt, shawnguo,
s.hauer, kernel, festevam, linux-imx, balbi, gregkh, linux-phy,
devicetree, linux-arm-kernel, linux-kernel, linux-usb, imx
According to spec:
0000 +19.95%
....
1111 -21.68%
45 * (1 + 19.95%) = 53.9775
45 * (1 - 21.68%) = 35.244
Chanege fsl,tx-cal-45-dn-ohms and fsl,tx-cal-45-dp-ohms range to [35-54]
from [30-55]
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Documentation/devicetree/bindings/phy/mxs-usb-phy.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
index c9f5c0caf8a9c..111d446b5f986 100644
--- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
+++ b/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
@@ -14,10 +14,10 @@ Required properties:
- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series
Optional properties:
-- fsl,tx-cal-45-dn-ohms: Integer [30-55]. Resistance (in ohms) of switchable
+- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable
high-speed trimming resistor connected in parallel with the 45 ohm resistor
that terminates the DN output signal. Default: 45
-- fsl,tx-cal-45-dp-ohms: Integer [30-55]. Resistance (in ohms) of switchable
+- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable
high-speed trimming resistor connected in parallel with the 45 ohm resistor
that terminates the DP output signal. Default: 45
- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v1 2/2] usb: phy: mxs: fix MXS_PHY_TX_CAL45_MIN and MXS_PHY_TX_CAL45_MAX
2022-08-29 15:31 [PATCH v1 1/2] doc: dt-binding: mxs-usb-phy: fix fsl,tx-cal-45-dn-ohms max and min value Frank Li
@ 2022-08-29 15:31 ` Frank Li
2022-08-30 9:44 ` [PATCH v1 1/2] doc: dt-binding: mxs-usb-phy: fix fsl,tx-cal-45-dn-ohms max and min value Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2022-08-29 15:31 UTC (permalink / raw)
To: kishon, vkoul, robh+dt, krzysztof.kozlowski+dt, shawnguo,
s.hauer, kernel, festevam, linux-imx, balbi, gregkh, linux-phy,
devicetree, linux-arm-kernel, linux-kernel, linux-usb, imx
According to spec:
0000 +19.95%
....
1111 -21.68%
45 * (1 + 19.95%) = 53.9775
45 * (1 - 21.68%) = 35.244
Fix MXS_PHY_TX_CAL45_MIN from 30 to 35
Fix MXS_PHY_TX_CAL45_MAX from 55 to 54
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/usb/phy/phy-mxs-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index 9292d8e4e92a5..f909741641ec3 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy-mxs-usb.c
@@ -193,8 +193,8 @@
#define MXS_PHY_NEED_IP_FIX BIT(3)
/* Minimum and maximum values for device tree entries */
-#define MXS_PHY_TX_CAL45_MIN 30
-#define MXS_PHY_TX_CAL45_MAX 55
+#define MXS_PHY_TX_CAL45_MIN 35
+#define MXS_PHY_TX_CAL45_MAX 54
#define MXS_PHY_TX_D_CAL_MIN 79
#define MXS_PHY_TX_D_CAL_MAX 119
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/2] doc: dt-binding: mxs-usb-phy: fix fsl,tx-cal-45-dn-ohms max and min value
2022-08-29 15:31 [PATCH v1 1/2] doc: dt-binding: mxs-usb-phy: fix fsl,tx-cal-45-dn-ohms max and min value Frank Li
2022-08-29 15:31 ` [PATCH v1 2/2] usb: phy: mxs: fix MXS_PHY_TX_CAL45_MIN and MXS_PHY_TX_CAL45_MAX Frank Li
@ 2022-08-30 9:44 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-30 9:44 UTC (permalink / raw)
To: Frank Li, kishon, vkoul, robh+dt, krzysztof.kozlowski+dt,
shawnguo, s.hauer, kernel, festevam, linux-imx, balbi, gregkh,
linux-phy, devicetree, linux-arm-kernel, linux-kernel, linux-usb,
imx
On 29/08/2022 18:31, Frank Li wrote:
> According to spec:
> 0000 +19.95%
> ....
> 1111 -21.68%
>
> 45 * (1 + 19.95%) = 53.9775
> 45 * (1 - 21.68%) = 35.244
>
> Chanege fsl,tx-cal-45-dn-ohms and fsl,tx-cal-45-dp-ohms range to [35-54]
> from [30-55]
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-30 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 15:31 [PATCH v1 1/2] doc: dt-binding: mxs-usb-phy: fix fsl,tx-cal-45-dn-ohms max and min value Frank Li
2022-08-29 15:31 ` [PATCH v1 2/2] usb: phy: mxs: fix MXS_PHY_TX_CAL45_MIN and MXS_PHY_TX_CAL45_MAX Frank Li
2022-08-30 9:44 ` [PATCH v1 1/2] doc: dt-binding: mxs-usb-phy: fix fsl,tx-cal-45-dn-ohms max and min value Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).