* [Intel-gfx] [PATCH] drm/i915: Avoid potential division-by-zero in computing CS timestamp period
@ 2020-02-16 16:17 Chris Wilson
2020-02-16 17:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Chris Wilson @ 2020-02-16 16:17 UTC (permalink / raw)
To: intel-gfx
Since we use a HW readback or estimation of the CS timestamp frequency,
sometimes it may result in 0. Avoid the division-by-zero in computing
its reciprocal, the timestamp period.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_device_info.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index a97437fac884..18d9de488593 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -1044,13 +1044,17 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
}
/* Initialize command stream timestamp frequency */
- runtime->cs_timestamp_frequency_khz = read_timestamp_frequency(dev_priv);
- runtime->cs_timestamp_period_ns =
- div_u64(1e6, runtime->cs_timestamp_frequency_khz);
- drm_dbg(&dev_priv->drm,
- "CS timestamp wraparound in %lldms\n",
- div_u64(mul_u32_u32(runtime->cs_timestamp_period_ns, S32_MAX),
- USEC_PER_SEC));
+ runtime->cs_timestamp_frequency_khz =
+ read_timestamp_frequency(dev_priv);
+ if (runtime->cs_timestamp_frequency_khz) {
+ runtime->cs_timestamp_period_ns =
+ div_u64(1e6, runtime->cs_timestamp_frequency_khz);
+ drm_dbg(&dev_priv->drm,
+ "CS timestamp wraparound in %lldms\n",
+ div_u64(mul_u32_u32(runtime->cs_timestamp_period_ns,
+ S32_MAX),
+ USEC_PER_SEC));
+ }
}
void intel_driver_caps_print(const struct intel_driver_caps *caps,
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid potential division-by-zero in computing CS timestamp period
2020-02-16 16:17 [Intel-gfx] [PATCH] drm/i915: Avoid potential division-by-zero in computing CS timestamp period Chris Wilson
@ 2020-02-16 17:14 ` Patchwork
2020-02-18 21:44 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-02-18 21:54 ` [Intel-gfx] [PATCH] " Lionel Landwerlin
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-02-16 17:14 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Avoid potential division-by-zero in computing CS timestamp period
URL : https://patchwork.freedesktop.org/series/73506/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7950 -> Patchwork_16590
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16590:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live_gt_lrc:
- {fi-tgl-dsi}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/fi-tgl-dsi/igt@i915_selftest@live_gt_lrc.html
Known issues
------------
Here are the changes found in Patchwork_16590 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gtt:
- fi-bxt-dsi: [PASS][2] -> [TIMEOUT][3] ([fdo#112271])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/fi-bxt-dsi/igt@i915_selftest@live_gtt.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/fi-bxt-dsi/igt@i915_selftest@live_gtt.html
* igt@i915_selftest@live_hangcheck:
- fi-icl-u3: [PASS][4] -> [INCOMPLETE][5] ([fdo#108569])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
Participating hosts (40 -> 43)
------------------------------
Additional (9): fi-hsw-peppy fi-ilk-650 fi-snb-2520m fi-ivb-3770 fi-bsw-kefka fi-blb-e6850 fi-byt-n2820 fi-skl-6700k2 fi-kbl-r
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-ctg-p8600 fi-gdg-551 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7950 -> Patchwork_16590
CI-20190529: 20190529
CI_DRM_7950: eebe6906446d83547d0a3f29ffa3f124a8971b40 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5444: c46bae259d427f53fcfcd5f05de0181a9e82d6fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16590: b82aca351b49349019c6bb4e08f3e148bb5b77a7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b82aca351b49 drm/i915: Avoid potential division-by-zero in computing CS timestamp period
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Avoid potential division-by-zero in computing CS timestamp period
2020-02-16 16:17 [Intel-gfx] [PATCH] drm/i915: Avoid potential division-by-zero in computing CS timestamp period Chris Wilson
2020-02-16 17:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-02-18 21:44 ` Patchwork
2020-02-18 21:54 ` [Intel-gfx] [PATCH] " Lionel Landwerlin
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-02-18 21:44 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Avoid potential division-by-zero in computing CS timestamp period
URL : https://patchwork.freedesktop.org/series/73506/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7950_full -> Patchwork_16590_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_16590_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_shared@exec-shared-gtt-render:
- shard-tglb: [PASS][1] -> [FAIL][2] ([i915#607] / [i915#616])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-tglb7/igt@gem_ctx_shared@exec-shared-gtt-render.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-tglb1/igt@gem_ctx_shared@exec-shared-gtt-render.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110841])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_balancer@hang:
- shard-tglb: [PASS][5] -> [TIMEOUT][6] ([fdo#112271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-tglb1/igt@gem_exec_balancer@hang.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-tglb3/igt@gem_exec_balancer@hang.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110854])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb4/igt@gem_exec_balancer@smoke.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb8/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@pi-ringfull-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb3/igt@gem_exec_schedule@pi-ringfull-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb2/igt@gem_exec_schedule@pi-ringfull-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +21 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd1.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_partial_pwrite_pread@write-display:
- shard-hsw: [PASS][13] -> [FAIL][14] ([i915#694])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-hsw1/igt@gem_partial_pwrite_pread@write-display.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-hsw7/igt@gem_partial_pwrite_pread@write-display.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870] / [i915#836])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-skl7/igt@gem_userptr_blits@sync-unmap-after-close.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-skl4/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-kbl6/igt@gem_workarounds@suspend-resume-fd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-kbl7/igt@gem_workarounds@suspend-resume-fd.html
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-hsw: [PASS][19] -> [INCOMPLETE][20] ([i915#151] / [i915#61])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-hsw1/igt@i915_pm_rpm@system-suspend-modeset.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-hsw5/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#72])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-glk6/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-glk8/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#79])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [PASS][27] -> [INCOMPLETE][28] ([i915#221])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-skl8/igt@kms_flip@flip-vs-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-skl5/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#34])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-skl9/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-skl2/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
- shard-glk: [PASS][31] -> [FAIL][32] ([i915#49])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt:
- shard-tglb: [PASS][33] -> [SKIP][34] ([i915#668]) +6 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][35] -> [INCOMPLETE][36] ([i915#123] / [i915#69])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-skl5/igt@kms_frontbuffer_tracking@psr-suspend.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-skl8/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-glk: [PASS][37] -> [FAIL][38] ([i915#899])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-glk1/igt@kms_plane_lowres@pipe-a-tiling-y.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-glk1/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb7/igt@kms_psr@psr2_primary_page_flip.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#112080]) +12 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb8/igt@perf_pmu@busy-no-semaphores-vcs1.html
#### Possible fixes ####
* {igt@gem_ctx_persistence@close-replace-race}:
- shard-skl: [FAIL][43] ([i915#1241]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-skl3/igt@gem_ctx_persistence@close-replace-race.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-skl4/igt@gem_ctx_persistence@close-replace-race.html
* igt@gem_exec_balancer@hang:
- shard-iclb: [FAIL][45] -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb4/igt@gem_exec_balancer@hang.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb2/igt@gem_exec_balancer@hang.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][47] ([fdo#112146]) -> [PASS][48] +6 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_linear_blits@normal:
- shard-hsw: [FAIL][49] ([i915#694]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-hsw8/igt@gem_linear_blits@normal.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-hsw2/igt@gem_linear_blits@normal.html
* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [FAIL][51] ([i915#447]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb1/igt@i915_pm_dc@dc5-dpms.html
* igt@kms_cursor_legacy@nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [FAIL][53] ([i915#67]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-glk7/igt@kms_cursor_legacy@nonblocking-modeset-vs-cursor-atomic.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-glk3/igt@kms_cursor_legacy@nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][55] ([i915#79]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [DMESG-WARN][57] ([i915#180]) -> [PASS][58] +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html
- shard-hsw: [INCOMPLETE][59] ([i915#61]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-hsw5/igt@kms_flip@flip-vs-suspend-interruptible.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-hsw7/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [SKIP][61] ([i915#668]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* {igt@kms_hdr@bpc-switch-dpms}:
- shard-skl: [FAIL][63] ([i915#1188]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: [DMESG-WARN][65] ([i915#180]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][67] ([fdo#108145] / [i915#265]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][69] ([fdo#109642] / [fdo#111068]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb5/igt@kms_psr2_su@frontbuffer.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@perf@short-reads:
- shard-apl: [TIMEOUT][73] ([fdo#112271] / [i915#51]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-apl4/igt@perf@short-reads.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-apl1/igt@perf@short-reads.html
* igt@perf_pmu@init-busy-vcs1:
- shard-iclb: [SKIP][75] ([fdo#112080]) -> [PASS][76] +18 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb3/igt@perf_pmu@init-busy-vcs1.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb2/igt@perf_pmu@init-busy-vcs1.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][77] ([fdo#109276]) -> [PASS][78] +22 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb5/igt@prime_vgem@fence-wait-bsd2.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][79] ([IGT#28]) -> [SKIP][80] ([fdo#112080])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [SKIP][81] ([fdo#112080]) -> [FAIL][82] ([IGT#28])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
* igt@gem_tiled_blits@normal:
- shard-hsw: [FAIL][83] ([i915#818]) -> [FAIL][84] ([i915#694]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-hsw1/igt@gem_tiled_blits@normal.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-hsw4/igt@gem_tiled_blits@normal.html
* igt@runner@aborted:
- shard-skl: [FAIL][85] ([i915#69] / [i915#974]) -> ([FAIL][86], [FAIL][87]) ([fdo#111870] / [i915#69] / [i915#974])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7950/shard-skl8/igt@runner@aborted.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-skl4/igt@runner@aborted.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/shard-skl7/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1241]: https://gitlab.freedesktop.org/drm/intel/issues/1241
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#447]: https://gitlab.freedesktop.org/drm/intel/issues/447
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51
[i915#607]: https://gitlab.freedesktop.org/drm/intel/issues/607
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#616]: https://gitlab.freedesktop.org/drm/intel/issues/616
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#67]: https://gitlab.freedesktop.org/drm/intel/issues/67
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818
[i915#836]: https://gitlab.freedesktop.org/drm/intel/issues/836
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
[i915#974]: https://gitlab.freedesktop.org/drm/intel/issues/974
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7950 -> Patchwork_16590
CI-20190529: 20190529
CI_DRM_7950: eebe6906446d83547d0a3f29ffa3f124a8971b40 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5444: c46bae259d427f53fcfcd5f05de0181a9e82d6fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16590: b82aca351b49349019c6bb4e08f3e148bb5b77a7 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16590/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Avoid potential division-by-zero in computing CS timestamp period
2020-02-16 16:17 [Intel-gfx] [PATCH] drm/i915: Avoid potential division-by-zero in computing CS timestamp period Chris Wilson
2020-02-16 17:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-18 21:44 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2020-02-18 21:54 ` Lionel Landwerlin
2020-02-18 22:03 ` Chris Wilson
2 siblings, 1 reply; 6+ messages in thread
From: Lionel Landwerlin @ 2020-02-18 21:54 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 16/02/2020 18:17, Chris Wilson wrote:
> Since we use a HW readback or estimation of the CS timestamp frequency,
> sometimes it may result in 0. Avoid the division-by-zero in computing
> its reciprocal, the timestamp period.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_device_info.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index a97437fac884..18d9de488593 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -1044,13 +1044,17 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
> }
>
> /* Initialize command stream timestamp frequency */
> - runtime->cs_timestamp_frequency_khz = read_timestamp_frequency(dev_priv);
> - runtime->cs_timestamp_period_ns =
> - div_u64(1e6, runtime->cs_timestamp_frequency_khz);
> - drm_dbg(&dev_priv->drm,
> - "CS timestamp wraparound in %lldms\n",
> - div_u64(mul_u32_u32(runtime->cs_timestamp_period_ns, S32_MAX),
> - USEC_PER_SEC));
> + runtime->cs_timestamp_frequency_khz =
> + read_timestamp_frequency(dev_priv);
> + if (runtime->cs_timestamp_frequency_khz) {
> + runtime->cs_timestamp_period_ns =
> + div_u64(1e6, runtime->cs_timestamp_frequency_khz);
> + drm_dbg(&dev_priv->drm,
> + "CS timestamp wraparound in %lldms\n",
> + div_u64(mul_u32_u32(runtime->cs_timestamp_period_ns,
> + S32_MAX),
> + USEC_PER_SEC));
> + }
Arg this is used in i915-perf in at least one place as denominator too...
-Lionel
> }
>
> void intel_driver_caps_print(const struct intel_driver_caps *caps,
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Avoid potential division-by-zero in computing CS timestamp period
2020-02-18 21:54 ` [Intel-gfx] [PATCH] " Lionel Landwerlin
@ 2020-02-18 22:03 ` Chris Wilson
2020-02-18 22:10 ` Lionel Landwerlin
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2020-02-18 22:03 UTC (permalink / raw)
To: Lionel Landwerlin, intel-gfx
Quoting Lionel Landwerlin (2020-02-18 21:54:03)
> On 16/02/2020 18:17, Chris Wilson wrote:
> > Since we use a HW readback or estimation of the CS timestamp frequency,
> > sometimes it may result in 0. Avoid the division-by-zero in computing
> > its reciprocal, the timestamp period.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > drivers/gpu/drm/i915/intel_device_info.c | 18 +++++++++++-------
> > 1 file changed, 11 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> > index a97437fac884..18d9de488593 100644
> > --- a/drivers/gpu/drm/i915/intel_device_info.c
> > +++ b/drivers/gpu/drm/i915/intel_device_info.c
> > @@ -1044,13 +1044,17 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
> > }
> >
> > /* Initialize command stream timestamp frequency */
> > - runtime->cs_timestamp_frequency_khz = read_timestamp_frequency(dev_priv);
> > - runtime->cs_timestamp_period_ns =
> > - div_u64(1e6, runtime->cs_timestamp_frequency_khz);
> > - drm_dbg(&dev_priv->drm,
> > - "CS timestamp wraparound in %lldms\n",
> > - div_u64(mul_u32_u32(runtime->cs_timestamp_period_ns, S32_MAX),
> > - USEC_PER_SEC));
> > + runtime->cs_timestamp_frequency_khz =
> > + read_timestamp_frequency(dev_priv);
> > + if (runtime->cs_timestamp_frequency_khz) {
> > + runtime->cs_timestamp_period_ns =
> > + div_u64(1e6, runtime->cs_timestamp_frequency_khz);
> > + drm_dbg(&dev_priv->drm,
> > + "CS timestamp wraparound in %lldms\n",
> > + div_u64(mul_u32_u32(runtime->cs_timestamp_period_ns,
> > + S32_MAX),
> > + USEC_PER_SEC));
> > + }
>
> Arg this is used in i915-perf in at least one place as denominator too...
This was a quick fix for BAT. See
https://patchwork.freedesktop.org/patch/353455/?series=73507&rev=1
then there are only a handful of platforms for which we don't know the
frequency, none of which matter for i915-perf.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Avoid potential division-by-zero in computing CS timestamp period
2020-02-18 22:03 ` Chris Wilson
@ 2020-02-18 22:10 ` Lionel Landwerlin
0 siblings, 0 replies; 6+ messages in thread
From: Lionel Landwerlin @ 2020-02-18 22:10 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 19/02/2020 00:03, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2020-02-18 21:54:03)
>> On 16/02/2020 18:17, Chris Wilson wrote:
>>> Since we use a HW readback or estimation of the CS timestamp frequency,
>>> sometimes it may result in 0. Avoid the division-by-zero in computing
>>> its reciprocal, the timestamp period.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>> drivers/gpu/drm/i915/intel_device_info.c | 18 +++++++++++-------
>>> 1 file changed, 11 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
>>> index a97437fac884..18d9de488593 100644
>>> --- a/drivers/gpu/drm/i915/intel_device_info.c
>>> +++ b/drivers/gpu/drm/i915/intel_device_info.c
>>> @@ -1044,13 +1044,17 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
>>> }
>>>
>>> /* Initialize command stream timestamp frequency */
>>> - runtime->cs_timestamp_frequency_khz = read_timestamp_frequency(dev_priv);
>>> - runtime->cs_timestamp_period_ns =
>>> - div_u64(1e6, runtime->cs_timestamp_frequency_khz);
>>> - drm_dbg(&dev_priv->drm,
>>> - "CS timestamp wraparound in %lldms\n",
>>> - div_u64(mul_u32_u32(runtime->cs_timestamp_period_ns, S32_MAX),
>>> - USEC_PER_SEC));
>>> + runtime->cs_timestamp_frequency_khz =
>>> + read_timestamp_frequency(dev_priv);
>>> + if (runtime->cs_timestamp_frequency_khz) {
>>> + runtime->cs_timestamp_period_ns =
>>> + div_u64(1e6, runtime->cs_timestamp_frequency_khz);
>>> + drm_dbg(&dev_priv->drm,
>>> + "CS timestamp wraparound in %lldms\n",
>>> + div_u64(mul_u32_u32(runtime->cs_timestamp_period_ns,
>>> + S32_MAX),
>>> + USEC_PER_SEC));
>>> + }
>> Arg this is used in i915-perf in at least one place as denominator too...
> This was a quick fix for BAT. See
> https://patchwork.freedesktop.org/patch/353455/?series=73507&rev=1
> then there are only a handful of platforms for which we don't know the
> frequency, none of which matter for i915-perf.
> -Chris
Ah, you got me worried :)
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-18 22:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-16 16:17 [Intel-gfx] [PATCH] drm/i915: Avoid potential division-by-zero in computing CS timestamp period Chris Wilson
2020-02-16 17:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-18 21:44 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-02-18 21:54 ` [Intel-gfx] [PATCH] " Lionel Landwerlin
2020-02-18 22:03 ` Chris Wilson
2020-02-18 22:10 ` Lionel Landwerlin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).