intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Paul Menzel <paulepanter@users.sourceforge.net>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915/tv: Remember the detected TV type
Date: Tue, 12 Apr 2011 10:34:41 +0200	[thread overview]
Message-ID: <1302597281.4323.21.camel@mattotaupa> (raw)
In-Reply-To: <1302587499-9962-2-git-send-email-chris@chris-wilson.co.uk>


[-- Attachment #1.1: Type: text/plain, Size: 1177 bytes --]

Am Dienstag, den 12.04.2011, 06:51 +0100 schrieb Chris Wilson:
> From: Mathew McKernan <matmckernan@rauland.com.au>
> 
> During detect() we would probe the connection bits to determine if
> there was a TV attached, and what video input type (Component, S-Video,
> Composite, etc) to use. However, we promptly discarded this vital bit of
> information and never propagated it to where it was used to determine
> the correct modes and setup the control registers. Fix it!
> 
> This fixes a regression from 7b334fcb45b757ffb093696ca3de1b0c8b4a33f1.

To quote Mark Brown [1].

        Always include the subject line of the commit in patches -
        readers are unlikely to have memorised commit IDs.

> Reported-and-tested-by: Mathew McKernan <matmckernan@rauland.com.au>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=35977
> Signed-off-by: Mathew McKernan <matmckernan@rauland.com.au>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@kernel.org

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

[…]


Thanks,

Paul


[1] http://mailman.alsa-project.org/pipermail/alsa-devel/2011-February/037200.html

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2011-04-12  8:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  5:51 i915 TV fixes Chris Wilson
2011-04-12  5:51 ` [PATCH 1/3] drm/i915/tv: Remember the detected TV type Chris Wilson
2011-04-12  8:34   ` Paul Menzel [this message]
2011-04-12  8:43     ` Chris Wilson
2011-04-12  9:21       ` Paul Menzel
2011-04-12  5:51 ` [PATCH 2/3] drm/i915/tv: Only poll for TV connections Chris Wilson
2011-04-12  5:51 ` [PATCH 3/3] drm/i915/tv: Fix modeset flickering introduced in 7f58aabc3 Chris Wilson
2011-04-12 15:16   ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302597281.4323.21.camel@mattotaupa \
    --to=paulepanter@users.sourceforge.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).