From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/2] drm/i915: Prefault all pages for pread and pwrite
Date: Sat, 9 Jul 2011 09:38:50 +0100 [thread overview]
Message-ID: <1310200731-18086-1-git-send-email-chris@chris-wilson.co.uk> (raw)
When using a GTT mapping as a source or destination for the pwrite or
pread command respectively, unless the PTEs for the GTT vma had been
prepopulated then get_user_pages() would fail with EFAULT. Usually, we
only write small amounts of data with pwrite that happened to be
conveniently prefaulted by the 2-page fault_in_pages_readable. By
prefaulting all pages before we take the struct mutex, we avoid this
issue, can stay in the fast path longer and reduce the likelihood of a
recursive deadlock.
"Fixes" gem_mmap_gtt.
References: https://bugs.freedesktop.org/show_bug.cgi?id=38115
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gem.c | 34 ++++++++++++++++++++++++++++++----
1 files changed, 30 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 4fc9738..2fce620 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -503,6 +503,19 @@ out:
return ret;
}
+static int prefault_writeable(unsigned long uaddr, unsigned long len)
+{
+ int ret = 0;
+
+ len += uaddr;
+ while (uaddr < len) {
+ ret |= __put_user(0, (char __user *)uaddr);
+ uaddr += 4096;
+ }
+
+ return ret ? -EFAULT : 0;
+}
+
/**
* Reads data from the object referenced by handle.
*
@@ -524,8 +537,7 @@ i915_gem_pread_ioctl(struct drm_device *dev, void *data,
args->size))
return -EFAULT;
- ret = fault_in_pages_writeable((char __user *)(uintptr_t)args->data_ptr,
- args->size);
+ ret = prefault_writeable(args->data_ptr, args->size);
if (ret)
return -EFAULT;
@@ -943,6 +955,21 @@ out:
return ret;
}
+static int prefault_readable(unsigned long uaddr, unsigned long len)
+{
+ volatile char c;
+ int ret = 0;
+
+ len += uaddr;
+ while (uaddr < len) {
+ ret |= __get_user(c, (const char __user *)uaddr);
+ uaddr += 4096;
+ }
+
+ return ret ? -EFAULT : 0;
+ (void)c;
+}
+
/**
* Writes data to the object referenced by handle.
*
@@ -964,8 +991,7 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data,
args->size))
return -EFAULT;
- ret = fault_in_pages_readable((char __user *)(uintptr_t)args->data_ptr,
- args->size);
+ ret = prefault_readable(args->data_ptr, args->size);
if (ret)
return -EFAULT;
--
1.7.5.4
next reply other threads:[~2011-07-09 8:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 8:38 Chris Wilson [this message]
2011-07-09 8:38 ` [PATCH 2/2] drm/i915: Disable page-faults around the fast pwrite/pread paths Chris Wilson
2011-07-09 14:41 ` Eric Anholt
2011-07-09 17:40 ` Chris Wilson
2011-07-09 20:24 ` Keith Packard
2011-07-09 20:50 ` Chris Wilson
2011-07-09 21:06 ` Keith Packard
2011-07-09 21:23 ` Chris Wilson
2011-07-09 22:07 ` Keith Packard
2011-07-11 16:51 ` Chris Wilson
2011-07-11 19:55 ` Keith Packard
2011-07-10 18:45 ` Eric Anholt
2011-07-10 20:29 ` Keith Packard
2011-07-09 20:21 ` [PATCH 1/2] drm/i915: Prefault all pages for pread and pwrite Keith Packard
2011-07-09 20:31 ` Chris Wilson
2011-07-10 1:40 ` Ben Widawsky
2011-07-10 8:08 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310200731-18086-1-git-send-email-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).