From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 2/2] drm/i915: Add simulator's host bridge
Date: Sat, 21 Jul 2012 10:42:13 +0100 [thread overview]
Message-ID: <1342863733_22403@CP5-2952> (raw)
In-Reply-To: <1342806210-4807-2-git-send-email-ben@bwidawsk.net>
On Fri, 20 Jul 2012 10:43:30 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> Add the host bridge ID used by the simulator. This was added in a
> previous patch for the agp layer, but wasn't preserved here. It also
> gives us an opportunity to let the rest of the driver know we're running
> as the simulator for various workarounds.
I like how minimal this looks, though it does worry me that is a little
too easy... (Not least the question why the simulator doesn't work with
forcewake... Doesn't that strike you as odd that we have rc6 bugs and
the simulator dies... ;-)
I think I would rather see this as an intel_info so that it can be
expanded upon simply for future/past simulators.
However, the fundamental question is do we ever ship simulators? If we
try to avoid carrying pre-production w/a, shouldn't that mean that we
don't even contemplate pushing simulator interfaces.
Having said, carrying these patches centrally does mean that will be
reviewed and kept in mind for future iterations.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-07-21 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 17:43 [PATCH 1/2] drm/i915: Give simulator a way to skip forcewake Ben Widawsky
2012-07-20 17:43 ` [PATCH 2/2] drm/i915: Add simulator's host bridge Ben Widawsky
2012-07-21 9:42 ` Chris Wilson [this message]
2012-07-21 14:52 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342863733_22403@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).