* [PATCH] drm/i915/selftests: Remove unused local variable 'file'
@ 2019-11-12 16:36 Chris Wilson
2019-11-12 16:36 ` [Intel-gfx] " Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Chris Wilson @ 2019-11-12 16:36 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld
drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:453 igt_threaded_blt() error: uninitialized symbol 'file'.
Fixes: 34485832cb98 ("drm/i915/selftests: Exercise parallel blit operations on a single ctx")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index c8a8c07e07ab..675c1a20a2f1 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -435,7 +435,6 @@ static int igt_threaded_blt(struct drm_i915_private *i915,
struct task_struct **tsk;
unsigned int n_cpus, i;
I915_RND_STATE(prng);
- struct file *file;
int err = 0;
n_cpus = num_online_cpus() + 1;
@@ -450,7 +449,7 @@ static int igt_threaded_blt(struct drm_i915_private *i915,
thread[0].file = mock_file(i915);
if (IS_ERR(thread[0].file)) {
- err = PTR_ERR(file);
+ err = PTR_ERR(thread[0].file);
goto out_thread;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/selftests: Remove unused local variable 'file'
2019-11-12 16:36 [PATCH] drm/i915/selftests: Remove unused local variable 'file' Chris Wilson
@ 2019-11-12 16:36 ` Chris Wilson
2019-11-12 16:42 ` Matthew Auld
2019-11-12 21:37 ` ✗ Fi.CI.BAT: failure for " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-11-12 16:36 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld
drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:453 igt_threaded_blt() error: uninitialized symbol 'file'.
Fixes: 34485832cb98 ("drm/i915/selftests: Exercise parallel blit operations on a single ctx")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index c8a8c07e07ab..675c1a20a2f1 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -435,7 +435,6 @@ static int igt_threaded_blt(struct drm_i915_private *i915,
struct task_struct **tsk;
unsigned int n_cpus, i;
I915_RND_STATE(prng);
- struct file *file;
int err = 0;
n_cpus = num_online_cpus() + 1;
@@ -450,7 +449,7 @@ static int igt_threaded_blt(struct drm_i915_private *i915,
thread[0].file = mock_file(i915);
if (IS_ERR(thread[0].file)) {
- err = PTR_ERR(file);
+ err = PTR_ERR(thread[0].file);
goto out_thread;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/selftests: Remove unused local variable 'file'
2019-11-12 16:36 [PATCH] drm/i915/selftests: Remove unused local variable 'file' Chris Wilson
2019-11-12 16:36 ` [Intel-gfx] " Chris Wilson
@ 2019-11-12 16:42 ` Matthew Auld
2019-11-12 16:42 ` [Intel-gfx] " Matthew Auld
2019-11-12 21:37 ` ✗ Fi.CI.BAT: failure for " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Matthew Auld @ 2019-11-12 16:42 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 12/11/2019 16:36, Chris Wilson wrote:
> drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:453 igt_threaded_blt() error: uninitialized symbol 'file'.
>
> Fixes: 34485832cb98 ("drm/i915/selftests: Exercise parallel blit operations on a single ctx")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Remove unused local variable 'file'
2019-11-12 16:42 ` Matthew Auld
@ 2019-11-12 16:42 ` Matthew Auld
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Auld @ 2019-11-12 16:42 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 12/11/2019 16:36, Chris Wilson wrote:
> drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:453 igt_threaded_blt() error: uninitialized symbol 'file'.
>
> Fixes: 34485832cb98 ("drm/i915/selftests: Exercise parallel blit operations on a single ctx")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/selftests: Remove unused local variable 'file'
2019-11-12 16:36 [PATCH] drm/i915/selftests: Remove unused local variable 'file' Chris Wilson
2019-11-12 16:36 ` [Intel-gfx] " Chris Wilson
2019-11-12 16:42 ` Matthew Auld
@ 2019-11-12 21:37 ` Patchwork
2019-11-12 21:37 ` [Intel-gfx] " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2019-11-12 21:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Remove unused local variable 'file'
URL : https://patchwork.freedesktop.org/series/69365/
State : failure
== Summary ==
Applying: drm/i915/selftests: Remove unused local variable 'file'
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Remove unused local variable 'file'
2019-11-12 21:37 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2019-11-12 21:37 ` Patchwork
0 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-11-12 21:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Remove unused local variable 'file'
URL : https://patchwork.freedesktop.org/series/69365/
State : failure
== Summary ==
Applying: drm/i915/selftests: Remove unused local variable 'file'
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-12 21:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 16:36 [PATCH] drm/i915/selftests: Remove unused local variable 'file' Chris Wilson
2019-11-12 16:36 ` [Intel-gfx] " Chris Wilson
2019-11-12 16:42 ` Matthew Auld
2019-11-12 16:42 ` [Intel-gfx] " Matthew Auld
2019-11-12 21:37 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-11-12 21:37 ` [Intel-gfx] " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).