* [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes @ 2020-01-16 21:16 Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 1/5] drm/i915: Fix eDP DPCD aux max backlight calculations Lyude Paul ` (10 more replies) 0 siblings, 11 replies; 17+ messages in thread From: Lyude Paul @ 2020-01-16 21:16 UTC (permalink / raw) To: intel-gfx; +Cc: David Airlie, linux-kernel, dri-devel I recently got a ThinkPad X1 Extreme 2nd Generation for fixing some issues on, and noticed that out of the box the backlight doesn't work. Along the way of fixing that, I found a few issues with how i915 handles DPCD AUX backlight control and fixed them. Now I've got working backlight controls, hooray! Note that this patch series enables DPCD backlight controls by default. This time however, we ignore the backlight type advertised in the VBT (unless it's a custom backlight interface that doesn't use the standard VESA interface over AUX) and just trust the DPCD. Lyude Paul (5): drm/i915: Fix eDP DPCD aux max backlight calculations drm/i915: Assume 100% brightness when not in DPCD control mode drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() drm/i915: Don't use VBT for detecting DPCD backlight controls drm/i915: Auto detect DPCD backlight support by default .../drm/i915/display/intel_display_types.h | 3 + .../drm/i915/display/intel_dp_aux_backlight.c | 175 ++++++++++++------ drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 4 files changed, 126 insertions(+), 56 deletions(-) -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH v3 1/5] drm/i915: Fix eDP DPCD aux max backlight calculations 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul @ 2020-01-16 21:16 ` Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 2/5] drm/i915: Assume 100% brightness when not in DPCD control mode Lyude Paul ` (9 subsequent siblings) 10 siblings, 0 replies; 17+ messages in thread From: Lyude Paul @ 2020-01-16 21:16 UTC (permalink / raw) To: intel-gfx Cc: Furquan Shaikh, David Airlie, linux-kernel, AceLan Kao, dri-devel, Perry Yuan Max backlight value for the panel was being calculated using byte count i.e. 0xffff if 2 bytes are supported for backlight brightness and 0xff if 1 byte is supported. However, EDP_PWMGEN_BIT_COUNT determines the number of active control bits used for the brightness setting. Thus, even if the panel uses 2 byte setting, it might not use all the control bits. Thus, max backlight should be set based on the value of EDP_PWMGEN_BIT_COUNT instead of assuming 65535 or 255. Additionally, EDP_PWMGEN_BIT_COUNT was being updated based on the VBT frequency which results in a different max backlight value. Thus, setting of EDP_PWMGEN_BIT_COUNT is moved to setup phase instead of enable so that max backlight can be calculated correctly. Only the frequency divider is set during the enable phase using the value of EDP_PWMGEN_BIT_COUNT. This is based off the original patch series from Furquan Shaikh <furquan@google.com>: https://patchwork.freedesktop.org/patch/317255/?series=62326&rev=3 Changes since original patch: * Remove unused intel_dp variable in intel_dp_aux_setup_backlight() * Fix checkpatch issues * Make sure that we rewrite the pwmgen bit count whenever we bring the panel out of D3 mode v2 by Jani: * rebase * fix readb return value check Cc: Furquan Shaikh <furquan@google.com> Tested-by: AceLan Kao <acelan.kao@canonical.com> Tested-by: Perry Yuan <pyuan@redhat.com> Signed-off-by: Lyude Paul <lyude@redhat.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- .../drm/i915/display/intel_display_types.h | 3 + .../drm/i915/display/intel_dp_aux_backlight.c | 139 ++++++++++++------ 2 files changed, 95 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h index fdd943a17de3..155ce49ae764 100644 --- a/drivers/gpu/drm/i915/display/intel_display_types.h +++ b/drivers/gpu/drm/i915/display/intel_display_types.h @@ -214,6 +214,9 @@ struct intel_panel { u8 controller; /* bxt+ only */ struct pwm_device *pwm; + /* DPCD backlight */ + u8 pwmgen_bit_count; + struct backlight_device *device; /* Connector and platform specific backlight functions */ diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index 7c653f8c307f..345eed641455 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c @@ -111,61 +111,28 @@ static bool intel_dp_aux_set_pwm_freq(struct intel_connector *connector) { struct drm_i915_private *dev_priv = to_i915(connector->base.dev); struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder); - int freq, fxp, fxp_min, fxp_max, fxp_actual, f = 1; - u8 pn, pn_min, pn_max; + const u8 pn = connector->panel.backlight.pwmgen_bit_count; + int freq, fxp, f, fxp_actual, fxp_min, fxp_max; - /* Find desired value of (F x P) - * Note that, if F x P is out of supported range, the maximum value or - * minimum value will applied automatically. So no need to check that. - */ freq = dev_priv->vbt.backlight.pwm_freq_hz; - DRM_DEBUG_KMS("VBT defined backlight frequency %u Hz\n", freq); if (!freq) { DRM_DEBUG_KMS("Use panel default backlight frequency\n"); return false; } fxp = DIV_ROUND_CLOSEST(KHz(DP_EDP_BACKLIGHT_FREQ_BASE_KHZ), freq); + f = clamp(DIV_ROUND_CLOSEST(fxp, 1 << pn), 1, 255); + fxp_actual = f << pn; - /* Use highest possible value of Pn for more granularity of brightness - * adjustment while satifying the conditions below. - * - Pn is in the range of Pn_min and Pn_max - * - F is in the range of 1 and 255 - * - FxP is within 25% of desired value. - * Note: 25% is arbitrary value and may need some tweak. - */ - if (drm_dp_dpcd_readb(&intel_dp->aux, - DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN, &pn_min) != 1) { - DRM_DEBUG_KMS("Failed to read pwmgen bit count cap min\n"); - return false; - } - if (drm_dp_dpcd_readb(&intel_dp->aux, - DP_EDP_PWMGEN_BIT_COUNT_CAP_MAX, &pn_max) != 1) { - DRM_DEBUG_KMS("Failed to read pwmgen bit count cap max\n"); - return false; - } - pn_min &= DP_EDP_PWMGEN_BIT_COUNT_MASK; - pn_max &= DP_EDP_PWMGEN_BIT_COUNT_MASK; - + /* Ensure frequency is within 25% of desired value */ fxp_min = DIV_ROUND_CLOSEST(fxp * 3, 4); fxp_max = DIV_ROUND_CLOSEST(fxp * 5, 4); - if (fxp_min < (1 << pn_min) || (255 << pn_max) < fxp_max) { - DRM_DEBUG_KMS("VBT defined backlight frequency out of range\n"); - return false; - } - for (pn = pn_max; pn >= pn_min; pn--) { - f = clamp(DIV_ROUND_CLOSEST(fxp, 1 << pn), 1, 255); - fxp_actual = f << pn; - if (fxp_min <= fxp_actual && fxp_actual <= fxp_max) - break; - } - - if (drm_dp_dpcd_writeb(&intel_dp->aux, - DP_EDP_PWMGEN_BIT_COUNT, pn) < 0) { - DRM_DEBUG_KMS("Failed to write aux pwmgen bit count\n"); + if (fxp_min > fxp_actual || fxp_actual > fxp_max) { + DRM_DEBUG_KMS("Actual frequency out of range\n"); return false; } + if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_EDP_BACKLIGHT_FREQ_SET, (u8) f) < 0) { DRM_DEBUG_KMS("Failed to write aux backlight freq\n"); @@ -179,6 +146,7 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st { struct intel_connector *connector = to_intel_connector(conn_state->connector); struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder); + struct intel_panel *panel = &connector->panel; u8 dpcd_buf, new_dpcd_buf, edp_backlight_mode; if (drm_dp_dpcd_readb(&intel_dp->aux, @@ -197,6 +165,12 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st case DP_EDP_BACKLIGHT_CONTROL_MODE_PRODUCT: new_dpcd_buf &= ~DP_EDP_BACKLIGHT_CONTROL_MODE_MASK; new_dpcd_buf |= DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD; + + if (drm_dp_dpcd_writeb(&intel_dp->aux, + DP_EDP_PWMGEN_BIT_COUNT, + panel->backlight.pwmgen_bit_count) < 0) + DRM_DEBUG_KMS("Failed to write aux pwmgen bit count\n"); + break; /* Do nothing when it is already DPCD mode */ @@ -226,20 +200,91 @@ static void intel_dp_aux_disable_backlight(const struct drm_connector_state *old false); } +static u32 intel_dp_aux_calc_max_backlight(struct intel_connector *connector) +{ + struct drm_i915_private *i915 = to_i915(connector->base.dev); + struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder); + struct intel_panel *panel = &connector->panel; + u32 max_backlight = 0; + int freq, fxp, fxp_min, fxp_max, fxp_actual, f = 1; + u8 pn, pn_min, pn_max; + + if (drm_dp_dpcd_readb(&intel_dp->aux, DP_EDP_PWMGEN_BIT_COUNT, &pn) == 1) { + pn &= DP_EDP_PWMGEN_BIT_COUNT_MASK; + max_backlight = (1 << pn) - 1; + } + + /* Find desired value of (F x P) + * Note that, if F x P is out of supported range, the maximum value or + * minimum value will applied automatically. So no need to check that. + */ + freq = i915->vbt.backlight.pwm_freq_hz; + DRM_DEBUG_KMS("VBT defined backlight frequency %u Hz\n", freq); + if (!freq) { + DRM_DEBUG_KMS("Use panel default backlight frequency\n"); + return max_backlight; + } + + fxp = DIV_ROUND_CLOSEST(KHz(DP_EDP_BACKLIGHT_FREQ_BASE_KHZ), freq); + + /* Use highest possible value of Pn for more granularity of brightness + * adjustment while satifying the conditions below. + * - Pn is in the range of Pn_min and Pn_max + * - F is in the range of 1 and 255 + * - FxP is within 25% of desired value. + * Note: 25% is arbitrary value and may need some tweak. + */ + if (drm_dp_dpcd_readb(&intel_dp->aux, + DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN, &pn_min) != 1) { + DRM_DEBUG_KMS("Failed to read pwmgen bit count cap min\n"); + return max_backlight; + } + if (drm_dp_dpcd_readb(&intel_dp->aux, + DP_EDP_PWMGEN_BIT_COUNT_CAP_MAX, &pn_max) != 1) { + DRM_DEBUG_KMS("Failed to read pwmgen bit count cap max\n"); + return max_backlight; + } + pn_min &= DP_EDP_PWMGEN_BIT_COUNT_MASK; + pn_max &= DP_EDP_PWMGEN_BIT_COUNT_MASK; + + fxp_min = DIV_ROUND_CLOSEST(fxp * 3, 4); + fxp_max = DIV_ROUND_CLOSEST(fxp * 5, 4); + if (fxp_min < (1 << pn_min) || (255 << pn_max) < fxp_max) { + DRM_DEBUG_KMS("VBT defined backlight frequency out of range\n"); + return max_backlight; + } + + for (pn = pn_max; pn >= pn_min; pn--) { + f = clamp(DIV_ROUND_CLOSEST(fxp, 1 << pn), 1, 255); + fxp_actual = f << pn; + if (fxp_min <= fxp_actual && fxp_actual <= fxp_max) + break; + } + + DRM_DEBUG_KMS("Using eDP pwmgen bit count of %d\n", pn); + if (drm_dp_dpcd_writeb(&intel_dp->aux, + DP_EDP_PWMGEN_BIT_COUNT, pn) < 0) { + DRM_DEBUG_KMS("Failed to write aux pwmgen bit count\n"); + return max_backlight; + } + panel->backlight.pwmgen_bit_count = pn; + + max_backlight = (1 << pn) - 1; + + return max_backlight; +} + static int intel_dp_aux_setup_backlight(struct intel_connector *connector, enum pipe pipe) { - struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder); struct intel_panel *panel = &connector->panel; - if (intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_BYTE_COUNT) - panel->backlight.max = 0xFFFF; - else - panel->backlight.max = 0xFF; + panel->backlight.max = intel_dp_aux_calc_max_backlight(connector); + if (!panel->backlight.max) + return -ENODEV; panel->backlight.min = 0; panel->backlight.level = intel_dp_aux_get_backlight(connector); - panel->backlight.enabled = panel->backlight.level != 0; return 0; -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH v3 2/5] drm/i915: Assume 100% brightness when not in DPCD control mode 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 1/5] drm/i915: Fix eDP DPCD aux max backlight calculations Lyude Paul @ 2020-01-16 21:16 ` Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 3/5] drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() Lyude Paul ` (8 subsequent siblings) 10 siblings, 0 replies; 17+ messages in thread From: Lyude Paul @ 2020-01-16 21:16 UTC (permalink / raw) To: intel-gfx; +Cc: David Airlie, linux-kernel, AceLan Kao, dri-devel, Perry Yuan Currently we always determine the initial panel brightness level by simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This seems wrong though, because if the panel is not currently in DPCD control mode there's not really any reason why there would be any brightness value programmed in the first place. This appears to be the case on the Lenovo ThinkPad X1 Extreme 2nd Generation, where the default value in these registers is always 0 on boot despite the fact the panel runs at max brightness by default. Getting the initial brightness value correct here is important as well, since the panel on this laptop doesn't behave well if it's ever put into DPCD control mode while the brightness level is programmed to 0. So, let's fix this by checking what the current backlight control mode is before reading the brightness level. If it's in DPCD control mode, we return the programmed brightness level. Otherwise we assume 100% brightness and return the highest possible brightness level. This also prevents us from accidentally programming a brightness level of 0. This is one of the many fixes that gets backlight controls working on the ThinkPad X1 Extreme 2nd Generation with optional 4K AMOLED screen. Changes since v1: * s/DP_EDP_DISPLAY_CONTROL_REGISTER/DP_EDP_BACKLIGHT_MODE_SET_REGISTER/ - Jani Tested-by: AceLan Kao <acelan.kao@canonical.com> Tested-by: Perry Yuan <pyuan@redhat.com> Signed-off-by: Lyude Paul <lyude@redhat.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- .../drm/i915/display/intel_dp_aux_backlight.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index 345eed641455..5d4db5f8a165 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c @@ -59,8 +59,25 @@ static u32 intel_dp_aux_get_backlight(struct intel_connector *connector) { struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder); u8 read_val[2] = { 0x0 }; + u8 mode_reg; u16 level = 0; + if (drm_dp_dpcd_readb(&intel_dp->aux, + DP_EDP_BACKLIGHT_MODE_SET_REGISTER, + &mode_reg) != 1) { + DRM_DEBUG_KMS("Failed to read the DPCD register 0x%x\n", + DP_EDP_BACKLIGHT_MODE_SET_REGISTER); + return 0; + } + + /* + * If we're not in DPCD control mode yet, the programmed brightness + * value is meaningless and we should assume max brightness + */ + if ((mode_reg & DP_EDP_BACKLIGHT_CONTROL_MODE_MASK) != + DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD) + return connector->panel.backlight.max; + if (drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_BACKLIGHT_BRIGHTNESS_MSB, &read_val, sizeof(read_val)) < 0) { DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n", -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH v3 3/5] drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 1/5] drm/i915: Fix eDP DPCD aux max backlight calculations Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 2/5] drm/i915: Assume 100% brightness when not in DPCD control mode Lyude Paul @ 2020-01-16 21:16 ` Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls Lyude Paul ` (7 subsequent siblings) 10 siblings, 0 replies; 17+ messages in thread From: Lyude Paul @ 2020-01-16 21:16 UTC (permalink / raw) To: intel-gfx; +Cc: David Airlie, linux-kernel, AceLan Kao, dri-devel, Perry Yuan For eDP panels, it appears it's expected that so long as the panel is in DPCD control mode that the brightness value is never set to 0. Instead, if the desired effect is to set the panel's backlight to 0 we're expected to simply turn off the backlight through the DP_EDP_DISPLAY_CONTROL_REGISTER. We already do the latter correctly in intel_dp_aux_disable_backlight(). But, we make the mistake of writing the DPCD registers in the wrong order when enabling the backlight in intel_dp_aux_enable_backlight() since we currently enable the backlight through DP_EDP_DISPLAY_CONTROL_REGISTER before writing the brightness level. On the X1 Extreme 2nd Generation, this appears to have the potential of confusing the panel in such a way that further attempts to set the brightness don't actually change the backlight as expected and leave it off. Presumably, this happens because the incorrect register writing order briefly leaves the panel with DPCD mode enabled and a 0 brightness level set. So, reverse the order we write the DPCD registers when enabling the panel backlight so that we write the brightness value first, and enable the backlight second. This fix appears to be the final bit needed to get the backlight on the ThinkPad X1 Extreme 2nd Generation's AMOLED screen working. Tested-by: AceLan Kao <acelan.kao@canonical.com> Tested-by: Perry Yuan <pyuan@redhat.com> Signed-off-by: Lyude Paul <lyude@redhat.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index 5d4db5f8a165..77a759361c5c 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c @@ -207,8 +207,9 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st } } + intel_dp_aux_set_backlight(conn_state, + connector->panel.backlight.level); set_aux_backlight_enable(intel_dp, true); - intel_dp_aux_set_backlight(conn_state, connector->panel.backlight.level); } static void intel_dp_aux_disable_backlight(const struct drm_connector_state *old_conn_state) -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul ` (2 preceding siblings ...) 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 3/5] drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() Lyude Paul @ 2020-01-16 21:16 ` Lyude Paul 2020-01-17 11:36 ` Jani Nikula 2020-01-17 23:21 ` [Intel-gfx] [PATCH v4] " Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 5/5] drm/i915: Auto detect DPCD backlight support by default Lyude Paul ` (6 subsequent siblings) 10 siblings, 2 replies; 17+ messages in thread From: Lyude Paul @ 2020-01-16 21:16 UTC (permalink / raw) To: intel-gfx Cc: Jani Nikula, linux-kernel, David Airlie, AceLan Kao, dri-devel, Perry Yuan Despite the fact that the VBT appears to have a field for specifying that a system is equipped with a panel that supports standard VESA backlight controls over the DP AUX channel, so far every system we've spotted DPCD backlight control support on doesn't actually set this field correctly and all have it set to INTEL_BACKLIGHT_DISPLAY_DDI. While we don't know the exact reason for this VBT misuse, talking with some vendors indicated that there's a good number of laptop panels out there that supposedly support both PWM backlight controls and DPCD backlight controls as a workaround until Intel supports DPCD backlight controls across platforms universally. This being said, the X1 Extreme 2nd Gen that I have here (note that Lenovo is not the hardware vendor that informed us of this) PWM backlight controls are advertised, but only DPCD controls actually function. I'm going to make an educated guess here and say that on systems like this one, it's likely that PWM backlight controls might have been intended to work but were never really tested by QA. Since we really need backlights to work without any extra module parameters, let's take the risk here and rely on the standard DPCD caps to tell us whether AUX backlight controls are supported or not. We still check the VBT, but only to make sure that we don't enable DPCD backlight controls on a panel that uses something other then the standard VESA interfaces over AUX. Since panels using such non-standard interfaces should probably have support added to i915, we'll print a warning when seeing this in the VBT. We can remove this warning later if we end up adding support for any custom backlight interfaces. Signed-off-by: Lyude Paul <lyude@redhat.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112376 Cc: Jani Nikula <jani.nikula@intel.com> Cc: Perry Yuan <pyuan@redhat.com> Cc: AceLan Kao <acelan.kao@canonical.com> --- .../drm/i915/display/intel_dp_aux_backlight.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index 77a759361c5c..3002b600635f 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c @@ -330,13 +330,17 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector) struct intel_panel *panel = &intel_connector->panel; struct drm_i915_private *dev_priv = to_i915(intel_connector->base.dev); - if (i915_modparams.enable_dpcd_backlight == 0 || - (i915_modparams.enable_dpcd_backlight == -1 && - dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE)) - return -ENODEV; - - if (!intel_dp_aux_display_control_capable(intel_connector)) + if (i915_modparams.enable_dpcd_backlight == 0) return -ENODEV; + if (i915_modparams.enable_dpcd_backlight == -1) { + if (dev_priv->vbt.backlight.type + == INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE) { + DRM_WARN("VBT says panel uses custom panel driver interface, not using DPCD backlight controls\n"); + return -ENODEV; + } + if (!intel_dp_aux_display_control_capable(intel_connector)) + return -ENODEV; + } panel->backlight.setup = intel_dp_aux_setup_backlight; panel->backlight.enable = intel_dp_aux_enable_backlight; -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls Lyude Paul @ 2020-01-17 11:36 ` Jani Nikula 2020-01-17 11:47 ` Jani Nikula 2020-01-17 20:24 ` Lyude Paul 2020-01-17 23:21 ` [Intel-gfx] [PATCH v4] " Lyude Paul 1 sibling, 2 replies; 17+ messages in thread From: Jani Nikula @ 2020-01-17 11:36 UTC (permalink / raw) To: Lyude Paul, intel-gfx Cc: David Airlie, linux-kernel, dri-devel, AceLan Kao, Perry Yuan On Thu, 16 Jan 2020, Lyude Paul <lyude@redhat.com> wrote: > Despite the fact that the VBT appears to have a field for specifying > that a system is equipped with a panel that supports standard VESA > backlight controls over the DP AUX channel, so far every system we've > spotted DPCD backlight control support on doesn't actually set this > field correctly and all have it set to INTEL_BACKLIGHT_DISPLAY_DDI. > > While we don't know the exact reason for this VBT misuse, talking with > some vendors indicated that there's a good number of laptop panels out > there that supposedly support both PWM backlight controls and DPCD > backlight controls as a workaround until Intel supports DPCD backlight > controls across platforms universally. This being said, the X1 Extreme > 2nd Gen that I have here (note that Lenovo is not the hardware vendor > that informed us of this) PWM backlight controls are advertised, but > only DPCD controls actually function. I'm going to make an educated > guess here and say that on systems like this one, it's likely that PWM > backlight controls might have been intended to work but were never > really tested by QA. > > Since we really need backlights to work without any extra module > parameters, let's take the risk here and rely on the standard DPCD caps > to tell us whether AUX backlight controls are supported or not. We still > check the VBT, but only to make sure that we don't enable DPCD backlight > controls on a panel that uses something other then the standard VESA > interfaces over AUX. Since panels using such non-standard interfaces > should probably have support added to i915, we'll print a warning when > seeing this in the VBT. We can remove this warning later if we end up > adding support for any custom backlight interfaces. > > Signed-off-by: Lyude Paul <lyude@redhat.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112376 > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Perry Yuan <pyuan@redhat.com> > Cc: AceLan Kao <acelan.kao@canonical.com> > --- > .../drm/i915/display/intel_dp_aux_backlight.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > index 77a759361c5c..3002b600635f 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > @@ -330,13 +330,17 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector) > struct intel_panel *panel = &intel_connector->panel; > struct drm_i915_private *dev_priv = to_i915(intel_connector->base.dev); > > - if (i915_modparams.enable_dpcd_backlight == 0 || > - (i915_modparams.enable_dpcd_backlight == -1 && > - dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE)) > - return -ENODEV; > - > - if (!intel_dp_aux_display_control_capable(intel_connector)) > + if (i915_modparams.enable_dpcd_backlight == 0) > return -ENODEV; > + if (i915_modparams.enable_dpcd_backlight == -1) { > + if (dev_priv->vbt.backlight.type > + == INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE) { > + DRM_WARN("VBT says panel uses custom panel driver interface, not using DPCD backlight controls\n"); > + return -ENODEV; > + } > + if (!intel_dp_aux_display_control_capable(intel_connector)) > + return -ENODEV; Functionally, I'm fine with trying this. But perhaps we should check aux and early return first, and then check what vbt says, to reduce the dmesg noise. I'll probably want to see a debug message if we're enabling aux backlight even if dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE. It's the kind of debug trace you'll really want to get first. BR, Jani. > + } > > panel->backlight.setup = intel_dp_aux_setup_backlight; > panel->backlight.enable = intel_dp_aux_enable_backlight; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls 2020-01-17 11:36 ` Jani Nikula @ 2020-01-17 11:47 ` Jani Nikula 2020-01-17 20:24 ` Lyude Paul 1 sibling, 0 replies; 17+ messages in thread From: Jani Nikula @ 2020-01-17 11:47 UTC (permalink / raw) To: Lyude Paul, intel-gfx Cc: David Airlie, linux-kernel, dri-devel, AceLan Kao, Perry Yuan On Fri, 17 Jan 2020, Jani Nikula <jani.nikula@intel.com> wrote: > On Thu, 16 Jan 2020, Lyude Paul <lyude@redhat.com> wrote: >> Despite the fact that the VBT appears to have a field for specifying >> that a system is equipped with a panel that supports standard VESA >> backlight controls over the DP AUX channel, so far every system we've >> spotted DPCD backlight control support on doesn't actually set this >> field correctly and all have it set to INTEL_BACKLIGHT_DISPLAY_DDI. >> >> While we don't know the exact reason for this VBT misuse, talking with >> some vendors indicated that there's a good number of laptop panels out >> there that supposedly support both PWM backlight controls and DPCD >> backlight controls as a workaround until Intel supports DPCD backlight >> controls across platforms universally. This being said, the X1 Extreme >> 2nd Gen that I have here (note that Lenovo is not the hardware vendor >> that informed us of this) PWM backlight controls are advertised, but >> only DPCD controls actually function. I'm going to make an educated >> guess here and say that on systems like this one, it's likely that PWM >> backlight controls might have been intended to work but were never >> really tested by QA. >> >> Since we really need backlights to work without any extra module >> parameters, let's take the risk here and rely on the standard DPCD caps >> to tell us whether AUX backlight controls are supported or not. We still >> check the VBT, but only to make sure that we don't enable DPCD backlight >> controls on a panel that uses something other then the standard VESA >> interfaces over AUX. Since panels using such non-standard interfaces >> should probably have support added to i915, we'll print a warning when >> seeing this in the VBT. We can remove this warning later if we end up >> adding support for any custom backlight interfaces. >> >> Signed-off-by: Lyude Paul <lyude@redhat.com> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112376 >> Cc: Jani Nikula <jani.nikula@intel.com> >> Cc: Perry Yuan <pyuan@redhat.com> >> Cc: AceLan Kao <acelan.kao@canonical.com> >> --- >> .../drm/i915/display/intel_dp_aux_backlight.c | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c >> index 77a759361c5c..3002b600635f 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c >> @@ -330,13 +330,17 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector) >> struct intel_panel *panel = &intel_connector->panel; >> struct drm_i915_private *dev_priv = to_i915(intel_connector->base.dev); >> >> - if (i915_modparams.enable_dpcd_backlight == 0 || >> - (i915_modparams.enable_dpcd_backlight == -1 && >> - dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE)) >> - return -ENODEV; >> - >> - if (!intel_dp_aux_display_control_capable(intel_connector)) >> + if (i915_modparams.enable_dpcd_backlight == 0) >> return -ENODEV; >> + if (i915_modparams.enable_dpcd_backlight == -1) { >> + if (dev_priv->vbt.backlight.type >> + == INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE) { >> + DRM_WARN("VBT says panel uses custom panel driver interface, not using DPCD backlight controls\n"); >> + return -ENODEV; >> + } >> + if (!intel_dp_aux_display_control_capable(intel_connector)) >> + return -ENODEV; > > Functionally, I'm fine with trying this. But perhaps we should check aux > and early return first, and then check what vbt says, to reduce the > dmesg noise. > > I'll probably want to see a debug message if we're enabling aux > backlight even if dev_priv->vbt.backlight.type != > INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE. It's the kind of debug trace > you'll really want to get first. So I've gone ahead and pushed patches 1-3 and 5 in this series, as they were tested as part of the series I posted. BR, Jani. > > BR, > Jani. > > > >> + } >> >> panel->backlight.setup = intel_dp_aux_setup_backlight; >> panel->backlight.enable = intel_dp_aux_enable_backlight; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls 2020-01-17 11:36 ` Jani Nikula 2020-01-17 11:47 ` Jani Nikula @ 2020-01-17 20:24 ` Lyude Paul 1 sibling, 0 replies; 17+ messages in thread From: Lyude Paul @ 2020-01-17 20:24 UTC (permalink / raw) To: Jani Nikula, intel-gfx Cc: David Airlie, linux-kernel, dri-devel, AceLan Kao, Perry Yuan On Fri, 2020-01-17 at 13:36 +0200, Jani Nikula wrote: > On Thu, 16 Jan 2020, Lyude Paul <lyude@redhat.com> wrote: > > Despite the fact that the VBT appears to have a field for specifying > > that a system is equipped with a panel that supports standard VESA > > backlight controls over the DP AUX channel, so far every system we've > > spotted DPCD backlight control support on doesn't actually set this > > field correctly and all have it set to INTEL_BACKLIGHT_DISPLAY_DDI. > > > > While we don't know the exact reason for this VBT misuse, talking with > > some vendors indicated that there's a good number of laptop panels out > > there that supposedly support both PWM backlight controls and DPCD > > backlight controls as a workaround until Intel supports DPCD backlight > > controls across platforms universally. This being said, the X1 Extreme > > 2nd Gen that I have here (note that Lenovo is not the hardware vendor > > that informed us of this) PWM backlight controls are advertised, but > > only DPCD controls actually function. I'm going to make an educated > > guess here and say that on systems like this one, it's likely that PWM > > backlight controls might have been intended to work but were never > > really tested by QA. > > > > Since we really need backlights to work without any extra module > > parameters, let's take the risk here and rely on the standard DPCD caps > > to tell us whether AUX backlight controls are supported or not. We still > > check the VBT, but only to make sure that we don't enable DPCD backlight > > controls on a panel that uses something other then the standard VESA > > interfaces over AUX. Since panels using such non-standard interfaces > > should probably have support added to i915, we'll print a warning when > > seeing this in the VBT. We can remove this warning later if we end up > > adding support for any custom backlight interfaces. > > > > Signed-off-by: Lyude Paul <lyude@redhat.com> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112376 > > Cc: Jani Nikula <jani.nikula@intel.com> > > Cc: Perry Yuan <pyuan@redhat.com> > > Cc: AceLan Kao <acelan.kao@canonical.com> > > --- > > .../drm/i915/display/intel_dp_aux_backlight.c | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > > b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > > index 77a759361c5c..3002b600635f 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > > @@ -330,13 +330,17 @@ int intel_dp_aux_init_backlight_funcs(struct > > intel_connector *intel_connector) > > struct intel_panel *panel = &intel_connector->panel; > > struct drm_i915_private *dev_priv = to_i915(intel_connector- > > >base.dev); > > > > - if (i915_modparams.enable_dpcd_backlight == 0 || > > - (i915_modparams.enable_dpcd_backlight == -1 && > > - dev_priv->vbt.backlight.type != > > INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE)) > > - return -ENODEV; > > - > > - if (!intel_dp_aux_display_control_capable(intel_connector)) > > + if (i915_modparams.enable_dpcd_backlight == 0) > > return -ENODEV; > > + if (i915_modparams.enable_dpcd_backlight == -1) { > > + if (dev_priv->vbt.backlight.type > > + == INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE) { > > + DRM_WARN("VBT says panel uses custom panel driver > > interface, not using DPCD backlight controls\n"); > > + return -ENODEV; > > + } > > + if (!intel_dp_aux_display_control_capable(intel_connector)) > > + return -ENODEV; > > Functionally, I'm fine with trying this. But perhaps we should check aux > and early return first, and then check what vbt says, to reduce the > dmesg noise. > > I'll probably want to see a debug message if we're enabling aux > backlight even if dev_priv->vbt.backlight.type != > INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE. It's the kind of debug trace > you'll really want to get first. Good point, I'll send a respin of this patch with those changes > > BR, > Jani. > > > > > + } > > > > panel->backlight.setup = intel_dp_aux_setup_backlight; > > panel->backlight.enable = intel_dp_aux_enable_backlight; -- Cheers, Lyude Paul _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH v4] drm/i915: Don't use VBT for detecting DPCD backlight controls 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls Lyude Paul 2020-01-17 11:36 ` Jani Nikula @ 2020-01-17 23:21 ` Lyude Paul 2020-01-22 9:17 ` Jani Nikula 1 sibling, 1 reply; 17+ messages in thread From: Lyude Paul @ 2020-01-17 23:21 UTC (permalink / raw) To: intel-gfx, Jani Nikula Cc: David Airlie, linux-kernel, AceLan Kao, dri-devel, Perry Yuan Despite the fact that the VBT appears to have a field for specifying that a system is equipped with a panel that supports standard VESA backlight controls over the DP AUX channel, so far every system we've spotted DPCD backlight control support on doesn't actually set this field correctly and all have it set to INTEL_BACKLIGHT_DISPLAY_DDI. While we don't know the exact reason for this VBT misuse, talking with some vendors indicated that there's a good number of laptop panels out there that supposedly support both PWM backlight controls and DPCD backlight controls as a workaround until Intel supports DPCD backlight controls across platforms universally. This being said, the X1 Extreme 2nd Gen that I have here (note that Lenovo is not the hardware vendor that informed us of this) PWM backlight controls are advertised, but only DPCD controls actually function. I'm going to make an educated guess here and say that on systems like this one, it's likely that PWM backlight controls might have been intended to work but were never really tested by QA. Since we really need backlights to work without any extra module parameters, let's take the risk here and rely on the standard DPCD caps to tell us whether AUX backlight controls are supported or not. We still check the VBT, just so we can print a debugging message on systems that advertise DPCD backlight support on the panel but not in the VBT. Changes since v3: * Print a debugging message if we enable DPCD backlight control on a device which doesn't report DPCD backlight controls in it's VBT, instead of warning on custom panel backlight interfaces. Signed-off-by: Lyude Paul <lyude@redhat.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112376 Cc: Jani Nikula <jani.nikula@intel.com> Cc: Perry Yuan <pyuan@redhat.com> Cc: AceLan Kao <acelan.kao@canonical.com> --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index 77a759361c5c..0f8edc775375 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c @@ -328,15 +328,16 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector) int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector) { struct intel_panel *panel = &intel_connector->panel; - struct drm_i915_private *dev_priv = to_i915(intel_connector->base.dev); + enum intel_backlight_type type = + to_i915(intel_connector->base.dev)->vbt.backlight.type; if (i915_modparams.enable_dpcd_backlight == 0 || (i915_modparams.enable_dpcd_backlight == -1 && - dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE)) + !intel_dp_aux_display_control_capable(intel_connector))) return -ENODEV; - if (!intel_dp_aux_display_control_capable(intel_connector)) - return -ENODEV; + if (type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE) + DRM_DEBUG_DRIVER("Ignoring VBT backlight type\n"); panel->backlight.setup = intel_dp_aux_setup_backlight; panel->backlight.enable = intel_dp_aux_enable_backlight; -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH v4] drm/i915: Don't use VBT for detecting DPCD backlight controls 2020-01-17 23:21 ` [Intel-gfx] [PATCH v4] " Lyude Paul @ 2020-01-22 9:17 ` Jani Nikula 0 siblings, 0 replies; 17+ messages in thread From: Jani Nikula @ 2020-01-22 9:17 UTC (permalink / raw) To: Lyude Paul, intel-gfx Cc: David Airlie, linux-kernel, dri-devel, AceLan Kao, Perry Yuan On Fri, 17 Jan 2020, Lyude Paul <lyude@redhat.com> wrote: > Despite the fact that the VBT appears to have a field for specifying > that a system is equipped with a panel that supports standard VESA > backlight controls over the DP AUX channel, so far every system we've > spotted DPCD backlight control support on doesn't actually set this > field correctly and all have it set to INTEL_BACKLIGHT_DISPLAY_DDI. > > While we don't know the exact reason for this VBT misuse, talking with > some vendors indicated that there's a good number of laptop panels out > there that supposedly support both PWM backlight controls and DPCD > backlight controls as a workaround until Intel supports DPCD backlight > controls across platforms universally. This being said, the X1 Extreme > 2nd Gen that I have here (note that Lenovo is not the hardware vendor > that informed us of this) PWM backlight controls are advertised, but > only DPCD controls actually function. I'm going to make an educated > guess here and say that on systems like this one, it's likely that PWM > backlight controls might have been intended to work but were never > really tested by QA. > > Since we really need backlights to work without any extra module > parameters, let's take the risk here and rely on the standard DPCD caps > to tell us whether AUX backlight controls are supported or not. We still > check the VBT, just so we can print a debugging message on systems that > advertise DPCD backlight support on the panel but not in the VBT. > > Changes since v3: > * Print a debugging message if we enable DPCD backlight control on a > device which doesn't report DPCD backlight controls in it's VBT, > instead of warning on custom panel backlight interfaces. > > Signed-off-by: Lyude Paul <lyude@redhat.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112376 > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Perry Yuan <pyuan@redhat.com> > Cc: AceLan Kao <acelan.kao@canonical.com> Thanks for the patch, pushed to dinq, fingers crossed! ;) BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > index 77a759361c5c..0f8edc775375 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > @@ -328,15 +328,16 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector) > int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector) > { > struct intel_panel *panel = &intel_connector->panel; > - struct drm_i915_private *dev_priv = to_i915(intel_connector->base.dev); > + enum intel_backlight_type type = > + to_i915(intel_connector->base.dev)->vbt.backlight.type; > > if (i915_modparams.enable_dpcd_backlight == 0 || > (i915_modparams.enable_dpcd_backlight == -1 && > - dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE)) > + !intel_dp_aux_display_control_capable(intel_connector))) > return -ENODEV; > > - if (!intel_dp_aux_display_control_capable(intel_connector)) > - return -ENODEV; > + if (type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE) > + DRM_DEBUG_DRIVER("Ignoring VBT backlight type\n"); > > panel->backlight.setup = intel_dp_aux_setup_backlight; > panel->backlight.enable = intel_dp_aux_enable_backlight; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH v3 5/5] drm/i915: Auto detect DPCD backlight support by default 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul ` (3 preceding siblings ...) 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls Lyude Paul @ 2020-01-16 21:16 ` Lyude Paul 2020-01-16 23:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev6) Patchwork ` (5 subsequent siblings) 10 siblings, 0 replies; 17+ messages in thread From: Lyude Paul @ 2020-01-16 21:16 UTC (permalink / raw) To: intel-gfx; +Cc: David Airlie, linux-kernel, AceLan Kao, dri-devel, Perry Yuan Turns out we actually already have some companies, such as Lenovo, shipping machines with AMOLED screens that don't allow controlling the backlight through the usual PWM interface and only allow controlling it through the standard EDP DPCD interface. One example of one of these laptops is the X1 Extreme 2nd Generation. Since we've got systems that need this turned on by default now to have backlight controls working out of the box, let's start auto-detecting it for systems by default based on what the VBT tells us. We do this by changing the default value for the enable_dpcd_backlight module param from 0 to -1. Tested-by: AceLan Kao <acelan.kao@canonical.com> Tested-by: Perry Yuan <pyuan@redhat.com> Signed-off-by: Lyude Paul <lyude@redhat.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 64009e99073d..905decc36e53 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -172,7 +172,7 @@ i915_param_named_unsafe(inject_probe_failure, uint, 0400, i915_param_named(enable_dpcd_backlight, int, 0600, "Enable support for DPCD backlight control" - "(-1=use per-VBT LFP backlight type setting, 0=disabled [default], 1=enabled)"); + "(-1=use per-VBT LFP backlight type setting [default], 0=disabled, 1=enabled)"); #if IS_ENABLED(CONFIG_DRM_I915_GVT) i915_param_named(enable_gvt, bool, 0400, diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index be6089e4f9e6..947d0a38fa3c 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++ b/drivers/gpu/drm/i915/i915_params.h @@ -66,7 +66,7 @@ struct drm_printer; param(int, reset, 3, 0600) \ param(unsigned int, inject_probe_failure, 0, 0600) \ param(int, fastboot, -1, 0600) \ - param(int, enable_dpcd_backlight, 0, 0600) \ + param(int, enable_dpcd_backlight, -1, 0600) \ param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE, 0400) \ param(unsigned long, fake_lmem_start, 0, 0400) \ /* leave bools at the end to not create holes */ \ -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev6) 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul ` (4 preceding siblings ...) 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 5/5] drm/i915: Auto detect DPCD backlight support by default Lyude Paul @ 2020-01-16 23:26 ` Patchwork 2020-01-16 23:26 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork ` (4 subsequent siblings) 10 siblings, 0 replies; 17+ messages in thread From: Patchwork @ 2020-01-16 23:26 UTC (permalink / raw) To: Lyude Paul; +Cc: intel-gfx == Series Details == Series: drm/i915: eDP DPCD aux backlight fixes (rev6) URL : https://patchwork.freedesktop.org/series/69914/ State : success == Summary == CI Bug Log - changes from CI_DRM_7758 -> Patchwork_16139 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/index.html Known issues ------------ Here are the changes found in Patchwork_16139 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_pm_rpm@module-reload: - fi-kbl-guc: [PASS][1] -> [FAIL][2] ([i915#579]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live_gem_contexts: - fi-hsw-peppy: [PASS][3] -> [DMESG-FAIL][4] ([i915#722]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html - fi-cfl-guc: [PASS][5] -> [INCOMPLETE][6] ([fdo#106070] / [i915#424]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-icl-u2: [PASS][7] -> [FAIL][8] ([i915#217]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - fi-skl-lmem: [PASS][9] -> [INCOMPLETE][10] ([i915#69]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-skl-lmem/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/fi-skl-lmem/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html #### Possible fixes #### * igt@gem_exec_create@basic: - fi-icl-dsi: [DMESG-WARN][11] ([i915#109]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-icl-dsi/igt@gem_exec_create@basic.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/fi-icl-dsi/igt@gem_exec_create@basic.html * igt@i915_pm_rpm@module-reload: - fi-skl-6770hq: [FAIL][13] ([i915#178]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live_blt: - fi-hsw-4770: [DMESG-FAIL][15] ([i915#553] / [i915#725]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-hsw-4770/igt@i915_selftest@live_blt.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/fi-hsw-4770/igt@i915_selftest@live_blt.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070 [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109 [i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178 [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217 [i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424 [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553 [i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722 [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 [i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937 Participating hosts (47 -> 41) ------------------------------ Additional (3): fi-byt-j1900 fi-byt-n2820 fi-tgl-y Missing (9): fi-ilk-m540 fi-bdw-5557u fi-hsw-4200u fi-bdw-gvtdvm fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-elk-e7500 fi-bsw-kefka Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7758 -> Patchwork_16139 CI-20190529: 20190529 CI_DRM_7758: d19270ce1f367fbfc1ff3b539bcb50e11ded181f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5371: 1b2816124ec3dbd53b81725d39292f45d41d895b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16139: 132c90f5d1b16e67e3a5a53a1f0809c6434e6638 @ git://anongit.freedesktop.org/gfx-ci/linux == Kernel 32bit build == Warning: Kernel 32bit buildtest failed: https://intel-gfx-ci.01.org/Patchwork_16139/build_32bit.log CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 122 modules ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1282: recipe for target 'modules' failed make: *** [modules] Error 2 == Linux commits == 132c90f5d1b1 drm/i915: Auto detect DPCD backlight support by default 4c0f762f43be drm/i915: Don't use VBT for detecting DPCD backlight controls 559dc1d2866b drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() 2cba5c059c24 drm/i915: Assume 100% brightness when not in DPCD control mode 0b7dc5151253 drm/i915: Fix eDP DPCD aux max backlight calculations == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: eDP DPCD aux backlight fixes (rev6) 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul ` (5 preceding siblings ...) 2020-01-16 23:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev6) Patchwork @ 2020-01-16 23:26 ` Patchwork 2020-01-18 3:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev7) Patchwork ` (3 subsequent siblings) 10 siblings, 0 replies; 17+ messages in thread From: Patchwork @ 2020-01-16 23:26 UTC (permalink / raw) To: Lyude Paul; +Cc: intel-gfx == Series Details == Series: drm/i915: eDP DPCD aux backlight fixes (rev6) URL : https://patchwork.freedesktop.org/series/69914/ State : warning == Summary == CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 122 modules ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1282: recipe for target 'modules' failed make: *** [modules] Error 2 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/build_32bit.log _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev7) 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul ` (6 preceding siblings ...) 2020-01-16 23:26 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork @ 2020-01-18 3:23 ` Patchwork 2020-01-18 3:23 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork ` (2 subsequent siblings) 10 siblings, 0 replies; 17+ messages in thread From: Patchwork @ 2020-01-18 3:23 UTC (permalink / raw) To: Lyude Paul; +Cc: intel-gfx == Series Details == Series: drm/i915: eDP DPCD aux backlight fixes (rev7) URL : https://patchwork.freedesktop.org/series/69914/ State : success == Summary == CI Bug Log - changes from CI_DRM_7769 -> Patchwork_16163 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/index.html Known issues ------------ Here are the changes found in Patchwork_16163 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_close_race@basic-threads: - fi-byt-j1900: [PASS][1] -> [TIMEOUT][2] ([fdo#112271] / [i915#816]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/fi-byt-j1900/igt@gem_close_race@basic-threads.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/fi-byt-j1900/igt@gem_close_race@basic-threads.html - fi-byt-n2820: [PASS][3] -> [TIMEOUT][4] ([fdo#112271] / [i915#816]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/fi-byt-n2820/igt@gem_close_race@basic-threads.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/fi-byt-n2820/igt@gem_close_race@basic-threads.html * igt@i915_module_load@reload-with-fault-injection: - fi-skl-6770hq: [PASS][5] -> [INCOMPLETE][6] ([i915#671]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pm_rpm@module-reload: - fi-kbl-guc: [PASS][7] -> [FAIL][8] ([i915#579]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live_blt: - fi-ivb-3770: [PASS][9] -> [DMESG-FAIL][10] ([i915#725]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/fi-ivb-3770/igt@i915_selftest@live_blt.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/fi-ivb-3770/igt@i915_selftest@live_blt.html * igt@i915_selftest@live_perf: - fi-apl-guc: [PASS][11] -> [INCOMPLETE][12] ([fdo#103927]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/fi-apl-guc/igt@i915_selftest@live_perf.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/fi-apl-guc/igt@i915_selftest@live_perf.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [PASS][13] -> [FAIL][14] ([fdo#111096] / [i915#323]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html #### Possible fixes #### * igt@i915_module_load@reload-with-fault-injection: - fi-cfl-guc: [INCOMPLETE][15] ([i915#505] / [i915#671]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/fi-cfl-guc/igt@i915_module_load@reload-with-fault-injection.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/fi-cfl-guc/igt@i915_module_load@reload-with-fault-injection.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-icl-u2: [FAIL][17] ([i915#217]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217 [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323 [i915#505]: https://gitlab.freedesktop.org/drm/intel/issues/505 [i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579 [i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671 [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 [i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816 Participating hosts (42 -> 44) ------------------------------ Additional (8): fi-hsw-4770r fi-hsw-peppy fi-snb-2520m fi-kbl-r fi-bsw-kefka fi-bsw-nick fi-skl-6600u fi-snb-2600 Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-glk-dsi fi-bsw-cyan fi-byt-clapper Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7769 -> Patchwork_16163 CI-20190529: 20190529 CI_DRM_7769: 15e78429922635916a012ba594255cf07a5b07ad @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5372: 0d00a27fbbd4d4a77d24499ea9811e07e65eb0ac @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16163: dab5771741336892a6f969a77fb3bc3f02446eac @ git://anongit.freedesktop.org/gfx-ci/linux == Kernel 32bit build == Warning: Kernel 32bit buildtest failed: https://intel-gfx-ci.01.org/Patchwork_16163/build_32bit.log CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 122 modules ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1282: recipe for target 'modules' failed make: *** [modules] Error 2 == Linux commits == dab577174133 drm/i915: Don't use VBT for detecting DPCD backlight controls == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: eDP DPCD aux backlight fixes (rev7) 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul ` (7 preceding siblings ...) 2020-01-18 3:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev7) Patchwork @ 2020-01-18 3:23 ` Patchwork 2020-01-20 5:16 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: eDP DPCD aux backlight fixes (rev6) Patchwork 2020-01-20 19:55 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: eDP DPCD aux backlight fixes (rev7) Patchwork 10 siblings, 0 replies; 17+ messages in thread From: Patchwork @ 2020-01-18 3:23 UTC (permalink / raw) To: Lyude Paul; +Cc: intel-gfx == Series Details == Series: drm/i915: eDP DPCD aux backlight fixes (rev7) URL : https://patchwork.freedesktop.org/series/69914/ State : warning == Summary == CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 122 modules ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1282: recipe for target 'modules' failed make: *** [modules] Error 2 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/build_32bit.log _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: eDP DPCD aux backlight fixes (rev6) 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul ` (8 preceding siblings ...) 2020-01-18 3:23 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork @ 2020-01-20 5:16 ` Patchwork 2020-01-20 19:55 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: eDP DPCD aux backlight fixes (rev7) Patchwork 10 siblings, 0 replies; 17+ messages in thread From: Patchwork @ 2020-01-20 5:16 UTC (permalink / raw) To: Lyude Paul; +Cc: intel-gfx == Series Details == Series: drm/i915: eDP DPCD aux backlight fixes (rev6) URL : https://patchwork.freedesktop.org/series/69914/ State : success == Summary == CI Bug Log - changes from CI_DRM_7758_full -> Patchwork_16139_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_16139_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@busy-vcs1: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +16 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_busy@busy-vcs1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb5/igt@gem_busy@busy-vcs1.html * igt@gem_ctx_isolation@vcs1-reset: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +2 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_ctx_isolation@vcs1-reset.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb8/igt@gem_ctx_isolation@vcs1-reset.html * igt@gem_exec_parallel@vcs0-fds: - shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([i915#470] / [i915#472]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb5/igt@gem_exec_parallel@vcs0-fds.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb3/igt@gem_exec_parallel@vcs0-fds.html * igt@gem_exec_schedule@pi-distinct-iova-bsd: - shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_exec_schedule@pi-distinct-iova-bsd.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb4/igt@gem_exec_schedule@pi-distinct-iova-bsd.html * igt@gem_exec_schedule@preempt-bsd: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +6 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@gem_exec_schedule@preempt-bsd.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb1/igt@gem_exec_schedule@preempt-bsd.html * igt@gem_exec_schedule@preempt-queue-bsd2: - shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111606] / [fdo#111677] / [i915#472]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb8/igt@gem_exec_schedule@preempt-queue-bsd2.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb3/igt@gem_exec_schedule@preempt-queue-bsd2.html * igt@gem_exec_schedule@smoketest-bsd1: - shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([i915#463] / [i915#472]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb1/igt@gem_exec_schedule@smoketest-bsd1.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb3/igt@gem_exec_schedule@smoketest-bsd1.html * igt@gem_exec_schedule@smoketest-bsd2: - shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([i915#472] / [i915#707]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb5/igt@gem_exec_schedule@smoketest-bsd2.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb4/igt@gem_exec_schedule@smoketest-bsd2.html * igt@gem_persistent_relocs@forked-interruptible-thrashing: - shard-snb: [PASS][17] -> [FAIL][18] ([i915#520]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-snb5/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-snb1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html - shard-apl: [PASS][19] -> [TIMEOUT][20] ([fdo#112271] / [i915#530]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html - shard-kbl: [PASS][21] -> [TIMEOUT][22] ([fdo#112271] / [i915#530]) +1 similar issue [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-kbl1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html * igt@gem_persistent_relocs@forked-thrash-inactive: - shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([i915#472] / [i915#530]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb3/igt@gem_persistent_relocs@forked-thrash-inactive.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb4/igt@gem_persistent_relocs@forked-thrash-inactive.html - shard-kbl: [PASS][25] -> [INCOMPLETE][26] ([fdo#103665] / [i915#530]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl2/igt@gem_persistent_relocs@forked-thrash-inactive.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-kbl3/igt@gem_persistent_relocs@forked-thrash-inactive.html * igt@gem_persistent_relocs@forked-thrashing: - shard-hsw: [PASS][27] -> [INCOMPLETE][28] ([i915#530] / [i915#61]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-hsw5/igt@gem_persistent_relocs@forked-thrashing.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-hsw7/igt@gem_persistent_relocs@forked-thrashing.html * igt@gem_sync@basic-store-all: - shard-tglb: [PASS][29] -> [INCOMPLETE][30] ([i915#472]) +2 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb8/igt@gem_sync@basic-store-all.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb6/igt@gem_sync@basic-store-all.html * igt@i915_selftest@live_execlists: - shard-tglb: [PASS][31] -> [INCOMPLETE][32] ([i915#472] / [i915#647]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb8/igt@i915_selftest@live_execlists.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb3/igt@i915_selftest@live_execlists.html * igt@i915_suspend@fence-restore-untiled: - shard-skl: [PASS][33] -> [INCOMPLETE][34] ([i915#69]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl5/igt@i915_suspend@fence-restore-untiled.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-skl2/igt@i915_suspend@fence-restore-untiled.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-apl: [PASS][35] -> [DMESG-WARN][36] ([i915#180]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_flip@plain-flip-fb-recreate: - shard-skl: [PASS][37] -> [FAIL][38] ([i915#34]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl8/igt@kms_flip@plain-flip-fb-recreate.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-skl10/igt@kms_flip@plain-flip-fb-recreate.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite: - shard-tglb: [PASS][39] -> [INCOMPLETE][40] ([i915#472] / [i915#474]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: - shard-tglb: [PASS][41] -> [FAIL][42] ([i915#49]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [PASS][43] -> [DMESG-WARN][44] ([i915#180]) +10 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite: - shard-skl: [PASS][45] -> [FAIL][46] ([i915#49]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl9/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-skl1/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][47] -> [FAIL][48] ([fdo#108145] / [i915#265]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][49] -> [FAIL][50] ([i915#173]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@kms_psr@no_drrs.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb1/igt@kms_psr@no_drrs.html * igt@prime_vgem@fence-wait-bsd2: - shard-iclb: [PASS][51] -> [SKIP][52] ([fdo#109276]) +17 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb5/igt@prime_vgem@fence-wait-bsd2.html #### Possible fixes #### * igt@gem_ctx_persistence@processes: - shard-iclb: [FAIL][53] ([i915#570]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_ctx_persistence@processes.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb5/igt@gem_ctx_persistence@processes.html * igt@gem_ctx_persistence@vcs1-queued: - shard-iclb: [SKIP][55] ([fdo#109276] / [fdo#112080]) -> [PASS][56] +2 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_ctx_persistence@vcs1-queued.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb4/igt@gem_ctx_persistence@vcs1-queued.html * igt@gem_ctx_shared@q-smoketest-all: - shard-tglb: [INCOMPLETE][57] ([fdo#111735] / [i915#472]) -> [PASS][58] +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb7/igt@gem_ctx_shared@q-smoketest-all.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb7/igt@gem_ctx_shared@q-smoketest-all.html * igt@gem_exec_await@wide-all: - shard-tglb: [INCOMPLETE][59] ([fdo#111736] / [i915#472]) -> [PASS][60] +1 similar issue [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb3/igt@gem_exec_await@wide-all.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb5/igt@gem_exec_await@wide-all.html * igt@gem_exec_balancer@smoke: - shard-iclb: [SKIP][61] ([fdo#110854]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_exec_balancer@smoke.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb4/igt@gem_exec_balancer@smoke.html * igt@gem_exec_parallel@vcs1-fds: - shard-iclb: [SKIP][63] ([fdo#112080]) -> [PASS][64] +10 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_exec_parallel@vcs1-fds.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb4/igt@gem_exec_parallel@vcs1-fds.html * igt@gem_exec_schedule@pi-common-bsd: - shard-iclb: [SKIP][65] ([i915#677]) -> [PASS][66] +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_exec_schedule@pi-common-bsd.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb8/igt@gem_exec_schedule@pi-common-bsd.html * igt@gem_exec_schedule@preempt-contexts-bsd2: - shard-iclb: [SKIP][67] ([fdo#109276]) -> [PASS][68] +24 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@gem_exec_schedule@preempt-contexts-bsd2.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb4/igt@gem_exec_schedule@preempt-contexts-bsd2.html * igt@gem_exec_schedule@preemptive-hang-bsd: - shard-iclb: [SKIP][69] ([fdo#112146]) -> [PASS][70] +7 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html * igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive: - shard-tglb: [INCOMPLETE][71] ([i915#472]) -> [PASS][72] +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb6/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb7/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive: - shard-kbl: [TIMEOUT][73] ([fdo#112271] / [i915#530]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html * igt@gem_persistent_relocs@forked-thrashing: - shard-kbl: [INCOMPLETE][75] ([fdo#103665] / [i915#530]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl6/igt@gem_persistent_relocs@forked-thrashing.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-kbl1/igt@gem_persistent_relocs@forked-thrashing.html * igt@gem_pipe_control_store_loop@reused-buffer: - shard-tglb: [INCOMPLETE][77] ([i915#472] / [i915#707] / [i915#796]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb3/igt@gem_pipe_control_store_loop@reused-buffer.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb5/igt@gem_pipe_control_store_loop@reused-buffer.html * igt@gen9_exec_parse@allowed-all: - shard-skl: [DMESG-WARN][79] ([i915#716]) -> [PASS][80] [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl8/igt@gen9_exec_parse@allowed-all.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-skl5/igt@gen9_exec_parse@allowed-all.html * {igt@i915_pm_rc6_residency@rc6-idle}: - shard-apl: [FAIL][81] ([i915#973]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl3/igt@i915_pm_rc6_residency@rc6-idle.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-apl7/igt@i915_pm_rc6_residency@rc6-idle.html * igt@i915_pm_rps@reset: - shard-iclb: [FAIL][83] ([i915#413]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@i915_pm_rps@reset.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb8/igt@i915_pm_rps@reset.html * igt@i915_selftest@live_execlists: - shard-kbl: [INCOMPLETE][85] ([fdo#103665] / [fdo#112175] / [fdo#112259]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl6/igt@i915_selftest@live_execlists.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-kbl7/igt@i915_selftest@live_execlists.html * igt@kms_color@pipe-b-ctm-blue-to-red: - shard-skl: [DMESG-WARN][87] ([i915#109]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl3/igt@kms_color@pipe-b-ctm-blue-to-red.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-skl3/igt@kms_color@pipe-b-ctm-blue-to-red.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-apl: [DMESG-WARN][89] ([i915#180]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-kbl: [DMESG-WARN][91] ([i915#180]) -> [PASS][92] +1 similar issue [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_flip@plain-flip-ts-check-interruptible: - shard-skl: [FAIL][93] ([i915#34]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible.html * igt@kms_frontbuffer_tracking@fbc-stridechange: - shard-tglb: [FAIL][95] ([i915#49]) -> [PASS][96] +2 similar issues [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-stridechange.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes: - shard-iclb: [INCOMPLETE][97] ([i915#140] / [i915#250]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html * igt@kms_psr@psr2_primary_blt: - shard-iclb: [SKIP][99] ([fdo#109441]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb1/igt@kms_psr@psr2_primary_blt.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb2/igt@kms_psr@psr2_primary_blt.html * igt@kms_setmode@basic: - shard-apl: [FAIL][101] ([i915#31]) -> [PASS][102] [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl3/igt@kms_setmode@basic.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-apl3/igt@kms_setmode@basic.html #### Warnings #### * igt@gem_ctx_isolation@vcs1-nonpriv: - shard-iclb: [FAIL][103] ([IGT#28]) -> [SKIP][104] ([fdo#109276] / [fdo#112080]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html * igt@i915_pm_dc@dc5-psr: - shard-snb: [SKIP][105] ([fdo#109271]) -> [INCOMPLETE][106] ([i915#82]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-snb2/igt@i915_pm_dc@dc5-psr.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-snb5/igt@i915_pm_dc@dc5-psr.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][107] ([fdo#109349]) -> [DMESG-WARN][108] ([fdo#107724]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606 [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677 [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735 [fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#112175]: https://bugs.freedesktop.org/show_bug.cgi?id=112175 [fdo#112259]: https://bugs.freedesktop.org/show_bug.cgi?id=112259 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109 [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140 [i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413 [i915#463]: https://gitlab.freedesktop.org/drm/intel/issues/463 [i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470 [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472 [i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520 [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530 [i915#570]: https://gitlab.freedesktop.org/drm/intel/issues/570 [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61 [i915#647]: https://gitlab.freedesktop.org/drm/intel/issues/647 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#796]: https://gitlab.freedesktop.org/drm/intel/issues/796 [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 [i915#973]: https://gitlab.freedesktop.org/drm/intel/issues/973 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7758 -> Patchwork_16139 CI-20190529: 20190529 CI_DRM_7758: d19270ce1f367fbfc1ff3b539bcb50e11ded181f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5371: 1b2816124ec3dbd53b81725d39292f45d41d895b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16139: 132c90f5d1b16e67e3a5a53a1f0809c6434e6638 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16139/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: eDP DPCD aux backlight fixes (rev7) 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul ` (9 preceding siblings ...) 2020-01-20 5:16 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: eDP DPCD aux backlight fixes (rev6) Patchwork @ 2020-01-20 19:55 ` Patchwork 10 siblings, 0 replies; 17+ messages in thread From: Patchwork @ 2020-01-20 19:55 UTC (permalink / raw) To: Lyude Paul; +Cc: intel-gfx == Series Details == Series: drm/i915: eDP DPCD aux backlight fixes (rev7) URL : https://patchwork.freedesktop.org/series/69914/ State : success == Summary == CI Bug Log - changes from CI_DRM_7769_full -> Patchwork_16163_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_16163_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@rcs0-s3: - shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +8 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html * igt@gem_ctx_persistence@vcs1-mixed: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed.html * igt@gem_eio@in-flight-contexts-1us: - shard-snb: [PASS][5] -> [FAIL][6] ([i915#490]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-snb6/igt@gem_eio@in-flight-contexts-1us.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-snb1/igt@gem_eio@in-flight-contexts-1us.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110854]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb1/igt@gem_exec_balancer@smoke.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb8/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@preempt-queue-bsd1: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +16 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd1.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd1.html * igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd: - shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112146]) +3 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb5/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb2/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive: - shard-apl: [PASS][13] -> [TIMEOUT][14] ([fdo#112271] / [i915#530]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-apl4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html * igt@gem_persistent_relocs@forked-thrash-inactive: - shard-apl: [PASS][15] -> [INCOMPLETE][16] ([fdo#103927] / [i915#530]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-apl2/igt@gem_persistent_relocs@forked-thrash-inactive.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-apl8/igt@gem_persistent_relocs@forked-thrash-inactive.html * igt@i915_pm_rps@waitboost: - shard-iclb: [PASS][17] -> [FAIL][18] ([i915#413]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb4/igt@i915_pm_rps@waitboost.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb1/igt@i915_pm_rps@waitboost.html * igt@kms_color@pipe-a-ctm-0-5: - shard-skl: [PASS][19] -> [DMESG-WARN][20] ([i915#109]) +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-skl7/igt@kms_color@pipe-a-ctm-0-5.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-skl5/igt@kms_color@pipe-a-ctm-0-5.html * igt@kms_flip@plain-flip-fb-recreate-interruptible: - shard-skl: [PASS][21] -> [FAIL][22] ([i915#34]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +3 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-apl8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_plane_multiple@atomic-pipe-a-tiling-none: - shard-hsw: [PASS][27] -> [DMESG-FAIL][28] ([i915#44]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-hsw5/igt@kms_plane_multiple@atomic-pipe-a-tiling-none.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-hsw5/igt@kms_plane_multiple@atomic-pipe-a-tiling-none.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +2 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@kms_setmode@basic: - shard-kbl: [PASS][31] -> [FAIL][32] ([i915#31]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-kbl2/igt@kms_setmode@basic.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-kbl3/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-c-query-busy: - shard-hsw: [PASS][33] -> [DMESG-WARN][34] ([i915#44]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-hsw5/igt@kms_vblank@pipe-c-query-busy.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-hsw5/igt@kms_vblank@pipe-c-query-busy.html * igt@perf_pmu@busy-accuracy-98-vcs1: - shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#112080]) +9 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb1/igt@perf_pmu@busy-accuracy-98-vcs1.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb8/igt@perf_pmu@busy-accuracy-98-vcs1.html #### Possible fixes #### * igt@gem_ctx_persistence@processes: - shard-skl: [FAIL][37] ([i915#570]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-skl8/igt@gem_ctx_persistence@processes.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-skl1/igt@gem_ctx_persistence@processes.html * igt@gem_ctx_persistence@vcs1-mixed-process: - shard-iclb: [SKIP][39] ([fdo#109276] / [fdo#112080]) -> [PASS][40] +4 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb6/igt@gem_ctx_persistence@vcs1-mixed-process.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed-process.html * igt@gem_exec_balancer@hang: - shard-iclb: [INCOMPLETE][41] ([i915#140]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb4/igt@gem_exec_balancer@hang.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb8/igt@gem_exec_balancer@hang.html * igt@gem_exec_schedule@pi-shared-iova-bsd: - shard-iclb: [SKIP][43] ([i915#677]) -> [PASS][44] +1 similar issue [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb1/igt@gem_exec_schedule@pi-shared-iova-bsd.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb8/igt@gem_exec_schedule@pi-shared-iova-bsd.html * igt@gem_exec_schedule@preempt-bsd: - shard-iclb: [SKIP][45] ([fdo#112146]) -> [PASS][46] +5 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb4/igt@gem_exec_schedule@preempt-bsd.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb8/igt@gem_exec_schedule@preempt-bsd.html * igt@gem_persistent_relocs@forked-faulting-reloc-thrashing: - shard-kbl: [TIMEOUT][47] ([fdo#112271] / [i915#530]) -> [PASS][48] +2 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-kbl6/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-kbl1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html * igt@gem_persistent_relocs@forked-interruptible-thrashing: - shard-apl: [TIMEOUT][49] ([fdo#112271] / [i915#530]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-apl7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-apl6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html * igt@gen7_exec_parse@basic-allocation: - shard-hsw: [FAIL][51] ([i915#694]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-hsw2/igt@gen7_exec_parse@basic-allocation.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-hsw5/igt@gen7_exec_parse@basic-allocation.html * igt@gen9_exec_parse@allowed-all: - shard-kbl: [DMESG-WARN][53] ([i915#716]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-kbl2/igt@gen9_exec_parse@allowed-all.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-kbl6/igt@gen9_exec_parse@allowed-all.html * igt@i915_pm_rps@reset: - shard-iclb: [FAIL][55] ([i915#413]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb8/igt@i915_pm_rps@reset.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb8/igt@i915_pm_rps@reset.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [DMESG-WARN][57] ([i915#180]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_color@pipe-c-ctm-0-5: - shard-skl: [DMESG-WARN][59] ([i915#109]) -> [PASS][60] +1 similar issue [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-skl1/igt@kms_color@pipe-c-ctm-0-5.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-skl10/igt@kms_color@pipe-c-ctm-0-5.html * igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic: - shard-hsw: [SKIP][61] ([fdo#109271]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-hsw5/igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-hsw5/igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-skl: [FAIL][63] ([IGT#5]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [FAIL][65] ([i915#79]) -> [PASS][66] +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-skl8/igt@kms_flip@flip-vs-expired-vblank.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-skl10/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-glk: [FAIL][67] ([i915#79]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [SKIP][69] ([fdo#109441]) -> [PASS][70] +2 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_setmode@basic: - shard-apl: [FAIL][71] ([i915#31]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-apl1/igt@kms_setmode@basic.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-apl3/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [DMESG-WARN][73] ([i915#180]) -> [PASS][74] +4 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@perf_pmu@busy-no-semaphores-vcs1: - shard-iclb: [SKIP][75] ([fdo#112080]) -> [PASS][76] +7 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb5/igt@perf_pmu@busy-no-semaphores-vcs1.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb1/igt@perf_pmu@busy-no-semaphores-vcs1.html * igt@prime_busy@hang-bsd2: - shard-iclb: [SKIP][77] ([fdo#109276]) -> [PASS][78] +5 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-iclb5/igt@prime_busy@hang-bsd2.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-iclb2/igt@prime_busy@hang-bsd2.html #### Warnings #### * igt@gem_tiled_blits@normal: - shard-hsw: [FAIL][79] ([i915#694]) -> [FAIL][80] ([i915#818]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-hsw2/igt@gem_tiled_blits@normal.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-hsw7/igt@gem_tiled_blits@normal.html * igt@runner@aborted: - shard-kbl: ([FAIL][81], [FAIL][82], [FAIL][83]) ([i915#716] / [i915#997]) -> ([FAIL][84], [FAIL][85]) ([i915#997]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-kbl7/igt@runner@aborted.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-kbl2/igt@runner@aborted.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-kbl1/igt@runner@aborted.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-kbl2/igt@runner@aborted.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-kbl7/igt@runner@aborted.html - shard-glk: ([FAIL][86], [FAIL][87], [FAIL][88]) ([i915#997] / [k.org#202321]) -> [FAIL][89] ([k.org#202321]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-glk4/igt@runner@aborted.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-glk2/igt@runner@aborted.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7769/shard-glk5/igt@runner@aborted.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/shard-glk1/igt@runner@aborted.html [IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109 [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413 [i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44 [i915#490]: https://gitlab.freedesktop.org/drm/intel/issues/490 [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530 [i915#570]: https://gitlab.freedesktop.org/drm/intel/issues/570 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818 [i915#997]: https://gitlab.freedesktop.org/drm/intel/issues/997 [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7769 -> Patchwork_16163 CI-20190529: 20190529 CI_DRM_7769: 15e78429922635916a012ba594255cf07a5b07ad @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5372: 0d00a27fbbd4d4a77d24499ea9811e07e65eb0ac @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16163: dab5771741336892a6f969a77fb3bc3f02446eac @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16163/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2020-01-22 9:16 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-01-16 21:16 [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 1/5] drm/i915: Fix eDP DPCD aux max backlight calculations Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 2/5] drm/i915: Assume 100% brightness when not in DPCD control mode Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 3/5] drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() Lyude Paul 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls Lyude Paul 2020-01-17 11:36 ` Jani Nikula 2020-01-17 11:47 ` Jani Nikula 2020-01-17 20:24 ` Lyude Paul 2020-01-17 23:21 ` [Intel-gfx] [PATCH v4] " Lyude Paul 2020-01-22 9:17 ` Jani Nikula 2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 5/5] drm/i915: Auto detect DPCD backlight support by default Lyude Paul 2020-01-16 23:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev6) Patchwork 2020-01-16 23:26 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork 2020-01-18 3:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev7) Patchwork 2020-01-18 3:23 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork 2020-01-20 5:16 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: eDP DPCD aux backlight fixes (rev6) Patchwork 2020-01-20 19:55 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: eDP DPCD aux backlight fixes (rev7) Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).