From: Chris Wilson <chris@chris-wilson.co.uk>
To: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>,
igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [RFC PATCH i-g-t v2] tests/gem_userptr_blits: Enhance invalid mapping exercise
Date: Tue, 11 Feb 2020 16:44:59 +0000 [thread overview]
Message-ID: <158143949995.3635.18328569070749519341@skylake-alporthouse-com> (raw)
In-Reply-To: <20200211143048.12260-1-janusz.krzysztofik@linux.intel.com>
Quoting Janusz Krzysztofik (2020-02-11 14:30:48)
> @@ -2009,8 +2016,31 @@ igt_main_args("c:", NULL, help_str, opt_handler, NULL)
> igt_subtest("invalid-null-pointer")
> test_invalid_null_pointer(fd);
>
> - igt_subtest("invalid-gtt-mapping")
> - test_invalid_gtt_mapping(fd);
> + igt_describe("Verify userptr on top of GTT mapping to GEM object will fail");
> + igt_subtest("invalid-gtt-mapping") {
> + gem_require_mappable_ggtt(fd);
> + test_invalid_mapping(fd, I915_MMAP_OFFSET_GTT);
> + }
#include "i915/gem_mman.h"
igt_subtest_with_dynamic("invalid-mmap-offset") {
for_each_mmap_offset_type(t) {
igt_dynamic_f("%s", t->name)
test_invalid_mapping(fd, t);
In test_invalid_mapping, instead of do_ioctl(MMAP_OFFSET) use
igt_require(igt_ioctl(MMAP_OFFSET, &arg) == 0);
(Or igt_require_f if you like to keep the spiel.)
}
}
}
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-11 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 14:30 [Intel-gfx] [RFC PATCH i-g-t v2] tests/gem_userptr_blits: Enhance invalid mapping exercise Janusz Krzysztofik
2020-02-11 16:44 ` Chris Wilson [this message]
2020-02-12 10:35 ` Janusz Krzysztofik
2020-02-20 12:36 ` Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158143949995.3635.18328569070749519341@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=janusz.krzysztofik@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).