[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per client engine busyness (rev5)

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: Per client engine busyness (rev5)
URL   : https://patchwork.freedesktop.org/series/70977/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a60fd0a6e3d1 drm/i915: Expose list of clients in sysfs
-:68: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#68: 
new file mode 100644

-:73: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#73: FILE: drivers/gpu/drm/i915/i915_drm_client.c:1:
+/*

-:74: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#74: FILE: drivers/gpu/drm/i915/i915_drm_client.c:2:
+ * SPDX-License-Identifier: MIT

-:234: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#234: FILE: drivers/gpu/drm/i915/i915_drm_client.h:1:
+/*

-:235: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#235: FILE: drivers/gpu/drm/i915/i915_drm_client.h:2:
+ * SPDX-License-Identifier: MIT

-:252: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#252: FILE: drivers/gpu/drm/i915/i915_drm_client.h:19:
+	struct mutex lock;

total: 0 errors, 5 warnings, 1 checks, 348 lines checked
c517889b70f2 drm/i915: Update client name on context create
-:174: ERROR:OPEN_BRACE: open brace '{' following struct go on the same line
#174: FILE: drivers/gpu/drm/i915/i915_drm_client.c:174:
+struct client_update_free
+{

-:216: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#216: FILE: drivers/gpu/drm/i915/i915_drm_client.c:216:
+	if (!name) {
+		drm_notice(&i915->drm,

-:258: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#258: FILE: drivers/gpu/drm/i915/i915_drm_client.h:32:
+	struct mutex update_lock;

total: 1 errors, 1 warnings, 1 checks, 219 lines checked
3867321c33f3 drm/i915: Make GEM contexts track DRM clients
eb5a71b451e7 drm/i915: Use explicit flag to mark unreachable intel_context
-:20: WARNING:MEMORY_BARRIER: memory barrier without comment
#20: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:571:
+		smp_store_mb(ce->closed, true);

total: 0 errors, 1 warnings, 0 checks, 26 lines checked
5d9fea699f4f drm/i915: Track runtime spent in unreachable intel_contexts
555e43ccead3 drm/i915: Track runtime spent in closed GEM contexts
b1460e0c42ea drm/i915: Track all user contexts per client
-:89: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#89: FILE: drivers/gpu/drm/i915/i915_drm_client.h:43:
+	spinlock_t ctx_lock;

total: 0 errors, 0 warnings, 1 checks, 59 lines checked
23836735df75 drm/i915: Expose per-engine client busyness
-:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25: 
     Render/3D/0   63.73% |███████████████████           |      3%      0%

-:114: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#114: FILE: drivers/gpu/drm/i915/i915_drm_client.c:94:
+static const char *uabi_class_names[] = {

total: 0 errors, 2 warnings, 0 checks, 150 lines checked
2bd7560f3275 drm/i915: Track per-context engine busyness
20e5180a4335 drm/i915: Carry over past software tracked context runtime
8c5b89e058b5 drm/i915: Prefer software tracked context busyness
c090e12915a4 compare runtimes
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:31: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#31: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:279:
+			printk("%p class%u %llums vs %llums\n",

total: 0 errors, 2 warnings, 0 checks, 25 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx