* [Intel-gfx] [PATCH v3] drm/i915: Add missing HDMI audio pixel clocks for gen12 @ 2020-03-10 16:23 Kai Vehmanen 2020-03-11 9:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add missing HDMI audio pixel clocks for gen12 (rev4) Patchwork ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Kai Vehmanen @ 2020-03-10 16:23 UTC (permalink / raw) To: intel-gfx Gen12 hardware supports HDMI audio pixel clocks of 296.7/297Mhz and 593.4/594Mhz. Add the missing rates and add logic to ignore them if running on older hardware. Bspec: 49333 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/display/intel_audio.c | 8 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 4 ++++ 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c index 19bf206037c2..62f234f641de 100644 --- a/drivers/gpu/drm/i915/display/intel_audio.c +++ b/drivers/gpu/drm/i915/display/intel_audio.c @@ -149,6 +149,10 @@ static const struct { { 74250, AUD_CONFIG_PIXEL_CLOCK_HDMI_74250 }, { 148352, AUD_CONFIG_PIXEL_CLOCK_HDMI_148352 }, { 148500, AUD_CONFIG_PIXEL_CLOCK_HDMI_148500 }, + { 296703, AUD_CONFIG_PIXEL_CLOCK_HDMI_296703 }, + { 297000, AUD_CONFIG_PIXEL_CLOCK_HDMI_297000 }, + { 593407, AUD_CONFIG_PIXEL_CLOCK_HDMI_593407 }, + { 594000, AUD_CONFIG_PIXEL_CLOCK_HDMI_594000 }, }; /* HDMI N/CTS table */ @@ -234,6 +238,7 @@ static const struct hdmi_aud_ncts hdmi_aud_ncts_36bpp[] = { /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */ static u32 audio_config_hdmi_pixel_clock(const struct intel_crtc_state *crtc_state) { + struct drm_i915_private *dev_priv = to_i915(crtc_state->uapi.crtc->dev); const struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode; int i; @@ -243,6 +248,9 @@ static u32 audio_config_hdmi_pixel_clock(const struct intel_crtc_state *crtc_sta break; } + if (INTEL_GEN(dev_priv) < 12 && adjusted_mode->crtc_clock > 148500) + i = ARRAY_SIZE(hdmi_audio_clock); + if (i == ARRAY_SIZE(hdmi_audio_clock)) { DRM_DEBUG_KMS("HDMI audio pixel clock setting for %d not found, falling back to defaults\n", adjusted_mode->crtc_clock); diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 79ae9654dac9..ee4a75ac9186 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -9251,6 +9251,10 @@ enum { #define AUD_CONFIG_PIXEL_CLOCK_HDMI_74250 (7 << 16) #define AUD_CONFIG_PIXEL_CLOCK_HDMI_148352 (8 << 16) #define AUD_CONFIG_PIXEL_CLOCK_HDMI_148500 (9 << 16) +#define AUD_CONFIG_PIXEL_CLOCK_HDMI_296703 (10 << 16) +#define AUD_CONFIG_PIXEL_CLOCK_HDMI_297000 (11 << 16) +#define AUD_CONFIG_PIXEL_CLOCK_HDMI_593407 (12 << 16) +#define AUD_CONFIG_PIXEL_CLOCK_HDMI_594000 (13 << 16) #define AUD_CONFIG_DISABLE_NCTS (1 << 3) /* HSW Audio */ -- 2.17.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add missing HDMI audio pixel clocks for gen12 (rev4) 2020-03-10 16:23 [Intel-gfx] [PATCH v3] drm/i915: Add missing HDMI audio pixel clocks for gen12 Kai Vehmanen @ 2020-03-11 9:09 ` Patchwork 2020-03-11 17:39 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-03-11 18:32 ` [Intel-gfx] [PATCH v3] drm/i915: Add missing HDMI audio pixel clocks for gen12 Ville Syrjälä 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2020-03-11 9:09 UTC (permalink / raw) To: Kai Vehmanen; +Cc: intel-gfx == Series Details == Series: drm/i915: Add missing HDMI audio pixel clocks for gen12 (rev4) URL : https://patchwork.freedesktop.org/series/72617/ State : success == Summary == CI Bug Log - changes from CI_DRM_8112 -> Patchwork_16911 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/index.html Known issues ------------ Here are the changes found in Patchwork_16911 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@gem_contexts: - fi-cml-s: [PASS][1] -> [DMESG-FAIL][2] ([i915#877]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/fi-cml-s/igt@i915_selftest@live@gem_contexts.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/fi-cml-s/igt@i915_selftest@live@gem_contexts.html * igt@kms_chamelium@hdmi-crc-fast: - fi-icl-u2: [PASS][3] -> [FAIL][4] ([fdo#109635] / [i915#217]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s4-devices: - fi-tgl-y: [FAIL][5] ([CI#94]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html * igt@kms_addfb_basic@unused-modifier: - fi-tgl-y: [DMESG-WARN][7] ([CI#94] / [i915#402]) -> [PASS][8] +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/fi-tgl-y/igt@kms_addfb_basic@unused-modifier.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/fi-tgl-y/igt@kms_addfb_basic@unused-modifier.html [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94 [fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635 [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877 Participating hosts (44 -> 39) ------------------------------ Additional (4): fi-skl-6770hq fi-bsw-nick fi-skl-6600u fi-bsw-n3050 Missing (9): fi-hsw-4200u fi-hsw-peppy fi-bdw-gvtdvm fi-glk-dsi fi-byt-squawks fi-elk-e7500 fi-bsw-kefka fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8112 -> Patchwork_16911 CI-20190529: 20190529 CI_DRM_8112: 032f2fe5c92eb1db6d417738431153c001a41bcc @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5504: d6788bf0404f76b66170e18eb26c85004b5ccb25 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16911: 1d291f34ab62143871b49b78d833e0897c26ffa8 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 1d291f34ab62 drm/i915: Add missing HDMI audio pixel clocks for gen12 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add missing HDMI audio pixel clocks for gen12 (rev4) 2020-03-10 16:23 [Intel-gfx] [PATCH v3] drm/i915: Add missing HDMI audio pixel clocks for gen12 Kai Vehmanen 2020-03-11 9:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add missing HDMI audio pixel clocks for gen12 (rev4) Patchwork @ 2020-03-11 17:39 ` Patchwork 2020-03-11 18:32 ` [Intel-gfx] [PATCH v3] drm/i915: Add missing HDMI audio pixel clocks for gen12 Ville Syrjälä 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2020-03-11 17:39 UTC (permalink / raw) To: Kai Vehmanen; +Cc: intel-gfx == Series Details == Series: drm/i915: Add missing HDMI audio pixel clocks for gen12 (rev4) URL : https://patchwork.freedesktop.org/series/72617/ State : success == Summary == CI Bug Log - changes from CI_DRM_8112_full -> Patchwork_16911_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_16911_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@close-replace-race: - shard-tglb: [PASS][1] -> [INCOMPLETE][2] ([i915#1402]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-tglb1/igt@gem_ctx_persistence@close-replace-race.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-tglb7/igt@gem_ctx_persistence@close-replace-race.html * igt@gem_exec_schedule@independent-bsd2: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +21 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb4/igt@gem_exec_schedule@independent-bsd2.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb5/igt@gem_exec_schedule@independent-bsd2.html * igt@gem_exec_schedule@pi-shared-iova-bsd: - shard-iclb: [PASS][5] -> [SKIP][6] ([i915#677]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb3/igt@gem_exec_schedule@pi-shared-iova-bsd.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb4/igt@gem_exec_schedule@pi-shared-iova-bsd.html * igt@gem_exec_schedule@preempt-other-bsd: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +2 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb3/igt@gem_exec_schedule@preempt-other-bsd.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb2/igt@gem_exec_schedule@preempt-other-bsd.html * igt@gem_exec_whisper@basic-queues-forked: - shard-glk: [PASS][9] -> [DMESG-WARN][10] ([i915#118] / [i915#95]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-glk7/igt@gem_exec_whisper@basic-queues-forked.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-glk6/igt@gem_exec_whisper@basic-queues-forked.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-glk: [PASS][11] -> [FAIL][12] ([i915#644]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-glk8/igt@gem_ppgtt@flink-and-close-vma-leak.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-glk6/igt@gem_ppgtt@flink-and-close-vma-leak.html - shard-tglb: [PASS][13] -> [FAIL][14] ([i915#644]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-tglb3/igt@gem_ppgtt@flink-and-close-vma-leak.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-tglb1/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_workarounds@suspend-resume-context: - shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +5 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-apl6/igt@gem_workarounds@suspend-resume-context.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-apl1/igt@gem_workarounds@suspend-resume-context.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +5 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-kbl7/igt@gem_workarounds@suspend-resume-fd.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [PASS][19] -> [DMESG-WARN][20] ([i915#716]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-glk2/igt@gen9_exec_parse@allowed-all.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-glk1/igt@gen9_exec_parse@allowed-all.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-skl: [PASS][21] -> [INCOMPLETE][22] ([i915#69]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-skl10/igt@i915_suspend@fence-restore-tiled2untiled.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-skl8/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_flip@plain-flip-fb-recreate: - shard-skl: [PASS][23] -> [FAIL][24] ([i915#34]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-skl4/igt@kms_flip@plain-flip-fb-recreate.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-skl5/igt@kms_flip@plain-flip-fb-recreate.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite: - shard-glk: [PASS][25] -> [FAIL][26] ([i915#49]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-glk: [PASS][29] -> [FAIL][30] ([i915#899]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-glk8/igt@kms_plane_lowres@pipe-a-tiling-x.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-glk2/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +2 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html * igt@perf_pmu@busy-accuracy-98-vcs1: - shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#112080]) +9 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb4/igt@perf_pmu@busy-accuracy-98-vcs1.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb5/igt@perf_pmu@busy-accuracy-98-vcs1.html #### Possible fixes #### * igt@gem_ctx_persistence@close-replace-race: - shard-kbl: [INCOMPLETE][35] ([i915#1402]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-kbl1/igt@gem_ctx_persistence@close-replace-race.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-kbl3/igt@gem_ctx_persistence@close-replace-race.html - shard-iclb: [INCOMPLETE][37] ([i915#1402]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb7/igt@gem_ctx_persistence@close-replace-race.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb7/igt@gem_ctx_persistence@close-replace-race.html * igt@gem_ctx_persistence@engines-mixed-process@vecs0: - shard-kbl: [FAIL][39] ([i915#679]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-kbl7/igt@gem_ctx_persistence@engines-mixed-process@vecs0.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-kbl7/igt@gem_ctx_persistence@engines-mixed-process@vecs0.html * igt@gem_exec_schedule@implicit-both-bsd1: - shard-iclb: [SKIP][41] ([fdo#109276] / [i915#677]) -> [PASS][42] +1 similar issue [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb3/igt@gem_exec_schedule@implicit-both-bsd1.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb2/igt@gem_exec_schedule@implicit-both-bsd1.html * igt@gem_exec_schedule@pi-distinct-iova-bsd: - shard-iclb: [SKIP][43] ([i915#677]) -> [PASS][44] +1 similar issue [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb4/igt@gem_exec_schedule@pi-distinct-iova-bsd.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb5/igt@gem_exec_schedule@pi-distinct-iova-bsd.html * igt@gem_exec_schedule@preemptive-hang-bsd: - shard-iclb: [SKIP][45] ([fdo#112146]) -> [PASS][46] +9 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html * igt@gem_exec_whisper@basic-fds-priority: - shard-glk: [DMESG-WARN][47] ([i915#118] / [i915#95]) -> [PASS][48] +1 similar issue [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-glk3/igt@gem_exec_whisper@basic-fds-priority.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-glk8/igt@gem_exec_whisper@basic-fds-priority.html * igt@i915_pm_rps@waitboost: - shard-iclb: [FAIL][49] ([i915#413]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb6/igt@i915_pm_rps@waitboost.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb8/igt@i915_pm_rps@waitboost.html * igt@kms_cursor_crc@pipe-a-cursor-dpms: - shard-skl: [FAIL][51] ([i915#54]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-skl9/igt@kms_cursor_crc@pipe-a-cursor-dpms.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-dpms.html * igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled: - shard-glk: [FAIL][53] ([i915#52] / [i915#54]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-glk8/igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-glk6/igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [FAIL][55] ([i915#79]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_hdr@bpc-switch: - shard-skl: [FAIL][57] ([i915#1188]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-skl1/igt@kms_hdr@bpc-switch.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-skl3/igt@kms_hdr@bpc-switch.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-apl: [DMESG-WARN][59] ([i915#180]) -> [PASS][60] +3 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html - shard-kbl: [DMESG-WARN][61] ([i915#180]) -> [PASS][62] +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [FAIL][63] ([fdo#108145]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-glk: [FAIL][65] ([i915#899]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-glk8/igt@kms_plane_lowres@pipe-a-tiling-y.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-glk6/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@psr2_sprite_render: - shard-iclb: [SKIP][67] ([fdo#109441]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb3/igt@kms_psr@psr2_sprite_render.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb2/igt@kms_psr@psr2_sprite_render.html * igt@perf_pmu@busy-no-semaphores-vcs1: - shard-iclb: [SKIP][69] ([fdo#112080]) -> [PASS][70] +12 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb8/igt@perf_pmu@busy-no-semaphores-vcs1.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb2/igt@perf_pmu@busy-no-semaphores-vcs1.html * igt@prime_busy@hang-bsd2: - shard-iclb: [SKIP][71] ([fdo#109276]) -> [PASS][72] +15 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb8/igt@prime_busy@hang-bsd2.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb2/igt@prime_busy@hang-bsd2.html #### Warnings #### * igt@gem_ctx_persistence@close-replace-race: - shard-skl: [INCOMPLETE][73] ([i915#1402]) -> [TIMEOUT][74] ([i915#1340]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-skl4/igt@gem_ctx_persistence@close-replace-race.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-skl5/igt@gem_ctx_persistence@close-replace-race.html * igt@gem_linear_blits@normal: - shard-apl: [TIMEOUT][75] ([i915#1322]) -> [TIMEOUT][76] ([fdo#111732] / [i915#1322]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-apl1/igt@gem_linear_blits@normal.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-apl3/igt@gem_linear_blits@normal.html * igt@i915_pm_dc@dc6-dpms: - shard-tglb: [SKIP][77] ([i915#468]) -> [FAIL][78] ([i915#454]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-tglb8/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_dc@dc6-psr: - shard-tglb: [FAIL][79] ([i915#454]) -> [SKIP][80] ([i915#468]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-tglb3/igt@i915_pm_dc@dc6-psr.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-tglb2/igt@i915_pm_dc@dc6-psr.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][81] ([fdo#109349]) -> [DMESG-WARN][82] ([i915#1226]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-iclb8/igt@kms_dp_dsc@basic-dsc-enable-edp.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-kbl: [DMESG-WARN][83] ([i915#180]) -> [INCOMPLETE][84] ([i915#155]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@runner@aborted: - shard-kbl: ([FAIL][85], [FAIL][86]) ([i915#1389] / [i915#1402] / [i915#92]) -> [FAIL][87] ([i915#92]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-kbl1/igt@runner@aborted.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8112/shard-kbl1/igt@runner@aborted.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/shard-kbl3/igt@runner@aborted.html [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111732]: https://bugs.freedesktop.org/show_bug.cgi?id=111732 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226 [i915#1322]: https://gitlab.freedesktop.org/drm/intel/issues/1322 [i915#1340]: https://gitlab.freedesktop.org/drm/intel/issues/1340 [i915#1389]: https://gitlab.freedesktop.org/drm/intel/issues/1389 [i915#1402]: https://gitlab.freedesktop.org/drm/intel/issues/1402 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8112 -> Patchwork_16911 CI-20190529: 20190529 CI_DRM_8112: 032f2fe5c92eb1db6d417738431153c001a41bcc @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5504: d6788bf0404f76b66170e18eb26c85004b5ccb25 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16911: 1d291f34ab62143871b49b78d833e0897c26ffa8 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16911/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH v3] drm/i915: Add missing HDMI audio pixel clocks for gen12 2020-03-10 16:23 [Intel-gfx] [PATCH v3] drm/i915: Add missing HDMI audio pixel clocks for gen12 Kai Vehmanen 2020-03-11 9:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add missing HDMI audio pixel clocks for gen12 (rev4) Patchwork 2020-03-11 17:39 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2020-03-11 18:32 ` Ville Syrjälä 2 siblings, 0 replies; 4+ messages in thread From: Ville Syrjälä @ 2020-03-11 18:32 UTC (permalink / raw) To: Kai Vehmanen; +Cc: intel-gfx On Tue, Mar 10, 2020 at 06:23:38PM +0200, Kai Vehmanen wrote: > Gen12 hardware supports HDMI audio pixel clocks of 296.7/297Mhz > and 593.4/594Mhz. Add the missing rates and add logic to ignore > them if running on older hardware. > > Bspec: 49333 > Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Thanks. Pushed to dinq. > --- > drivers/gpu/drm/i915/display/intel_audio.c | 8 ++++++++ > drivers/gpu/drm/i915/i915_reg.h | 4 ++++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c > index 19bf206037c2..62f234f641de 100644 > --- a/drivers/gpu/drm/i915/display/intel_audio.c > +++ b/drivers/gpu/drm/i915/display/intel_audio.c > @@ -149,6 +149,10 @@ static const struct { > { 74250, AUD_CONFIG_PIXEL_CLOCK_HDMI_74250 }, > { 148352, AUD_CONFIG_PIXEL_CLOCK_HDMI_148352 }, > { 148500, AUD_CONFIG_PIXEL_CLOCK_HDMI_148500 }, > + { 296703, AUD_CONFIG_PIXEL_CLOCK_HDMI_296703 }, > + { 297000, AUD_CONFIG_PIXEL_CLOCK_HDMI_297000 }, > + { 593407, AUD_CONFIG_PIXEL_CLOCK_HDMI_593407 }, > + { 594000, AUD_CONFIG_PIXEL_CLOCK_HDMI_594000 }, > }; > > /* HDMI N/CTS table */ > @@ -234,6 +238,7 @@ static const struct hdmi_aud_ncts hdmi_aud_ncts_36bpp[] = { > /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */ > static u32 audio_config_hdmi_pixel_clock(const struct intel_crtc_state *crtc_state) > { > + struct drm_i915_private *dev_priv = to_i915(crtc_state->uapi.crtc->dev); > const struct drm_display_mode *adjusted_mode = > &crtc_state->hw.adjusted_mode; > int i; > @@ -243,6 +248,9 @@ static u32 audio_config_hdmi_pixel_clock(const struct intel_crtc_state *crtc_sta > break; > } > > + if (INTEL_GEN(dev_priv) < 12 && adjusted_mode->crtc_clock > 148500) > + i = ARRAY_SIZE(hdmi_audio_clock); > + > if (i == ARRAY_SIZE(hdmi_audio_clock)) { > DRM_DEBUG_KMS("HDMI audio pixel clock setting for %d not found, falling back to defaults\n", > adjusted_mode->crtc_clock); > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 79ae9654dac9..ee4a75ac9186 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -9251,6 +9251,10 @@ enum { > #define AUD_CONFIG_PIXEL_CLOCK_HDMI_74250 (7 << 16) > #define AUD_CONFIG_PIXEL_CLOCK_HDMI_148352 (8 << 16) > #define AUD_CONFIG_PIXEL_CLOCK_HDMI_148500 (9 << 16) > +#define AUD_CONFIG_PIXEL_CLOCK_HDMI_296703 (10 << 16) > +#define AUD_CONFIG_PIXEL_CLOCK_HDMI_297000 (11 << 16) > +#define AUD_CONFIG_PIXEL_CLOCK_HDMI_593407 (12 << 16) > +#define AUD_CONFIG_PIXEL_CLOCK_HDMI_594000 (13 << 16) > #define AUD_CONFIG_DISABLE_NCTS (1 << 3) > > /* HSW Audio */ > -- > 2.17.1 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-11 18:32 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-10 16:23 [Intel-gfx] [PATCH v3] drm/i915: Add missing HDMI audio pixel clocks for gen12 Kai Vehmanen 2020-03-11 9:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add missing HDMI audio pixel clocks for gen12 (rev4) Patchwork 2020-03-11 17:39 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-03-11 18:32 ` [Intel-gfx] [PATCH v3] drm/i915: Add missing HDMI audio pixel clocks for gen12 Ville Syrjälä
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).