* [Intel-gfx] [PATCH] drm/i915/gem: Check for a closed context when looking up an engine
@ 2020-03-16 16:14 Chris Wilson
2020-03-16 23:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Chris Wilson @ 2020-03-16 16:14 UTC (permalink / raw)
To: intel-gfx
Beware that the context may already be closed as we try to lookup an
engine.
Closes: https://gitlab.freedesktop.org/drm/intel/issues/1389
Fixes: 130a95e9098e ("drm/i915/gem: Consolidate ctx->engines[] release")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_context.h | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.h b/drivers/gpu/drm/i915/gem/i915_gem_context.h
index 57b7ae2893e1..a09fd67fed1d 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.h
@@ -192,12 +192,16 @@ i915_gem_context_unlock_engines(struct i915_gem_context *ctx)
static inline struct intel_context *
i915_gem_context_get_engine(struct i915_gem_context *ctx, unsigned int idx)
{
- struct intel_context *ce = ERR_PTR(-EINVAL);
+ struct intel_context *ce;
rcu_read_lock(); {
struct i915_gem_engines *e = rcu_dereference(ctx->engines);
- if (likely(idx < e->num_engines && e->engines[idx]))
+ if (unlikely(e == NULL)) /* context was closed! */
+ ce = ERR_PTR(-ENOENT);
+ else if (likely(idx < e->num_engines && e->engines[idx]))
ce = intel_context_get(e->engines[idx]);
+ else
+ ce = ERR_PTR(-EINVAL);
} rcu_read_unlock();
return ce;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Check for a closed context when looking up an engine
2020-03-16 16:14 [Intel-gfx] [PATCH] drm/i915/gem: Check for a closed context when looking up an engine Chris Wilson
@ 2020-03-16 23:18 ` Patchwork
2020-03-16 23:34 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-03-16 23:18 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Check for a closed context when looking up an engine
URL : https://patchwork.freedesktop.org/series/74750/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a3c39e8196a9 drm/i915/gem: Check for a closed context when looking up an engine
-:30: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!e"
#30: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.h:199:
+ if (unlikely(e == NULL)) /* context was closed! */
total: 0 errors, 0 warnings, 1 checks, 18 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gem: Check for a closed context when looking up an engine
2020-03-16 16:14 [Intel-gfx] [PATCH] drm/i915/gem: Check for a closed context when looking up an engine Chris Wilson
2020-03-16 23:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2020-03-16 23:34 ` Patchwork
2020-03-16 23:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-03-16 23:34 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Check for a closed context when looking up an engine
URL : https://patchwork.freedesktop.org/series/74750/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
Error: Cannot open file ./drivers/gpu/drm/i915/i915_gem_fence_reg.c
Error: Cannot open file ./drivers/gpu/drm/i915/i915_gem_fence_reg.c
Error: Cannot open file ./drivers/gpu/drm/i915/i915_gem_fence_reg.c
Error: Cannot open file ./drivers/gpu/drm/i915/i915_gem_fence_reg.c
WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -internal ./drivers/gpu/drm/i915/i915_gem_fence_reg.c' failed with return code 2
WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -function fence register handling ./drivers/gpu/drm/i915/i915_gem_fence_reg.c' failed with return code 1
WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -function tiling swizzling details ./drivers/gpu/drm/i915/i915_gem_fence_reg.c' failed with return code 1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Check for a closed context when looking up an engine
2020-03-16 16:14 [Intel-gfx] [PATCH] drm/i915/gem: Check for a closed context when looking up an engine Chris Wilson
2020-03-16 23:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-03-16 23:34 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
@ 2020-03-16 23:47 ` Patchwork
2020-03-17 7:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-17 8:30 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-03-16 23:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Check for a closed context when looking up an engine
URL : https://patchwork.freedesktop.org/series/74750/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8138 -> Patchwork_16984
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/index.html
Known issues
------------
Here are the changes found in Patchwork_16984 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@fds:
- fi-tgl-y: [PASS][1] -> [INCOMPLETE][2] ([CI#94] / [i915#470] / [i915#529])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/fi-tgl-y/igt@gem_exec_parallel@fds.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/fi-tgl-y/igt@gem_exec_parallel@fds.html
* igt@i915_selftest@live@execlists:
- fi-skl-guc: [PASS][3] -> [INCOMPLETE][4] ([i915#656])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/fi-skl-guc/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/fi-skl-guc/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@requests:
- fi-bwr-2160: [PASS][5] -> [INCOMPLETE][6] ([i915#1457])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/fi-bwr-2160/igt@i915_selftest@live@requests.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/fi-bwr-2160/igt@i915_selftest@live@requests.html
#### Possible fixes ####
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-cml-u2: [FAIL][7] ([i915#217]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/fi-cml-u2/igt@kms_chamelium@common-hpd-after-suspend.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/fi-cml-u2/igt@kms_chamelium@common-hpd-after-suspend.html
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[i915#1457]: https://gitlab.freedesktop.org/drm/intel/issues/1457
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470
[i915#529]: https://gitlab.freedesktop.org/drm/intel/issues/529
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
Participating hosts (40 -> 44)
------------------------------
Additional (8): fi-bdw-5557u fi-hsw-peppy fi-skl-6770hq fi-ilk-650 fi-gdg-551 fi-ivb-3770 fi-cfl-8109u fi-snb-2600
Missing (4): fi-byt-squawks fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8138 -> Patchwork_16984
CI-20190529: 20190529
CI_DRM_8138: 652084cff0971058d1acb1746001f89ef8ea7321 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5512: f6fef7eff6f121e5e89afd7e70116f471ccd5b8b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16984: a3c39e8196a999b51e95f43ebf36887facede60d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a3c39e8196a9 drm/i915/gem: Check for a closed context when looking up an engine
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Check for a closed context when looking up an engine
2020-03-16 16:14 [Intel-gfx] [PATCH] drm/i915/gem: Check for a closed context when looking up an engine Chris Wilson
` (2 preceding siblings ...)
2020-03-16 23:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-03-17 7:47 ` Patchwork
2020-03-17 8:30 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-03-17 7:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Check for a closed context when looking up an engine
URL : https://patchwork.freedesktop.org/series/74750/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8138_full -> Patchwork_16984_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16984_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@sysfs_preempt_timeout@timeout@rcs0}:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl1/igt@sysfs_preempt_timeout@timeout@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl4/igt@sysfs_preempt_timeout@timeout@rcs0.html
New tests
---------
New tests have been introduced between CI_DRM_8138_full and Patchwork_16984_full:
### New IGT tests (1) ###
* igt@sysfs_heartbeat_interval@off:
- Statuses :
- Exec time: [None] s
Known issues
------------
Here are the changes found in Patchwork_16984_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@close-replace-race:
- shard-skl: [PASS][3] -> [INCOMPLETE][4] ([i915#1402])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl8/igt@gem_ctx_persistence@close-replace-race.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl6/igt@gem_ctx_persistence@close-replace-race.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process@blt:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#679])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-tglb7/igt@gem_ctx_persistence@legacy-engines-mixed-process@blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-tglb6/igt@gem_ctx_persistence@legacy-engines-mixed-process@blt.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox:
- shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([i915#1239])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-tglb7/igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-tglb6/igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#110841])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_schedule@implicit-write-read-bsd2:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276] / [i915#677])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb1/igt@gem_exec_schedule@implicit-write-read-bsd2.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb3/igt@gem_exec_schedule@implicit-write-read-bsd2.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109276]) +14 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb1/igt@gem_exec_schedule@independent-bsd2.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb8/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_exec_schedule@pi-userfault-bsd:
- shard-iclb: [PASS][15] -> [SKIP][16] ([i915#677])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb8/igt@gem_exec_schedule@pi-userfault-bsd.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb1/igt@gem_exec_schedule@pi-userfault-bsd.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_whisper@basic-fds-all:
- shard-iclb: [PASS][19] -> [INCOMPLETE][20] ([i915#1401])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb8/igt@gem_exec_whisper@basic-fds-all.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb1/igt@gem_exec_whisper@basic-fds-all.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [PASS][21] -> [FAIL][22] ([i915#644])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-apl6/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_tiled_swapping@non-threaded:
- shard-kbl: [PASS][23] -> [DMESG-WARN][24] ([i915#183])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-kbl7/igt@gem_tiled_swapping@non-threaded.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-kbl6/igt@gem_tiled_swapping@non-threaded.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#454])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl10/igt@i915_pm_dc@dc6-psr.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl6/igt@i915_pm_dc@dc6-psr.html
* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#54])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl5/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
- shard-kbl: [PASS][29] -> [FAIL][30] ([i915#54])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
- shard-apl: [PASS][31] -> [FAIL][32] ([i915#54])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][33] -> [DMESG-WARN][34] ([i915#180])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#34])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl9/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-move:
- shard-glk: [PASS][37] -> [FAIL][38] ([i915#49])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-move.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-move.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#1188])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl4/igt@kms_hdr@bpc-switch.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl1/igt@kms_hdr@bpc-switch.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-skl: [PASS][41] -> [INCOMPLETE][42] ([i915#69])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109642] / [fdo#111068])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb2/igt@kms_psr2_su@page_flip.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb3/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#109441])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb5/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][47] -> [DMESG-WARN][48] ([i915#180]) +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@perf_pmu@busy-vcs1:
- shard-iclb: [PASS][49] -> [SKIP][50] ([fdo#112080]) +14 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb1/igt@perf_pmu@busy-vcs1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb8/igt@perf_pmu@busy-vcs1.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][51] ([fdo#112080]) -> [PASS][52] +10 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb8/igt@gem_busy@busy-vcs1.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb1/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_persistence@close-replace-race:
- shard-apl: [INCOMPLETE][53] ([fdo#103927] / [i915#1402]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-apl3/igt@gem_ctx_persistence@close-replace-race.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-apl3/igt@gem_ctx_persistence@close-replace-race.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][55] ([fdo#110854]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb3/igt@gem_exec_balancer@smoke.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb4/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@pi-distinct-iova-render:
- shard-skl: [DMESG-WARN][57] ([i915#836]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl10/igt@gem_exec_schedule@pi-distinct-iova-render.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl2/igt@gem_exec_schedule@pi-distinct-iova-render.html
* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [SKIP][59] ([i915#677]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb2/igt@gem_exec_schedule@pi-shared-iova-bsd.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb3/igt@gem_exec_schedule@pi-shared-iova-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][61] ([fdo#109276]) -> [PASS][62] +16 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@preempt-queue-contexts-render:
- shard-skl: [FAIL][63] -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl3/igt@gem_exec_schedule@preempt-queue-contexts-render.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl10/igt@gem_exec_schedule@preempt-queue-contexts-render.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][65] ([fdo#112146]) -> [PASS][66] +5 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb2/igt@gem_exec_schedule@reorder-wide-bsd.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@i915_pm_rps@reset:
- shard-iclb: [FAIL][67] ([i915#413]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb3/igt@i915_pm_rps@reset.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb4/igt@i915_pm_rps@reset.html
* igt@kms_color@pipe-c-ctm-0-5:
- shard-skl: [FAIL][69] ([i915#182]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl1/igt@kms_color@pipe-c-ctm-0-5.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl4/igt@kms_color@pipe-c-ctm-0-5.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [FAIL][71] ([i915#72]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-hsw: [FAIL][73] ([i915#57]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][75] ([IGT#5]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [DMESG-WARN][77] ([i915#180]) -> [PASS][78] +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@plain-flip-ts-check-interruptible:
- shard-glk: [FAIL][79] ([i915#34]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-glk2/igt@kms_flip@plain-flip-ts-check-interruptible.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-glk7/igt@kms_flip@plain-flip-ts-check-interruptible.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-skl: [INCOMPLETE][81] ([i915#69]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
- shard-kbl: [DMESG-WARN][83] ([i915#180]) -> [PASS][84] +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][85] ([fdo#108145] / [i915#265]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][87] ([fdo#109441]) -> [PASS][88] +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][89] ([i915#588]) -> [SKIP][90] ([i915#658])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-iclb3/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-snb: [INCOMPLETE][91] ([i915#82]) -> [SKIP][92] ([fdo#109271])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-snb5/igt@i915_pm_rpm@dpms-non-lpsp.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-snb5/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@runner@aborted:
- shard-apl: ([FAIL][93], [FAIL][94]) ([fdo#103927] / [i915#1402]) -> [FAIL][95] ([fdo#103927])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-apl3/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-apl2/igt@runner@aborted.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-apl8/igt@runner@aborted.html
- shard-skl: [FAIL][96] ([i915#69]) -> [FAIL][97] ([i915#1402] / [i915#69])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8138/shard-skl10/igt@runner@aborted.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/shard-skl6/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1239]: https://gitlab.freedesktop.org/drm/intel/issues/1239
[i915#1401]: https://gitlab.freedesktop.org/drm/intel/issues/1401
[i915#1402]: https://gitlab.freedesktop.org/drm/intel/issues/1402
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#182]: https://gitlab.freedesktop.org/drm/intel/issues/182
[i915#183]: https://gitlab.freedesktop.org/drm/intel/issues/183
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#836]: https://gitlab.freedesktop.org/drm/intel/issues/836
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8138 -> Patchwork_16984
CI-20190529: 20190529
CI_DRM_8138: 652084cff0971058d1acb1746001f89ef8ea7321 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5512: f6fef7eff6f121e5e89afd7e70116f471ccd5b8b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16984: a3c39e8196a999b51e95f43ebf36887facede60d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16984/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem: Check for a closed context when looking up an engine
2020-03-16 16:14 [Intel-gfx] [PATCH] drm/i915/gem: Check for a closed context when looking up an engine Chris Wilson
` (3 preceding siblings ...)
2020-03-17 7:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2020-03-17 8:30 ` Tvrtko Ursulin
4 siblings, 0 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2020-03-17 8:30 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 16/03/2020 16:14, Chris Wilson wrote:
> Beware that the context may already be closed as we try to lookup an
> engine.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/1389
> Fixes: 130a95e9098e ("drm/i915/gem: Consolidate ctx->engines[] release")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.h | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.h b/drivers/gpu/drm/i915/gem/i915_gem_context.h
> index 57b7ae2893e1..a09fd67fed1d 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.h
> @@ -192,12 +192,16 @@ i915_gem_context_unlock_engines(struct i915_gem_context *ctx)
> static inline struct intel_context *
> i915_gem_context_get_engine(struct i915_gem_context *ctx, unsigned int idx)
> {
> - struct intel_context *ce = ERR_PTR(-EINVAL);
> + struct intel_context *ce;
>
> rcu_read_lock(); {
> struct i915_gem_engines *e = rcu_dereference(ctx->engines);
> - if (likely(idx < e->num_engines && e->engines[idx]))
> + if (unlikely(e == NULL)) /* context was closed! */
> + ce = ERR_PTR(-ENOENT);
> + else if (likely(idx < e->num_engines && e->engines[idx]))
> ce = intel_context_get(e->engines[idx]);
> + else
> + ce = ERR_PTR(-EINVAL);
> } rcu_read_unlock();
>
> return ce;
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-17 8:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 16:14 [Intel-gfx] [PATCH] drm/i915/gem: Check for a closed context when looking up an engine Chris Wilson
2020-03-16 23:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-03-16 23:34 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-03-16 23:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-17 7:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-17 8:30 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).