* [Intel-gfx] [CI] perf/core: Only copy-to-user after completely unlocking all locks, v3.
@ 2020-05-02 17:14 Chris Wilson
2020-05-02 17:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for perf/core: Only copy-to-user after completely unlocking all locks, v3. (rev3) Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2020-05-02 17:14 UTC (permalink / raw)
To: intel-gfx
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
We inadvertently create a dependency on mmap_sem with a whole chain.
This breaks any user who wants to take a lock and call rcu_barrier(),
while also taking that lock inside mmap_sem:
<4> [604.892532] ======================================================
<4> [604.892534] WARNING: possible circular locking dependency detected
<4> [604.892536] 5.6.0-rc7-CI-Patchwork_17096+ #1 Tainted: G U
<4> [604.892537] ------------------------------------------------------
<4> [604.892538] kms_frontbuffer/2595 is trying to acquire lock:
<4> [604.892540] ffffffff8264a558 (rcu_state.barrier_mutex){+.+.}, at: rcu_barrier+0x23/0x190
<4> [604.892547]
but task is already holding lock:
<4> [604.892547] ffff888484716050 (reservation_ww_class_mutex){+.+.}, at: i915_gem_object_pin_to_display_plane+0x89/0x270 [i915]
<4> [604.892592]
which lock already depends on the new lock.
<4> [604.892593]
the existing dependency chain (in reverse order) is:
<4> [604.892594]
-> #6 (reservation_ww_class_mutex){+.+.}:
<4> [604.892597] __ww_mutex_lock.constprop.15+0xc3/0x1090
<4> [604.892598] ww_mutex_lock+0x39/0x70
<4> [604.892600] dma_resv_lockdep+0x10e/0x1f5
<4> [604.892602] do_one_initcall+0x58/0x300
<4> [604.892604] kernel_init_freeable+0x17b/0x1dc
<4> [604.892605] kernel_init+0x5/0x100
<4> [604.892606] ret_from_fork+0x24/0x50
<4> [604.892607]
-> #5 (reservation_ww_class_acquire){+.+.}:
<4> [604.892609] dma_resv_lockdep+0xec/0x1f5
<4> [604.892610] do_one_initcall+0x58/0x300
<4> [604.892610] kernel_init_freeable+0x17b/0x1dc
<4> [604.892611] kernel_init+0x5/0x100
<4> [604.892612] ret_from_fork+0x24/0x50
<4> [604.892613]
-> #4 (&mm->mmap_sem#2){++++}:
<4> [604.892615] __might_fault+0x63/0x90
<4> [604.892617] _copy_to_user+0x1e/0x80
<4> [604.892619] perf_read+0x200/0x2b0
<4> [604.892621] vfs_read+0x96/0x160
<4> [604.892622] ksys_read+0x9f/0xe0
<4> [604.892623] do_syscall_64+0x4f/0x220
<4> [604.892624] entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4> [604.892625]
-> #3 (&cpuctx_mutex){+.+.}:
<4> [604.892626] __mutex_lock+0x9a/0x9c0
<4> [604.892627] perf_event_init_cpu+0xa4/0x140
<4> [604.892629] perf_event_init+0x19d/0x1cd
<4> [604.892630] start_kernel+0x362/0x4e4
<4> [604.892631] secondary_startup_64+0xa4/0xb0
<4> [604.892631]
-> #2 (pmus_lock){+.+.}:
<4> [604.892633] __mutex_lock+0x9a/0x9c0
<4> [604.892633] perf_event_init_cpu+0x6b/0x140
<4> [604.892635] cpuhp_invoke_callback+0x9b/0x9d0
<4> [604.892636] _cpu_up+0xa2/0x140
<4> [604.892637] do_cpu_up+0x61/0xa0
<4> [604.892639] smp_init+0x57/0x96
<4> [604.892639] kernel_init_freeable+0x87/0x1dc
<4> [604.892640] kernel_init+0x5/0x100
<4> [604.892642] ret_from_fork+0x24/0x50
<4> [604.892642]
-> #1 (cpu_hotplug_lock.rw_sem){++++}:
<4> [604.892643] cpus_read_lock+0x34/0xd0
<4> [604.892644] rcu_barrier+0xaa/0x190
<4> [604.892645] kernel_init+0x21/0x100
<4> [604.892647] ret_from_fork+0x24/0x50
<4> [604.892647]
-> #0 (rcu_state.barrier_mutex){+.+.}:
<4> [604.892649] __lock_acquire+0x1328/0x15d0
<4> [604.892650] lock_acquire+0xa7/0x1c0
<4> [604.892651] __mutex_lock+0x9a/0x9c0
<4> [604.892652] rcu_barrier+0x23/0x190
<4> [604.892680] i915_gem_object_unbind+0x29d/0x3f0 [i915]
<4> [604.892707] i915_gem_object_pin_to_display_plane+0x141/0x270 [i915]
<4> [604.892737] intel_pin_and_fence_fb_obj+0xec/0x1f0 [i915]
<4> [604.892767] intel_plane_pin_fb+0x3f/0xd0 [i915]
<4> [604.892797] intel_prepare_plane_fb+0x13b/0x5c0 [i915]
<4> [604.892798] drm_atomic_helper_prepare_planes+0x85/0x110
<4> [604.892827] intel_atomic_commit+0xda/0x390 [i915]
<4> [604.892828] drm_atomic_helper_set_config+0x57/0xa0
<4> [604.892830] drm_mode_setcrtc+0x1c4/0x720
<4> [604.892830] drm_ioctl_kernel+0xb0/0xf0
<4> [604.892831] drm_ioctl+0x2e1/0x390
<4> [604.892833] ksys_ioctl+0x7b/0x90
<4> [604.892835] __x64_sys_ioctl+0x11/0x20
<4> [604.892835] do_syscall_64+0x4f/0x220
<4> [604.892836] entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4> [604.892837]
Changes since v1:
- Use (*values)[n++] in perf_read_one().
Changes since v2:
- Centrally allocate values.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
fixup perf patch
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
kernel/events/core.c | 48 ++++++++++++++++++++++----------------------
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 33054521ea5d..bd9c488330f0 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -5102,20 +5102,16 @@ static int __perf_read_group_add(struct perf_event *leader,
}
static int perf_read_group(struct perf_event *event,
- u64 read_format, char __user *buf)
+ u64 read_format, char __user *buf,
+ u64 *values)
{
struct perf_event *leader = event->group_leader, *child;
struct perf_event_context *ctx = leader->ctx;
int ret;
- u64 *values;
lockdep_assert_held(&ctx->mutex);
- values = kzalloc(event->read_size, GFP_KERNEL);
- if (!values)
- return -ENOMEM;
-
- values[0] = 1 + leader->nr_siblings;
+ *values = 1 + leader->nr_siblings;
/*
* By locking the child_mutex of the leader we effectively
@@ -5133,25 +5129,17 @@ static int perf_read_group(struct perf_event *event,
goto unlock;
}
- mutex_unlock(&leader->child_mutex);
-
ret = event->read_size;
- if (copy_to_user(buf, values, event->read_size))
- ret = -EFAULT;
- goto out;
-
unlock:
mutex_unlock(&leader->child_mutex);
-out:
- kfree(values);
return ret;
}
static int perf_read_one(struct perf_event *event,
- u64 read_format, char __user *buf)
+ u64 read_format, char __user *buf,
+ u64 *values)
{
u64 enabled, running;
- u64 values[4];
int n = 0;
values[n++] = __perf_event_read_value(event, &enabled, &running);
@@ -5162,9 +5150,6 @@ static int perf_read_one(struct perf_event *event,
if (read_format & PERF_FORMAT_ID)
values[n++] = primary_event_id(event);
- if (copy_to_user(buf, values, n * sizeof(u64)))
- return -EFAULT;
-
return n * sizeof(u64);
}
@@ -5185,7 +5170,8 @@ static bool is_event_hup(struct perf_event *event)
* Read the performance event - simple non blocking version for now
*/
static ssize_t
-__perf_read(struct perf_event *event, char __user *buf, size_t count)
+__perf_read(struct perf_event *event, char __user *buf,
+ size_t count, u64 *values)
{
u64 read_format = event->attr.read_format;
int ret;
@@ -5203,9 +5189,9 @@ __perf_read(struct perf_event *event, char __user *buf, size_t count)
WARN_ON_ONCE(event->ctx->parent_ctx);
if (read_format & PERF_FORMAT_GROUP)
- ret = perf_read_group(event, read_format, buf);
+ ret = perf_read_group(event, read_format, buf, values);
else
- ret = perf_read_one(event, read_format, buf);
+ ret = perf_read_one(event, read_format, buf, values);
return ret;
}
@@ -5215,16 +5201,30 @@ perf_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
{
struct perf_event *event = file->private_data;
struct perf_event_context *ctx;
+ u64 stack_values[8];
+ u64 *values;
int ret;
ret = security_perf_event_read(event);
if (ret)
return ret;
+ values = stack_values;
+ if (event->read_size > sizeof(stack_values))
+ values = kzalloc(event->read_size, GFP_KERNEL);
+ if (!values)
+ return -ENOMEM;
+
ctx = perf_event_ctx_lock(event);
- ret = __perf_read(event, buf, count);
+ ret = __perf_read(event, buf, count, values);
perf_event_ctx_unlock(event, ctx);
+ if (ret > 0 && copy_to_user(buf, values, ret))
+ ret = -EFAULT;
+
+ if (values != stack_values)
+ kfree(values);
+
return ret;
}
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for perf/core: Only copy-to-user after completely unlocking all locks, v3. (rev3)
2020-05-02 17:14 [Intel-gfx] [CI] perf/core: Only copy-to-user after completely unlocking all locks, v3 Chris Wilson
@ 2020-05-02 17:50 ` Patchwork
2020-05-02 18:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-05-02 21:14 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-05-02 17:50 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: perf/core: Only copy-to-user after completely unlocking all locks, v3. (rev3)
URL : https://patchwork.freedesktop.org/series/76325/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9cb5cee2dd0e perf/core: Only copy-to-user after completely unlocking all locks, v3.
-:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17:
<4> [604.892540] ffffffff8264a558 (rcu_state.barrier_mutex){+.+.}, at: rcu_barrier+0x23/0x190
-:106: WARNING:BAD_SIGN_OFF: Duplicate signature
#106:
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
-:180: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#180: FILE: kernel/events/core.c:5174:
+__perf_read(struct perf_event *event, char __user *buf,
+ size_t count, u64 *values)
total: 0 errors, 2 warnings, 1 checks, 110 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for perf/core: Only copy-to-user after completely unlocking all locks, v3. (rev3)
2020-05-02 17:14 [Intel-gfx] [CI] perf/core: Only copy-to-user after completely unlocking all locks, v3 Chris Wilson
2020-05-02 17:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for perf/core: Only copy-to-user after completely unlocking all locks, v3. (rev3) Patchwork
@ 2020-05-02 18:13 ` Patchwork
2020-05-02 21:14 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-05-02 18:13 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: perf/core: Only copy-to-user after completely unlocking all locks, v3. (rev3)
URL : https://patchwork.freedesktop.org/series/76325/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8411 -> Patchwork_17553
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/index.html
Known issues
------------
Here are the changes found in Patchwork_17553 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@objects:
- fi-bwr-2160: [INCOMPLETE][1] ([i915#489]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/fi-bwr-2160/igt@i915_selftest@live@objects.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/fi-bwr-2160/igt@i915_selftest@live@objects.html
[i915#489]: https://gitlab.freedesktop.org/drm/intel/issues/489
Participating hosts (51 -> 43)
------------------------------
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8411 -> Patchwork_17553
CI-20190529: 20190529
CI_DRM_8411: b0821be4cf1a8ede85f8b93d4d28e0332f6fb334 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5626: f27fdfff026276ac75c69e487c929a843f66f6ca @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17553: 9cb5cee2dd0e976d529dfefbaa3e1b65eeef128f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9cb5cee2dd0e perf/core: Only copy-to-user after completely unlocking all locks, v3.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for perf/core: Only copy-to-user after completely unlocking all locks, v3. (rev3)
2020-05-02 17:14 [Intel-gfx] [CI] perf/core: Only copy-to-user after completely unlocking all locks, v3 Chris Wilson
2020-05-02 17:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for perf/core: Only copy-to-user after completely unlocking all locks, v3. (rev3) Patchwork
2020-05-02 18:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-05-02 21:14 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-05-02 21:14 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: perf/core: Only copy-to-user after completely unlocking all locks, v3. (rev3)
URL : https://patchwork.freedesktop.org/series/76325/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8411_full -> Patchwork_17553_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17553_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17553_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17553_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_balancer@full-late:
- shard-skl: [PASS][1] -> [FAIL][2] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-skl8/igt@gem_exec_balancer@full-late.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-skl5/igt@gem_exec_balancer@full-late.html
- shard-tglb: [PASS][3] -> [FAIL][4] +6 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-tglb2/igt@gem_exec_balancer@full-late.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-tglb8/igt@gem_exec_balancer@full-late.html
- shard-glk: [PASS][5] -> [FAIL][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-glk1/igt@gem_exec_balancer@full-late.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-glk7/igt@gem_exec_balancer@full-late.html
* igt@perf_pmu@all-busy-check-all:
- shard-kbl: [PASS][7] -> [FAIL][8] +5 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-kbl7/igt@perf_pmu@all-busy-check-all.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-kbl3/igt@perf_pmu@all-busy-check-all.html
* igt@perf_pmu@frequency:
- shard-iclb: [PASS][9] -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-iclb3/igt@perf_pmu@frequency.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-iclb2/igt@perf_pmu@frequency.html
- shard-apl: [PASS][11] -> [FAIL][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-apl6/igt@perf_pmu@frequency.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-apl6/igt@perf_pmu@frequency.html
- shard-hsw: [PASS][13] -> [FAIL][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-hsw7/igt@perf_pmu@frequency.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-hsw2/igt@perf_pmu@frequency.html
- shard-snb: [PASS][15] -> [FAIL][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-snb4/igt@perf_pmu@frequency.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-snb6/igt@perf_pmu@frequency.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@perf_pmu@busy-check-all@vcs0}:
- shard-glk: [PASS][17] -> [FAIL][18] +15 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-glk9/igt@perf_pmu@busy-check-all@vcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-glk7/igt@perf_pmu@busy-check-all@vcs0.html
* {igt@perf_pmu@busy-idle-check-all@rcs0}:
- shard-skl: [PASS][19] -> [FAIL][20] +23 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-skl8/igt@perf_pmu@busy-idle-check-all@rcs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-skl5/igt@perf_pmu@busy-idle-check-all@rcs0.html
- shard-tglb: [PASS][21] -> [FAIL][22] +35 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-tglb2/igt@perf_pmu@busy-idle-check-all@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-tglb8/igt@perf_pmu@busy-idle-check-all@rcs0.html
* {igt@perf_pmu@busy-idle-check-all@vcs0}:
- shard-apl: [PASS][23] -> [FAIL][24] +23 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-apl7/igt@perf_pmu@busy-idle-check-all@vcs0.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-apl3/igt@perf_pmu@busy-idle-check-all@vcs0.html
* {igt@perf_pmu@busy-idle-no-semaphores@vecs0}:
- shard-kbl: [PASS][25] -> [FAIL][26] +35 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-kbl2/igt@perf_pmu@busy-idle-no-semaphores@vecs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-kbl6/igt@perf_pmu@busy-idle-no-semaphores@vecs0.html
* {igt@perf_pmu@busy-no-semaphores@bcs0}:
- shard-hsw: [PASS][27] -> [FAIL][28] +19 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-hsw1/igt@perf_pmu@busy-no-semaphores@bcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-hsw2/igt@perf_pmu@busy-no-semaphores@bcs0.html
- shard-glk: NOTRUN -> [FAIL][29] +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-glk6/igt@perf_pmu@busy-no-semaphores@bcs0.html
* {igt@perf_pmu@idle-no-semaphores@vcs0}:
- shard-snb: [PASS][30] -> [FAIL][31] +10 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-snb4/igt@perf_pmu@idle-no-semaphores@vcs0.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-snb2/igt@perf_pmu@idle-no-semaphores@vcs0.html
* {igt@perf_pmu@most-busy-check-all@vcs1}:
- shard-iclb: NOTRUN -> [FAIL][32] +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-iclb1/igt@perf_pmu@most-busy-check-all@vcs1.html
* {igt@perf_pmu@semaphore-busy@bcs0}:
- shard-iclb: [PASS][33] -> [FAIL][34] +27 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-iclb2/igt@perf_pmu@semaphore-busy@bcs0.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-iclb8/igt@perf_pmu@semaphore-busy@bcs0.html
Known issues
------------
Here are the changes found in Patchwork_17553_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-mixed-process@render:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#1528])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-skl1/igt@gem_ctx_persistence@legacy-engines-mixed-process@render.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-skl2/igt@gem_ctx_persistence@legacy-engines-mixed-process@render.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][37] -> [DMESG-WARN][38] ([i915#180])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-apl7/igt@gem_workarounds@suspend-resume.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-apl4/igt@gem_workarounds@suspend-resume.html
* igt@i915_suspend@forcewake:
- shard-skl: [PASS][39] -> [INCOMPLETE][40] ([i915#69])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-skl3/igt@i915_suspend@forcewake.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-skl3/igt@i915_suspend@forcewake.html
* igt@kms_cursor_legacy@all-pipes-torture-bo:
- shard-snb: [PASS][41] -> [DMESG-WARN][42] ([i915#128])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-snb1/igt@kms_cursor_legacy@all-pipes-torture-bo.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-snb2/igt@kms_cursor_legacy@all-pipes-torture-bo.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109349])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-iclb8/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][45] -> [DMESG-WARN][46] ([i915#180]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109441]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-glk: [PASS][49] -> [FAIL][50] ([i915#43])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-glk8/igt@kms_vblank@pipe-c-accuracy-idle.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-glk9/igt@kms_vblank@pipe-c-accuracy-idle.html
#### Possible fixes ####
* igt@gem_exec_params@invalid-bsd-ring:
- shard-iclb: [SKIP][51] ([fdo#109276]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-iclb3/igt@gem_exec_params@invalid-bsd-ring.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-iclb2/igt@gem_exec_params@invalid-bsd-ring.html
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [DMESG-WARN][53] ([i915#716]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-apl7/igt@gen9_exec_parse@allowed-all.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-apl3/igt@gen9_exec_parse@allowed-all.html
* {igt@kms_flip@flip-vs-suspend-interruptible@a-dp1}:
- shard-kbl: [DMESG-WARN][55] ([i915#180]) -> [PASS][56] +8 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][57] ([i915#180] / [i915#95]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-apl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-apl8/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][59] ([i915#1188]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-skl8/igt@kms_hdr@bpc-switch.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-skl1/igt@kms_hdr@bpc-switch.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][61] ([i915#180]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][63] ([fdo#109642] / [fdo#111068]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-iclb3/igt@kms_psr2_su@frontbuffer.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +4 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][67] ([i915#658]) -> [SKIP][68] ([i915#588])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-iclb3/igt@i915_pm_dc@dc3co-vpb-simulation.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [FAIL][69] ([i915#454]) -> [SKIP][70] ([i915#468])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-tglb3/igt@i915_pm_dc@dc6-psr.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-tglb2/igt@i915_pm_dc@dc6-psr.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: [FAIL][71] ([fdo#108145] / [i915#265]) -> [FAIL][72] ([fdo#108145] / [i915#265] / [i915#95])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [FAIL][73] ([i915#608]) -> [SKIP][74] ([fdo#109642] / [fdo#111068])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8411/shard-iclb2/igt@kms_psr2_su@page_flip.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/shard-iclb8/igt@kms_psr2_su@page_flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#608]: https://gitlab.freedesktop.org/drm/intel/issues/608
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8411 -> Patchwork_17553
CI-20190529: 20190529
CI_DRM_8411: b0821be4cf1a8ede85f8b93d4d28e0332f6fb334 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5626: f27fdfff026276ac75c69e487c929a843f66f6ca @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17553: 9cb5cee2dd0e976d529dfefbaa3e1b65eeef128f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17553/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-02 21:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-02 17:14 [Intel-gfx] [CI] perf/core: Only copy-to-user after completely unlocking all locks, v3 Chris Wilson
2020-05-02 17:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for perf/core: Only copy-to-user after completely unlocking all locks, v3. (rev3) Patchwork
2020-05-02 18:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-05-02 21:14 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).