* [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes
@ 2020-07-02 13:06 Chris Wilson
2020-07-02 13:06 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: Only revoke mmap handlers if active Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Chris Wilson @ 2020-07-02 13:06 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
Only a GGTT mmaping will use the aperture detiling registers, so only a
tiling change for an object, we only need to revoke those mmapings and
not the CPU mmapings (which are always linear irrespective of the tiling).
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +-
drivers/gpu/drm/i915/gem/i915_gem_mman.h | 5 ++++-
drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 2 +-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index fe27c5b344e3..7c2650cfb070 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -448,7 +448,7 @@ void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
* mapping will then trigger a page fault on the next user access, allowing
* fixup by vm_fault_gtt().
*/
-static void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
+void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
{
struct drm_i915_private *i915 = to_i915(obj->base.dev);
intel_wakeref_t wakeref;
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.h b/drivers/gpu/drm/i915/gem/i915_gem_mman.h
index 862e01b7cb69..7c5ccdf59359 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.h
@@ -24,8 +24,11 @@ int i915_gem_dumb_mmap_offset(struct drm_file *file_priv,
struct drm_device *dev,
u32 handle, u64 *offset);
-void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
void i915_gem_object_release_mmap(struct drm_i915_gem_object *obj);
+
+void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
+void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
+
void i915_gem_object_release_mmap_offset(struct drm_i915_gem_object *obj);
#endif
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
index 0158e49bf9bb..ff72ee2fd9cd 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
@@ -299,7 +299,7 @@ i915_gem_object_set_tiling(struct drm_i915_gem_object *obj,
i915_gem_object_unlock(obj);
/* Force the fence to be reacquired for GTT access */
- i915_gem_object_release_mmap(obj);
+ i915_gem_object_release_mmap_gtt(obj);
/* Try to preallocate memory required to save swizzling on put-pages */
if (i915_gem_object_needs_bit17_swizzle(obj)) {
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: Only revoke mmap handlers if active
2020-07-02 13:06 [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes Chris Wilson
@ 2020-07-02 13:06 ` Chris Wilson
2020-07-02 13:10 ` Chris Wilson
2020-07-02 15:50 ` Tvrtko Ursulin
2020-07-02 14:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes Patchwork
` (2 subsequent siblings)
3 siblings, 2 replies; 7+ messages in thread
From: Chris Wilson @ 2020-07-02 13:06 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
Avoid waking up the device and taking stale locks if we know that the
object is not currently mmapped. This is particularly useful as not many
object are actually mmapped and so we can destroy them without waking
the device up, and gives us a little more freedom of workqueue ordering
during shutdown.
v2: Pull the release_mmap() into its single user in freeing the objects,
where there can not be any race with a concurrent user of the freed
object. Or so one hopes!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
---
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 13 -------------
drivers/gpu/drm/i915/gem/i915_gem_mman.h | 2 --
drivers/gpu/drm/i915/gem/i915_gem_object.c | 11 +++++++++++
3 files changed, 11 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index 7c2650cfb070..b23368529a40 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -507,19 +507,6 @@ void i915_gem_object_release_mmap_offset(struct drm_i915_gem_object *obj)
spin_unlock(&obj->mmo.lock);
}
-/**
- * i915_gem_object_release_mmap - remove physical page mappings
- * @obj: obj in question
- *
- * Preserve the reservation of the mmapping with the DRM core code, but
- * relinquish ownership of the pages back to the system.
- */
-void i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
-{
- i915_gem_object_release_mmap_gtt(obj);
- i915_gem_object_release_mmap_offset(obj);
-}
-
static struct i915_mmap_offset *
lookup_mmo(struct drm_i915_gem_object *obj,
enum i915_mmap_type mmap_type)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.h b/drivers/gpu/drm/i915/gem/i915_gem_mman.h
index 7c5ccdf59359..efee9e0d2508 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.h
@@ -24,8 +24,6 @@ int i915_gem_dumb_mmap_offset(struct drm_file *file_priv,
struct drm_device *dev,
u32 handle, u64 *offset);
-void i915_gem_object_release_mmap(struct drm_i915_gem_object *obj);
-
void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
index 6b69191c5543..d377c0ef8603 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
@@ -171,6 +171,17 @@ static void __i915_gem_free_object_rcu(struct rcu_head *head)
atomic_dec(&i915->mm.free_count);
}
+static void i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
+{
+ /* Skip serialisation and waking the device if known to be not used. */
+
+ if (obj->userfault_count)
+ i915_gem_object_release_mmap_gtt(obj);
+
+ if (!RB_EMPTY_ROOT(&obj->mmo.offsets))
+ i915_gem_object_release_mmap_offset(obj);
+}
+
static void __i915_gem_free_objects(struct drm_i915_private *i915,
struct llist_node *freed)
{
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: Only revoke mmap handlers if active
2020-07-02 13:06 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: Only revoke mmap handlers if active Chris Wilson
@ 2020-07-02 13:10 ` Chris Wilson
2020-07-02 15:50 ` Tvrtko Ursulin
1 sibling, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2020-07-02 13:10 UTC (permalink / raw)
To: intel-gfx
Quoting Chris Wilson (2020-07-02 14:06:05)
> Avoid waking up the device and taking stale locks if we know that the
> object is not currently mmapped. This is particularly useful as not many
> object are actually mmapped and so we can destroy them without waking
> the device up, and gives us a little more freedom of workqueue ordering
> during shutdown.
>
> v2: Pull the release_mmap() into its single user in freeing the objects,
> where there can not be any race with a concurrent user of the freed
> object. Or so one hopes!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
> ---
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 13 -------------
> drivers/gpu/drm/i915/gem/i915_gem_mman.h | 2 --
> drivers/gpu/drm/i915/gem/i915_gem_object.c | 11 +++++++++++
> 3 files changed, 11 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> index 7c2650cfb070..b23368529a40 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> @@ -507,19 +507,6 @@ void i915_gem_object_release_mmap_offset(struct drm_i915_gem_object *obj)
> spin_unlock(&obj->mmo.lock);
> }
>
> -/**
> - * i915_gem_object_release_mmap - remove physical page mappings
> - * @obj: obj in question
> - *
> - * Preserve the reservation of the mmapping with the DRM core code, but
> - * relinquish ownership of the pages back to the system.
> - */
> -void i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
> -{
> - i915_gem_object_release_mmap_gtt(obj);
> - i915_gem_object_release_mmap_offset(obj);
> -}
> -
> static struct i915_mmap_offset *
> lookup_mmo(struct drm_i915_gem_object *obj,
> enum i915_mmap_type mmap_type)
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.h b/drivers/gpu/drm/i915/gem/i915_gem_mman.h
> index 7c5ccdf59359..efee9e0d2508 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.h
> @@ -24,8 +24,6 @@ int i915_gem_dumb_mmap_offset(struct drm_file *file_priv,
> struct drm_device *dev,
> u32 handle, u64 *offset);
>
> -void i915_gem_object_release_mmap(struct drm_i915_gem_object *obj);
> -
> void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
> void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> index 6b69191c5543..d377c0ef8603 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -171,6 +171,17 @@ static void __i915_gem_free_object_rcu(struct rcu_head *head)
> atomic_dec(&i915->mm.free_count);
> }
>
> +static void i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
Maybe free_mmaps to try and discourage re-use?
> +{
> + /* Skip serialisation and waking the device if known to be not used. */
> +
> + if (obj->userfault_count)
> + i915_gem_object_release_mmap_gtt(obj);
> +
> + if (!RB_EMPTY_ROOT(&obj->mmo.offsets))
> + i915_gem_object_release_mmap_offset(obj);
> +}
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes
2020-07-02 13:06 [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes Chris Wilson
2020-07-02 13:06 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: Only revoke mmap handlers if active Chris Wilson
@ 2020-07-02 14:34 ` Patchwork
2020-07-02 15:48 ` [Intel-gfx] [PATCH v2 1/2] " Tvrtko Ursulin
2020-07-02 19:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2020-07-02 14:34 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes
URL : https://patchwork.freedesktop.org/series/79046/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8696 -> Patchwork_18068
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/index.html
Known issues
------------
Here are the changes found in Patchwork_18068 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-n3050: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [FAIL][9] ([i915#1888]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/fi-kbl-x1275/igt@kms_busy@basic@flip.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/fi-kbl-x1275/igt@kms_busy@basic@flip.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][14] ([i915#1982] / [i915#62] / [i915#92])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (42 -> 37)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
-------------
* Linux: CI_DRM_8696 -> Patchwork_18068
CI-20190529: 20190529
CI_DRM_8696: ba8b1c9012ed325ee42f673654da123bd1a9e2df @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5720: f35053d4b6d7bbcf6505ef67a8bd56acc7fb2eb2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18068: a798cfe96795eeff574585ff633a02cafb891dd9 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a798cfe96795 drm/i915/gem: Only revoke mmap handlers if active
5ea515e65a04 drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes
2020-07-02 13:06 [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes Chris Wilson
2020-07-02 13:06 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: Only revoke mmap handlers if active Chris Wilson
2020-07-02 14:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes Patchwork
@ 2020-07-02 15:48 ` Tvrtko Ursulin
2020-07-02 19:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Tvrtko Ursulin @ 2020-07-02 15:48 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 02/07/2020 14:06, Chris Wilson wrote:
> Only a GGTT mmaping will use the aperture detiling registers, so only a
> tiling change for an object, we only need to revoke those mmapings and
> not the CPU mmapings (which are always linear irrespective of the tiling).
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +-
> drivers/gpu/drm/i915/gem/i915_gem_mman.h | 5 ++++-
> drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 2 +-
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> index fe27c5b344e3..7c2650cfb070 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> @@ -448,7 +448,7 @@ void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
> * mapping will then trigger a page fault on the next user access, allowing
> * fixup by vm_fault_gtt().
> */
> -static void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
> +void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
> {
> struct drm_i915_private *i915 = to_i915(obj->base.dev);
> intel_wakeref_t wakeref;
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.h b/drivers/gpu/drm/i915/gem/i915_gem_mman.h
> index 862e01b7cb69..7c5ccdf59359 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.h
> @@ -24,8 +24,11 @@ int i915_gem_dumb_mmap_offset(struct drm_file *file_priv,
> struct drm_device *dev,
> u32 handle, u64 *offset);
>
> -void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
> void i915_gem_object_release_mmap(struct drm_i915_gem_object *obj);
> +
> +void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
> +void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
> +
> void i915_gem_object_release_mmap_offset(struct drm_i915_gem_object *obj);
>
> #endif
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> index 0158e49bf9bb..ff72ee2fd9cd 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> @@ -299,7 +299,7 @@ i915_gem_object_set_tiling(struct drm_i915_gem_object *obj,
> i915_gem_object_unlock(obj);
>
> /* Force the fence to be reacquired for GTT access */
> - i915_gem_object_release_mmap(obj);
> + i915_gem_object_release_mmap_gtt(obj);
>
> /* Try to preallocate memory required to save swizzling on put-pages */
> if (i915_gem_object_needs_bit17_swizzle(obj)) {
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: Only revoke mmap handlers if active
2020-07-02 13:06 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: Only revoke mmap handlers if active Chris Wilson
2020-07-02 13:10 ` Chris Wilson
@ 2020-07-02 15:50 ` Tvrtko Ursulin
1 sibling, 0 replies; 7+ messages in thread
From: Tvrtko Ursulin @ 2020-07-02 15:50 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 02/07/2020 14:06, Chris Wilson wrote:
> Avoid waking up the device and taking stale locks if we know that the
> object is not currently mmapped. This is particularly useful as not many
> object are actually mmapped and so we can destroy them without waking
> the device up, and gives us a little more freedom of workqueue ordering
> during shutdown.
>
> v2: Pull the release_mmap() into its single user in freeing the objects,
> where there can not be any race with a concurrent user of the freed
> object. Or so one hopes!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
> ---
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 13 -------------
> drivers/gpu/drm/i915/gem/i915_gem_mman.h | 2 --
> drivers/gpu/drm/i915/gem/i915_gem_object.c | 11 +++++++++++
> 3 files changed, 11 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> index 7c2650cfb070..b23368529a40 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> @@ -507,19 +507,6 @@ void i915_gem_object_release_mmap_offset(struct drm_i915_gem_object *obj)
> spin_unlock(&obj->mmo.lock);
> }
>
> -/**
> - * i915_gem_object_release_mmap - remove physical page mappings
> - * @obj: obj in question
> - *
> - * Preserve the reservation of the mmapping with the DRM core code, but
> - * relinquish ownership of the pages back to the system.
> - */
> -void i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
> -{
> - i915_gem_object_release_mmap_gtt(obj);
> - i915_gem_object_release_mmap_offset(obj);
> -}
> -
> static struct i915_mmap_offset *
> lookup_mmo(struct drm_i915_gem_object *obj,
> enum i915_mmap_type mmap_type)
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.h b/drivers/gpu/drm/i915/gem/i915_gem_mman.h
> index 7c5ccdf59359..efee9e0d2508 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.h
> @@ -24,8 +24,6 @@ int i915_gem_dumb_mmap_offset(struct drm_file *file_priv,
> struct drm_device *dev,
> u32 handle, u64 *offset);
>
> -void i915_gem_object_release_mmap(struct drm_i915_gem_object *obj);
> -
> void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
> void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> index 6b69191c5543..d377c0ef8603 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -171,6 +171,17 @@ static void __i915_gem_free_object_rcu(struct rcu_head *head)
> atomic_dec(&i915->mm.free_count);
> }
>
> +static void i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
Yes you can give it a more internal name for a good measure.
> +{
> + /* Skip serialisation and waking the device if known to be not used. */
> +
> + if (obj->userfault_count)
> + i915_gem_object_release_mmap_gtt(obj);
> +
> + if (!RB_EMPTY_ROOT(&obj->mmo.offsets))
> + i915_gem_object_release_mmap_offset(obj);
> +}
> +
> static void __i915_gem_free_objects(struct drm_i915_private *i915,
> struct llist_node *freed)
> {
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes
2020-07-02 13:06 [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes Chris Wilson
` (2 preceding siblings ...)
2020-07-02 15:48 ` [Intel-gfx] [PATCH v2 1/2] " Tvrtko Ursulin
@ 2020-07-02 19:47 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2020-07-02 19:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes
URL : https://patchwork.freedesktop.org/series/79046/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8696_full -> Patchwork_18068_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18068_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18068_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18068_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-iclb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-iclb1/igt@kms_fbcon_fbt@fbc-suspend.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-iclb2/igt@kms_fbcon_fbt@fbc-suspend.html
Known issues
------------
Here are the changes found in Patchwork_18068_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#1635] / [i915#95]) +21 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-apl2/igt@gem_exec_reloc@basic-many-active@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-apl3/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_reloc@basic-many-active@vecs0:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([i915#93] / [i915#95]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-kbl6/igt@gem_exec_reloc@basic-many-active@vecs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-kbl6/igt@gem_exec_reloc@basic-many-active@vecs0.html
* igt@i915_module_load@reload:
- shard-tglb: [PASS][7] -> [DMESG-WARN][8] ([i915#402]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-tglb2/igt@i915_module_load@reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-tglb1/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@i2c:
- shard-skl: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-skl10/igt@i915_pm_rpm@i2c.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-skl1/igt@i915_pm_rpm@i2c.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-apl6/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-apl2/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
* igt@kms_color@pipe-a-gamma:
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#1149])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-tglb1/igt@kms_color@pipe-a-gamma.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-tglb8/igt@kms_color@pipe-a-gamma.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][15] -> [FAIL][16] ([IGT#5])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-kbl4/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-kbl1/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#46])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@plain-flip-ts-check@a-edp1:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#1928])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-skl2/igt@kms_flip@plain-flip-ts-check@a-edp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-skl3/igt@kms_flip@plain-flip-ts-check@a-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
- shard-snb: [PASS][25] -> [TIMEOUT][26] ([i915#1958] / [i915#2119]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-snb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [i915#265])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_cursor@pipe-a-viewport-size-256:
- shard-glk: [PASS][29] -> [FAIL][30] ([i915#1559])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-glk9/igt@kms_plane_cursor@pipe-a-viewport-size-256.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-glk7/igt@kms_plane_cursor@pipe-a-viewport-size-256.html
* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-iclb: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-iclb8/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-iclb3/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html
#### Possible fixes ####
* igt@gem_ctx_engines@independent:
- shard-kbl: [DMESG-WARN][33] ([i915#93] / [i915#95]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-kbl2/igt@gem_ctx_engines@independent.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-kbl3/igt@gem_ctx_engines@independent.html
* igt@gem_exec_reloc@basic-concurrent0:
- shard-glk: [FAIL][35] ([i915#1930]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-glk3/igt@gem_exec_reloc@basic-concurrent0.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-glk3/igt@gem_exec_reloc@basic-concurrent0.html
* igt@gem_exec_whisper@basic-forked-all:
- shard-glk: [DMESG-WARN][37] ([i915#118] / [i915#95]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-glk3/igt@gem_exec_whisper@basic-forked-all.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-glk3/igt@gem_exec_whisper@basic-forked-all.html
* igt@kms_addfb_basic@basic-x-tiled:
- shard-tglb: [DMESG-WARN][39] ([i915#402]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-tglb6/igt@kms_addfb_basic@basic-x-tiled.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-tglb5/igt@kms_addfb_basic@basic-x-tiled.html
* igt@kms_big_fb@linear-16bpp-rotate-0:
- shard-apl: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-apl2/igt@kms_big_fb@linear-16bpp-rotate-0.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-apl4/igt@kms_big_fb@linear-16bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- shard-skl: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] +4 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-skl2/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-skl3/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][45] ([i915#180]) -> [PASS][46] +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_edge_walk@pipe-c-256x256-left-edge:
- shard-apl: [DMESG-WARN][47] ([i915#1635] / [i915#95]) -> [PASS][48] +20 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-apl8/igt@kms_cursor_edge_walk@pipe-c-256x256-left-edge.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-apl8/igt@kms_cursor_edge_walk@pipe-c-256x256-left-edge.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][49] ([i915#1188]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-skl2/igt@kms_hdr@bpc-switch-dpms.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-skl3/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][51] ([i915#173]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-iclb1/igt@kms_psr@no_drrs.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-iclb8/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][53] ([fdo#109441]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@syncobj_wait@single-wait-for-submit-submitted:
- shard-iclb: [DMESG-WARN][55] ([i915#1226]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-iclb2/igt@syncobj_wait@single-wait-for-submit-submitted.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-iclb4/igt@syncobj_wait@single-wait-for-submit-submitted.html
#### Warnings ####
* igt@gem_exec_reloc@basic-concurrent16:
- shard-snb: [FAIL][57] ([i915#1930]) -> [TIMEOUT][58] ([i915#1958] / [i915#2119])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-snb4/igt@gem_exec_reloc@basic-concurrent16.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-snb6/igt@gem_exec_reloc@basic-concurrent16.html
* igt@gem_exec_reloc@basic-spin-others@vcs0:
- shard-snb: [WARN][59] ([i915#2036]) -> [WARN][60] ([i915#2021])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-snb2/igt@gem_exec_reloc@basic-spin-others@vcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-snb1/igt@gem_exec_reloc@basic-spin-others@vcs0.html
* igt@kms_chamelium@vga-edid-read:
- shard-apl: [SKIP][61] ([fdo#109271] / [fdo#111827]) -> [SKIP][62] ([fdo#109271] / [fdo#111827] / [i915#1635])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-apl2/igt@kms_chamelium@vga-edid-read.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-apl4/igt@kms_chamelium@vga-edid-read.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-tglb: [FAIL][63] ([i915#1149] / [i915#315]) -> [DMESG-FAIL][64] ([i915#1149] / [i915#402])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-tglb1/igt@kms_color@pipe-a-ctm-0-75.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-tglb6/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_content_protection@srm:
- shard-kbl: [TIMEOUT][65] ([i915#1319] / [i915#1958] / [i915#2119]) -> [TIMEOUT][66] ([i915#1319] / [i915#2119])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-kbl2/igt@kms_content_protection@srm.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-kbl4/igt@kms_content_protection@srm.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][67] ([i915#1226]) -> [SKIP][68] ([fdo#109349])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-iclb3/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-apl: [SKIP][69] ([fdo#109271]) -> [SKIP][70] ([fdo#109271] / [i915#1635]) +4 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-apl3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-apl7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][71] ([i915#180] / [i915#93] / [i915#95]) -> [DMESG-WARN][72] ([i915#93] / [i915#95])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-wc:
- shard-apl: [SKIP][73] ([fdo#109271] / [i915#1635]) -> [SKIP][74] ([fdo#109271]) +5 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-apl6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-wc.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-apl8/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-wc.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant:
- shard-apl: [DMESG-FAIL][75] ([fdo#108145] / [i915#1635] / [i915#1982] / [i915#95]) -> [DMESG-FAIL][76] ([fdo#108145] / [i915#1635] / [i915#95])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
* igt@kms_plane_lowres@pipe-b-tiling-y:
- shard-snb: [SKIP][77] ([fdo#109271]) -> [TIMEOUT][78] ([i915#1958] / [i915#2119]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-snb4/igt@kms_plane_lowres@pipe-b-tiling-y.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-snb6/igt@kms_plane_lowres@pipe-b-tiling-y.html
* igt@runner@aborted:
- shard-tglb: [FAIL][79] ([i915#1764] / [i915#2110]) -> [FAIL][80] ([i915#2110])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8696/shard-tglb3/igt@runner@aborted.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/shard-tglb7/igt@runner@aborted.html
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1559]: https://gitlab.freedesktop.org/drm/intel/issues/1559
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#1764]: https://gitlab.freedesktop.org/drm/intel/issues/1764
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2021]: https://gitlab.freedesktop.org/drm/intel/issues/2021
[i915#2036]: https://gitlab.freedesktop.org/drm/intel/issues/2036
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8696 -> Patchwork_18068
CI-20190529: 20190529
CI_DRM_8696: ba8b1c9012ed325ee42f673654da123bd1a9e2df @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5720: f35053d4b6d7bbcf6505ef67a8bd56acc7fb2eb2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18068: a798cfe96795eeff574585ff633a02cafb891dd9 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18068/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-02 19:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-02 13:06 [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes Chris Wilson
2020-07-02 13:06 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: Only revoke mmap handlers if active Chris Wilson
2020-07-02 13:10 ` Chris Wilson
2020-07-02 15:50 ` Tvrtko Ursulin
2020-07-02 14:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/gem: Only revoke the GGTT mmappings on aperture detiling changes Patchwork
2020-07-02 15:48 ` [Intel-gfx] [PATCH v2 1/2] " Tvrtko Ursulin
2020-07-02 19:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).