* [Intel-gfx] [CI] drm/i915/gem: Split the context's obj:vma lut into its own mutex
@ 2020-07-02 22:21 Chris Wilson
2020-07-02 23:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev2) Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2020-07-02 22:21 UTC (permalink / raw)
To: intel-gfx
Rather than reuse the common ctx->mutex for locking the execbuffer LUT,
split it into its own lock to avoid being taken [as part of ctx->mutex]
at inappropriate times. In particular to avoid the inversion from taking
the timeline->mutex for the whole execbuf submission in the next patch.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 +++++++----
.../gpu/drm/i915/gem/i915_gem_context_types.h | 1 +
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 17 +++++++++++------
drivers/gpu/drm/i915/gem/i915_gem_object.c | 4 ++--
.../gpu/drm/i915/gem/selftests/mock_context.c | 4 +++-
5 files changed, 24 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 6675447a47b9..41784df51e58 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -101,8 +101,7 @@ static void lut_close(struct i915_gem_context *ctx)
struct radix_tree_iter iter;
void __rcu **slot;
- lockdep_assert_held(&ctx->mutex);
-
+ mutex_lock(&ctx->lut_mutex);
rcu_read_lock();
radix_tree_for_each_slot(slot, &ctx->handles_vma, &iter, 0) {
struct i915_vma *vma = rcu_dereference_raw(*slot);
@@ -135,6 +134,7 @@ static void lut_close(struct i915_gem_context *ctx)
i915_gem_object_put(obj);
}
rcu_read_unlock();
+ mutex_unlock(&ctx->lut_mutex);
}
static struct intel_context *
@@ -342,6 +342,7 @@ static void i915_gem_context_free(struct i915_gem_context *ctx)
spin_unlock(&ctx->i915->gem.contexts.lock);
mutex_destroy(&ctx->engines_mutex);
+ mutex_destroy(&ctx->lut_mutex);
if (ctx->timeline)
intel_timeline_put(ctx->timeline);
@@ -725,6 +726,7 @@ __create_context(struct drm_i915_private *i915)
RCU_INIT_POINTER(ctx->engines, e);
INIT_RADIX_TREE(&ctx->handles_vma, GFP_KERNEL);
+ mutex_init(&ctx->lut_mutex);
/* NB: Mark all slices as needing a remap so that when the context first
* loads it will restore whatever remap state already exists. If there
@@ -1312,11 +1314,11 @@ static int set_ppgtt(struct drm_i915_file_private *file_priv,
if (vm == rcu_access_pointer(ctx->vm))
goto unlock;
+ old = __set_ppgtt(ctx, vm);
+
/* Teardown the existing obj:vma cache, it will have to be rebuilt. */
lut_close(ctx);
- old = __set_ppgtt(ctx, vm);
-
/*
* We need to flush any requests using the current ppgtt before
* we release it as the requests do not hold a reference themselves,
@@ -1330,6 +1332,7 @@ static int set_ppgtt(struct drm_i915_file_private *file_priv,
if (err) {
i915_vm_close(__set_ppgtt(ctx, old));
i915_vm_close(old);
+ lut_close(ctx); /* force a rebuild of the old obj:vma cache */
}
unlock:
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
index 28760bd03265..ae14ca24a11f 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
@@ -170,6 +170,7 @@ struct i915_gem_context {
* per vm, which may be one per context or shared with the global GTT)
*/
struct radix_tree_root handles_vma;
+ struct mutex lut_mutex;
/**
* @name: arbitrary name, used for user debug
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index b4862afaaf28..52391894c994 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -782,10 +782,13 @@ static int __eb_add_lut(struct i915_execbuffer *eb,
/* Check that the context hasn't been closed in the meantime */
err = -EINTR;
- if (!mutex_lock_interruptible(&ctx->mutex)) {
- err = -ENOENT;
- if (likely(!i915_gem_context_is_closed(ctx)))
+ if (!mutex_lock_interruptible(&ctx->lut_mutex)) {
+ if (unlikely(vma->vm != ctx->vm))
+ err = -EAGAIN; /* user racing with ctx set-vm */
+ else if (likely(!i915_gem_context_is_closed(ctx)))
err = radix_tree_insert(&ctx->handles_vma, handle, vma);
+ else
+ err = -ENOENT;
if (err == 0) { /* And nor has this handle */
struct drm_i915_gem_object *obj = vma->obj;
@@ -798,7 +801,7 @@ static int __eb_add_lut(struct i915_execbuffer *eb,
}
spin_unlock(&obj->lut_lock);
}
- mutex_unlock(&ctx->mutex);
+ mutex_unlock(&ctx->lut_mutex);
}
if (unlikely(err))
goto err;
@@ -814,6 +817,8 @@ static int __eb_add_lut(struct i915_execbuffer *eb,
static struct i915_vma *eb_lookup_vma(struct i915_execbuffer *eb, u32 handle)
{
+ struct i915_address_space *vm = eb->context->vm;
+
do {
struct drm_i915_gem_object *obj;
struct i915_vma *vma;
@@ -821,7 +826,7 @@ static struct i915_vma *eb_lookup_vma(struct i915_execbuffer *eb, u32 handle)
rcu_read_lock();
vma = radix_tree_lookup(&eb->gem_context->handles_vma, handle);
- if (likely(vma))
+ if (likely(vma && vma->vm == vm))
vma = i915_vma_tryget(vma);
rcu_read_unlock();
if (likely(vma))
@@ -831,7 +836,7 @@ static struct i915_vma *eb_lookup_vma(struct i915_execbuffer *eb, u32 handle)
if (unlikely(!obj))
return ERR_PTR(-ENOENT);
- vma = i915_vma_instance(obj, eb->context->vm, NULL);
+ vma = i915_vma_instance(obj, vm, NULL);
if (IS_ERR(vma)) {
i915_gem_object_put(obj);
return vma;
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
index eb35bdd10c09..c8421fd9d2dc 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
@@ -143,14 +143,14 @@ void i915_gem_close_object(struct drm_gem_object *gem, struct drm_file *file)
* vma, in the same fd namespace, by virtue of flink/open.
*/
- mutex_lock(&ctx->mutex);
+ mutex_lock(&ctx->lut_mutex);
vma = radix_tree_delete(&ctx->handles_vma, lut->handle);
if (vma) {
GEM_BUG_ON(vma->obj != obj);
GEM_BUG_ON(!atomic_read(&vma->open_count));
i915_vma_close(vma);
}
- mutex_unlock(&ctx->mutex);
+ mutex_unlock(&ctx->lut_mutex);
i915_gem_context_put(lut->ctx);
i915_lut_handle_free(lut);
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
index aa0d06cf1903..51b5a3421b40 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
@@ -23,6 +23,8 @@ mock_context(struct drm_i915_private *i915,
INIT_LIST_HEAD(&ctx->link);
ctx->i915 = i915;
+ mutex_init(&ctx->mutex);
+
spin_lock_init(&ctx->stale.lock);
INIT_LIST_HEAD(&ctx->stale.engines);
@@ -35,7 +37,7 @@ mock_context(struct drm_i915_private *i915,
RCU_INIT_POINTER(ctx->engines, e);
INIT_RADIX_TREE(&ctx->handles_vma, GFP_KERNEL);
- mutex_init(&ctx->mutex);
+ mutex_init(&ctx->lut_mutex);
if (name) {
struct i915_ppgtt *ppgtt;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev2)
2020-07-02 22:21 [Intel-gfx] [CI] drm/i915/gem: Split the context's obj:vma lut into its own mutex Chris Wilson
@ 2020-07-02 23:48 ` Patchwork
2020-07-02 23:49 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-07-03 0:17 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-07-02 23:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev2)
URL : https://patchwork.freedesktop.org/series/79064/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e64718ab4fd9 drm/i915/gem: Split the context's obj:vma lut into its own mutex
-:83: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#83: FILE: drivers/gpu/drm/i915/gem/i915_gem_context_types.h:173:
+ struct mutex lut_mutex;
total: 0 errors, 0 warnings, 1 checks, 137 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev2)
2020-07-02 22:21 [Intel-gfx] [CI] drm/i915/gem: Split the context's obj:vma lut into its own mutex Chris Wilson
2020-07-02 23:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev2) Patchwork
@ 2020-07-02 23:49 ` Patchwork
2020-07-03 0:17 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-07-02 23:49 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev2)
URL : https://patchwork.freedesktop.org/series/79064/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won't be checked separately.
+drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:786:21: error: incompatible types in comparison expression (different address spaces)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev2)
2020-07-02 22:21 [Intel-gfx] [CI] drm/i915/gem: Split the context's obj:vma lut into its own mutex Chris Wilson
2020-07-02 23:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev2) Patchwork
2020-07-02 23:49 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2020-07-03 0:17 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-07-03 0:17 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev2)
URL : https://patchwork.freedesktop.org/series/79064/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8702 -> Patchwork_18076
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18076 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18076, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18076:
### IGT changes ###
#### Possible regressions ####
* igt@gem_busy@busy@all:
- fi-ilk-650: [PASS][1] -> [INCOMPLETE][2] +5 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-ilk-650/igt@gem_busy@busy@all.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-ilk-650/igt@gem_busy@busy@all.html
- fi-snb-2520m: [PASS][3] -> [INCOMPLETE][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-snb-2520m/igt@gem_busy@busy@all.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-snb-2520m/igt@gem_busy@busy@all.html
* igt@gem_close_race@basic-process:
- fi-ivb-3770: [PASS][5] -> [TIMEOUT][6] +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-ivb-3770/igt@gem_close_race@basic-process.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-ivb-3770/igt@gem_close_race@basic-process.html
- fi-blb-e6850: [PASS][7] -> [TIMEOUT][8] +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-blb-e6850/igt@gem_close_race@basic-process.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-blb-e6850/igt@gem_close_race@basic-process.html
- fi-hsw-4770: [PASS][9] -> [TIMEOUT][10] +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-hsw-4770/igt@gem_close_race@basic-process.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-hsw-4770/igt@gem_close_race@basic-process.html
* igt@gem_ctx_create@basic-files:
- fi-byt-n2820: [PASS][11] -> [TIMEOUT][12] +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-byt-n2820/igt@gem_ctx_create@basic-files.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-byt-n2820/igt@gem_ctx_create@basic-files.html
- fi-byt-j1900: [PASS][13] -> [TIMEOUT][14] +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-byt-j1900/igt@gem_ctx_create@basic-files.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-byt-j1900/igt@gem_ctx_create@basic-files.html
* igt@gem_ctx_exec@basic:
- fi-ilk-650: [PASS][15] -> [TIMEOUT][16] +4 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-ilk-650/igt@gem_ctx_exec@basic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-ilk-650/igt@gem_ctx_exec@basic.html
- fi-elk-e7500: [PASS][17] -> [TIMEOUT][18] +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-elk-e7500/igt@gem_ctx_exec@basic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-elk-e7500/igt@gem_ctx_exec@basic.html
- fi-snb-2520m: [PASS][19] -> [TIMEOUT][20] +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-snb-2520m/igt@gem_ctx_exec@basic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-snb-2520m/igt@gem_ctx_exec@basic.html
* igt@gem_exec_basic@basic@rcs0:
- fi-bwr-2160: [PASS][21] -> [INCOMPLETE][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-bwr-2160/igt@gem_exec_basic@basic@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-bwr-2160/igt@gem_exec_basic@basic@rcs0.html
* igt@gem_exec_create@basic:
- fi-gdg-551: [PASS][23] -> [TIMEOUT][24] +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-gdg-551/igt@gem_exec_create@basic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-gdg-551/igt@gem_exec_create@basic.html
- fi-bwr-2160: [PASS][25] -> [TIMEOUT][26] +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-bwr-2160/igt@gem_exec_create@basic.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-bwr-2160/igt@gem_exec_create@basic.html
* igt@gem_exec_fence@basic-await@rcs0:
- fi-ivb-3770: [PASS][27] -> [INCOMPLETE][28] +5 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-ivb-3770/igt@gem_exec_fence@basic-await@rcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-ivb-3770/igt@gem_exec_fence@basic-await@rcs0.html
* igt@gem_exec_fence@basic-busy@rcs0:
- fi-blb-e6850: [PASS][29] -> [INCOMPLETE][30] +6 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-blb-e6850/igt@gem_exec_fence@basic-busy@rcs0.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-blb-e6850/igt@gem_exec_fence@basic-busy@rcs0.html
* igt@gem_exec_fence@basic-wait@rcs0:
- fi-hsw-4770: [PASS][31] -> [INCOMPLETE][32] +5 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-hsw-4770/igt@gem_exec_fence@basic-wait@rcs0.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-hsw-4770/igt@gem_exec_fence@basic-wait@rcs0.html
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][33] -> [TIMEOUT][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
#### Warnings ####
* igt@gem_exec_fence@basic-busy:
- fi-bwr-2160: [SKIP][35] ([fdo#109271]) -> [TIMEOUT][36] +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-bwr-2160/igt@gem_exec_fence@basic-busy.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-bwr-2160/igt@gem_exec_fence@basic-busy.html
* igt@gem_exec_fence@nb-await:
- fi-gdg-551: [SKIP][37] ([fdo#109271]) -> [TIMEOUT][38] +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-gdg-551/igt@gem_exec_fence@nb-await.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-gdg-551/igt@gem_exec_fence@nb-await.html
- fi-snb-2520m: [SKIP][39] ([fdo#109271]) -> [TIMEOUT][40] +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-snb-2520m/igt@gem_exec_fence@nb-await.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-snb-2520m/igt@gem_exec_fence@nb-await.html
Known issues
------------
Here are the changes found in Patchwork_18076 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy@all:
- fi-pnv-d510: [PASS][41] -> [INCOMPLETE][42] ([i915#2119] / [i915#299]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-pnv-d510/igt@gem_busy@busy@all.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-pnv-d510/igt@gem_busy@busy@all.html
- fi-gdg-551: [PASS][43] -> [INCOMPLETE][44] ([i915#172]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-gdg-551/igt@gem_busy@busy@all.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-gdg-551/igt@gem_busy@busy@all.html
- fi-bwr-2160: [PASS][45] -> [INCOMPLETE][46] ([i915#2119])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-bwr-2160/igt@gem_busy@busy@all.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-bwr-2160/igt@gem_busy@busy@all.html
- fi-byt-n2820: [PASS][47] -> [INCOMPLETE][48] ([i915#45]) +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-byt-n2820/igt@gem_busy@busy@all.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-byt-n2820/igt@gem_busy@busy@all.html
- fi-elk-e7500: [PASS][49] -> [INCOMPLETE][50] ([i915#2119] / [i915#66])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-elk-e7500/igt@gem_busy@busy@all.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-elk-e7500/igt@gem_busy@busy@all.html
* igt@gem_close_race@basic-process:
- fi-elk-e7500: [PASS][51] -> [TIMEOUT][52] ([i915#1958] / [i915#2119])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-elk-e7500/igt@gem_close_race@basic-process.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-elk-e7500/igt@gem_close_race@basic-process.html
- fi-snb-2600: [PASS][53] -> [INCOMPLETE][54] ([i915#82]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-snb-2600/igt@gem_close_race@basic-process.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-snb-2600/igt@gem_close_race@basic-process.html
- fi-bwr-2160: [PASS][55] -> [TIMEOUT][56] ([i915#1958] / [i915#2119]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-bwr-2160/igt@gem_close_race@basic-process.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-bwr-2160/igt@gem_close_race@basic-process.html
* igt@gem_exec_fence@basic-await@rcs0:
- fi-byt-j1900: [PASS][57] -> [INCOMPLETE][58] ([i915#2119] / [i915#45])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-byt-j1900/igt@gem_exec_fence@basic-await@rcs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-byt-j1900/igt@gem_exec_fence@basic-await@rcs0.html
* igt@gem_exec_fence@basic-busy@rcs0:
- fi-elk-e7500: [PASS][59] -> [INCOMPLETE][60] ([i915#66]) +4 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-elk-e7500/igt@gem_exec_fence@basic-busy@rcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-elk-e7500/igt@gem_exec_fence@basic-busy@rcs0.html
- fi-byt-j1900: [PASS][61] -> [INCOMPLETE][62] ([i915#45]) +4 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-byt-j1900/igt@gem_exec_fence@basic-busy@rcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-byt-j1900/igt@gem_exec_fence@basic-busy@rcs0.html
* igt@gem_exec_fence@basic-wait@rcs0:
- fi-pnv-d510: [PASS][63] -> [INCOMPLETE][64] ([i915#299]) +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-pnv-d510/igt@gem_exec_fence@basic-wait@rcs0.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-pnv-d510/igt@gem_exec_fence@basic-wait@rcs0.html
* igt@gem_exec_fence@nb-await@rcs0:
- fi-byt-n2820: [PASS][65] -> [INCOMPLETE][66] ([i915#2119] / [i915#45]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-byt-n2820/igt@gem_exec_fence@nb-await@rcs0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-byt-n2820/igt@gem_exec_fence@nb-await@rcs0.html
* igt@gem_render_linear_blits@basic:
- fi-gdg-551: [PASS][67] -> [TIMEOUT][68] ([i915#1958] / [i915#2119])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-gdg-551/igt@gem_render_linear_blits@basic.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-gdg-551/igt@gem_render_linear_blits@basic.html
* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: [PASS][69] -> [DMESG-WARN][70] ([i915#1982])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [PASS][71] -> [DMESG-WARN][72] ([i915#1982]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [FAIL][73] ([i915#1888]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
* igt@gem_linear_blits@basic:
- fi-tgl-u2: [DMESG-WARN][75] ([i915#402]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-tgl-u2/igt@gem_linear_blits@basic.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-tgl-u2/igt@gem_linear_blits@basic.html
* igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
- fi-icl-u2: [DMESG-WARN][77] ([i915#1982]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][79] ([i915#62] / [i915#95]) -> [SKIP][80] ([fdo#109271])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- fi-kbl-x1275: [DMESG-WARN][81] ([i915#62] / [i915#92]) -> [DMESG-WARN][82] ([i915#62] / [i915#92] / [i915#95]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
* igt@kms_flip@basic-flip-vs-modeset@a-dp1:
- fi-kbl-x1275: [DMESG-WARN][83] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][84] ([i915#62] / [i915#92]) +3 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][85] ([i915#1982] / [i915#62] / [i915#92]) -> [DMESG-WARN][86] ([i915#62] / [i915#92])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#172]: https://gitlab.freedesktop.org/drm/intel/issues/172
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119
[i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#66]: https://gitlab.freedesktop.org/drm/intel/issues/66
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (43 -> 37)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8702 -> Patchwork_18076
CI-20190529: 20190529
CI_DRM_8702: 7a5c82b68e1d0fbf600d353793c2360b3e425629 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5720: f35053d4b6d7bbcf6505ef67a8bd56acc7fb2eb2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18076: e64718ab4fd9fb2b3f5ce0a63610c76c93ced4e5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e64718ab4fd9 drm/i915/gem: Split the context's obj:vma lut into its own mutex
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18076/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-03 0:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-02 22:21 [Intel-gfx] [CI] drm/i915/gem: Split the context's obj:vma lut into its own mutex Chris Wilson
2020-07-02 23:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev2) Patchwork
2020-07-02 23:49 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-07-03 0:17 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).