* [Intel-gfx] [CI] drm/i915/gem: Split the context's obj:vma lut into its own mutex
@ 2020-07-03 0:43 Chris Wilson
2020-07-03 0:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3) Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2020-07-03 0:43 UTC (permalink / raw)
To: intel-gfx
Rather than reuse the common ctx->mutex for locking the execbuffer LUT,
split it into its own lock to avoid being taken [as part of ctx->mutex]
at inappropriate times. In particular to avoid the inversion from taking
the timeline->mutex for the whole execbuf submission in the next patch.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 +++++++----
.../gpu/drm/i915/gem/i915_gem_context_types.h | 1 +
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 17 +++++++++++------
drivers/gpu/drm/i915/gem/i915_gem_object.c | 4 ++--
.../gpu/drm/i915/gem/selftests/mock_context.c | 4 +++-
5 files changed, 24 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 6675447a47b9..41784df51e58 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -101,8 +101,7 @@ static void lut_close(struct i915_gem_context *ctx)
struct radix_tree_iter iter;
void __rcu **slot;
- lockdep_assert_held(&ctx->mutex);
-
+ mutex_lock(&ctx->lut_mutex);
rcu_read_lock();
radix_tree_for_each_slot(slot, &ctx->handles_vma, &iter, 0) {
struct i915_vma *vma = rcu_dereference_raw(*slot);
@@ -135,6 +134,7 @@ static void lut_close(struct i915_gem_context *ctx)
i915_gem_object_put(obj);
}
rcu_read_unlock();
+ mutex_unlock(&ctx->lut_mutex);
}
static struct intel_context *
@@ -342,6 +342,7 @@ static void i915_gem_context_free(struct i915_gem_context *ctx)
spin_unlock(&ctx->i915->gem.contexts.lock);
mutex_destroy(&ctx->engines_mutex);
+ mutex_destroy(&ctx->lut_mutex);
if (ctx->timeline)
intel_timeline_put(ctx->timeline);
@@ -725,6 +726,7 @@ __create_context(struct drm_i915_private *i915)
RCU_INIT_POINTER(ctx->engines, e);
INIT_RADIX_TREE(&ctx->handles_vma, GFP_KERNEL);
+ mutex_init(&ctx->lut_mutex);
/* NB: Mark all slices as needing a remap so that when the context first
* loads it will restore whatever remap state already exists. If there
@@ -1312,11 +1314,11 @@ static int set_ppgtt(struct drm_i915_file_private *file_priv,
if (vm == rcu_access_pointer(ctx->vm))
goto unlock;
+ old = __set_ppgtt(ctx, vm);
+
/* Teardown the existing obj:vma cache, it will have to be rebuilt. */
lut_close(ctx);
- old = __set_ppgtt(ctx, vm);
-
/*
* We need to flush any requests using the current ppgtt before
* we release it as the requests do not hold a reference themselves,
@@ -1330,6 +1332,7 @@ static int set_ppgtt(struct drm_i915_file_private *file_priv,
if (err) {
i915_vm_close(__set_ppgtt(ctx, old));
i915_vm_close(old);
+ lut_close(ctx); /* force a rebuild of the old obj:vma cache */
}
unlock:
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
index 28760bd03265..ae14ca24a11f 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
@@ -170,6 +170,7 @@ struct i915_gem_context {
* per vm, which may be one per context or shared with the global GTT)
*/
struct radix_tree_root handles_vma;
+ struct mutex lut_mutex;
/**
* @name: arbitrary name, used for user debug
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index b4862afaaf28..e9bb85b679b4 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -782,10 +782,13 @@ static int __eb_add_lut(struct i915_execbuffer *eb,
/* Check that the context hasn't been closed in the meantime */
err = -EINTR;
- if (!mutex_lock_interruptible(&ctx->mutex)) {
- err = -ENOENT;
- if (likely(!i915_gem_context_is_closed(ctx)))
+ if (!mutex_lock_interruptible(&ctx->lut_mutex)) {
+ if (unlikely(ctx->vm && vma->vm != ctx->vm))
+ err = -EAGAIN; /* user racing with ctx set-vm */
+ else if (likely(!i915_gem_context_is_closed(ctx)))
err = radix_tree_insert(&ctx->handles_vma, handle, vma);
+ else
+ err = -ENOENT;
if (err == 0) { /* And nor has this handle */
struct drm_i915_gem_object *obj = vma->obj;
@@ -798,7 +801,7 @@ static int __eb_add_lut(struct i915_execbuffer *eb,
}
spin_unlock(&obj->lut_lock);
}
- mutex_unlock(&ctx->mutex);
+ mutex_unlock(&ctx->lut_mutex);
}
if (unlikely(err))
goto err;
@@ -814,6 +817,8 @@ static int __eb_add_lut(struct i915_execbuffer *eb,
static struct i915_vma *eb_lookup_vma(struct i915_execbuffer *eb, u32 handle)
{
+ struct i915_address_space *vm = eb->context->vm;
+
do {
struct drm_i915_gem_object *obj;
struct i915_vma *vma;
@@ -821,7 +826,7 @@ static struct i915_vma *eb_lookup_vma(struct i915_execbuffer *eb, u32 handle)
rcu_read_lock();
vma = radix_tree_lookup(&eb->gem_context->handles_vma, handle);
- if (likely(vma))
+ if (likely(vma && vma->vm == vm))
vma = i915_vma_tryget(vma);
rcu_read_unlock();
if (likely(vma))
@@ -831,7 +836,7 @@ static struct i915_vma *eb_lookup_vma(struct i915_execbuffer *eb, u32 handle)
if (unlikely(!obj))
return ERR_PTR(-ENOENT);
- vma = i915_vma_instance(obj, eb->context->vm, NULL);
+ vma = i915_vma_instance(obj, vm, NULL);
if (IS_ERR(vma)) {
i915_gem_object_put(obj);
return vma;
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
index eb35bdd10c09..c8421fd9d2dc 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
@@ -143,14 +143,14 @@ void i915_gem_close_object(struct drm_gem_object *gem, struct drm_file *file)
* vma, in the same fd namespace, by virtue of flink/open.
*/
- mutex_lock(&ctx->mutex);
+ mutex_lock(&ctx->lut_mutex);
vma = radix_tree_delete(&ctx->handles_vma, lut->handle);
if (vma) {
GEM_BUG_ON(vma->obj != obj);
GEM_BUG_ON(!atomic_read(&vma->open_count));
i915_vma_close(vma);
}
- mutex_unlock(&ctx->mutex);
+ mutex_unlock(&ctx->lut_mutex);
i915_gem_context_put(lut->ctx);
i915_lut_handle_free(lut);
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
index aa0d06cf1903..51b5a3421b40 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
@@ -23,6 +23,8 @@ mock_context(struct drm_i915_private *i915,
INIT_LIST_HEAD(&ctx->link);
ctx->i915 = i915;
+ mutex_init(&ctx->mutex);
+
spin_lock_init(&ctx->stale.lock);
INIT_LIST_HEAD(&ctx->stale.engines);
@@ -35,7 +37,7 @@ mock_context(struct drm_i915_private *i915,
RCU_INIT_POINTER(ctx->engines, e);
INIT_RADIX_TREE(&ctx->handles_vma, GFP_KERNEL);
- mutex_init(&ctx->mutex);
+ mutex_init(&ctx->lut_mutex);
if (name) {
struct i915_ppgtt *ppgtt;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3)
2020-07-03 0:43 [Intel-gfx] [CI] drm/i915/gem: Split the context's obj:vma lut into its own mutex Chris Wilson
@ 2020-07-03 0:53 ` Patchwork
2020-07-03 0:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-07-03 0:53 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3)
URL : https://patchwork.freedesktop.org/series/79064/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
15fe500e5d57 drm/i915/gem: Split the context's obj:vma lut into its own mutex
-:83: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#83: FILE: drivers/gpu/drm/i915/gem/i915_gem_context_types.h:173:
+ struct mutex lut_mutex;
total: 0 errors, 0 warnings, 1 checks, 137 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3)
2020-07-03 0:43 [Intel-gfx] [CI] drm/i915/gem: Split the context's obj:vma lut into its own mutex Chris Wilson
2020-07-03 0:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3) Patchwork
@ 2020-07-03 0:55 ` Patchwork
2020-07-03 1:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-03 7:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-07-03 0:55 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3)
URL : https://patchwork.freedesktop.org/series/79064/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won't be checked separately.
+drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:786:21: error: incompatible types in comparison expression (different address spaces)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3)
2020-07-03 0:43 [Intel-gfx] [CI] drm/i915/gem: Split the context's obj:vma lut into its own mutex Chris Wilson
2020-07-03 0:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3) Patchwork
2020-07-03 0:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2020-07-03 1:18 ` Patchwork
2020-07-03 7:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-07-03 1:18 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3)
URL : https://patchwork.freedesktop.org/series/79064/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8702 -> Patchwork_18078
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/index.html
Known issues
------------
Here are the changes found in Patchwork_18078 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-skl-6600u: [PASS][1] -> [INCOMPLETE][2] ([i915#1795])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-skl-6600u/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/fi-skl-6600u/igt@i915_selftest@live@execlists.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [FAIL][3] ([i915#1888]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
* igt@i915_module_load@reload:
- fi-byt-n2820: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-byt-n2820/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/fi-byt-n2820/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][12] ([i915#1982] / [i915#62] / [i915#92] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][13] ([i915#62] / [i915#95]) -> [SKIP][14] ([fdo#109271])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size.html
* igt@kms_flip@basic-flip-vs-modeset@a-dp1:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][19] ([i915#1982] / [i915#62] / [i915#92]) -> [DMESG-WARN][20] ([i915#62] / [i915#92])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1795]: https://gitlab.freedesktop.org/drm/intel/issues/1795
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (43 -> 36)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-apl-guc fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8702 -> Patchwork_18078
CI-20190529: 20190529
CI_DRM_8702: 7a5c82b68e1d0fbf600d353793c2360b3e425629 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5720: f35053d4b6d7bbcf6505ef67a8bd56acc7fb2eb2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18078: 15fe500e5d577aaa6d696056c5067daf82a2e202 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
15fe500e5d57 drm/i915/gem: Split the context's obj:vma lut into its own mutex
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3)
2020-07-03 0:43 [Intel-gfx] [CI] drm/i915/gem: Split the context's obj:vma lut into its own mutex Chris Wilson
` (2 preceding siblings ...)
2020-07-03 1:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-07-03 7:31 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-07-03 7:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3)
URL : https://patchwork.freedesktop.org/series/79064/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8702_full -> Patchwork_18078_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18078_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_import_export@prime:
- shard-tglb: [PASS][1] -> [DMESG-WARN][2] ([i915#402])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-tglb2/igt@drm_import_export@prime.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-tglb2/igt@drm_import_export@prime.html
* igt@gen9_exec_parse@cmd-crossing-page:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#93] / [i915#95]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-kbl1/igt@gen9_exec_parse@cmd-crossing-page.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-kbl2/igt@gen9_exec_parse@cmd-crossing-page.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([i915#926])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-iclb3/igt@i915_module_load@reload-with-fault-injection.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-iclb2/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_addfb_basic@basic-x-tiled:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl3/igt@kms_addfb_basic@basic-x-tiled.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-apl1/igt@kms_addfb_basic@basic-x-tiled.html
* igt@kms_color@pipe-a-gamma:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#1149])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-tglb3/igt@kms_color@pipe-a-gamma.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-tglb8/igt@kms_color@pipe-a-gamma.html
* igt@kms_color@pipe-c-ctm-0-25:
- shard-skl: [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +7 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-skl3/igt@kms_color@pipe-c-ctm-0-25.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-skl7/igt@kms_color@pipe-c-ctm-0-25.html
* igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge:
- shard-glk: [PASS][13] -> [DMESG-FAIL][14] ([i915#118] / [i915#70] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-glk7/igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-glk5/igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge.html
* igt@kms_cursor_edge_walk@pipe-c-64x64-bottom-edge:
- shard-glk: [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-glk9/igt@kms_cursor_edge_walk@pipe-c-64x64-bottom-edge.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-glk8/igt@kms_cursor_edge_walk@pipe-c-64x64-bottom-edge.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][17] -> [FAIL][18] ([IGT#5])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@pipe-a-forked-move:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#1635] / [i915#95]) +18 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl2/igt@kms_cursor_legacy@pipe-a-forked-move.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-apl4/igt@kms_cursor_legacy@pipe-a-forked-move.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-wf_vblank-interruptible@a-edp1:
- shard-tglb: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-tglb2/igt@kms_flip@flip-vs-wf_vblank-interruptible@a-edp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-tglb1/igt@kms_flip@flip-vs-wf_vblank-interruptible@a-edp1.html
* igt@kms_flip@plain-flip-ts-check@a-edp1:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#1928])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-skl7/igt@kms_flip@plain-flip-ts-check@a-edp1.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-skl4/igt@kms_flip@plain-flip-ts-check@a-edp1.html
* igt@kms_plane_cursor@pipe-a-viewport-size-256:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#1559])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-glk1/igt@kms_plane_cursor@pipe-a-viewport-size-256.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-glk9/igt@kms_plane_cursor@pipe-a-viewport-size-256.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html
#### Possible fixes ####
* igt@gem_exec_flush@basic-wb-rw-default:
- shard-glk: [INCOMPLETE][31] ([i915#58] / [k.org#198133]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-glk2/igt@gem_exec_flush@basic-wb-rw-default.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-glk4/igt@gem_exec_flush@basic-wb-rw-default.html
* igt@gem_exec_reloc@basic-concurrent0:
- shard-glk: [FAIL][33] ([i915#1930]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-glk9/igt@gem_exec_reloc@basic-concurrent0.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-glk8/igt@gem_exec_reloc@basic-concurrent0.html
* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [DMESG-WARN][35] ([i915#118] / [i915#95]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-glk3/igt@gem_exec_whisper@basic-queues-forked.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-glk6/igt@gem_exec_whisper@basic-queues-forked.html
* igt@gem_exec_whisper@basic-queues-priority:
- shard-apl: [DMESG-WARN][37] ([i915#1635] / [i915#95]) -> [PASS][38] +20 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl4/igt@gem_exec_whisper@basic-queues-priority.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-apl2/igt@gem_exec_whisper@basic-queues-priority.html
* igt@i915_pm_rpm@i2c:
- shard-skl: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40] +8 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-skl1/igt@i915_pm_rpm@i2c.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-skl6/igt@i915_pm_rpm@i2c.html
* igt@i915_selftest@live@execlists:
- shard-tglb: [INCOMPLETE][41] ([i915#2123]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-tglb8/igt@i915_selftest@live@execlists.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-tglb1/igt@i915_selftest@live@execlists.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-apl: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl6/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-apl7/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][45] ([i915#180]) -> [PASS][46] +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-snb: [INCOMPLETE][47] ([i915#82]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-snb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-snb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][49] ([fdo#109441]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][51] ([i915#31]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl4/igt@kms_setmode@basic.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-apl2/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-wait-forked-busy:
- shard-kbl: [DMESG-WARN][53] ([i915#93] / [i915#95]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-kbl7/igt@kms_vblank@pipe-a-wait-forked-busy.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-kbl1/igt@kms_vblank@pipe-a-wait-forked-busy.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: [INCOMPLETE][55] ([i915#155] / [i915#794]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-kbl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-kbl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-storm:
- shard-apl: [SKIP][57] ([fdo#109271] / [fdo#111827] / [i915#1635]) -> [SKIP][58] ([fdo#109271] / [fdo#111827])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl4/igt@kms_chamelium@hdmi-hpd-storm.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-apl2/igt@kms_chamelium@hdmi-hpd-storm.html
* igt@kms_chamelium@vga-hpd-with-enabled-mode:
- shard-apl: [SKIP][59] ([fdo#109271] / [fdo#111827]) -> [SKIP][60] ([fdo#109271] / [fdo#111827] / [i915#1635])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl8/igt@kms_chamelium@vga-hpd-with-enabled-mode.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-apl6/igt@kms_chamelium@vga-hpd-with-enabled-mode.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-tglb: [FAIL][61] ([i915#1149] / [i915#315]) -> [DMESG-FAIL][62] ([i915#1149] / [i915#402])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-tglb3/igt@kms_color@pipe-a-ctm-0-75.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-tglb6/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_content_protection@srm:
- shard-kbl: [TIMEOUT][63] ([i915#1319] / [i915#1958] / [i915#2119]) -> [TIMEOUT][64] ([i915#1319] / [i915#2119])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-kbl1/igt@kms_content_protection@srm.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-kbl4/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@pipe-d-cursor-512x512-random:
- shard-apl: [SKIP][65] ([fdo#109271]) -> [SKIP][66] ([fdo#109271] / [i915#1635]) +8 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl2/igt@kms_cursor_crc@pipe-d-cursor-512x512-random.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-apl4/igt@kms_cursor_crc@pipe-d-cursor-512x512-random.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff:
- shard-apl: [SKIP][67] ([fdo#109271] / [i915#1635]) -> [SKIP][68] ([fdo#109271]) +5 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-apl3/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff.html
* igt@runner@aborted:
- shard-apl: ([FAIL][69], [FAIL][70], [FAIL][71]) ([i915#1610] / [i915#1635] / [i915#2110]) -> [FAIL][72] ([i915#1635] / [i915#2110])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl3/igt@runner@aborted.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl2/igt@runner@aborted.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-apl1/igt@runner@aborted.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-apl8/igt@runner@aborted.html
- shard-tglb: ([FAIL][73], [FAIL][74], [FAIL][75]) ([i915#1233] / [i915#2110] / [i915#529]) -> [FAIL][76] ([i915#1764] / [i915#2110])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-tglb1/igt@runner@aborted.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-tglb5/igt@runner@aborted.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8702/shard-tglb8/igt@runner@aborted.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/shard-tglb3/igt@runner@aborted.html
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1559]: https://gitlab.freedesktop.org/drm/intel/issues/1559
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1764]: https://gitlab.freedesktop.org/drm/intel/issues/1764
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119
[i915#2123]: https://gitlab.freedesktop.org/drm/intel/issues/2123
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#529]: https://gitlab.freedesktop.org/drm/intel/issues/529
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#70]: https://gitlab.freedesktop.org/drm/intel/issues/70
[i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#926]: https://gitlab.freedesktop.org/drm/intel/issues/926
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8702 -> Patchwork_18078
CI-20190529: 20190529
CI_DRM_8702: 7a5c82b68e1d0fbf600d353793c2360b3e425629 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5720: f35053d4b6d7bbcf6505ef67a8bd56acc7fb2eb2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18078: 15fe500e5d577aaa6d696056c5067daf82a2e202 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18078/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-03 7:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-03 0:43 [Intel-gfx] [CI] drm/i915/gem: Split the context's obj:vma lut into its own mutex Chris Wilson
2020-07-03 0:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Split the context's obj:vma lut into its own mutex (rev3) Patchwork
2020-07-03 0:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-07-03 1:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-03 7:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).