* [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis
@ 2020-09-23 4:40 Steve Hampson
2020-09-23 5:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: Steve Hampson @ 2020-09-23 4:40 UTC (permalink / raw)
To: intel-gfx
A static analysis tool has reveiled a NULL pointer error in
__i915_gem_object_lock. This appears to be correct as many calls
pass a NULL into the ww parameter.
Signed-off-by: Steve Hampson <steven.t.hampson@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h
index d46db8d8f38e..9b18ead42991 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h
@@ -126,7 +126,7 @@ static inline int __i915_gem_object_lock(struct drm_i915_gem_object *obj,
if (ret == -EALREADY)
ret = 0;
- if (ret == -EDEADLK)
+ if (ret == -EDEADLK && ww)
ww->contended = obj;
return ret;
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Fix NULL pointer found by static analysis
2020-09-23 4:40 [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis Steve Hampson
@ 2020-09-23 5:28 ` Patchwork
2020-09-23 8:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-09-23 5:28 UTC (permalink / raw)
To: Steve Hampson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 7247 bytes --]
== Series Details ==
Series: Fix NULL pointer found by static analysis
URL : https://patchwork.freedesktop.org/series/81999/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9039 -> Patchwork_18551
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/index.html
Known issues
------------
Here are the changes found in Patchwork_18551 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic@flip:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-tgl-y/igt@kms_busy@basic@flip.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-tgl-y/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-icl-u2: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@vgem_basic@setversion:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-tgl-y/igt@vgem_basic@setversion.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-tgl-y/igt@vgem_basic@setversion.html
#### Possible fixes ####
* igt@gem_flink_basic@basic:
- fi-tgl-y: [DMESG-WARN][7] ([i915#402]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-tgl-y/igt@gem_flink_basic@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-tgl-y/igt@gem_flink_basic@basic.html
* igt@i915_module_load@reload:
- {fi-tgl-dsi}: [DMESG-WARN][9] ([i915#1982] / [k.org#205379]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-tgl-dsi/igt@i915_module_load@reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-tgl-dsi/igt@i915_module_load@reload.html
* igt@i915_selftest@live@coherency:
- fi-gdg-551: [DMESG-FAIL][11] ([i915#1748]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-gdg-551/igt@i915_selftest@live@coherency.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-gdg-551/igt@i915_selftest@live@coherency.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
* igt@vgem_basic@unload:
- fi-skl-guc: [DMESG-WARN][15] ([i915#2203]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-skl-guc/igt@vgem_basic@unload.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-skl-guc/igt@vgem_basic@unload.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#1982] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
* igt@gem_exec_suspend@basic-s3:
- fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][20] ([i915#1982] / [i915#62] / [i915#92])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html
- fi-tgl-y: [DMESG-WARN][21] ([i915#2411] / [i915#402]) -> [DMESG-WARN][22] ([i915#2411])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][23] ([i915#62] / [i915#95]) -> [DMESG-FAIL][24] ([i915#62])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92]) -> [DMESG-WARN][26] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-kbl-x1275: [DMESG-WARN][27] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][28] ([i915#62] / [i915#92]) +7 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/fi-kbl-x1275/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/fi-kbl-x1275/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1748]: https://gitlab.freedesktop.org/drm/intel/issues/1748
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (44 -> 39)
------------------------------
Missing (5): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9039 -> Patchwork_18551
CI-20190529: 20190529
CI_DRM_9039: 050bf10e3619ea10ec5820ab8a2ee65bfa4ab024 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5787: 0ec962017c8131de14e0cb038f7f76b1f17ed637 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18551: 9e05f4f6fbb01620eb50a4edfb51b8128d589a6a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9e05f4f6fbb0 Fix NULL pointer found by static analysis
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/index.html
[-- Attachment #1.2: Type: text/html, Size: 10063 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for Fix NULL pointer found by static analysis
2020-09-23 4:40 [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis Steve Hampson
2020-09-23 5:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-09-23 8:48 ` Patchwork
2020-09-23 8:58 ` [Intel-gfx] [PATCH] " Chris Wilson
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-09-23 8:48 UTC (permalink / raw)
To: Steve Hampson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 10020 bytes --]
== Series Details ==
Series: Fix NULL pointer found by static analysis
URL : https://patchwork.freedesktop.org/series/81999/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9039_full -> Patchwork_18551_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18551_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [PASS][1] -> [INCOMPLETE][2] ([i915#300])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- shard-skl: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) +9 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-skl6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-skl3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- shard-skl: [PASS][5] -> [FAIL][6] ([i915#177] / [i915#52] / [i915#54])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-skl8/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-tglb: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-wc:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#49])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-skl5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-wc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#1188])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-skl: [PASS][15] -> [INCOMPLETE][16] ([i915#198])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-skl5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-skl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145] / [i915#265])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][19] -> [DMESG-FAIL][20] ([fdo#108145] / [i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
* igt@sw_sync@sync_expired_merge:
- shard-iclb: [PASS][23] -> [DMESG-WARN][24] ([i915#1982])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-iclb8/igt@sw_sync@sync_expired_merge.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-iclb2/igt@sw_sync@sync_expired_merge.html
#### Possible fixes ####
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [FAIL][25] ([i915#2389]) -> [PASS][26] +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-glk7/igt@gem_exec_reloc@basic-many-active@rcs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-glk8/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@kms_busy@basic-flip-pipe-c:
- shard-skl: [DMESG-WARN][27] ([i915#1982]) -> [PASS][28] +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-skl7/igt@kms_busy@basic-flip-pipe-c.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-skl1/igt@kms_busy@basic-flip-pipe-c.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][29] ([i915#180]) -> [PASS][30] +4 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render:
- shard-tglb: [DMESG-WARN][31] ([i915#1982]) -> [PASS][32] +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-tglb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][33] ([i915#1188]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-skl8/igt@kms_hdr@bpc-switch.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-skl7/igt@kms_hdr@bpc-switch.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][35] ([fdo#109441]) -> [PASS][36] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][37] ([i915#1635] / [i915#31]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-apl1/igt@kms_setmode@basic.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-apl3/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-b-query-busy:
- shard-apl: [DMESG-WARN][39] ([i915#1635] / [i915#1982]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9039/shard-apl4/igt@kms_vblank@pipe-b-query-busy.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/shard-apl1/igt@kms_vblank@pipe-b-query-busy.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2469]: https://gitlab.freedesktop.org/drm/intel/issues/2469
[i915#2476]: https://gitlab.freedesktop.org/drm/intel/issues/2476
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9039 -> Patchwork_18551
CI-20190529: 20190529
CI_DRM_9039: 050bf10e3619ea10ec5820ab8a2ee65bfa4ab024 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5787: 0ec962017c8131de14e0cb038f7f76b1f17ed637 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18551: 9e05f4f6fbb01620eb50a4edfb51b8128d589a6a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18551/index.html
[-- Attachment #1.2: Type: text/html, Size: 11715 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis
2020-09-23 4:40 [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis Steve Hampson
2020-09-23 5:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-09-23 8:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2020-09-23 8:58 ` Chris Wilson
2020-09-23 9:04 ` Jani Nikula
2020-09-23 21:23 ` Hampson, Steven T
` (3 subsequent siblings)
6 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2020-09-23 8:58 UTC (permalink / raw)
To: Steve Hampson, intel-gfx
Quoting Steve Hampson (2020-09-23 05:40:54)
> A static analysis tool has reveiled a NULL pointer error in
> __i915_gem_object_lock. This appears to be correct as many calls
> pass a NULL into the ww parameter.
>
> Signed-off-by: Steve Hampson <steven.t.hampson@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h
> index d46db8d8f38e..9b18ead42991 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h
> @@ -126,7 +126,7 @@ static inline int __i915_gem_object_lock(struct drm_i915_gem_object *obj,
> if (ret == -EALREADY)
> ret = 0;
>
> - if (ret == -EDEADLK)
> + if (ret == -EDEADLK && ww)
EDEADLK is predicated by ww already.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis
2020-09-23 8:58 ` [Intel-gfx] [PATCH] " Chris Wilson
@ 2020-09-23 9:04 ` Jani Nikula
0 siblings, 0 replies; 9+ messages in thread
From: Jani Nikula @ 2020-09-23 9:04 UTC (permalink / raw)
To: Chris Wilson, Steve Hampson, intel-gfx
On Wed, 23 Sep 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Steve Hampson (2020-09-23 05:40:54)
>> A static analysis tool has reveiled a NULL pointer error in
>> __i915_gem_object_lock. This appears to be correct as many calls
>> pass a NULL into the ww parameter.
>>
>> Signed-off-by: Steve Hampson <steven.t.hampson@intel.com>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h
>> index d46db8d8f38e..9b18ead42991 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h
>> @@ -126,7 +126,7 @@ static inline int __i915_gem_object_lock(struct drm_i915_gem_object *obj,
>> if (ret == -EALREADY)
>> ret = 0;
>>
>> - if (ret == -EDEADLK)
>> + if (ret == -EDEADLK && ww)
>
> EDEADLK is predicated by ww already.
The hard part is that neither the analyzer nor a human who doesn't know
how dma_resv_lock* work can easily deduce that. :(
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis
2020-09-23 4:40 [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis Steve Hampson
` (2 preceding siblings ...)
2020-09-23 8:58 ` [Intel-gfx] [PATCH] " Chris Wilson
@ 2020-09-23 21:23 ` Hampson, Steven T
2020-09-23 21:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix NULL pointer found by static analysis (rev2) Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Hampson, Steven T @ 2020-09-23 21:23 UTC (permalink / raw)
To: Hampson, Steven T, intel-gfx
Never mind. This is a false positive.
-----Original Message-----
From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Steve Hampson
Sent: Tuesday, September 22, 2020 9:41 PM
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis
A static analysis tool has reveiled a NULL pointer error in __i915_gem_object_lock. This appears to be correct as many calls pass a NULL into the ww parameter.
Signed-off-by: Steve Hampson <steven.t.hampson@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h
index d46db8d8f38e..9b18ead42991 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h
@@ -126,7 +126,7 @@ static inline int __i915_gem_object_lock(struct drm_i915_gem_object *obj,
if (ret == -EALREADY)
ret = 0;
- if (ret == -EDEADLK)
+ if (ret == -EDEADLK && ww)
ww->contended = obj;
return ret;
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix NULL pointer found by static analysis (rev2)
2020-09-23 4:40 [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis Steve Hampson
` (3 preceding siblings ...)
2020-09-23 21:23 ` Hampson, Steven T
@ 2020-09-23 21:57 ` Patchwork
2020-09-23 22:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-24 1:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-09-23 21:57 UTC (permalink / raw)
To: Hampson, Steven T; +Cc: intel-gfx
== Series Details ==
Series: Fix NULL pointer found by static analysis (rev2)
URL : https://patchwork.freedesktop.org/series/81999/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3a559b7eb929 Fix NULL pointer found by static analysis
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Steve Hampson
-:30: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Intel-gfx <intel-gfx-bounces@lists.freedesktop.org>'
total: 0 errors, 2 warnings, 0 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Fix NULL pointer found by static analysis (rev2)
2020-09-23 4:40 [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis Steve Hampson
` (4 preceding siblings ...)
2020-09-23 21:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix NULL pointer found by static analysis (rev2) Patchwork
@ 2020-09-23 22:22 ` Patchwork
2020-09-24 1:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-09-23 22:22 UTC (permalink / raw)
To: Hampson, Steven T; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 6510 bytes --]
== Series Details ==
Series: Fix NULL pointer found by static analysis (rev2)
URL : https://patchwork.freedesktop.org/series/81999/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9045 -> Patchwork_18559
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/index.html
Known issues
------------
Here are the changes found in Patchwork_18559 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#1982] / [k.org#205379])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-tgl-y/igt@i915_module_load@reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-tgl-y/igt@i915_module_load@reload.html
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][3] -> [DMESG-WARN][4] ([i915#62] / [i915#92] / [i915#95]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-kbl-x1275/igt@kms_busy@basic@flip.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-kbl-x1275/igt@kms_busy@basic@flip.html
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-tgl-y/igt@kms_busy@basic@flip.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-tgl-y/igt@kms_busy@basic@flip.html
* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([i915#402]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
#### Possible fixes ####
* igt@debugfs_test@read_all_entries:
- {fi-kbl-7560u}: [INCOMPLETE][9] ([i915#2417]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html
* igt@gem_tiled_fence_blits@basic:
- fi-tgl-y: [DMESG-WARN][11] ([i915#402]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-tgl-y/igt@gem_tiled_fence_blits@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-tgl-y/igt@gem_tiled_fence_blits@basic.html
* igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
- fi-icl-u2: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
* igt@vgem_basic@unload:
- fi-skl-guc: [DMESG-WARN][15] ([i915#2203]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-skl-guc/igt@vgem_basic@unload.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-skl-guc/igt@vgem_basic@unload.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#1982] / [i915#62] / [i915#92] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-tgl-y: [DMESG-WARN][19] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][20] ([i915#2411])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- fi-kbl-x1275: [DMESG-WARN][21] ([i915#62] / [i915#92]) -> [DMESG-WARN][22] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][24] ([i915#62] / [i915#92]) +8 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2417]: https://gitlab.freedesktop.org/drm/intel/issues/2417
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (46 -> 40)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9045 -> Patchwork_18559
CI-20190529: 20190529
CI_DRM_9045: c090e19126310a35b72cafa971bdbdfa1c5c87db @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5787: 0ec962017c8131de14e0cb038f7f76b1f17ed637 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18559: 3a559b7eb929b4731fdff08a173ccfbf9a8ca87a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3a559b7eb929 Fix NULL pointer found by static analysis
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/index.html
[-- Attachment #1.2: Type: text/html, Size: 8826 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Fix NULL pointer found by static analysis (rev2)
2020-09-23 4:40 [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis Steve Hampson
` (5 preceding siblings ...)
2020-09-23 22:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-09-24 1:08 ` Patchwork
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-09-24 1:08 UTC (permalink / raw)
To: Hampson, Steven T; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 13797 bytes --]
== Series Details ==
Series: Fix NULL pointer found by static analysis (rev2)
URL : https://patchwork.freedesktop.org/series/81999/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9045_full -> Patchwork_18559_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18559_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18559_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18559_full:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- shard-hsw: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-hsw8/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_18559_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_import_export@prime:
- shard-hsw: [PASS][2] -> [INCOMPLETE][3] ([i915#2377])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-hsw2/igt@drm_import_export@prime.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-hsw8/igt@drm_import_export@prime.html
* igt@gem_exec_reloc@basic-many-active@bcs0:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2389])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-glk1/igt@gem_exec_reloc@basic-many-active@bcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-glk4/igt@gem_exec_reloc@basic-many-active@bcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][6] -> [SKIP][7] ([i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-tglb8/igt@gem_huc_copy@huc-copy.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-tglb6/igt@gem_huc_copy@huc-copy.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-skl: [PASS][8] -> [TIMEOUT][9] ([i915#1958] / [i915#2424])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-skl9/igt@gem_userptr_blits@sync-unmap-cycles.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-skl2/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][10] -> [DMESG-WARN][11] ([i915#180]) +5 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- shard-skl: [PASS][12] -> [DMESG-WARN][13] ([i915#1982]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-skl6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-skl8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][14] -> [DMESG-WARN][15] ([i915#1982])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-hsw1/igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-vga1-hdmi-a1.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-hsw6/igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-vga1-hdmi-a1.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu:
- shard-skl: [PASS][16] -> [FAIL][17] ([i915#49])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render:
- shard-tglb: [PASS][18] -> [DMESG-WARN][19] ([i915#1982]) +6 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-tglb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-tglb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][20] -> [FAIL][21] ([i915#1188])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-skl1/igt@kms_hdr@bpc-switch.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-skl4/igt@kms_hdr@bpc-switch.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][22] -> [FAIL][23] ([fdo#108145] / [i915#265]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][24] -> [DMESG-FAIL][25] ([fdo#108145] / [i915#1982])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][26] -> [SKIP][27] ([fdo#109441]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html
#### Possible fixes ####
* igt@i915_selftest@mock@contexts:
- shard-skl: [INCOMPLETE][28] ([i915#198] / [i915#2278]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-skl1/igt@i915_selftest@mock@contexts.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-skl4/igt@i915_selftest@mock@contexts.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][30] ([i915#72]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][32] ([i915#2122]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][34] ([i915#180]) -> [PASS][35] +4 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip_event_leak:
- shard-glk: [INCOMPLETE][36] -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-glk7/igt@kms_flip_event_leak.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-glk4/igt@kms_flip_event_leak.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [DMESG-WARN][38] ([i915#1982]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt:
- shard-tglb: [DMESG-WARN][40] ([i915#1982]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][42] ([fdo#109441]) -> [PASS][43] +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-iclb1/igt@kms_psr@psr2_cursor_plane_onoff.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_vblank@pipe-a-query-forked-busy:
- shard-skl: [DMESG-WARN][44] ([i915#1982]) -> [PASS][45] +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-skl10/igt@kms_vblank@pipe-a-query-forked-busy.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-skl7/igt@kms_vblank@pipe-a-query-forked-busy.html
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][46] ([i915#1542]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-skl2/igt@perf@polling-parameterized.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-skl1/igt@perf@polling-parameterized.html
* igt@perf@polling-small-buf:
- shard-iclb: [FAIL][48] ([i915#1722]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-iclb3/igt@perf@polling-small-buf.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-iclb4/igt@perf@polling-small-buf.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][50] ([i915#658]) -> [SKIP][51] ([i915#588])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-iclb5/igt@i915_pm_dc@dc3co-vpb-simulation.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_flip@plain-flip-fb-recreate@a-edp1:
- shard-skl: [DMESG-FAIL][52] ([i915#1982]) -> [DMESG-WARN][53] ([i915#1982])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-skl5/igt@kms_flip@plain-flip-fb-recreate@a-edp1.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-skl5/igt@kms_flip@plain-flip-fb-recreate@a-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-hsw: [INCOMPLETE][54] -> [SKIP][55] ([fdo#109271])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-hsw8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-hsw7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [INCOMPLETE][56] ([i915#198]) -> [FAIL][57] ([i915#1188])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9045/shard-skl5/igt@kms_hdr@bpc-switch-suspend.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2278]: https://gitlab.freedesktop.org/drm/intel/issues/2278
[i915#2377]: https://gitlab.freedesktop.org/drm/intel/issues/2377
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2424]: https://gitlab.freedesktop.org/drm/intel/issues/2424
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9045 -> Patchwork_18559
CI-20190529: 20190529
CI_DRM_9045: c090e19126310a35b72cafa971bdbdfa1c5c87db @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5787: 0ec962017c8131de14e0cb038f7f76b1f17ed637 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18559: 3a559b7eb929b4731fdff08a173ccfbf9a8ca87a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18559/index.html
[-- Attachment #1.2: Type: text/html, Size: 15992 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-09-24 1:08 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 4:40 [Intel-gfx] [PATCH] Fix NULL pointer found by static analysis Steve Hampson
2020-09-23 5:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-09-23 8:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-09-23 8:58 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-09-23 9:04 ` Jani Nikula
2020-09-23 21:23 ` Hampson, Steven T
2020-09-23 21:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix NULL pointer found by static analysis (rev2) Patchwork
2020-09-23 22:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-24 1:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).