* [Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not suspend bonded requests if one hangs
@ 2021-01-18 12:43 Chris Wilson
2021-01-18 12:43 ` [Intel-gfx] [PATCH 2/2] drm/i915/gt: Skip over completed active execlists, again Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2021-01-18 12:43 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
Treat the dependency between bonded requests as weak and leave the
remainder of the pair on the GPU if one hangs.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
index 740ff05fd692..524c8b54d220 100644
--- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
@@ -1990,6 +1990,9 @@ static void __execlists_hold(struct i915_request *rq)
struct i915_request *w =
container_of(p->waiter, typeof(*w), sched);
+ if (p->flags & I915_DEPENDENCY_WEAK)
+ continue;
+
/* Leave semaphores spinning on the other engines */
if (w->engine != rq->engine)
continue;
@@ -2088,6 +2091,9 @@ static void __execlists_unhold(struct i915_request *rq)
struct i915_request *w =
container_of(p->waiter, typeof(*w), sched);
+ if (p->flags & I915_DEPENDENCY_WEAK)
+ continue;
+
/* Propagate any change in error status */
if (rq->fence.error)
i915_request_set_error_once(w, rq->fence.error);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Intel-gfx] [PATCH 2/2] drm/i915/gt: Skip over completed active execlists, again 2021-01-18 12:43 [Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not suspend bonded requests if one hangs Chris Wilson @ 2021-01-18 12:43 ` Chris Wilson 2021-01-18 16:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Chris Wilson @ 2021-01-18 12:43 UTC (permalink / raw) To: intel-gfx; +Cc: Chris Wilson Now that we are careful to always force-restore contexts upon rewinding (where necessary), we can restore our optimisation to skip over completed active execlists when dequeuing. Referenecs: 35f3fd8182ba ("drm/i915/execlists: Workaround switching back to a completed context") References: 8ab3a3812aa9 ("drm/i915/gt: Incrementally check for rewinding") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> --- .../drm/i915/gt/intel_execlists_submission.c | 36 +++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c index 524c8b54d220..750e95aa904c 100644 --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c @@ -1224,12 +1224,20 @@ static void set_preempt_timeout(struct intel_engine_cs *engine, active_preempt_timeout(engine, rq)); } +static bool completed(const struct i915_request *rq) +{ + if (i915_request_has_sentinel(rq)) + return false; + + return __i915_request_is_complete(rq); +} + static void execlists_dequeue(struct intel_engine_cs *engine) { struct intel_engine_execlists * const execlists = &engine->execlists; struct i915_request **port = execlists->pending; struct i915_request ** const last_port = port + execlists->port_mask; - struct i915_request *last = *execlists->active; + struct i915_request *last, * const *active; struct virtual_engine *ve; struct rb_node *rb; bool submit = false; @@ -1266,21 +1274,15 @@ static void execlists_dequeue(struct intel_engine_cs *engine) * i.e. we will retrigger preemption following the ack in case * of trouble. * - * In theory we can skip over completed contexts that have not - * yet been processed by events (as those events are in flight): - * - * while ((last = *active) && i915_request_completed(last)) - * active++; - * - * However, the GPU cannot handle this as it will ultimately - * find itself trying to jump back into a context it has just - * completed and barf. */ + active = execlists->active; + while ((last = *active) && completed(last)) + active++; if (last) { - if (__i915_request_is_complete(last)) { - goto check_secondary; - } else if (need_preempt(engine, last)) { + GEM_BUG_ON(!i915_request_is_active(last)); + + if (need_preempt(engine, last)) { ENGINE_TRACE(engine, "preempting last=%llx:%lld, prio=%d, hint=%d\n", last->fence.context, @@ -1359,9 +1361,7 @@ static void execlists_dequeue(struct intel_engine_cs *engine) * we hopefully coalesce several updates into a single * submission. */ -check_secondary: - if (!list_is_last(&last->sched.link, - &engine->active.requests)) { + if (active[1]) { /* * Even if ELSP[1] is occupied and not worthy * of timeslices, our queue might be. @@ -1562,7 +1562,7 @@ static void execlists_dequeue(struct intel_engine_cs *engine) * of ordered contexts. */ if (submit && - memcmp(execlists->active, + memcmp(active, execlists->pending, (port - execlists->pending) * sizeof(*port))) { *port = NULL; @@ -1570,7 +1570,7 @@ static void execlists_dequeue(struct intel_engine_cs *engine) execlists_schedule_in(*port, port - execlists->pending); WRITE_ONCE(execlists->yield, -1); - set_preempt_timeout(engine, *execlists->active); + set_preempt_timeout(engine, *active); execlists_submit_ports(engine); } else { ring_set_paused(engine, 0); -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs 2021-01-18 12:43 [Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not suspend bonded requests if one hangs Chris Wilson 2021-01-18 12:43 ` [Intel-gfx] [PATCH 2/2] drm/i915/gt: Skip over completed active execlists, again Chris Wilson @ 2021-01-18 16:45 ` Patchwork 2021-01-18 17:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-01-18 22:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-01-18 16:45 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs URL : https://patchwork.freedesktop.org/series/85991/ State : warning == Summary == $ dim checkpatch origin/drm-tip cf42e636b946 drm/i915/gt: Do not suspend bonded requests if one hangs 93452ea1d70b drm/i915/gt: Skip over completed active execlists, again -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: Referenecs: 35f3fd8182ba ("drm/i915/execlists: Workaround switching back to a completed context") -:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 35f3fd8182ba ("drm/i915/execlists: Workaround switching back to a completed context")' #10: Referenecs: 35f3fd8182ba ("drm/i915/execlists: Workaround switching back to a completed context") -:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 8ab3a3812aa9 ("drm/i915/gt: Incrementally check for rewinding")' #11: References: 8ab3a3812aa9 ("drm/i915/gt: Incrementally check for rewinding") total: 2 errors, 1 warnings, 0 checks, 74 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs 2021-01-18 12:43 [Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not suspend bonded requests if one hangs Chris Wilson 2021-01-18 12:43 ` [Intel-gfx] [PATCH 2/2] drm/i915/gt: Skip over completed active execlists, again Chris Wilson 2021-01-18 16:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs Patchwork @ 2021-01-18 17:15 ` Patchwork 2021-01-18 22:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-01-18 17:15 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 3577 bytes --] == Series Details == Series: series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs URL : https://patchwork.freedesktop.org/series/85991/ State : success == Summary == CI Bug Log - changes from CI_DRM_9636 -> Patchwork_19392 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/index.html Known issues ------------ Here are the changes found in Patchwork_19392 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@core_hotunplug@unbind-rebind: - fi-kbl-7500u: [PASS][1] -> [DMESG-WARN][2] ([i915#2605]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html * igt@fbdev@write: - fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/fi-tgl-y/igt@fbdev@write.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/fi-tgl-y/igt@fbdev@write.html * igt@i915_selftest@live@blt: - fi-snb-2600: [PASS][5] -> [DMESG-FAIL][6] ([i915#1409]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/fi-snb-2600/igt@i915_selftest@live@blt.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/fi-snb-2600/igt@i915_selftest@live@blt.html #### Possible fixes #### * igt@debugfs_test@read_all_entries: - fi-tgl-y: [DMESG-WARN][7] ([i915#402]) -> [PASS][8] +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/fi-tgl-y/igt@debugfs_test@read_all_entries.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/fi-tgl-y/igt@debugfs_test@read_all_entries.html * igt@kms_chamelium@hdmi-crc-fast: - fi-kbl-7500u: [DMESG-WARN][9] ([i915#2868]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1409]: https://gitlab.freedesktop.org/drm/intel/issues/1409 [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295 [i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605 [i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (44 -> 39) ------------------------------ Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_9636 -> Patchwork_19392 CI-20190529: 20190529 CI_DRM_9636: f560ac388c527f2f166897c9091f7b9ad652050f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19392: 93452ea1d70be326ec74fc5729db4a5e2db7081b @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 93452ea1d70b drm/i915/gt: Skip over completed active execlists, again cf42e636b946 drm/i915/gt: Do not suspend bonded requests if one hangs == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/index.html [-- Attachment #1.2: Type: text/html, Size: 4314 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs 2021-01-18 12:43 [Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not suspend bonded requests if one hangs Chris Wilson ` (2 preceding siblings ...) 2021-01-18 17:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2021-01-18 22:20 ` Patchwork 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-01-18 22:20 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 15496 bytes --] == Series Details == Series: series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs URL : https://patchwork.freedesktop.org/series/85991/ State : success == Summary == CI Bug Log - changes from CI_DRM_9636_full -> Patchwork_19392_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_19392_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@engines-mixed: - shard-hsw: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-hsw6/igt@gem_ctx_persistence@engines-mixed.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-apl: [PASS][2] -> [FAIL][3] ([i915#2389]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl3/igt@gem_exec_reloc@basic-many-active@rcs0.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-apl1/igt@gem_exec_reloc@basic-many-active@rcs0.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-skl: [PASS][4] -> [FAIL][5] ([i915#644]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@gem_ppgtt@flink-and-close-vma-leak.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl3/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_render_copy@y-tiled-to-vebox-linear: - shard-hsw: NOTRUN -> [SKIP][6] ([fdo#109271]) +99 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-hsw6/igt@gem_render_copy@y-tiled-to-vebox-linear.html * igt@i915_module_load@reload-with-fault-injection: - shard-hsw: NOTRUN -> [INCOMPLETE][7] ([i915#2880]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-hsw4/igt@i915_module_load@reload-with-fault-injection.html * igt@kms_color_chamelium@pipe-d-ctm-max: - shard-hsw: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +7 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-hsw2/igt@kms_color_chamelium@pipe-d-ctm-max.html * igt@kms_cursor_crc@pipe-b-cursor-256x85-random: - shard-skl: [PASS][9] -> [FAIL][10] ([i915#54]) +10 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-256x85-random.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-256x85-random.html * igt@kms_flip@bo-too-big@a-hdmi-a1: - shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#118] / [i915#95]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_flip@bo-too-big@a-hdmi-a1.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-glk9/igt@kms_flip@bo-too-big@a-hdmi-a1.html * igt@kms_flip@flip-vs-expired-vblank@c-edp1: - shard-skl: [PASS][13] -> [FAIL][14] ([i915#79]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl2/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html * igt@kms_flip@flip-vs-suspend@b-hdmi-a1: - shard-hsw: [PASS][15] -> [INCOMPLETE][16] ([i915#2055] / [i915#2295]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-hsw7/igt@kms_flip@flip-vs-suspend@b-hdmi-a1.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-hsw4/igt@kms_flip@flip-vs-suspend@b-hdmi-a1.html * igt@kms_flip@nonexisting-fb@a-edp1: - shard-skl: [PASS][17] -> [DMESG-WARN][18] ([i915#1982]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_flip@nonexisting-fb@a-edp1.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl8/igt@kms_flip@nonexisting-fb@a-edp1.html * igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1: - shard-skl: [PASS][19] -> [FAIL][20] ([i915#2122]) +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl7/igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl1/igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite: - shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271]) +4 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite.html * igt@kms_pipe_crc_basic@read-crc-pipe-a: - shard-glk: [PASS][22] -> [FAIL][23] ([i915#53]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_pipe_crc_basic@read-crc-pipe-a.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-glk9/igt@kms_pipe_crc_basic@read-crc-pipe-a.html * igt@kms_psr@psr2_suspend: - shard-iclb: [PASS][24] -> [SKIP][25] ([fdo#109441]) +1 similar issue [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb2/igt@kms_psr@psr2_suspend.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-iclb7/igt@kms_psr@psr2_suspend.html * igt@perf_pmu@module-unload: - shard-skl: [PASS][26] -> [DMESG-WARN][27] ([i915#1982] / [i915#262]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@perf_pmu@module-unload.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl8/igt@perf_pmu@module-unload.html #### Possible fixes #### * igt@gem_exec_capture@pi@vecs0: - shard-skl: [INCOMPLETE][28] ([i915#198] / [i915#2624]) -> [PASS][29] [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@gem_exec_capture@pi@vecs0.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl2/igt@gem_exec_capture@pi@vecs0.html * {igt@gem_exec_fair@basic-flow@rcs0}: - shard-tglb: [FAIL][30] ([i915#2842]) -> [PASS][31] +2 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-tglb8/igt@gem_exec_fair@basic-flow@rcs0.html * {igt@gem_exec_fair@basic-none@vcs0}: - shard-kbl: [FAIL][32] ([i915#2842]) -> [PASS][33] +1 similar issue [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html * {igt@gem_exec_fair@basic-pace-share@rcs0}: - shard-glk: [FAIL][34] ([i915#2842]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html * {igt@gem_exec_schedule@u-fairslice@rcs0}: - shard-skl: [DMESG-WARN][36] ([i915#1610] / [i915#2803]) -> [PASS][37] [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@gem_exec_schedule@u-fairslice@rcs0.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl1/igt@gem_exec_schedule@u-fairslice@rcs0.html * igt@gem_partial_pwrite_pread@writes-after-reads-snoop: - shard-hsw: [INCOMPLETE][38] -> [PASS][39] [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-hsw7/igt@gem_partial_pwrite_pread@writes-after-reads-snoop.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-hsw2/igt@gem_partial_pwrite_pread@writes-after-reads-snoop.html * igt@kms_color@pipe-a-ctm-0-5: - shard-skl: [DMESG-WARN][40] ([i915#1982]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_color@pipe-a-ctm-0-5.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl8/igt@kms_color@pipe-a-ctm-0-5.html * igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen: - shard-skl: [FAIL][42] ([i915#54]) -> [PASS][43] +4 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: - shard-skl: [FAIL][44] ([i915#79]) -> [PASS][45] [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html * igt@kms_flip@flip-vs-expired-vblank@c-dp1: - shard-apl: [FAIL][46] ([i915#79]) -> [PASS][47] [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl2/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-apl3/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [FAIL][48] ([i915#1188]) -> [PASS][49] +1 similar issue [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [SKIP][50] ([fdo#109441]) -> [PASS][51] +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@perf@short-reads: - shard-skl: [FAIL][52] ([i915#51]) -> [PASS][53] [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@perf@short-reads.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl2/igt@perf@short-reads.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][54] ([i915#2684]) -> [WARN][55] ([i915#1804] / [i915#2684]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-iclb7/igt@i915_pm_rc6_residency@rc6-fence.html * igt@runner@aborted: - shard-kbl: [FAIL][56] ([i915#2295] / [i915#2505]) -> [FAIL][57] ([i915#2295]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl6/igt@runner@aborted.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-kbl1/igt@runner@aborted.html - shard-apl: [FAIL][58] ([i915#2295]) -> ([FAIL][59], [FAIL][60]) ([i915#1610] / [i915#2295] / [i915#2426]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl8/igt@runner@aborted.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-apl6/igt@runner@aborted.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-apl7/igt@runner@aborted.html - shard-skl: ([FAIL][61], [FAIL][62], [FAIL][63]) ([i915#2029] / [i915#2295] / [i915#2426]) -> ([FAIL][64], [FAIL][65]) ([i915#2295] / [i915#2426]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@runner@aborted.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@runner@aborted.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl3/igt@runner@aborted.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl1/igt@runner@aborted.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/shard-skl9/igt@runner@aborted.html ### Piglit changes ### #### Issues hit #### * spec@ext_framebuffer_multisample_blit_scaled@blit-scaled samples=2: - pig-glk-j5005: NOTRUN -> [WARN][66] ([mesa#1797]) +1 similar issue [66]: None {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505 [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262 [i915#2624]: https://gitlab.freedesktop.org/drm/intel/issues/2624 [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 [i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849 [i915#2880]: https://gitlab.freedesktop.org/drm/intel/issues/2880 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51 [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 [mesa#1797]: https://gitlab.freedesktop.org/mesa/mesa/issues/1797 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_9636 -> Patchwork_19392 CI-20190529: 20190529 CI_DRM_9636: f560ac388c527f2f166897c9091f7b9ad652050f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19392: 93452ea1d70be326ec74fc5729db4a5e2db7081b @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19392/index.html [-- Attachment #1.2: Type: text/html, Size: 18098 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not suspend bonded requests if one hangs @ 2021-01-20 12:17 Chris Wilson 2021-01-20 19:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork 0 siblings, 1 reply; 6+ messages in thread From: Chris Wilson @ 2021-01-20 12:17 UTC (permalink / raw) To: intel-gfx; +Cc: Chris Wilson Treat the dependency between bonded requests as weak and leave the remainder of the pair on the GPU if one hangs. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c index 740ff05fd692..524c8b54d220 100644 --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c @@ -1990,6 +1990,9 @@ static void __execlists_hold(struct i915_request *rq) struct i915_request *w = container_of(p->waiter, typeof(*w), sched); + if (p->flags & I915_DEPENDENCY_WEAK) + continue; + /* Leave semaphores spinning on the other engines */ if (w->engine != rq->engine) continue; @@ -2088,6 +2091,9 @@ static void __execlists_unhold(struct i915_request *rq) struct i915_request *w = container_of(p->waiter, typeof(*w), sched); + if (p->flags & I915_DEPENDENCY_WEAK) + continue; + /* Propagate any change in error status */ if (rq->fence.error) i915_request_set_error_once(w, rq->fence.error); -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs 2021-01-20 12:17 [Intel-gfx] [PATCH 1/2] " Chris Wilson @ 2021-01-20 19:16 ` Patchwork 0 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-01-20 19:16 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 4088 bytes --] == Series Details == Series: series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs URL : https://patchwork.freedesktop.org/series/86087/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19426 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19426/index.html Known issues ------------ Here are the changes found in Patchwork_19426 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_prime@i915-to-amd: - fi-snb-2520m: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19426/fi-snb-2520m/igt@amdgpu/amd_prime@i915-to-amd.html * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy: - fi-snb-2600: NOTRUN -> [SKIP][2] ([fdo#109271]) +30 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19426/fi-snb-2600/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html * igt@kms_chamelium@hdmi-crc-fast: - fi-snb-2600: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827]) +8 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19426/fi-snb-2600/igt@kms_chamelium@hdmi-crc-fast.html * igt@vgem_basic@create: - fi-tgl-y: [PASS][4] -> [DMESG-WARN][5] ([i915#402]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-tgl-y/igt@vgem_basic@create.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19426/fi-tgl-y/igt@vgem_basic@create.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-snb-2600: [DMESG-WARN][6] ([i915#2772]) -> [PASS][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-snb-2600/igt@gem_exec_suspend@basic-s3.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19426/fi-snb-2600/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live@hangcheck: - fi-snb-2520m: [INCOMPLETE][8] -> [PASS][9] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-snb-2520m/igt@i915_selftest@live@hangcheck.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19426/fi-snb-2520m/igt@i915_selftest@live@hangcheck.html * igt@prime_self_import@basic-with_one_bo_two_files: - fi-tgl-y: [DMESG-WARN][10] ([i915#402]) -> [PASS][11] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19426/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2772]: https://gitlab.freedesktop.org/drm/intel/issues/2772 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (43 -> 38) ------------------------------ Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_9650 -> Patchwork_19426 CI-20190529: 20190529 CI_DRM_9650: 3f989d1bb4cfd91e25549f9fd7a750412581dcc4 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19426: 63e0ca6b8dc8f97bb9e2509ce1f4d091c3985cde @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 63e0ca6b8dc8 drm/i915/gt: Skip over completed active execlists, again 69e82f4a4b40 drm/i915/gt: Do not suspend bonded requests if one hangs == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19426/index.html [-- Attachment #1.2: Type: text/html, Size: 4942 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-20 19:17 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-01-18 12:43 [Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not suspend bonded requests if one hangs Chris Wilson 2021-01-18 12:43 ` [Intel-gfx] [PATCH 2/2] drm/i915/gt: Skip over completed active execlists, again Chris Wilson 2021-01-18 16:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs Patchwork 2021-01-18 17:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-01-18 22:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-01-20 12:17 [Intel-gfx] [PATCH 1/2] " Chris Wilson 2021-01-20 19:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).