* [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early
@ 2021-01-15 16:23 Jinoh Kang
2021-01-15 16:56 ` Chris Wilson
` (6 more replies)
0 siblings, 7 replies; 11+ messages in thread
From: Jinoh Kang @ 2021-01-15 16:23 UTC (permalink / raw)
To: Marek Marczykowski-Górecki
Cc: dri-devel, David Airlie, intel-gfx, linux-kernel, Chris Wilson,
Matthew Auld
If GUP-ineligible pages are passed to a GEM userptr object, -EFAULT is
returned only when the object is actually bound.
The xf86-video-intel userspace driver cannot differentiate this
condition, and marks the GPU as wedged. This not only disables graphics
acceleration but may also cripple other functions such as VT switch.
Solve this by "prefaulting" user pages on GEM object creation, testing
whether all pages are eligible for get_user_pages() in the process.
On failure, return -EFAULT so that userspace can fallback to software
blitting.
This behavior can be enabled via a new modparam "gem_userptr_prefault",
which is false by default.
Known use cases:
- As a debugging aid, invalid pointers and/or wrong pages passed to
userptr could be caught much earlier.
- Qubes OS R4.0 uses VM_PFNMAP pages from drivers/xen/privcmd.c, in
order to map framebuffers from Xen guest to dom0. These pages are not
GUP-able, but they cannot be exposed via DMA-BUF either. Previously
this issue had gone somehow undetected, until some patch between
v4.14 and v4.19 triggered it.
Signed-off-by: Jinoh Kang <jinoh.kang.kr@gmail.com>
Cc: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 35 +++++++++++++++++++++
drivers/gpu/drm/i915/i915_params.c | 3 ++
drivers/gpu/drm/i915/i915_params.h | 1 +
3 files changed, 39 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
index f2eaed6aca3d..5d653df2f759 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
@@ -712,6 +712,33 @@ static const struct drm_i915_gem_object_ops i915_gem_userptr_ops = {
.release = i915_gem_userptr_release,
};
+static int i915_gem_userptr_prefault(unsigned long start,
+ unsigned long nr_pages,
+ bool readonly)
+{
+ unsigned int gup_flags = (readonly ? 0 : FOLL_WRITE) | FOLL_NOWAIT;
+ int err = 0;
+
+ mmap_read_lock(current->mm);
+ while (nr_pages) {
+ long ret;
+
+ ret = get_user_pages(start, nr_pages, gup_flags, NULL, NULL);
+ if (ret < 0) {
+ err = (int)ret;
+ break;
+ }
+ if (ret == 0)
+ ret = 1; /* skip this page */
+
+ start += ret << PAGE_SHIFT;
+ nr_pages -= ret;
+ }
+ mmap_read_unlock(current->mm);
+
+ return err;
+}
+
/*
* Creates a new mm object that wraps some normal memory from the process
* context - user memory.
@@ -796,6 +823,14 @@ i915_gem_userptr_ioctl(struct drm_device *dev,
if (!access_ok((char __user *)(unsigned long)args->user_ptr, args->user_size))
return -EFAULT;
+ if (i915_modparams.gem_userptr_prefault) {
+ ret = i915_gem_userptr_prefault((unsigned long)args->user_ptr,
+ args->user_size >> PAGE_SHIFT,
+ args->flags & I915_USERPTR_READ_ONLY);
+ if (ret)
+ return ret;
+ }
+
if (args->flags & I915_USERPTR_READ_ONLY) {
/*
* On almost all of the older hw, we cannot tell the GPU that
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 7f139ea4a90b..b5e0a88c059f 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -197,6 +197,9 @@ i915_param_named_unsafe(fake_lmem_start, ulong, 0400,
"Fake LMEM start offset (default: 0)");
#endif
+i915_param_named(gem_userptr_prefault, bool, 0600,
+ "Prefault pages when userptr GEM object is created (default: false)");
+
static __always_inline void _print_param(struct drm_printer *p,
const char *name,
const char *type,
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 330c03e2b4f7..323f60298b05 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -79,6 +79,7 @@ struct drm_printer;
param(bool, disable_display, false, 0400) \
param(bool, verbose_state_checks, true, 0) \
param(bool, nuclear_pageflip, false, 0400) \
+ param(bool, gem_userptr_prefault, false, 0600) \
param(bool, enable_dp_mst, true, 0600) \
param(bool, enable_gvt, false, 0400)
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early
2021-01-15 16:23 [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early Jinoh Kang
@ 2021-01-15 16:56 ` Chris Wilson
2021-01-15 17:03 ` Jinoh Kang
2021-01-15 17:07 ` Chris Wilson
2021-01-15 20:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (5 subsequent siblings)
6 siblings, 2 replies; 11+ messages in thread
From: Chris Wilson @ 2021-01-15 16:56 UTC (permalink / raw)
To: Jinoh Kang, Marek Marczykowski-Górecki
Cc: dri-devel, David Airlie, intel-gfx, linux-kernel, Matthew Auld
Quoting Jinoh Kang (2021-01-15 16:23:31)
> If GUP-ineligible pages are passed to a GEM userptr object, -EFAULT is
> returned only when the object is actually bound.
>
> The xf86-video-intel userspace driver cannot differentiate this
> condition, and marks the GPU as wedged.
The idea was to call gem_set_domain on the object to validate the pages
after creation. I only did that for read-only... I did however make mesa
use set-domain for validation.
As a question how are you getting to call userptr on something that
wasn't passed by SHM ipc?
> This not only disables graphics
> acceleration but may also cripple other functions such as VT switch.
That should be a non-sequitur; certainly VT switch works without ever
using the GPU.
> Solve this by "prefaulting" user pages on GEM object creation, testing
> whether all pages are eligible for get_user_pages() in the process.
> On failure, return -EFAULT so that userspace can fallback to software
> blitting.
See https://patchwork.freedesktop.org/series/33449/ for adding PROBE |
POPULATE flags.
But we can just use set-domain.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early
2021-01-15 16:56 ` Chris Wilson
@ 2021-01-15 17:03 ` Jinoh Kang
2021-01-15 17:07 ` Chris Wilson
1 sibling, 0 replies; 11+ messages in thread
From: Jinoh Kang @ 2021-01-15 17:03 UTC (permalink / raw)
To: Chris Wilson, Marek Marczykowski-Górecki
Cc: dri-devel, David Airlie, intel-gfx, linux-kernel, Matthew Auld
On 1/15/21 4:56 PM, Chris Wilson wrote:
> Quoting Jinoh Kang (2021-01-15 16:23:31)
>> If GUP-ineligible pages are passed to a GEM userptr object, -EFAULT is
>> returned only when the object is actually bound.
>>
>> The xf86-video-intel userspace driver cannot differentiate this
>> condition, and marks the GPU as wedged.
>
> The idea was to call gem_set_domain on the object to validate the pages
> after creation. I only did that for read-only... I did however make mesa
> use set-domain for validation.
Thanks for the info!
>
> As a question how are you getting to call userptr on something that
> wasn't passed by SHM ipc?
Basically XShmAttachFd, which is not exposed on libX11.
>
>> This not only disables graphics
>> acceleration but may also cripple other functions such as VT switch.
>
> That should be a non-sequitur; certainly VT switch works without ever
> using the GPU.
Not that VT switch doesn't work; rather, there's some heavy graphic
artifacts such as blank rectangles or part of window going completely
transparent. I suppose that's another issue.
>
>> Solve this by "prefaulting" user pages on GEM object creation, testing
>> whether all pages are eligible for get_user_pages() in the process.
>> On failure, return -EFAULT so that userspace can fallback to software
>> blitting.
>
> See https://patchwork.freedesktop.org/series/33449/ for adding PROBE |
> POPULATE flags.
>
> But we can just use set-domain.
So this patch was unnecessary. Thanks for the pointer as to how to
patch the userspace.
> -Chris
>
--
Sincerely,
Jinoh Kang
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early
2021-01-15 16:56 ` Chris Wilson
2021-01-15 17:03 ` Jinoh Kang
@ 2021-01-15 17:07 ` Chris Wilson
2021-01-16 5:11 ` Jinoh Kang
1 sibling, 1 reply; 11+ messages in thread
From: Chris Wilson @ 2021-01-15 17:07 UTC (permalink / raw)
To: Jinoh Kang, Marek Marczykowski-Górecki
Cc: dri-devel, David Airlie, intel-gfx, linux-kernel, Matthew Auld
Quoting Chris Wilson (2021-01-15 16:56:42)
> Quoting Jinoh Kang (2021-01-15 16:23:31)
> > If GUP-ineligible pages are passed to a GEM userptr object, -EFAULT is
> > returned only when the object is actually bound.
> >
> > The xf86-video-intel userspace driver cannot differentiate this
> > condition, and marks the GPU as wedged.
>
> The idea was to call gem_set_domain on the object to validate the pages
> after creation. I only did that for read-only... I did however make mesa
> use set-domain for validation.
Hmm, I remember a reason why we wanted to be lazy in populating the
pages was that we would often be called to create a map that was never
used. So the additional gup + bind was measurable, and we would rather
just have a probe.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/userptr: detect un-GUP-able pages early
2021-01-15 16:23 [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early Jinoh Kang
2021-01-15 16:56 ` Chris Wilson
@ 2021-01-15 20:46 ` Patchwork
2021-01-15 21:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (4 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-15 20:46 UTC (permalink / raw)
To: Jinoh Kang; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/userptr: detect un-GUP-able pages early
URL : https://patchwork.freedesktop.org/series/85925/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
84aaa6e33a39 drm/i915/userptr: detect un-GUP-able pages early
-:106: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#106: FILE: drivers/gpu/drm/i915/i915_params.c:201:
+i915_param_named(gem_userptr_prefault, bool, 0600,
+ "Prefault pages when userptr GEM object is created (default: false)");
total: 0 errors, 0 warnings, 1 checks, 63 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/userptr: detect un-GUP-able pages early
2021-01-15 16:23 [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early Jinoh Kang
2021-01-15 16:56 ` Chris Wilson
2021-01-15 20:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2021-01-15 21:16 ` Patchwork
2021-01-16 4:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-15 21:16 UTC (permalink / raw)
To: Jinoh Kang; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2428 bytes --]
== Series Details ==
Series: drm/i915/userptr: detect un-GUP-able pages early
URL : https://patchwork.freedesktop.org/series/85925/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9624 -> Patchwork_19376
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/index.html
Known issues
------------
Here are the changes found in Patchwork_19376 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@basic:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/fi-tgl-y/igt@gem_mmap_gtt@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/fi-tgl-y/igt@gem_mmap_gtt@basic.html
#### Possible fixes ####
* igt@gem_render_tiled_blits@basic:
- fi-tgl-y: [DMESG-WARN][3] ([i915#402]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/fi-tgl-y/igt@gem_render_tiled_blits@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/fi-tgl-y/igt@gem_render_tiled_blits@basic.html
* igt@i915_selftest@live@blt:
- fi-snb-2600: [DMESG-FAIL][5] ([i915#1409]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/fi-snb-2600/igt@i915_selftest@live@blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/fi-snb-2600/igt@i915_selftest@live@blt.html
[i915#1409]: https://gitlab.freedesktop.org/drm/intel/issues/1409
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (42 -> 38)
------------------------------
Missing (4): fi-byt-j1900 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9624 -> Patchwork_19376
CI-20190529: 20190529
CI_DRM_9624: c94178b94789eadad87ec0e784572da0f288db55 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5959: c5cf0734c4f6c1fa17a6a15b5aa721c3a0b8c494 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19376: 84aaa6e33a39c23fb331ecd6fd4379e58fb0e19b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
84aaa6e33a39 drm/i915/userptr: detect un-GUP-able pages early
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/index.html
[-- Attachment #1.2: Type: text/html, Size: 3152 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/userptr: detect un-GUP-able pages early
2021-01-15 16:23 [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early Jinoh Kang
` (2 preceding siblings ...)
2021-01-15 21:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-01-16 4:11 ` Patchwork
2021-01-19 18:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/userptr: detect un-GUP-able pages early (rev2) Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-16 4:11 UTC (permalink / raw)
To: Jinoh Kang; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 18625 bytes --]
== Series Details ==
Series: drm/i915/userptr: detect un-GUP-able pages early
URL : https://patchwork.freedesktop.org/series/85925/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9624_full -> Patchwork_19376_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19376_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19376_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19376_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gem_contexts:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-iclb8/igt@i915_selftest@live@gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-iclb2/igt@i915_selftest@live@gem_contexts.html
Known issues
------------
Here are the changes found in Patchwork_19376_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@render-ccs:
- shard-glk: [PASS][3] -> [INCOMPLETE][4] ([i915#2405] / [i915#2499])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-glk2/igt@api_intel_bb@render-ccs.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-glk2/igt@api_intel_bb@render-ccs.html
* igt@core_hotunplug@unbind-rebind:
- shard-hsw: NOTRUN -> [WARN][5] ([i915#2283])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-hsw6/igt@core_hotunplug@unbind-rebind.html
* igt@gem_ctx_persistence@engines-hostile:
- shard-hsw: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) +5 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-hsw6/igt@gem_ctx_persistence@engines-hostile.html
* igt@gem_exec_endless@dispatch@rcs0:
- shard-kbl: [PASS][7] -> [INCOMPLETE][8] ([i915#2502])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-kbl6/igt@gem_exec_endless@dispatch@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-kbl2/igt@gem_exec_endless@dispatch@rcs0.html
* igt@gem_exec_reloc@basic-many-active@vcs0:
- shard-hsw: NOTRUN -> [FAIL][9] ([i915#2389]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-hsw6/igt@gem_exec_reloc@basic-many-active@vcs0.html
* igt@gem_exec_reloc@basic-many-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][10] ([i915#2389])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-iclb2/igt@gem_exec_reloc@basic-many-active@vcs1.html
* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#118] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-glk7/igt@gem_exec_whisper@basic-queues-forked.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-glk5/igt@gem_exec_whisper@basic-queues-forked.html
* igt@gem_pwrite@basic-exhaustion:
- shard-hsw: NOTRUN -> [WARN][13] ([i915#2658])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-hsw6/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_userptr_blits@process-exit-mmap@wc:
- shard-hsw: NOTRUN -> [SKIP][14] ([fdo#109271]) +322 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-hsw6/igt@gem_userptr_blits@process-exit-mmap@wc.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][15] ([i915#454])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl4/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [PASS][16] -> [FAIL][17] ([i915#1860])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-hsw4/igt@i915_pm_rc6_residency@rc6-idle.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-hsw6/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_color@pipe-c-ctm-0-5:
- shard-skl: [PASS][18] -> [DMESG-WARN][19] ([i915#1982])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-skl4/igt@kms_color@pipe-c-ctm-0-5.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl5/igt@kms_color@pipe-c-ctm-0-5.html
* igt@kms_color_chamelium@pipe-b-ctm-green-to-red:
- shard-hsw: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +18 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-hsw6/igt@kms_color_chamelium@pipe-b-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
- shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl4/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html
* igt@kms_cursor_crc@pipe-b-cursor-256x85-random:
- shard-skl: [PASS][22] -> [FAIL][23] ([i915#54]) +8 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-256x85-random.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-256x85-random.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-kbl: [PASS][24] -> [INCOMPLETE][25] ([i915#2295])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-kbl3/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-kbl6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-glk: [PASS][26] -> [FAIL][27] ([i915#2346])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-skl: [PASS][28] -> [FAIL][29] ([i915#2346])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][30] -> [INCOMPLETE][31] ([i915#198])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-skl8/igt@kms_fbcon_fbt@psr-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl6/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-indfb-fliptrack:
- shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271]) +30 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl7/igt@kms_frontbuffer_tracking@fbcpsr-2p-indfb-fliptrack.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: NOTRUN -> [FAIL][33] ([fdo#108145] / [i915#265]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_scaling@plane-scaling@pipe-b-plane-scaling:
- shard-kbl: [PASS][34] -> [DMESG-WARN][35] ([i915#180] / [i915#78])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-kbl6/igt@kms_plane_scaling@plane-scaling@pipe-b-plane-scaling.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-kbl2/igt@kms_plane_scaling@plane-scaling@pipe-b-plane-scaling.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][36] -> [SKIP][37] ([fdo#109441]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html
#### Possible fixes ####
* {igt@gem_exec_fair@basic-none@vcs0}:
- shard-apl: [FAIL][38] ([i915#2842]) -> [PASS][39] +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-apl7/igt@gem_exec_fair@basic-none@vcs0.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-apl6/igt@gem_exec_fair@basic-none@vcs0.html
* {igt@gem_exec_fair@basic-pace-share@rcs0}:
- shard-glk: [FAIL][40] ([i915#2842]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* {igt@gem_exec_fair@basic-pace@bcs0}:
- shard-iclb: [FAIL][42] ([i915#2842]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-iclb8/igt@gem_exec_fair@basic-pace@bcs0.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-iclb7/igt@gem_exec_fair@basic-pace@bcs0.html
* {igt@gem_exec_fair@basic-pace@vcs1}:
- shard-kbl: [FAIL][44] ([i915#2842]) -> [PASS][45] +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html
* {igt@gem_vm_create@destroy-race}:
- shard-tglb: [TIMEOUT][46] ([i915#2795]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-tglb3/igt@gem_vm_create@destroy-race.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-tglb2/igt@gem_vm_create@destroy-race.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen:
- shard-skl: [FAIL][48] ([i915#54]) -> [PASS][49] +13 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [FAIL][50] ([i915#2346]) -> [PASS][51] +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- shard-skl: [DMESG-WARN][52] ([i915#1982]) -> [PASS][53] +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-skl1/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl4/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [FAIL][54] ([i915#79]) -> [PASS][55] +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-glk: [FAIL][56] ([i915#49]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-gtt.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [INCOMPLETE][58] ([i915#198]) -> [PASS][59] +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-skl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][60] ([fdo#108145] / [i915#265]) -> [PASS][61] +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-kbl: [DMESG-WARN][62] ([i915#165] / [i915#180] / [i915#78]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-kbl2/igt@kms_plane_lowres@pipe-b-tiling-yf.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-kbl4/igt@kms_plane_lowres@pipe-b-tiling-yf.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][64] ([fdo#109441]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@perf@blocking:
- shard-skl: [FAIL][66] ([i915#1542]) -> [PASS][67] +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-skl8/igt@perf@blocking.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-skl6/igt@perf@blocking.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][68] ([i915#588]) -> [SKIP][69] ([i915#658])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-iclb4/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][70] ([i915#1804] / [i915#2684]) -> [WARN][71] ([i915#2681] / [i915#2684]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [FAIL][72] ([i915#2597]) -> [FAIL][73] ([i915#2574])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/shard-tglb1/igt@kms_async_flips@test-time-stamp.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/shard-tglb5/igt@kms_async_flips@test-time-stamp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1860]: https://gitlab.freedesktop.org/drm/intel/issues/1860
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2499]: https://gitlab.freedesktop.org/drm/intel/issues/2499
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#2574]: https://gitlab.freedesktop.org/drm/intel/issues/2574
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2795]: https://gitlab.freedesktop.org/drm/intel/issues/2795
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9624 -> Patchwork_19376
CI-20190529: 20190529
CI_DRM_9624: c94178b94789eadad87ec0e784572da0f288db55 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5959: c5cf0734c4f6c1fa17a6a15b5aa721c3a0b8c494 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19376: 84aaa6e33a39c23fb331ecd6fd4379e58fb0e19b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19376/index.html
[-- Attachment #1.2: Type: text/html, Size: 21408 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early
2021-01-15 17:07 ` Chris Wilson
@ 2021-01-16 5:11 ` Jinoh Kang
0 siblings, 0 replies; 11+ messages in thread
From: Jinoh Kang @ 2021-01-16 5:11 UTC (permalink / raw)
To: Chris Wilson, Marek Marczykowski-Górecki
Cc: dri-devel, David Airlie, intel-gfx, linux-kernel, Matthew Auld
On 1/15/21 5:07 PM, Chris Wilson wrote:
> Quoting Chris Wilson (2021-01-15 16:56:42)
>> Quoting Jinoh Kang (2021-01-15 16:23:31)
>>> If GUP-ineligible pages are passed to a GEM userptr object, -EFAULT is
>>> returned only when the object is actually bound.
>>>
>>> The xf86-video-intel userspace driver cannot differentiate this
>>> condition, and marks the GPU as wedged.
>>
>> The idea was to call gem_set_domain on the object to validate the pages
>> after creation. I only did that for read-only... I did however make mesa
>> use set-domain for validation.
>
> Hmm, I remember a reason why we wanted to be lazy in populating the
> pages was that we would often be called to create a map that was never
> used. So the additional gup + bind was measurable, and we would rather
> just have a probe.
> -Chris
>
try_upload__blt uses the map immediately, so I guess that would be an
appropriate place to patch.
> Basically XShmAttachFd, which is not exposed on libX11.
To clarify: privcmd pages cannot actually be passed by fd, since it's
tightly bound with current->mm. There's some sysv shmop hooking hack
involved, which is injected in Xorg side.
---
Besides, is there an equivalent code path that lets you eagerly *unpin*
pages when closing an userptr object without waiting for the worker?
This is actually more of a problem in drivers/xen/grant-table.c side,
since it hangs the current task until all page refs are released, and
it didn't even use ZONE_DEVICE pages until recently (while still not
using dev_pagemap_ops::page_free, since the unpopulated-alloc pgmap
is not MEMORY_DEVICE_FS_DAX apparently).
(You could say that we should switch to DMA-BUF instead and that would
be a valid criticism. I'm merely figuring out what the best workaround
for the current status quo would be.)
I'm using something like the following:
---
drivers/gpu/drm/i915/gem/i915_gem_object.c | 8 ++++++++
drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 1 +
drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 3 ++-
drivers/gpu/drm/i915/i915_params.c | 3 +++
drivers/gpu/drm/i915/i915_params.h | 1 +
5 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
index 00d24000b5e8..4352a5788fd8 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
@@ -167,6 +167,14 @@ static void i915_gem_close_object(struct drm_gem_object *gem, struct drm_file *f
i915_lut_handle_free(lut);
i915_gem_object_put(obj);
}
+
+ if (i915_modparams.gem_userptr_close_immediate &&
+ i915_gem_object_type_has(obj, I915_GEM_OBJECT_IMM_RELEASE) &&
+ i915_gem_object_is_shrinkable(obj) &&
+ !atomic_read(&obj->mm.shrink_pin) &&
+ i915_gem_object_unbind(obj, I915_GEM_OBJECT_UNBIND_ACTIVE |
+ I915_GEM_OBJECT_UNBIND_TEST) == 0)
+ __i915_gem_object_put_pages(obj);
}
static void __i915_gem_free_object_rcu(struct rcu_head *head)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
index e2d9b7e1e152..0ac1dfed0b91 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
@@ -36,6 +36,7 @@ struct drm_i915_gem_object_ops {
#define I915_GEM_OBJECT_IS_PROXY BIT(3)
#define I915_GEM_OBJECT_NO_MMAP BIT(4)
#define I915_GEM_OBJECT_ASYNC_CANCEL BIT(5)
+#define I915_GEM_OBJECT_IMM_RELEASE BIT(7)
/* Interface between the GEM object and its backing storage.
* get_pages() is called once prior to the use of the associated set
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
index f2eaed6aca3d..baa91daf43a1 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
@@ -705,7 +705,8 @@ static const struct drm_i915_gem_object_ops i915_gem_userptr_ops = {
.flags = I915_GEM_OBJECT_HAS_STRUCT_PAGE |
I915_GEM_OBJECT_IS_SHRINKABLE |
I915_GEM_OBJECT_NO_MMAP |
- I915_GEM_OBJECT_ASYNC_CANCEL,
+ I915_GEM_OBJECT_ASYNC_CANCEL |
+ I915_GEM_OBJECT_IMM_RELEASE,
.get_pages = i915_gem_userptr_get_pages,
.put_pages = i915_gem_userptr_put_pages,
.dmabuf_export = i915_gem_userptr_dmabuf_export,
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 7f139ea4a90b..4d056fd1b6e7 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -197,6 +197,9 @@ i915_param_named_unsafe(fake_lmem_start, ulong, 0400,
"Fake LMEM start offset (default: 0)");
#endif
+i915_param_named(gem_userptr_close_immediate, bool, 0600,
+ "Immediately release pages when userptr GEM object is closed (default:false)");
+
static __always_inline void _print_param(struct drm_printer *p,
const char *name,
const char *type,
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 330c03e2b4f7..a94367a0345b 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -79,6 +79,7 @@ struct drm_printer;
param(bool, disable_display, false, 0400) \
param(bool, verbose_state_checks, true, 0) \
param(bool, nuclear_pageflip, false, 0400) \
+ param(bool, gem_userptr_close_immediate, false, 0600) \
param(bool, enable_dp_mst, true, 0600) \
param(bool, enable_gvt, false, 0400)
--
Sincerely,
Jinoh Kang
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/userptr: detect un-GUP-able pages early (rev2)
2021-01-15 16:23 [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early Jinoh Kang
` (3 preceding siblings ...)
2021-01-16 4:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2021-01-19 18:58 ` Patchwork
2021-01-19 19:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-19 22:41 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-19 18:58 UTC (permalink / raw)
To: Jinoh Kang; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/userptr: detect un-GUP-able pages early (rev2)
URL : https://patchwork.freedesktop.org/series/85925/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c3761c13da43 drm/i915/userptr: detect un-GUP-able pages early
-:89: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#89: FILE: drivers/gpu/drm/i915/i915_params.c:201:
+i915_param_named(gem_userptr_close_immediate, bool, 0600,
+ "Immediately release pages when userptr GEM object is closed (default:false)");
-:105: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 1 checks, 46 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/userptr: detect un-GUP-able pages early (rev2)
2021-01-15 16:23 [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early Jinoh Kang
` (4 preceding siblings ...)
2021-01-19 18:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/userptr: detect un-GUP-able pages early (rev2) Patchwork
@ 2021-01-19 19:27 ` Patchwork
2021-01-19 22:41 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-19 19:27 UTC (permalink / raw)
To: Jinoh Kang; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5166 bytes --]
== Series Details ==
Series: drm/i915/userptr: detect un-GUP-able pages early (rev2)
URL : https://patchwork.freedesktop.org/series/85925/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9644 -> Patchwork_19409
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/index.html
Known issues
------------
Here are the changes found in Patchwork_19409 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@memory-alloc:
- fi-tgl-y: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/fi-tgl-y/igt@amdgpu/amd_basic@memory-alloc.html
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][2] ([fdo#109271]) +26 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][4] ([i915#2283])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [PASS][6] -> [DMESG-WARN][7] ([i915#402]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
* igt@runner@aborted:
- fi-kbl-r: NOTRUN -> [FAIL][8] ([i915#1569] / [i915#192] / [i915#193] / [i915#194] / [i915#2295])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/fi-kbl-r/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_getparams_basic@basic-subslice-total:
- fi-tgl-y: [DMESG-WARN][9] ([i915#402]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [FAIL][11] ([i915#2203] / [i915#579]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][13] ([i915#2782]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1569]: https://gitlab.freedesktop.org/drm/intel/issues/1569
[i915#192]: https://gitlab.freedesktop.org/drm/intel/issues/192
[i915#193]: https://gitlab.freedesktop.org/drm/intel/issues/193
[i915#194]: https://gitlab.freedesktop.org/drm/intel/issues/194
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
Participating hosts (43 -> 37)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9644 -> Patchwork_19409
CI-20190529: 20190529
CI_DRM_9644: 12cf13e4efed76291e500bab3b1b4d6ff4a00bb5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19409: c3761c13da431175d01da34b09536f6eb9fd206b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c3761c13da43 drm/i915/userptr: detect un-GUP-able pages early
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/index.html
[-- Attachment #1.2: Type: text/html, Size: 6200 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/userptr: detect un-GUP-able pages early (rev2)
2021-01-15 16:23 [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early Jinoh Kang
` (5 preceding siblings ...)
2021-01-19 19:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-01-19 22:41 ` Patchwork
6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-19 22:41 UTC (permalink / raw)
To: Jinoh Kang; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 22857 bytes --]
== Series Details ==
Series: drm/i915/userptr: detect un-GUP-able pages early (rev2)
URL : https://patchwork.freedesktop.org/series/85925/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9644_full -> Patchwork_19409_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19409_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][1] -> [FAIL][2] ([i915#2842]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][3] -> [FAIL][4] ([i915#2842]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html
- shard-iclb: [PASS][7] -> [FAIL][8] ([i915#2849])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_reloc@basic-wide-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][9] ([i915#2389])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@gem_exec_reloc@basic-wide-active@vcs1.html
* igt@gem_exec_schedule@u-fairslice@vecs0:
- shard-skl: [PASS][10] -> [DMESG-WARN][11] ([i915#1610] / [i915#2803])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl3/igt@gem_exec_schedule@u-fairslice@vecs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl8/igt@gem_exec_schedule@u-fairslice@vecs0.html
* igt@gem_exec_whisper@basic-normal:
- shard-glk: [PASS][12] -> [DMESG-WARN][13] ([i915#118] / [i915#95]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-glk1/igt@gem_exec_whisper@basic-normal.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-glk7/igt@gem_exec_whisper@basic-normal.html
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][14] ([i915#768]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-iclb: NOTRUN -> [SKIP][15] ([fdo#110892])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][16] ([fdo#110725] / [fdo#111614]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@kms_big_fb@x-tiled-8bpp-rotate-270.html
* igt@kms_chamelium@dp-edid-read:
- shard-iclb: NOTRUN -> [SKIP][17] ([fdo#109284] / [fdo#111827]) +5 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@kms_chamelium@dp-edid-read.html
* igt@kms_color@pipe-d-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][18] ([fdo#109278] / [i915#1149])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@kms_color@pipe-d-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-b-degamma:
- shard-kbl: NOTRUN -> [SKIP][19] ([fdo#109271] / [fdo#111827]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-kbl2/igt@kms_color_chamelium@pipe-b-degamma.html
* igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
- shard-skl: [PASS][20] -> [FAIL][21] ([i915#54]) +7 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl9/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][22] ([fdo#109278] / [fdo#109279])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][23] ([fdo#109278]) +4 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions:
- shard-iclb: NOTRUN -> [SKIP][24] ([fdo#109274] / [fdo#109278]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions.html
* igt@kms_flip@2x-wf_vblank-ts-check-interruptible:
- shard-iclb: NOTRUN -> [SKIP][25] ([fdo#109274])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@kms_flip@2x-wf_vblank-ts-check-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [PASS][26] -> [FAIL][27] ([i915#2598]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-tglb3/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][28] -> [FAIL][29] ([i915#79]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][30] -> [FAIL][31] ([i915#2122])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
- shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271]) +16 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#109280]) +9 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271]) +5 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-indfb-scaledprimary:
- shard-tglb: [PASS][35] -> [DMESG-WARN][36] ([i915#1982])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-indfb-scaledprimary.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-indfb-scaledprimary.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#1188])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl8/igt@kms_hdr@bpc-switch.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl10/igt@kms_hdr@bpc-switch.html
* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#109289]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- shard-glk: [PASS][40] -> [FAIL][41] ([i915#53])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-glk9/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-glk6/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][42] ([fdo#108145] / [i915#265])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-kbl2/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][43] -> [FAIL][44] ([fdo#108145] / [i915#265])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: NOTRUN -> [SKIP][45] ([i915#658])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][46] -> [SKIP][47] ([fdo#109441])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109441])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@perf_pmu@event-wait@rcs0:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#112283])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@perf_pmu@event-wait@rcs0.html
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109291]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html
#### Possible fixes ####
* igt@gem_ctx_persistence@close-replace-race:
- shard-glk: [TIMEOUT][51] ([i915#2918]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-glk6/igt@gem_ctx_persistence@close-replace-race.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-glk4/igt@gem_ctx_persistence@close-replace-race.html
* igt@gem_exec_capture@pi@vecs0:
- shard-skl: [INCOMPLETE][53] ([i915#198] / [i915#2624]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl4/igt@gem_exec_capture@pi@vecs0.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl9/igt@gem_exec_capture@pi@vecs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-tglb: [FAIL][55] ([i915#2842]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-tglb5/igt@gem_exec_fair@basic-pace@vcs1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-tglb1/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_schedule@u-fairslice@vcs0:
- shard-skl: [DMESG-WARN][57] ([i915#1610] / [i915#2803]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl3/igt@gem_exec_schedule@u-fairslice@vcs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl8/igt@gem_exec_schedule@u-fairslice@vcs0.html
* igt@gem_exec_schedule@u-fairslice@vecs0:
- shard-kbl: [DMESG-WARN][59] ([i915#1610] / [i915#2803]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-kbl3/igt@gem_exec_schedule@u-fairslice@vecs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-kbl2/igt@gem_exec_schedule@u-fairslice@vecs0.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][61] ([i915#454]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
* igt@i915_selftest@live@gem_contexts:
- shard-iclb: [INCOMPLETE][63] -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-iclb4/igt@i915_selftest@live@gem_contexts.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb1/igt@i915_selftest@live@gem_contexts.html
* igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen:
- shard-skl: [FAIL][65] ([i915#54]) -> [PASS][66] +9 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html
* igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge:
- shard-glk: [DMESG-WARN][67] ([i915#118] / [i915#95]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-glk9/igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-glk6/igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][69] ([i915#180] / [i915#78]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-kbl2/igt@kms_hdr@bpc-switch-suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-kbl6/igt@kms_hdr@bpc-switch-suspend.html
- shard-skl: [FAIL][71] ([i915#1188]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl7/igt@kms_hdr@bpc-switch-suspend.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl3/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][73] ([fdo#108145] / [i915#265]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-iclb8/igt@kms_psr@psr2_cursor_plane_move.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
* igt@perf@blocking:
- shard-skl: [FAIL][77] ([i915#1542]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl5/igt@perf@blocking.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl2/igt@perf@blocking.html
* igt@perf_pmu@busy-double-start@vecs0:
- shard-skl: [DMESG-WARN][79] ([i915#1982]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl1/igt@perf_pmu@busy-double-start@vecs0.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl5/igt@perf_pmu@busy-double-start@vecs0.html
* igt@perf_pmu@module-unload:
- shard-skl: [DMESG-WARN][81] ([i915#1982] / [i915#262]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-skl1/igt@perf_pmu@module-unload.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-skl5/igt@perf_pmu@module-unload.html
#### Warnings ####
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [SKIP][83] ([fdo#109271]) -> [FAIL][84] ([i915#2842])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][85] ([i915#2684]) -> [WARN][86] ([i915#1804] / [i915#2684])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][87] ([i915#1804] / [i915#2684]) -> [WARN][88] ([i915#2684])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-iclb: [SKIP][89] ([i915#2920]) -> [SKIP][90] ([i915#658])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: [SKIP][91] ([i915#658]) -> [SKIP][92] ([i915#2920])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-iclb8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][93], [FAIL][94]) ([i915#2295] / [i915#2426]) -> [FAIL][95] ([i915#2295])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-kbl3/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9644/shard-kbl1/igt@runner@aborted.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/shard-kbl1/igt@runner@aborted.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#2624]: https://gitlab.freedesktop.org/drm/intel/issues/2624
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2918]: https://gitlab.freedesktop.org/drm/intel/issues/2918
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9644 -> Patchwork_19409
CI-20190529: 20190529
CI_DRM_9644: 12cf13e4efed76291e500bab3b1b4d6ff4a00bb5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19409: c3761c13da431175d01da34b09536f6eb9fd206b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19409/index.html
[-- Attachment #1.2: Type: text/html, Size: 27233 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-01-19 22:41 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 16:23 [Intel-gfx] [PATCH] drm/i915/userptr: detect un-GUP-able pages early Jinoh Kang
2021-01-15 16:56 ` Chris Wilson
2021-01-15 17:03 ` Jinoh Kang
2021-01-15 17:07 ` Chris Wilson
2021-01-16 5:11 ` Jinoh Kang
2021-01-15 20:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-01-15 21:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-16 4:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-19 18:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/userptr: detect un-GUP-able pages early (rev2) Patchwork
2021-01-19 19:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-19 22:41 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).