* [Intel-gfx] [PATCH] drm/i915/gt: Flush before changing register state
@ 2021-01-25 22:02 Chris Wilson
2021-01-26 1:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2021-01-25 22:02 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
Flush; invalidate; change registers; invalidate; flush.
Will this finally work on every device? Or will Baytrail complain again?
On the positive side, we immediate see the benefit of having hsw-gt1 in
CU.
Fixes: ace44e13e577 ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
Testcase: igt/gem_render_tiled_blits # hsw-gt1
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
---
drivers/gpu/drm/i915/gt/gen7_renderclear.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
index 8551e6de50e8..e403eb046a43 100644
--- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
+++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
@@ -393,6 +393,7 @@ static void emit_batch(struct i915_vma * const vma,
desc_count);
/* Reset inherited context registers */
+ gen7_emit_pipeline_flush(&cmds);
gen7_emit_pipeline_invalidate(&cmds);
batch_add(&cmds, MI_LOAD_REGISTER_IMM(2));
batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_0_GEN7));
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Flush before changing register state
2021-01-25 22:02 [Intel-gfx] [PATCH] drm/i915/gt: Flush before changing register state Chris Wilson
@ 2021-01-26 1:23 ` Patchwork
2021-01-26 7:44 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-26 11:46 ` [Intel-gfx] [PATCH] " Mika Kuoppala
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2021-01-26 1:23 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2583 bytes --]
== Series Details ==
Series: drm/i915/gt: Flush before changing register state
URL : https://patchwork.freedesktop.org/series/86276/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9682 -> Patchwork_19496
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/index.html
Known issues
------------
Here are the changes found in Patchwork_19496 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_sync@basic-all:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/fi-tgl-y/igt@gem_sync@basic-all.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/fi-tgl-y/igt@gem_sync@basic-all.html
#### Possible fixes ####
* igt@gem_render_tiled_blits@basic:
- {fi-hsw-gt1}: [FAIL][3] -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/fi-hsw-gt1/igt@gem_render_tiled_blits@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/fi-hsw-gt1/igt@gem_render_tiled_blits@basic.html
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [DMESG-WARN][5] ([i915#402]) -> [PASS][6] +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (40 -> 35)
------------------------------
Missing (5): fi-jsl-1 fi-ilk-m540 fi-hsw-4200u fi-tgl-u2 fi-ctg-p8600
Build changes
-------------
* Linux: CI_DRM_9682 -> Patchwork_19496
CI-20190529: 20190529
CI_DRM_9682: 35ee6d505b478462c04952da1a4fbc03991af114 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5971: abef2b7d6ff30f3b948b3e5d39653debb73083f3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19496: 96e74e1408d6a5ad3af121289d83a22afcdcc2a7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
96e74e1408d6 drm/i915/gt: Flush before changing register state
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/index.html
[-- Attachment #1.2: Type: text/html, Size: 3320 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Flush before changing register state
2021-01-25 22:02 [Intel-gfx] [PATCH] drm/i915/gt: Flush before changing register state Chris Wilson
2021-01-26 1:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-01-26 7:44 ` Patchwork
2021-01-26 11:46 ` [Intel-gfx] [PATCH] " Mika Kuoppala
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2021-01-26 7:44 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 14109 bytes --]
== Series Details ==
Series: drm/i915/gt: Flush before changing register state
URL : https://patchwork.freedesktop.org/series/86276/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9682_full -> Patchwork_19496_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19496_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@sysfs_clients@pidname}:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-glk9/igt@sysfs_clients@pidname.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-glk2/igt@sysfs_clients@pidname.html
Known issues
------------
Here are the changes found in Patchwork_19496_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][3] -> [FAIL][4] ([i915#2846])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-kbl6/igt@gem_exec_fair@basic-deadline.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2842]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-tglb1/igt@gem_exec_fair@basic-flow@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_params@no-vebox:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-glk3/igt@gem_exec_params@no-vebox.html
* igt@gem_exec_schedule@u-fairslice-all:
- shard-glk: [PASS][10] -> [DMESG-WARN][11] ([i915#1610])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-glk8/igt@gem_exec_schedule@u-fairslice-all.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-glk8/igt@gem_exec_schedule@u-fairslice-all.html
* igt@gem_exec_schedule@u-fairslice@rcs0:
- shard-apl: [PASS][12] -> [DMESG-WARN][13] ([i915#1610])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-apl3/igt@gem_exec_schedule@u-fairslice@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-apl2/igt@gem_exec_schedule@u-fairslice@rcs0.html
- shard-tglb: [PASS][14] -> [DMESG-WARN][15] ([i915#2803])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-tglb7/igt@gem_exec_schedule@u-fairslice@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-tglb2/igt@gem_exec_schedule@u-fairslice@rcs0.html
* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-glk: [PASS][16] -> [DMESG-WARN][17] ([i915#118] / [i915#95])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-glk2/igt@gem_exec_whisper@basic-fds-forked-all.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-glk5/igt@gem_exec_whisper@basic-fds-forked-all.html
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [PASS][18] -> [FAIL][19] ([i915#2597])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-tglb8/igt@kms_async_flips@test-time-stamp.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-tglb8/igt@kms_async_flips@test-time-stamp.html
* igt@kms_color_chamelium@pipe-b-ctm-0-75:
- shard-glk: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-glk3/igt@kms_color_chamelium@pipe-b-ctm-0-75.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-glk: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#2672])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-glk3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-glk: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#533])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-glk3/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109642] / [fdo#111068] / [i915#658])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-iclb2/igt@kms_psr2_su@page_flip.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-iclb6/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-iclb6/igt@kms_psr@psr2_sprite_blt.html
* igt@perf@polling-parameterized:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#1542])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-glk6/igt@perf@polling-parameterized.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-glk3/igt@perf@polling-parameterized.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][29] ([i915#2846]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-glk9/igt@gem_exec_fair@basic-deadline.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-glk2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [FAIL][31] ([i915#2842]) -> [PASS][32] +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-kbl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-kbl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][33] ([i915#2842]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][35] ([i915#2849]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_schedule@u-fairslice@vcs0:
- shard-glk: [DMESG-WARN][37] ([i915#1610]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-glk6/igt@gem_exec_schedule@u-fairslice@vcs0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-glk3/igt@gem_exec_schedule@u-fairslice@vcs0.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [WARN][39] ([i915#1519]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-hsw4/igt@i915_pm_rc6_residency@rc6-idle.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-hsw2/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-hsw: [INCOMPLETE][41] ([i915#2055]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-hsw4/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-hsw2/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-iclb4/igt@kms_psr@psr2_suspend.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-iclb2/igt@kms_psr@psr2_suspend.html
* {igt@sysfs_clients@sema-10@rcs0}:
- shard-apl: [SKIP][45] ([fdo#109271]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-apl8/igt@sysfs_clients@sema-10@rcs0.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-apl7/igt@sysfs_clients@sema-10@rcs0.html
#### Warnings ####
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-iclb: [SKIP][47] ([i915#2920]) -> [SKIP][48] ([i915#658]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-iclb6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-iclb: [SKIP][49] ([i915#658]) -> [SKIP][50] ([i915#2920])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-iclb4/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
* igt@runner@aborted:
- shard-apl: ([FAIL][51], [FAIL][52], [FAIL][53]) ([i915#2295]) -> ([FAIL][54], [FAIL][55], [FAIL][56], [FAIL][57]) ([i915#1610] / [i915#2295] / [i915#2426])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-apl2/igt@runner@aborted.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-apl8/igt@runner@aborted.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-apl7/igt@runner@aborted.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-apl7/igt@runner@aborted.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-apl3/igt@runner@aborted.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-apl6/igt@runner@aborted.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-apl2/igt@runner@aborted.html
- shard-tglb: ([FAIL][58], [FAIL][59], [FAIL][60]) ([i915#1602] / [i915#2295] / [i915#2667]) -> ([FAIL][61], [FAIL][62], [FAIL][63], [FAIL][64]) ([i915#1602] / [i915#2295] / [i915#2426] / [i915#2667] / [i915#2803])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-tglb3/igt@runner@aborted.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-tglb1/igt@runner@aborted.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9682/shard-tglb5/igt@runner@aborted.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-tglb7/igt@runner@aborted.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-tglb3/igt@runner@aborted.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-tglb2/igt@runner@aborted.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/shard-tglb3/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#2667]: https://gitlab.freedesktop.org/drm/intel/issues/2667
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9682 -> Patchwork_19496
CI-20190529: 20190529
CI_DRM_9682: 35ee6d505b478462c04952da1a4fbc03991af114 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5971: abef2b7d6ff30f3b948b3e5d39653debb73083f3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19496: 96e74e1408d6a5ad3af121289d83a22afcdcc2a7 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19496/index.html
[-- Attachment #1.2: Type: text/html, Size: 17086 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Flush before changing register state
2021-01-25 22:02 [Intel-gfx] [PATCH] drm/i915/gt: Flush before changing register state Chris Wilson
2021-01-26 1:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-26 7:44 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-01-26 11:46 ` Mika Kuoppala
2 siblings, 0 replies; 4+ messages in thread
From: Mika Kuoppala @ 2021-01-26 11:46 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Chris Wilson
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Flush; invalidate; change registers; invalidate; flush.
>
> Will this finally work on every device? Or will Baytrail complain again?
>
> On the positive side, we immediate see the benefit of having hsw-gt1 in
> CU.
CI
Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>
> Fixes: ace44e13e577 ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
> Testcase: igt/gem_render_tiled_blits # hsw-gt1
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
> ---
> drivers/gpu/drm/i915/gt/gen7_renderclear.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> index 8551e6de50e8..e403eb046a43 100644
> --- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> +++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> @@ -393,6 +393,7 @@ static void emit_batch(struct i915_vma * const vma,
> desc_count);
>
> /* Reset inherited context registers */
> + gen7_emit_pipeline_flush(&cmds);
> gen7_emit_pipeline_invalidate(&cmds);
> batch_add(&cmds, MI_LOAD_REGISTER_IMM(2));
> batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_0_GEN7));
> --
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-26 11:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 22:02 [Intel-gfx] [PATCH] drm/i915/gt: Flush before changing register state Chris Wilson
2021-01-26 1:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-26 7:44 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-26 11:46 ` [Intel-gfx] [PATCH] " Mika Kuoppala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).