From: Chris Wilson <chris@chris-wilson.co.uk>
To: Matthew Auld <matthew.auld@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gtt: split up i915_gem_gtt
Date: Tue, 26 Jan 2021 18:59:52 +0000 [thread overview]
Message-ID: <161168759268.2943.16198172842245466140@build.alporthouse.com> (raw)
In-Reply-To: <cc82f99e-9a78-215d-32ad-a1c9ac2afac9@linux.intel.com>
Quoting Tvrtko Ursulin (2021-01-26 17:13:24)
>
>
> On 06/01/2020 23:47, Matthew Auld wrote:
> > Attempt to split i915_gem_gtt.[ch] into more manageable chunks.
>
> > +void clear_pages(struct i915_vma *vma)
> > +{
> > + GEM_BUG_ON(!vma->pages);
> > +
> > + if (vma->pages != vma->obj->mm.pages) {
> > + sg_free_table(vma->pages);
> > + kfree(vma->pages);
> > + }
> > + vma->pages = NULL;
> > +
> > + memset(&vma->page_sizes, 0, sizeof(vma->page_sizes));
> > +}
>
> We probably want to add a prefix now that the function is exported.
Or follow through on eliminating the callback.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-01-26 18:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 23:47 [Intel-gfx] [PATCH] drm/i915/gtt: split up i915_gem_gtt Matthew Auld
2020-01-06 23:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-01-07 0:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-07 11:33 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-01-07 13:40 ` Chris Wilson
2020-01-07 17:31 ` Chris Wilson
2020-01-07 13:50 ` kbuild test robot
2020-01-07 14:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2020-01-07 17:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: split up i915_gem_gtt (rev2) Patchwork
2020-01-07 17:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-08 1:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-26 17:13 ` [Intel-gfx] [PATCH] drm/i915/gtt: split up i915_gem_gtt Tvrtko Ursulin
2021-01-26 18:59 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161168759268.2943.16198172842245466140@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).