intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Diana Craciun OSS" <diana.craciun@oss.nxp.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Provide core infrastructure for managing open/release (rev4)
Date: Tue, 20 Jul 2021 17:55:22 -0000	[thread overview]
Message-ID: <162680372252.12849.3527457443031010678@emeril.freedesktop.org> (raw)
In-Reply-To: <0-v2-b6a5582525c9+ff96-vfio_reflck_jgg@nvidia.com>

== Series Details ==

Series: Provide core infrastructure for managing open/release (rev4)
URL   : https://patchwork.freedesktop.org/series/92556/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
7dbfff5c0615 vfio/samples: Remove module get/put
-:56: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 31 lines checked
a970d83995e9 vfio/mbochs: Fix missing error unwind in mbochs_probe()
-:42: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 24 lines checked
5234af9416ea vfio: Introduce a vfio_uninit_group_dev() API call
98f8177ed897 vfio: Provide better generic support for open/release vfio_device_ops
-:238: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#238: FILE: drivers/vfio/vfio.c:1480:
+	fdno = ret = get_unused_fd_flags(O_CLOEXEC);

-:336: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#336: FILE: include/linux/vfio.h:25:
+	struct mutex lock;

-:378: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 2 checks, 304 lines checked
41fd621c4613 vfio/samples: Delete useless open/close
-:97: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 66 lines checked
58c423da0813 vfio/fsl: Move to the device set infrastructure
-:299: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 255 lines checked
08ebd8d9d664 vfio/platform: Use open_device() instead of open coding a refcnt scheme
-:48: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#48: FILE: drivers/vfio/platform/vfio_platform_common.c:230:
+		dev_warn(

-:102: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#102: FILE: drivers/vfio/platform/vfio_platform_common.c:261:
+		dev_warn(

-:146: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 2 checks, 120 lines checked
f71fdc2eb5e9 vfio/pci: Move to the device set infrastructure
00142c33a230 vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set
-:130: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#130: FILE: drivers/vfio/pci/vfio_pci.c:2225:
+	if (vfio_pci_for_each_slot_or_bus(

-:236: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 1 checks, 193 lines checked
b53473635416 vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set
-:230: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#230: FILE: drivers/vfio/pci/vfio_pci.c:2103:
+	if (vfio_pci_for_each_slot_or_bus(

-:295: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 1 checks, 263 lines checked
4be916d9705d vfio/mbochs: Fix close when multiple device FDs are open
-:36: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 16 lines checked
19f77617b258 vfio/ap, ccw: Fix open/close when multiple device FDs are open
-:84: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 52 lines checked
cab2ea195208 vfio/gvt: Fix open/close when multiple device FDs are open
-:51: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 26 lines checked
162e52a805ca vfio: Remove struct vfio_device_ops open/release
-:142: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 107 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-07-20 17:55 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 17:42 [Intel-gfx] [PATCH v2 00/14] Provide core infrastructure for managing open/release Jason Gunthorpe
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 01/14] vfio/samples: Remove module get/put Jason Gunthorpe
2021-07-23  7:18   ` Christoph Hellwig
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 02/14] vfio/mbochs: Fix missing error unwind in mbochs_probe() Jason Gunthorpe
2021-07-20 22:01   ` Alex Williamson
2021-07-20 22:49     ` Jason Gunthorpe
2021-07-20 22:54       ` Alex Williamson
2021-07-21  9:18       ` Cornelia Huck
2021-07-21  9:16   ` Cornelia Huck
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 03/14] vfio: Introduce a vfio_uninit_group_dev() API call Jason Gunthorpe
2021-07-21 11:33   ` Cornelia Huck
2021-07-23  7:18   ` Christoph Hellwig
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 04/14] vfio: Provide better generic support for open/release vfio_device_ops Jason Gunthorpe
2021-07-22 14:42   ` Cornelia Huck
2021-07-23  7:39   ` Christoph Hellwig
2021-07-23 14:38     ` Jason Gunthorpe
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 05/14] vfio/samples: Delete useless open/close Jason Gunthorpe
2021-07-23  7:39   ` Christoph Hellwig
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 06/14] vfio/fsl: Move to the device set infrastructure Jason Gunthorpe
2021-07-23  7:44   ` Christoph Hellwig
2021-07-23 12:22     ` Jason Gunthorpe
2021-07-23 12:29       ` Christoph Hellwig
2021-07-23 13:11         ` Jason Gunthorpe
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 07/14] vfio/platform: Use open_device() instead of open coding a refcnt scheme Jason Gunthorpe
2021-07-22 14:48   ` Cornelia Huck
2021-07-23  7:45   ` Christoph Hellwig
2021-07-23 12:23     ` Jason Gunthorpe
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 08/14] vfio/pci: Move to the device set infrastructure Jason Gunthorpe
2021-07-23  7:47   ` Christoph Hellwig
2021-07-23 12:59     ` Jason Gunthorpe
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set Jason Gunthorpe
2021-07-23  8:05   ` Christoph Hellwig
2021-07-23 13:30     ` Jason Gunthorpe
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set Jason Gunthorpe
2021-07-23  8:12   ` Christoph Hellwig
2021-07-23 13:31     ` Jason Gunthorpe
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 11/14] vfio/mbochs: Fix close when multiple device FDs are open Jason Gunthorpe
2021-07-23  8:13   ` Christoph Hellwig
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 12/14] vfio/ap, ccw: Fix open/close " Jason Gunthorpe
2021-07-20 17:42 ` [Intel-gfx] [PATCH v2 13/14] vfio/gvt: " Jason Gunthorpe
2021-07-23  8:14   ` Christoph Hellwig
2021-07-20 17:43 ` [Intel-gfx] [PATCH v2 14/14] vfio: Remove struct vfio_device_ops open/release Jason Gunthorpe
2021-07-23  8:14   ` Christoph Hellwig
2021-07-20 17:55 ` Patchwork [this message]
2021-07-20 17:59 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for Provide core infrastructure for managing open/release (rev4) Patchwork
2021-07-20 18:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-20 19:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-07-20 22:22 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Provide core infrastructure for managing open/release (rev5) Patchwork
2021-07-23  9:41 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Provide core infrastructure for managing open/release (rev6) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162680372252.12849.3527457443031010678@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=diana.craciun@oss.nxp.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).