* [Intel-gfx] [PATCH] drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv
@ 2023-02-01 18:51 Mavroudis Chatzilaridis
2023-02-01 19:18 ` Jani Nikula
2023-02-01 19:44 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Mavroudis Chatzilaridis @ 2023-02-01 18:51 UTC (permalink / raw)
To: intel-gfx
This laptop uses inverted backlight PWM. Thus, without this quirk,
backlight brightness decreases as the brightness value increases and
vice versa.
Signed-off-by: Mavroudis Chatzilaridis <mavchatz@protonmail.com>
---
drivers/gpu/drm/i915/display/intel_quirks.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c
index 6e48d3bcdfec..a280448df771 100644
--- a/drivers/gpu/drm/i915/display/intel_quirks.c
+++ b/drivers/gpu/drm/i915/display/intel_quirks.c
@@ -199,6 +199,8 @@ static struct intel_quirk intel_quirks[] = {
/* ECS Liva Q2 */
{ 0x3185, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
{ 0x3184, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
+ /* HP Notebook - 14-r206nv */
+ { 0x0f31, 0x103c, 0x220f, quirk_invert_brightness },
};
void intel_init_quirks(struct drm_i915_private *i915)
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv
2023-02-01 18:51 [Intel-gfx] [PATCH] drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv Mavroudis Chatzilaridis
@ 2023-02-01 19:18 ` Jani Nikula
2023-02-16 16:52 ` Jani Nikula
2023-02-01 19:44 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 1 reply; 4+ messages in thread
From: Jani Nikula @ 2023-02-01 19:18 UTC (permalink / raw)
To: Mavroudis Chatzilaridis, intel-gfx
On Wed, 01 Feb 2023, Mavroudis Chatzilaridis <mavchatz@protonmail.com> wrote:
> This laptop uses inverted backlight PWM. Thus, without this quirk,
> backlight brightness decreases as the brightness value increases and
> vice versa.
>
> Signed-off-by: Mavroudis Chatzilaridis <mavchatz@protonmail.com>
Thanks for the patch, but this really needs a bug filed at fdo gitlab
with dmesg, VBT, etc. [1]
I don't doubt you, but the fix may need to be different. All the
previous quirks were on ancient GM45, and I was pretty sure the problems
were limited to that platform. I'm hesitant to add the quirk to other
platforms without more info.
Thanks,
Jani.
[1] https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-i915-bugs
> ---
> drivers/gpu/drm/i915/display/intel_quirks.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c
> index 6e48d3bcdfec..a280448df771 100644
> --- a/drivers/gpu/drm/i915/display/intel_quirks.c
> +++ b/drivers/gpu/drm/i915/display/intel_quirks.c
> @@ -199,6 +199,8 @@ static struct intel_quirk intel_quirks[] = {
> /* ECS Liva Q2 */
> { 0x3185, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
> { 0x3184, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
> + /* HP Notebook - 14-r206nv */
> + { 0x0f31, 0x103c, 0x220f, quirk_invert_brightness },
> };
>
> void intel_init_quirks(struct drm_i915_private *i915)
> --
> 2.34.1
>
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv
2023-02-01 18:51 [Intel-gfx] [PATCH] drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv Mavroudis Chatzilaridis
2023-02-01 19:18 ` Jani Nikula
@ 2023-02-01 19:44 ` Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2023-02-01 19:44 UTC (permalink / raw)
To: Mavroudis Chatzilaridis; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4801 bytes --]
== Series Details ==
Series: drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv
URL : https://patchwork.freedesktop.org/series/113568/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12680 -> Patchwork_113568v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_113568v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_113568v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113568v1/index.html
Participating hosts (26 -> 26)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113568v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-skl-6600u: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/fi-skl-6600u/igt@i915_suspend@basic-s3-without-i915.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113568v1/fi-skl-6600u/igt@i915_suspend@basic-s3-without-i915.html
Known issues
------------
Here are the changes found in Patchwork_113568v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113568v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113568v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_module_load@load:
- fi-kbl-soraka: NOTRUN -> [DMESG-WARN][5] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113568v1/fi-kbl-soraka/igt@i915_module_load@load.html
* igt@i915_selftest@live@execlists:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][6] ([i915#7156])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113568v1/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][7] ([i915#1886])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113568v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271]) +15 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113568v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
#### Possible fixes ####
* igt@i915_selftest@live@migrate:
- {bat-dg2-11}: [DMESG-WARN][9] ([i915#7699]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/bat-dg2-11/igt@i915_selftest@live@migrate.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113568v1/bat-dg2-11/igt@i915_selftest@live@migrate.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7156]: https://gitlab.freedesktop.org/drm/intel/issues/7156
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* Linux: CI_DRM_12680 -> Patchwork_113568v1
CI-20190529: 20190529
CI_DRM_12680: 06086656e6f03cbcbb4b99273734a7943e923fc9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113568v1: 06086656e6f03cbcbb4b99273734a7943e923fc9 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
5bfe004e71e2 drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113568v1/index.html
[-- Attachment #2: Type: text/html, Size: 5480 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv
2023-02-01 19:18 ` Jani Nikula
@ 2023-02-16 16:52 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2023-02-16 16:52 UTC (permalink / raw)
To: Mavroudis Chatzilaridis, intel-gfx
On Wed, 01 Feb 2023, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 01 Feb 2023, Mavroudis Chatzilaridis <mavchatz@protonmail.com> wrote:
>> This laptop uses inverted backlight PWM. Thus, without this quirk,
>> backlight brightness decreases as the brightness value increases and
>> vice versa.
>>
>> Signed-off-by: Mavroudis Chatzilaridis <mavchatz@protonmail.com>
>
> Thanks for the patch, but this really needs a bug filed at fdo gitlab
> with dmesg, VBT, etc. [1]
>
> I don't doubt you, but the fix may need to be different. All the
> previous quirks were on ancient GM45, and I was pretty sure the problems
> were limited to that platform. I'm hesitant to add the quirk to other
> platforms without more info.
>
> Thanks,
> Jani.
>
>
> [1] https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-i915-bugs
So we pretty much exhausted all the possibilities at [2], and we're left
with the quirk. I've pushed this to drm-intel-next with cc: stable,
thanks for the patch.
BR,
Jani.
PS. For posterity, this did pass BAT and IGT despite the CI reply in
this thread [3].
[2] https://gitlab.freedesktop.org/drm/intel/-/issues/8013
[3] https://patchwork.freedesktop.org/series/113568/
>
>
>> ---
>> drivers/gpu/drm/i915/display/intel_quirks.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c
>> index 6e48d3bcdfec..a280448df771 100644
>> --- a/drivers/gpu/drm/i915/display/intel_quirks.c
>> +++ b/drivers/gpu/drm/i915/display/intel_quirks.c
>> @@ -199,6 +199,8 @@ static struct intel_quirk intel_quirks[] = {
>> /* ECS Liva Q2 */
>> { 0x3185, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
>> { 0x3184, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
>> + /* HP Notebook - 14-r206nv */
>> + { 0x0f31, 0x103c, 0x220f, quirk_invert_brightness },
>> };
>>
>> void intel_init_quirks(struct drm_i915_private *i915)
>> --
>> 2.34.1
>>
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-16 16:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-01 18:51 [Intel-gfx] [PATCH] drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv Mavroudis Chatzilaridis
2023-02-01 19:18 ` Jani Nikula
2023-02-16 16:52 ` Jani Nikula
2023-02-01 19:44 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).