* [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock
@ 2023-03-30 12:11 Swati Sharma
2023-03-30 12:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2) Patchwork
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: Swati Sharma @ 2023-03-30 12:11 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, David E. Box
From: "David E. Box" <david.e.box@linux.intel.com>
The VMD driver calls pci_enabled_link_state as a callback from
pci_bus_walk. Both will acquire the pci_bus_sem lock leading to a lockdep
warning. Add an argument to pci_enable_link_state to set whether the lock
should be acquired. In the VMD driver, set the argument to false since the
lock will already be obtained by pci_bus_walk.
Still, review comments needs to be addressed. However, this fix
is helping to unblock CI execution for now.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/8316
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: de82f60f9c86 ("PCI/ASPM: Add pci_enable_link_state()")
Link: https://lore.kernel.org/linux-pci/ZBjko%2FifunIwsK2v@intel.com/
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
drivers/pci/controller/vmd.c | 2 +-
drivers/pci/pcie/aspm.c | 9 ++++++---
include/linux/pci.h | 5 +++--
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 990630ec57c6..45aa35744eae 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -737,7 +737,7 @@ static int vmd_pm_enable_quirk(struct pci_dev *pdev, void *userdata)
if (!(features & VMD_FEAT_BIOS_PM_QUIRK))
return 0;
- pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL);
+ pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL, false);
pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_LTR);
if (!pos)
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index 66d7514ca111..5b5a600bb864 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -1147,8 +1147,9 @@ EXPORT_SYMBOL(pci_disable_link_state);
*
* @pdev: PCI device
* @state: Mask of ASPM link states to enable
+ * @sem: Boolean to acquire/release pci_bus_sem
*/
-int pci_enable_link_state(struct pci_dev *pdev, int state)
+int pci_enable_link_state(struct pci_dev *pdev, int state, bool sem)
{
struct pcie_link_state *link = pcie_aspm_get_link(pdev);
@@ -1165,7 +1166,8 @@ int pci_enable_link_state(struct pci_dev *pdev, int state)
return -EPERM;
}
- down_read(&pci_bus_sem);
+ if (sem)
+ down_read(&pci_bus_sem);
mutex_lock(&aspm_lock);
link->aspm_default = 0;
if (state & PCIE_LINK_STATE_L0S)
@@ -1186,7 +1188,8 @@ int pci_enable_link_state(struct pci_dev *pdev, int state)
link->clkpm_default = (state & PCIE_LINK_STATE_CLKPM) ? 1 : 0;
pcie_set_clkpm(link, policy_to_clkpm_state(link));
mutex_unlock(&aspm_lock);
- up_read(&pci_bus_sem);
+ if (sem)
+ up_read(&pci_bus_sem);
return 0;
}
diff --git a/include/linux/pci.h b/include/linux/pci.h
index b50e5c79f7e3..1fe4557e87b9 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1708,7 +1708,7 @@ extern bool pcie_ports_native;
#ifdef CONFIG_PCIEASPM
int pci_disable_link_state(struct pci_dev *pdev, int state);
int pci_disable_link_state_locked(struct pci_dev *pdev, int state);
-int pci_enable_link_state(struct pci_dev *pdev, int state);
+int pci_enable_link_state(struct pci_dev *pdev, int state, bool sem);
void pcie_no_aspm(void);
bool pcie_aspm_support_enabled(void);
bool pcie_aspm_enabled(struct pci_dev *pdev);
@@ -1717,7 +1717,8 @@ static inline int pci_disable_link_state(struct pci_dev *pdev, int state)
{ return 0; }
static inline int pci_disable_link_state_locked(struct pci_dev *pdev, int state)
{ return 0; }
-static inline int pci_enable_link_state(struct pci_dev *pdev, int state)
+static inline int
+pci_enable_link_state(struct pci_dev *pdev, int state, bool sem)
{ return 0; }
static inline void pcie_no_aspm(void) { }
static inline bool pcie_aspm_support_enabled(void) { return false; }
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2)
2023-03-30 12:11 [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Swati Sharma
@ 2023-03-30 12:53 ` Patchwork
2023-03-30 12:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-03-30 12:53 UTC (permalink / raw)
To: David E. Box; +Cc: intel-gfx
== Series Details ==
Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2)
URL : https://patchwork.freedesktop.org/series/115466/
State : warning
== Summary ==
Error: dim checkpatch failed
d7993ebfc2b0 PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock
-:19: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' instead
#19:
References: https://gitlab.freedesktop.org/drm/intel/-/issues/8316
-:20: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Link: with a URL to the report
#20:
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: de82f60f9c86 ("PCI/ASPM: Add pci_enable_link_state()")
total: 0 errors, 2 warnings, 0 checks, 53 lines checked
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2)
2023-03-30 12:11 [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Swati Sharma
2023-03-30 12:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2) Patchwork
@ 2023-03-30 12:53 ` Patchwork
2023-03-30 13:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-03-30 12:53 UTC (permalink / raw)
To: David E. Box; +Cc: intel-gfx
== Series Details ==
Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2)
URL : https://patchwork.freedesktop.org/series/115466/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2)
2023-03-30 12:11 [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Swati Sharma
2023-03-30 12:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2) Patchwork
2023-03-30 12:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2023-03-30 13:10 ` Patchwork
2023-03-30 14:42 ` [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Rodrigo Vivi
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-03-30 13:10 UTC (permalink / raw)
To: David E. Box; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10726 bytes --]
== Series Details ==
Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2)
URL : https://patchwork.freedesktop.org/series/115466/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12939 -> Patchwork_115466v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_115466v2 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_115466v2, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/index.html
Participating hosts (37 -> 37)
------------------------------
Additional (1): bat-rpls-2
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_115466v2:
### IGT changes ###
#### Possible regressions ####
* igt@dmabuf@all-tests@dma_fence:
- bat-dg2-11: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12939/bat-dg2-11/igt@dmabuf@all-tests@dma_fence.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-dg2-11/igt@dmabuf@all-tests@dma_fence.html
* igt@dmabuf@all-tests@sanitycheck:
- bat-dg2-11: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12939/bat-dg2-11/igt@dmabuf@all-tests@sanitycheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-dg2-11/igt@dmabuf@all-tests@sanitycheck.html
Known issues
------------
Here are the changes found in Patchwork_115466v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-rpls-2: NOTRUN -> [SKIP][5] ([i915#7456])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@debugfs_test@basic-hwmon.html
- bat-adlp-6: NOTRUN -> [SKIP][6] ([i915#7456])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-adlp-6/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@read:
- bat-rpls-2: NOTRUN -> [SKIP][7] ([i915#2582]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@fbdev@read.html
* igt@gem_lmem_swapping@random-engines:
- bat-adlp-6: NOTRUN -> [SKIP][8] ([i915#4613]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-adlp-6/igt@gem_lmem_swapping@random-engines.html
* igt@gem_lmem_swapping@verify-random:
- bat-rpls-2: NOTRUN -> [SKIP][9] ([i915#4613]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@gem_lmem_swapping@verify-random.html
* igt@gem_tiled_pread_basic:
- bat-adlp-6: NOTRUN -> [SKIP][10] ([i915#3282])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-adlp-6/igt@gem_tiled_pread_basic.html
- bat-rpls-2: NOTRUN -> [SKIP][11] ([i915#3282])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-rpls-2: NOTRUN -> [SKIP][12] ([i915#7561])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@workarounds:
- bat-dg1-7: [PASS][13] -> [ABORT][14] ([i915#4983])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12939/bat-dg1-7/igt@i915_selftest@live@workarounds.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-dg1-7/igt@i915_selftest@live@workarounds.html
- bat-rpls-2: NOTRUN -> [INCOMPLETE][15] ([i915#7913])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@i915_selftest@live@workarounds.html
* igt@kms_busy@basic:
- bat-rpls-2: NOTRUN -> [SKIP][16] ([i915#1845]) +14 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@kms_busy@basic.html
* igt@kms_chamelium_edid@hdmi-edid-read:
- bat-rpls-2: NOTRUN -> [SKIP][17] ([i915#7828]) +7 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@kms_chamelium_edid@hdmi-edid-read.html
* igt@kms_chamelium_hpd@dp-hpd-fast:
- bat-adlp-6: NOTRUN -> [SKIP][18] ([i915#7828]) +8 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-adlp-6/igt@kms_chamelium_hpd@dp-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-6: NOTRUN -> [SKIP][19] ([i915#4103]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-adlp-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_flip@basic-flip-vs-dpms:
- bat-rpls-2: NOTRUN -> [SKIP][20] ([i915#3637]) +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-rpls-2: NOTRUN -> [SKIP][21] ([fdo#109285])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@kms_force_connector_basic@force-load-detect.html
- bat-adlp-6: NOTRUN -> [SKIP][22] ([fdo#109285])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-adlp-6/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- bat-rpls-2: NOTRUN -> [SKIP][23] ([i915#1849])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rpls-2: NOTRUN -> [SKIP][24] ([i915#1072]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-adlp-6: NOTRUN -> [SKIP][25] ([i915#3555] / [i915#4579])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-adlp-6/igt@kms_setmode@basic-clone-single-crtc.html
- bat-rpls-2: NOTRUN -> [SKIP][26] ([i915#3555])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-rpls-2: NOTRUN -> [SKIP][27] ([fdo#109295] / [i915#1845] / [i915#3708])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-read:
- bat-rpls-2: NOTRUN -> [SKIP][28] ([fdo#109295] / [i915#3708]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rpls-2/igt@prime_vgem@basic-fence-read.html
- bat-adlp-6: NOTRUN -> [SKIP][29] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-adlp-6/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-userptr:
- bat-adlp-6: NOTRUN -> [SKIP][30] ([fdo#109295] / [i915#3301] / [i915#3708])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-adlp-6/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][31] ([i915#5334]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12939/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@requests:
- fi-kbl-soraka: [ABORT][33] ([i915#7913]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12939/fi-kbl-soraka/igt@i915_selftest@live@requests.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/fi-kbl-soraka/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-rplp-1: [DMESG-FAIL][35] ([i915#6367] / [i915#7913]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12939/bat-rplp-1/igt@i915_selftest@live@slpc.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/bat-rplp-1/igt@i915_selftest@live@slpc.html
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
Build changes
-------------
* Linux: CI_DRM_12939 -> Patchwork_115466v2
CI-20190529: 20190529
CI_DRM_12939: 67f2a2f9902dad389232eee48db7073d66011582 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7227: 5dfa3675c36bab82cdda056db7ef622363c324ee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115466v2: 67f2a2f9902dad389232eee48db7073d66011582 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
089e7cf4b87e PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v2/index.html
[-- Attachment #2: Type: text/html, Size: 13080 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock
2023-03-30 12:11 [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Swati Sharma
` (2 preceding siblings ...)
2023-03-30 13:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2023-03-30 14:42 ` Rodrigo Vivi
2023-03-30 15:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3) Patchwork
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Rodrigo Vivi @ 2023-03-30 14:42 UTC (permalink / raw)
To: Swati Sharma; +Cc: jani.nikula, intel-gfx, David E. Box
On Thu, Mar 30, 2023 at 05:41:35PM +0530, Swati Sharma wrote:
> From: "David E. Box" <david.e.box@linux.intel.com>
>
> The VMD driver calls pci_enabled_link_state as a callback from
> pci_bus_walk. Both will acquire the pci_bus_sem lock leading to a lockdep
> warning. Add an argument to pci_enable_link_state to set whether the lock
> should be acquired. In the VMD driver, set the argument to false since the
> lock will already be obtained by pci_bus_walk.
>
> Still, review comments needs to be addressed. However, this fix
> is helping to unblock CI execution for now.
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/8316
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Fixes: de82f60f9c86 ("PCI/ASPM: Add pci_enable_link_state()")
> Link: https://lore.kernel.org/linux-pci/ZBjko%2FifunIwsK2v@intel.com/
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
to get this into topic/core-for-CI
> ---
> drivers/pci/controller/vmd.c | 2 +-
> drivers/pci/pcie/aspm.c | 9 ++++++---
> include/linux/pci.h | 5 +++--
> 3 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index 990630ec57c6..45aa35744eae 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -737,7 +737,7 @@ static int vmd_pm_enable_quirk(struct pci_dev *pdev, void *userdata)
> if (!(features & VMD_FEAT_BIOS_PM_QUIRK))
> return 0;
>
> - pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL);
> + pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL, false);
>
> pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_LTR);
> if (!pos)
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index 66d7514ca111..5b5a600bb864 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -1147,8 +1147,9 @@ EXPORT_SYMBOL(pci_disable_link_state);
> *
> * @pdev: PCI device
> * @state: Mask of ASPM link states to enable
> + * @sem: Boolean to acquire/release pci_bus_sem
> */
> -int pci_enable_link_state(struct pci_dev *pdev, int state)
> +int pci_enable_link_state(struct pci_dev *pdev, int state, bool sem)
> {
> struct pcie_link_state *link = pcie_aspm_get_link(pdev);
>
> @@ -1165,7 +1166,8 @@ int pci_enable_link_state(struct pci_dev *pdev, int state)
> return -EPERM;
> }
>
> - down_read(&pci_bus_sem);
> + if (sem)
> + down_read(&pci_bus_sem);
> mutex_lock(&aspm_lock);
> link->aspm_default = 0;
> if (state & PCIE_LINK_STATE_L0S)
> @@ -1186,7 +1188,8 @@ int pci_enable_link_state(struct pci_dev *pdev, int state)
> link->clkpm_default = (state & PCIE_LINK_STATE_CLKPM) ? 1 : 0;
> pcie_set_clkpm(link, policy_to_clkpm_state(link));
> mutex_unlock(&aspm_lock);
> - up_read(&pci_bus_sem);
> + if (sem)
> + up_read(&pci_bus_sem);
>
> return 0;
> }
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index b50e5c79f7e3..1fe4557e87b9 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1708,7 +1708,7 @@ extern bool pcie_ports_native;
> #ifdef CONFIG_PCIEASPM
> int pci_disable_link_state(struct pci_dev *pdev, int state);
> int pci_disable_link_state_locked(struct pci_dev *pdev, int state);
> -int pci_enable_link_state(struct pci_dev *pdev, int state);
> +int pci_enable_link_state(struct pci_dev *pdev, int state, bool sem);
> void pcie_no_aspm(void);
> bool pcie_aspm_support_enabled(void);
> bool pcie_aspm_enabled(struct pci_dev *pdev);
> @@ -1717,7 +1717,8 @@ static inline int pci_disable_link_state(struct pci_dev *pdev, int state)
> { return 0; }
> static inline int pci_disable_link_state_locked(struct pci_dev *pdev, int state)
> { return 0; }
> -static inline int pci_enable_link_state(struct pci_dev *pdev, int state)
> +static inline int
> +pci_enable_link_state(struct pci_dev *pdev, int state, bool sem)
> { return 0; }
> static inline void pcie_no_aspm(void) { }
> static inline bool pcie_aspm_support_enabled(void) { return false; }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)
2023-03-30 12:11 [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Swati Sharma
` (3 preceding siblings ...)
2023-03-30 14:42 ` [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Rodrigo Vivi
@ 2023-03-30 15:57 ` Patchwork
2023-03-30 15:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-03-30 15:57 UTC (permalink / raw)
To: David E. Box; +Cc: intel-gfx
== Series Details ==
Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)
URL : https://patchwork.freedesktop.org/series/115466/
State : warning
== Summary ==
Error: dim checkpatch failed
ca06d5b4038a PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock
-:19: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' instead
#19:
References: https://gitlab.freedesktop.org/drm/intel/-/issues/8316
-:20: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Link: with a URL to the report
#20:
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: de82f60f9c86 ("PCI/ASPM: Add pci_enable_link_state()")
total: 0 errors, 2 warnings, 0 checks, 53 lines checked
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)
2023-03-30 12:11 [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Swati Sharma
` (4 preceding siblings ...)
2023-03-30 15:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3) Patchwork
@ 2023-03-30 15:57 ` Patchwork
2023-03-30 16:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-31 11:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
7 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-03-30 15:57 UTC (permalink / raw)
To: David E. Box; +Cc: intel-gfx
== Series Details ==
Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)
URL : https://patchwork.freedesktop.org/series/115466/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)
2023-03-30 12:11 [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Swati Sharma
` (5 preceding siblings ...)
2023-03-30 15:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2023-03-30 16:07 ` Patchwork
2023-03-31 11:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
7 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-03-30 16:07 UTC (permalink / raw)
To: David E. Box; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6828 bytes --]
== Series Details ==
Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)
URL : https://patchwork.freedesktop.org/series/115466/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12940 -> Patchwork_115466v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/index.html
Participating hosts (37 -> 35)
------------------------------
Missing (2): fi-snb-2520m fi-pnv-d510
Known issues
------------
Here are the changes found in Patchwork_115466v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-adlp-6: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-adlp-6/igt@debugfs_test@basic-hwmon.html
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: NOTRUN -> [ABORT][2] ([i915#6687] / [i915#7978])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_lmem_swapping@random-engines:
- bat-adlp-6: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-adlp-6/igt@gem_lmem_swapping@random-engines.html
* igt@gem_tiled_pread_basic:
- bat-adlp-6: NOTRUN -> [SKIP][4] ([i915#3282])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-adlp-6/igt@gem_tiled_pread_basic.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [PASS][5] -> [ABORT][6] ([i915#4983] / [i915#7913])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/bat-rpls-2/igt@i915_selftest@live@reset.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@kms_chamelium_hpd@dp-hpd-fast:
- bat-adlp-6: NOTRUN -> [SKIP][7] ([i915#7828]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-adlp-6/igt@kms_chamelium_hpd@dp-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-6: NOTRUN -> [SKIP][8] ([i915#4103]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-adlp-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-adlp-6: NOTRUN -> [SKIP][9] ([fdo#109285])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-adlp-6/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1:
- bat-dg2-8: [PASS][10] -> [FAIL][11] ([i915#7932])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-adlp-6: NOTRUN -> [SKIP][12] ([i915#3555] / [i915#4579])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-adlp-6/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-read:
- bat-adlp-6: NOTRUN -> [SKIP][13] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-adlp-6/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-userptr:
- bat-adlp-6: NOTRUN -> [SKIP][14] ([fdo#109295] / [i915#3301] / [i915#3708])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-adlp-6/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- bat-dg2-8: [DMESG-FAIL][15] ([i915#6998] / [i915#7913]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/bat-dg2-8/igt@i915_selftest@live@hangcheck.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-dg2-8/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][17] ([i915#4983]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/bat-rpls-1/igt@i915_selftest@live@reset.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- bat-dg2-11: [DMESG-WARN][19] ([i915#7996]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/bat-dg2-11/igt@i915_selftest@live@slpc.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/bat-dg2-11/igt@i915_selftest@live@slpc.html
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6998]: https://gitlab.freedesktop.org/drm/intel/issues/6998
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* Linux: CI_DRM_12940 -> Patchwork_115466v3
CI-20190529: 20190529
CI_DRM_12940: 0b6fef24310e1d6a4432aa98ce5d700df6a94947 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7229: 4acf68be01b4fa60a3041e1571681f1474ac0548 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115466v3: 0b6fef24310e1d6a4432aa98ce5d700df6a94947 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
819e6b7b90c0 PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/index.html
[-- Attachment #2: Type: text/html, Size: 8057 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)
2023-03-30 12:11 [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Swati Sharma
` (6 preceding siblings ...)
2023-03-30 16:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-03-31 11:55 ` Patchwork
7 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-03-31 11:55 UTC (permalink / raw)
To: David E. Box; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11510 bytes --]
== Series Details ==
Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)
URL : https://patchwork.freedesktop.org/series/115466/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12940_full -> Patchwork_115466v3_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_115466v3_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-glk4/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][4] ([i915#3318])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-apl2/igt@gem_userptr_blits@vma-merge.html
* igt@i915_pm_rpm@modeset-lpsp:
- shard-apl: NOTRUN -> [SKIP][5] ([fdo#109271]) +18 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-apl2/igt@i915_pm_rpm@modeset-lpsp.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#3886]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-apl2/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_content_protection@uevent@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][7] ([i915#1339])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-apl2/igt@kms_content_protection@uevent@pipe-a-dp-1.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#72])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/shard-glk6/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-glk8/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_selftest@all-tests:
- shard-snb: NOTRUN -> [SKIP][10] ([fdo#109271]) +11 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-snb4/igt@kms_selftest@all-tests.html
* igt@kms_writeback@writeback-check-output:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#2437])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-glk4/igt@kms_writeback@writeback-check-output.html
* igt@v3d/v3d_perfmon@create-perfmon-invalid-counters:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271]) +7 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-glk4/igt@v3d/v3d_perfmon@create-perfmon-invalid-counters.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][13] ([i915#2846]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/shard-glk1/igt@gem_exec_fair@basic-deadline.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-glk9/igt@gem_exec_fair@basic-deadline.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [ABORT][15] ([i915#5566]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/shard-apl3/igt@gen9_exec_parse@allowed-single.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-apl2/igt@gen9_exec_parse@allowed-single.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-vga1:
- shard-snb: [ABORT][17] -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/shard-snb2/igt@kms_flip@flip-vs-suspend-interruptible@b-vga1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-snb4/igt@kms_flip@flip-vs-suspend-interruptible@b-vga1.html
* igt@kms_flip@plain-flip-ts-check@a-hdmi-a2:
- shard-glk: [FAIL][19] ([i915#2122]) -> [PASS][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/shard-glk2/igt@kms_flip@plain-flip-ts-check@a-hdmi-a2.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-glk3/igt@kms_flip@plain-flip-ts-check@a-hdmi-a2.html
* {igt@perf@stress-open-close@0-rcs0}:
- shard-glk: [ABORT][21] ([i915#5213]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/shard-glk5/igt@perf@stress-open-close@0-rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-glk4/igt@perf@stress-open-close@0-rcs0.html
* igt@perf_pmu@idle@rcs0:
- {shard-dg1}: [FAIL][23] ([i915#4349]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12940/shard-dg1-16/igt@perf_pmu@idle@rcs0.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/shard-dg1-15/igt@perf_pmu@idle@rcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1339]: https://gitlab.freedesktop.org/drm/intel/issues/1339
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
Build changes
-------------
* Linux: CI_DRM_12940 -> Patchwork_115466v3
CI-20190529: 20190529
CI_DRM_12940: 0b6fef24310e1d6a4432aa98ce5d700df6a94947 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7229: 4acf68be01b4fa60a3041e1571681f1474ac0548 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115466v3: 0b6fef24310e1d6a4432aa98ce5d700df6a94947 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115466v3/index.html
[-- Attachment #2: Type: text/html, Size: 8430 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-03-31 11:55 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-30 12:11 [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Swati Sharma
2023-03-30 12:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2) Patchwork
2023-03-30 12:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-30 13:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-03-30 14:42 ` [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock Rodrigo Vivi
2023-03-30 15:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3) Patchwork
2023-03-30 15:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-30 16:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-31 11:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).