* [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends
@ 2023-03-31 20:02 Umesh Nerlige Ramappa
2023-03-31 21:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2) Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Umesh Nerlige Ramappa @ 2023-03-31 20:02 UTC (permalink / raw)
To: intel-gfx
The underlying mechanism used to provide the client specific utilization
in fdinfo is context busyness. When a context switches out, the HW
records the runtime in the specific context field. This information is
accumulated in fdinfo. This information is independent of the scheduling
backend as long as contexts are switching out in reasonable time.
If a context is actively running on the engine, then the active busyness
is calculated by using the delta between current time and the context
switch in time. This part of the calculation depends on the scheduling
backend. For GuC backends, this data comes entirely from GuC FW. The FW
implementation is WIP.
Enable fdinfo for GuC based platforms with the exception that long
running contexts will not provide reliable busyness data unless they
switch out at some reasonable point in time.
Revert "drm/i915: Don't show engine information in fdinfo with GuC submission"
This reverts commit 8d0e3decf26bc423d8b1c42c05636ccc05ea6b17.
Resolves: https://gitlab.freedesktop.org/drm/intel/issues/8303
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Test-with: 20230331195915.5839-1-umesh.nerlige.ramappa@intel.com
---
drivers/gpu/drm/i915/i915_drm_client.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c
index e8fa172ebe5e..d18d0a3ed905 100644
--- a/drivers/gpu/drm/i915/i915_drm_client.c
+++ b/drivers/gpu/drm/i915/i915_drm_client.c
@@ -147,11 +147,7 @@ void i915_drm_client_fdinfo(struct seq_file *m, struct file *f)
PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn));
seq_printf(m, "drm-client-id:\t%u\n", client->id);
- /*
- * Temporarily skip showing client engine information with GuC submission till
- * fetching engine busyness is implemented in the GuC submission backend
- */
- if (GRAPHICS_VER(i915) < 8 || intel_uc_uses_guc_submission(&i915->gt0.uc))
+ if (GRAPHICS_VER(i915) < 8)
return;
for (i = 0; i < ARRAY_SIZE(uabi_class_names); i++)
--
2.36.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2)
2023-03-31 20:02 [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends Umesh Nerlige Ramappa
@ 2023-03-31 21:32 ` Patchwork
2023-03-31 21:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-03-31 21:32 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2)
URL : https://patchwork.freedesktop.org/series/115958/
State : warning
== Summary ==
Error: dim checkpatch failed
5e2ea7ebd7e8 drm/i915/fdinfo: Enable fdinfo for GuC backends
-:22: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#22:
Revert "drm/i915: Don't show engine information in fdinfo with GuC submission"
-:25: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'Resolves:', use 'Link:' instead
#25:
Resolves: https://gitlab.freedesktop.org/drm/intel/issues/8303
total: 0 errors, 2 warnings, 0 checks, 12 lines checked
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2)
2023-03-31 20:02 [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends Umesh Nerlige Ramappa
2023-03-31 21:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2) Patchwork
@ 2023-03-31 21:45 ` Patchwork
2023-04-01 22:11 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-04-03 10:21 ` [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends Tvrtko Ursulin
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-03-31 21:45 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3684 bytes --]
== Series Details ==
Series: drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2)
URL : https://patchwork.freedesktop.org/series/115958/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12952 -> Patchwork_115958v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/index.html
Participating hosts (38 -> 37)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_115958v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][1] -> [DMESG-WARN][2] ([i915#7699])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/bat-dg2-11/igt@i915_selftest@live@migrate.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][3] -> [ABORT][4] ([i915#4983])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/bat-rpls-1/igt@i915_selftest@live@reset.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-1:
- bat-dg2-8: [PASS][5] -> [FAIL][6] ([i915#6703])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/bat-dg2-8/igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/bat-dg2-8/igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-1.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][7] ([i915#5334]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
#### Warnings ####
* igt@i915_selftest@live@slpc:
- bat-rpls-2: [DMESG-FAIL][9] ([i915#6367] / [i915#7913] / [i915#7996]) -> [DMESG-FAIL][10] ([i915#6367] / [i915#7913])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/bat-rpls-2/igt@i915_selftest@live@slpc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/bat-rpls-2/igt@i915_selftest@live@slpc.html
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6703]: https://gitlab.freedesktop.org/drm/intel/issues/6703
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* IGT: IGT_7231 -> IGTPW_8732
* Linux: CI_DRM_12952 -> Patchwork_115958v2
CI-20190529: 20190529
CI_DRM_12952: 51cf6fb5e846c1adbe92debb7282d0dcc3934ecb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8732: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8732/index.html
IGT_7231: 94188a1dc91b6ef1cf3e9df1440ff00b6ff25935 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115958v2: 51cf6fb5e846c1adbe92debb7282d0dcc3934ecb @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
f23abbaed36a drm/i915/fdinfo: Enable fdinfo for GuC backends
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/index.html
[-- Attachment #2: Type: text/html, Size: 4534 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2)
2023-03-31 20:02 [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends Umesh Nerlige Ramappa
2023-03-31 21:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2) Patchwork
2023-03-31 21:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-04-01 22:11 ` Patchwork
2023-04-03 10:21 ` [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends Tvrtko Ursulin
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-04-01 22:11 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 14410 bytes --]
== Series Details ==
Series: drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2)
URL : https://patchwork.freedesktop.org/series/115958/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12952_full -> Patchwork_115958v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 8)
------------------------------
Additional (1): shard-tglu0
Known issues
------------
Here are the changes found in Patchwork_115958v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2846])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-glk6/igt@gem_exec_fair@basic-deadline.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-glk2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][5] -> [ABORT][6] ([i915#180])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-apl3/igt@gem_softpin@noreloc-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-apl7/igt@gem_softpin@noreloc-s3.html
* igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-snb4/igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][8] -> [FAIL][9] ([i915#2346]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#79])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-glk3/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-dg1}: [SKIP][12] ([i915#5563]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-dg1-17/igt@drm_fdinfo@virtual-idle.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-dg1-17/igt@drm_fdinfo@virtual-idle.html
* igt@gem_eio@in-flight-contexts-1us:
- {shard-tglu}: [TIMEOUT][14] ([i915#3063]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-tglu-9/igt@gem_eio@in-flight-contexts-1us.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-tglu-9/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][16] ([i915#2842]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-tglu-6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-tglu-3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][18] ([i915#2842]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-apl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][20] ([fdo#109271]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-apl4/igt@i915_pm_dc@dc9-dpms.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-glk: [DMESG-FAIL][22] ([i915#5334]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-glk9/igt@i915_selftest@live@gt_heartbeat.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-glk7/igt@i915_selftest@live@gt_heartbeat.html
- shard-apl: [DMESG-FAIL][24] ([i915#5334]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-apl6/igt@i915_selftest@live@gt_heartbeat.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-apl6/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][26] ([i915#2346]) -> [PASS][27] +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [FAIL][28] ([i915#79]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
* igt@perf_pmu@idle@rcs0:
- {shard-dg1}: [FAIL][30] ([i915#4349]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-dg1-14/igt@perf_pmu@idle@rcs0.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-dg1-15/igt@perf_pmu@idle@rcs0.html
* igt@perf_pmu@module-unload:
- shard-snb: [ABORT][32] ([i915#4528]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-snb2/igt@perf_pmu@module-unload.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/shard-snb2/igt@perf_pmu@module-unload.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8150]: https://gitlab.freedesktop.org/drm/intel/issues/8150
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308
Build changes
-------------
* IGT: IGT_7231 -> IGTPW_8732
* Linux: CI_DRM_12952 -> Patchwork_115958v2
CI-20190529: 20190529
CI_DRM_12952: 51cf6fb5e846c1adbe92debb7282d0dcc3934ecb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8732: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8732/index.html
IGT_7231: 94188a1dc91b6ef1cf3e9df1440ff00b6ff25935 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115958v2: 51cf6fb5e846c1adbe92debb7282d0dcc3934ecb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115958v2/index.html
[-- Attachment #2: Type: text/html, Size: 9603 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends
2023-03-31 20:02 [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends Umesh Nerlige Ramappa
` (2 preceding siblings ...)
2023-04-01 22:11 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-04-03 10:21 ` Tvrtko Ursulin
2023-04-03 20:10 ` Umesh Nerlige Ramappa
3 siblings, 1 reply; 6+ messages in thread
From: Tvrtko Ursulin @ 2023-04-03 10:21 UTC (permalink / raw)
To: Umesh Nerlige Ramappa, intel-gfx
On 31/03/2023 21:02, Umesh Nerlige Ramappa wrote:
> The underlying mechanism used to provide the client specific utilization
> in fdinfo is context busyness. When a context switches out, the HW
> records the runtime in the specific context field. This information is
> accumulated in fdinfo. This information is independent of the scheduling
> backend as long as contexts are switching out in reasonable time.
>
> If a context is actively running on the engine, then the active busyness
> is calculated by using the delta between current time and the context
> switch in time. This part of the calculation depends on the scheduling
> backend. For GuC backends, this data comes entirely from GuC FW. The FW
> implementation is WIP.
>
> Enable fdinfo for GuC based platforms with the exception that long
> running contexts will not provide reliable busyness data unless they
> switch out at some reasonable point in time.
>
> Revert "drm/i915: Don't show engine information in fdinfo with GuC submission"
> This reverts commit 8d0e3decf26bc423d8b1c42c05636ccc05ea6b17.
>
> Resolves: https://gitlab.freedesktop.org/drm/intel/issues/8303
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Test-with: 20230331195915.5839-1-umesh.nerlige.ramappa@intel.com
> ---
> drivers/gpu/drm/i915/i915_drm_client.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c
> index e8fa172ebe5e..d18d0a3ed905 100644
> --- a/drivers/gpu/drm/i915/i915_drm_client.c
> +++ b/drivers/gpu/drm/i915/i915_drm_client.c
> @@ -147,11 +147,7 @@ void i915_drm_client_fdinfo(struct seq_file *m, struct file *f)
> PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn));
> seq_printf(m, "drm-client-id:\t%u\n", client->id);
>
> - /*
> - * Temporarily skip showing client engine information with GuC submission till
> - * fetching engine busyness is implemented in the GuC submission backend
> - */
> - if (GRAPHICS_VER(i915) < 8 || intel_uc_uses_guc_submission(&i915->gt0.uc))
> + if (GRAPHICS_VER(i915) < 8)
> return;
>
> for (i = 0; i < ARRAY_SIZE(uabi_class_names); i++)
Ack in principle but we have to figure out why Kurt reports this doesn't
work - usage always zero with real workloads.
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends
2023-04-03 10:21 ` [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends Tvrtko Ursulin
@ 2023-04-03 20:10 ` Umesh Nerlige Ramappa
0 siblings, 0 replies; 6+ messages in thread
From: Umesh Nerlige Ramappa @ 2023-04-03 20:10 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
On Mon, Apr 03, 2023 at 11:21:51AM +0100, Tvrtko Ursulin wrote:
>
>On 31/03/2023 21:02, Umesh Nerlige Ramappa wrote:
>>The underlying mechanism used to provide the client specific utilization
>>in fdinfo is context busyness. When a context switches out, the HW
>>records the runtime in the specific context field. This information is
>>accumulated in fdinfo. This information is independent of the scheduling
>>backend as long as contexts are switching out in reasonable time.
>>
>>If a context is actively running on the engine, then the active busyness
>>is calculated by using the delta between current time and the context
>>switch in time. This part of the calculation depends on the scheduling
>>backend. For GuC backends, this data comes entirely from GuC FW. The FW
>>implementation is WIP.
>>
>>Enable fdinfo for GuC based platforms with the exception that long
>>running contexts will not provide reliable busyness data unless they
>>switch out at some reasonable point in time.
>>
>>Revert "drm/i915: Don't show engine information in fdinfo with GuC submission"
>>This reverts commit 8d0e3decf26bc423d8b1c42c05636ccc05ea6b17.
>>
>>Resolves: https://gitlab.freedesktop.org/drm/intel/issues/8303
>>Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>>Test-with: 20230331195915.5839-1-umesh.nerlige.ramappa@intel.com
>>---
>> drivers/gpu/drm/i915/i915_drm_client.c | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>>diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c
>>index e8fa172ebe5e..d18d0a3ed905 100644
>>--- a/drivers/gpu/drm/i915/i915_drm_client.c
>>+++ b/drivers/gpu/drm/i915/i915_drm_client.c
>>@@ -147,11 +147,7 @@ void i915_drm_client_fdinfo(struct seq_file *m, struct file *f)
>> PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn));
>> seq_printf(m, "drm-client-id:\t%u\n", client->id);
>>- /*
>>- * Temporarily skip showing client engine information with GuC submission till
>>- * fetching engine busyness is implemented in the GuC submission backend
>>- */
>>- if (GRAPHICS_VER(i915) < 8 || intel_uc_uses_guc_submission(&i915->gt0.uc))
>>+ if (GRAPHICS_VER(i915) < 8)
>> return;
>> for (i = 0; i < ARRAY_SIZE(uabi_class_names); i++)
>
>Ack in principle but we have to figure out why Kurt reports this
>doesn't work - usage always zero with real workloads.
Hmm, looks like this might need some more changes that I initially
thought. The changes may need to be extracted from this -
https://patchwork.freedesktop.org/patch/496441/
lrc_update_runtime (which updates the stats by peeking into the hw
context), is only called when the context is about to be unpinned. The
issue is that the GuC context is not unpinned until the context
scheduling is disabled. Disabling the context scheduling is asynchronous
and does not align with context switch out. Also if requests are
scheduled frequently to the context, then the context scheduling is
never disabled.
In the patch linked above, I am calling lrc_update_runtime whenever the
update_stats hook is called (in case of intel_gpu_top, it's every
second) and when context is inactive. This resolves the issue, but I
need to check with Ashutosh/John if we can do that for this specific
case because the way we check that the context is active is dependent on
the WIP feature of GuC.. sigh...
Regards,
Umesh
>
>Regards,
>
>Tvrtko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-03 20:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-31 20:02 [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends Umesh Nerlige Ramappa
2023-03-31 21:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2) Patchwork
2023-03-31 21:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-04-01 22:11 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-04-03 10:21 ` [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends Tvrtko Ursulin
2023-04-03 20:10 ` Umesh Nerlige Ramappa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).