* [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST
@ 2023-04-04 9:05 Jani Nikula
2023-04-04 12:22 ` kernel test robot
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Jani Nikula @ 2023-04-04 9:05 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Rodrigo Vivi
Enabling kernel-doc warnings in commit aaee4bbe8a1a ("drm/i915: enable
kernel-doc warnings for CONFIG_DRM_I915_WERROR=y") actually only covers
the .c files. And it's good for avoiding warnings in W= builds. However,
we need something more to check for kernel-doc issues in headers. Add it
as part of the existing HDRTEST.
We have tons of issues, and this unleashes warnings galore on
CONFIG_DRM_I915_WERROR=y. It doesn't fail the build because (at least
for now) we don't pass -Werror to kernel-doc.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 831e42175165..b739300267c2 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -387,7 +387,8 @@ always-$(CONFIG_DRM_I915_WERROR) += \
$(shell cd $(srctree)/$(src) && find * -name '*.h')))
quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@)
- cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; touch $@
+ cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; \
+ $(srctree)/scripts/kernel-doc -none $<; touch $@
$(obj)/%.hdrtest: $(src)/%.h FORCE
$(call if_changed_dep,hdrtest)
--
2.39.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST
2023-04-04 9:05 [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST Jani Nikula
@ 2023-04-04 12:22 ` kernel test robot
2023-04-04 12:26 ` Jani Nikula
2023-04-04 13:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: kernel test robot @ 2023-04-04 12:22 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: jani.nikula, Rodrigo Vivi, oe-kbuild-all
Hi Jani,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-tip/drm-tip]
url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-run-kernel-doc-on-headers-as-part-of-HDRTEST/20230404-170637
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link: https://lore.kernel.org/r/20230404090528.173075-1-jani.nikula%40intel.com
patch subject: [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST
config: i386-defconfig (https://download.01.org/0day-ci/archive/20230404/202304042026.uZBs3cC2-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/336391cc647b2fbdf0ebd2eda8a10fb4509918b7
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jani-Nikula/drm-i915-run-kernel-doc-on-headers-as-part-of-HDRTEST/20230404-170637
git checkout 336391cc647b2fbdf0ebd2eda8a10fb4509918b7
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 olddefconfig
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304042026.uZBs3cC2-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'size' not described in '__guc_capture_bufstate'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'data' not described in '__guc_capture_bufstate'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'rd' not described in '__guc_capture_bufstate'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'wr' not described in '__guc_capture_bufstate'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'link' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'is_partial' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'eng_class' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'eng_inst' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'guc_id' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'lrca' not described in '__guc_capture_parsed_output'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'reginfo' not described in '__guc_capture_parsed_output'
>> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:62: warning: wrong kernel-doc identifier on line:
* struct guc_debug_capture_list_header / struct guc_debug_capture_list
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:80: warning: wrong kernel-doc identifier on line:
* struct __guc_mmio_reg_descr / struct __guc_mmio_reg_descr_group
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:105: warning: wrong kernel-doc identifier on line:
* struct guc_state_capture_header_t / struct guc_state_capture_t /
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'is_valid' not described in '__guc_capture_ads_cache'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'ptr' not described in '__guc_capture_ads_cache'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'size' not described in '__guc_capture_ads_cache'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'status' not described in '__guc_capture_ads_cache'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function parameter or member 'ads_null_cache' not described in 'intel_guc_state_capture'
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function parameter or member 'max_mmio_per_node' not described in 'intel_guc_state_capture'
--
drivers/gpu/drm/i915/i915_pmu.h:21: warning: cannot understand function prototype: 'enum i915_pmu_tracked_events '
drivers/gpu/drm/i915/i915_pmu.h:32: warning: cannot understand function prototype: 'enum '
>> drivers/gpu/drm/i915/i915_pmu.h:41: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* How many different events we track in the global PMU mask.
--
>> drivers/gpu/drm/i915/i915_request.h:176: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Request queue structure.
drivers/gpu/drm/i915/i915_request.h:477: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Returns true if seq1 is later than seq2.
--
>> drivers/gpu/drm/i915/i915_vma.h:145: warning: expecting prototype for i915_vma_offset(). Prototype was for i915_vma_size() instead
--
>> drivers/gpu/drm/i915/intel_wakeref.h:118: warning: expecting prototype for intel_wakeref_get_if_in_use(). Prototype was for intel_wakeref_get_if_active() instead
vim +62 drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h
24492514ccbd57 Alan Previn 2022-03-21 14
f5718a7265a6f5 Alan Previn 2022-03-21 15 /**
f5718a7265a6f5 Alan Previn 2022-03-21 16 * struct __guc_capture_bufstate
f5718a7265a6f5 Alan Previn 2022-03-21 17 *
f5718a7265a6f5 Alan Previn 2022-03-21 18 * Book-keeping structure used to track read and write pointers
f5718a7265a6f5 Alan Previn 2022-03-21 19 * as we extract error capture data from the GuC-log-buffer's
f5718a7265a6f5 Alan Previn 2022-03-21 20 * error-capture region as a stream of dwords.
f5718a7265a6f5 Alan Previn 2022-03-21 21 */
f5718a7265a6f5 Alan Previn 2022-03-21 22 struct __guc_capture_bufstate {
f5718a7265a6f5 Alan Previn 2022-03-21 23 u32 size;
f5718a7265a6f5 Alan Previn 2022-03-21 24 void *data;
f5718a7265a6f5 Alan Previn 2022-03-21 25 u32 rd;
f5718a7265a6f5 Alan Previn 2022-03-21 26 u32 wr;
f5718a7265a6f5 Alan Previn 2022-03-21 @27 };
f5718a7265a6f5 Alan Previn 2022-03-21 28
f5718a7265a6f5 Alan Previn 2022-03-21 29 /**
f5718a7265a6f5 Alan Previn 2022-03-21 30 * struct __guc_capture_parsed_output - extracted error capture node
f5718a7265a6f5 Alan Previn 2022-03-21 31 *
f5718a7265a6f5 Alan Previn 2022-03-21 32 * A single unit of extracted error-capture output data grouped together
f5718a7265a6f5 Alan Previn 2022-03-21 33 * at an engine-instance level. We keep these nodes in a linked list.
247f8071d58933 Alan Previn 2022-03-21 34 * See cachelist and outlist below.
f5718a7265a6f5 Alan Previn 2022-03-21 35 */
f5718a7265a6f5 Alan Previn 2022-03-21 36 struct __guc_capture_parsed_output {
f5718a7265a6f5 Alan Previn 2022-03-21 37 /*
f5718a7265a6f5 Alan Previn 2022-03-21 38 * A single set of 3 capture lists: a global-list
f5718a7265a6f5 Alan Previn 2022-03-21 39 * an engine-class-list and an engine-instance list.
f5718a7265a6f5 Alan Previn 2022-03-21 40 * outlist in __guc_capture_parsed_output will keep
f5718a7265a6f5 Alan Previn 2022-03-21 41 * a linked list of these nodes that will eventually
f5718a7265a6f5 Alan Previn 2022-03-21 42 * be detached from outlist and attached into to
f5718a7265a6f5 Alan Previn 2022-03-21 43 * i915_gpu_codedump in response to a context reset
f5718a7265a6f5 Alan Previn 2022-03-21 44 */
f5718a7265a6f5 Alan Previn 2022-03-21 45 struct list_head link;
f5718a7265a6f5 Alan Previn 2022-03-21 46 bool is_partial;
f5718a7265a6f5 Alan Previn 2022-03-21 47 u32 eng_class;
f5718a7265a6f5 Alan Previn 2022-03-21 48 u32 eng_inst;
f5718a7265a6f5 Alan Previn 2022-03-21 49 u32 guc_id;
f5718a7265a6f5 Alan Previn 2022-03-21 50 u32 lrca;
f5718a7265a6f5 Alan Previn 2022-03-21 51 struct gcap_reg_list_info {
f5718a7265a6f5 Alan Previn 2022-03-21 52 u32 vfid;
f5718a7265a6f5 Alan Previn 2022-03-21 53 u32 num_regs;
f5718a7265a6f5 Alan Previn 2022-03-21 54 struct guc_mmio_reg *regs;
f5718a7265a6f5 Alan Previn 2022-03-21 55 } reginfo[GUC_CAPTURE_LIST_TYPE_MAX];
f5718a7265a6f5 Alan Previn 2022-03-21 56 #define GCAP_PARSED_REGLIST_INDEX_GLOBAL BIT(GUC_CAPTURE_LIST_TYPE_GLOBAL)
f5718a7265a6f5 Alan Previn 2022-03-21 57 #define GCAP_PARSED_REGLIST_INDEX_ENGCLASS BIT(GUC_CAPTURE_LIST_TYPE_ENGINE_CLASS)
f5718a7265a6f5 Alan Previn 2022-03-21 58 #define GCAP_PARSED_REGLIST_INDEX_ENGINST BIT(GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE)
f5718a7265a6f5 Alan Previn 2022-03-21 59 };
f5718a7265a6f5 Alan Previn 2022-03-21 60
24492514ccbd57 Alan Previn 2022-03-21 61 /**
24492514ccbd57 Alan Previn 2022-03-21 @62 * struct guc_debug_capture_list_header / struct guc_debug_capture_list
24492514ccbd57 Alan Previn 2022-03-21 63 *
24492514ccbd57 Alan Previn 2022-03-21 64 * As part of ADS registration, these header structures (followed by
24492514ccbd57 Alan Previn 2022-03-21 65 * an array of 'struct guc_mmio_reg' entries) are used to register with
24492514ccbd57 Alan Previn 2022-03-21 66 * GuC microkernel the list of registers we want it to dump out prior
24492514ccbd57 Alan Previn 2022-03-21 67 * to a engine reset.
24492514ccbd57 Alan Previn 2022-03-21 68 */
24492514ccbd57 Alan Previn 2022-03-21 69 struct guc_debug_capture_list_header {
24492514ccbd57 Alan Previn 2022-03-21 70 u32 info;
24492514ccbd57 Alan Previn 2022-03-21 71 #define GUC_CAPTURELISTHDR_NUMDESCR GENMASK(15, 0)
24492514ccbd57 Alan Previn 2022-03-21 72 } __packed;
24492514ccbd57 Alan Previn 2022-03-21 73
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST
2023-04-04 12:22 ` kernel test robot
@ 2023-04-04 12:26 ` Jani Nikula
2023-04-04 16:21 ` Rodrigo Vivi
0 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2023-04-04 12:26 UTC (permalink / raw)
To: kernel test robot, intel-gfx; +Cc: Rodrigo Vivi, oe-kbuild-all
On Tue, 04 Apr 2023, kernel test robot <lkp@intel.com> wrote:
> Hi Jani,
>
> kernel test robot noticed the following build warnings:
Yeah, that's kind of the point of adding more checks. ;)
BR,
Jani.
>
> [auto build test WARNING on drm-tip/drm-tip]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-run-kernel-doc-on-headers-as-part-of-HDRTEST/20230404-170637
> base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
> patch link: https://lore.kernel.org/r/20230404090528.173075-1-jani.nikula%40intel.com
> patch subject: [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST
> config: i386-defconfig (https://download.01.org/0day-ci/archive/20230404/202304042026.uZBs3cC2-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> reproduce (this is a W=1 build):
> # https://github.com/intel-lab-lkp/linux/commit/336391cc647b2fbdf0ebd2eda8a10fb4509918b7
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Jani-Nikula/drm-i915-run-kernel-doc-on-headers-as-part-of-HDRTEST/20230404-170637
> git checkout 336391cc647b2fbdf0ebd2eda8a10fb4509918b7
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> make W=1 O=build_dir ARCH=i386 olddefconfig
> make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202304042026.uZBs3cC2-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'size' not described in '__guc_capture_bufstate'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'data' not described in '__guc_capture_bufstate'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'rd' not described in '__guc_capture_bufstate'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'wr' not described in '__guc_capture_bufstate'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'link' not described in '__guc_capture_parsed_output'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'is_partial' not described in '__guc_capture_parsed_output'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'eng_class' not described in '__guc_capture_parsed_output'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'eng_inst' not described in '__guc_capture_parsed_output'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'guc_id' not described in '__guc_capture_parsed_output'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'lrca' not described in '__guc_capture_parsed_output'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'reginfo' not described in '__guc_capture_parsed_output'
>>> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:62: warning: wrong kernel-doc identifier on line:
> * struct guc_debug_capture_list_header / struct guc_debug_capture_list
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:80: warning: wrong kernel-doc identifier on line:
> * struct __guc_mmio_reg_descr / struct __guc_mmio_reg_descr_group
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:105: warning: wrong kernel-doc identifier on line:
> * struct guc_state_capture_header_t / struct guc_state_capture_t /
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'is_valid' not described in '__guc_capture_ads_cache'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'ptr' not described in '__guc_capture_ads_cache'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'size' not described in '__guc_capture_ads_cache'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'status' not described in '__guc_capture_ads_cache'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function parameter or member 'ads_null_cache' not described in 'intel_guc_state_capture'
> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function parameter or member 'max_mmio_per_node' not described in 'intel_guc_state_capture'
> --
> drivers/gpu/drm/i915/i915_pmu.h:21: warning: cannot understand function prototype: 'enum i915_pmu_tracked_events '
> drivers/gpu/drm/i915/i915_pmu.h:32: warning: cannot understand function prototype: 'enum '
>>> drivers/gpu/drm/i915/i915_pmu.h:41: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * How many different events we track in the global PMU mask.
> --
>>> drivers/gpu/drm/i915/i915_request.h:176: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Request queue structure.
> drivers/gpu/drm/i915/i915_request.h:477: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Returns true if seq1 is later than seq2.
> --
>>> drivers/gpu/drm/i915/i915_vma.h:145: warning: expecting prototype for i915_vma_offset(). Prototype was for i915_vma_size() instead
> --
>>> drivers/gpu/drm/i915/intel_wakeref.h:118: warning: expecting prototype for intel_wakeref_get_if_in_use(). Prototype was for intel_wakeref_get_if_active() instead
>
>
> vim +62 drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h
>
> 24492514ccbd57 Alan Previn 2022-03-21 14
> f5718a7265a6f5 Alan Previn 2022-03-21 15 /**
> f5718a7265a6f5 Alan Previn 2022-03-21 16 * struct __guc_capture_bufstate
> f5718a7265a6f5 Alan Previn 2022-03-21 17 *
> f5718a7265a6f5 Alan Previn 2022-03-21 18 * Book-keeping structure used to track read and write pointers
> f5718a7265a6f5 Alan Previn 2022-03-21 19 * as we extract error capture data from the GuC-log-buffer's
> f5718a7265a6f5 Alan Previn 2022-03-21 20 * error-capture region as a stream of dwords.
> f5718a7265a6f5 Alan Previn 2022-03-21 21 */
> f5718a7265a6f5 Alan Previn 2022-03-21 22 struct __guc_capture_bufstate {
> f5718a7265a6f5 Alan Previn 2022-03-21 23 u32 size;
> f5718a7265a6f5 Alan Previn 2022-03-21 24 void *data;
> f5718a7265a6f5 Alan Previn 2022-03-21 25 u32 rd;
> f5718a7265a6f5 Alan Previn 2022-03-21 26 u32 wr;
> f5718a7265a6f5 Alan Previn 2022-03-21 @27 };
> f5718a7265a6f5 Alan Previn 2022-03-21 28
> f5718a7265a6f5 Alan Previn 2022-03-21 29 /**
> f5718a7265a6f5 Alan Previn 2022-03-21 30 * struct __guc_capture_parsed_output - extracted error capture node
> f5718a7265a6f5 Alan Previn 2022-03-21 31 *
> f5718a7265a6f5 Alan Previn 2022-03-21 32 * A single unit of extracted error-capture output data grouped together
> f5718a7265a6f5 Alan Previn 2022-03-21 33 * at an engine-instance level. We keep these nodes in a linked list.
> 247f8071d58933 Alan Previn 2022-03-21 34 * See cachelist and outlist below.
> f5718a7265a6f5 Alan Previn 2022-03-21 35 */
> f5718a7265a6f5 Alan Previn 2022-03-21 36 struct __guc_capture_parsed_output {
> f5718a7265a6f5 Alan Previn 2022-03-21 37 /*
> f5718a7265a6f5 Alan Previn 2022-03-21 38 * A single set of 3 capture lists: a global-list
> f5718a7265a6f5 Alan Previn 2022-03-21 39 * an engine-class-list and an engine-instance list.
> f5718a7265a6f5 Alan Previn 2022-03-21 40 * outlist in __guc_capture_parsed_output will keep
> f5718a7265a6f5 Alan Previn 2022-03-21 41 * a linked list of these nodes that will eventually
> f5718a7265a6f5 Alan Previn 2022-03-21 42 * be detached from outlist and attached into to
> f5718a7265a6f5 Alan Previn 2022-03-21 43 * i915_gpu_codedump in response to a context reset
> f5718a7265a6f5 Alan Previn 2022-03-21 44 */
> f5718a7265a6f5 Alan Previn 2022-03-21 45 struct list_head link;
> f5718a7265a6f5 Alan Previn 2022-03-21 46 bool is_partial;
> f5718a7265a6f5 Alan Previn 2022-03-21 47 u32 eng_class;
> f5718a7265a6f5 Alan Previn 2022-03-21 48 u32 eng_inst;
> f5718a7265a6f5 Alan Previn 2022-03-21 49 u32 guc_id;
> f5718a7265a6f5 Alan Previn 2022-03-21 50 u32 lrca;
> f5718a7265a6f5 Alan Previn 2022-03-21 51 struct gcap_reg_list_info {
> f5718a7265a6f5 Alan Previn 2022-03-21 52 u32 vfid;
> f5718a7265a6f5 Alan Previn 2022-03-21 53 u32 num_regs;
> f5718a7265a6f5 Alan Previn 2022-03-21 54 struct guc_mmio_reg *regs;
> f5718a7265a6f5 Alan Previn 2022-03-21 55 } reginfo[GUC_CAPTURE_LIST_TYPE_MAX];
> f5718a7265a6f5 Alan Previn 2022-03-21 56 #define GCAP_PARSED_REGLIST_INDEX_GLOBAL BIT(GUC_CAPTURE_LIST_TYPE_GLOBAL)
> f5718a7265a6f5 Alan Previn 2022-03-21 57 #define GCAP_PARSED_REGLIST_INDEX_ENGCLASS BIT(GUC_CAPTURE_LIST_TYPE_ENGINE_CLASS)
> f5718a7265a6f5 Alan Previn 2022-03-21 58 #define GCAP_PARSED_REGLIST_INDEX_ENGINST BIT(GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE)
> f5718a7265a6f5 Alan Previn 2022-03-21 59 };
> f5718a7265a6f5 Alan Previn 2022-03-21 60
> 24492514ccbd57 Alan Previn 2022-03-21 61 /**
> 24492514ccbd57 Alan Previn 2022-03-21 @62 * struct guc_debug_capture_list_header / struct guc_debug_capture_list
> 24492514ccbd57 Alan Previn 2022-03-21 63 *
> 24492514ccbd57 Alan Previn 2022-03-21 64 * As part of ADS registration, these header structures (followed by
> 24492514ccbd57 Alan Previn 2022-03-21 65 * an array of 'struct guc_mmio_reg' entries) are used to register with
> 24492514ccbd57 Alan Previn 2022-03-21 66 * GuC microkernel the list of registers we want it to dump out prior
> 24492514ccbd57 Alan Previn 2022-03-21 67 * to a engine reset.
> 24492514ccbd57 Alan Previn 2022-03-21 68 */
> 24492514ccbd57 Alan Previn 2022-03-21 69 struct guc_debug_capture_list_header {
> 24492514ccbd57 Alan Previn 2022-03-21 70 u32 info;
> 24492514ccbd57 Alan Previn 2022-03-21 71 #define GUC_CAPTURELISTHDR_NUMDESCR GENMASK(15, 0)
> 24492514ccbd57 Alan Previn 2022-03-21 72 } __packed;
> 24492514ccbd57 Alan Previn 2022-03-21 73
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: run kernel-doc on headers as part of HDRTEST
2023-04-04 9:05 [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST Jani Nikula
2023-04-04 12:22 ` kernel test robot
@ 2023-04-04 13:51 ` Patchwork
2023-04-04 14:54 ` [Intel-gfx] [PATCH] " Das, Nirmoy
2023-04-04 22:11 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2023-04-04 13:51 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5240 bytes --]
== Series Details ==
Series: drm/i915: run kernel-doc on headers as part of HDRTEST
URL : https://patchwork.freedesktop.org/series/116077/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12964 -> Patchwork_116077v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/index.html
Participating hosts (37 -> 37)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_116077v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#5334] / [i915#7872])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][4] ([i915#1886])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][5] -> [DMESG-WARN][6] ([i915#7699])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/bat-dg2-11/igt@i915_selftest@live@migrate.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- bat-rpls-2: [PASS][7] -> [ABORT][8] ([i915#7913] / [i915#7982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/bat-rpls-2/igt@i915_selftest@live@requests.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/bat-rpls-2/igt@i915_selftest@live@requests.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][9] ([fdo#109271]) +16 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
- bat-dg2-8: [PASS][10] -> [FAIL][11] ([i915#7932]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
#### Possible fixes ####
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [FAIL][12] ([i915#7932]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
#### Warnings ####
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [DMESG-FAIL][14] ([i915#6367] / [i915#7996]) -> [DMESG-FAIL][15] ([i915#6367])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/bat-rpls-1/igt@i915_selftest@live@slpc.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* Linux: CI_DRM_12964 -> Patchwork_116077v1
CI-20190529: 20190529
CI_DRM_12964: 761960bbc648f09022c69052289c90bb55798a8b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7234: 70802fb59c65164f3587e71376ebed1ed5e91fd1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_116077v1: 761960bbc648f09022c69052289c90bb55798a8b @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
72f069c332be drm/i915: run kernel-doc on headers as part of HDRTEST
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/index.html
[-- Attachment #2: Type: text/html, Size: 6339 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST
2023-04-04 9:05 [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST Jani Nikula
2023-04-04 12:22 ` kernel test robot
2023-04-04 13:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-04-04 14:54 ` Das, Nirmoy
2023-04-04 22:11 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Das, Nirmoy @ 2023-04-04 14:54 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Rodrigo Vivi
On 4/4/2023 11:05 AM, Jani Nikula wrote:
> Enabling kernel-doc warnings in commit aaee4bbe8a1a ("drm/i915: enable
> kernel-doc warnings for CONFIG_DRM_I915_WERROR=y") actually only covers
> the .c files. And it's good for avoiding warnings in W= builds. However,
> we need something more to check for kernel-doc issues in headers. Add it
> as part of the existing HDRTEST.
>
> We have tons of issues, and this unleashes warnings galore on
> CONFIG_DRM_I915_WERROR=y. It doesn't fail the build because (at least
> for now) we don't pass -Werror to kernel-doc.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
This will be really helpful.
Acked-by: Nirmoy Das <nirmoy.das@intel.com>
Thanks,
Nirmoy
> ---
> drivers/gpu/drm/i915/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index 831e42175165..b739300267c2 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -387,7 +387,8 @@ always-$(CONFIG_DRM_I915_WERROR) += \
> $(shell cd $(srctree)/$(src) && find * -name '*.h')))
>
> quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@)
> - cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; touch $@
> + cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; \
> + $(srctree)/scripts/kernel-doc -none $<; touch $@
>
> $(obj)/%.hdrtest: $(src)/%.h FORCE
> $(call if_changed_dep,hdrtest)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST
2023-04-04 12:26 ` Jani Nikula
@ 2023-04-04 16:21 ` Rodrigo Vivi
2023-04-05 10:43 ` Jani Nikula
0 siblings, 1 reply; 8+ messages in thread
From: Rodrigo Vivi @ 2023-04-04 16:21 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, oe-kbuild-all
On Tue, Apr 04, 2023 at 03:26:24PM +0300, Jani Nikula wrote:
> On Tue, 04 Apr 2023, kernel test robot <lkp@intel.com> wrote:
> > Hi Jani,
> >
> > kernel test robot noticed the following build warnings:
>
> Yeah, that's kind of the point of adding more checks. ;)
Indeed. I was in doubt if the include of the full dir was the right
way, but this reply shows it works as expected :)
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> BR,
> Jani.
>
>
> >
> > [auto build test WARNING on drm-tip/drm-tip]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-run-kernel-doc-on-headers-as-part-of-HDRTEST/20230404-170637
> > base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
> > patch link: https://lore.kernel.org/r/20230404090528.173075-1-jani.nikula%40intel.com
> > patch subject: [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST
> > config: i386-defconfig (https://download.01.org/0day-ci/archive/20230404/202304042026.uZBs3cC2-lkp@intel.com/config)
> > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> > reproduce (this is a W=1 build):
> > # https://github.com/intel-lab-lkp/linux/commit/336391cc647b2fbdf0ebd2eda8a10fb4509918b7
> > git remote add linux-review https://github.com/intel-lab-lkp/linux
> > git fetch --no-tags linux-review Jani-Nikula/drm-i915-run-kernel-doc-on-headers-as-part-of-HDRTEST/20230404-170637
> > git checkout 336391cc647b2fbdf0ebd2eda8a10fb4509918b7
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > make W=1 O=build_dir ARCH=i386 olddefconfig
> > make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/
> >
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Link: https://lore.kernel.org/oe-kbuild-all/202304042026.uZBs3cC2-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'size' not described in '__guc_capture_bufstate'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'data' not described in '__guc_capture_bufstate'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'rd' not described in '__guc_capture_bufstate'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'wr' not described in '__guc_capture_bufstate'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'link' not described in '__guc_capture_parsed_output'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'is_partial' not described in '__guc_capture_parsed_output'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'eng_class' not described in '__guc_capture_parsed_output'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'eng_inst' not described in '__guc_capture_parsed_output'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'guc_id' not described in '__guc_capture_parsed_output'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'lrca' not described in '__guc_capture_parsed_output'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'reginfo' not described in '__guc_capture_parsed_output'
> >>> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:62: warning: wrong kernel-doc identifier on line:
> > * struct guc_debug_capture_list_header / struct guc_debug_capture_list
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:80: warning: wrong kernel-doc identifier on line:
> > * struct __guc_mmio_reg_descr / struct __guc_mmio_reg_descr_group
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:105: warning: wrong kernel-doc identifier on line:
> > * struct guc_state_capture_header_t / struct guc_state_capture_t /
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'is_valid' not described in '__guc_capture_ads_cache'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'ptr' not described in '__guc_capture_ads_cache'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'size' not described in '__guc_capture_ads_cache'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'status' not described in '__guc_capture_ads_cache'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function parameter or member 'ads_null_cache' not described in 'intel_guc_state_capture'
> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function parameter or member 'max_mmio_per_node' not described in 'intel_guc_state_capture'
> > --
> > drivers/gpu/drm/i915/i915_pmu.h:21: warning: cannot understand function prototype: 'enum i915_pmu_tracked_events '
> > drivers/gpu/drm/i915/i915_pmu.h:32: warning: cannot understand function prototype: 'enum '
> >>> drivers/gpu/drm/i915/i915_pmu.h:41: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > * How many different events we track in the global PMU mask.
> > --
> >>> drivers/gpu/drm/i915/i915_request.h:176: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > * Request queue structure.
> > drivers/gpu/drm/i915/i915_request.h:477: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > * Returns true if seq1 is later than seq2.
> > --
> >>> drivers/gpu/drm/i915/i915_vma.h:145: warning: expecting prototype for i915_vma_offset(). Prototype was for i915_vma_size() instead
> > --
> >>> drivers/gpu/drm/i915/intel_wakeref.h:118: warning: expecting prototype for intel_wakeref_get_if_in_use(). Prototype was for intel_wakeref_get_if_active() instead
> >
> >
> > vim +62 drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h
> >
> > 24492514ccbd57 Alan Previn 2022-03-21 14
> > f5718a7265a6f5 Alan Previn 2022-03-21 15 /**
> > f5718a7265a6f5 Alan Previn 2022-03-21 16 * struct __guc_capture_bufstate
> > f5718a7265a6f5 Alan Previn 2022-03-21 17 *
> > f5718a7265a6f5 Alan Previn 2022-03-21 18 * Book-keeping structure used to track read and write pointers
> > f5718a7265a6f5 Alan Previn 2022-03-21 19 * as we extract error capture data from the GuC-log-buffer's
> > f5718a7265a6f5 Alan Previn 2022-03-21 20 * error-capture region as a stream of dwords.
> > f5718a7265a6f5 Alan Previn 2022-03-21 21 */
> > f5718a7265a6f5 Alan Previn 2022-03-21 22 struct __guc_capture_bufstate {
> > f5718a7265a6f5 Alan Previn 2022-03-21 23 u32 size;
> > f5718a7265a6f5 Alan Previn 2022-03-21 24 void *data;
> > f5718a7265a6f5 Alan Previn 2022-03-21 25 u32 rd;
> > f5718a7265a6f5 Alan Previn 2022-03-21 26 u32 wr;
> > f5718a7265a6f5 Alan Previn 2022-03-21 @27 };
> > f5718a7265a6f5 Alan Previn 2022-03-21 28
> > f5718a7265a6f5 Alan Previn 2022-03-21 29 /**
> > f5718a7265a6f5 Alan Previn 2022-03-21 30 * struct __guc_capture_parsed_output - extracted error capture node
> > f5718a7265a6f5 Alan Previn 2022-03-21 31 *
> > f5718a7265a6f5 Alan Previn 2022-03-21 32 * A single unit of extracted error-capture output data grouped together
> > f5718a7265a6f5 Alan Previn 2022-03-21 33 * at an engine-instance level. We keep these nodes in a linked list.
> > 247f8071d58933 Alan Previn 2022-03-21 34 * See cachelist and outlist below.
> > f5718a7265a6f5 Alan Previn 2022-03-21 35 */
> > f5718a7265a6f5 Alan Previn 2022-03-21 36 struct __guc_capture_parsed_output {
> > f5718a7265a6f5 Alan Previn 2022-03-21 37 /*
> > f5718a7265a6f5 Alan Previn 2022-03-21 38 * A single set of 3 capture lists: a global-list
> > f5718a7265a6f5 Alan Previn 2022-03-21 39 * an engine-class-list and an engine-instance list.
> > f5718a7265a6f5 Alan Previn 2022-03-21 40 * outlist in __guc_capture_parsed_output will keep
> > f5718a7265a6f5 Alan Previn 2022-03-21 41 * a linked list of these nodes that will eventually
> > f5718a7265a6f5 Alan Previn 2022-03-21 42 * be detached from outlist and attached into to
> > f5718a7265a6f5 Alan Previn 2022-03-21 43 * i915_gpu_codedump in response to a context reset
> > f5718a7265a6f5 Alan Previn 2022-03-21 44 */
> > f5718a7265a6f5 Alan Previn 2022-03-21 45 struct list_head link;
> > f5718a7265a6f5 Alan Previn 2022-03-21 46 bool is_partial;
> > f5718a7265a6f5 Alan Previn 2022-03-21 47 u32 eng_class;
> > f5718a7265a6f5 Alan Previn 2022-03-21 48 u32 eng_inst;
> > f5718a7265a6f5 Alan Previn 2022-03-21 49 u32 guc_id;
> > f5718a7265a6f5 Alan Previn 2022-03-21 50 u32 lrca;
> > f5718a7265a6f5 Alan Previn 2022-03-21 51 struct gcap_reg_list_info {
> > f5718a7265a6f5 Alan Previn 2022-03-21 52 u32 vfid;
> > f5718a7265a6f5 Alan Previn 2022-03-21 53 u32 num_regs;
> > f5718a7265a6f5 Alan Previn 2022-03-21 54 struct guc_mmio_reg *regs;
> > f5718a7265a6f5 Alan Previn 2022-03-21 55 } reginfo[GUC_CAPTURE_LIST_TYPE_MAX];
> > f5718a7265a6f5 Alan Previn 2022-03-21 56 #define GCAP_PARSED_REGLIST_INDEX_GLOBAL BIT(GUC_CAPTURE_LIST_TYPE_GLOBAL)
> > f5718a7265a6f5 Alan Previn 2022-03-21 57 #define GCAP_PARSED_REGLIST_INDEX_ENGCLASS BIT(GUC_CAPTURE_LIST_TYPE_ENGINE_CLASS)
> > f5718a7265a6f5 Alan Previn 2022-03-21 58 #define GCAP_PARSED_REGLIST_INDEX_ENGINST BIT(GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE)
> > f5718a7265a6f5 Alan Previn 2022-03-21 59 };
> > f5718a7265a6f5 Alan Previn 2022-03-21 60
> > 24492514ccbd57 Alan Previn 2022-03-21 61 /**
> > 24492514ccbd57 Alan Previn 2022-03-21 @62 * struct guc_debug_capture_list_header / struct guc_debug_capture_list
> > 24492514ccbd57 Alan Previn 2022-03-21 63 *
> > 24492514ccbd57 Alan Previn 2022-03-21 64 * As part of ADS registration, these header structures (followed by
> > 24492514ccbd57 Alan Previn 2022-03-21 65 * an array of 'struct guc_mmio_reg' entries) are used to register with
> > 24492514ccbd57 Alan Previn 2022-03-21 66 * GuC microkernel the list of registers we want it to dump out prior
> > 24492514ccbd57 Alan Previn 2022-03-21 67 * to a engine reset.
> > 24492514ccbd57 Alan Previn 2022-03-21 68 */
> > 24492514ccbd57 Alan Previn 2022-03-21 69 struct guc_debug_capture_list_header {
> > 24492514ccbd57 Alan Previn 2022-03-21 70 u32 info;
> > 24492514ccbd57 Alan Previn 2022-03-21 71 #define GUC_CAPTURELISTHDR_NUMDESCR GENMASK(15, 0)
> > 24492514ccbd57 Alan Previn 2022-03-21 72 } __packed;
> > 24492514ccbd57 Alan Previn 2022-03-21 73
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: run kernel-doc on headers as part of HDRTEST
2023-04-04 9:05 [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST Jani Nikula
` (2 preceding siblings ...)
2023-04-04 14:54 ` [Intel-gfx] [PATCH] " Das, Nirmoy
@ 2023-04-04 22:11 ` Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2023-04-04 22:11 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 14518 bytes --]
== Series Details ==
Series: drm/i915: run kernel-doc on headers as part of HDRTEST
URL : https://patchwork.freedesktop.org/series/116077/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12964_full -> Patchwork_116077v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_116077v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_rotation_crc@primary-rotation-270:
- {shard-rkl}: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-rkl-4/igt@kms_rotation_crc@primary-rotation-270.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-rkl-4/igt@kms_rotation_crc@primary-rotation-270.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-d:
- {shard-rkl}: [SKIP][3] ([i915#4070] / [i915#533] / [i915#6768]) -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-rkl-1/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-d.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-rkl-2/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-d.html
Known issues
------------
Here are the changes found in Patchwork_116077v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-apl: [PASS][5] -> [FAIL][6] ([i915#2846])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-apl4/igt@gem_exec_fair@basic-deadline.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-apl3/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-glk3/igt@gem_exec_fair@basic-pace@vcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-glk6/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_pwrite@basic-exhaustion:
- shard-snb: NOTRUN -> [WARN][9] ([i915#2658])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-snb2/igt@gem_pwrite@basic-exhaustion.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#3886])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-apl3/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_content_protection@atomic-dpms:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271]) +86 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-snb2/igt@kms_content_protection@atomic-dpms.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271]) +9 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-apl3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- {shard-rkl}: [FAIL][13] ([i915#7742]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-rkl-2/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][15] ([i915#6268]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-tglu-3/igt@gem_ctx_exec@basic-nohangcheck.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-tglu-9/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-tglu}: [SKIP][17] ([i915#4281]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-tglu-8/igt@i915_pm_dc@dc9-dpms.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-tglu-9/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- {shard-rkl}: [SKIP][19] ([i915#1397]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-rkl-6/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-dg1}: [SKIP][21] ([i915#1397]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-dg1-15/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-dg1-14/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@i915_pm_rps@reset:
- shard-snb: [INCOMPLETE][23] ([i915#7790]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-snb2/igt@i915_pm_rps@reset.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-snb2/igt@i915_pm_rps@reset.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][25] ([i915#2346]) -> [PASS][26] +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
- shard-glk: [FAIL][27] ([i915#2346]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@single-bo@pipe-b:
- {shard-dg1}: [INCOMPLETE][29] ([i915#8011]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-dg1-14/igt@kms_cursor_legacy@single-bo@pipe-b.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-dg1-18/igt@kms_cursor_legacy@single-bo@pipe-b.html
* igt@kms_cursor_legacy@single-move@all-pipes:
- shard-apl: [ABORT][31] -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-apl3/igt@kms_cursor_legacy@single-move@all-pipes.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-apl3/igt@kms_cursor_legacy@single-move@all-pipes.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][33] ([i915#2122]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-glk9/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-glk2/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-4:
- {shard-dg1}: [ABORT][35] ([i915#8174]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12964/shard-dg1-18/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-4.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/shard-dg1-16/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-4.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8174]: https://gitlab.freedesktop.org/drm/intel/issues/8174
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
Build changes
-------------
* Linux: CI_DRM_12964 -> Patchwork_116077v1
CI-20190529: 20190529
CI_DRM_12964: 761960bbc648f09022c69052289c90bb55798a8b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7234: 70802fb59c65164f3587e71376ebed1ed5e91fd1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_116077v1: 761960bbc648f09022c69052289c90bb55798a8b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116077v1/index.html
[-- Attachment #2: Type: text/html, Size: 11203 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST
2023-04-04 16:21 ` Rodrigo Vivi
@ 2023-04-05 10:43 ` Jani Nikula
0 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2023-04-05 10:43 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
On Tue, 04 Apr 2023, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Tue, Apr 04, 2023 at 03:26:24PM +0300, Jani Nikula wrote:
>> On Tue, 04 Apr 2023, kernel test robot <lkp@intel.com> wrote:
>> > Hi Jani,
>> >
>> > kernel test robot noticed the following build warnings:
>>
>> Yeah, that's kind of the point of adding more checks. ;)
>
> Indeed. I was in doubt if the include of the full dir was the right
> way, but this reply shows it works as expected :)
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks, pushed to drm-intel-next.
Btw the gitlab issue for the warnings is [1].
BR,
Jani.
[1] https://gitlab.freedesktop.org/drm/intel/-/issues/8335
>
>>
>> BR,
>> Jani.
>>
>>
>> >
>> > [auto build test WARNING on drm-tip/drm-tip]
>> >
>> > url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-run-kernel-doc-on-headers-as-part-of-HDRTEST/20230404-170637
>> > base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
>> > patch link: https://lore.kernel.org/r/20230404090528.173075-1-jani.nikula%40intel.com
>> > patch subject: [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST
>> > config: i386-defconfig (https://download.01.org/0day-ci/archive/20230404/202304042026.uZBs3cC2-lkp@intel.com/config)
>> > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
>> > reproduce (this is a W=1 build):
>> > # https://github.com/intel-lab-lkp/linux/commit/336391cc647b2fbdf0ebd2eda8a10fb4509918b7
>> > git remote add linux-review https://github.com/intel-lab-lkp/linux
>> > git fetch --no-tags linux-review Jani-Nikula/drm-i915-run-kernel-doc-on-headers-as-part-of-HDRTEST/20230404-170637
>> > git checkout 336391cc647b2fbdf0ebd2eda8a10fb4509918b7
>> > # save the config file
>> > mkdir build_dir && cp config build_dir/.config
>> > make W=1 O=build_dir ARCH=i386 olddefconfig
>> > make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/
>> >
>> > If you fix the issue, kindly add following tag where applicable
>> > | Reported-by: kernel test robot <lkp@intel.com>
>> > | Link: https://lore.kernel.org/oe-kbuild-all/202304042026.uZBs3cC2-lkp@intel.com/
>> >
>> > All warnings (new ones prefixed by >>):
>> >
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'size' not described in '__guc_capture_bufstate'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'data' not described in '__guc_capture_bufstate'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'rd' not described in '__guc_capture_bufstate'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'wr' not described in '__guc_capture_bufstate'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'link' not described in '__guc_capture_parsed_output'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'is_partial' not described in '__guc_capture_parsed_output'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'eng_class' not described in '__guc_capture_parsed_output'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'eng_inst' not described in '__guc_capture_parsed_output'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'guc_id' not described in '__guc_capture_parsed_output'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'lrca' not described in '__guc_capture_parsed_output'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:59: warning: Function parameter or member 'reginfo' not described in '__guc_capture_parsed_output'
>> >>> drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:62: warning: wrong kernel-doc identifier on line:
>> > * struct guc_debug_capture_list_header / struct guc_debug_capture_list
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:80: warning: wrong kernel-doc identifier on line:
>> > * struct __guc_mmio_reg_descr / struct __guc_mmio_reg_descr_group
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:105: warning: wrong kernel-doc identifier on line:
>> > * struct guc_state_capture_header_t / struct guc_state_capture_t /
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'is_valid' not described in '__guc_capture_ads_cache'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'ptr' not described in '__guc_capture_ads_cache'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'size' not described in '__guc_capture_ads_cache'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:163: warning: Function parameter or member 'status' not described in '__guc_capture_ads_cache'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function parameter or member 'ads_null_cache' not described in 'intel_guc_state_capture'
>> > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function parameter or member 'max_mmio_per_node' not described in 'intel_guc_state_capture'
>> > --
>> > drivers/gpu/drm/i915/i915_pmu.h:21: warning: cannot understand function prototype: 'enum i915_pmu_tracked_events '
>> > drivers/gpu/drm/i915/i915_pmu.h:32: warning: cannot understand function prototype: 'enum '
>> >>> drivers/gpu/drm/i915/i915_pmu.h:41: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>> > * How many different events we track in the global PMU mask.
>> > --
>> >>> drivers/gpu/drm/i915/i915_request.h:176: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>> > * Request queue structure.
>> > drivers/gpu/drm/i915/i915_request.h:477: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>> > * Returns true if seq1 is later than seq2.
>> > --
>> >>> drivers/gpu/drm/i915/i915_vma.h:145: warning: expecting prototype for i915_vma_offset(). Prototype was for i915_vma_size() instead
>> > --
>> >>> drivers/gpu/drm/i915/intel_wakeref.h:118: warning: expecting prototype for intel_wakeref_get_if_in_use(). Prototype was for intel_wakeref_get_if_active() instead
>> >
>> >
>> > vim +62 drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h
>> >
>> > 24492514ccbd57 Alan Previn 2022-03-21 14
>> > f5718a7265a6f5 Alan Previn 2022-03-21 15 /**
>> > f5718a7265a6f5 Alan Previn 2022-03-21 16 * struct __guc_capture_bufstate
>> > f5718a7265a6f5 Alan Previn 2022-03-21 17 *
>> > f5718a7265a6f5 Alan Previn 2022-03-21 18 * Book-keeping structure used to track read and write pointers
>> > f5718a7265a6f5 Alan Previn 2022-03-21 19 * as we extract error capture data from the GuC-log-buffer's
>> > f5718a7265a6f5 Alan Previn 2022-03-21 20 * error-capture region as a stream of dwords.
>> > f5718a7265a6f5 Alan Previn 2022-03-21 21 */
>> > f5718a7265a6f5 Alan Previn 2022-03-21 22 struct __guc_capture_bufstate {
>> > f5718a7265a6f5 Alan Previn 2022-03-21 23 u32 size;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 24 void *data;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 25 u32 rd;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 26 u32 wr;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 @27 };
>> > f5718a7265a6f5 Alan Previn 2022-03-21 28
>> > f5718a7265a6f5 Alan Previn 2022-03-21 29 /**
>> > f5718a7265a6f5 Alan Previn 2022-03-21 30 * struct __guc_capture_parsed_output - extracted error capture node
>> > f5718a7265a6f5 Alan Previn 2022-03-21 31 *
>> > f5718a7265a6f5 Alan Previn 2022-03-21 32 * A single unit of extracted error-capture output data grouped together
>> > f5718a7265a6f5 Alan Previn 2022-03-21 33 * at an engine-instance level. We keep these nodes in a linked list.
>> > 247f8071d58933 Alan Previn 2022-03-21 34 * See cachelist and outlist below.
>> > f5718a7265a6f5 Alan Previn 2022-03-21 35 */
>> > f5718a7265a6f5 Alan Previn 2022-03-21 36 struct __guc_capture_parsed_output {
>> > f5718a7265a6f5 Alan Previn 2022-03-21 37 /*
>> > f5718a7265a6f5 Alan Previn 2022-03-21 38 * A single set of 3 capture lists: a global-list
>> > f5718a7265a6f5 Alan Previn 2022-03-21 39 * an engine-class-list and an engine-instance list.
>> > f5718a7265a6f5 Alan Previn 2022-03-21 40 * outlist in __guc_capture_parsed_output will keep
>> > f5718a7265a6f5 Alan Previn 2022-03-21 41 * a linked list of these nodes that will eventually
>> > f5718a7265a6f5 Alan Previn 2022-03-21 42 * be detached from outlist and attached into to
>> > f5718a7265a6f5 Alan Previn 2022-03-21 43 * i915_gpu_codedump in response to a context reset
>> > f5718a7265a6f5 Alan Previn 2022-03-21 44 */
>> > f5718a7265a6f5 Alan Previn 2022-03-21 45 struct list_head link;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 46 bool is_partial;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 47 u32 eng_class;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 48 u32 eng_inst;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 49 u32 guc_id;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 50 u32 lrca;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 51 struct gcap_reg_list_info {
>> > f5718a7265a6f5 Alan Previn 2022-03-21 52 u32 vfid;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 53 u32 num_regs;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 54 struct guc_mmio_reg *regs;
>> > f5718a7265a6f5 Alan Previn 2022-03-21 55 } reginfo[GUC_CAPTURE_LIST_TYPE_MAX];
>> > f5718a7265a6f5 Alan Previn 2022-03-21 56 #define GCAP_PARSED_REGLIST_INDEX_GLOBAL BIT(GUC_CAPTURE_LIST_TYPE_GLOBAL)
>> > f5718a7265a6f5 Alan Previn 2022-03-21 57 #define GCAP_PARSED_REGLIST_INDEX_ENGCLASS BIT(GUC_CAPTURE_LIST_TYPE_ENGINE_CLASS)
>> > f5718a7265a6f5 Alan Previn 2022-03-21 58 #define GCAP_PARSED_REGLIST_INDEX_ENGINST BIT(GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE)
>> > f5718a7265a6f5 Alan Previn 2022-03-21 59 };
>> > f5718a7265a6f5 Alan Previn 2022-03-21 60
>> > 24492514ccbd57 Alan Previn 2022-03-21 61 /**
>> > 24492514ccbd57 Alan Previn 2022-03-21 @62 * struct guc_debug_capture_list_header / struct guc_debug_capture_list
>> > 24492514ccbd57 Alan Previn 2022-03-21 63 *
>> > 24492514ccbd57 Alan Previn 2022-03-21 64 * As part of ADS registration, these header structures (followed by
>> > 24492514ccbd57 Alan Previn 2022-03-21 65 * an array of 'struct guc_mmio_reg' entries) are used to register with
>> > 24492514ccbd57 Alan Previn 2022-03-21 66 * GuC microkernel the list of registers we want it to dump out prior
>> > 24492514ccbd57 Alan Previn 2022-03-21 67 * to a engine reset.
>> > 24492514ccbd57 Alan Previn 2022-03-21 68 */
>> > 24492514ccbd57 Alan Previn 2022-03-21 69 struct guc_debug_capture_list_header {
>> > 24492514ccbd57 Alan Previn 2022-03-21 70 u32 info;
>> > 24492514ccbd57 Alan Previn 2022-03-21 71 #define GUC_CAPTURELISTHDR_NUMDESCR GENMASK(15, 0)
>> > 24492514ccbd57 Alan Previn 2022-03-21 72 } __packed;
>> > 24492514ccbd57 Alan Previn 2022-03-21 73
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-04-05 10:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-04 9:05 [Intel-gfx] [PATCH] drm/i915: run kernel-doc on headers as part of HDRTEST Jani Nikula
2023-04-04 12:22 ` kernel test robot
2023-04-04 12:26 ` Jani Nikula
2023-04-04 16:21 ` Rodrigo Vivi
2023-04-05 10:43 ` Jani Nikula
2023-04-04 13:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-04-04 14:54 ` [Intel-gfx] [PATCH] " Das, Nirmoy
2023-04-04 22:11 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).