From: Chris Wilson <chris@chris-wilson.co.uk>
To: Keith Packard <keithp@keithp.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: Attach a fb to the load-detect pipe
Date: Wed, 20 Apr 2011 10:25:37 +0100 [thread overview]
Message-ID: <1bdc18$k9qq24@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <yuntydux79v.fsf@aiko.keithp.com>
On Tue, 19 Apr 2011 14:26:04 -0700, Keith Packard <keithp@keithp.com> wrote:
> On Tue, 19 Apr 2011 21:32:02 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > We need to ensure that we feed valid memory into the display plane
> > attached to the pipe when switching the pipe on. Otherwise, the display
> > engine may read through an invalid PTE and so throw an PGTBL_ER
> > exception.
>
> This seems to rewrite most of the load detection code, but doesn't
> justify that rewrite in comments (either commit or in-line). You'll need
> to break this up so that we can actually see what is changing.
I created a fresh series of patches that hopefully clarifies what needs to
be corrected in intel_get_load_detect_pipe(). It was meant to be attached
here, but I failed to drive git send-email correctly. :(
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-04-20 9:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 20:32 Modesetting fixes for pre-ILK, 915GM especially Chris Wilson
2011-04-19 20:32 ` [PATCH 1/3] drm/i915: Check that the plane points to the pipe's framebuffer before enabling Chris Wilson
2011-04-19 20:40 ` Jesse Barnes
2011-04-19 20:32 ` [PATCH 2/3] drm/i915: Attach a fb to the load-detect pipe Chris Wilson
2011-04-19 21:26 ` Keith Packard
2011-04-20 9:25 ` Chris Wilson [this message]
2011-04-19 20:32 ` [PATCH 3/3] drm/i915: Only enable the plane after setting the fb base (pre-ILK) Chris Wilson
2011-04-19 20:39 ` Jesse Barnes
2011-04-20 21:43 [PATCH] drm/i915: Attach a fb to the load-detect pipe Chris Wilson
2011-04-21 8:45 ` When in doubt, use a temporary fb Chris Wilson
2011-04-21 8:45 ` [PATCH 2/3] drm/i915: Attach a fb to the load-detect pipe Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1bdc18$k9qq24@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).