* [PATCH] drm/i915: Fix a bug calling sleep function in atomic context
@ 2019-11-13 0:28 Bruce Chang
2019-11-13 0:28 ` [Intel-gfx] " Bruce Chang
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Bruce Chang @ 2019-11-13 0:28 UTC (permalink / raw)
To: intel-gfx
There are quite a few reports regarding "BUG: sleeping function called from
invalid context at mm/page_alloc.c"
Basically after the io_mapping_map_atomic_wc/kmap_atomic, it enters atomic
context, but compress_page cannot be called in atomic context as it will
call pool_alloc with GFP_KERNEL flag which can go to sleep. This is why
the bug got reported.
So, changed to non atomic version instead.
Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
---
drivers/gpu/drm/i915/i915_gpu_error.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 1f2f266f26af..7118ecb7f144 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1007,67 +1007,67 @@ i915_error_object_create(struct drm_i915_private *i915,
compress->wc = i915_gem_object_is_lmem(vma->obj) ||
drm_mm_node_allocated(&ggtt->error_capture);
ret = -EINVAL;
if (drm_mm_node_allocated(&ggtt->error_capture)) {
void __iomem *s;
dma_addr_t dma;
for_each_sgt_daddr(dma, iter, vma->pages) {
ggtt->vm.insert_page(&ggtt->vm, dma, slot,
I915_CACHE_NONE, 0);
s = io_mapping_map_wc(&ggtt->iomap, slot, PAGE_SIZE);
ret = compress_page(compress, (void __force *)s, dst);
io_mapping_unmap(s);
if (ret)
break;
}
} else if (i915_gem_object_is_lmem(vma->obj)) {
struct intel_memory_region *mem = vma->obj->mm.region;
dma_addr_t dma;
for_each_sgt_daddr(dma, iter, vma->pages) {
void __iomem *s;
- s = io_mapping_map_atomic_wc(&mem->iomap, dma);
+ s = io_mapping_map_wc(&mem->iomap, dma, PAGE_SIZE);
ret = compress_page(compress, (void __force *)s, dst);
- io_mapping_unmap_atomic(s);
+ io_mapping_unmap(s);
if (ret)
break;
}
} else {
struct page *page;
for_each_sgt_page(page, iter, vma->pages) {
void *s;
drm_clflush_pages(&page, 1);
- s = kmap_atomic(page);
+ s = kmap(page);
ret = compress_page(compress, s, dst);
- kunmap_atomic(s);
+ kunmap(s);
drm_clflush_pages(&page, 1);
if (ret)
break;
}
}
if (ret || compress_flush(compress, dst)) {
while (dst->page_count--)
pool_free(&compress->pool, dst->pages[dst->page_count]);
kfree(dst);
dst = NULL;
}
compress_finish(compress);
return dst;
}
/*
* Generate a semi-unique error code. The code is not meant to have meaning, The
* code's only purpose is to try to prevent false duplicated bug reports by
* grossly estimating a GPU error state.
*
* TODO Ideally, hashing the batchbuffer would be a very nice way to determine
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 0:28 [PATCH] drm/i915: Fix a bug calling sleep function in atomic context Bruce Chang
@ 2019-11-13 0:28 ` Bruce Chang
2019-11-13 1:36 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 14+ messages in thread
From: Bruce Chang @ 2019-11-13 0:28 UTC (permalink / raw)
To: intel-gfx
There are quite a few reports regarding "BUG: sleeping function called from
invalid context at mm/page_alloc.c"
Basically after the io_mapping_map_atomic_wc/kmap_atomic, it enters atomic
context, but compress_page cannot be called in atomic context as it will
call pool_alloc with GFP_KERNEL flag which can go to sleep. This is why
the bug got reported.
So, changed to non atomic version instead.
Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
---
drivers/gpu/drm/i915/i915_gpu_error.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 1f2f266f26af..7118ecb7f144 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1007,67 +1007,67 @@ i915_error_object_create(struct drm_i915_private *i915,
compress->wc = i915_gem_object_is_lmem(vma->obj) ||
drm_mm_node_allocated(&ggtt->error_capture);
ret = -EINVAL;
if (drm_mm_node_allocated(&ggtt->error_capture)) {
void __iomem *s;
dma_addr_t dma;
for_each_sgt_daddr(dma, iter, vma->pages) {
ggtt->vm.insert_page(&ggtt->vm, dma, slot,
I915_CACHE_NONE, 0);
s = io_mapping_map_wc(&ggtt->iomap, slot, PAGE_SIZE);
ret = compress_page(compress, (void __force *)s, dst);
io_mapping_unmap(s);
if (ret)
break;
}
} else if (i915_gem_object_is_lmem(vma->obj)) {
struct intel_memory_region *mem = vma->obj->mm.region;
dma_addr_t dma;
for_each_sgt_daddr(dma, iter, vma->pages) {
void __iomem *s;
- s = io_mapping_map_atomic_wc(&mem->iomap, dma);
+ s = io_mapping_map_wc(&mem->iomap, dma, PAGE_SIZE);
ret = compress_page(compress, (void __force *)s, dst);
- io_mapping_unmap_atomic(s);
+ io_mapping_unmap(s);
if (ret)
break;
}
} else {
struct page *page;
for_each_sgt_page(page, iter, vma->pages) {
void *s;
drm_clflush_pages(&page, 1);
- s = kmap_atomic(page);
+ s = kmap(page);
ret = compress_page(compress, s, dst);
- kunmap_atomic(s);
+ kunmap(s);
drm_clflush_pages(&page, 1);
if (ret)
break;
}
}
if (ret || compress_flush(compress, dst)) {
while (dst->page_count--)
pool_free(&compress->pool, dst->pages[dst->page_count]);
kfree(dst);
dst = NULL;
}
compress_finish(compress);
return dst;
}
/*
* Generate a semi-unique error code. The code is not meant to have meaning, The
* code's only purpose is to try to prevent false duplicated bug reports by
* grossly estimating a GPU error state.
*
* TODO Ideally, hashing the batchbuffer would be a very nice way to determine
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 0:28 [PATCH] drm/i915: Fix a bug calling sleep function in atomic context Bruce Chang
2019-11-13 0:28 ` [Intel-gfx] " Bruce Chang
@ 2019-11-13 1:36 ` Patchwork
2019-11-13 1:36 ` [Intel-gfx] " Patchwork
2019-11-13 13:25 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-13 19:32 ` [PATCH] " Brian Welty
3 siblings, 1 reply; 14+ messages in thread
From: Patchwork @ 2019-11-13 1:36 UTC (permalink / raw)
To: Bruce Chang; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix a bug calling sleep function in atomic context
URL : https://patchwork.freedesktop.org/series/69385/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7324 -> Patchwork_15246
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/index.html
Known issues
------------
Here are the changes found in Patchwork_15246 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][1] -> [DMESG-WARN][2] ([fdo#102614])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: [DMESG-WARN][3] ([fdo#107139]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
* igt@kms_busy@basic-flip-pipe-a:
- fi-icl-u2: [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-guc: [FAIL][7] ([fdo#103167]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-icl-guc/igt@kms_frontbuffer_tracking@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-icl-guc/igt@kms_frontbuffer_tracking@basic.html
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
Participating hosts (51 -> 46)
------------------------------
Additional (1): fi-skl-6770hq
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7324 -> Patchwork_15246
CI-20190529: 20190529
CI_DRM_7324: dd07789205270dd69eca30ef7d123b5d2322d7a8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5274: 1345346c97c630563aae08cc2f1276c70b90378d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15246: 87b5c93d694e0a22a5fec76927b71215475c59ec @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
87b5c93d694e drm/i915: Fix a bug calling sleep function in atomic context
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 1:36 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-11-13 1:36 ` Patchwork
0 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-11-13 1:36 UTC (permalink / raw)
To: Bruce Chang; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix a bug calling sleep function in atomic context
URL : https://patchwork.freedesktop.org/series/69385/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7324 -> Patchwork_15246
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/index.html
Known issues
------------
Here are the changes found in Patchwork_15246 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][1] -> [DMESG-WARN][2] ([fdo#102614])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: [DMESG-WARN][3] ([fdo#107139]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
* igt@kms_busy@basic-flip-pipe-a:
- fi-icl-u2: [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-guc: [FAIL][7] ([fdo#103167]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-icl-guc/igt@kms_frontbuffer_tracking@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-icl-guc/igt@kms_frontbuffer_tracking@basic.html
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
Participating hosts (51 -> 46)
------------------------------
Additional (1): fi-skl-6770hq
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7324 -> Patchwork_15246
CI-20190529: 20190529
CI_DRM_7324: dd07789205270dd69eca30ef7d123b5d2322d7a8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5274: 1345346c97c630563aae08cc2f1276c70b90378d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15246: 87b5c93d694e0a22a5fec76927b71215475c59ec @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
87b5c93d694e drm/i915: Fix a bug calling sleep function in atomic context
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 0:28 [PATCH] drm/i915: Fix a bug calling sleep function in atomic context Bruce Chang
2019-11-13 0:28 ` [Intel-gfx] " Bruce Chang
2019-11-13 1:36 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-11-13 13:25 ` Patchwork
2019-11-13 13:25 ` [Intel-gfx] " Patchwork
2019-11-13 19:32 ` [PATCH] " Brian Welty
3 siblings, 1 reply; 14+ messages in thread
From: Patchwork @ 2019-11-13 13:25 UTC (permalink / raw)
To: Bruce Chang; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix a bug calling sleep function in atomic context
URL : https://patchwork.freedesktop.org/series/69385/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7324_full -> Patchwork_15246_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_15246_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
* igt@gem_ctx_isolation@vcs1-reset:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@gem_ctx_isolation@vcs1-reset.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@gem_ctx_isolation@vcs1-reset.html
* igt@gem_eio@suspend:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([fdo#111850])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@gem_eio@suspend.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@gem_eio@suspend.html
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@gem_exec_schedule@in-order-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb4/igt@gem_exec_schedule@in-order-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_sync@basic-store-each:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111747])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb4/igt@gem_sync@basic-store-each.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb9/igt@gem_sync@basic-store-each.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-hsw5/igt@gem_userptr_blits@dmabuf-sync.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-hsw8/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-snb4/igt@gem_userptr_blits@sync-unmap.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-snb2/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([fdo#105763] / [fdo#106538])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-glk6/igt@i915_pm_rpm@modeset-stress-extra-wait.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
* igt@i915_pm_rpm@universal-planes:
- shard-skl: [PASS][19] -> [DMESG-WARN][20] ([fdo#105541])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl6/igt@i915_pm_rpm@universal-planes.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl1/igt@i915_pm_rpm@universal-planes.html
* igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen:
- shard-skl: [PASS][21] -> [FAIL][22] ([fdo#103232]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html
* igt@kms_flip@2x-dpms-vs-vblank-race:
- shard-hsw: [PASS][23] -> [DMESG-WARN][24] ([fdo#102614])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-hsw8/igt@kms_flip@2x-dpms-vs-vblank-race.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-hsw5/igt@kms_flip@2x-dpms-vs-vblank-race.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-tglb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-skl: [PASS][33] -> [INCOMPLETE][34] ([fdo#104108])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl10/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl10/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][35] -> [FAIL][36] ([fdo#103166])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@psr2_suspend:
- shard-tglb: [PASS][39] -> [DMESG-WARN][40] ([fdo#111600])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb3/igt@kms_psr@psr2_suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb8/igt@kms_psr@psr2_suspend.html
* igt@kms_psr@suspend:
- shard-tglb: [PASS][41] -> [INCOMPLETE][42] ([fdo#111832] / [fdo#111850]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@kms_psr@suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@kms_psr@suspend.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][43] ([fdo#108566]) -> [PASS][44] +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
- shard-tglb: [INCOMPLETE][45] ([fdo#111832]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb1/igt@gem_ctx_isolation@rcs0-s3.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb9/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [SKIP][47] ([fdo#109276] / [fdo#112080]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][49] ([fdo#110841]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_ctx_switch@vcs1-heavy:
- shard-iclb: [SKIP][51] ([fdo#112080]) -> [PASS][52] +9 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb8/igt@gem_ctx_switch@vcs1-heavy.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@gem_ctx_switch@vcs1-heavy.html
* igt@gem_eio@reset-stress:
- shard-tglb: [INCOMPLETE][53] ([fdo#111867]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@gem_eio@reset-stress.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb7/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][55] ([fdo#110854]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@gem_exec_balancer@smoke.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb2/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@preempt-queue-blt:
- shard-tglb: [INCOMPLETE][57] ([fdo#111677]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb6/igt@gem_exec_schedule@preempt-queue-blt.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb1/igt@gem_exec_schedule@preempt-queue-blt.html
* igt@gem_exec_schedule@preempt-queue-chain-bsd1:
- shard-tglb: [INCOMPLETE][59] ([fdo#111606] / [fdo#111677]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb1/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][61] ([fdo#112146]) -> [PASS][62] +4 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb2/igt@gem_exec_schedule@preemptive-hang-bsd.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb3/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [INCOMPLETE][63] ([fdo#111736] / [fdo#111850]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb8/igt@gem_exec_suspend@basic-s3.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [FAIL][65] ([fdo#112037]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_userptr_blits@sync-unmap:
- shard-hsw: [DMESG-WARN][67] ([fdo#111870]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-hsw6/igt@gem_userptr_blits@sync-unmap.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-hsw5/igt@gem_userptr_blits@sync-unmap.html
* igt@kms_color@pipe-a-ctm-red-to-blue:
- shard-skl: [DMESG-WARN][69] ([fdo#106107]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl10/igt@kms_color@pipe-a-ctm-red-to-blue.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl10/igt@kms_color@pipe-a-ctm-red-to-blue.html
* igt@kms_cursor_crc@pipe-c-cursor-size-change:
- shard-skl: [FAIL][71] ([fdo#103232]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-size-change.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-size-change.html
* igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
- shard-skl: [DMESG-WARN][73] ([fdo#105541]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl8/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl6/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][75] ([fdo#105363]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl9/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [FAIL][77] ([fdo#103167]) -> [PASS][78] +6 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +4 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-tglb: [INCOMPLETE][81] ([fdo#111832] / [fdo#111850]) -> [PASS][82] +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][83] ([fdo#108145]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][85] ([fdo#108145] / [fdo#110403]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][87] ([fdo#109441]) -> [PASS][88] +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_cpu.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][89] ([fdo#99912]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-apl7/igt@kms_setmode@basic.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-apl8/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][91] ([fdo#111850]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb1/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb2/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [INCOMPLETE][93] ([fdo#104108]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][95] ([fdo#109276]) -> [PASS][96] +16 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@prime_busy@hang-bsd2.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][97] ([fdo#109276] / [fdo#112080]) -> [FAIL][98] ([fdo#111329])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs2-clean:
- shard-tglb: [SKIP][99] ([fdo#111912] / [fdo#112080]) -> [SKIP][100] ([fdo#112080])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb1/igt@gem_ctx_isolation@vcs2-clean.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb9/igt@gem_ctx_isolation@vcs2-clean.html
* igt@gem_ctx_isolation@vcs2-reset:
- shard-tglb: [SKIP][101] ([fdo#112080]) -> [SKIP][102] ([fdo#111912] / [fdo#112080])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@gem_ctx_isolation@vcs2-reset.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb7/igt@gem_ctx_isolation@vcs2-reset.html
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][103] ([fdo#105411]) -> [DMESG-WARN][104] ([fdo# 112000 ] / [fdo#111781])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-snb7/igt@gem_eio@kms.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-snb5/igt@gem_eio@kms.html
* igt@gem_exec_schedule@deep-blt:
- shard-tglb: [FAIL][105] ([fdo#111646]) -> [INCOMPLETE][106] ([fdo#111671])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb8/igt@gem_exec_schedule@deep-blt.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb7/igt@gem_exec_schedule@deep-blt.html
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [FAIL][107] ([fdo#111330]) -> [SKIP][108] ([fdo#109276])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb4/igt@gem_mocs_settings@mocs-isolation-bsd2.html
[1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 13:25 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-11-13 13:25 ` Patchwork
0 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-11-13 13:25 UTC (permalink / raw)
To: Bruce Chang; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix a bug calling sleep function in atomic context
URL : https://patchwork.freedesktop.org/series/69385/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7324_full -> Patchwork_15246_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_15246_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
* igt@gem_ctx_isolation@vcs1-reset:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@gem_ctx_isolation@vcs1-reset.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@gem_ctx_isolation@vcs1-reset.html
* igt@gem_eio@suspend:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([fdo#111850])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@gem_eio@suspend.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@gem_eio@suspend.html
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@gem_exec_schedule@in-order-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb4/igt@gem_exec_schedule@in-order-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_sync@basic-store-each:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111747])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb4/igt@gem_sync@basic-store-each.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb9/igt@gem_sync@basic-store-each.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-hsw5/igt@gem_userptr_blits@dmabuf-sync.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-hsw8/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-snb4/igt@gem_userptr_blits@sync-unmap.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-snb2/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([fdo#105763] / [fdo#106538])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-glk6/igt@i915_pm_rpm@modeset-stress-extra-wait.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
* igt@i915_pm_rpm@universal-planes:
- shard-skl: [PASS][19] -> [DMESG-WARN][20] ([fdo#105541])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl6/igt@i915_pm_rpm@universal-planes.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl1/igt@i915_pm_rpm@universal-planes.html
* igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen:
- shard-skl: [PASS][21] -> [FAIL][22] ([fdo#103232]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html
* igt@kms_flip@2x-dpms-vs-vblank-race:
- shard-hsw: [PASS][23] -> [DMESG-WARN][24] ([fdo#102614])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-hsw8/igt@kms_flip@2x-dpms-vs-vblank-race.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-hsw5/igt@kms_flip@2x-dpms-vs-vblank-race.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-tglb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-skl: [PASS][33] -> [INCOMPLETE][34] ([fdo#104108])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl10/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl10/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][35] -> [FAIL][36] ([fdo#103166])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@psr2_suspend:
- shard-tglb: [PASS][39] -> [DMESG-WARN][40] ([fdo#111600])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb3/igt@kms_psr@psr2_suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb8/igt@kms_psr@psr2_suspend.html
* igt@kms_psr@suspend:
- shard-tglb: [PASS][41] -> [INCOMPLETE][42] ([fdo#111832] / [fdo#111850]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@kms_psr@suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@kms_psr@suspend.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][43] ([fdo#108566]) -> [PASS][44] +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
- shard-tglb: [INCOMPLETE][45] ([fdo#111832]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb1/igt@gem_ctx_isolation@rcs0-s3.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb9/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [SKIP][47] ([fdo#109276] / [fdo#112080]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][49] ([fdo#110841]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_ctx_switch@vcs1-heavy:
- shard-iclb: [SKIP][51] ([fdo#112080]) -> [PASS][52] +9 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb8/igt@gem_ctx_switch@vcs1-heavy.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@gem_ctx_switch@vcs1-heavy.html
* igt@gem_eio@reset-stress:
- shard-tglb: [INCOMPLETE][53] ([fdo#111867]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@gem_eio@reset-stress.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb7/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][55] ([fdo#110854]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@gem_exec_balancer@smoke.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb2/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@preempt-queue-blt:
- shard-tglb: [INCOMPLETE][57] ([fdo#111677]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb6/igt@gem_exec_schedule@preempt-queue-blt.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb1/igt@gem_exec_schedule@preempt-queue-blt.html
* igt@gem_exec_schedule@preempt-queue-chain-bsd1:
- shard-tglb: [INCOMPLETE][59] ([fdo#111606] / [fdo#111677]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb1/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][61] ([fdo#112146]) -> [PASS][62] +4 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb2/igt@gem_exec_schedule@preemptive-hang-bsd.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb3/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [INCOMPLETE][63] ([fdo#111736] / [fdo#111850]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb8/igt@gem_exec_suspend@basic-s3.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [FAIL][65] ([fdo#112037]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_userptr_blits@sync-unmap:
- shard-hsw: [DMESG-WARN][67] ([fdo#111870]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-hsw6/igt@gem_userptr_blits@sync-unmap.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-hsw5/igt@gem_userptr_blits@sync-unmap.html
* igt@kms_color@pipe-a-ctm-red-to-blue:
- shard-skl: [DMESG-WARN][69] ([fdo#106107]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl10/igt@kms_color@pipe-a-ctm-red-to-blue.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl10/igt@kms_color@pipe-a-ctm-red-to-blue.html
* igt@kms_cursor_crc@pipe-c-cursor-size-change:
- shard-skl: [FAIL][71] ([fdo#103232]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-size-change.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-size-change.html
* igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
- shard-skl: [DMESG-WARN][73] ([fdo#105541]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl8/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl6/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][75] ([fdo#105363]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl9/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [FAIL][77] ([fdo#103167]) -> [PASS][78] +6 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +4 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-tglb: [INCOMPLETE][81] ([fdo#111832] / [fdo#111850]) -> [PASS][82] +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][83] ([fdo#108145]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][85] ([fdo#108145] / [fdo#110403]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][87] ([fdo#109441]) -> [PASS][88] +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_cpu.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][89] ([fdo#99912]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-apl7/igt@kms_setmode@basic.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-apl8/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][91] ([fdo#111850]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb1/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb2/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [INCOMPLETE][93] ([fdo#104108]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][95] ([fdo#109276]) -> [PASS][96] +16 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@prime_busy@hang-bsd2.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][97] ([fdo#109276] / [fdo#112080]) -> [FAIL][98] ([fdo#111329])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs2-clean:
- shard-tglb: [SKIP][99] ([fdo#111912] / [fdo#112080]) -> [SKIP][100] ([fdo#112080])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb1/igt@gem_ctx_isolation@vcs2-clean.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb9/igt@gem_ctx_isolation@vcs2-clean.html
* igt@gem_ctx_isolation@vcs2-reset:
- shard-tglb: [SKIP][101] ([fdo#112080]) -> [SKIP][102] ([fdo#111912] / [fdo#112080])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@gem_ctx_isolation@vcs2-reset.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb7/igt@gem_ctx_isolation@vcs2-reset.html
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][103] ([fdo#105411]) -> [DMESG-WARN][104] ([fdo# 112000 ] / [fdo#111781])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-snb7/igt@gem_eio@kms.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-snb5/igt@gem_eio@kms.html
* igt@gem_exec_schedule@deep-blt:
- shard-tglb: [FAIL][105] ([fdo#111646]) -> [INCOMPLETE][106] ([fdo#111671])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb8/igt@gem_exec_schedule@deep-blt.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb7/igt@gem_exec_schedule@deep-blt.html
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [FAIL][107] ([fdo#111330]) -> [SKIP][108] ([fdo#109276])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb4/igt@gem_mocs_settings@mocs-isolation-bsd2.html
[1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 0:28 [PATCH] drm/i915: Fix a bug calling sleep function in atomic context Bruce Chang
` (2 preceding siblings ...)
2019-11-13 13:25 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-11-13 19:32 ` Brian Welty
2019-11-13 19:32 ` [Intel-gfx] " Brian Welty
3 siblings, 1 reply; 14+ messages in thread
From: Brian Welty @ 2019-11-13 19:32 UTC (permalink / raw)
To: Bruce Chang, intel-gfx
On 11/12/2019 4:28 PM, Bruce Chang wrote:
> There are quite a few reports regarding "BUG: sleeping function called from
> invalid context at mm/page_alloc.c"
>
> Basically after the io_mapping_map_atomic_wc/kmap_atomic, it enters atomic
> context, but compress_page cannot be called in atomic context as it will
> call pool_alloc with GFP_KERNEL flag which can go to sleep. This is why
> the bug got reported.
>
> So, changed to non atomic version instead.
The atomic functions were recently added, so seems worth a note that
you are fixing that patch by adding:
Fixes: 895d8ebeaa924 ("drm/i915: error capture with no ggtt slot")
And your fix here looks correct to me, so:
Reviewed-by: Brian Welty <brian.welty@intel.com>
>
> Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gpu_error.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 1f2f266f26af..7118ecb7f144 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1007,67 +1007,67 @@ i915_error_object_create(struct drm_i915_private *i915,
> compress->wc = i915_gem_object_is_lmem(vma->obj) ||
> drm_mm_node_allocated(&ggtt->error_capture);
>
> ret = -EINVAL;
> if (drm_mm_node_allocated(&ggtt->error_capture)) {
> void __iomem *s;
> dma_addr_t dma;
>
> for_each_sgt_daddr(dma, iter, vma->pages) {
> ggtt->vm.insert_page(&ggtt->vm, dma, slot,
> I915_CACHE_NONE, 0);
>
> s = io_mapping_map_wc(&ggtt->iomap, slot, PAGE_SIZE);
> ret = compress_page(compress, (void __force *)s, dst);
> io_mapping_unmap(s);
> if (ret)
> break;
> }
> } else if (i915_gem_object_is_lmem(vma->obj)) {
> struct intel_memory_region *mem = vma->obj->mm.region;
> dma_addr_t dma;
>
> for_each_sgt_daddr(dma, iter, vma->pages) {
> void __iomem *s;
>
> - s = io_mapping_map_atomic_wc(&mem->iomap, dma);
> + s = io_mapping_map_wc(&mem->iomap, dma, PAGE_SIZE);
> ret = compress_page(compress, (void __force *)s, dst);
> - io_mapping_unmap_atomic(s);
> + io_mapping_unmap(s);
> if (ret)
> break;
> }
> } else {
> struct page *page;
>
> for_each_sgt_page(page, iter, vma->pages) {
> void *s;
>
> drm_clflush_pages(&page, 1);
>
> - s = kmap_atomic(page);
> + s = kmap(page);
> ret = compress_page(compress, s, dst);
> - kunmap_atomic(s);
> + kunmap(s);
>
> drm_clflush_pages(&page, 1);
>
> if (ret)
> break;
> }
> }
>
> if (ret || compress_flush(compress, dst)) {
> while (dst->page_count--)
> pool_free(&compress->pool, dst->pages[dst->page_count]);
> kfree(dst);
> dst = NULL;
> }
> compress_finish(compress);
>
> return dst;
> }
>
> /*
> * Generate a semi-unique error code. The code is not meant to have meaning, The
> * code's only purpose is to try to prevent false duplicated bug reports by
> * grossly estimating a GPU error state.
> *
> * TODO Ideally, hashing the batchbuffer would be a very nice way to determine
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 19:32 ` [PATCH] " Brian Welty
@ 2019-11-13 19:32 ` Brian Welty
0 siblings, 0 replies; 14+ messages in thread
From: Brian Welty @ 2019-11-13 19:32 UTC (permalink / raw)
To: Bruce Chang, intel-gfx
On 11/12/2019 4:28 PM, Bruce Chang wrote:
> There are quite a few reports regarding "BUG: sleeping function called from
> invalid context at mm/page_alloc.c"
>
> Basically after the io_mapping_map_atomic_wc/kmap_atomic, it enters atomic
> context, but compress_page cannot be called in atomic context as it will
> call pool_alloc with GFP_KERNEL flag which can go to sleep. This is why
> the bug got reported.
>
> So, changed to non atomic version instead.
The atomic functions were recently added, so seems worth a note that
you are fixing that patch by adding:
Fixes: 895d8ebeaa924 ("drm/i915: error capture with no ggtt slot")
And your fix here looks correct to me, so:
Reviewed-by: Brian Welty <brian.welty@intel.com>
>
> Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gpu_error.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 1f2f266f26af..7118ecb7f144 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1007,67 +1007,67 @@ i915_error_object_create(struct drm_i915_private *i915,
> compress->wc = i915_gem_object_is_lmem(vma->obj) ||
> drm_mm_node_allocated(&ggtt->error_capture);
>
> ret = -EINVAL;
> if (drm_mm_node_allocated(&ggtt->error_capture)) {
> void __iomem *s;
> dma_addr_t dma;
>
> for_each_sgt_daddr(dma, iter, vma->pages) {
> ggtt->vm.insert_page(&ggtt->vm, dma, slot,
> I915_CACHE_NONE, 0);
>
> s = io_mapping_map_wc(&ggtt->iomap, slot, PAGE_SIZE);
> ret = compress_page(compress, (void __force *)s, dst);
> io_mapping_unmap(s);
> if (ret)
> break;
> }
> } else if (i915_gem_object_is_lmem(vma->obj)) {
> struct intel_memory_region *mem = vma->obj->mm.region;
> dma_addr_t dma;
>
> for_each_sgt_daddr(dma, iter, vma->pages) {
> void __iomem *s;
>
> - s = io_mapping_map_atomic_wc(&mem->iomap, dma);
> + s = io_mapping_map_wc(&mem->iomap, dma, PAGE_SIZE);
> ret = compress_page(compress, (void __force *)s, dst);
> - io_mapping_unmap_atomic(s);
> + io_mapping_unmap(s);
> if (ret)
> break;
> }
> } else {
> struct page *page;
>
> for_each_sgt_page(page, iter, vma->pages) {
> void *s;
>
> drm_clflush_pages(&page, 1);
>
> - s = kmap_atomic(page);
> + s = kmap(page);
> ret = compress_page(compress, s, dst);
> - kunmap_atomic(s);
> + kunmap(s);
>
> drm_clflush_pages(&page, 1);
>
> if (ret)
> break;
> }
> }
>
> if (ret || compress_flush(compress, dst)) {
> while (dst->page_count--)
> pool_free(&compress->pool, dst->pages[dst->page_count]);
> kfree(dst);
> dst = NULL;
> }
> compress_finish(compress);
>
> return dst;
> }
>
> /*
> * Generate a semi-unique error code. The code is not meant to have meaning, The
> * code's only purpose is to try to prevent false duplicated bug reports by
> * grossly estimating a GPU error state.
> *
> * TODO Ideally, hashing the batchbuffer would be a very nice way to determine
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix a bug calling sleep function in atomic context
2019-11-18 15:59 ` Jani Nikula
@ 2019-11-18 15:59 ` Jani Nikula
0 siblings, 0 replies; 14+ messages in thread
From: Jani Nikula @ 2019-11-18 15:59 UTC (permalink / raw)
To: Bruce Chang, intel-gfx
On Wed, 13 Nov 2019, Bruce Chang <yu.bruce.chang@intel.com> wrote:
> below is the call trace when this issue is hit
>
> <3> [113.316247] BUG: sleeping function called from invalid context at mm/page_alloc.c:4653
> <3> [113.318190] in_atomic(): 1, irqs_disabled(): 0, pid: 678, name: debugfs_test
> <4> [113.319900] no locks held by debugfs_test/678.
> <3> [113.321002] Preemption disabled at:
> <4> [113.321130] [<ffffffffa02506d4>] i915_error_object_create+0x494/0x610 [i915]
> <4> [113.327259] Call Trace:
> <4> [113.327871] dump_stack+0x67/0x9b
> <4> [113.328683] ___might_sleep+0x167/0x250
> <4> [113.329618] __alloc_pages_nodemask+0x26b/0x1110
> <4> [113.330731] ? ___slab_alloc.constprop.34+0x21c/0x380
> <4> [113.331943] ? ___slab_alloc.constprop.34+0x21c/0x380
> <4> [113.333169] ? __slab_alloc.isra.28.constprop.33+0x4d/0x70
> <4> [113.334614] pool_alloc.constprop.19+0x14/0x60 [i915]
> <4> [113.335951] compress_page+0x7c/0x100 [i915]
> <4> [113.337110] i915_error_object_create+0x4bd/0x610 [i915]
> <4> [113.338515] i915_capture_gpu_state+0x384/0x1680 [i915]
> <4> [113.339771] ? __lock_acquire+0x4ac/0x1e90
> <4> [113.340785] ? _raw_spin_lock_irqsave_nested+0x1/0x50
> <4> [113.342127] i915_gpu_info_open+0x44/0x70 [i915]
> <4> [113.343243] full_proxy_open+0x139/0x1b0
> <4> [113.344196] ? open_proxy_open+0xc0/0xc0
> <4> [113.345149] do_dentry_open+0x1ce/0x3a0
> <4> [113.346084] path_openat+0x4c9/0xac0
> <4> [113.346967] do_filp_open+0x96/0x110
> <4> [113.347848] ? __alloc_fd+0xe0/0x1f0
> <4> [113.348736] ? do_sys_open+0x1b8/0x250
> <4> [113.349647] do_sys_open+0x1b8/0x250
> <4> [113.350526] do_syscall_64+0x55/0x1c0
> <4> [113.351418] entry_SYSCALL_64_after_hwframe+0x49/0xbe
>
> After the io_mapping_map_atomic_wc/kmap_atomic, the kernel enters atomic context
> but after that, compress_page calls pool_alloc with GFP_KERNEL flag which can
> potentially go to sleep. When the kernel is in atomic context, sleeping is not
> allowed. This is why this bug got triggered.
>
> In order to fix this issue, we either
> 1) not enter into atomic context, i.e., to use non atomic version of
> functions like io_mapping_map_wc/kmap,
> or
> 2) make compress_page run in atomic context.
>
> But it is not a good idea to run slow compression in atomic context, so,
> 1) above is preferred solution which is the implementation of this patch.
>
> Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
> Reviewed-by: Brian Welty <brian.welty@intel.com>
> Fixes: 895d8ebeaa924 ("drm/i915: error capture with no ggtt slot")
> ---
> drivers/gpu/drm/i915/i915_gpu_error.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 1f2f266f26af..7118ecb7f144 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1007,67 +1007,67 @@ i915_error_object_create(struct drm_i915_private *i915,
> compress->wc = i915_gem_object_is_lmem(vma->obj) ||
> drm_mm_node_allocated(&ggtt->error_capture);
>
> ret = -EINVAL;
> if (drm_mm_node_allocated(&ggtt->error_capture)) {
> void __iomem *s;
> dma_addr_t dma;
>
> for_each_sgt_daddr(dma, iter, vma->pages) {
> ggtt->vm.insert_page(&ggtt->vm, dma, slot,
> I915_CACHE_NONE, 0);
>
> s = io_mapping_map_wc(&ggtt->iomap, slot, PAGE_SIZE);
> ret = compress_page(compress, (void __force *)s, dst);
> io_mapping_unmap(s);
> if (ret)
> break;
> }
> } else if (i915_gem_object_is_lmem(vma->obj)) {
> struct intel_memory_region *mem = vma->obj->mm.region;
> dma_addr_t dma;
>
> for_each_sgt_daddr(dma, iter, vma->pages) {
> void __iomem *s;
>
> - s = io_mapping_map_atomic_wc(&mem->iomap, dma);
> + s = io_mapping_map_wc(&mem->iomap, dma, PAGE_SIZE);
> ret = compress_page(compress, (void __force *)s, dst);
> - io_mapping_unmap_atomic(s);
> + io_mapping_unmap(s);
> if (ret)
> break;
> }
> } else {
> struct page *page;
>
> for_each_sgt_page(page, iter, vma->pages) {
> void *s;
>
> drm_clflush_pages(&page, 1);
>
> - s = kmap_atomic(page);
> + s = kmap(page);
> ret = compress_page(compress, s, dst);
> - kunmap_atomic(s);
> + kunmap(s);
>
> drm_clflush_pages(&page, 1);
>
> if (ret)
> break;
> }
> }
>
> if (ret || compress_flush(compress, dst)) {
> while (dst->page_count--)
> pool_free(&compress->pool, dst->pages[dst->page_count]);
> kfree(dst);
> dst = NULL;
> }
> compress_finish(compress);
>
> return dst;
> }
>
> /*
> * Generate a semi-unique error code. The code is not meant to have meaning, The
> * code's only purpose is to try to prevent false duplicated bug reports by
> * grossly estimating a GPU error state.
> *
> * TODO Ideally, hashing the batchbuffer would be a very nice way to determine
For future reference, please just use the default patch context size.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 23:25 Bruce Chang
@ 2019-11-13 23:25 ` Bruce Chang
0 siblings, 0 replies; 14+ messages in thread
From: Bruce Chang @ 2019-11-13 23:25 UTC (permalink / raw)
To: intel-gfx
below is the call trace when this issue is hit
<3> [113.316247] BUG: sleeping function called from invalid context at mm/page_alloc.c:4653
<3> [113.318190] in_atomic(): 1, irqs_disabled(): 0, pid: 678, name: debugfs_test
<4> [113.319900] no locks held by debugfs_test/678.
<3> [113.321002] Preemption disabled at:
<4> [113.321130] [<ffffffffa02506d4>] i915_error_object_create+0x494/0x610 [i915]
<4> [113.327259] Call Trace:
<4> [113.327871] dump_stack+0x67/0x9b
<4> [113.328683] ___might_sleep+0x167/0x250
<4> [113.329618] __alloc_pages_nodemask+0x26b/0x1110
<4> [113.330731] ? ___slab_alloc.constprop.34+0x21c/0x380
<4> [113.331943] ? ___slab_alloc.constprop.34+0x21c/0x380
<4> [113.333169] ? __slab_alloc.isra.28.constprop.33+0x4d/0x70
<4> [113.334614] pool_alloc.constprop.19+0x14/0x60 [i915]
<4> [113.335951] compress_page+0x7c/0x100 [i915]
<4> [113.337110] i915_error_object_create+0x4bd/0x610 [i915]
<4> [113.338515] i915_capture_gpu_state+0x384/0x1680 [i915]
<4> [113.339771] ? __lock_acquire+0x4ac/0x1e90
<4> [113.340785] ? _raw_spin_lock_irqsave_nested+0x1/0x50
<4> [113.342127] i915_gpu_info_open+0x44/0x70 [i915]
<4> [113.343243] full_proxy_open+0x139/0x1b0
<4> [113.344196] ? open_proxy_open+0xc0/0xc0
<4> [113.345149] do_dentry_open+0x1ce/0x3a0
<4> [113.346084] path_openat+0x4c9/0xac0
<4> [113.346967] do_filp_open+0x96/0x110
<4> [113.347848] ? __alloc_fd+0xe0/0x1f0
<4> [113.348736] ? do_sys_open+0x1b8/0x250
<4> [113.349647] do_sys_open+0x1b8/0x250
<4> [113.350526] do_syscall_64+0x55/0x1c0
<4> [113.351418] entry_SYSCALL_64_after_hwframe+0x49/0xbe
After the io_mapping_map_atomic_wc/kmap_atomic, the kernel enters atomic context
but after that, compress_page calls pool_alloc with GFP_KERNEL flag which can
potentially go to sleep.
In order to fix this issue, we either
1) not enter into atomic context, i.e., to use non atomic version of
functions like io_mapping_map_wc/kmap,
or
2) make compress_page run in atomic context.
To follow current design not to run compression in atomic context, so,
use 1) above in this patch.
Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
Reviewed-by: Brian Welty <brian.welty@intel.com>
Fixes: 895d8ebeaa924 ("drm/i915: error capture with no ggtt slot")
---
drivers/gpu/drm/i915/i915_gpu_error.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 1f2f266f26af..7118ecb7f144 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1007,67 +1007,67 @@ i915_error_object_create(struct drm_i915_private *i915,
compress->wc = i915_gem_object_is_lmem(vma->obj) ||
drm_mm_node_allocated(&ggtt->error_capture);
ret = -EINVAL;
if (drm_mm_node_allocated(&ggtt->error_capture)) {
void __iomem *s;
dma_addr_t dma;
for_each_sgt_daddr(dma, iter, vma->pages) {
ggtt->vm.insert_page(&ggtt->vm, dma, slot,
I915_CACHE_NONE, 0);
s = io_mapping_map_wc(&ggtt->iomap, slot, PAGE_SIZE);
ret = compress_page(compress, (void __force *)s, dst);
io_mapping_unmap(s);
if (ret)
break;
}
} else if (i915_gem_object_is_lmem(vma->obj)) {
struct intel_memory_region *mem = vma->obj->mm.region;
dma_addr_t dma;
for_each_sgt_daddr(dma, iter, vma->pages) {
void __iomem *s;
- s = io_mapping_map_atomic_wc(&mem->iomap, dma);
+ s = io_mapping_map_wc(&mem->iomap, dma, PAGE_SIZE);
ret = compress_page(compress, (void __force *)s, dst);
- io_mapping_unmap_atomic(s);
+ io_mapping_unmap(s);
if (ret)
break;
}
} else {
struct page *page;
for_each_sgt_page(page, iter, vma->pages) {
void *s;
drm_clflush_pages(&page, 1);
- s = kmap_atomic(page);
+ s = kmap(page);
ret = compress_page(compress, s, dst);
- kunmap_atomic(s);
+ kunmap(s);
drm_clflush_pages(&page, 1);
if (ret)
break;
}
}
if (ret || compress_flush(compress, dst)) {
while (dst->page_count--)
pool_free(&compress->pool, dst->pages[dst->page_count]);
kfree(dst);
dst = NULL;
}
compress_finish(compress);
return dst;
}
/*
* Generate a semi-unique error code. The code is not meant to have meaning, The
* code's only purpose is to try to prevent false duplicated bug reports by
* grossly estimating a GPU error state.
*
* TODO Ideally, hashing the batchbuffer would be a very nice way to determine
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 23:20 ` Chris Wilson
@ 2019-11-13 23:20 ` Chris Wilson
0 siblings, 0 replies; 14+ messages in thread
From: Chris Wilson @ 2019-11-13 23:20 UTC (permalink / raw)
To: Bruce Chang, intel-gfx
Quoting Bruce Chang (2019-11-13 23:11:04)
> below is the call trace when this issue is hit
>
> <3> [113.316247] BUG: sleeping function called from invalid context at mm/page_alloc.c:4653
> <3> [113.318190] in_atomic(): 1, irqs_disabled(): 0, pid: 678, name: debugfs_test
> <4> [113.319900] no locks held by debugfs_test/678.
> <3> [113.321002] Preemption disabled at:
> <4> [113.321130] [<ffffffffa02506d4>] i915_error_object_create+0x494/0x610 [i915]
> <4> [113.327259] Call Trace:
> <4> [113.327871] dump_stack+0x67/0x9b
> <4> [113.328683] ___might_sleep+0x167/0x250
> <4> [113.329618] __alloc_pages_nodemask+0x26b/0x1110
> <4> [113.330731] ? ___slab_alloc.constprop.34+0x21c/0x380
> <4> [113.331943] ? ___slab_alloc.constprop.34+0x21c/0x380
> <4> [113.333169] ? __slab_alloc.isra.28.constprop.33+0x4d/0x70
> <4> [113.334614] pool_alloc.constprop.19+0x14/0x60 [i915]
> <4> [113.335951] compress_page+0x7c/0x100 [i915]
> <4> [113.337110] i915_error_object_create+0x4bd/0x610 [i915]
> <4> [113.338515] i915_capture_gpu_state+0x384/0x1680 [i915]
> <4> [113.339771] ? __lock_acquire+0x4ac/0x1e90
> <4> [113.340785] ? _raw_spin_lock_irqsave_nested+0x1/0x50
> <4> [113.342127] i915_gpu_info_open+0x44/0x70 [i915]
> <4> [113.343243] full_proxy_open+0x139/0x1b0
> <4> [113.344196] ? open_proxy_open+0xc0/0xc0
> <4> [113.345149] do_dentry_open+0x1ce/0x3a0
> <4> [113.346084] path_openat+0x4c9/0xac0
> <4> [113.346967] do_filp_open+0x96/0x110
> <4> [113.347848] ? __alloc_fd+0xe0/0x1f0
> <4> [113.348736] ? do_sys_open+0x1b8/0x250
> <4> [113.349647] do_sys_open+0x1b8/0x250
> <4> [113.350526] do_syscall_64+0x55/0x1c0
> <4> [113.351418] entry_SYSCALL_64_after_hwframe+0x49/0xbe
>
> After the io_mapping_map_atomic_wc/kmap_atomic, the kernel enters atomic context
> but after that, compress_page calls pool_alloc with GFP_KERNEL flag which can
> potentially go to sleep. When the kernel is in atomic context, sleeping is not
> allowed. This is why this bug got triggered.
The last 2 sentences are redundant.
> In order to fix this issue, we either
> 1) not enter into atomic context, i.e., to use non atomic version of
> functions like io_mapping_map_wc/kmap,
> or
> 2) make compress_page run in atomic context.
>
> But it is not a good idea to run slow compression in atomic context, so,
> 1) above is preferred solution which is the implementation of this patch.
Reasonable, though we have and may have to do capture inside atomic
again. (Dropping the atomicity is a recent change that has a surprising
amount of controversy.)
> Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
> Reviewed-by: Brian Welty <brian.welty@intel.com>
> Fixes: 895d8ebeaa924 ("drm/i915: error capture with no ggtt slot")
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 23:11 Bruce Chang
@ 2019-11-13 23:11 ` Bruce Chang
2019-11-13 23:20 ` Chris Wilson
2019-11-18 15:59 ` Jani Nikula
2 siblings, 0 replies; 14+ messages in thread
From: Bruce Chang @ 2019-11-13 23:11 UTC (permalink / raw)
To: intel-gfx
below is the call trace when this issue is hit
<3> [113.316247] BUG: sleeping function called from invalid context at mm/page_alloc.c:4653
<3> [113.318190] in_atomic(): 1, irqs_disabled(): 0, pid: 678, name: debugfs_test
<4> [113.319900] no locks held by debugfs_test/678.
<3> [113.321002] Preemption disabled at:
<4> [113.321130] [<ffffffffa02506d4>] i915_error_object_create+0x494/0x610 [i915]
<4> [113.327259] Call Trace:
<4> [113.327871] dump_stack+0x67/0x9b
<4> [113.328683] ___might_sleep+0x167/0x250
<4> [113.329618] __alloc_pages_nodemask+0x26b/0x1110
<4> [113.330731] ? ___slab_alloc.constprop.34+0x21c/0x380
<4> [113.331943] ? ___slab_alloc.constprop.34+0x21c/0x380
<4> [113.333169] ? __slab_alloc.isra.28.constprop.33+0x4d/0x70
<4> [113.334614] pool_alloc.constprop.19+0x14/0x60 [i915]
<4> [113.335951] compress_page+0x7c/0x100 [i915]
<4> [113.337110] i915_error_object_create+0x4bd/0x610 [i915]
<4> [113.338515] i915_capture_gpu_state+0x384/0x1680 [i915]
<4> [113.339771] ? __lock_acquire+0x4ac/0x1e90
<4> [113.340785] ? _raw_spin_lock_irqsave_nested+0x1/0x50
<4> [113.342127] i915_gpu_info_open+0x44/0x70 [i915]
<4> [113.343243] full_proxy_open+0x139/0x1b0
<4> [113.344196] ? open_proxy_open+0xc0/0xc0
<4> [113.345149] do_dentry_open+0x1ce/0x3a0
<4> [113.346084] path_openat+0x4c9/0xac0
<4> [113.346967] do_filp_open+0x96/0x110
<4> [113.347848] ? __alloc_fd+0xe0/0x1f0
<4> [113.348736] ? do_sys_open+0x1b8/0x250
<4> [113.349647] do_sys_open+0x1b8/0x250
<4> [113.350526] do_syscall_64+0x55/0x1c0
<4> [113.351418] entry_SYSCALL_64_after_hwframe+0x49/0xbe
After the io_mapping_map_atomic_wc/kmap_atomic, the kernel enters atomic context
but after that, compress_page calls pool_alloc with GFP_KERNEL flag which can
potentially go to sleep. When the kernel is in atomic context, sleeping is not
allowed. This is why this bug got triggered.
In order to fix this issue, we either
1) not enter into atomic context, i.e., to use non atomic version of
functions like io_mapping_map_wc/kmap,
or
2) make compress_page run in atomic context.
But it is not a good idea to run slow compression in atomic context, so,
1) above is preferred solution which is the implementation of this patch.
Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
Reviewed-by: Brian Welty <brian.welty@intel.com>
Fixes: 895d8ebeaa924 ("drm/i915: error capture with no ggtt slot")
---
drivers/gpu/drm/i915/i915_gpu_error.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 1f2f266f26af..7118ecb7f144 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1007,67 +1007,67 @@ i915_error_object_create(struct drm_i915_private *i915,
compress->wc = i915_gem_object_is_lmem(vma->obj) ||
drm_mm_node_allocated(&ggtt->error_capture);
ret = -EINVAL;
if (drm_mm_node_allocated(&ggtt->error_capture)) {
void __iomem *s;
dma_addr_t dma;
for_each_sgt_daddr(dma, iter, vma->pages) {
ggtt->vm.insert_page(&ggtt->vm, dma, slot,
I915_CACHE_NONE, 0);
s = io_mapping_map_wc(&ggtt->iomap, slot, PAGE_SIZE);
ret = compress_page(compress, (void __force *)s, dst);
io_mapping_unmap(s);
if (ret)
break;
}
} else if (i915_gem_object_is_lmem(vma->obj)) {
struct intel_memory_region *mem = vma->obj->mm.region;
dma_addr_t dma;
for_each_sgt_daddr(dma, iter, vma->pages) {
void __iomem *s;
- s = io_mapping_map_atomic_wc(&mem->iomap, dma);
+ s = io_mapping_map_wc(&mem->iomap, dma, PAGE_SIZE);
ret = compress_page(compress, (void __force *)s, dst);
- io_mapping_unmap_atomic(s);
+ io_mapping_unmap(s);
if (ret)
break;
}
} else {
struct page *page;
for_each_sgt_page(page, iter, vma->pages) {
void *s;
drm_clflush_pages(&page, 1);
- s = kmap_atomic(page);
+ s = kmap(page);
ret = compress_page(compress, s, dst);
- kunmap_atomic(s);
+ kunmap(s);
drm_clflush_pages(&page, 1);
if (ret)
break;
}
}
if (ret || compress_flush(compress, dst)) {
while (dst->page_count--)
pool_free(&compress->pool, dst->pages[dst->page_count]);
kfree(dst);
dst = NULL;
}
compress_finish(compress);
return dst;
}
/*
* Generate a semi-unique error code. The code is not meant to have meaning, The
* code's only purpose is to try to prevent false duplicated bug reports by
* grossly estimating a GPU error state.
*
* TODO Ideally, hashing the batchbuffer would be a very nice way to determine
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 20:05 ` Chris Wilson
@ 2019-11-13 20:05 ` Chris Wilson
0 siblings, 0 replies; 14+ messages in thread
From: Chris Wilson @ 2019-11-13 20:05 UTC (permalink / raw)
To: Bruce Chang, intel-gfx
Quoting Bruce Chang (2019-11-13 19:52:44)
> There are quite a few reports regarding "BUG: sleeping function called from
> invalid context at mm/page_alloc.c"
>
> Basically after the io_mapping_map_atomic_wc/kmap_atomic, it enters atomic
> context, but compress_page cannot be called in atomic context as it will
> call pool_alloc with GFP_KERNEL flag which can go to sleep. This is why
> the bug got reported.
Just a trimmed stack trace showing the bug will do fine; as the distance
to might_sleep_if() is short.
Then all you need to do is a quick description of why that is a problem,
and why you choose to fix it as you did. The latter is so that we can
assess if you've considered the alternatives, though in this case it is
trivial although the reason why GFP_KERNEL works for us here is not.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Fix a bug calling sleep function in atomic context
2019-11-13 19:52 Bruce Chang
@ 2019-11-13 19:52 ` Bruce Chang
2019-11-13 20:05 ` Chris Wilson
1 sibling, 0 replies; 14+ messages in thread
From: Bruce Chang @ 2019-11-13 19:52 UTC (permalink / raw)
To: intel-gfx
There are quite a few reports regarding "BUG: sleeping function called from
invalid context at mm/page_alloc.c"
Basically after the io_mapping_map_atomic_wc/kmap_atomic, it enters atomic
context, but compress_page cannot be called in atomic context as it will
call pool_alloc with GFP_KERNEL flag which can go to sleep. This is why
the bug got reported.
So, changed to non atomic version instead.
Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
Reviewed-by: Brian Welty <brian.welty@intel.com>
Fixes: 895d8ebeaa924 ("drm/i915: error capture with no ggtt slot")
---
drivers/gpu/drm/i915/i915_gpu_error.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 1f2f266f26af..7118ecb7f144 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1007,67 +1007,67 @@ i915_error_object_create(struct drm_i915_private *i915,
compress->wc = i915_gem_object_is_lmem(vma->obj) ||
drm_mm_node_allocated(&ggtt->error_capture);
ret = -EINVAL;
if (drm_mm_node_allocated(&ggtt->error_capture)) {
void __iomem *s;
dma_addr_t dma;
for_each_sgt_daddr(dma, iter, vma->pages) {
ggtt->vm.insert_page(&ggtt->vm, dma, slot,
I915_CACHE_NONE, 0);
s = io_mapping_map_wc(&ggtt->iomap, slot, PAGE_SIZE);
ret = compress_page(compress, (void __force *)s, dst);
io_mapping_unmap(s);
if (ret)
break;
}
} else if (i915_gem_object_is_lmem(vma->obj)) {
struct intel_memory_region *mem = vma->obj->mm.region;
dma_addr_t dma;
for_each_sgt_daddr(dma, iter, vma->pages) {
void __iomem *s;
- s = io_mapping_map_atomic_wc(&mem->iomap, dma);
+ s = io_mapping_map_wc(&mem->iomap, dma, PAGE_SIZE);
ret = compress_page(compress, (void __force *)s, dst);
- io_mapping_unmap_atomic(s);
+ io_mapping_unmap(s);
if (ret)
break;
}
} else {
struct page *page;
for_each_sgt_page(page, iter, vma->pages) {
void *s;
drm_clflush_pages(&page, 1);
- s = kmap_atomic(page);
+ s = kmap(page);
ret = compress_page(compress, s, dst);
- kunmap_atomic(s);
+ kunmap(s);
drm_clflush_pages(&page, 1);
if (ret)
break;
}
}
if (ret || compress_flush(compress, dst)) {
while (dst->page_count--)
pool_free(&compress->pool, dst->pages[dst->page_count]);
kfree(dst);
dst = NULL;
}
compress_finish(compress);
return dst;
}
/*
* Generate a semi-unique error code. The code is not meant to have meaning, The
* code's only purpose is to try to prevent false duplicated bug reports by
* grossly estimating a GPU error state.
*
* TODO Ideally, hashing the batchbuffer would be a very nice way to determine
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-11-18 15:59 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 0:28 [PATCH] drm/i915: Fix a bug calling sleep function in atomic context Bruce Chang
2019-11-13 0:28 ` [Intel-gfx] " Bruce Chang
2019-11-13 1:36 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-13 1:36 ` [Intel-gfx] " Patchwork
2019-11-13 13:25 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-13 13:25 ` [Intel-gfx] " Patchwork
2019-11-13 19:32 ` [PATCH] " Brian Welty
2019-11-13 19:32 ` [Intel-gfx] " Brian Welty
2019-11-13 19:52 Bruce Chang
2019-11-13 19:52 ` [Intel-gfx] " Bruce Chang
2019-11-13 20:05 ` Chris Wilson
2019-11-13 20:05 ` [Intel-gfx] " Chris Wilson
2019-11-13 23:11 Bruce Chang
2019-11-13 23:11 ` [Intel-gfx] " Bruce Chang
2019-11-13 23:20 ` Chris Wilson
2019-11-13 23:20 ` [Intel-gfx] " Chris Wilson
2019-11-18 15:59 ` Jani Nikula
2019-11-18 15:59 ` [Intel-gfx] " Jani Nikula
2019-11-13 23:25 Bruce Chang
2019-11-13 23:25 ` [Intel-gfx] " Bruce Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).