* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Add Wa_1606054188;tgl
2020-01-17 9:16 [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl Matt Atwood
@ 2020-01-17 1:00 ` Patchwork
2020-01-17 1:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-01-17 1:00 UTC (permalink / raw)
To: Matt Atwood; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Add Wa_1606054188;tgl
URL : https://patchwork.freedesktop.org/series/72148/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7758 -> Patchwork_16140
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/index.html
Known issues
------------
Here are the changes found in Patchwork_16140 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-7500u: [PASS][1] -> [INCOMPLETE][2] ([i915#879])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-kbl-7500u/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/fi-kbl-7500u/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_selftest@live_coherency:
- fi-cfl-guc: [PASS][3] -> [DMESG-FAIL][4] ([i915#889]) +7 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-cfl-guc/igt@i915_selftest@live_coherency.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/fi-cfl-guc/igt@i915_selftest@live_coherency.html
* igt@i915_selftest@live_gem_contexts:
- fi-hsw-peppy: [PASS][5] -> [DMESG-FAIL][6] ([i915#722])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
* igt@i915_selftest@live_gt_timelines:
- fi-cfl-guc: [PASS][7] -> [DMESG-WARN][8] ([i915#889]) +23 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-cfl-guc/igt@i915_selftest@live_gt_timelines.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/fi-cfl-guc/igt@i915_selftest@live_gt_timelines.html
* igt@kms_chamelium@dp-edid-read:
- fi-kbl-7500u: [PASS][9] -> [FAIL][10] ([fdo#109635] / [i915#217] / [i915#976])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
#### Possible fixes ####
* igt@gem_exec_create@basic:
- fi-icl-dsi: [DMESG-WARN][11] ([i915#109]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-icl-dsi/igt@gem_exec_create@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/fi-icl-dsi/igt@gem_exec_create@basic.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][13] ([i915#553] / [i915#725]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-hsw-4770/igt@i915_selftest@live_blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/fi-hsw-4770/igt@i915_selftest@live_blt.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][15] ([fdo#111096] / [i915#323]) -> [FAIL][16] ([fdo#111407])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#879]: https://gitlab.freedesktop.org/drm/intel/issues/879
[i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
[i915#976]: https://gitlab.freedesktop.org/drm/intel/issues/976
Participating hosts (47 -> 43)
------------------------------
Additional (4): fi-kbl-soraka fi-byt-j1900 fi-byt-n2820 fi-tgl-y
Missing (8): fi-ilk-m540 fi-ehl-1 fi-hsw-4200u fi-skl-6770hq fi-glk-dsi fi-byt-squawks fi-bsw-cyan fi-gdg-551
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7758 -> Patchwork_16140
CI-20190529: 20190529
CI_DRM_7758: d19270ce1f367fbfc1ff3b539bcb50e11ded181f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5371: 1b2816124ec3dbd53b81725d39292f45d41d895b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16140: 7bd0232eb6eccdcde8ee3c919d956c52e6bcf855 @ git://anongit.freedesktop.org/gfx-ci/linux
== Kernel 32bit build ==
Warning: Kernel 32bit buildtest failed:
https://intel-gfx-ci.01.org/Patchwork_16140/build_32bit.log
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
CHK include/generated/compile.h
Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 122 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
scripts/Makefile.modpost:93: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1282: recipe for target 'modules' failed
make: *** [modules] Error 2
== Linux commits ==
7bd0232eb6ec drm/i915/tgl: Add Wa_1606054188;tgl
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/tgl: Add Wa_1606054188;tgl
2020-01-17 9:16 [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl Matt Atwood
2020-01-17 1:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-01-17 1:00 ` Patchwork
2020-01-20 8:01 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-01-17 1:00 UTC (permalink / raw)
To: Matt Atwood; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Add Wa_1606054188;tgl
URL : https://patchwork.freedesktop.org/series/72148/
State : warning
== Summary ==
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
CHK include/generated/compile.h
Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 122 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
scripts/Makefile.modpost:93: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1282: recipe for target 'modules' failed
make: *** [modules] Error 2
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/build_32bit.log
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl
@ 2020-01-17 9:16 Matt Atwood
2020-01-17 1:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Matt Atwood @ 2020-01-17 9:16 UTC (permalink / raw)
To: intel-gfx
On Tiger Lake we do not support source keying in the pixel formats P010,
P012, P016.
Bspec: 52890
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
drivers/gpu/drm/i915/display/intel_sprite.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
index fca77ec1e0dd..67176524e60f 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.c
+++ b/drivers/gpu/drm/i915/display/intel_sprite.c
@@ -2049,6 +2049,19 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
unsigned int rotation = plane_state->hw.rotation;
struct drm_format_name_buf format_name;
+ /* Wa_1606054188;tgl
+ *
+ * TODO: Add format RGB64i when implemented
+ *
+ */
+ if (IS_GEN(dev_priv, 12) &&
+ (plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE))
+ if (fb->format->format & (DRM_FORMAT_P010 | DRM_FORMAT_P012
+ | DRM_FORMAT_P016)) {
+ DRM_DEBUG_KMS("GEN12 does not support source color key planes in formats P01x\n");
+ return -EINVAL;
+ }
+
if (!fb)
return 0;
--
2.21.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add Wa_1606054188;tgl
2020-01-17 9:16 [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl Matt Atwood
2020-01-17 1:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-17 1:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
@ 2020-01-20 8:01 ` Patchwork
2020-01-27 22:42 ` [Intel-gfx] [PATCH] " Manasi Navare
2020-01-28 17:05 ` Ville Syrjälä
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-01-20 8:01 UTC (permalink / raw)
To: Matt Atwood; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Add Wa_1606054188;tgl
URL : https://patchwork.freedesktop.org/series/72148/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7758_full -> Patchwork_16140_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_16140_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +14 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_busy@busy-vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb6/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +10 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_persistence@vcs1-hostile-preempt:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [fdo#112080]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb6/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
* igt@gem_ctx_shared@q-smoketest-blt:
- shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([fdo#111735] / [i915#472])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb1/igt@gem_ctx_shared@q-smoketest-blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb6/igt@gem_ctx_shared@q-smoketest-blt.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-snb: [PASS][9] -> [FAIL][10] ([i915#490])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-snb5/igt@gem_eio@in-flight-contexts-1us.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-snb5/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_balancer@nop:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111736] / [i915#472])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb3/igt@gem_exec_balancer@nop.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb6/igt@gem_exec_balancer@nop.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [PASS][13] -> [SKIP][14] ([i915#677]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb1/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#112146]) +6 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@gem_exec_schedule@preempt-bsd.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb4/igt@gem_exec_schedule@preempt-bsd.html
* igt@gem_exec_schedule@preempt-queue-vebox:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([fdo#111677] / [i915#472])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb3/igt@gem_exec_schedule@preempt-queue-vebox.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb6/igt@gem_exec_schedule@preempt-queue-vebox.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-glk: [PASS][19] -> [TIMEOUT][20] ([fdo#112271] / [i915#530])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-glk3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-glk1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
- shard-kbl: [PASS][21] -> [TIMEOUT][22] ([fdo#112271] / [i915#530])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-kbl6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-kbl: [PASS][23] -> [INCOMPLETE][24] ([fdo#103665] / [i915#530])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl2/igt@gem_persistent_relocs@forked-thrash-inactive.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-kbl6/igt@gem_persistent_relocs@forked-thrash-inactive.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [PASS][25] -> [FAIL][26] ([i915#644])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_sync@basic-store-each:
- shard-tglb: [PASS][27] -> [INCOMPLETE][28] ([i915#472])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb1/igt@gem_sync@basic-store-each.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb7/igt@gem_sync@basic-store-each.html
* igt@i915_pm_rps@waitboost:
- shard-iclb: [PASS][29] -> [FAIL][30] ([i915#413])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb6/igt@i915_pm_rps@waitboost.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb4/igt@i915_pm_rps@waitboost.html
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [PASS][31] -> [INCOMPLETE][32] ([i915#221])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl3/igt@kms_flip@flip-vs-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-skl2/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][33] -> [DMESG-WARN][34] ([i915#180]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-pgflip-blt:
- shard-tglb: [PASS][35] -> [FAIL][36] ([i915#49]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-pgflip-blt.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-pgflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-skl: [PASS][37] -> [INCOMPLETE][38] ([i915#69])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-skl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][39] -> [FAIL][40] ([fdo#108145] / [i915#265])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-snb: [PASS][41] -> [SKIP][42] ([fdo#109271])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-snb1/igt@kms_plane_multiple@atomic-pipe-b-tiling-x.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-snb4/igt@kms_plane_multiple@atomic-pipe-b-tiling-x.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109441])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb6/igt@kms_psr@psr2_primary_page_flip.html
* igt@perf_pmu@enable-race-vecs0:
- shard-tglb: [PASS][45] -> [INCOMPLETE][46] ([i915#470] / [i915#472])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb3/igt@perf_pmu@enable-race-vecs0.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb3/igt@perf_pmu@enable-race-vecs0.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109276]) +23 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@prime_busy@hang-bsd2.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb6/igt@prime_busy@hang-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-kbl: [DMESG-WARN][49] ([i915#180]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl3/igt@gem_ctx_isolation@bcs0-s3.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-kbl6/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_persistence@processes:
- shard-iclb: [FAIL][51] ([i915#570]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_ctx_persistence@processes.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb6/igt@gem_ctx_persistence@processes.html
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [SKIP][53] ([fdo#109276] / [fdo#112080]) -> [PASS][54] +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_ctx_persistence@vcs1-queued.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][55] ([fdo#110841]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb8/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_ctx_shared@q-smoketest-bsd2:
- shard-tglb: [INCOMPLETE][57] ([i915#461] / [i915#472]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb3/igt@gem_ctx_shared@q-smoketest-bsd2.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb8/igt@gem_ctx_shared@q-smoketest-bsd2.html
* igt@gem_ctx_shared@q-smoketest-vebox:
- shard-tglb: [INCOMPLETE][59] ([fdo#111735] / [i915#472]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb6/igt@gem_ctx_shared@q-smoketest-vebox.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb1/igt@gem_ctx_shared@q-smoketest-vebox.html
* igt@gem_eio@kms:
- shard-tglb: [INCOMPLETE][61] ([i915#472] / [i915#476]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb6/igt@gem_eio@kms.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb7/igt@gem_eio@kms.html
* igt@gem_exec_await@wide-contexts:
- shard-tglb: [INCOMPLETE][63] ([fdo#111736] / [i915#472]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb3/igt@gem_exec_await@wide-contexts.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb4/igt@gem_exec_await@wide-contexts.html
* igt@gem_exec_balancer@hang:
- shard-iclb: [INCOMPLETE][65] ([i915#140]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@gem_exec_balancer@hang.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb8/igt@gem_exec_balancer@hang.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][67] ([fdo#110854]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_exec_balancer@smoke.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_create@madvise:
- shard-tglb: [INCOMPLETE][69] ([i915#472]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb4/igt@gem_exec_create@madvise.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb4/igt@gem_exec_create@madvise.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][71] ([fdo#112080]) -> [PASS][72] +13 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_exec_parallel@vcs1-fds.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@pi-common-bsd:
- shard-iclb: [SKIP][73] ([i915#677]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_exec_schedule@pi-common-bsd.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb5/igt@gem_exec_schedule@pi-common-bsd.html
* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [SKIP][75] ([fdo#109276]) -> [PASS][76] +31 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@gem_exec_schedule@preempt-contexts-bsd2.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb2/igt@gem_exec_schedule@preempt-contexts-bsd2.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][77] ([fdo#112146]) -> [PASS][78] +10 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-kbl: [TIMEOUT][79] ([fdo#112271] / [i915#530]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
- shard-hsw: [TIMEOUT][81] ([fdo#112271] / [i915#530]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-hsw7/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-hsw2/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
* igt@gem_persistent_relocs@forked-thrashing:
- shard-kbl: [INCOMPLETE][83] ([fdo#103665] / [i915#530]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl6/igt@gem_persistent_relocs@forked-thrashing.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-kbl4/igt@gem_persistent_relocs@forked-thrashing.html
* igt@gen9_exec_parse@allowed-all:
- shard-skl: [DMESG-WARN][85] ([i915#716]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl8/igt@gen9_exec_parse@allowed-all.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-skl10/igt@gen9_exec_parse@allowed-all.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][87] ([i915#454]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
* {igt@i915_pm_rc6_residency@rc6-idle}:
- shard-apl: [FAIL][89] ([i915#973]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl3/igt@i915_pm_rc6_residency@rc6-idle.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-apl8/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_selftest@live_execlists:
- shard-kbl: [INCOMPLETE][91] ([fdo#103665] / [fdo#112175] / [fdo#112259]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl6/igt@i915_selftest@live_execlists.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-kbl2/igt@i915_selftest@live_execlists.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-apl: [DMESG-WARN][93] ([i915#180]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-apl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding:
- shard-skl: [FAIL][95] ([i915#54]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding.html
* igt@kms_flip@plain-flip-ts-check-interruptible:
- shard-skl: [FAIL][97] ([i915#34]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-skl3/igt@kms_flip@plain-flip-ts-check-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-tglb: [FAIL][99] ([i915#49]) -> [PASS][100] +4 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: [INCOMPLETE][101] ([i915#140] / [i915#250]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][103] ([fdo#108145]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][105] ([fdo#108145] / [i915#265]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][107] ([fdo#109642] / [fdo#111068]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@kms_psr2_su@page_flip.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][109] ([fdo#109441]) -> [PASS][110] +3 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][111] ([IGT#28]) -> [SKIP][112] ([fdo#109276] / [fdo#112080])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-apl: [TIMEOUT][113] ([fdo#112271] / [i915#530]) -> [TIMEOUT][114] ([fdo#112271])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112175]: https://bugs.freedesktop.org/show_bug.cgi?id=112175
[fdo#112259]: https://bugs.freedesktop.org/show_bug.cgi?id=112259
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#461]: https://gitlab.freedesktop.org/drm/intel/issues/461
[i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#490]: https://gitlab.freedesktop.org/drm/intel/issues/490
[i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#570]: https://gitlab.freedesktop.org/drm/intel/issues/570
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#973]: https://gitlab.freedesktop.org/drm/intel/issues/973
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7758 -> Patchwork_16140
CI-20190529: 20190529
CI_DRM_7758: d19270ce1f367fbfc1ff3b539bcb50e11ded181f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5371: 1b2816124ec3dbd53b81725d39292f45d41d895b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16140: 7bd0232eb6eccdcde8ee3c919d956c52e6bcf855 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16140/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl
2020-01-17 9:16 [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl Matt Atwood
` (2 preceding siblings ...)
2020-01-20 8:01 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
@ 2020-01-27 22:42 ` Manasi Navare
2020-01-28 17:05 ` Ville Syrjälä
4 siblings, 0 replies; 10+ messages in thread
From: Manasi Navare @ 2020-01-27 22:42 UTC (permalink / raw)
To: Matt Atwood; +Cc: intel-gfx
On Fri, Jan 17, 2020 at 04:16:28AM -0500, Matt Atwood wrote:
> On Tiger Lake we do not support source keying in the pixel formats P010,
> P012, P016.
>
> Bspec: 52890
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_sprite.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> index fca77ec1e0dd..67176524e60f 100644
> --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> @@ -2049,6 +2049,19 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
> unsigned int rotation = plane_state->hw.rotation;
> struct drm_format_name_buf format_name;
>
> + /* Wa_1606054188;tgl
^ This should be a :
> + *
> + * TODO: Add format RGB64i when implemented
> + *
> + */
> + if (IS_GEN(dev_priv, 12) &&
> + (plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE))
> + if (fb->format->format & (DRM_FORMAT_P010 | DRM_FORMAT_P012
> + | DRM_FORMAT_P016)) {
> + DRM_DEBUG_KMS("GEN12 does not support source color key planes in formats P01x\n");
> + return -EINVAL;
> + }
> +
I think this whole WA and check should be added after the check for !fb else we might have a risk
of dereferencing a NULL pointer.
With the above fixs
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Manasi
> if (!fb)
> return 0;
>
> --
> 2.21.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl
2020-01-17 9:16 [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl Matt Atwood
` (3 preceding siblings ...)
2020-01-27 22:42 ` [Intel-gfx] [PATCH] " Manasi Navare
@ 2020-01-28 17:05 ` Ville Syrjälä
2020-01-28 17:30 ` Ville Syrjälä
4 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2020-01-28 17:05 UTC (permalink / raw)
To: Matt Atwood; +Cc: intel-gfx
On Fri, Jan 17, 2020 at 04:16:28AM -0500, Matt Atwood wrote:
> On Tiger Lake we do not support source keying in the pixel formats P010,
> P012, P016.
>
> Bspec: 52890
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_sprite.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> index fca77ec1e0dd..67176524e60f 100644
> --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> @@ -2049,6 +2049,19 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
> unsigned int rotation = plane_state->hw.rotation;
> struct drm_format_name_buf format_name;
>
> + /* Wa_1606054188;tgl
> + *
> + * TODO: Add format RGB64i when implemented
> + *
> + */
> + if (IS_GEN(dev_priv, 12) &&
> + (plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE))
> + if (fb->format->format & (DRM_FORMAT_P010 | DRM_FORMAT_P012
> + | DRM_FORMAT_P016)) {
if (a && b && c)
Needless parens.
Continuing | should go to the end. Also alignment is borked.
> + DRM_DEBUG_KMS("GEN12 does not support source color key planes in formats P01x\n");
Feels a bit overly verbose:
"Source color keying not supported with P01x formats\n"
> + return -EINVAL;
> + }
> +
> if (!fb)
> return 0;
What Manasi said. In fact pls move the thing to the end of the function
because I have more color key checks queued up in a branch and IIRC
I put them to the very end of the function.
>
> --
> 2.21.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl
2020-01-28 17:05 ` Ville Syrjälä
@ 2020-01-28 17:30 ` Ville Syrjälä
2020-01-28 20:28 ` Manasi Navare
2020-01-28 20:53 ` Manasi Navare
0 siblings, 2 replies; 10+ messages in thread
From: Ville Syrjälä @ 2020-01-28 17:30 UTC (permalink / raw)
To: Matt Atwood; +Cc: intel-gfx
On Tue, Jan 28, 2020 at 07:05:38PM +0200, Ville Syrjälä wrote:
> On Fri, Jan 17, 2020 at 04:16:28AM -0500, Matt Atwood wrote:
> > On Tiger Lake we do not support source keying in the pixel formats P010,
> > P012, P016.
> >
> > Bspec: 52890
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_sprite.c | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> > index fca77ec1e0dd..67176524e60f 100644
> > --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> > @@ -2049,6 +2049,19 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
> > unsigned int rotation = plane_state->hw.rotation;
> > struct drm_format_name_buf format_name;
> >
> > + /* Wa_1606054188;tgl
> > + *
> > + * TODO: Add format RGB64i when implemented
> > + *
> > + */
> > + if (IS_GEN(dev_priv, 12) &&
> > + (plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE))
> > + if (fb->format->format & (DRM_FORMAT_P010 | DRM_FORMAT_P012
> > + | DRM_FORMAT_P016)) {
Oh, and that | stuff is actually just nonsense. That's not a
bitfield or anything like that. I'd just add a small
intel_format_is_p01x() function etc.
>
> if (a && b && c)
>
> Needless parens.
>
> Continuing | should go to the end. Also alignment is borked.
>
> > + DRM_DEBUG_KMS("GEN12 does not support source color key planes in formats P01x\n");
>
> Feels a bit overly verbose:
> "Source color keying not supported with P01x formats\n"
>
> > + return -EINVAL;
> > + }
> > +
> > if (!fb)
> > return 0;
>
> What Manasi said. In fact pls move the thing to the end of the function
> because I have more color key checks queued up in a branch and IIRC
> I put them to the very end of the function.
>
> >
> > --
> > 2.21.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl
2020-01-28 17:30 ` Ville Syrjälä
@ 2020-01-28 20:28 ` Manasi Navare
2020-01-29 11:35 ` Ville Syrjälä
2020-01-28 20:53 ` Manasi Navare
1 sibling, 1 reply; 10+ messages in thread
From: Manasi Navare @ 2020-01-28 20:28 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Tue, Jan 28, 2020 at 07:30:59PM +0200, Ville Syrjälä wrote:
> On Tue, Jan 28, 2020 at 07:05:38PM +0200, Ville Syrjälä wrote:
> > On Fri, Jan 17, 2020 at 04:16:28AM -0500, Matt Atwood wrote:
> > > On Tiger Lake we do not support source keying in the pixel formats P010,
> > > P012, P016.
> > >
> > > Bspec: 52890
> > > Cc: Matt Roper <matthew.d.roper@intel.com>
> > > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_sprite.c | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> > > index fca77ec1e0dd..67176524e60f 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> > > @@ -2049,6 +2049,19 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
> > > unsigned int rotation = plane_state->hw.rotation;
> > > struct drm_format_name_buf format_name;
> > >
> > > + /* Wa_1606054188;tgl
> > > + *
> > > + * TODO: Add format RGB64i when implemented
> > > + *
> > > + */
> > > + if (IS_GEN(dev_priv, 12) &&
> > > + (plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE))
Yes I agree here no need to have paranthesis just
if (IS_GEN(dev_priv, 12) && plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE)
should suffice since bitwise & higher precedence than logical AND
> > > + if (fb->format->format & (DRM_FORMAT_P010 | DRM_FORMAT_P012
> > > + | DRM_FORMAT_P016)) {
>
> Oh, and that | stuff is actually just nonsense. That's not a
> bitfield or anything like that. I'd just add a small
> intel_format_is_p01x() function etc.
Yes I agree with Ville. The DRM_FORMAT_ is a 4CC format identifie not a bitfield
so you would need to define a static function something like:
static bool intel_format_is_p01x()
{
if(format == DRM_FORMAT_P010 ||
format == DRM_FORMAT_P012 ||
format == DRM_FORMAT_P016)
return true;
return false;
}
Look at lookup_format_info() for reference.
Hope this helps.
Manasi
>
> >
> > if (a && b && c)
> >
> > Needless parens.
> >
> > Continuing | should go to the end. Also alignment is borked.
> >
> > > + DRM_DEBUG_KMS("GEN12 does not support source color key planes in formats P01x\n");
> >
> > Feels a bit overly verbose:
> > "Source color keying not supported with P01x formats\n"
> >
> > > + return -EINVAL;
> > > + }
> > > +
> > > if (!fb)
> > > return 0;
> >
> > What Manasi said. In fact pls move the thing to the end of the function
> > because I have more color key checks queued up in a branch and IIRC
> > I put them to the very end of the function.
> >
> > >
> > > --
> > > 2.21.1
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
> > --
> > Ville Syrjälä
> > Intel
>
> --
> Ville Syrjälä
> Intel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl
2020-01-28 17:30 ` Ville Syrjälä
2020-01-28 20:28 ` Manasi Navare
@ 2020-01-28 20:53 ` Manasi Navare
1 sibling, 0 replies; 10+ messages in thread
From: Manasi Navare @ 2020-01-28 20:53 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Tue, Jan 28, 2020 at 07:30:59PM +0200, Ville Syrjälä wrote:
> On Tue, Jan 28, 2020 at 07:05:38PM +0200, Ville Syrjälä wrote:
> > On Fri, Jan 17, 2020 at 04:16:28AM -0500, Matt Atwood wrote:
> > > On Tiger Lake we do not support source keying in the pixel formats P010,
> > > P012, P016.
> > >
> > > Bspec: 52890
> > > Cc: Matt Roper <matthew.d.roper@intel.com>
> > > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_sprite.c | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> > > index fca77ec1e0dd..67176524e60f 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> > > @@ -2049,6 +2049,19 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
> > > unsigned int rotation = plane_state->hw.rotation;
> > > struct drm_format_name_buf format_name;
> > >
> > > + /* Wa_1606054188;tgl
> > > + *
> > > + * TODO: Add format RGB64i when implemented
> > > + *
> > > + */
> > > + if (IS_GEN(dev_priv, 12) &&
> > > + (plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE))
Yes I agree, it should just be :
if (IS_GEN(dev_priv, 12) && plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE)
since bitwise & has higher precedence than logical AND
> > > + if (fb->format->format & (DRM_FORMAT_P010 | DRM_FORMAT_P012
> > > + | DRM_FORMAT_P016)) {
>
> Oh, and that | stuff is actually just nonsense. That's not a
> bitfield or anything like that. I'd just add a small
> intel_format_is_p01x() function etc.
>
Yes that is true here DRM_FORMAT_* is a 4CC format identifier so like Ville
suggested the function to check format should look like:
static bool intel_format_is_p01x()
{
if (format == DRM_FORMAT_P010 ||
format == DRM_FORMAT_P012 ||
format == DRM_FORMAT_P016)
return true;
return false;
}
Hope this helps, you can also look at the lookup_format_info()
Manasi
> >
> > if (a && b && c)
> >
> > Needless parens.
> >
> > Continuing | should go to the end. Also alignment is borked.
> >
> > > + DRM_DEBUG_KMS("GEN12 does not support source color key planes in formats P01x\n");
> >
> > Feels a bit overly verbose:
> > "Source color keying not supported with P01x formats\n"
> >
> > > + return -EINVAL;
> > > + }
> > > +
> > > if (!fb)
> > > return 0;
> >
> > What Manasi said. In fact pls move the thing to the end of the function
> > because I have more color key checks queued up in a branch and IIRC
> > I put them to the very end of the function.
> >
> > >
> > > --
> > > 2.21.1
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
> > --
> > Ville Syrjälä
> > Intel
>
> --
> Ville Syrjälä
> Intel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl
2020-01-28 20:28 ` Manasi Navare
@ 2020-01-29 11:35 ` Ville Syrjälä
0 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2020-01-29 11:35 UTC (permalink / raw)
To: Manasi Navare; +Cc: intel-gfx
On Tue, Jan 28, 2020 at 12:28:35PM -0800, Manasi Navare wrote:
> On Tue, Jan 28, 2020 at 07:30:59PM +0200, Ville Syrjälä wrote:
> > On Tue, Jan 28, 2020 at 07:05:38PM +0200, Ville Syrjälä wrote:
> > > On Fri, Jan 17, 2020 at 04:16:28AM -0500, Matt Atwood wrote:
> > > > On Tiger Lake we do not support source keying in the pixel formats P010,
> > > > P012, P016.
> > > >
> > > > Bspec: 52890
> > > > Cc: Matt Roper <matthew.d.roper@intel.com>
> > > > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/display/intel_sprite.c | 13 +++++++++++++
> > > > 1 file changed, 13 insertions(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> > > > index fca77ec1e0dd..67176524e60f 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> > > > @@ -2049,6 +2049,19 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
> > > > unsigned int rotation = plane_state->hw.rotation;
> > > > struct drm_format_name_buf format_name;
> > > >
> > > > + /* Wa_1606054188;tgl
> > > > + *
> > > > + * TODO: Add format RGB64i when implemented
> > > > + *
> > > > + */
> > > > + if (IS_GEN(dev_priv, 12) &&
> > > > + (plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE))
>
> Yes I agree here no need to have paranthesis just
>
> if (IS_GEN(dev_priv, 12) && plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE)
> should suffice since bitwise & higher precedence than logical AND
>
> > > > + if (fb->format->format & (DRM_FORMAT_P010 | DRM_FORMAT_P012
> > > > + | DRM_FORMAT_P016)) {
> >
> > Oh, and that | stuff is actually just nonsense. That's not a
> > bitfield or anything like that. I'd just add a small
> > intel_format_is_p01x() function etc.
>
> Yes I agree with Ville. The DRM_FORMAT_ is a 4CC format identifie not a bitfield
> so you would need to define a static function something like:
>
> static bool intel_format_is_p01x()
> {
> if(format == DRM_FORMAT_P010 ||
> format == DRM_FORMAT_P012 ||
> format == DRM_FORMAT_P016)
> return true;
switch()
>
> return false;
> }
>
> Look at lookup_format_info() for reference.
> Hope this helps.
>
> Manasi
>
> >
> > >
> > > if (a && b && c)
> > >
> > > Needless parens.
> > >
> > > Continuing | should go to the end. Also alignment is borked.
> > >
> > > > + DRM_DEBUG_KMS("GEN12 does not support source color key planes in formats P01x\n");
> > >
> > > Feels a bit overly verbose:
> > > "Source color keying not supported with P01x formats\n"
> > >
> > > > + return -EINVAL;
> > > > + }
> > > > +
> > > > if (!fb)
> > > > return 0;
> > >
> > > What Manasi said. In fact pls move the thing to the end of the function
> > > because I have more color key checks queued up in a branch and IIRC
> > > I put them to the very end of the function.
> > >
> > > >
> > > > --
> > > > 2.21.1
> > > >
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > Intel-gfx@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > >
> > > --
> > > Ville Syrjälä
> > > Intel
> >
> > --
> > Ville Syrjälä
> > Intel
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-01-29 11:36 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 9:16 [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl Matt Atwood
2020-01-17 1:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-17 1:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-20 8:01 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2020-01-27 22:42 ` [Intel-gfx] [PATCH] " Manasi Navare
2020-01-28 17:05 ` Ville Syrjälä
2020-01-28 17:30 ` Ville Syrjälä
2020-01-28 20:28 ` Manasi Navare
2020-01-29 11:35 ` Ville Syrjälä
2020-01-28 20:53 ` Manasi Navare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).