[Intel-gfx] [PATCH] softirq: Kick ksoftirqd if __do_softirq() is incomplete

* [Intel-gfx] [PATCH] softirq: Kick ksoftirqd if __do_softirq() is incomplete
@ 2020-05-21 11:25 Chris Wilson
  2020-05-21 12:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
  2020-05-22  5:40 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2020-05-21 11:25 UTC (permalink / raw)
  To: intel-gfx; +Cc: Chris Wilson

When invoking the softirq, a tasklet may be skipped due to contention or
being disabled. The tasklet is then left on the scheduled list, but we
do not wakeup ksoftirqd to retry the execution.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 kernel/softirq.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index a47c6dd57452..88cec274037d 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -379,9 +379,10 @@ static inline void invoke_softirq(void)
 		 */
 		do_softirq_own_stack();
 #endif
-	} else {
-		wakeup_softirqd();
 	}
+
+	if (local_softirq_pending())
+		wakeup_softirqd();
 }
 
 static inline void tick_irq_exit(void)
-- 
2.27.0.rc0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread