intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Ma <aaron.ma@canonical.com>
To: aaron.ma@canonical.com, intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH xf86-video-intel] sna/uxa: add drm modes for no-GTF pannels
Date: Sat, 30 May 2020 10:18:50 +0800	[thread overview]
Message-ID: <20200530021850.37348-1-aaron.ma@canonical.com> (raw)

EDID1.4 replaced GTF Bit with Continuous or Non-Continuous Frequency
Display.

SNA still check this bit as GTF support, only defined modes in EDID
will be set.

Correct the GTF support check, then add more modes.

Note, gtf_supported must be included in xserver.
https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/421

BugLink: https://gitlab.freedesktop.org/drm/intel/issues/313

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 src/sna/sna_display.c   | 2 +-
 src/uxa/intel_display.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/sna/sna_display.c b/src/sna/sna_display.c
index 874292bc..16ecd353 100644
--- a/src/sna/sna_display.c
+++ b/src/sna/sna_display.c
@@ -4325,7 +4325,7 @@ sna_output_add_default_modes(xf86OutputPtr output, DisplayModePtr modes)
 	int max_x = 0, max_y = 0, max_clock = 0;
 	float max_vrefresh = 0.0;
 
-	if (mon && GTF_SUPPORTED(mon->features.msc))
+	if (mon && gtf_supported(mon))
 		return modes;
 
 	for (m = modes; m; m = m->next) {
diff --git a/src/uxa/intel_display.c b/src/uxa/intel_display.c
index ba4b8d87..2490db84 100644
--- a/src/uxa/intel_display.c
+++ b/src/uxa/intel_display.c
@@ -915,7 +915,7 @@ intel_output_panel_edid(xf86OutputPtr output, DisplayModePtr modes)
 {
 	xf86MonPtr mon = output->MonInfo;
 
-	if (!mon || !GTF_SUPPORTED(mon->features.msc)) {
+	if (!mon || !gtf_supported(mon)) {
 		DisplayModePtr i, m, p = NULL;
 		int max_x = 0, max_y = 0;
 		float max_vrefresh = 0.0;
-- 
2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2020-05-30  2:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-30  2:18 Aaron Ma [this message]
2020-05-30  2:26 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for sna/uxa: add drm modes for no-GTF pannels Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200530021850.37348-1-aaron.ma@canonical.com \
    --to=aaron.ma@canonical.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).