intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH xf86-video-intel] sna/uxa: add drm modes for no-GTF pannels
@ 2020-05-30  2:18 Aaron Ma
  2020-05-30  2:26 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
  0 siblings, 1 reply; 2+ messages in thread
From: Aaron Ma @ 2020-05-30  2:18 UTC (permalink / raw)
  To: aaron.ma, intel-gfx

EDID1.4 replaced GTF Bit with Continuous or Non-Continuous Frequency
Display.

SNA still check this bit as GTF support, only defined modes in EDID
will be set.

Correct the GTF support check, then add more modes.

Note, gtf_supported must be included in xserver.
https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/421

BugLink: https://gitlab.freedesktop.org/drm/intel/issues/313

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 src/sna/sna_display.c   | 2 +-
 src/uxa/intel_display.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/sna/sna_display.c b/src/sna/sna_display.c
index 874292bc..16ecd353 100644
--- a/src/sna/sna_display.c
+++ b/src/sna/sna_display.c
@@ -4325,7 +4325,7 @@ sna_output_add_default_modes(xf86OutputPtr output, DisplayModePtr modes)
 	int max_x = 0, max_y = 0, max_clock = 0;
 	float max_vrefresh = 0.0;
 
-	if (mon && GTF_SUPPORTED(mon->features.msc))
+	if (mon && gtf_supported(mon))
 		return modes;
 
 	for (m = modes; m; m = m->next) {
diff --git a/src/uxa/intel_display.c b/src/uxa/intel_display.c
index ba4b8d87..2490db84 100644
--- a/src/uxa/intel_display.c
+++ b/src/uxa/intel_display.c
@@ -915,7 +915,7 @@ intel_output_panel_edid(xf86OutputPtr output, DisplayModePtr modes)
 {
 	xf86MonPtr mon = output->MonInfo;
 
-	if (!mon || !GTF_SUPPORTED(mon->features.msc)) {
+	if (!mon || !gtf_supported(mon)) {
 		DisplayModePtr i, m, p = NULL;
 		int max_x = 0, max_y = 0;
 		float max_vrefresh = 0.0;
-- 
2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Intel-gfx] ✗ Fi.CI.BUILD: failure for sna/uxa: add drm modes for no-GTF pannels
  2020-05-30  2:18 [Intel-gfx] [PATCH xf86-video-intel] sna/uxa: add drm modes for no-GTF pannels Aaron Ma
@ 2020-05-30  2:26 ` Patchwork
  0 siblings, 0 replies; 2+ messages in thread
From: Patchwork @ 2020-05-30  2:26 UTC (permalink / raw)
  To: Aaron Ma; +Cc: intel-gfx

== Series Details ==

Series: sna/uxa: add drm modes for no-GTF pannels
URL   : https://patchwork.freedesktop.org/series/77808/
State : failure

== Summary ==

Applying: sna/uxa: add drm modes for no-GTF pannels
error: sha1 information is lacking or useless (src/sna/sna_display.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 sna/uxa: add drm modes for no-GTF pannels
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-30  2:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-30  2:18 [Intel-gfx] [PATCH xf86-video-intel] sna/uxa: add drm modes for no-GTF pannels Aaron Ma
2020-05-30  2:26 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).