* [Intel-gfx] [PATCH 1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex
@ 2020-07-28 15:28 Chris Wilson
2020-07-28 15:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/gem: Reduce ctx->engine_mutex for reading the clone source Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2020-07-28 15:28 UTC (permalink / raw)
To: intel-gfx; +Cc: stable, Chris Wilson, thomas.hellstrom, Daniel Vetter
Since the debugfs may peek into the GEM contexts as the corresponding
client/fd is being closed, we may try and follow a dangling pointer.
However, the context closure itself is serialised with the ctx->mutex,
so if we hold that mutex as we inspect the state coupled in the context,
we know the pointers within the context are stable and will remain valid
as we inspect their tables.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: CQ Tang <cq.tang@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 784219962193..ea469168cd44 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -326,6 +326,7 @@ static void print_context_stats(struct seq_file *m,
}
i915_gem_context_unlock_engines(ctx);
+ mutex_lock(&ctx->mutex);
if (!IS_ERR_OR_NULL(ctx->file_priv)) {
struct file_stats stats = {
.vm = rcu_access_pointer(ctx->vm),
@@ -346,6 +347,7 @@ static void print_context_stats(struct seq_file *m,
print_file_stats(m, name, stats);
}
+ mutex_unlock(&ctx->mutex);
spin_lock(&i915->gem.contexts.lock);
list_safe_reset_next(ctx, cn, link);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Intel-gfx] [PATCH 2/2] drm/i915/gem: Reduce ctx->engine_mutex for reading the clone source 2020-07-28 15:28 [Intel-gfx] [PATCH 1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex Chris Wilson @ 2020-07-28 15:28 ` Chris Wilson 2020-07-28 19:22 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: Chris Wilson @ 2020-07-28 15:28 UTC (permalink / raw) To: intel-gfx; +Cc: thomas.hellstrom, Chris Wilson When cloning the engines from the source context, we need to ensure that the engines are not freed as we copy them, and that the flags we clone from the source correspond with the engines we copy across. To do this we need only take a reference to the src->engines, rather than hold the src->engine_mutex, so long as we verify that nothing changed under the read. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 24 +++++++++++++-------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index d0bdb6d447ed..b5b179f96d77 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -752,7 +752,8 @@ __create_context(struct drm_i915_private *i915) } static inline struct i915_gem_engines * -__context_engines_await(const struct i915_gem_context *ctx) +__context_engines_await(const struct i915_gem_context *ctx, + bool *user_engines) { struct i915_gem_engines *engines; @@ -761,6 +762,10 @@ __context_engines_await(const struct i915_gem_context *ctx) engines = rcu_dereference(ctx->engines); GEM_BUG_ON(!engines); + if (user_engines) + *user_engines = i915_gem_context_user_engines(ctx); + + /* successful await => strong mb */ if (unlikely(!i915_sw_fence_await(&engines->fence))) continue; @@ -784,7 +789,7 @@ context_apply_all(struct i915_gem_context *ctx, struct intel_context *ce; int err = 0; - e = __context_engines_await(ctx); + e = __context_engines_await(ctx, NULL); for_each_gem_engine(ce, e, it) { err = fn(ce, data); if (err) @@ -1117,7 +1122,7 @@ static int context_barrier_task(struct i915_gem_context *ctx, return err; } - e = __context_engines_await(ctx); + e = __context_engines_await(ctx, NULL); if (!e) { i915_active_release(&cb->base); return -ENOENT; @@ -2114,11 +2119,14 @@ static int copy_ring_size(struct intel_context *dst, static int clone_engines(struct i915_gem_context *dst, struct i915_gem_context *src) { - struct i915_gem_engines *e = i915_gem_context_lock_engines(src); - struct i915_gem_engines *clone; + struct i915_gem_engines *clone, *e; bool user_engines; unsigned long n; + e = __context_engines_await(src, &user_engines); + if (!e) + return -ENOENT; + clone = alloc_engines(e->num_engines); if (!clone) goto err_unlock; @@ -2160,9 +2168,7 @@ static int clone_engines(struct i915_gem_context *dst, } } clone->num_engines = n; - - user_engines = i915_gem_context_user_engines(src); - i915_gem_context_unlock_engines(src); + i915_sw_fence_complete(&e->fence); /* Serialised by constructor */ engines_idle_release(dst, rcu_replace_pointer(dst->engines, clone, 1)); @@ -2173,7 +2179,7 @@ static int clone_engines(struct i915_gem_context *dst, return 0; err_unlock: - i915_gem_context_unlock_engines(src); + i915_sw_fence_complete(&e->fence); return -ENOMEM; } -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex 2020-07-28 15:28 [Intel-gfx] [PATCH 1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex Chris Wilson 2020-07-28 15:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/gem: Reduce ctx->engine_mutex for reading the clone source Chris Wilson @ 2020-07-28 19:22 ` Patchwork 2020-07-28 19:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-07-29 3:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-07-28 19:22 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: series starting with [1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex URL : https://patchwork.freedesktop.org/series/79990/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex 2020-07-28 15:28 [Intel-gfx] [PATCH 1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex Chris Wilson 2020-07-28 15:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/gem: Reduce ctx->engine_mutex for reading the clone source Chris Wilson 2020-07-28 19:22 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex Patchwork @ 2020-07-28 19:43 ` Patchwork 2020-07-29 3:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-07-28 19:43 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 7275 bytes --] == Series Details == Series: series starting with [1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex URL : https://patchwork.freedesktop.org/series/79990/ State : success == Summary == CI Bug Log - changes from CI_DRM_8807 -> Patchwork_18255 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/index.html Known issues ------------ Here are the changes found in Patchwork_18255 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_module_load@reload: - fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-tgl-y/igt@i915_module_load@reload.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-tgl-y/igt@i915_module_load@reload.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_selftest@live@gt_contexts: - fi-snb-2520m: [PASS][5] -> [DMESG-FAIL][6] ([i915#541]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-snb-2520m/igt@i915_selftest@live@gt_contexts.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-snb-2520m/igt@i915_selftest@live@gt_contexts.html * igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1: - fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html * igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2: - fi-skl-guc: [PASS][9] -> [DMESG-WARN][10] ([i915#2203]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html * igt@prime_self_import@basic-with_two_bos: - fi-tgl-y: [PASS][11] -> [DMESG-WARN][12] ([i915#402]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-u2: [FAIL][13] ([i915#1888]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html * igt@gem_flink_basic@basic: - fi-tgl-y: [DMESG-WARN][15] ([i915#402]) -> [PASS][16] +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-tgl-y/igt@gem_flink_basic@basic.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-tgl-y/igt@gem_flink_basic@basic.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-bsw-n3050: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-bsw-n3050/igt@i915_pm_rpm@basic-pci-d3-state.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-bsw-n3050/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_pm_rpm@module-reload: - fi-bsw-kefka: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-bsw-kefka/igt@i915_pm_rpm@module-reload.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-bsw-kefka/igt@i915_pm_rpm@module-reload.html * igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1: - fi-icl-u2: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html #### Warnings #### * igt@gem_exec_suspend@basic-s0: - fi-kbl-x1275: [DMESG-WARN][23] ([i915#1982] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html * igt@kms_force_connector_basic@force-edid: - fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92]) -> [DMESG-WARN][26] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html * igt@kms_pipe_crc_basic@read-crc-pipe-a: - fi-kbl-x1275: [DMESG-WARN][27] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][28] ([i915#62] / [i915#92]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-a.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-a.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (43 -> 37) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus Build changes ------------- * Linux: CI_DRM_8807 -> Patchwork_18255 CI-20190529: 20190529 CI_DRM_8807: 494850d613c74f24a5799710b346faa5cd12a407 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5749: 2fef871e791ceab7841b899691c443167550173d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18255: a1fa09b7c79050a0c74b144969c4b87b4f220fa3 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == a1fa09b7c790 drm/i915/gem: Reduce ctx->engine_mutex for reading the clone source c69a0a568866 drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/index.html [-- Attachment #1.2: Type: text/html, Size: 9551 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex 2020-07-28 15:28 [Intel-gfx] [PATCH 1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex Chris Wilson ` (2 preceding siblings ...) 2020-07-28 19:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2020-07-29 3:49 ` Patchwork 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-07-29 3:49 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 17084 bytes --] == Series Details == Series: series starting with [1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex URL : https://patchwork.freedesktop.org/series/79990/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8807_full -> Patchwork_18255_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_18255_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_18255_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_18255_full: ### IGT changes ### #### Possible regressions #### * igt@kms_flip@nonexisting-fb@b-dp1: - shard-kbl: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-kbl6/igt@kms_flip@nonexisting-fb@b-dp1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-kbl7/igt@kms_flip@nonexisting-fb@b-dp1.html Known issues ------------ Here are the changes found in Patchwork_18255_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@engines-mixed-process@vcs0: - shard-skl: [PASS][3] -> [FAIL][4] ([i915#1528]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl7/igt@gem_ctx_persistence@engines-mixed-process@vcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl2/igt@gem_ctx_persistence@engines-mixed-process@vcs0.html * igt@gem_ctx_persistence@replace@bcs0: - shard-skl: [PASS][5] -> [FAIL][6] ([i915#2092]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl1/igt@gem_ctx_persistence@replace@bcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl4/igt@gem_ctx_persistence@replace@bcs0.html * igt@gem_exec_whisper@basic-queues-priority: - shard-glk: [PASS][7] -> [DMESG-WARN][8] ([i915#118] / [i915#95]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-glk9/igt@gem_exec_whisper@basic-queues-priority.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-glk3/igt@gem_exec_whisper@basic-queues-priority.html * igt@i915_pm_dc@dc6-psr: - shard-skl: [PASS][9] -> [FAIL][10] ([i915#454]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl7/igt@i915_pm_dc@dc6-psr.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl2/igt@i915_pm_dc@dc6-psr.html * igt@kms_atomic_transition@plane-all-transition-fencing@edp-1-pipe-c: - shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([i915#2242]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-tglb1/igt@kms_atomic_transition@plane-all-transition-fencing@edp-1-pipe-c.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-tglb2/igt@kms_atomic_transition@plane-all-transition-fencing@edp-1-pipe-c.html * igt@kms_big_fb@y-tiled-16bpp-rotate-0: - shard-skl: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +13 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl6/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl3/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +4 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_legacy@pipe-c-torture-bo: - shard-iclb: [PASS][17] -> [DMESG-WARN][18] ([i915#128]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-iclb2/igt@kms_cursor_legacy@pipe-c-torture-bo.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-iclb5/igt@kms_cursor_legacy@pipe-c-torture-bo.html * igt@kms_flip@nonexisting-fb@a-edp1: - shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([i915#2240]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-tglb6/igt@kms_flip@nonexisting-fb@a-edp1.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-tglb6/igt@kms_flip@nonexisting-fb@a-edp1.html * igt@kms_flip@nonexisting-fb@b-vga1: - shard-snb: [PASS][21] -> [INCOMPLETE][22] ([i915#82]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-snb2/igt@kms_flip@nonexisting-fb@b-vga1.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-snb6/igt@kms_flip@nonexisting-fb@b-vga1.html * igt@kms_frontbuffer_tracking@fbc-badstride: - shard-glk: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-glk3/igt@kms_frontbuffer_tracking@fbc-badstride.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-glk6/igt@kms_frontbuffer_tracking@fbc-badstride.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-skl: [PASS][25] -> [INCOMPLETE][26] ([i915#198]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [i915#265]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_psr@psr2_sprite_blt: - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-iclb1/igt@kms_psr@psr2_sprite_blt.html * igt@perf@blocking-parameterized: - shard-iclb: [PASS][31] -> [FAIL][32] ([i915#1542]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-iclb4/igt@perf@blocking-parameterized.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-iclb2/igt@perf@blocking-parameterized.html - shard-tglb: [PASS][33] -> [FAIL][34] ([i915#1542]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-tglb3/igt@perf@blocking-parameterized.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-tglb6/igt@perf@blocking-parameterized.html * igt@perf_pmu@module-unload: - shard-tglb: [PASS][35] -> [DMESG-WARN][36] ([i915#1982]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-tglb2/igt@perf_pmu@module-unload.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-tglb5/igt@perf_pmu@module-unload.html #### Possible fixes #### * igt@gem_eio@in-flight-suspend: - shard-skl: [DMESG-WARN][37] ([i915#1982]) -> [PASS][38] +4 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl7/igt@gem_eio@in-flight-suspend.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl10/igt@gem_eio@in-flight-suspend.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [SKIP][39] ([i915#2190]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-tglb6/igt@gem_huc_copy@huc-copy.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-tglb3/igt@gem_huc_copy@huc-copy.html * igt@i915_pm_rpm@system-suspend-modeset: - shard-skl: [INCOMPLETE][41] ([i915#151]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl3/igt@i915_pm_rpm@system-suspend-modeset.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl5/igt@i915_pm_rpm@system-suspend-modeset.html * igt@kms_atomic_transition@plane-all-transition@edp-1-pipe-a: - shard-tglb: [INCOMPLETE][43] ([i915#2242]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-tglb6/igt@kms_atomic_transition@plane-all-transition@edp-1-pipe-a.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-tglb7/igt@kms_atomic_transition@plane-all-transition@edp-1-pipe-a.html * igt@kms_big_fb@linear-64bpp-rotate-0: - shard-glk: [DMESG-FAIL][45] ([i915#118] / [i915#95]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-0.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-glk9/igt@kms_big_fb@linear-64bpp-rotate-0.html * igt@kms_big_fb@yf-tiled-32bpp-rotate-270: - shard-apl: [DMESG-WARN][47] ([i915#1635] / [i915#1982]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-apl4/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-apl2/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-skl: [INCOMPLETE][49] ([i915#300]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_edge_walk@pipe-c-64x64-top-edge: - shard-glk: [DMESG-WARN][51] ([i915#1982]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-glk9/igt@kms_cursor_edge_walk@pipe-c-64x64-top-edge.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-glk2/igt@kms_cursor_edge_walk@pipe-c-64x64-top-edge.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2: - shard-glk: [FAIL][53] ([i915#79]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html * igt@kms_flip@nonexisting-fb@a-edp1: - shard-iclb: [INCOMPLETE][55] ([i915#2240]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-iclb4/igt@kms_flip@nonexisting-fb@a-edp1.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-iclb1/igt@kms_flip@nonexisting-fb@a-edp1.html * igt@kms_flip_tiling@flip-changes-tiling-y: - shard-skl: [FAIL][57] ([i915#699]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl5/igt@kms_flip_tiling@flip-changes-tiling-y.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl9/igt@kms_flip_tiling@flip-changes-tiling-y.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite: - shard-iclb: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbcpsr-stridechange: - shard-tglb: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62] +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-stridechange.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-stridechange.html * igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw: - shard-iclb: [INCOMPLETE][63] ([i915#123]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-iclb1/igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-iclb6/igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [FAIL][65] ([i915#1188]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl3/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_hdr@bpc-switch-suspend: - shard-kbl: [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +9 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-kbl4/igt@kms_hdr@bpc-switch-suspend.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-kbl2/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: [SKIP][69] ([fdo#109441]) -> [PASS][70] +3 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_gtt.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html #### Warnings #### * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][71] ([fdo#109349]) -> [DMESG-WARN][72] ([i915#1226]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_plane_alpha_blend@pipe-a-alpha-basic: - shard-skl: [FAIL][73] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][74] ([fdo#108145] / [i915#1982]) +1 similar issue [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8807/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226 [i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123 [i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128 [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151 [i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2092]: https://gitlab.freedesktop.org/drm/intel/issues/2092 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2240]: https://gitlab.freedesktop.org/drm/intel/issues/2240 [i915#2242]: https://gitlab.freedesktop.org/drm/intel/issues/2242 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (10 -> 11) ------------------------------ Additional (1): pig-icl-1065g7 Build changes ------------- * Linux: CI_DRM_8807 -> Patchwork_18255 CI-20190529: 20190529 CI_DRM_8807: 494850d613c74f24a5799710b346faa5cd12a407 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5749: 2fef871e791ceab7841b899691c443167550173d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18255: a1fa09b7c79050a0c74b144969c4b87b4f220fa3 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18255/index.html [-- Attachment #1.2: Type: text/html, Size: 19812 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-29 3:49 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-28 15:28 [Intel-gfx] [PATCH 1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex Chris Wilson 2020-07-28 15:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/gem: Reduce ctx->engine_mutex for reading the clone source Chris Wilson 2020-07-28 19:22 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex Patchwork 2020-07-28 19:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-07-29 3:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).