* [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH
@ 2020-10-28 14:43 Lee Shawn C
2020-10-28 15:09 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
` (12 more replies)
0 siblings, 13 replies; 24+ messages in thread
From: Lee Shawn C @ 2020-10-28 14:43 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou
After boot into kernel. Driver configured ddc pin mapping based on
predefined table in parse_ddi_port(). Now driver configure rkl
ddc pin mapping depends on icp_ddc_pin_map[]. Then this table will
give incorrect gmbus port number to cause HDMI can't work.
Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can
works properly on rkl.
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Aditya Swarup <aditya.swarup@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 22 ++++++++++++++++++-
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 ++++
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index a0a41ec5c341..f2c4772e4c7f 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1597,12 +1597,32 @@ static const u8 icp_ddc_pin_map[] = {
[TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP,
};
+static const u8 rkl_pch_tgp_ddc_pin_map[] = {
+ [RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
+ [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
+ [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP,
+};
+
+static const u8 rkl_pch_cmp_ddc_pin_map[] = {
+ [RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
+ [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_3_BXT,
+ [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_4_CNP,
+};
+
static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
{
const u8 *ddc_pin_map;
int n_entries;
- if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
+ if (IS_ROCKETLAKE(dev_priv)) {
+ if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP) {
+ ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
+ n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
+ } else {
+ ddc_pin_map = rkl_pch_cmp_ddc_pin_map;
+ n_entries = ARRAY_SIZE(rkl_pch_cmp_ddc_pin_map);
+ }
+ } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
ddc_pin_map = icp_ddc_pin_map;
n_entries = ARRAY_SIZE(icp_ddc_pin_map);
} else if (HAS_PCH_CNP(dev_priv)) {
diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index 6faabd4f6d49..3418c00446c1 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -315,6 +315,10 @@ enum vbt_gmbus_ddi {
ICL_DDC_BUS_DDI_A = 0x1,
ICL_DDC_BUS_DDI_B,
TGL_DDC_BUS_DDI_C,
+ RKL_DDC_BUS_DDI_B = 0x1,
+ RKL_DDC_BUS_DDI_C,
+ RKL_DDC_BUS_DDI_D,
+ RKL_DDC_BUS_DDI_E,
ICL_DDC_BUS_PORT_1 = 0x4,
ICL_DDC_BUS_PORT_2,
ICL_DDC_BUS_PORT_3,
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/rkl: new rkl ddc map for different PCH
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
@ 2020-10-28 15:09 ` Patchwork
2020-10-29 8:10 ` [Intel-gfx] [PATCH] " Jani Nikula
` (11 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2020-10-28 15:09 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/rkl: new rkl ddc map for different PCH
URL : https://patchwork.freedesktop.org/series/83154/
State : failure
== Summary ==
Applying: drm/i915/rkl: new rkl ddc map for different PCH
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/display/intel_bios.c
M drivers/gpu/drm/i915/display/intel_vbt_defs.h
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/display/intel_vbt_defs.h
Auto-merging drivers/gpu/drm/i915/display/intel_bios.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/i915/display/intel_bios.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 drm/i915/rkl: new rkl ddc map for different PCH
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
2020-10-28 15:09 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
@ 2020-10-29 8:10 ` Jani Nikula
2020-10-30 13:41 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
` (10 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Jani Nikula @ 2020-10-29 8:10 UTC (permalink / raw)
To: Lee Shawn C, intel-gfx; +Cc: Cooper Chiou
On Wed, 28 Oct 2020, Lee Shawn C <shawn.c.lee@intel.com> wrote:
> After boot into kernel. Driver configured ddc pin mapping based on
> predefined table in parse_ddi_port(). Now driver configure rkl
> ddc pin mapping depends on icp_ddc_pin_map[]. Then this table will
> give incorrect gmbus port number to cause HDMI can't work.
>
> Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
> Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can
> works properly on rkl.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Aditya Swarup <aditya.swarup@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 22 ++++++++++++++++++-
> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 ++++
> 2 files changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index a0a41ec5c341..f2c4772e4c7f 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1597,12 +1597,32 @@ static const u8 icp_ddc_pin_map[] = {
> [TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP,
> };
>
> +static const u8 rkl_pch_tgp_ddc_pin_map[] = {
> + [RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
> + [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
> + [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP,
> +};
> +
> +static const u8 rkl_pch_cmp_ddc_pin_map[] = {
> + [RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
> + [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_3_BXT,
> + [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_4_CNP,
> +};
> +
> static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
> {
> const u8 *ddc_pin_map;
> int n_entries;
>
> - if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
> + if (IS_ROCKETLAKE(dev_priv)) {
Why the platform check for a PCH based thing?
BR,
Jani.
> + if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP) {
> + ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
> + n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
> + } else {
> + ddc_pin_map = rkl_pch_cmp_ddc_pin_map;
> + n_entries = ARRAY_SIZE(rkl_pch_cmp_ddc_pin_map);
> + }
> + } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
> ddc_pin_map = icp_ddc_pin_map;
> n_entries = ARRAY_SIZE(icp_ddc_pin_map);
> } else if (HAS_PCH_CNP(dev_priv)) {
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index 6faabd4f6d49..3418c00446c1 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -315,6 +315,10 @@ enum vbt_gmbus_ddi {
> ICL_DDC_BUS_DDI_A = 0x1,
> ICL_DDC_BUS_DDI_B,
> TGL_DDC_BUS_DDI_C,
> + RKL_DDC_BUS_DDI_B = 0x1,
> + RKL_DDC_BUS_DDI_C,
> + RKL_DDC_BUS_DDI_D,
> + RKL_DDC_BUS_DDI_E,
> ICL_DDC_BUS_PORT_1 = 0x4,
> ICL_DDC_BUS_PORT_2,
> ICL_DDC_BUS_PORT_3,
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/rkl: new rkl ddc map for different PCH
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
2020-10-28 15:09 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2020-10-29 8:10 ` [Intel-gfx] [PATCH] " Jani Nikula
@ 2020-10-30 13:41 ` Lee Shawn C
2020-10-30 17:35 ` Matt Roper
2020-10-30 16:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rkl: new rkl ddc map for different PCH (rev2) Patchwork
` (9 subsequent siblings)
12 siblings, 1 reply; 24+ messages in thread
From: Lee Shawn C @ 2020-10-30 13:41 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou
After boot into kernel. Driver configured ddc pin mapping based on
predefined table in parse_ddi_port(). Now driver configure rkl
ddc pin mapping depends on icp_ddc_pin_map[]. Then this table will
give incorrect gmbus port number to cause HDMI can't work.
Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can
works properly on rkl.
v2: update patch based on latest dinq branch.
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Aditya Swarup <aditya.swarup@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 20 +++++++++++++++++++
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 ++++
2 files changed, 24 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 0a309645fe06..ca9426e1768a 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1623,6 +1623,18 @@ static const u8 icp_ddc_pin_map[] = {
[TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP,
};
+static const u8 rkl_pch_tgp_ddc_pin_map[] = {
+ [RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
+ [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
+ [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP,
+};
+
+static const u8 rkl_pch_cmp_ddc_pin_map[] = {
+ [RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
+ [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_3_BXT,
+ [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_4_CNP,
+};
+
static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
{
const u8 *ddc_pin_map;
@@ -1630,6 +1642,14 @@ static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
return vbt_pin;
+ } else if (IS_ROCKETLAKE(dev_priv)) {
+ if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP) {
+ ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
+ n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
+ } else {
+ ddc_pin_map = rkl_pch_cmp_ddc_pin_map;
+ n_entries = ARRAY_SIZE(rkl_pch_cmp_ddc_pin_map);
+ }
} else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
ddc_pin_map = icp_ddc_pin_map;
n_entries = ARRAY_SIZE(icp_ddc_pin_map);
diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index 49b4b5fca941..2df009996128 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -319,6 +319,10 @@ enum vbt_gmbus_ddi {
ICL_DDC_BUS_DDI_A = 0x1,
ICL_DDC_BUS_DDI_B,
TGL_DDC_BUS_DDI_C,
+ RKL_DDC_BUS_DDI_B = 0x1,
+ RKL_DDC_BUS_DDI_C,
+ RKL_DDC_BUS_DDI_D,
+ RKL_DDC_BUS_DDI_E,
ICL_DDC_BUS_PORT_1 = 0x4,
ICL_DDC_BUS_PORT_2,
ICL_DDC_BUS_PORT_3,
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rkl: new rkl ddc map for different PCH (rev2)
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (2 preceding siblings ...)
2020-10-30 13:41 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
@ 2020-10-30 16:05 ` Patchwork
2020-10-30 16:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (8 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2020-10-30 16:05 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/rkl: new rkl ddc map for different PCH (rev2)
URL : https://patchwork.freedesktop.org/series/83154/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2114e70dca7c drm/i915/rkl: new rkl ddc map for different PCH
-:11: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'd0a89527d06', maybe rebased or not pulled?
#11:
Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
total: 0 errors, 1 warnings, 0 checks, 42 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rkl: new rkl ddc map for different PCH (rev2)
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (3 preceding siblings ...)
2020-10-30 16:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rkl: new rkl ddc map for different PCH (rev2) Patchwork
@ 2020-10-30 16:33 ` Patchwork
2020-10-30 19:34 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (7 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2020-10-30 16:33 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4720 bytes --]
== Series Details ==
Series: drm/i915/rkl: new rkl ddc map for different PCH (rev2)
URL : https://patchwork.freedesktop.org/series/83154/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9229 -> Patchwork_18814
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/index.html
New tests
---------
New tests have been introduced between CI_DRM_9229 and Patchwork_18814:
### New CI tests (1) ###
* boot:
- Statuses : 40 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18814 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-byt-j1900: [DMESG-WARN][3] ([i915#1982]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/fi-byt-j1900/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/fi-byt-j1900/igt@i915_module_load@reload.html
- fi-tgl-u2: [DMESG-WARN][5] ([i915#1982] / [k.org#205379]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/fi-tgl-u2/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/fi-tgl-u2/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@active:
- {fi-ehl-1}: [INCOMPLETE][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/fi-ehl-1/igt@i915_selftest@live@active.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/fi-ehl-1/igt@i915_selftest@live@active.html
* igt@i915_selftest@live@execlists:
- fi-kbl-x1275: [INCOMPLETE][11] ([i915#794]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/fi-kbl-x1275/igt@i915_selftest@live@execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/fi-kbl-x1275/igt@i915_selftest@live@execlists.html
* igt@kms_busy@basic@flip:
- {fi-kbl-7560u}: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/fi-kbl-7560u/igt@kms_busy@basic@flip.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/fi-kbl-7560u/igt@kms_busy@basic@flip.html
#### Warnings ####
* igt@core_hotunplug@unbind-rebind:
- fi-icl-u2: [DMESG-WARN][15] ([i915#1982] / [i915#289]) -> [DMESG-WARN][16] ([i915#289])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/fi-icl-u2/igt@core_hotunplug@unbind-rebind.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/fi-icl-u2/igt@core_hotunplug@unbind-rebind.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289
[i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (45 -> 40)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9229 -> Patchwork_18814
CI-20190529: 20190529
CI_DRM_9229: 4abde8e3625d7249799c3e1cdeac1b2aa3ad3edb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5830: 12d370cb57e0cfcb781c87ad9e15e68b17a1f41f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18814: 2114e70dca7c1b45aa7aba2d3043994b60176eec @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2114e70dca7c drm/i915/rkl: new rkl ddc map for different PCH
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/index.html
[-- Attachment #1.2: Type: text/html, Size: 5938 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/rkl: new rkl ddc map for different PCH
2020-10-30 13:41 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
@ 2020-10-30 17:35 ` Matt Roper
2020-10-31 2:55 ` Lee, Shawn C
0 siblings, 1 reply; 24+ messages in thread
From: Matt Roper @ 2020-10-30 17:35 UTC (permalink / raw)
To: Lee Shawn C; +Cc: Cooper Chiou, intel-gfx
On Fri, Oct 30, 2020 at 09:41:37PM +0800, Lee Shawn C wrote:
> After boot into kernel. Driver configured ddc pin mapping based on
> predefined table in parse_ddi_port(). Now driver configure rkl
> ddc pin mapping depends on icp_ddc_pin_map[]. Then this table will
> give incorrect gmbus port number to cause HDMI can't work.
>
> Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
> Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can
> works properly on rkl.
>
> v2: update patch based on latest dinq branch.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Aditya Swarup <aditya.swarup@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 20 +++++++++++++++++++
> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 ++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 0a309645fe06..ca9426e1768a 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1623,6 +1623,18 @@ static const u8 icp_ddc_pin_map[] = {
> [TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP,
> };
>
> +static const u8 rkl_pch_tgp_ddc_pin_map[] = {
> + [RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
> + [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
> + [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP,
> +};
> +
> +static const u8 rkl_pch_cmp_ddc_pin_map[] = {
> + [RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
> + [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_3_BXT,
> + [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_4_CNP,
> +};
> +
> static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
> {
> const u8 *ddc_pin_map;
> @@ -1630,6 +1642,14 @@ static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
>
> if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
> return vbt_pin;
> + } else if (IS_ROCKETLAKE(dev_priv)) {
> + if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP) {
> + ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
> + n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
> + } else {
> + ddc_pin_map = rkl_pch_cmp_ddc_pin_map;
> + n_entries = ARRAY_SIZE(rkl_pch_cmp_ddc_pin_map);
> + }
> } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
> ddc_pin_map = icp_ddc_pin_map;
> n_entries = ARRAY_SIZE(icp_ddc_pin_map);
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index 49b4b5fca941..2df009996128 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -319,6 +319,10 @@ enum vbt_gmbus_ddi {
> ICL_DDC_BUS_DDI_A = 0x1,
> ICL_DDC_BUS_DDI_B,
> TGL_DDC_BUS_DDI_C,
> + RKL_DDC_BUS_DDI_B = 0x1,
> + RKL_DDC_BUS_DDI_C,
> + RKL_DDC_BUS_DDI_D,
> + RKL_DDC_BUS_DDI_E,
These definitions don't really make sense; according to the VBT
definition in the bspec (20124), the symbolic names map to different VBT
input values depending on which PCH is paired with RKL. E.g., VBT value
of "2" refers to PHY-C when using a CMP PCH, but refers to PHY-B when
using a TGP PCH.
From what I can see, RKL+TGP is already handled properly today in the
code and doesn't need any special handling. The patch here would
actually break it, because it would associate the wrong pins to outputs
(and fail to associate anything at all with PHY-B [vbt value 2]).
For RKL+CMP, we do need a change to the code to pick valid output pins
in the range 1-4 rather than 1,2,9,A, but it doesn't look like the
mapping being added here is quite right for that either. CMP is a
derivative of CNP, so I believe we should be following the "CNL-PCH"
column of the VBT definition.
Matt
> ICL_DDC_BUS_PORT_1 = 0x4,
> ICL_DDC_BUS_PORT_2,
> ICL_DDC_BUS_PORT_3,
> --
> 2.28.0
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/rkl: new rkl ddc map for different PCH (rev2)
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (4 preceding siblings ...)
2020-10-30 16:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-10-30 19:34 ` Patchwork
2020-11-02 13:56 ` [Intel-gfx] [PATCH v3] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (6 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2020-10-30 19:34 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 18188 bytes --]
== Series Details ==
Series: drm/i915/rkl: new rkl ddc map for different PCH (rev2)
URL : https://patchwork.freedesktop.org/series/83154/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9229_full -> Patchwork_18814_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18814_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18814_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18814_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
New tests
---------
New tests have been introduced between CI_DRM_9229_full and Patchwork_18814_full:
### New CI tests (1) ###
* boot:
- Statuses : 200 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18814_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_create@forked:
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-glk3/igt@gem_exec_create@forked.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-glk4/igt@gem_exec_create@forked.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][5] -> [DMESG-WARN][6] ([i915#1436] / [i915#716])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl6/igt@gen9_exec_parse@allowed-single.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl4/igt@gen9_exec_parse@allowed-single.html
* igt@kms_cursor_crc@pipe-a-cursor-dpms:
- shard-skl: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-dpms.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-dpms.html
* igt@kms_cursor_crc@pipe-b-cursor-128x128-random:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#54]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl10/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html
* igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge:
- shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-glk7/igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-glk7/igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][13] -> [FAIL][14] ([i915#79])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#79])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-glk1/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#2122])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#2122])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-glk5/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-glk8/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1.html
* igt@kms_flip_tiling@flip-to-yf-tiled:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-kbl1/igt@kms_flip_tiling@flip-to-yf-tiled.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-kbl3/igt@kms_flip_tiling@flip-to-yf-tiled.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt:
- shard-iclb: [PASS][23] -> [DMESG-WARN][24] ([i915#1982])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-iclb6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-iclb6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#1188])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl7/igt@kms_hdr@bpc-switch-suspend.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl6/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
* igt@kms_sysfs_edid_timing:
- shard-hsw: [PASS][29] -> [FAIL][30] ([IGT#2])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-hsw2/igt@kms_sysfs_edid_timing.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-hsw1/igt@kms_sysfs_edid_timing.html
* igt@perf@polling-parameterized:
- shard-glk: [PASS][31] -> [FAIL][32] ([i915#1542])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-glk9/igt@perf@polling-parameterized.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-glk6/igt@perf@polling-parameterized.html
#### Possible fixes ####
* igt@gem_workarounds@suspend-resume-fd:
- shard-skl: [INCOMPLETE][33] ([i915#198]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl6/igt@gem_workarounds@suspend-resume-fd.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl9/igt@gem_workarounds@suspend-resume-fd.html
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-apl: [FAIL][35] ([i915#1635] / [i915#2521]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-apl4/igt@kms_async_flips@async-flip-with-page-flip-events.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-apl2/igt@kms_async_flips@async-flip-with-page-flip-events.html
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@edp-1-pipe-b:
- shard-skl: [DMESG-WARN][37] ([i915#1982]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl8/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@edp-1-pipe-b.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl10/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@edp-1-pipe-b.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding:
- shard-skl: [FAIL][39] ([i915#54]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html
* igt@kms_cursor_edge_walk@pipe-b-128x128-top-edge:
- shard-glk: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-glk1/igt@kms_cursor_edge_walk@pipe-b-128x128-top-edge.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-glk6/igt@kms_cursor_edge_walk@pipe-b-128x128-top-edge.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-bottom-edge:
- shard-tglb: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-tglb5/igt@kms_cursor_edge_walk@pipe-d-128x128-bottom-edge.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-tglb3/igt@kms_cursor_edge_walk@pipe-d-128x128-bottom-edge.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [FAIL][45] ([i915#96]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-hsw7/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_flip@blocking-wf_vblank@a-dp1:
- shard-kbl: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-kbl4/igt@kms_flip@blocking-wf_vblank@a-dp1.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-kbl7/igt@kms_flip@blocking-wf_vblank@a-dp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [DMESG-WARN][49] ([i915#180]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-kbl3/igt@kms_flip@flip-vs-suspend@c-dp1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-hsw: [INCOMPLETE][51] ([i915#2055]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-hsw6/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-hsw7/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][53] ([i915#2122]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][55] ([i915#1188]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-c:
- shard-skl: [FAIL][57] -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl1/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-c.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl4/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-c.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
- shard-apl: [DMESG-WARN][59] ([i915#1635] / [i915#1982]) -> [PASS][60] +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-apl8/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-apl6/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][61] ([fdo#109441]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@perf@polling-parameterized:
- shard-tglb: [FAIL][63] ([i915#1542]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-tglb5/igt@perf@polling-parameterized.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-tglb3/igt@perf@polling-parameterized.html
#### Warnings ####
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-hsw: [FAIL][65] -> [FAIL][66] ([i915#2261])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-hsw4/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-hsw2/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: [SKIP][67] ([fdo#109271]) -> [FAIL][68] ([i915#183])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-hsw2/igt@gem_tiled_swapping@non-threaded.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-hsw1/igt@gem_tiled_swapping@non-threaded.html
* igt@kms_color@pipe-a-ctm-red-to-blue:
- shard-skl: [DMESG-WARN][69] ([i915#1982]) -> [DMESG-FAIL][70] ([i915#1982])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl9/igt@kms_color@pipe-a-ctm-red-to-blue.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl9/igt@kms_color@pipe-a-ctm-red-to-blue.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [DMESG-WARN][71] ([i915#2411]) -> [INCOMPLETE][72] ([i915#1436] / [i915#456])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-tglb7/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-tglb5/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* igt@kms_flip_tiling@flip-x-tiled:
- shard-skl: [DMESG-WARN][73] ([i915#1982]) -> [DMESG-FAIL][74] ([fdo#108145] / [i915#1982])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-skl9/igt@kms_flip_tiling@flip-x-tiled.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-skl9/igt@kms_flip_tiling@flip-x-tiled.html
* igt@runner@aborted:
- shard-tglb: [FAIL][75] ([i915#2439]) -> ([FAIL][76], [FAIL][77]) ([i915#2248] / [i915#2439])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9229/shard-tglb1/igt@runner@aborted.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-tglb8/igt@runner@aborted.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/shard-tglb5/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#183]: https://gitlab.freedesktop.org/drm/intel/issues/183
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2248]: https://gitlab.freedesktop.org/drm/intel/issues/2248
[i915#2261]: https://gitlab.freedesktop.org/drm/intel/issues/2261
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9229 -> Patchwork_18814
CI-20190529: 20190529
CI_DRM_9229: 4abde8e3625d7249799c3e1cdeac1b2aa3ad3edb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5830: 12d370cb57e0cfcb781c87ad9e15e68b17a1f41f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18814: 2114e70dca7c1b45aa7aba2d3043994b60176eec @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18814/index.html
[-- Attachment #1.2: Type: text/html, Size: 21251 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/rkl: new rkl ddc map for different PCH
2020-10-30 17:35 ` Matt Roper
@ 2020-10-31 2:55 ` Lee, Shawn C
2020-11-02 6:12 ` Matt Roper
0 siblings, 1 reply; 24+ messages in thread
From: Lee, Shawn C @ 2020-10-31 2:55 UTC (permalink / raw)
To: Roper, Matthew D; +Cc: Chiou, Cooper, intel-gfx
On Fri, Oct. 30, 2020, 5:35 p.m., Matt Roper wrote:
>On Fri, Oct 30, 2020 at 09:41:37PM +0800, Lee Shawn C wrote:
>> After boot into kernel. Driver configured ddc pin mapping based on
>> predefined table in parse_ddi_port(). Now driver configure rkl ddc pin
>> mapping depends on icp_ddc_pin_map[]. Then this table will give
>> incorrect gmbus port number to cause HDMI can't work.
>>
>> Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
>> Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can works
>> properly on rkl.
>>
>> v2: update patch based on latest dinq branch.
>>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Cc: Aditya Swarup <aditya.swarup@intel.com>
>> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.c | 20 +++++++++++++++++++
>> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 ++++
>> 2 files changed, 24 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
>> b/drivers/gpu/drm/i915/display/intel_bios.c
>> index 0a309645fe06..ca9426e1768a 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -1623,6 +1623,18 @@ static const u8 icp_ddc_pin_map[] = {
>> [TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP, };
>>
>> +static const u8 rkl_pch_tgp_ddc_pin_map[] = {
>> + [RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
>> + [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
>> + [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP, };
>> +
>> +static const u8 rkl_pch_cmp_ddc_pin_map[] = {
>> + [RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
>> + [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_3_BXT,
>> + [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_4_CNP, };
>> +
>> static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
>> {
>> const u8 *ddc_pin_map;
>> @@ -1630,6 +1642,14 @@ static u8 map_ddc_pin(struct drm_i915_private
>> *dev_priv, u8 vbt_pin)
>>
>> if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
>> return vbt_pin;
>> + } else if (IS_ROCKETLAKE(dev_priv)) {
>> + if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP) {
>> + ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
>> + n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
>> + } else {
>> + ddc_pin_map = rkl_pch_cmp_ddc_pin_map;
>> + n_entries = ARRAY_SIZE(rkl_pch_cmp_ddc_pin_map);
>> + }
>> } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
>> ddc_pin_map = icp_ddc_pin_map;
>> n_entries = ARRAY_SIZE(icp_ddc_pin_map); diff --git
>> a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> index 49b4b5fca941..2df009996128 100644
>> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> @@ -319,6 +319,10 @@ enum vbt_gmbus_ddi {
>> ICL_DDC_BUS_DDI_A = 0x1,
>> ICL_DDC_BUS_DDI_B,
>> TGL_DDC_BUS_DDI_C,
>> + RKL_DDC_BUS_DDI_B = 0x1,
>> + RKL_DDC_BUS_DDI_C,
>> + RKL_DDC_BUS_DDI_D,
>> + RKL_DDC_BUS_DDI_E,
>
>These definitions don't really make sense; according to the VBT definition in the bspec (20124), the symbolic names map to different VBT input values depending on which PCH is paired with RKL. E.g., VBT value of "2" refers to PHY-C when using a CMP PCH, but refers to PHY-B when using a TGP PCH.
>
>From what I can see, RKL+TGP is already handled properly today in the code and doesn't need any special handling. The patch here would actually break it, because it would associate the wrong pins to outputs (and fail to associate anything at all with PHY-B [vbt value 2]).
>
>For RKL+CMP, we do need a change to the code to pick valid output pins in the range 1-4 rather than 1,2,9,A, but it doesn't look like the mapping being added here is quite right for that either. CMP is a derivative of CNP, so I believe we should be following the "CNL-PCH"
>column of the VBT definition.
>
>
>Matt
>
Hi Matt,
Thanks for your comments! Below is EFP configuration from vbt. And we know there is no real port "C" on physical hardware with TGP-PCH.
EFP1 : DisplayPort-B
EFP2 : HDMI-C
EFP3 : HDMI-D
EFP4 : no device
Below messages came from customer board with latest drm-tip kernel (5.10.0-rc1+). Port D/E will be mapped to ddc pin 0x3/0x9 according to icp_ddc_pin_map[].
But port D/E should map to 0x9/0xa on TGP-PCH.
Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_bios_port_aux_ch [i915]] using AUX D for port D (platform default)
Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on [ENCODER:201:DDI D]
Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0x3 for port D (VBT)
Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_bios_port_aux_ch [i915]] using AUX E for port E (platform default)
Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on [ENCODER:205:DDI E]
Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0x9 for port E (VBT)
This is what we got after applied this change.
Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_bios_port_aux_ch [i915]] using AUX D for port D (platform default)
Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on [ENCODER:201:DDI D]
Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0x9 for port D (VBT)
Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_bios_port_aux_ch [i915]] using AUX E for port E (platform default)
Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on [ENCODER:205:DDI E]
Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0xa for port E (VBT)
Best regards,
Shawn
>> ICL_DDC_BUS_PORT_1 = 0x4,
>> ICL_DDC_BUS_PORT_2,
>> ICL_DDC_BUS_PORT_3,
>> --
>> 2.28.0
>>
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/rkl: new rkl ddc map for different PCH
2020-10-31 2:55 ` Lee, Shawn C
@ 2020-11-02 6:12 ` Matt Roper
2020-11-02 13:37 ` Lee, Shawn C
0 siblings, 1 reply; 24+ messages in thread
From: Matt Roper @ 2020-11-02 6:12 UTC (permalink / raw)
To: 20201030134137.30867-1-shawn.c.lee; +Cc: Chiou, Cooper, intel-gfx
On Fri, Oct 30, 2020 at 07:55:35PM -0700, Lee, Shawn C wrote:
>
> On Fri, Oct. 30, 2020, 5:35 p.m., Matt Roper wrote:
> >On Fri, Oct 30, 2020 at 09:41:37PM +0800, Lee Shawn C wrote:
> >> After boot into kernel. Driver configured ddc pin mapping based on
> >> predefined table in parse_ddi_port(). Now driver configure rkl ddc pin
> >> mapping depends on icp_ddc_pin_map[]. Then this table will give
> >> incorrect gmbus port number to cause HDMI can't work.
> >>
> >> Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
> >> Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can works
> >> properly on rkl.
> >>
> >> v2: update patch based on latest dinq branch.
> >>
> >> Cc: Matt Roper <matthew.d.roper@intel.com>
> >> Cc: Aditya Swarup <aditya.swarup@intel.com>
> >> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> >> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> >> Cc: Cooper Chiou <cooper.chiou@intel.com>
> >> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
> >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
> >> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_bios.c | 20 +++++++++++++++++++
> >> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 ++++
> >> 2 files changed, 24 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
> >> b/drivers/gpu/drm/i915/display/intel_bios.c
> >> index 0a309645fe06..ca9426e1768a 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> >> @@ -1623,6 +1623,18 @@ static const u8 icp_ddc_pin_map[] = {
> >> [TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP, };
> >>
> >> +static const u8 rkl_pch_tgp_ddc_pin_map[] = {
> >> +[RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
> >> +[RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
> >> +[RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP, };
> >> +
> >> +static const u8 rkl_pch_cmp_ddc_pin_map[] = {
> >> +[RKL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
> >> +[RKL_DDC_BUS_DDI_D] = GMBUS_PIN_3_BXT,
> >> +[RKL_DDC_BUS_DDI_E] = GMBUS_PIN_4_CNP, };
> >> +
> >> static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
> >> {
> >> const u8 *ddc_pin_map;
> >> @@ -1630,6 +1642,14 @@ static u8 map_ddc_pin(struct drm_i915_private
> >> *dev_priv, u8 vbt_pin)
> >>
> >> if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
> >> return vbt_pin;
> >> +} else if (IS_ROCKETLAKE(dev_priv)) {
> >> +if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP) {
> >> +ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
> >> +n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
> >> +} else {
> >> +ddc_pin_map = rkl_pch_cmp_ddc_pin_map;
> >> +n_entries = ARRAY_SIZE(rkl_pch_cmp_ddc_pin_map);
> >> +}
> >> } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
> >> ddc_pin_map = icp_ddc_pin_map;
> >> n_entries = ARRAY_SIZE(icp_ddc_pin_map); diff --git
> >> a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> >> b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> >> index 49b4b5fca941..2df009996128 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> >> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> >> @@ -319,6 +319,10 @@ enum vbt_gmbus_ddi {
> >> ICL_DDC_BUS_DDI_A = 0x1,
> >> ICL_DDC_BUS_DDI_B,
> >> TGL_DDC_BUS_DDI_C,
> >> +RKL_DDC_BUS_DDI_B = 0x1,
> >> +RKL_DDC_BUS_DDI_C,
> >> +RKL_DDC_BUS_DDI_D,
> >> +RKL_DDC_BUS_DDI_E,
> >
> >These definitions don't really make sense; according to the VBT definition in the bspec (20124), the symbolic names map to different VBT input values depending on which PCH is paired with RKL. E.g., VBT value of "2" refers to PHY-C when using a CMP PCH, but refers to PHY-B when using a TGP PCH.
> >
> >From what I can see, RKL+TGP is already handled properly today in the code and doesn't need any special handling. The patch here would actually break it, because it would associate the wrong pins to outputs (and fail to associate anything at all with PHY-B [vbt value 2]).
> >
> >For RKL+CMP, we do need a change to the code to pick valid output pins in the range 1-4 rather than 1,2,9,A, but it doesn't look like the mapping being added here is quite right for that either. CMP is a derivative of CNP, so I believe we should be following the "CNL-PCH"
> >column of the VBT definition.
> >
> >
> >Matt
> >
>
> Hi Matt,
>
> Thanks for your comments! Below is EFP configuration from vbt. And we
> know there is no real port "C" on physical hardware with TGP-PCH.
The terminology gets somewhat confusing, so just for clarity, the
outputs on RKL in general are:
DDI-A (aka PORT-A) <-> PHY-A
DDI-B (aka PORT-B) <-> PHY-B
DDI-TC1 (aka PORT-D) <-> PHY-C
DDI-TC2 (aka PORT-E) <-> PHY-D
Note that on recent platforms where the DDI and PHY are separate blocks
we try to use the term "port" to refer to the DDI. And based on their
register offsets, we treat DDI-TC1 and DDI-TC2 as ports D and E in i915,
even though that's not something the bspec does.
It looks like the proper table for RKL+TGP should actually be:
static const u8 rkl_pch_tgp_ddc_pin_map[] = {
[1] = GMBUS_PIN_1_BXT,
[2] = GMBUS_PIN_2_BXT,
[3] = GMBUS_PIN_9_TC1_ICP,
[4] = GMBUS_PIN_10_TC2_ICP,
}
i.e., basically the same as what you had, but we do need to handle the
input value '1' too since we can legitimately drive HDMI on all four of
the outputs when using a TGP PCH.
When we're instead working on a RKL+CMP platform DDI-A output (if
present) will always be eDP; there's no support for HDMI in that case.
So for RKL+CMP the gmbus pin mapping needs to be
0x1 (DDI-B) -> 0x1
0x2 (DDI-C) -> 0x2
0x3 (DDI-D) -> 0x4
The cnp_ddc_pin_map[] table that we already have in the code should
handle that properly, so there's no need for special RKL+CMP handling;
we can just let it fall through to the existing HAS_PCH_CNP() branch.
However I think rkl_port_to_ddc_pin() is off by one for the values it's
returning on CMP; we need to fix that so that cases where the VBT
doesn't specify a valid DDC pin.
Matt
> EFP1 : DisplayPort-B
> EFP2 : HDMI-C
> EFP3 : HDMI-D
> EFP4 : no device
>
> Below messages came from customer board with latest drm-tip kernel (5.10.0-rc1+). Port D/E will be mapped to ddc pin 0x3/0x9 according to icp_ddc_pin_map[].
> But port D/E should map to 0x9/0xa on TGP-PCH.
> Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_bios_port_aux_ch [i915]] using AUX D for port D (platform default)
> Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on [ENCODER:201:DDI D]
> Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0x3 for port D (VBT)
> Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_bios_port_aux_ch [i915]] using AUX E for port E (platform default)
> Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on [ENCODER:205:DDI E]
> Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0x9 for port E (VBT)
>
> This is what we got after applied this change.
> Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_bios_port_aux_ch [i915]] using AUX D for port D (platform default)
> Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on [ENCODER:201:DDI D]
> Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0x9 for port D (VBT)
> Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_bios_port_aux_ch [i915]] using AUX E for port E (platform default)
> Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on [ENCODER:205:DDI E]
> Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0: [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0xa for port E (VBT)
>
> Best regards,
> Shawn
>
> >> ICL_DDC_BUS_PORT_1 = 0x4,
> >> ICL_DDC_BUS_PORT_2,
> >> ICL_DDC_BUS_PORT_3,
> >> --
> >> 2.28.0
> >>
> >
> >--
> >Matt Roper
> >Graphics Software Engineer
> >VTT-OSGC Platform Enablement
> >Intel Corporation
> >(916) 356-2795
> >
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/rkl: new rkl ddc map for different PCH
2020-11-02 6:12 ` Matt Roper
@ 2020-11-02 13:37 ` Lee, Shawn C
0 siblings, 0 replies; 24+ messages in thread
From: Lee, Shawn C @ 2020-11-02 13:37 UTC (permalink / raw)
To: Roper, Matthew D, intel-gfx; +Cc: Chiou, Cooper
On Mon, November 2, 2020 2:12 PM Matt Roper wrote:
>On Fri, Oct 30, 2020 at 07:55:35PM -0700, Lee, Shawn C wrote:
>> On Fri, Oct. 30, 2020, 5:35 p.m., Matt Roper wrote:
>> >On Fri, Oct 30, 2020 at 09:41:37PM +0800, Lee Shawn C wrote:
>> >> After boot into kernel. Driver configured ddc pin mapping based on
>> >> predefined table in parse_ddi_port(). Now driver configure rkl ddc
>> >> pin mapping depends on icp_ddc_pin_map[]. Then this table will give
>> >> incorrect gmbus port number to cause HDMI can't work.
>> >>
>> >> Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
>> >> Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can
>> >> works properly on rkl.
>> >>
>> >> v2: update patch based on latest dinq branch.
>> >>
>> >> Cc: Matt Roper <matthew.d.roper@intel.com>
>> >> Cc: Aditya Swarup <aditya.swarup@intel.com>
>> >> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> >> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> >> Cc: Cooper Chiou <cooper.chiou@intel.com>
>> >> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
>> >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
>> >> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> >> ---
>> >> drivers/gpu/drm/i915/display/intel_bios.c | 20 +++++++++++++++++++
>> >> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 ++++
>> >> 2 files changed, 24 insertions(+)
>> >>
>> >> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
>> >> b/drivers/gpu/drm/i915/display/intel_bios.c
>> >> index 0a309645fe06..ca9426e1768a 100644
>> >> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> >> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> >> @@ -1623,6 +1623,18 @@ static const u8 icp_ddc_pin_map[] = {
>> >> [TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP, };
>> >>
>> >> +static const u8 rkl_pch_tgp_ddc_pin_map[] = { [RKL_DDC_BUS_DDI_B]
>> >> += GMBUS_PIN_2_BXT, [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
>> >> +[RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP, };
>> >> +
>> >> +static const u8 rkl_pch_cmp_ddc_pin_map[] = { [RKL_DDC_BUS_DDI_B]
>> >> += GMBUS_PIN_2_BXT, [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_3_BXT,
>> >> +[RKL_DDC_BUS_DDI_E] = GMBUS_PIN_4_CNP, };
>> >> +
>> >> static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8
>> >> vbt_pin) { const u8 *ddc_pin_map; @@ -1630,6 +1642,14 @@ static u8
>> >> map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
>> >>
>> >> if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) { return vbt_pin;
>> >> +} else if (IS_ROCKETLAKE(dev_priv)) { if (INTEL_PCH_TYPE(dev_priv)
>> >> +>= PCH_TGP) { ddc_pin_map = rkl_pch_tgp_ddc_pin_map; n_entries =
>> >> +ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
>> >> +} else {
>> >> +ddc_pin_map = rkl_pch_cmp_ddc_pin_map; n_entries =
>> >> +ARRAY_SIZE(rkl_pch_cmp_ddc_pin_map);
>> >> +}
>> >> } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) { ddc_pin_map =
>> >> icp_ddc_pin_map; n_entries = ARRAY_SIZE(icp_ddc_pin_map); diff
>> >> --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> >> b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> >> index 49b4b5fca941..2df009996128 100644
>> >> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> >> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> >> @@ -319,6 +319,10 @@ enum vbt_gmbus_ddi { ICL_DDC_BUS_DDI_A = 0x1,
>> >> ICL_DDC_BUS_DDI_B, TGL_DDC_BUS_DDI_C,
>> >> +RKL_DDC_BUS_DDI_B = 0x1,
>> >> +RKL_DDC_BUS_DDI_C,
>> >> +RKL_DDC_BUS_DDI_D,
>> >> +RKL_DDC_BUS_DDI_E,
>> >
>> >These definitions don't really make sense; according to the VBT definition in the bspec (20124), the symbolic names map to different VBT input values depending on which PCH is paired with RKL. E.g., VBT value of "2" refers to PHY-C when using a CMP PCH, but refers to PHY-B when using a TGP PCH.
>> >
>> >From what I can see, RKL+TGP is already handled properly today in the code and doesn't need any special handling. The patch here would actually break it, because it would associate the wrong pins to outputs (and fail to associate anything at all with PHY-B [vbt value 2]).
>> >
>> >For RKL+CMP, we do need a change to the code to pick valid output pins in the range 1-4 rather than 1,2,9,A, but it doesn't look like the mapping being added here is quite right for that either. CMP is a derivative of CNP, so I believe we should be following the "CNL-PCH"
>> >column of the VBT definition.
>> >
>> >
>> >Matt
>> >
>>
>> Hi Matt,
>>
>> Thanks for your comments! Below is EFP configuration from vbt. And we
>> know there is no real port "C" on physical hardware with TGP-PCH.
>
>The terminology gets somewhat confusing, so just for clarity, the outputs on RKL in general are:
>
> DDI-A (aka PORT-A) <-> PHY-A
> DDI-B (aka PORT-B) <-> PHY-B
> DDI-TC1 (aka PORT-D) <-> PHY-C
> DDI-TC2 (aka PORT-E) <-> PHY-D
>
>Note that on recent platforms where the DDI and PHY are separate blocks we try to use the term "port" to refer to the DDI. And based on their register offsets, we treat DDI-TC1 and DDI-TC2 as ports D and E in i915, even though that's not something the bspec does.
>
>It looks like the proper table for RKL+TGP should actually be:
>
> static const u8 rkl_pch_tgp_ddc_pin_map[] = {
> [1] = GMBUS_PIN_1_BXT,
> [2] = GMBUS_PIN_2_BXT,
> [3] = GMBUS_PIN_9_TC1_ICP,
> [4] = GMBUS_PIN_10_TC2_ICP,
> }
>
Thanks for clarification! I will update table like this.
>i.e., basically the same as what you had, but we do need to handle the input value '1' too since we can legitimately drive HDMI on all four of the outputs when using a TGP PCH.
>
>When we're instead working on a RKL+CMP platform DDI-A output (if
>present) will always be eDP; there's no support for HDMI in that case.
>So for RKL+CMP the gmbus pin mapping needs to be
>
> 0x1 (DDI-B) -> 0x1
> 0x2 (DDI-C) -> 0x2
> 0x3 (DDI-D) -> 0x4
>
>The cnp_ddc_pin_map[] table that we already have in the code should handle that properly, so there's no need for special RKL+CMP handling; we can just let it fall through to the existing HAS_PCH_CNP() branch.
OK! If RKL+CMP sku, driver will load cnp_ddc_pin_map[] just like original design. The new table will be removed.
>However I think rkl_port_to_ddc_pin() is off by one for the values it's returning on CMP; we need to fix that so that cases where the VBT doesn't specify a valid DDC pin.
>
Looks like we need some changes in rkl_port_to_ddc_pin() like below. What do you think?
if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP && phy > PHY_C)
return GMBUS_PIN_9_TC1_ICP + phy - PHY_D;
>
>Matt
>
>> EFP1 : DisplayPort-B
>> EFP2 : HDMI-C
>> EFP3 : HDMI-D
>> EFP4 : no device
>>
>> Below messages came from customer board with latest drm-tip kernel (5.10.0-rc1+). Port D/E will be mapped to ddc pin 0x3/0x9 according to icp_ddc_pin_map[].
>> But port D/E should map to 0x9/0xa on TGP-PCH.
>> Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_bios_port_aux_ch [i915]] using AUX D for port D (platform
>> default) Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on
>> [ENCODER:201:DDI D] Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0x3 for port D
>> (VBT) Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_bios_port_aux_ch [i915]] using AUX E for port E (platform
>> default) Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on
>> [ENCODER:205:DDI E] Oct 23 18:39:14 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0x9 for port E
>> (VBT)
>>
>> This is what we got after applied this change.
>> Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_bios_port_aux_ch [i915]] using AUX D for port D (platform
>> default) Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on
>> [ENCODER:201:DDI D] Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0x9 for port D
>> (VBT) Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_bios_port_aux_ch [i915]] using AUX E for port E (platform
>> default) Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_hdmi_init_connector [i915]] Adding HDMI connector on
>> [ENCODER:205:DDI E] Oct 28 18:18:47 ubuntu kernel: i915 0000:00:02.0:
>> [drm:intel_hdmi_init_connector [i915]] Using DDC pin 0xa for port E
>> (VBT)
>>
>> Best regards,
>> Shawn
>>
>> >> ICL_DDC_BUS_PORT_1 = 0x4,
>> >> ICL_DDC_BUS_PORT_2,
>> >> ICL_DDC_BUS_PORT_3,
>> >> --
>> >> 2.28.0
>> >>
>> >
>> >--
>> >Matt Roper
>> >Graphics Software Engineer
>> >VTT-OSGC Platform Enablement
>> >Intel Corporation
>> >(916) 356-2795
>> >
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795
Best regards,
Shawn
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] [PATCH v3] drm/i915/rkl: new rkl ddc map for different PCH
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (5 preceding siblings ...)
2020-10-30 19:34 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-11-02 13:56 ` Lee Shawn C
2020-11-10 15:17 ` Lee, Shawn C
2020-11-12 23:53 ` Matt Roper
2020-11-02 14:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rkl: new rkl ddc map for different PCH (rev3) Patchwork
` (5 subsequent siblings)
12 siblings, 2 replies; 24+ messages in thread
From: Lee Shawn C @ 2020-11-02 13:56 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou
After boot into kernel. Driver configured ddc pin mapping based on
predefined table in parse_ddi_port(). Now driver configure rkl
ddc pin mapping depends on icp_ddc_pin_map[]. Then this table will
give incorrect gmbus port number to cause HDMI can't work.
Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can
works properly on rkl.
v2: update patch based on latest dinq branch.
v3: update ddc table for RKL+TGP sku.
RKL+CNP sku will load cnp_ddc_pin_map[] setting.
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Aditya Swarup <aditya.swarup@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 16 ++++++++++++++--
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 4cc949b228f2..4de991bafd10 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1623,6 +1623,13 @@ static const u8 icp_ddc_pin_map[] = {
[TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP,
};
+static const u8 rkl_pch_tgp_ddc_pin_map[] = {
+ [ICL_DDC_BUS_DDI_A] = GMBUS_PIN_1_BXT,
+ [ICL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
+ [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
+ [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP,
+};
+
static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
{
const u8 *ddc_pin_map;
@@ -1631,8 +1638,13 @@ static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
return vbt_pin;
} else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
- ddc_pin_map = icp_ddc_pin_map;
- n_entries = ARRAY_SIZE(icp_ddc_pin_map);
+ if (IS_ROCKETLAKE(dev_priv)) {
+ ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
+ n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
+ } else {
+ ddc_pin_map = icp_ddc_pin_map;
+ n_entries = ARRAY_SIZE(icp_ddc_pin_map);
+ }
} else if (HAS_PCH_CNP(dev_priv)) {
ddc_pin_map = cnp_ddc_pin_map;
n_entries = ARRAY_SIZE(cnp_ddc_pin_map);
diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index 49b4b5fca941..187ec573de59 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -319,6 +319,8 @@ enum vbt_gmbus_ddi {
ICL_DDC_BUS_DDI_A = 0x1,
ICL_DDC_BUS_DDI_B,
TGL_DDC_BUS_DDI_C,
+ RKL_DDC_BUS_DDI_D = 0x3,
+ RKL_DDC_BUS_DDI_E,
ICL_DDC_BUS_PORT_1 = 0x4,
ICL_DDC_BUS_PORT_2,
ICL_DDC_BUS_PORT_3,
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rkl: new rkl ddc map for different PCH (rev3)
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (6 preceding siblings ...)
2020-11-02 13:56 ` [Intel-gfx] [PATCH v3] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
@ 2020-11-02 14:12 ` Patchwork
2020-11-02 14:31 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (4 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2020-11-02 14:12 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/rkl: new rkl ddc map for different PCH (rev3)
URL : https://patchwork.freedesktop.org/series/83154/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c0a38bfa9c23 drm/i915/rkl: new rkl ddc map for different PCH
-:11: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'd0a89527d06', maybe rebased or not pulled?
#11:
Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
total: 0 errors, 1 warnings, 0 checks, 36 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/rkl: new rkl ddc map for different PCH (rev3)
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (7 preceding siblings ...)
2020-11-02 14:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rkl: new rkl ddc map for different PCH (rev3) Patchwork
@ 2020-11-02 14:31 ` Patchwork
2020-11-17 14:19 ` [Intel-gfx] [PATCH v4] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (3 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2020-11-02 14:31 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5024 bytes --]
== Series Details ==
Series: drm/i915/rkl: new rkl ddc map for different PCH (rev3)
URL : https://patchwork.freedesktop.org/series/83154/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9245 -> Patchwork_18826
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18826 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18826, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18826/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18826:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@reload:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9245/fi-skl-lmem/igt@i915_module_load@reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18826/fi-skl-lmem/igt@i915_module_load@reload.html
New tests
---------
New tests have been introduced between CI_DRM_9245 and Patchwork_18826:
### New CI tests (1) ###
* boot:
- Statuses : 38 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18826 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9245/fi-byt-j1900/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18826/fi-byt-j1900/igt@i915_module_load@reload.html
- fi-tgl-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#1982] / [k.org#205379])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9245/fi-tgl-u2/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18826/fi-tgl-u2/igt@i915_module_load@reload.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9245/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18826/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-cfl-8109u: [DMESG-WARN][9] -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9245/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18826/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html
* igt@i915_module_load@reload:
- fi-icl-y: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9245/fi-icl-y/igt@i915_module_load@reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18826/fi-icl-y/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9245/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18826/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9245/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18826/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (42 -> 38)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9245 -> Patchwork_18826
CI-20190529: 20190529
CI_DRM_9245: 02c27d0ee1335328e9d87ed1a0932671efbb0d5c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5830: 12d370cb57e0cfcb781c87ad9e15e68b17a1f41f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18826: c0a38bfa9c23a6b42bf1ebb3003349951582730e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c0a38bfa9c23 drm/i915/rkl: new rkl ddc map for different PCH
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18826/index.html
[-- Attachment #1.2: Type: text/html, Size: 6203 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH v3] drm/i915/rkl: new rkl ddc map for different PCH
2020-11-02 13:56 ` [Intel-gfx] [PATCH v3] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
@ 2020-11-10 15:17 ` Lee, Shawn C
2020-11-12 23:53 ` Matt Roper
1 sibling, 0 replies; 24+ messages in thread
From: Lee, Shawn C @ 2020-11-10 15:17 UTC (permalink / raw)
To: intel-gfx; +Cc: Chiou, Cooper
On Mon, Nov 2, 2020 at 01:56PM, Lee Shawn C wrote:
>After boot into kernel. Driver configured ddc pin mapping based on predefined table in parse_ddi_port(). Now driver configure rkl ddc pin mapping depends on icp_ddc_pin_map[]. Then this table will give incorrect gmbus port number to cause HDMI can't work.
>
>Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
>Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can works properly on rkl.
>
>v2: update patch based on latest dinq branch.
>v3: update ddc table for RKL+TGP sku.
> RKL+CNP sku will load cnp_ddc_pin_map[] setting.
Hi Matt, may i have your comment about this patch v3? Thanks!
Best regards,
Shawn
>
>Cc: Matt Roper <matthew.d.roper@intel.com>
>Cc: Aditya Swarup <aditya.swarup@intel.com>
>Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>Cc: Jani Nikula <jani.nikula@linux.intel.com>
>Cc: Cooper Chiou <cooper.chiou@intel.com>
>Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
>Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
>Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_bios.c | 16 ++++++++++++++--
> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
> 2 files changed, 16 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>index 4cc949b228f2..4de991bafd10 100644
>--- a/drivers/gpu/drm/i915/display/intel_bios.c
>+++ b/drivers/gpu/drm/i915/display/intel_bios.c
>@@ -1623,6 +1623,13 @@ static const u8 icp_ddc_pin_map[] = {
> [TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP, };
>
>+static const u8 rkl_pch_tgp_ddc_pin_map[] = {
>+ [ICL_DDC_BUS_DDI_A] = GMBUS_PIN_1_BXT,
>+ [ICL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
>+ [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
>+ [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP, };
>+
> static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin) {
> const u8 *ddc_pin_map;
>@@ -1631,8 +1638,13 @@ static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
> if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
> return vbt_pin;
> } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
>- ddc_pin_map = icp_ddc_pin_map;
>- n_entries = ARRAY_SIZE(icp_ddc_pin_map);
>+ if (IS_ROCKETLAKE(dev_priv)) {
>+ ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
>+ n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
>+ } else {
>+ ddc_pin_map = icp_ddc_pin_map;
>+ n_entries = ARRAY_SIZE(icp_ddc_pin_map);
>+ }
> } else if (HAS_PCH_CNP(dev_priv)) {
> ddc_pin_map = cnp_ddc_pin_map;
> n_entries = ARRAY_SIZE(cnp_ddc_pin_map); diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>index 49b4b5fca941..187ec573de59 100644
>--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>@@ -319,6 +319,8 @@ enum vbt_gmbus_ddi {
> ICL_DDC_BUS_DDI_A = 0x1,
> ICL_DDC_BUS_DDI_B,
> TGL_DDC_BUS_DDI_C,
>+ RKL_DDC_BUS_DDI_D = 0x3,
>+ RKL_DDC_BUS_DDI_E,
> ICL_DDC_BUS_PORT_1 = 0x4,
> ICL_DDC_BUS_PORT_2,
> ICL_DDC_BUS_PORT_3,
>--
>2.17.1
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH v3] drm/i915/rkl: new rkl ddc map for different PCH
2020-11-02 13:56 ` [Intel-gfx] [PATCH v3] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
2020-11-10 15:17 ` Lee, Shawn C
@ 2020-11-12 23:53 ` Matt Roper
2020-11-13 0:14 ` Lee, Shawn C
1 sibling, 1 reply; 24+ messages in thread
From: Matt Roper @ 2020-11-12 23:53 UTC (permalink / raw)
To: Lee Shawn C; +Cc: Cooper Chiou, intel-gfx
On Mon, Nov 02, 2020 at 09:56:14PM +0800, Lee Shawn C wrote:
> After boot into kernel. Driver configured ddc pin mapping based on
> predefined table in parse_ddi_port(). Now driver configure rkl
> ddc pin mapping depends on icp_ddc_pin_map[]. Then this table will
> give incorrect gmbus port number to cause HDMI can't work.
>
> Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
> Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can
> works properly on rkl.
>
> v2: update patch based on latest dinq branch.
> v3: update ddc table for RKL+TGP sku.
> RKL+CNP sku will load cnp_ddc_pin_map[] setting.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Aditya Swarup <aditya.swarup@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 16 ++++++++++++++--
> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
> 2 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 4cc949b228f2..4de991bafd10 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1623,6 +1623,13 @@ static const u8 icp_ddc_pin_map[] = {
> [TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP,
> };
>
> +static const u8 rkl_pch_tgp_ddc_pin_map[] = {
> + [ICL_DDC_BUS_DDI_A] = GMBUS_PIN_1_BXT,
> + [ICL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
> + [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
> + [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP,
> +};
> +
> static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
> {
> const u8 *ddc_pin_map;
> @@ -1631,8 +1638,13 @@ static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
> if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
> return vbt_pin;
> } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
> - ddc_pin_map = icp_ddc_pin_map;
> - n_entries = ARRAY_SIZE(icp_ddc_pin_map);
> + if (IS_ROCKETLAKE(dev_priv)) {
> + ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
> + n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
It's probably best to just keep this at the top-level of the if/else
chain rather than nesting.
...
} else if (IS_ROCKETLAKE(dev_priv) && INTEL_PCH_TYPE(dev_priv) == PCH_TGP) {
ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
} else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
...
The RKL+CMP pairing will still fall through to the PCH_CNP case
properly if we do this.
Also, I think we still need an update to rkl_port_to_ddc_pin() to handle
the CMP case properly when the VBT doesn't specify a valid pin to use
with the output. I.e., the final return should be
return GMBUS_PIN_1_BXT + phy - 1;
since by default CNP/CMP's DDI-B should start with an input to the
mapping table of 1 rather than 2 (according to bspec 20124).
Matt
> + } else {
> + ddc_pin_map = icp_ddc_pin_map;
> + n_entries = ARRAY_SIZE(icp_ddc_pin_map);
> + }
> } else if (HAS_PCH_CNP(dev_priv)) {
> ddc_pin_map = cnp_ddc_pin_map;
> n_entries = ARRAY_SIZE(cnp_ddc_pin_map);
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index 49b4b5fca941..187ec573de59 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -319,6 +319,8 @@ enum vbt_gmbus_ddi {
> ICL_DDC_BUS_DDI_A = 0x1,
> ICL_DDC_BUS_DDI_B,
> TGL_DDC_BUS_DDI_C,
> + RKL_DDC_BUS_DDI_D = 0x3,
> + RKL_DDC_BUS_DDI_E,
> ICL_DDC_BUS_PORT_1 = 0x4,
> ICL_DDC_BUS_PORT_2,
> ICL_DDC_BUS_PORT_3,
> --
> 2.17.1
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH v3] drm/i915/rkl: new rkl ddc map for different PCH
2020-11-12 23:53 ` Matt Roper
@ 2020-11-13 0:14 ` Lee, Shawn C
0 siblings, 0 replies; 24+ messages in thread
From: Lee, Shawn C @ 2020-11-13 0:14 UTC (permalink / raw)
To: Roper, Matthew D, intel-gfx; +Cc: Chiou, Cooper
On Thu, Nov. 12, 2020, 11:53 p.m., Matt Roper wrote:
>On Mon, Nov 02, 2020 at 09:56:14PM +0800, Lee Shawn C wrote:
>> After boot into kernel. Driver configured ddc pin mapping based on
>> predefined table in parse_ddi_port(). Now driver configure rkl ddc pin
>> mapping depends on icp_ddc_pin_map[]. Then this table will give
>> incorrect gmbus port number to cause HDMI can't work.
>>
>> Refer to commit d0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
>> Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can works
>> properly on rkl.
>>
>> v2: update patch based on latest dinq branch.
>> v3: update ddc table for RKL+TGP sku.
>> RKL+CNP sku will load cnp_ddc_pin_map[] setting.
>>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Cc: Aditya Swarup <aditya.swarup@intel.com>
>> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.c | 16 ++++++++++++++--
>> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
>> 2 files changed, 16 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
>> b/drivers/gpu/drm/i915/display/intel_bios.c
>> index 4cc949b228f2..4de991bafd10 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -1623,6 +1623,13 @@ static const u8 icp_ddc_pin_map[] = {
>> [TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP, };
>>
>> +static const u8 rkl_pch_tgp_ddc_pin_map[] = {
>> + [ICL_DDC_BUS_DDI_A] = GMBUS_PIN_1_BXT,
>> + [ICL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
>> + [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
>> + [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP, };
>> +
>> static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
>> {
>> const u8 *ddc_pin_map;
>> @@ -1631,8 +1638,13 @@ static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
>> if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
>> return vbt_pin;
>> } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
>> - ddc_pin_map = icp_ddc_pin_map;
>> - n_entries = ARRAY_SIZE(icp_ddc_pin_map);
>> + if (IS_ROCKETLAKE(dev_priv)) {
>> + ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
>> + n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
>
>It's probably best to just keep this at the top-level of the if/else chain rather than nesting.
>
> ...
> } else if (IS_ROCKETLAKE(dev_priv) && INTEL_PCH_TYPE(dev_priv) == PCH_TGP) {
> ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
> n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
> } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
> ...
Thanks, Matt! I will modify the code like this.
>
>The RKL+CMP pairing will still fall through to the PCH_CNP case properly if we do this.
>
>Also, I think we still need an update to rkl_port_to_ddc_pin() to handle the CMP case properly when the VBT doesn't specify a valid pin to use with the output. I.e., the final return should be
>
> return GMBUS_PIN_1_BXT + phy - 1;
>
>since by default CNP/CMP's DDI-B should start with an input to the mapping table of 1 rather than 2 (according to bspec 20124).
>
So, it looks like we need additioal patch to fix it. Do you know who will help on this? Thanks!
Best regards,
Shawn
>
>Matt
>
>
>> + } else {
>> + ddc_pin_map = icp_ddc_pin_map;
>> + n_entries = ARRAY_SIZE(icp_ddc_pin_map);
>> + }
>> } else if (HAS_PCH_CNP(dev_priv)) {
>> ddc_pin_map = cnp_ddc_pin_map;
>> n_entries = ARRAY_SIZE(cnp_ddc_pin_map); diff --git
>> a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> index 49b4b5fca941..187ec573de59 100644
>> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> @@ -319,6 +319,8 @@ enum vbt_gmbus_ddi {
>> ICL_DDC_BUS_DDI_A = 0x1,
>> ICL_DDC_BUS_DDI_B,
>> TGL_DDC_BUS_DDI_C,
>> + RKL_DDC_BUS_DDI_D = 0x3,
>> + RKL_DDC_BUS_DDI_E,
>> ICL_DDC_BUS_PORT_1 = 0x4,
>> ICL_DDC_BUS_PORT_2,
>> ICL_DDC_BUS_PORT_3,
>> --
>> 2.17.1
>>
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] [PATCH v4] drm/i915/rkl: new rkl ddc map for different PCH
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (8 preceding siblings ...)
2020-11-02 14:31 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2020-11-17 14:19 ` Lee Shawn C
2020-11-17 14:26 ` [Intel-gfx] [PATCH v5] " Lee Shawn C
` (2 subsequent siblings)
12 siblings, 0 replies; 24+ messages in thread
From: Lee Shawn C @ 2020-11-17 14:19 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou
After boot into kernel. Driver configured ddc pin mapping based on
predefined table in parse_ddi_port(). Now driver configure rkl
ddc pin mapping depends on icp_ddc_pin_map[]. Then this table will
give incorrect gmbus port number to cause HDMI can't work.
Refer to commit cd0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can
works properly on rkl.
v2: update patch based on latest dinq branch.
v3: update ddc table for RKL+TGP sku.
RKL+CNP sku will load cnp_ddc_pin_map[] setting.
v4: modify the if/else judgment to avoid nesting.
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Aditya Swarup <aditya.swarup@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 7 +++++++
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
2 files changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 4cc949b228f2..823fabdb5c94 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1623,6 +1623,13 @@ static const u8 icp_ddc_pin_map[] = {
[TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP,
};
+static const u8 rkl_pch_tgp_ddc_pin_map[] = {
+ [ICL_DDC_BUS_DDI_A] = GMBUS_PIN_1_BXT,
+ [ICL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
+ [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
+ [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP,
+};
+
static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
{
const u8 *ddc_pin_map;
diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index 49b4b5fca941..187ec573de59 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -319,6 +319,8 @@ enum vbt_gmbus_ddi {
ICL_DDC_BUS_DDI_A = 0x1,
ICL_DDC_BUS_DDI_B,
TGL_DDC_BUS_DDI_C,
+ RKL_DDC_BUS_DDI_D = 0x3,
+ RKL_DDC_BUS_DDI_E,
ICL_DDC_BUS_PORT_1 = 0x4,
ICL_DDC_BUS_PORT_2,
ICL_DDC_BUS_PORT_3,
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [Intel-gfx] [PATCH v5] drm/i915/rkl: new rkl ddc map for different PCH
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (9 preceding siblings ...)
2020-11-17 14:19 ` [Intel-gfx] [PATCH v4] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
@ 2020-11-17 14:26 ` Lee Shawn C
2020-11-19 23:51 ` Matt Roper
2020-11-17 23:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rkl: new rkl ddc map for different PCH (rev5) Patchwork
2020-11-18 4:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
12 siblings, 1 reply; 24+ messages in thread
From: Lee Shawn C @ 2020-11-17 14:26 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou
After boot into kernel. Driver configured ddc pin mapping based on
predefined table in parse_ddi_port(). Now driver configure rkl
ddc pin mapping depends on icp_ddc_pin_map[]. Then this table will
give incorrect gmbus port number to cause HDMI can't work.
Refer to commit cd0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can
works properly on rkl.
v2: update patch based on latest dinq branch.
v3: update ddc table for RKL+TGP sku.
RKL+CNP sku will load cnp_ddc_pin_map[] setting.
v4: modify the if/else judgment to avoid nesting.
v5: fix typo in v4.
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Aditya Swarup <aditya.swarup@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 10 ++++++++++
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
2 files changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 4cc949b228f2..cf2fba490b7b 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1623,6 +1623,13 @@ static const u8 icp_ddc_pin_map[] = {
[TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP,
};
+static const u8 rkl_pch_tgp_ddc_pin_map[] = {
+ [ICL_DDC_BUS_DDI_A] = GMBUS_PIN_1_BXT,
+ [ICL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
+ [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
+ [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP,
+};
+
static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
{
const u8 *ddc_pin_map;
@@ -1630,6 +1637,9 @@ static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
return vbt_pin;
+ } else if (IS_ROCKETLAKE(dev_priv) && INTEL_PCH_TYPE(dev_priv) == PCH_TGP) {
+ ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
+ n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
} else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
ddc_pin_map = icp_ddc_pin_map;
n_entries = ARRAY_SIZE(icp_ddc_pin_map);
diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index 49b4b5fca941..187ec573de59 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -319,6 +319,8 @@ enum vbt_gmbus_ddi {
ICL_DDC_BUS_DDI_A = 0x1,
ICL_DDC_BUS_DDI_B,
TGL_DDC_BUS_DDI_C,
+ RKL_DDC_BUS_DDI_D = 0x3,
+ RKL_DDC_BUS_DDI_E,
ICL_DDC_BUS_PORT_1 = 0x4,
ICL_DDC_BUS_PORT_2,
ICL_DDC_BUS_PORT_3,
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rkl: new rkl ddc map for different PCH (rev5)
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (10 preceding siblings ...)
2020-11-17 14:26 ` [Intel-gfx] [PATCH v5] " Lee Shawn C
@ 2020-11-17 23:10 ` Patchwork
2020-11-18 4:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2020-11-17 23:10 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 6394 bytes --]
== Series Details ==
Series: drm/i915/rkl: new rkl ddc map for different PCH (rev5)
URL : https://patchwork.freedesktop.org/series/83154/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9350 -> Patchwork_18923
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/index.html
New tests
---------
New tests have been introduced between CI_DRM_9350 and Patchwork_18923:
### New CI tests (1) ###
* boot:
- Statuses : 41 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18923 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-icl-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-icl-u2/igt@i915_module_load@reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-icl-u2/igt@i915_module_load@reload.html
- fi-kbl-soraka: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-kbl-soraka/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-kbl-soraka/igt@i915_module_load@reload.html
- fi-tgl-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#1982] / [k.org#205379])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-u2/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-tgl-u2/igt@i915_module_load@reload.html
- fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([i915#1982] / [k.org#205379])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-y/igt@i915_module_load@reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-tgl-y/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-7500u: [PASS][9] -> [DMESG-WARN][10] ([i915#203])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-kbl-7500u/igt@i915_pm_rpm@module-reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-kbl-7500u/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bxt-dsi: [PASS][11] -> [DMESG-WARN][12] ([i915#1635] / [i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-bxt-dsi/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-bxt-dsi/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- fi-tgl-y: [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-y/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-tgl-y/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
#### Possible fixes ####
* igt@kms_busy@basic@flip:
- {fi-kbl-7560u}: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-kbl-7560u/igt@kms_busy@basic@flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-kbl-7560u/igt@kms_busy@basic@flip.html
- {fi-tgl-dsi}: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-dsi/igt@kms_busy@basic@flip.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-tgl-dsi/igt@kms_busy@basic@flip.html
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-tgl-y: [DMESG-WARN][23] ([i915#1982]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
* igt@vgem_basic@setversion:
- fi-tgl-y: [DMESG-WARN][25] ([i915#402]) -> [PASS][26] +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-y/igt@vgem_basic@setversion.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/fi-tgl-y/igt@vgem_basic@setversion.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (45 -> 41)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9350 -> Patchwork_18923
CI-20190529: 20190529
CI_DRM_9350: 3161d1b26b7e1a7cb9146e3f8bd613f901ff5b38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5855: d9b3c7058efe41e5224dd1e43fac05dc6d049380 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18923: 01e1fe95c13042070184c365b93a449e343acadd @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
01e1fe95c130 drm/i915/rkl: new rkl ddc map for different PCH
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/index.html
[-- Attachment #1.2: Type: text/html, Size: 8049 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/rkl: new rkl ddc map for different PCH (rev5)
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
` (11 preceding siblings ...)
2020-11-17 23:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rkl: new rkl ddc map for different PCH (rev5) Patchwork
@ 2020-11-18 4:08 ` Patchwork
12 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2020-11-18 4:08 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 21885 bytes --]
== Series Details ==
Series: drm/i915/rkl: new rkl ddc map for different PCH (rev5)
URL : https://patchwork.freedesktop.org/series/83154/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9350_full -> Patchwork_18923_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18923_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18923_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18923_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_eio@kms:
- shard-snb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-snb4/igt@gem_eio@kms.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-snb6/igt@gem_eio@kms.html
* igt@gem_exec_whisper@basic-queues-all:
- shard-iclb: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb2/igt@gem_exec_whisper@basic-queues-all.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-iclb4/igt@gem_exec_whisper@basic-queues-all.html
New tests
---------
New tests have been introduced between CI_DRM_9350_full and Patchwork_18923_full:
### New CI tests (1) ###
* boot:
- Statuses : 200 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18923_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-hsw: [PASS][5] -> [FAIL][6] ([i915#2389])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw8/igt@gem_exec_reloc@basic-many-active@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-hsw7/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- shard-snb: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-snb5/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-snb4/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#54]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-tglb: [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb5/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-tglb7/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [PASS][13] -> [FAIL][14] ([i915#96])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982] / [i915#2295])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl7/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl7/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#2346])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-tglb: [PASS][19] -> [FAIL][20] ([i915#2346])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- shard-skl: [PASS][21] -> [DMESG-WARN][22] ([i915#1982]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl7/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl4/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#79])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#2122])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-glk2/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#79])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl10/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-hsw: [PASS][29] -> [INCOMPLETE][30] ([i915#2055])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw6/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-hsw4/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-apl: [PASS][31] -> [DMESG-WARN][32] ([i915#1635] / [i915#1982]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-apl8/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-apl8/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
- shard-iclb: [PASS][33] -> [DMESG-WARN][34] ([i915#1982])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
- shard-glk: [PASS][35] -> [DMESG-WARN][36] ([i915#1982])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk5/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-glk4/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#1982]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#1188]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl5/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: [PASS][41] -> [INCOMPLETE][42] ([i915#198])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-skl: [PASS][43] -> [FAIL][44] ([i915#247])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl9/igt@kms_plane@plane-position-covered-pipe-b-planes.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl5/igt@kms_plane@plane-position-covered-pipe-b-planes.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#109642] / [fdo#111068])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-iclb5/igt@kms_psr2_su@frontbuffer.html
* igt@prime_vgem@basic-fence-flip:
- shard-hsw: [PASS][47] -> [DMESG-WARN][48] ([i915#1982])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw2/igt@prime_vgem@basic-fence-flip.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-hsw6/igt@prime_vgem@basic-fence-flip.html
* igt@sysfs_timeslice_duration@timeout@vecs0:
- shard-skl: [PASS][49] -> [FAIL][50] ([i915#1732])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl2/igt@sysfs_timeslice_duration@timeout@vecs0.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl8/igt@sysfs_timeslice_duration@timeout@vecs0.html
#### Possible fixes ####
* igt@gem_eio@kms:
- shard-hsw: [INCOMPLETE][51] ([i915#1888] / [i915#2244]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw2/igt@gem_eio@kms.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-hsw1/igt@gem_eio@kms.html
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [FAIL][53] ([i915#2389]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk3/igt@gem_exec_reloc@basic-many-active@rcs0.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-glk9/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_suspend@basic-s3:
- shard-glk: [FAIL][55] -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk6/igt@gem_exec_suspend@basic-s3.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-glk9/igt@gem_exec_suspend@basic-s3.html
- shard-kbl: [DMESG-WARN][57] ([i915#180]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl2/igt@gem_exec_suspend@basic-s3.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-kbl3/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_rpm@i2c:
- shard-skl: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl9/igt@i915_pm_rpm@i2c.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl5/igt@i915_pm_rpm@i2c.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-glk: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk1/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-glk2/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* {igt@kms_async_flips@test-time-stamp}:
- shard-tglb: [FAIL][63] ([i915#2597]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb1/igt@kms_async_flips@test-time-stamp.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-tglb5/igt@kms_async_flips@test-time-stamp.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-kbl: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl1/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-kbl7/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-b-cursor-256x85-random:
- shard-skl: [FAIL][67] ([i915#54]) -> [PASS][68] +4 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-256x85-random.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-256x85-random.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][69] ([i915#2346]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions:
- shard-snb: [FAIL][71] -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-snb6/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-snb5/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled:
- shard-apl: [DMESG-WARN][73] ([i915#1635] / [i915#1982]) -> [PASS][74] +5 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-apl7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-apl7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
* igt@kms_flip@dpms-off-confusion@a-vga1:
- shard-hsw: [DMESG-WARN][75] ([i915#1982]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw6/igt@kms_flip@dpms-off-confusion@a-vga1.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-hsw4/igt@kms_flip@dpms-off-confusion@a-vga1.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-tglb: [DMESG-WARN][77] ([i915#1982]) -> [PASS][78] +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][79] ([fdo#108145] / [i915#265]) -> [PASS][80] +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][81] ([fdo#109441]) -> [PASS][82] +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@perf_pmu@module-unload:
- shard-skl: [DMESG-WARN][83] ([i915#1982] / [i915#262]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl10/igt@perf_pmu@module-unload.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-skl9/igt@perf_pmu@module-unload.html
#### Warnings ####
* igt@gem_softpin@noreloc-s3:
- shard-tglb: [DMESG-WARN][85] ([i915#1436]) -> [INCOMPLETE][86] ([i915#1373] / [i915#1436] / [i915#456])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb7/igt@gem_softpin@noreloc-s3.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-tglb6/igt@gem_softpin@noreloc-s3.html
* igt@runner@aborted:
- shard-hsw: [FAIL][87] ([i915#2295] / [i915#2439] / [i915#483]) -> [FAIL][88] ([i915#2295] / [i915#2439])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw1/igt@runner@aborted.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-hsw6/igt@runner@aborted.html
- shard-iclb: ([FAIL][89], [FAIL][90]) ([i915#2295] / [i915#2439] / [i915#483]) -> ([FAIL][91], [FAIL][92]) ([i915#2295] / [i915#2439])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb5/igt@runner@aborted.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb4/igt@runner@aborted.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-iclb3/igt@runner@aborted.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-iclb4/igt@runner@aborted.html
- shard-glk: ([FAIL][93], [FAIL][94]) ([i915#1611] / [i915#2295] / [i915#2439] / [i915#86] / [k.org#202321]) -> ([FAIL][95], [FAIL][96]) ([i915#1611] / [i915#2295] / [i915#2439] / [i915#483] / [i915#86] / [k.org#202321])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk2/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk6/igt@runner@aborted.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-glk1/igt@runner@aborted.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/shard-glk3/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1373]: https://gitlab.freedesktop.org/drm/intel/issues/1373
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1732]: https://gitlab.freedesktop.org/drm/intel/issues/1732
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2244]: https://gitlab.freedesktop.org/drm/intel/issues/2244
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#247]: https://gitlab.freedesktop.org/drm/intel/issues/247
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#86]: https://gitlab.freedesktop.org/drm/intel/issues/86
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9350 -> Patchwork_18923
CI-20190529: 20190529
CI_DRM_9350: 3161d1b26b7e1a7cb9146e3f8bd613f901ff5b38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5855: d9b3c7058efe41e5224dd1e43fac05dc6d049380 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18923: 01e1fe95c13042070184c365b93a449e343acadd @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18923/index.html
[-- Attachment #1.2: Type: text/html, Size: 26346 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH v5] drm/i915/rkl: new rkl ddc map for different PCH
2020-11-17 14:26 ` [Intel-gfx] [PATCH v5] " Lee Shawn C
@ 2020-11-19 23:51 ` Matt Roper
2020-11-20 2:21 ` Lee, Shawn C
0 siblings, 1 reply; 24+ messages in thread
From: Matt Roper @ 2020-11-19 23:51 UTC (permalink / raw)
To: Lee Shawn C; +Cc: Cooper Chiou, intel-gfx
On Tue, Nov 17, 2020 at 10:26:29PM +0800, Lee Shawn C wrote:
> After boot into kernel. Driver configured ddc pin mapping based on
> predefined table in parse_ddi_port(). Now driver configure rkl
> ddc pin mapping depends on icp_ddc_pin_map[]. Then this table will
> give incorrect gmbus port number to cause HDMI can't work.
>
> Refer to commit cd0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
> Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can
> works properly on rkl.
>
> v2: update patch based on latest dinq branch.
> v3: update ddc table for RKL+TGP sku.
> RKL+CNP sku will load cnp_ddc_pin_map[] setting.
> v4: modify the if/else judgment to avoid nesting.
> v5: fix typo in v4.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Aditya Swarup <aditya.swarup@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Do you plan to follow up with a separate patch to fix the CMP handling
in rkl_port_to_ddc_pin that I mentioned previously? I want to make sure
that part doesn't fall through the cracks.
Matt
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 10 ++++++++++
> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
> 2 files changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 4cc949b228f2..cf2fba490b7b 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1623,6 +1623,13 @@ static const u8 icp_ddc_pin_map[] = {
> [TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP,
> };
>
> +static const u8 rkl_pch_tgp_ddc_pin_map[] = {
> + [ICL_DDC_BUS_DDI_A] = GMBUS_PIN_1_BXT,
> + [ICL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
> + [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
> + [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP,
> +};
> +
> static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
> {
> const u8 *ddc_pin_map;
> @@ -1630,6 +1637,9 @@ static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
>
> if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
> return vbt_pin;
> + } else if (IS_ROCKETLAKE(dev_priv) && INTEL_PCH_TYPE(dev_priv) == PCH_TGP) {
> + ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
> + n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
> } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
> ddc_pin_map = icp_ddc_pin_map;
> n_entries = ARRAY_SIZE(icp_ddc_pin_map);
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index 49b4b5fca941..187ec573de59 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -319,6 +319,8 @@ enum vbt_gmbus_ddi {
> ICL_DDC_BUS_DDI_A = 0x1,
> ICL_DDC_BUS_DDI_B,
> TGL_DDC_BUS_DDI_C,
> + RKL_DDC_BUS_DDI_D = 0x3,
> + RKL_DDC_BUS_DDI_E,
> ICL_DDC_BUS_PORT_1 = 0x4,
> ICL_DDC_BUS_PORT_2,
> ICL_DDC_BUS_PORT_3,
> --
> 2.17.1
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH v5] drm/i915/rkl: new rkl ddc map for different PCH
2020-11-19 23:51 ` Matt Roper
@ 2020-11-20 2:21 ` Lee, Shawn C
2020-12-17 7:48 ` Timo Aaltonen
0 siblings, 1 reply; 24+ messages in thread
From: Lee, Shawn C @ 2020-11-20 2:21 UTC (permalink / raw)
To: intel-gfx, Roper, Matthew D; +Cc: Chiou, Cooper
On Thu, Nov. 19, 2020 at 11:51 PM, Matt Roper wrote:
>On Tue, Nov 17, 2020 at 10:26:29PM +0800, Lee Shawn C wrote:
>> After boot into kernel. Driver configured ddc pin mapping based on
>> predefined table in parse_ddi_port(). Now driver configure rkl ddc pin
>> mapping depends on icp_ddc_pin_map[]. Then this table will give
>> incorrect gmbus port number to cause HDMI can't work.
>>
>> Refer to commit cd0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
>> Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can works
>> properly on rkl.
>>
>> v2: update patch based on latest dinq branch.
>> v3: update ddc table for RKL+TGP sku.
>> RKL+CNP sku will load cnp_ddc_pin_map[] setting.
>> v4: modify the if/else judgment to avoid nesting.
>> v5: fix typo in v4.
>>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Cc: Aditya Swarup <aditya.swarup@intel.com>
>> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>
>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
>Do you plan to follow up with a separate patch to fix the CMP handling in rkl_port_to_ddc_pin that I mentioned previously? I want to make sure that part doesn't fall through the cracks.
>
Do you mean the modification like this in rkl_port_to_ddc_pin()? If so, I will commit a separate patch to fix it later.
return GMBUS_PIN_1_BXT + phy - 1;
Best regards,
Shawn
>
>Matt
>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.c | 10 ++++++++++
>> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
>> 2 files changed, 12 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
>> b/drivers/gpu/drm/i915/display/intel_bios.c
>> index 4cc949b228f2..cf2fba490b7b 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -1623,6 +1623,13 @@ static const u8 icp_ddc_pin_map[] = {
>> [TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP, };
>>
>> +static const u8 rkl_pch_tgp_ddc_pin_map[] = {
>> + [ICL_DDC_BUS_DDI_A] = GMBUS_PIN_1_BXT,
>> + [ICL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
>> + [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
>> + [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP, };
>> +
>> static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
>> {
>> const u8 *ddc_pin_map;
>> @@ -1630,6 +1637,9 @@ static u8 map_ddc_pin(struct drm_i915_private
>> *dev_priv, u8 vbt_pin)
>>
>> if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
>> return vbt_pin;
>> + } else if (IS_ROCKETLAKE(dev_priv) && INTEL_PCH_TYPE(dev_priv) == PCH_TGP) {
>> + ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
>> + n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
>> } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
>> ddc_pin_map = icp_ddc_pin_map;
>> n_entries = ARRAY_SIZE(icp_ddc_pin_map); diff --git
>> a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> index 49b4b5fca941..187ec573de59 100644
>> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> @@ -319,6 +319,8 @@ enum vbt_gmbus_ddi {
>> ICL_DDC_BUS_DDI_A = 0x1,
>> ICL_DDC_BUS_DDI_B,
>> TGL_DDC_BUS_DDI_C,
>> + RKL_DDC_BUS_DDI_D = 0x3,
>> + RKL_DDC_BUS_DDI_E,
>> ICL_DDC_BUS_PORT_1 = 0x4,
>> ICL_DDC_BUS_PORT_2,
>> ICL_DDC_BUS_PORT_3,
>> --
>> 2.17.1
>>
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH v5] drm/i915/rkl: new rkl ddc map for different PCH
2020-11-20 2:21 ` Lee, Shawn C
@ 2020-12-17 7:48 ` Timo Aaltonen
0 siblings, 0 replies; 24+ messages in thread
From: Timo Aaltonen @ 2020-12-17 7:48 UTC (permalink / raw)
To: 20201117142629.28729-1-shawn.c.lee, intel-gfx, Roper, Matthew D
Cc: Chiou, Cooper
Hi,
Progress here seems to have stalled, or did I miss something?
On 20.11.2020 4.21, Lee, Shawn C wrote:
> On Thu, Nov. 19, 2020 at 11:51 PM, Matt Roper wrote:
>> On Tue, Nov 17, 2020 at 10:26:29PM +0800, Lee Shawn C wrote:
>>> After boot into kernel. Driver configured ddc pin mapping based on
>>> predefined table in parse_ddi_port(). Now driver configure rkl ddc pin
>>> mapping depends on icp_ddc_pin_map[]. Then this table will give
>>> incorrect gmbus port number to cause HDMI can't work.
>>>
>>> Refer to commit cd0a89527d06 ("drm/i915/rkl: Add DDC pin mapping").
>>> Create two ddc pin table for rkl TGP and CMP pch. Then HDMI can works
>>> properly on rkl.
>>>
>>> v2: update patch based on latest dinq branch.
>>> v3: update ddc table for RKL+TGP sku.
>>> RKL+CNP sku will load cnp_ddc_pin_map[] setting.
>>> v4: modify the if/else judgment to avoid nesting.
>>> v5: fix typo in v4.
>>>
>>> Cc: Matt Roper <matthew.d.roper@intel.com>
>>> Cc: Aditya Swarup <aditya.swarup@intel.com>
>>> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>>> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
>>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2577
>>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>>
>> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>>
>> Do you plan to follow up with a separate patch to fix the CMP handling in rkl_port_to_ddc_pin that I mentioned previously? I want to make sure that part doesn't fall through the cracks.
>>
>
> Do you mean the modification like this in rkl_port_to_ddc_pin()? If so, I will commit a separate patch to fix it later.
>
> return GMBUS_PIN_1_BXT + phy - 1;
>
> Best regards,
> Shawn
>
>>
>> Matt
>>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_bios.c | 10 ++++++++++
>>> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
>>> 2 files changed, 12 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
>>> b/drivers/gpu/drm/i915/display/intel_bios.c
>>> index 4cc949b228f2..cf2fba490b7b 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>>> @@ -1623,6 +1623,13 @@ static const u8 icp_ddc_pin_map[] = {
>>> [TGL_DDC_BUS_PORT_6] = GMBUS_PIN_14_TC6_TGP, };
>>>
>>> +static const u8 rkl_pch_tgp_ddc_pin_map[] = {
>>> + [ICL_DDC_BUS_DDI_A] = GMBUS_PIN_1_BXT,
>>> + [ICL_DDC_BUS_DDI_B] = GMBUS_PIN_2_BXT,
>>> + [RKL_DDC_BUS_DDI_D] = GMBUS_PIN_9_TC1_ICP,
>>> + [RKL_DDC_BUS_DDI_E] = GMBUS_PIN_10_TC2_ICP, };
>>> +
>>> static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin)
>>> {
>>> const u8 *ddc_pin_map;
>>> @@ -1630,6 +1637,9 @@ static u8 map_ddc_pin(struct drm_i915_private
>>> *dev_priv, u8 vbt_pin)
>>>
>>> if (INTEL_PCH_TYPE(dev_priv) >= PCH_DG1) {
>>> return vbt_pin;
>>> + } else if (IS_ROCKETLAKE(dev_priv) && INTEL_PCH_TYPE(dev_priv) == PCH_TGP) {
>>> + ddc_pin_map = rkl_pch_tgp_ddc_pin_map;
>>> + n_entries = ARRAY_SIZE(rkl_pch_tgp_ddc_pin_map);
>>> } else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP) {
>>> ddc_pin_map = icp_ddc_pin_map;
>>> n_entries = ARRAY_SIZE(icp_ddc_pin_map); diff --git
>>> a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>>> b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>>> index 49b4b5fca941..187ec573de59 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>>> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>>> @@ -319,6 +319,8 @@ enum vbt_gmbus_ddi {
>>> ICL_DDC_BUS_DDI_A = 0x1,
>>> ICL_DDC_BUS_DDI_B,
>>> TGL_DDC_BUS_DDI_C,
>>> + RKL_DDC_BUS_DDI_D = 0x3,
>>> + RKL_DDC_BUS_DDI_E,
>>> ICL_DDC_BUS_PORT_1 = 0x4,
>>> ICL_DDC_BUS_PORT_2,
>>> ICL_DDC_BUS_PORT_3,
>>> --
>>> 2.17.1
>>>
>>
>> --
>> Matt Roper
>> Graphics Software Engineer
>> VTT-OSGC Platform Enablement
>> Intel Corporation
>> (916) 356-2795
>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
--
t
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2020-12-17 7:49 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 14:43 [Intel-gfx] [PATCH] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
2020-10-28 15:09 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2020-10-29 8:10 ` [Intel-gfx] [PATCH] " Jani Nikula
2020-10-30 13:41 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
2020-10-30 17:35 ` Matt Roper
2020-10-31 2:55 ` Lee, Shawn C
2020-11-02 6:12 ` Matt Roper
2020-11-02 13:37 ` Lee, Shawn C
2020-10-30 16:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rkl: new rkl ddc map for different PCH (rev2) Patchwork
2020-10-30 16:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-10-30 19:34 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-11-02 13:56 ` [Intel-gfx] [PATCH v3] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
2020-11-10 15:17 ` Lee, Shawn C
2020-11-12 23:53 ` Matt Roper
2020-11-13 0:14 ` Lee, Shawn C
2020-11-02 14:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rkl: new rkl ddc map for different PCH (rev3) Patchwork
2020-11-02 14:31 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-11-17 14:19 ` [Intel-gfx] [PATCH v4] drm/i915/rkl: new rkl ddc map for different PCH Lee Shawn C
2020-11-17 14:26 ` [Intel-gfx] [PATCH v5] " Lee Shawn C
2020-11-19 23:51 ` Matt Roper
2020-11-20 2:21 ` Lee, Shawn C
2020-12-17 7:48 ` Timo Aaltonen
2020-11-17 23:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rkl: new rkl ddc map for different PCH (rev5) Patchwork
2020-11-18 4:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).