* Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression
[not found] ` <160527763346.5566.3471508802857132043@jlahtine-mobl.ger.corp.intel.com>
@ 2020-11-19 7:20 ` Oliver Sang
2020-11-24 20:47 ` Chris Wilson
[not found] ` <df7e1556-ee01-ad27-1abb-ffe5d74567b7@intel.com>
1 sibling, 1 reply; 7+ messages in thread
From: Oliver Sang @ 2020-11-19 7:20 UTC (permalink / raw)
To: Joonas Lahtinen
Cc: feng.tang, tiejun.li, Chris Wilson, frank.du, guobing.chen,
jiebin.sun, Shuhua.Fan, Matthew Auld, fan.zhao, ying.huang,
shan.kang, zhengjun.xing, zhengjun.xing, Wenhuan.Huang,
intel-gfx, guangli.li, gengxin.xie, ming.a.chen, yu.ma,
jessica.ji, lkp, wangyang.guo, dapeng1.mi, LKML
On Fri, Nov 13, 2020 at 04:27:13PM +0200, Joonas Lahtinen wrote:
> Hi,
>
> Could you add intel-gfx@lists.freedesktop.org into reports going
> forward.
>
> Quoting kernel test robot (2020-11-11 17:58:11)
> >
> > Greeting,
> >
> > FYI, we noticed a -54.0% regression of phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second due to commit:
>
> How many runs are there on the bad version to ensure the bisect is
> repeatable?
test 4 times.
zxing@inn:/result/phoronix-test-suite/performance-true-Radial_Gradient_Paint-1024x1024-jxrendermark-1.2.4-ucode=0xd6-monitor=da39a3ee/lkp-cfl-d1/debian-x86_64-phoronix/x86_64-rhel-8.3/gcc-9/59dd13ad310793757e34afa489dd6fc8544fc3da$ grep -r "operations_per_second" */stats.json
0/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4133.487932,
1/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4120.421503,
2/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4188.414835,
3/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4068.549514,
>
> According to Chris test has various factors affecting why the result
> could fluctuate and has been known. Reverting the patch did not have
> an effect on the benchmark and was not expected to do so, either.
>
> Is there some mechanism to queue a re-run?
>
> Would it make sense to do further runs before sending out the e-mail
> to avoid false positives.
>
> It could of course be also solved by sticking to tests that have less
> fluctuation in them.
>
> Regards, Joonas
>
> >
> >
> > commit: 59dd13ad310793757e34afa489dd6fc8544fc3da ("drm/i915/gem: Flush coherency domains on first set-domain-ioctl")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> >
> >
> > in testcase: phoronix-test-suite
> > on test machine: 12 threads Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz with 8G memory
> > with following parameters:
> >
> > need_x: true
> > test: jxrendermark-1.2.4
> > option_a: Radial Gradient Paint
> > option_b: 1024x1024
> > cpufreq_governor: performance
> > ucode: 0xd6
> >
> > test-description: The Phoronix Test Suite is the most comprehensive testing and benchmarking platform available that provides an extensible framework for which new tests can be easily added.
> > test-url: http://www.phoronix-test-suite.com/
> >
> >
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kernel test robot <oliver.sang@intel.com>
> >
> >
> > Details are as below:
> > -------------------------------------------------------------------------------------------------->
> >
> >
> > To reproduce:
> >
> > git clone https://github.com/intel/lkp-tests.git
> > cd lkp-tests
> > bin/lkp install job.yaml # job file is attached in this email
> > bin/lkp run job.yaml
> >
> > =========================================================================================
> > compiler/cpufreq_governor/kconfig/need_x/option_a/option_b/rootfs/tbox_group/test/testcase/ucode:
> > gcc-9/performance/x86_64-rhel-8.3/true/Radial Gradient Paint/1024x1024/debian-x86_64-phoronix/lkp-cfl-d1/jxrendermark-1.2.4/phoronix-test-suite/0xd6
> >
> > commit:
> > 0dccdba51e ("Merge tag 'gvt-fixes-2020-10-30' of https://github.com/intel/gvt-linux into drm-intel-fixes")
> > 59dd13ad31 ("drm/i915/gem: Flush coherency domains on first set-domain-ioctl")
> >
> > 0dccdba51e852271 59dd13ad310793757e34afa489d
> > ---------------- ---------------------------
> > %stddev %change %stddev
> > \ | \
> > 8980 ± 2% -54.0% 4127 phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second
> > 9.00 +13.9% 10.25 ± 4% phoronix-test-suite.time.percent_of_cpu_this_job_got
> >
> >
> >
> >
> >
> > 10000 +-------------------------------------------------------------------+
> > | |
> > 9000 |-+.+. .+.+.+.+.+. .+. .+. .+. .+.+. .+. .+. .+. .+.+. .|
> > |.+ + +.+ + +.+ + +.+.+ + +.+ + +.+ |
> > | |
> > 8000 |-+ |
> > | |
> > 7000 |-+ |
> > | |
> > 6000 |-+ |
> > | |
> > | |
> > 5000 |-+ |
> > | O |
> > 4000 +-------------------------------------------------------------------+
> >
> >
> > [*] bisect-good sample
> > [O] bisect-bad sample
> >
> >
> >
> > Disclaimer:
> > Results have been estimated based on internal Intel analysis and are provided
> > for informational purposes only. Any difference in system hardware or software
> > design or configuration may affect actual performance.
> >
> >
> > Thanks,
> > Oliver Sang
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression
2020-11-19 7:20 ` [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression Oliver Sang
@ 2020-11-24 20:47 ` Chris Wilson
2020-11-26 1:44 ` Xing Zhengjun
0 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2020-11-24 20:47 UTC (permalink / raw)
To: Joonas Lahtinen, Oliver Sang
Cc: feng.tang, tiejun.li, guangli.li, frank.du, guobing.chen,
jiebin.sun, Shuhua.Fan, Matthew Auld, fan.zhao, ying.huang,
shan.kang, zhengjun.xing, zhengjun.xing, Wenhuan.Huang,
intel-gfx, lkp, ming.a.chen, yu.ma, jessica.ji, dapeng1.mi,
wangyang.guo, LKML, gengxin.xie
Quoting Oliver Sang (2020-11-19 07:20:18)
> On Fri, Nov 13, 2020 at 04:27:13PM +0200, Joonas Lahtinen wrote:
> > Hi,
> >
> > Could you add intel-gfx@lists.freedesktop.org into reports going
> > forward.
> >
> > Quoting kernel test robot (2020-11-11 17:58:11)
> > >
> > > Greeting,
> > >
> > > FYI, we noticed a -54.0% regression of phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second due to commit:
> >
> > How many runs are there on the bad version to ensure the bisect is
> > repeatable?
>
> test 4 times.
> zxing@inn:/result/phoronix-test-suite/performance-true-Radial_Gradient_Paint-1024x1024-jxrendermark-1.2.4-ucode=0xd6-monitor=da39a3ee/lkp-cfl-d1/debian-x86_64-phoronix/x86_64-rhel-8.3/gcc-9/59dd13ad310793757e34afa489dd6fc8544fc3da$ grep -r "operations_per_second" */stats.json
> 0/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4133.487932,
> 1/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4120.421503,
> 2/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4188.414835,
> 3/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4068.549514,
a w/o revert (drm-tip)
b w/ revert
+mB----------------------------------------------------------------------------+
| ..b |
| ..b.aa |
| ....a.a |
| ....a.a |
| b b ........a |
| b b b b......... a |
| b bb bbb........... |
|b ab bbab.bb.b............ba b a a ab a|
| |__A__| |
| |MA_| |
+------------------------------------------------------------------------------+
N Min Max Median Avg Stddev
a 120 3621.8761 7356.4442 4606.7895 4607.9132 156.17693
b 120 2664.0563 6359.9686 4519.5036 4534.4463 95.471121
The patch is not expected to have any impact on the machine you are testing on.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression
2020-11-24 20:47 ` Chris Wilson
@ 2020-11-26 1:44 ` Xing Zhengjun
2020-11-26 21:34 ` Chris Wilson
0 siblings, 1 reply; 7+ messages in thread
From: Xing Zhengjun @ 2020-11-26 1:44 UTC (permalink / raw)
To: Chris Wilson, Joonas Lahtinen, Oliver Sang
Cc: feng.tang, tiejun.li, guangli.li, frank.du, guobing.chen,
jiebin.sun, Shuhua.Fan, Matthew Auld, fan.zhao, ying.huang,
shan.kang, zhengjun.xing, Wenhuan.Huang, intel-gfx, lkp,
ming.a.chen, yu.ma, jessica.ji, dapeng1.mi, wangyang.guo, LKML,
gengxin.xie
On 11/25/2020 4:47 AM, Chris Wilson wrote:
> Quoting Oliver Sang (2020-11-19 07:20:18)
>> On Fri, Nov 13, 2020 at 04:27:13PM +0200, Joonas Lahtinen wrote:
>>> Hi,
>>>
>>> Could you add intel-gfx@lists.freedesktop.org into reports going
>>> forward.
>>>
>>> Quoting kernel test robot (2020-11-11 17:58:11)
>>>>
>>>> Greeting,
>>>>
>>>> FYI, we noticed a -54.0% regression of phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second due to commit:
>>>
>>> How many runs are there on the bad version to ensure the bisect is
>>> repeatable?
>>
>> test 4 times.
>> zxing@inn:/result/phoronix-test-suite/performance-true-Radial_Gradient_Paint-1024x1024-jxrendermark-1.2.4-ucode=0xd6-monitor=da39a3ee/lkp-cfl-d1/debian-x86_64-phoronix/x86_64-rhel-8.3/gcc-9/59dd13ad310793757e34afa489dd6fc8544fc3da$ grep -r "operations_per_second" */stats.json
>> 0/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4133.487932,
>> 1/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4120.421503,
>> 2/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4188.414835,
>> 3/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4068.549514,
>
> a w/o revert (drm-tip)
> b w/ revert
> +mB----------------------------------------------------------------------------+
> | ..b |
> | ..b.aa |
> | ....a.a |
> | ....a.a |
> | b b ........a |
> | b b b b......... a |
> | b bb bbb........... |
> |b ab bbab.bb.b............ba b a a ab a|
> | |__A__| |
> | |MA_| |
> +------------------------------------------------------------------------------+
> N Min Max Median Avg Stddev
> a 120 3621.8761 7356.4442 4606.7895 4607.9132 156.17693
> b 120 2664.0563 6359.9686 4519.5036 4534.4463 95.471121
>
> The patch is not expected to have any impact on the machine you are testing on.
> -Chris
>
What's your code base?
For my side:
1) sync the code to the head of Linux mainline
2) git reset --hard 59dd13ad31
3) git revert 59dd13ad3107
We compare the test result of commit 59dd13ad3107 (step 2) and
2052847b06f8 (step 3, revert 59dd13ad3107), the regression should
related with 59dd13ad3107. Each test case we run 5 times.
=========================================================================================
tbox_group/testcase/rootfs/kconfig/compiler/need_x/test/option_a/option_b/cpufreq_governor/ucode/debug-setup:
lkp-cfl-d1/phoronix-test-suite/debian-x86_64-phoronix/x86_64-rhel-8.3/gcc-9/true/jxrendermark-1.2.4/Radial
Gradient Paint/1024x1024/performance/0xde/regression_test
commit:
0dccdba51e852271a3dbc9358375f4c882b863f2
59dd13ad310793757e34afa489dd6fc8544fc3da
2052847b06f863a028f7f3bbc62401e043b34301 (revert 59dd13ad3107)
0dccdba51e852271 59dd13ad310793757e34afa489d 2052847b06f863a028f7f3bbc62
---------------- --------------------------- ---------------------------
%stddev %change %stddev %change %stddev
\ | \ | \
8145 ± 2% -53.1% 3817 ± 3% -1.8% 7995
phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second
--
Zhengjun Xing
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression
2020-11-26 1:44 ` Xing Zhengjun
@ 2020-11-26 21:34 ` Chris Wilson
2020-11-27 1:51 ` Xing Zhengjun
0 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2020-11-26 21:34 UTC (permalink / raw)
To: Joonas Lahtinen, Oliver Sang, Xing Zhengjun
Cc: feng.tang, tiejun.li, guangli.li, frank.du, guobing.chen,
jiebin.sun, Shuhua.Fan, Matthew Auld, fan.zhao, ying.huang,
shan.kang, zhengjun.xing, Wenhuan.Huang, intel-gfx, lkp,
ming.a.chen, yu.ma, jessica.ji, dapeng1.mi, wangyang.guo, LKML,
gengxin.xie
Quoting Xing Zhengjun (2020-11-26 01:44:55)
>
>
> On 11/25/2020 4:47 AM, Chris Wilson wrote:
> > Quoting Oliver Sang (2020-11-19 07:20:18)
> >> On Fri, Nov 13, 2020 at 04:27:13PM +0200, Joonas Lahtinen wrote:
> >>> Hi,
> >>>
> >>> Could you add intel-gfx@lists.freedesktop.org into reports going
> >>> forward.
> >>>
> >>> Quoting kernel test robot (2020-11-11 17:58:11)
> >>>>
> >>>> Greeting,
> >>>>
> >>>> FYI, we noticed a -54.0% regression of phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second due to commit:
> >>>
> >>> How many runs are there on the bad version to ensure the bisect is
> >>> repeatable?
> >>
> >> test 4 times.
> >> zxing@inn:/result/phoronix-test-suite/performance-true-Radial_Gradient_Paint-1024x1024-jxrendermark-1.2.4-ucode=0xd6-monitor=da39a3ee/lkp-cfl-d1/debian-x86_64-phoronix/x86_64-rhel-8.3/gcc-9/59dd13ad310793757e34afa489dd6fc8544fc3da$ grep -r "operations_per_second" */stats.json
> >> 0/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4133.487932,
> >> 1/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4120.421503,
> >> 2/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4188.414835,
> >> 3/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4068.549514,
> >
> > a w/o revert (drm-tip)
> > b w/ revert
> > +mB----------------------------------------------------------------------------+
> > | ..b |
> > | ..b.aa |
> > | ....a.a |
> > | ....a.a |
> > | b b ........a |
> > | b b b b......... a |
> > | b bb bbb........... |
> > |b ab bbab.bb.b............ba b a a ab a|
> > | |__A__| |
> > | |MA_| |
> > +------------------------------------------------------------------------------+
> > N Min Max Median Avg Stddev
> > a 120 3621.8761 7356.4442 4606.7895 4607.9132 156.17693
> > b 120 2664.0563 6359.9686 4519.5036 4534.4463 95.471121
> >
> > The patch is not expected to have any impact on the machine you are testing on.
> > -Chris
> >
>
> What's your code base?
> For my side:
> 1) sync the code to the head of Linux mainline
> 2) git reset --hard 59dd13ad31
> 3) git revert 59dd13ad3107
> We compare the test result of commit 59dd13ad3107 (step 2) and
> 2052847b06f8 (step 3, revert 59dd13ad3107), the regression should
> related with 59dd13ad3107. Each test case we run 5 times.
a 59dd13ad31
b revert
+mB----------------------------------------------------------------------------+
| a |
| aa |
| .b....ba |
| .b....baa b |
| .........b . b b |
| a b.......... ..bb b b |
| b a b.............b.a b b |
|a a b. .aaa..b.............b..b....ab b a .|
| |__A__| |
| |___A_____| |
+------------------------------------------------------------------------------+
N Min Max Median Avg Stddev
a 120 3658.3435 6363.7812 4527.4406 4536.612 86.095459
b 120 3928.9643 6375.829 4576.0482 4585.4224 157.284
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression
2020-11-26 21:34 ` Chris Wilson
@ 2020-11-27 1:51 ` Xing Zhengjun
2020-11-27 13:07 ` Chris Wilson
0 siblings, 1 reply; 7+ messages in thread
From: Xing Zhengjun @ 2020-11-27 1:51 UTC (permalink / raw)
To: Chris Wilson, Joonas Lahtinen, Oliver Sang
Cc: feng.tang, tiejun.li, guangli.li, frank.du, guobing.chen,
jiebin.sun, Shuhua.Fan, Matthew Auld, fan.zhao, ying.huang,
shan.kang, zhengjun.xing, Wenhuan.Huang, intel-gfx, lkp,
ming.a.chen, yu.ma, jessica.ji, dapeng1.mi, wangyang.guo, LKML,
gengxin.xie
On 11/27/2020 5:34 AM, Chris Wilson wrote:
> Quoting Xing Zhengjun (2020-11-26 01:44:55)
>>
>>
>> On 11/25/2020 4:47 AM, Chris Wilson wrote:
>>> Quoting Oliver Sang (2020-11-19 07:20:18)
>>>> On Fri, Nov 13, 2020 at 04:27:13PM +0200, Joonas Lahtinen wrote:
>>>>> Hi,
>>>>>
>>>>> Could you add intel-gfx@lists.freedesktop.org into reports going
>>>>> forward.
>>>>>
>>>>> Quoting kernel test robot (2020-11-11 17:58:11)
>>>>>>
>>>>>> Greeting,
>>>>>>
>>>>>> FYI, we noticed a -54.0% regression of phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second due to commit:
>>>>>
>>>>> How many runs are there on the bad version to ensure the bisect is
>>>>> repeatable?
>>>>
>>>> test 4 times.
>>>> zxing@inn:/result/phoronix-test-suite/performance-true-Radial_Gradient_Paint-1024x1024-jxrendermark-1.2.4-ucode=0xd6-monitor=da39a3ee/lkp-cfl-d1/debian-x86_64-phoronix/x86_64-rhel-8.3/gcc-9/59dd13ad310793757e34afa489dd6fc8544fc3da$ grep -r "operations_per_second" */stats.json
>>>> 0/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4133.487932,
>>>> 1/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4120.421503,
>>>> 2/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4188.414835,
>>>> 3/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4068.549514,
>>>
>>> a w/o revert (drm-tip)
>>> b w/ revert
>>> +mB----------------------------------------------------------------------------+
>>> | ..b |
>>> | ..b.aa |
>>> | ....a.a |
>>> | ....a.a |
>>> | b b ........a |
>>> | b b b b......... a |
>>> | b bb bbb........... |
>>> |b ab bbab.bb.b............ba b a a ab a|
>>> | |__A__| |
>>> | |MA_| |
>>> +------------------------------------------------------------------------------+
>>> N Min Max Median Avg Stddev
>>> a 120 3621.8761 7356.4442 4606.7895 4607.9132 156.17693
>>> b 120 2664.0563 6359.9686 4519.5036 4534.4463 95.471121
>>>
>>> The patch is not expected to have any impact on the machine you are testing on.
>>> -Chris
>>>
>>
>> What's your code base?
>> For my side:
>> 1) sync the code to the head of Linux mainline
>> 2) git reset --hard 59dd13ad31
>> 3) git revert 59dd13ad3107
>> We compare the test result of commit 59dd13ad3107 (step 2) and
>> 2052847b06f8 (step 3, revert 59dd13ad3107), the regression should
>> related with 59dd13ad3107. Each test case we run 5 times.
>
> a 59dd13ad31
> b revert
> +mB----------------------------------------------------------------------------+
> | a |
> | aa |
> | .b....ba |
> | .b....baa b |
> | .........b . b b |
> | a b.......... ..bb b b |
> | b a b.............b.a b b |
> |a a b. .aaa..b.............b..b....ab b a .|
> | |__A__| |
> | |___A_____| |
> +------------------------------------------------------------------------------+
> N Min Max Median Avg Stddev
> a 120 3658.3435 6363.7812 4527.4406 4536.612 86.095459
> b 120 3928.9643 6375.829 4576.0482 4585.4224 157.284
>
Could you share with me your test commands and the hardware info, then I
can reproduce it on my side? Thanks.
--
Zhengjun Xing
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression
2020-11-27 1:51 ` Xing Zhengjun
@ 2020-11-27 13:07 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2020-11-27 13:07 UTC (permalink / raw)
To: Joonas Lahtinen, Oliver Sang, Xing Zhengjun
Cc: feng.tang, tiejun.li, guangli.li, frank.du, guobing.chen,
jiebin.sun, Shuhua.Fan, Matthew Auld, fan.zhao, ying.huang,
shan.kang, zhengjun.xing, Wenhuan.Huang, intel-gfx, lkp,
ming.a.chen, yu.ma, jessica.ji, dapeng1.mi, wangyang.guo, LKML,
gengxin.xie
Quoting Xing Zhengjun (2020-11-27 01:51:41)
>
>
> On 11/27/2020 5:34 AM, Chris Wilson wrote:
> > Quoting Xing Zhengjun (2020-11-26 01:44:55)
> >>
> >>
> >> On 11/25/2020 4:47 AM, Chris Wilson wrote:
> >>> Quoting Oliver Sang (2020-11-19 07:20:18)
> >>>> On Fri, Nov 13, 2020 at 04:27:13PM +0200, Joonas Lahtinen wrote:
> >>>>> Hi,
> >>>>>
> >>>>> Could you add intel-gfx@lists.freedesktop.org into reports going
> >>>>> forward.
> >>>>>
> >>>>> Quoting kernel test robot (2020-11-11 17:58:11)
> >>>>>>
> >>>>>> Greeting,
> >>>>>>
> >>>>>> FYI, we noticed a -54.0% regression of phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second due to commit:
> >>>>>
> >>>>> How many runs are there on the bad version to ensure the bisect is
> >>>>> repeatable?
> >>>>
> >>>> test 4 times.
> >>>> zxing@inn:/result/phoronix-test-suite/performance-true-Radial_Gradient_Paint-1024x1024-jxrendermark-1.2.4-ucode=0xd6-monitor=da39a3ee/lkp-cfl-d1/debian-x86_64-phoronix/x86_64-rhel-8.3/gcc-9/59dd13ad310793757e34afa489dd6fc8544fc3da$ grep -r "operations_per_second" */stats.json
> >>>> 0/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4133.487932,
> >>>> 1/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4120.421503,
> >>>> 2/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4188.414835,
> >>>> 3/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4068.549514,
> >>>
> >>> a w/o revert (drm-tip)
> >>> b w/ revert
> >>> +mB----------------------------------------------------------------------------+
> >>> | ..b |
> >>> | ..b.aa |
> >>> | ....a.a |
> >>> | ....a.a |
> >>> | b b ........a |
> >>> | b b b b......... a |
> >>> | b bb bbb........... |
> >>> |b ab bbab.bb.b............ba b a a ab a|
> >>> | |__A__| |
> >>> | |MA_| |
> >>> +------------------------------------------------------------------------------+
> >>> N Min Max Median Avg Stddev
> >>> a 120 3621.8761 7356.4442 4606.7895 4607.9132 156.17693
> >>> b 120 2664.0563 6359.9686 4519.5036 4534.4463 95.471121
> >>>
> >>> The patch is not expected to have any impact on the machine you are testing on.
> >>> -Chris
> >>>
> >>
> >> What's your code base?
> >> For my side:
> >> 1) sync the code to the head of Linux mainline
> >> 2) git reset --hard 59dd13ad31
> >> 3) git revert 59dd13ad3107
> >> We compare the test result of commit 59dd13ad3107 (step 2) and
> >> 2052847b06f8 (step 3, revert 59dd13ad3107), the regression should
> >> related with 59dd13ad3107. Each test case we run 5 times.
> >
> > a 59dd13ad31
> > b revert
> > +mB----------------------------------------------------------------------------+
> > | a |
> > | aa |
> > | .b....ba |
> > | .b....baa b |
> > | .........b . b b |
> > | a b.......... ..bb b b |
> > | b a b.............b.a b b |
> > |a a b. .aaa..b.............b..b....ab b a .|
> > | |__A__| |
> > | |___A_____| |
> > +------------------------------------------------------------------------------+
> > N Min Max Median Avg Stddev
> > a 120 3658.3435 6363.7812 4527.4406 4536.612 86.095459
> > b 120 3928.9643 6375.829 4576.0482 4585.4224 157.284
> >
>
> Could you share with me your test commands and the hardware info, then I
> can reproduce it on my side? Thanks.
It was a i7-8809G, identical i915 behaviour as the i7-8700 the report was
generated on.
sudo Xorg & for i in $(seq 1 120); do ./jx 13 1024 | awk '{print $1}' ; done
using -modesetting + iris (i965 makes no difference, just slightly
slower)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression
[not found] ` <df7e1556-ee01-ad27-1abb-ffe5d74567b7@intel.com>
@ 2020-12-10 13:07 ` Joonas Lahtinen
0 siblings, 0 replies; 7+ messages in thread
From: Joonas Lahtinen @ 2020-12-10 13:07 UTC (permalink / raw)
To: Rong Chen; +Cc: intel-gfx
+ intel-gfx
Quoting Rong Chen (2020-12-10 08:54:59)
>
>
> On 11/13/20 10:27 PM, Joonas Lahtinen wrote:
> > Hi,
> >
> > Could you add intel-gfx@lists.freedesktop.org into reports going
> > forward.
>
> Hi Joonas,
>
> Sorry for the late, which kind of issue that needs to be forwarded?
When sending the regression notifications, it would be useful to include
the mailing lists from MAINTAINERS file based on the files being touched
by the bisected commit.
That would help bringing the right attention and be especially important
for the cases where the patch author has become inactive (changed jobs
or e-mail, etc.)
Regards, Joonas
> Best Regards,
> Rong Chen
>
> >
> > Quoting kernel test robot (2020-11-11 17:58:11)
> >> Greeting,
> >>
> >> FYI, we noticed a -54.0% regression of phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second due to commit:
> > How many runs are there on the bad version to ensure the bisect is
> > repeatable?
> >
> > According to Chris test has various factors affecting why the result
> > could fluctuate and has been known. Reverting the patch did not have
> > an effect on the benchmark and was not expected to do so, either.
> >
> > Is there some mechanism to queue a re-run?
> >
> > Would it make sense to do further runs before sending out the e-mail
> > to avoid false positives.
> >
> > It could of course be also solved by sticking to tests that have less
> > fluctuation in them.
> >
> > Regards, Joonas
> >
> >>
> >> commit: 59dd13ad310793757e34afa489dd6fc8544fc3da ("drm/i915/gem: Flush coherency domains on first set-domain-ioctl")
> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> >>
> >>
> >> in testcase: phoronix-test-suite
> >> on test machine: 12 threads Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz with 8G memory
> >> with following parameters:
> >>
> >> need_x: true
> >> test: jxrendermark-1.2.4
> >> option_a: Radial Gradient Paint
> >> option_b: 1024x1024
> >> cpufreq_governor: performance
> >> ucode: 0xd6
> >>
> >> test-description: The Phoronix Test Suite is the most comprehensive testing and benchmarking platform available that provides an extensible framework for which new tests can be easily added.
> >> test-url: http://www.phoronix-test-suite.com/
> >>
> >>
> >>
> >> If you fix the issue, kindly add following tag
> >> Reported-by: kernel test robot <oliver.sang@intel.com>
> >>
> >>
> >> Details are as below:
> >> -------------------------------------------------------------------------------------------------->
> >>
> >>
> >> To reproduce:
> >>
> >> git clone https://github.com/intel/lkp-tests.git
> >> cd lkp-tests
> >> bin/lkp install job.yaml # job file is attached in this email
> >> bin/lkp run job.yaml
> >>
> >> =========================================================================================
> >> compiler/cpufreq_governor/kconfig/need_x/option_a/option_b/rootfs/tbox_group/test/testcase/ucode:
> >> gcc-9/performance/x86_64-rhel-8.3/true/Radial Gradient Paint/1024x1024/debian-x86_64-phoronix/lkp-cfl-d1/jxrendermark-1.2.4/phoronix-test-suite/0xd6
> >>
> >> commit:
> >> 0dccdba51e ("Merge tag 'gvt-fixes-2020-10-30' of https://github.com/intel/gvt-linux into drm-intel-fixes")
> >> 59dd13ad31 ("drm/i915/gem: Flush coherency domains on first set-domain-ioctl")
> >>
> >> 0dccdba51e852271 59dd13ad310793757e34afa489d
> >> ---------------- ---------------------------
> >> %stddev %change %stddev
> >> \ | \
> >> 8980 ± 2% -54.0% 4127 phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second
> >> 9.00 +13.9% 10.25 ± 4% phoronix-test-suite.time.percent_of_cpu_this_job_got
> >>
> >>
> >>
> >>
> >>
> >> 10000 +-------------------------------------------------------------------+
> >> | |
> >> 9000 |-+.+. .+.+.+.+.+. .+. .+. .+. .+.+. .+. .+. .+. .+.+. .|
> >> |.+ + +.+ + +.+ + +.+.+ + +.+ + +.+ |
> >> | |
> >> 8000 |-+ |
> >> | |
> >> 7000 |-+ |
> >> | |
> >> 6000 |-+ |
> >> | |
> >> | |
> >> 5000 |-+ |
> >> | O |
> >> 4000 +-------------------------------------------------------------------+
> >>
> >>
> >> [*] bisect-good sample
> >> [O] bisect-bad sample
> >>
> >>
> >>
> >> Disclaimer:
> >> Results have been estimated based on internal Intel analysis and are provided
> >> for informational purposes only. Any difference in system hardware or software
> >> design or configuration may affect actual performance.
> >>
> >>
> >> Thanks,
> >> Oliver Sang
> >>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-12-10 13:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201111155811.GB24657@xsang-OptiPlex-9020>
[not found] ` <160527763346.5566.3471508802857132043@jlahtine-mobl.ger.corp.intel.com>
2020-11-19 7:20 ` [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression Oliver Sang
2020-11-24 20:47 ` Chris Wilson
2020-11-26 1:44 ` Xing Zhengjun
2020-11-26 21:34 ` Chris Wilson
2020-11-27 1:51 ` Xing Zhengjun
2020-11-27 13:07 ` Chris Wilson
[not found] ` <df7e1556-ee01-ad27-1abb-ffe5d74567b7@intel.com>
2020-12-10 13:07 ` Joonas Lahtinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).