Intel-GFX Archive on lore.kernel.org
 help / color / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: [Intel-gfx] [PATCH 08/10] drm/i915/gt: Replace unnecessary ',' with '; '
Date: Fri, 22 Jan 2021 15:06:20 +0000
Message-ID: <20210122150622.21088-8-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20210122150622.21088-1-chris@chris-wilson.co.uk>

Checkpatch spotted a couple of commas where we can use the more common
';', and so not worry about the subtle implications of sequence points.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/gen6_ppgtt.h        | 4 ++--
 drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/gen6_ppgtt.h b/drivers/gpu/drm/i915/gt/gen6_ppgtt.h
index 3357228f3304..6a61a5c3a85a 100644
--- a/drivers/gpu/drm/i915/gt/gen6_ppgtt.h
+++ b/drivers/gpu/drm/i915/gt/gen6_ppgtt.h
@@ -59,9 +59,9 @@ static inline struct gen6_ppgtt *to_gen6_ppgtt(struct i915_ppgtt *base)
 	for (iter = gen6_pde_index(start);				\
 	     length > 0 && iter < I915_PDES &&				\
 		     (pt = i915_pt_entry(pd, iter), true);		\
-	     ({ u32 temp = ALIGN(start+1, 1 << GEN6_PDE_SHIFT);		\
+	     ({ u32 temp = ALIGN(start + 1, 1 << GEN6_PDE_SHIFT);	\
 		    temp = min(temp - start, length);			\
-		    start += temp, length -= temp; }), ++iter)
+		    start += temp; length -= temp; }), ++iter)
 
 #define gen6_for_all_pdes(pt, pd, iter)					\
 	for (iter = 0;							\
diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
index 60393ce5614d..28a1d5e1fb92 100644
--- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
+++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
@@ -115,7 +115,7 @@ intel_setup_fake_lmem(struct drm_i915_private *i915)
 
 	/* Your mappable aperture belongs to me now! */
 	mappable_end = pci_resource_len(pdev, 2);
-	io_start = pci_resource_start(pdev, 2),
+	io_start = pci_resource_start(pdev, 2);
 	start = i915->params.fake_lmem_start;
 
 	mem = intel_memory_region_create(i915,
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 15:06 [Intel-gfx] [PATCH 01/10] drm/i915/gt: SPDX cleanup Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 02/10] drm/i915/gt: Add some missing blank lines after declaration Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 03/10] drm/i915/gt: Remove repeated words from comments Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 04/10] drm/i915/gt: Fixup misaligned function parameters Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 05/10] drm/i915/gt: Remove a bonus newline Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 06/10] drm/i915/gt: Wrap macro arg in () Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 07/10] drm/i915/gt: Insert spaces into GEN3_L3LOG_SIZE/4 Chris Wilson
2021-01-22 15:06 ` Chris Wilson [this message]
2021-01-22 15:06 ` [Intel-gfx] [PATCH 09/10] drm/i915/gt: Add a space before '(' Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 10/10] drm/i915/gt: Replace 'return' with a fall-through Chris Wilson
2021-01-22 15:43 ` [Intel-gfx] [PATCH 01/10] drm/i915/gt: SPDX cleanup Michal Wajdeczko
2021-01-22 15:49   ` Chris Wilson
2021-01-22 16:03     ` Michal Wajdeczko
2021-01-22 16:16       ` Chris Wilson
2021-01-22 18:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] " Patchwork
2021-01-22 18:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-22 19:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-23  3:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210122150622.21088-8-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Intel-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/intel-gfx/0 intel-gfx/git/0.git
	git clone --mirror https://lore.kernel.org/intel-gfx/1 intel-gfx/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 intel-gfx intel-gfx/ https://lore.kernel.org/intel-gfx \
		intel-gfx@lists.freedesktop.org
	public-inbox-index intel-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.intel-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git