* [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel
@ 2021-06-29 6:51 venkata.sai.patnana
2021-06-29 6:51 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
` (10 more replies)
0 siblings, 11 replies; 19+ messages in thread
From: venkata.sai.patnana @ 2021-06-29 6:51 UTC (permalink / raw)
To: intel-gfx
From: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
DSC can be supported per DP connector. This patch creates
a per connector debugfs node to expose the Input and
Compressed BPP.
The same node can be used from userspace to force
DSC to a certain BPP.
force_dsc_bpp is written through this debugfs
node to force DSC BPP to all accepted values
Test-with: <20210622102454.8922-1-venkata.sai.patnana@intel.com>
Anusha Srivatsa (2):
drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP
enable
drm/i915/display/dsc: Set BPP in the kernel
.../drm/i915/display/intel_display_debugfs.c | 103 +++++++++++++++++-
.../drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 23 +++-
3 files changed, 121 insertions(+), 6 deletions(-)
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
@ 2021-06-29 6:51 ` venkata.sai.patnana
2021-06-29 14:35 ` Jani Nikula
2021-07-01 9:16 ` [Intel-gfx] [v3 " venkata.sai.patnana
2021-06-29 6:51 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
` (9 subsequent siblings)
10 siblings, 2 replies; 19+ messages in thread
From: venkata.sai.patnana @ 2021-06-29 6:51 UTC (permalink / raw)
To: intel-gfx
From: Anusha Srivatsa <anusha.srivatsa@intel.com>
DSC can be supported per DP connector. This patch creates
a per connector debugfs node to expose the Input and
Compressed BPP.
The same node can be used from userspace to force
DSC to a certain BPP.
force_dsc_bpp is written through this debugfs
node to force DSC BPP to all accepted values
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Navare Manasi D <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
---
.../drm/i915/display/intel_display_debugfs.c | 103 +++++++++++++++++-
.../drm/i915/display/intel_display_types.h | 1 +
2 files changed, 103 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index af9e58619667d..6dc223227eeaa 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -2389,6 +2389,100 @@ static const struct file_operations i915_dsc_fec_support_fops = {
.write = i915_dsc_fec_support_write
};
+static int i915_dsc_bpp_support_show(struct seq_file *m, void *data)
+{
+ struct drm_connector *connector = m->private;
+ struct drm_device *dev = connector->dev;
+ struct drm_crtc *crtc;
+ struct intel_dp *intel_dp;
+ struct drm_modeset_acquire_ctx ctx;
+ struct intel_crtc_state *crtc_state = NULL;
+ int ret = 0;
+ bool try_again = false;
+
+ drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
+
+ do {
+ try_again = false;
+ ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
+ &ctx);
+ if (ret) {
+ ret = -EINTR;
+ break;
+ }
+ crtc = connector->state->crtc;
+ if (connector->status != connector_status_connected || !crtc) {
+ ret = -ENODEV;
+ break;
+ }
+ ret = drm_modeset_lock(&crtc->mutex, &ctx);
+ if (ret == -EDEADLK) {
+ ret = drm_modeset_backoff(&ctx);
+ if (!ret) {
+ try_again = true;
+ continue;
+ }
+ break;
+ } else if (ret) {
+ break;
+ }
+ intel_dp = intel_attached_dp(to_intel_connector(connector));
+ crtc_state = to_intel_crtc_state(crtc->state);
+ seq_printf(m, "Input_BPP: %d\n", crtc_state->pipe_bpp);
+ seq_printf(m, "Compressed_BPP: %d\n",
+ crtc_state->dsc.compressed_bpp);
+ } while (try_again);
+
+ drm_modeset_drop_locks(&ctx);
+ drm_modeset_acquire_fini(&ctx);
+
+ return ret;
+}
+
+static ssize_t i915_dsc_bpp_support_write(struct file *file,
+ const char __user *ubuf,
+ size_t len, loff_t *offp)
+{
+ int dsc_bpp = 0;
+ int ret;
+ struct drm_connector *connector =
+ ((struct seq_file *)file->private_data)->private;
+ struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
+ struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+
+ if (len == 0)
+ return 0;
+
+ drm_dbg(&i915->drm,
+ "Copied %zu bytes from user to force BPP\n", len);
+
+ ret = kstrtoint_from_user(ubuf, len, 0, &dsc_bpp);
+
+ intel_dp->force_dsc_bpp = dsc_bpp;
+ if (ret < 0)
+ return ret;
+
+ *offp += len;
+ return len;
+}
+
+static int i915_dsc_bpp_support_open(struct inode *inode,
+ struct file *file)
+{
+ return single_open(file, i915_dsc_bpp_support_show,
+ inode->i_private);
+}
+
+static const struct file_operations i915_dsc_bpp_support_fops = {
+ .owner = THIS_MODULE,
+ .open = i915_dsc_bpp_support_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
+ .write = i915_dsc_bpp_support_write
+};
+
/**
* intel_connector_debugfs_add - add i915 specific connector debugfs files
* @connector: pointer to a registered drm_connector
@@ -2427,9 +2521,16 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
connector, &i915_hdcp_sink_capability_fops);
}
- if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) && ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort && !to_intel_connector(connector)->mst_port) || connector->connector_type == DRM_MODE_CONNECTOR_eDP))
+ if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) &&
+ ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
+ !to_intel_connector(connector)->mst_port) ||
+ connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
connector, &i915_dsc_fec_support_fops);
+ debugfs_create_file("i915_dsc_bpp_support", S_IRUGO,
+ root, connector,
+ &i915_dsc_bpp_support_fops);
+ }
/* Legacy panels doesn't lpsp on any platform */
if ((DISPLAY_VER(dev_priv) >= 9 || IS_HASWELL(dev_priv) ||
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index d94f361b548b7..19d8d3eefbc27 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1612,6 +1612,7 @@ struct intel_dp {
/* Display stream compression testing */
bool force_dsc_en;
+ int force_dsc_bpp;
bool hobl_failed;
bool hobl_active;
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] [PATCH v2 2/2] drm/i915/display/dsc: Set BPP in the kernel
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
2021-06-29 6:51 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
@ 2021-06-29 6:51 ` venkata.sai.patnana
2021-06-29 7:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dsc: Set BPP in the kernel (rev2) Patchwork
` (8 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: venkata.sai.patnana @ 2021-06-29 6:51 UTC (permalink / raw)
To: intel-gfx
From: Anusha Srivatsa <anusha.srivatsa@intel.com>
Set compress BPP in kernel while connector DP or eDP
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Navare Manasi D <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 23 ++++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index f74f70691247b..08205923bff07 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1241,9 +1241,15 @@ static int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
pipe_config->lane_count = limits->max_lane_count;
if (intel_dp_is_edp(intel_dp)) {
- pipe_config->dsc.compressed_bpp =
- min_t(u16, drm_edp_dsc_sink_output_bpp(intel_dp->dsc_dpcd) >> 4,
- pipe_config->pipe_bpp);
+ if (intel_dp->force_dsc_bpp) {
+ drm_dbg_kms(&dev_priv->drm,
+ "DSC BPP forced to %d", intel_dp->force_dsc_bpp);
+ pipe_config->dsc.compressed_bpp = intel_dp->force_dsc_bpp;
+ } else {
+ pipe_config->dsc.compressed_bpp =
+ min_t(u16, drm_edp_dsc_sink_output_bpp(intel_dp->dsc_dpcd) >> 4,
+ pipe_config->pipe_bpp);
+ }
pipe_config->dsc.slice_count =
drm_dp_dsc_sink_max_slice_count(intel_dp->dsc_dpcd,
true);
@@ -1269,9 +1275,15 @@ static int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
"Compressed BPP/Slice Count not supported\n");
return -EINVAL;
}
- pipe_config->dsc.compressed_bpp = min_t(u16,
+ if (intel_dp->force_dsc_bpp) {
+ drm_dbg_kms(&dev_priv->drm,
+ "DSC BPP forced to %d\n", intel_dp->force_dsc_bpp);
+ pipe_config->dsc.compressed_bpp = intel_dp->force_dsc_bpp;
+ } else {
+ pipe_config->dsc.compressed_bpp = min_t(u16,
dsc_max_output_bpp >> 4,
pipe_config->pipe_bpp);
+ }
pipe_config->dsc.slice_count = dsc_dp_slice_count;
}
/*
@@ -1374,7 +1386,8 @@ intel_dp_compute_link_config(struct intel_encoder *encoder,
* Pipe joiner needs compression upto display12 due to BW limitation. DG2
* onwards pipe joiner can be enabled without compression.
*/
- drm_dbg_kms(&i915->drm, "Force DSC en = %d\n", intel_dp->force_dsc_en);
+ drm_dbg_kms(&i915->drm, "Force DSC en = %d\n Force DSC BPP = %d\n",
+ intel_dp->force_dsc_en, intel_dp->force_dsc_bpp);
if (ret || intel_dp->force_dsc_en || (DISPLAY_VER(i915) < 13 &&
pipe_config->bigjoiner)) {
ret = intel_dp_dsc_compute_config(intel_dp, pipe_config,
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dsc: Set BPP in the kernel (rev2)
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
2021-06-29 6:51 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
2021-06-29 6:51 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
@ 2021-06-29 7:25 ` Patchwork
2021-06-29 7:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (7 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2021-06-29 7:25 UTC (permalink / raw)
To: venkata.sai.patnana; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display/dsc: Set BPP in the kernel (rev2)
URL : https://patchwork.freedesktop.org/series/91917/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8c10d57a92b5 drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
-:71: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#71: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2433:
+ seq_printf(m, "Compressed_BPP: %d\n",
+ crtc_state->dsc.compressed_bpp);
-:81: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#81: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2443:
+static ssize_t i915_dsc_bpp_support_write(struct file *file,
+ const char __user *ubuf,
-:109: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#109: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2471:
+static int i915_dsc_bpp_support_open(struct inode *inode,
+ struct file *file)
-:138: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#138: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2530:
+ debugfs_create_file("i915_dsc_bpp_support", S_IRUGO,
total: 0 errors, 1 warnings, 3 checks, 124 lines checked
f9fdb098f248 drm/i915/display/dsc: Set BPP in the kernel
-:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#26: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1246:
+ drm_dbg_kms(&dev_priv->drm,
+ "DSC BPP forced to %d", intel_dp->force_dsc_bpp);
-:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#31: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1251:
+ min_t(u16, drm_edp_dsc_sink_output_bpp(intel_dp->dsc_dpcd) >> 4,
+ pipe_config->pipe_bpp);
-:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#47: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1284:
+ pipe_config->dsc.compressed_bpp = min_t(u16,
dsc_max_output_bpp >> 4,
total: 0 errors, 0 warnings, 3 checks, 43 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display/dsc: Set BPP in the kernel (rev2)
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
` (2 preceding siblings ...)
2021-06-29 7:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dsc: Set BPP in the kernel (rev2) Patchwork
@ 2021-06-29 7:26 ` Patchwork
2021-06-29 7:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (6 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2021-06-29 7:26 UTC (permalink / raw)
To: venkata.sai.patnana; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display/dsc: Set BPP in the kernel (rev2)
URL : https://patchwork.freedesktop.org/series/91917/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_display.c:1893:21: expected struct i915_vma *[assigned] vma
+drivers/gpu/drm/i915/display/intel_display.c:1893:21: got void [noderef] __iomem *[assigned] iomem
+drivers/gpu/drm/i915/display/intel_display.c:1893:21: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_reset.c:1396:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block
+./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080)
+./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080)
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/dsc: Set BPP in the kernel (rev2)
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
` (3 preceding siblings ...)
2021-06-29 7:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2021-06-29 7:55 ` Patchwork
2021-06-29 9:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (5 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2021-06-29 7:55 UTC (permalink / raw)
To: venkata.sai.patnana; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1895 bytes --]
== Series Details ==
Series: drm/i915/display/dsc: Set BPP in the kernel (rev2)
URL : https://patchwork.freedesktop.org/series/91917/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10285 -> Patchwork_20482
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/index.html
Known issues
------------
Here are the changes found in Patchwork_20482 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [FAIL][1] ([i915#1372]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
Participating hosts (40 -> 36)
------------------------------
Missing (4): fi-kbl-soraka fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* IGT: IGT_6121 -> IGTPW_5962
* Linux: CI_DRM_10285 -> Patchwork_20482
CI-20190529: 20190529
CI_DRM_10285: e65a658751fc5d3be5b0f4bcc4731e66ca1a537a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5962: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5962/index.html
IGT_6121: a63ceb48e6c3e733d04156b32fba3b4f4d5ad794 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20482: f9fdb098f2480a719e469ed1f7efa2392db8ec67 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f9fdb098f248 drm/i915/display/dsc: Set BPP in the kernel
8c10d57a92b5 drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/index.html
[-- Attachment #1.2: Type: text/html, Size: 2507 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/dsc: Set BPP in the kernel (rev2)
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
` (4 preceding siblings ...)
2021-06-29 7:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-06-29 9:04 ` Patchwork
2021-07-01 9:12 ` [Intel-gfx] [v3 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
` (4 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2021-06-29 9:04 UTC (permalink / raw)
To: venkata.sai.patnana; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30273 bytes --]
== Series Details ==
Series: drm/i915/display/dsc: Set BPP in the kernel (rev2)
URL : https://patchwork.freedesktop.org/series/91917/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10285_full -> Patchwork_20482_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20482_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20482_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20482_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-glk3/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-glk3/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
* {igt@kms_dp_dsc@dsc-15bpp-compression-xrgb8888} (NEW):
- shard-tglb: NOTRUN -> [SKIP][3] +14 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-tglb7/igt@kms_dp_dsc@dsc-15bpp-compression-xrgb8888.html
* {igt@kms_dp_dsc@dsc-22bpp-compression-xrgb8888} (NEW):
- shard-iclb: NOTRUN -> [SKIP][4] +15 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb6/igt@kms_dp_dsc@dsc-22bpp-compression-xrgb8888.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- {shard-rkl-6}: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_mmap_wc@set-cache-level:
- {shard-rkl-2}: NOTRUN -> [SKIP][6] +59 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-2/igt@gem_mmap_wc@set-cache-level.html
* igt@kms_busy@basic:
- {shard-rkl-5}: NOTRUN -> [SKIP][7] +49 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-5/igt@kms_busy@basic.html
* {igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs}:
- {shard-rkl-6}: NOTRUN -> [SKIP][8] +10 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-6/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs.html
* {igt@kms_ccs@pipe-b-bad-pixel-format-yf_tiled_ccs}:
- {shard-rkl-1}: NOTRUN -> [FAIL][9] +49 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-1/igt@kms_ccs@pipe-b-bad-pixel-format-yf_tiled_ccs.html
* {igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs}:
- {shard-rkl-5}: NOTRUN -> [FAIL][10] +21 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-5/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* {igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_ccs}:
- {shard-rkl-2}: NOTRUN -> [FAIL][11] +31 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-2/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_ccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- {shard-rkl-1}: NOTRUN -> [INCOMPLETE][12] +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- {shard-rkl-5}: NOTRUN -> [INCOMPLETE][13]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- {shard-rkl-2}: NOTRUN -> [INCOMPLETE][14]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-render:
- {shard-rkl-1}: NOTRUN -> [SKIP][15] +253 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-render.html
* igt@runner@aborted:
- {shard-rkl-2}: [FAIL][16] ([i915#3002]) -> [FAIL][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-rkl-2/igt@runner@aborted.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-rkl-2/igt@runner@aborted.html
New tests
---------
New tests have been introduced between CI_DRM_10285_full and Patchwork_20482_full:
### New IGT tests (21) ###
* igt@kms_dp_dsc@basic-dsc-enable:
- Statuses : 5 skip(s)
- Exec time: [0.0, 0.00] s
* igt@kms_dp_dsc@basic-dsc-enable@edp-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [1.50] s
* igt@kms_dp_dsc@basic-dsc-enable@edp-1-pipe-b:
- Statuses : 1 pass(s)
- Exec time: [1.15] s
* igt@kms_dp_dsc@basic-dsc-enable@edp-1-pipe-c:
- Statuses : 1 pass(s)
- Exec time: [1.16] s
* igt@kms_dp_dsc@basic-dsc-enable@edp-1-pipe-d:
- Statuses : 1 pass(s)
- Exec time: [1.16] s
* igt@kms_dp_dsc@dsc-10bpp-compression-xrgb8888:
- Statuses :
- Exec time: [None] s
* igt@kms_dp_dsc@dsc-11bpp-compression-xrgb8888:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-12bpp-compression-xrgb8888:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-13bpp-compression-xrgb8888:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-14bpp-compression-xrgb8888:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-15bpp-compression-xrgb8888:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-16bpp-compression-xrgb8888:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-17bpp-compression-xrgb8888:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-18bpp-compression-xrgb8888:
- Statuses : 6 skip(s)
- Exec time: [0.0, 0.00] s
* igt@kms_dp_dsc@dsc-19bpp-compression-xrgb8888:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-20bpp-compression-xrgb8888:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-21bpp-compression-xrgb8888:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-22bpp-compression-xrgb8888:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-23bpp-compression-xrgb8888:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-8bpp-compression-xrgb8888:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_dp_dsc@dsc-9bpp-compression-xrgb8888:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_20482_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-mixed:
- shard-snb: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#1099]) +3 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-snb2/igt@gem_ctx_persistence@engines-mixed.html
* igt@gem_eio@in-flight-suspend:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#180])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-apl7/igt@gem_eio@in-flight-suspend.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl6/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][21] -> [TIMEOUT][22] ([i915#2369] / [i915#2481] / [i915#3070])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-iclb5/igt@gem_eio@unwedge-stress.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb3/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-deadline:
- shard-apl: NOTRUN -> [FAIL][23] ([i915#2846])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: NOTRUN -> [FAIL][24] ([i915#2842])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb3/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][25] -> [FAIL][26] ([i915#2842])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-iclb4/igt@gem_exec_fair@basic-none-share@rcs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html
- shard-tglb: [PASS][27] -> [FAIL][28] ([i915#2842])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-tglb3/igt@gem_exec_fair@basic-none-share@rcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][29] -> [FAIL][30] ([i915#2842]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][31] -> [SKIP][32] ([fdo#109271]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs0.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_params@secure-non-root:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#112283])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb8/igt@gem_exec_params@secure-non-root.html
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][34] ([i915#3633]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-snb7/igt@gem_exec_reloc@basic-wide-active@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#2190])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl6/igt@gem_huc_copy@huc-copy.html
- shard-kbl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#2190])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl6/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@cpuset-big-copy:
- shard-iclb: [PASS][37] -> [FAIL][38] ([i915#2428])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-iclb3/igt@gem_mmap_gtt@cpuset-big-copy.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy.html
* igt@gem_mmap_offset@clear:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#3160])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-skl9/igt@gem_mmap_offset@clear.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl7/igt@gem_mmap_offset@clear.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][41] ([i915#2658]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl6/igt@gem_pread@exhaustion.html
- shard-kbl: NOTRUN -> [WARN][42] ([i915#2658])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl6/igt@gem_pread@exhaustion.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][43] ([i915#3002])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl2/igt@gem_userptr_blits@input-checking.html
- shard-kbl: NOTRUN -> [DMESG-WARN][44] ([i915#3002])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl2/igt@gem_userptr_blits@input-checking.html
* igt@gen9_exec_parse@batch-invalid-length:
- shard-snb: NOTRUN -> [SKIP][45] ([fdo#109271]) +373 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-snb5/igt@gen9_exec_parse@batch-invalid-length.html
* igt@gen9_exec_parse@bb-chained:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#112306]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb3/igt@gen9_exec_parse@bb-chained.html
* igt@gen9_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#112306])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-tglb3/igt@gen9_exec_parse@cmd-crossing-page.html
* igt@i915_pm_dc@dc9-dpms:
- shard-tglb: NOTRUN -> [SKIP][48] ([i915#3288])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-tglb7/igt@i915_pm_dc@dc9-dpms.html
- shard-iclb: NOTRUN -> [FAIL][49] ([i915#3343])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb2/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#110892])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-iclb: NOTRUN -> [SKIP][51] ([i915#1769])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb8/igt@kms_atomic_transition@plane-all-modeset-transition.html
- shard-tglb: NOTRUN -> [SKIP][52] ([i915#1769])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-tglb6/igt@kms_atomic_transition@plane-all-modeset-transition.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#110723])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb4/igt@kms_big_fb@yf-tiled-8bpp-rotate-90.html
* igt@kms_chamelium@dp-crc-multiple:
- shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +5 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl7/igt@kms_chamelium@dp-crc-multiple.html
* igt@kms_chamelium@dp-hpd-storm-disable:
- shard-glk: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-glk1/igt@kms_chamelium@dp-hpd-storm-disable.html
* igt@kms_chamelium@hdmi-mode-timings:
- shard-snb: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#111827]) +19 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-snb2/igt@kms_chamelium@hdmi-mode-timings.html
* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271] / [fdo#111827]) +19 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl1/igt@kms_chamelium@vga-hpd.html
* igt@kms_color@pipe-d-ctm-0-25:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109278] / [i915#1149])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb1/igt@kms_color@pipe-d-ctm-0-25.html
* igt@kms_color_chamelium@pipe-a-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109284] / [fdo#111827]) +5 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb5/igt@kms_color_chamelium@pipe-a-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-d-ctm-green-to-red:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [fdo#111827]) +16 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl6/igt@kms_color_chamelium@pipe-d-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
- shard-tglb: NOTRUN -> [SKIP][61] ([fdo#109284] / [fdo#111827]) +3 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-tglb1/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html
* igt@kms_concurrent@pipe-b:
- shard-skl: [PASS][62] -> [SKIP][63] ([fdo#109271]) +15 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-skl2/igt@kms_concurrent@pipe-b.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl8/igt@kms_concurrent@pipe-b.html
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> [TIMEOUT][64] ([i915#1319])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl2/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][65] ([i915#2105])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl2/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][66] ([i915#180])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
- shard-apl: NOTRUN -> [DMESG-WARN][67] ([i915#180])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-max-size-offscreen:
- shard-tglb: NOTRUN -> [SKIP][68] ([i915#3359])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-tglb3/igt@kms_cursor_crc@pipe-d-cursor-max-size-offscreen.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109274] / [fdo#109278])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb3/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#533]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl7/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* {igt@kms_dp_dsc@dsc-23bpp-compression-xrgb8888} (NEW):
- shard-glk: NOTRUN -> [SKIP][71] ([fdo#109271]) +32 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-glk3/igt@kms_dp_dsc@dsc-23bpp-compression-xrgb8888.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- shard-glk: [PASS][72] -> [DMESG-FAIL][73] ([i915#118] / [i915#95])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-glk9/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-glk1/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
* igt@kms_flip@2x-nonexisting-fb-interruptible:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#111825]) +9 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-tglb5/igt@kms_flip@2x-nonexisting-fb-interruptible.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109274]) +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb3/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: NOTRUN -> [FAIL][76] ([i915#2122])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][77] -> [DMESG-WARN][78] ([i915#180]) +4 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-kbl4/igt@kms_flip@flip-vs-suspend@c-dp1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl4/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [PASS][79] -> [FAIL][80] ([i915#2122])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-skl4/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl3/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-skl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#2672])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl10/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#2587])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2672])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt:
- shard-kbl: NOTRUN -> [SKIP][84] ([fdo#109271]) +188 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-fullscreen:
- shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271]) +55 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-fullscreen.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109280]) +15 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt.html
* igt@kms_hdmi_inject@inject-audio:
- shard-snb: [PASS][87] -> [SKIP][88] ([fdo#109271])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-snb6/igt@kms_hdmi_inject@inject-audio.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-snb7/igt@kms_hdmi_inject@inject-audio.html
- shard-tglb: [PASS][89] -> [SKIP][90] ([i915#433])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-tglb5/igt@kms_hdmi_inject@inject-audio.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-tglb2/igt@kms_hdmi_inject@inject-audio.html
- shard-iclb: [PASS][91] -> [SKIP][92] ([i915#433])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-iclb7/igt@kms_hdmi_inject@inject-audio.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb3/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][93] -> [FAIL][94] ([i915#1188])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl2/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c:
- shard-apl: NOTRUN -> [SKIP][95] ([fdo#109271]) +209 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl2/igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c.html
* igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109289])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb1/igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#533]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][98] ([i915#265])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][99] ([fdo#108145] / [i915#265])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][100] ([fdo#108145] / [i915#265]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl6/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][101] ([i915#265])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl3/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][102] -> [FAIL][103] ([fdo#108145] / [i915#265])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#658]) +4 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#658]) +5 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl2/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3:
- shard-skl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#658])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
- shard-iclb: NOTRUN -> [SKIP][107] ([i915#658])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][108] -> [SKIP][109] ([fdo#109441]) +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-snb: NOTRUN -> [FAIL][110] ([i915#31])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-snb6/igt@kms_setmode@basic.html
* igt@kms_sysfs_edid_timing:
- shard-kbl: NOTRUN -> [FAIL][111] ([IGT#2])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-kbl3/igt@kms_sysfs_edid_timing.html
- shard-skl: NOTRUN -> [FAIL][112] ([IGT#2])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl6/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-d-ts-continuation-idle-hang:
- shard-iclb: NOTRUN -> [SKIP][113] ([fdo#109278]) +12 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb7/igt@kms_vblank@pipe-d-ts-continuation-idle-hang.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#2437])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl6/igt@kms_writeback@writeback-check-output.html
* igt@nouveau_crc@pipe-b-source-outp-inactive:
- shard-iclb: NOTRUN -> [SKIP][115] ([i915#2530]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb1/igt@nouveau_crc@pipe-b-source-outp-inactive.html
- shard-tglb: NOTRUN -> [SKIP][116] ([i915#2530])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-tglb6/igt@nouveau_crc@pipe-b-source-outp-inactive.html
* igt@perf@short-reads:
- shard-skl: [PASS][117] -> [FAIL][118] ([i915#51])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/shard-skl3/igt@perf@short-reads.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl1/igt@perf@short-reads.html
* igt@prime_nv_api@i915_nv_import_vs_close:
- shard-iclb: NOTRUN -> [SKIP][119] ([fdo#109291]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb4/igt@prime_nv_api@i915_nv_import_vs_close.html
* igt@prime_nv_pcopy@test3_1:
- shard-tglb: NOTRUN -> [SKIP][120] ([fdo#109291])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-tglb6/igt@prime_nv_pcopy@test3_1.html
* igt@sysfs_clients@recycle-many:
- shard-apl: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2994]) +2 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-apl8/igt@sysfs_clients@recycle-many.html
- shard-iclb: NOTRUN -> [SKIP][122] ([i915#2994])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-iclb3/igt@sysfs_clients@recycle-many.html
- shard-glk: NOTRUN -> [SKIP][123] ([fdo#109271] / [i915#2994])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-glk4/igt@sysfs_clients@recycle-many.html
- shard-skl: NOTRUN -> [SKIP][124] ([fdo#109271] / [i915#2994])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/shard-skl8/igt@sysfs_clients@recycle-many.html
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20482/index.html
[-- Attachment #1.2: Type: text/html, Size: 34283 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
2021-06-29 6:51 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
@ 2021-06-29 14:35 ` Jani Nikula
2021-06-30 6:29 ` Patnana, Venkata Sai
2021-07-01 9:16 ` [Intel-gfx] [v3 " venkata.sai.patnana
1 sibling, 1 reply; 19+ messages in thread
From: Jani Nikula @ 2021-06-29 14:35 UTC (permalink / raw)
To: venkata.sai.patnana, intel-gfx
On Tue, 29 Jun 2021, venkata.sai.patnana@intel.com wrote:
> From: Anusha Srivatsa <anusha.srivatsa@intel.com>
>
> DSC can be supported per DP connector. This patch creates
> a per connector debugfs node to expose the Input and
> Compressed BPP.
>
> The same node can be used from userspace to force
> DSC to a certain BPP.
>
> force_dsc_bpp is written through this debugfs
> node to force DSC BPP to all accepted values
This commit message only describes the "what". It's nice and helpful to
summarize the code changes.
But the key question the commit message must answer is "why". Why are
you doing this? Why do we need this?
This looks like it complicates code that is already complicated to add a
debugfs. There needs to be a justification if it isn't obvious.
A couple of comments inline.
>
> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> Cc: Navare Manasi D <manasi.d.navare@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
> ---
> .../drm/i915/display/intel_display_debugfs.c | 103 +++++++++++++++++-
> .../drm/i915/display/intel_display_types.h | 1 +
> 2 files changed, 103 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index af9e58619667d..6dc223227eeaa 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -2389,6 +2389,100 @@ static const struct file_operations i915_dsc_fec_support_fops = {
> .write = i915_dsc_fec_support_write
> };
>
> +static int i915_dsc_bpp_support_show(struct seq_file *m, void *data)
> +{
> + struct drm_connector *connector = m->private;
> + struct drm_device *dev = connector->dev;
> + struct drm_crtc *crtc;
> + struct intel_dp *intel_dp;
> + struct drm_modeset_acquire_ctx ctx;
> + struct intel_crtc_state *crtc_state = NULL;
> + int ret = 0;
> + bool try_again = false;
> +
> + drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
> +
> + do {
> + try_again = false;
> + ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
> + &ctx);
> + if (ret) {
> + ret = -EINTR;
> + break;
> + }
> + crtc = connector->state->crtc;
> + if (connector->status != connector_status_connected || !crtc) {
> + ret = -ENODEV;
> + break;
> + }
> + ret = drm_modeset_lock(&crtc->mutex, &ctx);
> + if (ret == -EDEADLK) {
> + ret = drm_modeset_backoff(&ctx);
> + if (!ret) {
> + try_again = true;
> + continue;
> + }
> + break;
> + } else if (ret) {
> + break;
> + }
> + intel_dp = intel_attached_dp(to_intel_connector(connector));
> + crtc_state = to_intel_crtc_state(crtc->state);
> + seq_printf(m, "Input_BPP: %d\n", crtc_state->pipe_bpp);
> + seq_printf(m, "Compressed_BPP: %d\n",
> + crtc_state->dsc.compressed_bpp);
> + } while (try_again);
> +
> + drm_modeset_drop_locks(&ctx);
> + drm_modeset_acquire_fini(&ctx);
> +
> + return ret;
Looks like copy-paste from i915_dsc_fec_support_show() which already
makes me cringe. We can't keep accumulating this kind of code in
debugfs.
> +}
> +
> +static ssize_t i915_dsc_bpp_support_write(struct file *file,
> + const char __user *ubuf,
> + size_t len, loff_t *offp)
> +{
> + int dsc_bpp = 0;
> + int ret;
> + struct drm_connector *connector =
> + ((struct seq_file *)file->private_data)->private;
> + struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> +
> + if (len == 0)
> + return 0;
> +
> + drm_dbg(&i915->drm,
> + "Copied %zu bytes from user to force BPP\n", len);
Just no. Again, copy-paste from the fec stuff that we shouldn't have to
begin with.
> +
> + ret = kstrtoint_from_user(ubuf, len, 0, &dsc_bpp);
> +
> + intel_dp->force_dsc_bpp = dsc_bpp;
> + if (ret < 0)
> + return ret;
Check the errors before using the data!
Also, how are you prepared for fractional bpp?
> +
> + *offp += len;
> + return len;
> +}
> +
> +static int i915_dsc_bpp_support_open(struct inode *inode,
> + struct file *file)
> +{
> + return single_open(file, i915_dsc_bpp_support_show,
> + inode->i_private);
> +}
> +
> +static const struct file_operations i915_dsc_bpp_support_fops = {
> + .owner = THIS_MODULE,
> + .open = i915_dsc_bpp_support_open,
> + .read = seq_read,
> + .llseek = seq_lseek,
> + .release = single_release,
> + .write = i915_dsc_bpp_support_write
> +};
> +
> /**
> * intel_connector_debugfs_add - add i915 specific connector debugfs files
> * @connector: pointer to a registered drm_connector
> @@ -2427,9 +2521,16 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
> connector, &i915_hdcp_sink_capability_fops);
> }
>
> - if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) && ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort && !to_intel_connector(connector)->mst_port) || connector->connector_type == DRM_MODE_CONNECTOR_eDP))
> + if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) &&
> + ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
> + !to_intel_connector(connector)->mst_port) ||
> + connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
> debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
> connector, &i915_dsc_fec_support_fops);
> + debugfs_create_file("i915_dsc_bpp_support", S_IRUGO,
> + root, connector,
> + &i915_dsc_bpp_support_fops);
> + }
>
> /* Legacy panels doesn't lpsp on any platform */
> if ((DISPLAY_VER(dev_priv) >= 9 || IS_HASWELL(dev_priv) ||
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index d94f361b548b7..19d8d3eefbc27 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1612,6 +1612,7 @@ struct intel_dp {
>
> /* Display stream compression testing */
> bool force_dsc_en;
> + int force_dsc_bpp;
>
> bool hobl_failed;
> bool hobl_active;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
2021-06-29 14:35 ` Jani Nikula
@ 2021-06-30 6:29 ` Patnana, Venkata Sai
2021-06-30 13:24 ` Patnana, Venkata Sai
0 siblings, 1 reply; 19+ messages in thread
From: Patnana, Venkata Sai @ 2021-06-30 6:29 UTC (permalink / raw)
To: Jani Nikula, intel-gfx, Navare, Manasi D, Kulkarni, Vandita
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Tuesday, June 29, 2021 8:06 PM
> To: Patnana, Venkata Sai <venkata.sai.patnana@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector
> debugfs node for DSC BPP enable
>
> On Tue, 29 Jun 2021, venkata.sai.patnana@intel.com wrote:
> > From: Anusha Srivatsa <anusha.srivatsa@intel.com>
> >
> > DSC can be supported per DP connector. This patch creates a per
> > connector debugfs node to expose the Input and Compressed BPP.
> >
> > The same node can be used from userspace to force DSC to a certain
> > BPP.
> >
> > force_dsc_bpp is written through this debugfs node to force DSC BPP to
> > all accepted values
>
> This commit message only describes the "what". It's nice and helpful to
> summarize the code changes.
>
> But the key question the commit message must answer is "why". Why are you
> doing this? Why do we need this?
>
> This looks like it complicates code that is already complicated to add a debugfs.
> There needs to be a justification if it isn't obvious.
>
> A couple of comments inline.
>
> >
> > Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> > Cc: Navare Manasi D <manasi.d.navare@intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
> > ---
> > .../drm/i915/display/intel_display_debugfs.c | 103 +++++++++++++++++-
> > .../drm/i915/display/intel_display_types.h | 1 +
> > 2 files changed, 103 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > index af9e58619667d..6dc223227eeaa 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > @@ -2389,6 +2389,100 @@ static const struct file_operations
> i915_dsc_fec_support_fops = {
> > .write = i915_dsc_fec_support_write
> > };
> >
> > +static int i915_dsc_bpp_support_show(struct seq_file *m, void *data)
> > +{
> > + struct drm_connector *connector = m->private;
> > + struct drm_device *dev = connector->dev;
> > + struct drm_crtc *crtc;
> > + struct intel_dp *intel_dp;
> > + struct drm_modeset_acquire_ctx ctx;
> > + struct intel_crtc_state *crtc_state = NULL;
> > + int ret = 0;
> > + bool try_again = false;
> > +
> > + drm_modeset_acquire_init(&ctx,
> DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
> > +
> > + do {
> > + try_again = false;
> > + ret = drm_modeset_lock(&dev-
> >mode_config.connection_mutex,
> > + &ctx);
> > + if (ret) {
> > + ret = -EINTR;
> > + break;
> > + }
> > + crtc = connector->state->crtc;
> > + if (connector->status != connector_status_connected || !crtc) {
> > + ret = -ENODEV;
> > + break;
> > + }
> > + ret = drm_modeset_lock(&crtc->mutex, &ctx);
> > + if (ret == -EDEADLK) {
> > + ret = drm_modeset_backoff(&ctx);
> > + if (!ret) {
> > + try_again = true;
> > + continue;
> > + }
> > + break;
> > + } else if (ret) {
> > + break;
> > + }
> > + intel_dp = intel_attached_dp(to_intel_connector(connector));
> > + crtc_state = to_intel_crtc_state(crtc->state);
> > + seq_printf(m, "Input_BPP: %d\n", crtc_state->pipe_bpp);
> > + seq_printf(m, "Compressed_BPP: %d\n",
> > + crtc_state->dsc.compressed_bpp);
> > + } while (try_again);
> > +
> > + drm_modeset_drop_locks(&ctx);
> > + drm_modeset_acquire_fini(&ctx);
> > +
> > + return ret;
>
> Looks like copy-paste from i915_dsc_fec_support_show() which already makes
> me cringe. We can't keep accumulating this kind of code in debugfs.
@Navare, Manasi D, @Kulkarni, Vandita any thoughts ?
>
> > +}
> > +
> > +static ssize_t i915_dsc_bpp_support_write(struct file *file,
> > + const char __user *ubuf,
> > + size_t len, loff_t *offp)
> > +{
> > + int dsc_bpp = 0;
> > + int ret;
> > + struct drm_connector *connector =
> > + ((struct seq_file *)file->private_data)->private;
> > + struct intel_encoder *encoder =
> intel_attached_encoder(to_intel_connector(connector));
> > + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > +
> > + if (len == 0)
> > + return 0;
> > +
> > + drm_dbg(&i915->drm,
> > + "Copied %zu bytes from user to force BPP\n", len);
>
> Just no. Again, copy-paste from the fec stuff that we shouldn't have to begin
> with.
>
> > +
> > + ret = kstrtoint_from_user(ubuf, len, 0, &dsc_bpp);
> > +
> > + intel_dp->force_dsc_bpp = dsc_bpp;
> > + if (ret < 0)
> > + return ret;
>
> Check the errors before using the data!
>
> Also, how are you prepared for fractional bpp?
>
> > +
> > + *offp += len;
> > + return len;
> > +}
> > +
> > +static int i915_dsc_bpp_support_open(struct inode *inode,
> > + struct file *file)
> > +{
> > + return single_open(file, i915_dsc_bpp_support_show,
> > + inode->i_private);
> > +}
> > +
> > +static const struct file_operations i915_dsc_bpp_support_fops = {
> > + .owner = THIS_MODULE,
> > + .open = i915_dsc_bpp_support_open,
> > + .read = seq_read,
> > + .llseek = seq_lseek,
> > + .release = single_release,
> > + .write = i915_dsc_bpp_support_write
> > +};
> > +
> > /**
> > * intel_connector_debugfs_add - add i915 specific connector debugfs files
> > * @connector: pointer to a registered drm_connector @@ -2427,9
> > +2521,16 @@ int intel_connector_debugfs_add(struct drm_connector
> *connector)
> > connector,
> &i915_hdcp_sink_capability_fops);
> > }
> >
> > - if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) &&
> ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
> !to_intel_connector(connector)->mst_port) || connector->connector_type ==
> DRM_MODE_CONNECTOR_eDP))
> > + if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) &&
> > + ((connector->connector_type ==
> DRM_MODE_CONNECTOR_DisplayPort &&
> > + !to_intel_connector(connector)->mst_port) ||
> > + connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
> > debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
> > connector, &i915_dsc_fec_support_fops);
> > + debugfs_create_file("i915_dsc_bpp_support", S_IRUGO,
> > + root, connector,
> > + &i915_dsc_bpp_support_fops);
> > + }
> >
> > /* Legacy panels doesn't lpsp on any platform */
> > if ((DISPLAY_VER(dev_priv) >= 9 || IS_HASWELL(dev_priv) || diff
> > --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> > b/drivers/gpu/drm/i915/display/intel_display_types.h
> > index d94f361b548b7..19d8d3eefbc27 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > @@ -1612,6 +1612,7 @@ struct intel_dp {
> >
> > /* Display stream compression testing */
> > bool force_dsc_en;
> > + int force_dsc_bpp;
> >
> > bool hobl_failed;
> > bool hobl_active;
>
> --
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
2021-06-30 6:29 ` Patnana, Venkata Sai
@ 2021-06-30 13:24 ` Patnana, Venkata Sai
0 siblings, 0 replies; 19+ messages in thread
From: Patnana, Venkata Sai @ 2021-06-30 13:24 UTC (permalink / raw)
To: Jani Nikula, intel-gfx, Navare, Manasi D, Kulkarni, Vandita
> -----Original Message-----
> From: Patnana, Venkata Sai
> Sent: Wednesday, June 30, 2021 11:59 AM
> To: Jani Nikula <jani.nikula@linux.intel.com>; intel-gfx@lists.freedesktop.org;
> Navare, Manasi D <manasi.d.navare@intel.com>; Kulkarni, Vandita
> <vandita.kulkarni@intel.com>
> Subject: RE: [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector
> debugfs node for DSC BPP enable
>
> > From: Jani Nikula <jani.nikula@linux.intel.com>
> > Sent: Tuesday, June 29, 2021 8:06 PM
> > To: Patnana, Venkata Sai <venkata.sai.patnana@intel.com>; intel-
> > gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per
> > connector debugfs node for DSC BPP enable
> >
> > On Tue, 29 Jun 2021, venkata.sai.patnana@intel.com wrote:
> > > From: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > >
> > > DSC can be supported per DP connector. This patch creates a per
> > > connector debugfs node to expose the Input and Compressed BPP.
> > >
> > > The same node can be used from userspace to force DSC to a certain
> > > BPP.
> > >
> > > force_dsc_bpp is written through this debugfs node to force DSC BPP
> > > to all accepted values
> >
> > This commit message only describes the "what". It's nice and helpful
> > to summarize the code changes.
I ll update commit message with below details.
> >
> > But the key question the commit message must answer is "why". Why are
> > you doing this? Why do we need this?
We want to test all the possible compression bpp's otherwise else we can verify limited bpp's
> >
> > This looks like it complicates code that is already complicated to add a
> debugfs.
> > There needs to be a justification if it isn't obvious.
> >
> > A couple of comments inline.
> >
> > >
> > > Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> > > Cc: Navare Manasi D <manasi.d.navare@intel.com>
> > > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > > Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
> > > ---
> > > .../drm/i915/display/intel_display_debugfs.c | 103 +++++++++++++++++-
> > > .../drm/i915/display/intel_display_types.h | 1 +
> > > 2 files changed, 103 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > index af9e58619667d..6dc223227eeaa 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > @@ -2389,6 +2389,100 @@ static const struct file_operations
> > i915_dsc_fec_support_fops = {
> > > .write = i915_dsc_fec_support_write };
> > >
> > > +static int i915_dsc_bpp_support_show(struct seq_file *m, void
> > > +*data) {
> > > + struct drm_connector *connector = m->private;
> > > + struct drm_device *dev = connector->dev;
> > > + struct drm_crtc *crtc;
> > > + struct intel_dp *intel_dp;
> > > + struct drm_modeset_acquire_ctx ctx;
> > > + struct intel_crtc_state *crtc_state = NULL;
> > > + int ret = 0;
> > > + bool try_again = false;
> > > +
> > > + drm_modeset_acquire_init(&ctx,
> > DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
> > > +
> > > + do {
> > > + try_again = false;
> > > + ret = drm_modeset_lock(&dev-
> > >mode_config.connection_mutex,
> > > + &ctx);
> > > + if (ret) {
> > > + ret = -EINTR;
> > > + break;
> > > + }
> > > + crtc = connector->state->crtc;
> > > + if (connector->status != connector_status_connected || !crtc) {
> > > + ret = -ENODEV;
> > > + break;
> > > + }
> > > + ret = drm_modeset_lock(&crtc->mutex, &ctx);
> > > + if (ret == -EDEADLK) {
> > > + ret = drm_modeset_backoff(&ctx);
> > > + if (!ret) {
> > > + try_again = true;
> > > + continue;
> > > + }
> > > + break;
> > > + } else if (ret) {
> > > + break;
> > > + }
> > > + intel_dp = intel_attached_dp(to_intel_connector(connector));
> > > + crtc_state = to_intel_crtc_state(crtc->state);
> > > + seq_printf(m, "Input_BPP: %d\n", crtc_state->pipe_bpp);
> > > + seq_printf(m, "Compressed_BPP: %d\n",
> > > + crtc_state->dsc.compressed_bpp);
> > > + } while (try_again);
> > > +
> > > + drm_modeset_drop_locks(&ctx);
> > > + drm_modeset_acquire_fini(&ctx);
> > > +
> > > + return ret;
> >
> > Looks like copy-paste from i915_dsc_fec_support_show() which already
> > makes me cringe. We can't keep accumulating this kind of code in debugfs.
> @Navare, Manasi D, @Kulkarni, Vandita any thoughts ?
I ll create new file each entry, so that it become simple.
>
> >
> > > +}
> > > +
> > > +static ssize_t i915_dsc_bpp_support_write(struct file *file,
> > > + const char __user *ubuf,
> > > + size_t len, loff_t *offp)
> > > +{
> > > + int dsc_bpp = 0;
> > > + int ret;
> > > + struct drm_connector *connector =
> > > + ((struct seq_file *)file->private_data)->private;
> > > + struct intel_encoder *encoder =
> > intel_attached_encoder(to_intel_connector(connector));
> > > + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > > + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > > +
> > > + if (len == 0)
> > > + return 0;
> > > +
> > > + drm_dbg(&i915->drm,
> > > + "Copied %zu bytes from user to force BPP\n", len);
> >
> > Just no. Again, copy-paste from the fec stuff that we shouldn't have
> > to begin with.
> >
> > > +
> > > + ret = kstrtoint_from_user(ubuf, len, 0, &dsc_bpp);
> > > +
> > > + intel_dp->force_dsc_bpp = dsc_bpp;
> > > + if (ret < 0)
> > > + return ret;
> >
> > Check the errors before using the data!
I ll update it to above line
> >
> > Also, how are you prepared for fractional bpp?
"ok, I will check"
> >
> > > +
> > > + *offp += len;
> > > + return len;
> > > +}
> > > +
> > > +static int i915_dsc_bpp_support_open(struct inode *inode,
> > > + struct file *file)
> > > +{
> > > + return single_open(file, i915_dsc_bpp_support_show,
> > > + inode->i_private);
> > > +}
> > > +
> > > +static const struct file_operations i915_dsc_bpp_support_fops = {
> > > + .owner = THIS_MODULE,
> > > + .open = i915_dsc_bpp_support_open,
> > > + .read = seq_read,
> > > + .llseek = seq_lseek,
> > > + .release = single_release,
> > > + .write = i915_dsc_bpp_support_write };
> > > +
> > > /**
> > > * intel_connector_debugfs_add - add i915 specific connector debugfs files
> > > * @connector: pointer to a registered drm_connector @@ -2427,9
> > > +2521,16 @@ int intel_connector_debugfs_add(struct drm_connector
> > *connector)
> > > connector,
> > &i915_hdcp_sink_capability_fops);
> > > }
> > >
> > > - if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) &&
> > ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
> > !to_intel_connector(connector)->mst_port) || connector->connector_type
> > ==
> > DRM_MODE_CONNECTOR_eDP))
> > > + if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) &&
> > > + ((connector->connector_type ==
> > DRM_MODE_CONNECTOR_DisplayPort &&
> > > + !to_intel_connector(connector)->mst_port) ||
> > > + connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
> > > debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
> > > connector, &i915_dsc_fec_support_fops);
> > > + debugfs_create_file("i915_dsc_bpp_support", S_IRUGO,
> > > + root, connector,
> > > + &i915_dsc_bpp_support_fops);
> > > + }
> > >
> > > /* Legacy panels doesn't lpsp on any platform */
> > > if ((DISPLAY_VER(dev_priv) >= 9 || IS_HASWELL(dev_priv) || diff
> > > --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> > > b/drivers/gpu/drm/i915/display/intel_display_types.h
> > > index d94f361b548b7..19d8d3eefbc27 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > > @@ -1612,6 +1612,7 @@ struct intel_dp {
> > >
> > > /* Display stream compression testing */
> > > bool force_dsc_en;
> > > + int force_dsc_bpp;
> > >
> > > bool hobl_failed;
> > > bool hobl_active;
> >
> > --
> > Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] [v3 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
` (5 preceding siblings ...)
2021-06-29 9:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2021-07-01 9:12 ` venkata.sai.patnana
2021-07-01 9:12 ` [Intel-gfx] [v3 2/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
2021-07-01 10:00 ` [Intel-gfx] [v4 0/2] " venkata.sai.patnana
` (3 subsequent siblings)
10 siblings, 1 reply; 19+ messages in thread
From: venkata.sai.patnana @ 2021-07-01 9:12 UTC (permalink / raw)
To: intel-gfx
From: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
[What]:
This patch creates a per connector debugfs node to expose
the Input and Compressed BPP.
The same node can be used from userspace to force
DSC to a certain BPP(all accepted values).
[Why]:
Useful to verify all supported/requested compression bpp's
through IGT
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Navare Manasi D <manasi.d.navare@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
---
.../drm/i915/display/intel_display_debugfs.c | 76 ++++++++++++++++++-
.../drm/i915/display/intel_display_types.h | 1 +
2 files changed, 76 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index af9e58619667d..2305a0c2498cc 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -2389,6 +2389,73 @@ static const struct file_operations i915_dsc_fec_support_fops = {
.write = i915_dsc_fec_support_write
};
+static int i915_dsc_bpp_support_show(struct seq_file *m, void *data)
+{
+ struct drm_connector *connector = m->private;
+ struct drm_device *dev = connector->dev;
+ struct drm_crtc *crtc;
+ struct intel_crtc_state *crtc_state = NULL;
+ int ret = 0;
+
+ ret = drm_modeset_lock_single_interruptible(&dev->mode_config.connection_mutex);
+ if (ret)
+ return ret;
+
+ crtc = connector->state->crtc;
+ crtc_state = to_intel_crtc_state(crtc->state);
+ seq_printf(m, "Input_BPP: %d\n", crtc_state->pipe_bpp);
+ seq_printf(m, "Compressed_BPP: %d\n",
+ crtc_state->dsc.compressed_bpp);
+
+ drm_modeset_unlock(&dev->mode_config.connection_mutex);
+
+ return ret;
+}
+
+static ssize_t i915_dsc_bpp_support_write(struct file *file,
+ const char __user *ubuf,
+ size_t len, loff_t *offp)
+{
+ int dsc_bpp = 0;
+ int ret;
+ struct drm_connector *connector =
+ ((struct seq_file *)file->private_data)->private;
+ struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
+ struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+
+ if (len == 0)
+ return 0;
+
+ drm_dbg(&i915->drm,
+ "Copied %zu bytes from user to force BPP\n", len);
+
+ ret = kstrtoint_from_user(ubuf, len, 0, &dsc_bpp);
+
+ intel_dp->force_dsc_bpp = dsc_bpp;
+ if (ret < 0)
+ return ret;
+
+ *offp += len;
+ return len;
+}
+
+static int i915_dsc_bpp_support_open(struct inode *inode,
+ struct file *file)
+{
+ return single_open(file, i915_dsc_bpp_support_show,
+ inode->i_private);
+}
+
+static const struct file_operations i915_dsc_bpp_support_fops = {
+ .owner = THIS_MODULE,
+ .open = i915_dsc_bpp_support_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
+ .write = i915_dsc_bpp_support_write
+};
+
/**
* intel_connector_debugfs_add - add i915 specific connector debugfs files
* @connector: pointer to a registered drm_connector
@@ -2427,9 +2494,16 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
connector, &i915_hdcp_sink_capability_fops);
}
- if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) && ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort && !to_intel_connector(connector)->mst_port) || connector->connector_type == DRM_MODE_CONNECTOR_eDP))
+ if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) &&
+ ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
+ !to_intel_connector(connector)->mst_port) ||
+ connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
connector, &i915_dsc_fec_support_fops);
+ debugfs_create_file("i915_dsc_bpp_support", S_IRUGO,
+ root, connector,
+ &i915_dsc_bpp_support_fops);
+ }
/* Legacy panels doesn't lpsp on any platform */
if ((DISPLAY_VER(dev_priv) >= 9 || IS_HASWELL(dev_priv) ||
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index d94f361b548b7..19d8d3eefbc27 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1612,6 +1612,7 @@ struct intel_dp {
/* Display stream compression testing */
bool force_dsc_en;
+ int force_dsc_bpp;
bool hobl_failed;
bool hobl_active;
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] [v3 2/2] drm/i915/display/dsc: Set BPP in the kernel
2021-07-01 9:12 ` [Intel-gfx] [v3 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
@ 2021-07-01 9:12 ` venkata.sai.patnana
0 siblings, 0 replies; 19+ messages in thread
From: venkata.sai.patnana @ 2021-07-01 9:12 UTC (permalink / raw)
To: intel-gfx
From: Anusha Srivatsa <anusha.srivatsa@intel.com>
Set compress BPP in kernel while connector DP or eDP
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Navare Manasi D <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 23 ++++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 5b52beaddada0..4ce15da3e33ce 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1241,9 +1241,15 @@ static int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
pipe_config->lane_count = limits->max_lane_count;
if (intel_dp_is_edp(intel_dp)) {
- pipe_config->dsc.compressed_bpp =
- min_t(u16, drm_edp_dsc_sink_output_bpp(intel_dp->dsc_dpcd) >> 4,
- pipe_config->pipe_bpp);
+ if (intel_dp->force_dsc_bpp) {
+ drm_dbg_kms(&dev_priv->drm,
+ "DSC BPP forced to %d", intel_dp->force_dsc_bpp);
+ pipe_config->dsc.compressed_bpp = intel_dp->force_dsc_bpp;
+ } else {
+ pipe_config->dsc.compressed_bpp =
+ min_t(u16, drm_edp_dsc_sink_output_bpp(intel_dp->dsc_dpcd) >> 4,
+ pipe_config->pipe_bpp);
+ }
pipe_config->dsc.slice_count =
drm_dp_dsc_sink_max_slice_count(intel_dp->dsc_dpcd,
true);
@@ -1269,9 +1275,15 @@ static int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
"Compressed BPP/Slice Count not supported\n");
return -EINVAL;
}
- pipe_config->dsc.compressed_bpp = min_t(u16,
+ if (intel_dp->force_dsc_bpp) {
+ drm_dbg_kms(&dev_priv->drm,
+ "DSC BPP forced to %d\n", intel_dp->force_dsc_bpp);
+ pipe_config->dsc.compressed_bpp = intel_dp->force_dsc_bpp;
+ } else {
+ pipe_config->dsc.compressed_bpp = min_t(u16,
dsc_max_output_bpp >> 4,
pipe_config->pipe_bpp);
+ }
pipe_config->dsc.slice_count = dsc_dp_slice_count;
}
/*
@@ -1374,7 +1386,8 @@ intel_dp_compute_link_config(struct intel_encoder *encoder,
* Pipe joiner needs compression upto display12 due to BW limitation. DG2
* onwards pipe joiner can be enabled without compression.
*/
- drm_dbg_kms(&i915->drm, "Force DSC en = %d\n", intel_dp->force_dsc_en);
+ drm_dbg_kms(&i915->drm, "Force DSC en = %d\n Force DSC BPP = %d\n",
+ intel_dp->force_dsc_en, intel_dp->force_dsc_bpp);
if (ret || intel_dp->force_dsc_en || (DISPLAY_VER(i915) < 13 &&
pipe_config->bigjoiner)) {
ret = intel_dp_dsc_compute_config(intel_dp, pipe_config,
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] [v3 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
2021-06-29 6:51 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
2021-06-29 14:35 ` Jani Nikula
@ 2021-07-01 9:16 ` venkata.sai.patnana
1 sibling, 0 replies; 19+ messages in thread
From: venkata.sai.patnana @ 2021-07-01 9:16 UTC (permalink / raw)
To: intel-gfx
From: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
[What]:
This patch creates a per connector debugfs node to expose
the Input and Compressed BPP.
The same node can be used from userspace to force
DSC to a certain BPP(all accepted values).
[Why]:
Useful to verify all supported/requested compression bpp's
through IGT
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Navare Manasi D <manasi.d.navare@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
---
.../drm/i915/display/intel_display_debugfs.c | 76 ++++++++++++++++++-
.../drm/i915/display/intel_display_types.h | 1 +
2 files changed, 76 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index af9e58619667d..2305a0c2498cc 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -2389,6 +2389,73 @@ static const struct file_operations i915_dsc_fec_support_fops = {
.write = i915_dsc_fec_support_write
};
+static int i915_dsc_bpp_support_show(struct seq_file *m, void *data)
+{
+ struct drm_connector *connector = m->private;
+ struct drm_device *dev = connector->dev;
+ struct drm_crtc *crtc;
+ struct intel_crtc_state *crtc_state = NULL;
+ int ret = 0;
+
+ ret = drm_modeset_lock_single_interruptible(&dev->mode_config.connection_mutex);
+ if (ret)
+ return ret;
+
+ crtc = connector->state->crtc;
+ crtc_state = to_intel_crtc_state(crtc->state);
+ seq_printf(m, "Input_BPP: %d\n", crtc_state->pipe_bpp);
+ seq_printf(m, "Compressed_BPP: %d\n",
+ crtc_state->dsc.compressed_bpp);
+
+ drm_modeset_unlock(&dev->mode_config.connection_mutex);
+
+ return ret;
+}
+
+static ssize_t i915_dsc_bpp_support_write(struct file *file,
+ const char __user *ubuf,
+ size_t len, loff_t *offp)
+{
+ int dsc_bpp = 0;
+ int ret;
+ struct drm_connector *connector =
+ ((struct seq_file *)file->private_data)->private;
+ struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
+ struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+
+ if (len == 0)
+ return 0;
+
+ drm_dbg(&i915->drm,
+ "Copied %zu bytes from user to force BPP\n", len);
+
+ ret = kstrtoint_from_user(ubuf, len, 0, &dsc_bpp);
+
+ intel_dp->force_dsc_bpp = dsc_bpp;
+ if (ret < 0)
+ return ret;
+
+ *offp += len;
+ return len;
+}
+
+static int i915_dsc_bpp_support_open(struct inode *inode,
+ struct file *file)
+{
+ return single_open(file, i915_dsc_bpp_support_show,
+ inode->i_private);
+}
+
+static const struct file_operations i915_dsc_bpp_support_fops = {
+ .owner = THIS_MODULE,
+ .open = i915_dsc_bpp_support_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
+ .write = i915_dsc_bpp_support_write
+};
+
/**
* intel_connector_debugfs_add - add i915 specific connector debugfs files
* @connector: pointer to a registered drm_connector
@@ -2427,9 +2494,16 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
connector, &i915_hdcp_sink_capability_fops);
}
- if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) && ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort && !to_intel_connector(connector)->mst_port) || connector->connector_type == DRM_MODE_CONNECTOR_eDP))
+ if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) &&
+ ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
+ !to_intel_connector(connector)->mst_port) ||
+ connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
connector, &i915_dsc_fec_support_fops);
+ debugfs_create_file("i915_dsc_bpp_support", S_IRUGO,
+ root, connector,
+ &i915_dsc_bpp_support_fops);
+ }
/* Legacy panels doesn't lpsp on any platform */
if ((DISPLAY_VER(dev_priv) >= 9 || IS_HASWELL(dev_priv) ||
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index d94f361b548b7..19d8d3eefbc27 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1612,6 +1612,7 @@ struct intel_dp {
/* Display stream compression testing */
bool force_dsc_en;
+ int force_dsc_bpp;
bool hobl_failed;
bool hobl_active;
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] [v4 0/2] drm/i915/display/dsc: Set BPP in the kernel
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
` (6 preceding siblings ...)
2021-07-01 9:12 ` [Intel-gfx] [v3 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
@ 2021-07-01 10:00 ` venkata.sai.patnana
2021-07-01 10:00 ` [Intel-gfx] [v4 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
2021-07-01 10:00 ` [Intel-gfx] [v4 2/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
2021-07-01 10:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dsc: Set BPP in the kernel (rev4) Patchwork
` (2 subsequent siblings)
10 siblings, 2 replies; 19+ messages in thread
From: venkata.sai.patnana @ 2021-07-01 10:00 UTC (permalink / raw)
To: intel-gfx
From: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
DSC can be supported per DP connector. This patch creates
a per connector debugfs node to expose the Input and
Compressed BPP.
The same node can be used from userspace to force
DSC to a certain BPP.
force_dsc_bpp is written through this debugfs
node to force DSC BPP to all accepted values
Test-with: <20210622102454.8922-1-venkata.sai.patnana@intel.com>
Anusha Srivatsa (1):
drm/i915/display/dsc: Set BPP in the kernel
Patnana Venkata Sai (1):
drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP
enable
.../drm/i915/display/intel_display_debugfs.c | 74 ++++++++++++++++++-
.../drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 23 ++++--
3 files changed, 92 insertions(+), 6 deletions(-)
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] [v4 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
2021-07-01 10:00 ` [Intel-gfx] [v4 0/2] " venkata.sai.patnana
@ 2021-07-01 10:00 ` venkata.sai.patnana
2021-07-01 10:00 ` [Intel-gfx] [v4 2/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
1 sibling, 0 replies; 19+ messages in thread
From: venkata.sai.patnana @ 2021-07-01 10:00 UTC (permalink / raw)
To: intel-gfx
From: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
[What]:
This patch creates a per connector debugfs node to expose
the Input and Compressed BPP.
The same node can be used from userspace to force
DSC to a certain BPP(all accepted values).
[Why]:
Useful to verify all supported/requested compression bpp's
through IGT
v2: Remove unnecessary logic & update commit message
with in detail(Jani)
v3: Drop pipe bpp in debugfs node (Vandita)
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Navare Manasi D <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
---
.../drm/i915/display/intel_display_debugfs.c | 74 ++++++++++++++++++-
.../drm/i915/display/intel_display_types.h | 1 +
2 files changed, 74 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index af9e58619667d..619667ad15fa0 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -2389,6 +2389,71 @@ static const struct file_operations i915_dsc_fec_support_fops = {
.write = i915_dsc_fec_support_write
};
+static int i915_dsc_bpp_support_show(struct seq_file *m, void *data)
+{
+ struct drm_connector *connector = m->private;
+ struct drm_device *dev = connector->dev;
+ struct drm_crtc *crtc;
+ struct intel_crtc_state *crtc_state = NULL;
+ int ret = 0;
+
+ ret = drm_modeset_lock_single_interruptible(&dev->mode_config.connection_mutex);
+ if (ret)
+ return ret;
+
+ crtc = connector->state->crtc;
+ crtc_state = to_intel_crtc_state(crtc->state);
+ seq_printf(m, "Compressed_BPP: %d\n", crtc_state->dsc.compressed_bpp);
+
+ drm_modeset_unlock(&dev->mode_config.connection_mutex);
+
+ return ret;
+}
+
+static ssize_t i915_dsc_bpp_support_write(struct file *file,
+ const char __user *ubuf,
+ size_t len, loff_t *offp)
+{
+ int dsc_bpp = 0;
+ int ret;
+ struct drm_connector *connector =
+ ((struct seq_file *)file->private_data)->private;
+ struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
+ struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+
+ if (len == 0)
+ return 0;
+
+ drm_dbg(&i915->drm,
+ "Copied %zu bytes from user to force BPP\n", len);
+
+ ret = kstrtoint_from_user(ubuf, len, 0, &dsc_bpp);
+
+ intel_dp->force_dsc_bpp = dsc_bpp;
+ if (ret < 0)
+ return ret;
+
+ *offp += len;
+ return len;
+}
+
+static int i915_dsc_bpp_support_open(struct inode *inode,
+ struct file *file)
+{
+ return single_open(file, i915_dsc_bpp_support_show,
+ inode->i_private);
+}
+
+static const struct file_operations i915_dsc_bpp_support_fops = {
+ .owner = THIS_MODULE,
+ .open = i915_dsc_bpp_support_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
+ .write = i915_dsc_bpp_support_write
+};
+
/**
* intel_connector_debugfs_add - add i915 specific connector debugfs files
* @connector: pointer to a registered drm_connector
@@ -2427,9 +2492,16 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
connector, &i915_hdcp_sink_capability_fops);
}
- if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) && ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort && !to_intel_connector(connector)->mst_port) || connector->connector_type == DRM_MODE_CONNECTOR_eDP))
+ if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) &&
+ ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
+ !to_intel_connector(connector)->mst_port) ||
+ connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
connector, &i915_dsc_fec_support_fops);
+ debugfs_create_file("i915_dsc_bpp_support", S_IRUGO,
+ root, connector,
+ &i915_dsc_bpp_support_fops);
+ }
/* Legacy panels doesn't lpsp on any platform */
if ((DISPLAY_VER(dev_priv) >= 9 || IS_HASWELL(dev_priv) ||
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index d94f361b548b7..19d8d3eefbc27 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1612,6 +1612,7 @@ struct intel_dp {
/* Display stream compression testing */
bool force_dsc_en;
+ int force_dsc_bpp;
bool hobl_failed;
bool hobl_active;
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] [v4 2/2] drm/i915/display/dsc: Set BPP in the kernel
2021-07-01 10:00 ` [Intel-gfx] [v4 0/2] " venkata.sai.patnana
2021-07-01 10:00 ` [Intel-gfx] [v4 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
@ 2021-07-01 10:00 ` venkata.sai.patnana
1 sibling, 0 replies; 19+ messages in thread
From: venkata.sai.patnana @ 2021-07-01 10:00 UTC (permalink / raw)
To: intel-gfx
From: Anusha Srivatsa <anusha.srivatsa@intel.com>
Set compress BPP in kernel while connector DP or eDP
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Navare Manasi D <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 23 ++++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 5b52beaddada0..4ce15da3e33ce 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1241,9 +1241,15 @@ static int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
pipe_config->lane_count = limits->max_lane_count;
if (intel_dp_is_edp(intel_dp)) {
- pipe_config->dsc.compressed_bpp =
- min_t(u16, drm_edp_dsc_sink_output_bpp(intel_dp->dsc_dpcd) >> 4,
- pipe_config->pipe_bpp);
+ if (intel_dp->force_dsc_bpp) {
+ drm_dbg_kms(&dev_priv->drm,
+ "DSC BPP forced to %d", intel_dp->force_dsc_bpp);
+ pipe_config->dsc.compressed_bpp = intel_dp->force_dsc_bpp;
+ } else {
+ pipe_config->dsc.compressed_bpp =
+ min_t(u16, drm_edp_dsc_sink_output_bpp(intel_dp->dsc_dpcd) >> 4,
+ pipe_config->pipe_bpp);
+ }
pipe_config->dsc.slice_count =
drm_dp_dsc_sink_max_slice_count(intel_dp->dsc_dpcd,
true);
@@ -1269,9 +1275,15 @@ static int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
"Compressed BPP/Slice Count not supported\n");
return -EINVAL;
}
- pipe_config->dsc.compressed_bpp = min_t(u16,
+ if (intel_dp->force_dsc_bpp) {
+ drm_dbg_kms(&dev_priv->drm,
+ "DSC BPP forced to %d\n", intel_dp->force_dsc_bpp);
+ pipe_config->dsc.compressed_bpp = intel_dp->force_dsc_bpp;
+ } else {
+ pipe_config->dsc.compressed_bpp = min_t(u16,
dsc_max_output_bpp >> 4,
pipe_config->pipe_bpp);
+ }
pipe_config->dsc.slice_count = dsc_dp_slice_count;
}
/*
@@ -1374,7 +1386,8 @@ intel_dp_compute_link_config(struct intel_encoder *encoder,
* Pipe joiner needs compression upto display12 due to BW limitation. DG2
* onwards pipe joiner can be enabled without compression.
*/
- drm_dbg_kms(&i915->drm, "Force DSC en = %d\n", intel_dp->force_dsc_en);
+ drm_dbg_kms(&i915->drm, "Force DSC en = %d\n Force DSC BPP = %d\n",
+ intel_dp->force_dsc_en, intel_dp->force_dsc_bpp);
if (ret || intel_dp->force_dsc_en || (DISPLAY_VER(i915) < 13 &&
pipe_config->bigjoiner)) {
ret = intel_dp_dsc_compute_config(intel_dp, pipe_config,
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dsc: Set BPP in the kernel (rev4)
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
` (7 preceding siblings ...)
2021-07-01 10:00 ` [Intel-gfx] [v4 0/2] " venkata.sai.patnana
@ 2021-07-01 10:52 ` Patchwork
2021-07-01 10:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-07-01 11:23 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2021-07-01 10:52 UTC (permalink / raw)
To: venkata.sai.patnana; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display/dsc: Set BPP in the kernel (rev4)
URL : https://patchwork.freedesktop.org/series/91917/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e4fb01832beb drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2408:
+ seq_printf(m, "Compressed_BPP: %d\n",
+ crtc_state->dsc.compressed_bpp);
-:56: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#56: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2416:
+static ssize_t i915_dsc_bpp_support_write(struct file *file,
+ const char __user *ubuf,
-:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#84: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2444:
+static int i915_dsc_bpp_support_open(struct inode *inode,
+ struct file *file)
-:113: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#113: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2503:
+ debugfs_create_file("i915_dsc_bpp_support", S_IRUGO,
total: 0 errors, 1 warnings, 3 checks, 97 lines checked
f9001417c3a0 drm/i915/display/dsc: Set BPP in the kernel
-:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#26: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1246:
+ drm_dbg_kms(&dev_priv->drm,
+ "DSC BPP forced to %d", intel_dp->force_dsc_bpp);
-:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#31: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1251:
+ min_t(u16, drm_edp_dsc_sink_output_bpp(intel_dp->dsc_dpcd) >> 4,
+ pipe_config->pipe_bpp);
-:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#47: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1284:
+ pipe_config->dsc.compressed_bpp = min_t(u16,
dsc_max_output_bpp >> 4,
total: 0 errors, 0 warnings, 3 checks, 43 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display/dsc: Set BPP in the kernel (rev4)
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
` (8 preceding siblings ...)
2021-07-01 10:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dsc: Set BPP in the kernel (rev4) Patchwork
@ 2021-07-01 10:53 ` Patchwork
2021-07-01 11:23 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2021-07-01 10:53 UTC (permalink / raw)
To: venkata.sai.patnana; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display/dsc: Set BPP in the kernel (rev4)
URL : https://patchwork.freedesktop.org/series/91917/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_display.c:1896:21: expected struct i915_vma *[assigned] vma
+drivers/gpu/drm/i915/display/intel_display.c:1896:21: got void [noderef] __iomem *[assigned] iomem
+drivers/gpu/drm/i915/display/intel_display.c:1896:21: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_reset.c:1396:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block
+./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080)
+./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080)
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/dsc: Set BPP in the kernel (rev4)
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
` (9 preceding siblings ...)
2021-07-01 10:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2021-07-01 11:23 ` Patchwork
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2021-07-01 11:23 UTC (permalink / raw)
To: venkata.sai.patnana; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5483 bytes --]
== Series Details ==
Series: drm/i915/display/dsc: Set BPP in the kernel (rev4)
URL : https://patchwork.freedesktop.org/series/91917/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10297 -> Patchwork_20504
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20504 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20504, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20504:
### IGT changes ###
#### Possible regressions ####
* igt@debugfs_test@read_all_entries:
- fi-icl-y: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10297/fi-icl-y/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/fi-icl-y/igt@debugfs_test@read_all_entries.html
#### Warnings ####
* igt@debugfs_test@read_all_entries:
- fi-icl-u2: [{ABORT}][3] ([i915#1814]) -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10297/fi-icl-u2/igt@debugfs_test@read_all_entries.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/fi-icl-u2/igt@debugfs_test@read_all_entries.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@debugfs_test@read_all_entries:
- {fi-ehl-2}: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10297/fi-ehl-2/igt@debugfs_test@read_all_entries.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/fi-ehl-2/igt@debugfs_test@read_all_entries.html
- {fi-tgl-dsi}: [PASS][7] -> [INCOMPLETE][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10297/fi-tgl-dsi/igt@debugfs_test@read_all_entries.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/fi-tgl-dsi/igt@debugfs_test@read_all_entries.html
- {fi-tgl-1115g4}: [PASS][9] -> [INCOMPLETE][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10297/fi-tgl-1115g4/igt@debugfs_test@read_all_entries.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/fi-tgl-1115g4/igt@debugfs_test@read_all_entries.html
- {fi-jsl-1}: [PASS][11] -> [INCOMPLETE][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10297/fi-jsl-1/igt@debugfs_test@read_all_entries.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/fi-jsl-1/igt@debugfs_test@read_all_entries.html
* igt@runner@aborted:
- {fi-ehl-2}: NOTRUN -> [FAIL][13]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/fi-ehl-2/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_20504 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][14] -> [FAIL][15] ([i915#1372])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10297/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
* igt@runner@aborted:
- fi-icl-y: NOTRUN -> [FAIL][16] ([i915#1814])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/fi-icl-y/igt@runner@aborted.html
#### Warnings ####
* igt@runner@aborted:
- fi-icl-u2: [FAIL][17] ([i915#1814] / [i915#3363]) -> [FAIL][18] ([i915#1814] / [i915#2722] / [i915#3363])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10297/fi-icl-u2/igt@runner@aborted.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/fi-icl-u2/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3717]: https://gitlab.freedesktop.org/drm/intel/issues/3717
Participating hosts (37 -> 35)
------------------------------
Missing (2): fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_6125 -> IGTPW_5971
* Linux: CI_DRM_10297 -> Patchwork_20504
CI-20190529: 20190529
CI_DRM_10297: 96c7ad60de68518bdcd0d0e6381a2359034a0226 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5971: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5971/index.html
IGT_6125: 5bb62cb290fa32777934de4b39e107ccd282f7e8 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20504: f9001417c3a09b3bfc2edcddcc8c2fcdc25ea3f5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f9001417c3a0 drm/i915/display/dsc: Set BPP in the kernel
e4fb01832beb drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20504/index.html
[-- Attachment #1.2: Type: text/html, Size: 6548 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2021-07-01 11:23 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29 6:51 [Intel-gfx] [PATCH v2 0/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
2021-06-29 6:51 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
2021-06-29 14:35 ` Jani Nikula
2021-06-30 6:29 ` Patnana, Venkata Sai
2021-06-30 13:24 ` Patnana, Venkata Sai
2021-07-01 9:16 ` [Intel-gfx] [v3 " venkata.sai.patnana
2021-06-29 6:51 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
2021-06-29 7:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dsc: Set BPP in the kernel (rev2) Patchwork
2021-06-29 7:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-06-29 7:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-06-29 9:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-01 9:12 ` [Intel-gfx] [v3 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
2021-07-01 9:12 ` [Intel-gfx] [v3 2/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
2021-07-01 10:00 ` [Intel-gfx] [v4 0/2] " venkata.sai.patnana
2021-07-01 10:00 ` [Intel-gfx] [v4 1/2] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable venkata.sai.patnana
2021-07-01 10:00 ` [Intel-gfx] [v4 2/2] drm/i915/display/dsc: Set BPP in the kernel venkata.sai.patnana
2021-07-01 10:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dsc: Set BPP in the kernel (rev4) Patchwork
2021-07-01 10:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-07-01 11:23 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).