From: Melissa Wen <mwen@igalia.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v4 00/18] drm/sched dependency tracking and dma-resv fixes
Date: Tue, 27 Jul 2021 15:47:09 +0100 [thread overview]
Message-ID: <20210727144709.j5cpmtzo2x2m2a2o@mail.igalia.com> (raw)
In-Reply-To: <20210712175352.802687-1-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 3685 bytes --]
On 07/12, Daniel Vetter wrote:
> Hi all,
>
> Quick new version since the previous one was a bit too broken:
> - dropped the bug-on patch to avoid breaking amdgpu's gpu reset failure
> games
> - another attempt at splitting job_init/arm, hopefully we're getting
> there.
>
> Note that Christian has brought up a bikeshed on the new functions to add
> dependencies to drm_sched_jobs. I'm happy to repaint, if there's some kind
> of consensus on what it should be.
>
> Testing and review very much welcome, as usual.
Hi,
I've tested it some time ago; but now, for v3d, don't forget to rebase.
Also, common parts lgtm, so for them:
Acked-by: Melissa Wen <mwen@igalia.com>
>
> Cheers, Daniel
>
> Daniel Vetter (18):
> drm/sched: Split drm_sched_job_init
> drm/sched: Barriers are needed for entity->last_scheduled
> drm/sched: Add dependency tracking
> drm/sched: drop entity parameter from drm_sched_push_job
> drm/sched: improve docs around drm_sched_entity
> drm/panfrost: use scheduler dependency tracking
> drm/lima: use scheduler dependency tracking
> drm/v3d: Move drm_sched_job_init to v3d_job_init
> drm/v3d: Use scheduler dependency handling
> drm/etnaviv: Use scheduler dependency handling
> drm/gem: Delete gem array fencing helpers
> drm/sched: Don't store self-dependencies
> drm/sched: Check locking in drm_sched_job_await_implicit
> drm/msm: Don't break exclusive fence ordering
> drm/etnaviv: Don't break exclusive fence ordering
> drm/i915: delete exclude argument from i915_sw_fence_await_reservation
> drm/i915: Don't break exclusive fence ordering
> dma-resv: Give the docs a do-over
>
> Documentation/gpu/drm-mm.rst | 3 +
> drivers/dma-buf/dma-resv.c | 24 ++-
> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 4 +-
> drivers/gpu/drm/drm_gem.c | 96 ---------
> drivers/gpu/drm/etnaviv/etnaviv_gem.h | 5 +-
> drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 64 +++---
> drivers/gpu/drm/etnaviv/etnaviv_sched.c | 65 +-----
> drivers/gpu/drm/etnaviv/etnaviv_sched.h | 3 +-
> drivers/gpu/drm/i915/display/intel_display.c | 4 +-
> drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 2 +-
> .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 8 +-
> drivers/gpu/drm/i915/i915_sw_fence.c | 6 +-
> drivers/gpu/drm/i915/i915_sw_fence.h | 1 -
> drivers/gpu/drm/lima/lima_gem.c | 7 +-
> drivers/gpu/drm/lima/lima_sched.c | 28 +--
> drivers/gpu/drm/lima/lima_sched.h | 6 +-
> drivers/gpu/drm/msm/msm_gem_submit.c | 3 +-
> drivers/gpu/drm/panfrost/panfrost_drv.c | 16 +-
> drivers/gpu/drm/panfrost/panfrost_job.c | 39 +---
> drivers/gpu/drm/panfrost/panfrost_job.h | 5 +-
> drivers/gpu/drm/scheduler/sched_entity.c | 140 +++++++------
> drivers/gpu/drm/scheduler/sched_fence.c | 19 +-
> drivers/gpu/drm/scheduler/sched_main.c | 181 +++++++++++++++--
> drivers/gpu/drm/v3d/v3d_drv.h | 6 +-
> drivers/gpu/drm/v3d/v3d_gem.c | 115 +++++------
> drivers/gpu/drm/v3d/v3d_sched.c | 44 +----
> include/drm/drm_gem.h | 5 -
> include/drm/gpu_scheduler.h | 186 ++++++++++++++----
> include/linux/dma-buf.h | 7 +
> include/linux/dma-resv.h | 104 +++++++++-
> 31 files changed, 672 insertions(+), 528 deletions(-)
>
> --
> 2.32.0
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-07-27 14:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 17:53 [Intel-gfx] [PATCH v4 00/18] drm/sched dependency tracking and dma-resv fixes Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 01/18] drm/sched: Split drm_sched_job_init Daniel Vetter
2021-07-12 20:22 ` Emma Anholt
2021-07-13 6:40 ` Christian König
2021-07-13 6:53 ` Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 02/18] drm/sched: Barriers are needed for entity->last_scheduled Daniel Vetter
2021-07-13 6:35 ` Christian König
2021-07-13 6:50 ` Daniel Vetter
2021-07-13 7:25 ` Christian König
2021-07-13 9:10 ` Daniel Vetter
2021-07-13 11:20 ` Christian König
2021-07-13 16:11 ` Andrey Grodzovsky
2021-07-13 16:45 ` Daniel Vetter
2021-07-14 22:12 ` Andrey Grodzovsky
2021-07-15 10:16 ` Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 03/18] drm/sched: Add dependency tracking Daniel Vetter
2021-07-27 11:09 ` Daniel Vetter
2021-07-28 11:28 ` [Intel-gfx] [Linaro-mm-sig] " Christian König
2021-07-28 12:09 ` Daniel Vetter
2021-07-28 12:46 ` Christian König
2021-07-28 15:20 ` Melissa Wen
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 04/18] drm/sched: drop entity parameter from drm_sched_push_job Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 05/18] drm/sched: improve docs around drm_sched_entity Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 06/18] drm/panfrost: use scheduler dependency tracking Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 07/18] drm/lima: " Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 08/18] drm/v3d: Move drm_sched_job_init to v3d_job_init Daniel Vetter
2021-07-14 9:34 ` Melissa Wen
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 09/18] drm/v3d: Use scheduler dependency handling Daniel Vetter
2021-07-14 9:37 ` Melissa Wen
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 10/18] drm/etnaviv: " Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 11/18] drm/gem: Delete gem array fencing helpers Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 12/18] drm/sched: Don't store self-dependencies Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 13/18] drm/sched: Check locking in drm_sched_job_await_implicit Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 14/18] drm/msm: Don't break exclusive fence ordering Daniel Vetter
2021-07-13 16:55 ` Rob Clark
2021-07-13 16:58 ` Daniel Vetter
2021-07-13 17:46 ` Rob Clark
2021-07-13 17:45 ` Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 15/18] drm/etnaviv: " Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 16/18] drm/i915: delete exclude argument from i915_sw_fence_await_reservation Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 17/18] drm/i915: Don't break exclusive fence ordering Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 18/18] dma-resv: Give the docs a do-over Daniel Vetter
2021-07-12 20:47 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/sched dependency tracking and dma-resv fixes (rev3) Patchwork
2021-07-12 21:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-12 23:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-27 11:51 ` [Intel-gfx] [PATCH v4 00/18] drm/sched dependency tracking and dma-resv fixes Boris Brezillon
2021-07-27 14:47 ` Melissa Wen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727144709.j5cpmtzo2x2m2a2o@mail.igalia.com \
--to=mwen@igalia.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).