Re: [Intel-gfx] [PATCH v4 01/18] drm/sched: Split drm_sched_job_init

From: Emma Anholt <emma@anholt.net>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Adam Borowski" <kilobyte@angband.pl>,
	"David Airlie" <airlied@linux.ie>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"DRI Development" <dri-devel@lists.freedesktop.org>,
	"Melissa Wen" <melissa.srw@gmail.com>,
	"Nirmoy Das" <nirmoy.das@amd.com>,
	"Daniel Vetter" <daniel.vetter@intel.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	lima@lists.freedesktop.org,
	"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Steven Price" <steven.price@arm.com>,
	"Luben Tuikov" <luben.tuikov@amd.com>,
	"Alyssa Rosenzweig" <alyssa.rosenzweig@collabora.com>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Russell King" <linux+etnaviv@armlinux.org.uk>,
	"Dave Airlie" <airlied@redhat.com>,
	"Marek Olšák" <marek.olsak@amd.com>,
	"Dennis Li" <Dennis.Li@amd.com>, "Chen Li" <chenli@uniontech.com>,
	"Paul Menzel" <pmenzel@molgen.mpg.de>,
	"Kees Cook" <keescook@chromium.org>,
	"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
	"Kevin Wang" <kevin1.wang@amd.com>,
	etnaviv@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
	"Christian Gmeiner" <christian.gmeiner@gmail.com>,
	"Andrey Grodzovsky" <andrey.grodzovsky@amd.com>,
	"Sonny Jiang" <sonny.jiang@amd.com>,
	"Deepak R Varma" <mh12gx2825@gmail.com>,
	"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
	"Nick Terrell" <terrelln@fb.com>, "Qiang Yu" <yuq825@gmail.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Tian Tao" <tiantao6@hisilicon.com>,
	linux-media@vger.kernel.org,
	"Christian König" <christian.koenig@amd.com>,
	"Lucas Stach" <l.stach@pengutronix.de>
Subject: Re: [Intel-gfx] [PATCH v4 01/18] drm/sched: Split drm_sched_job_init
Date: Mon, 12 Jul 2021 13:22:39 -0700	[thread overview]
Message-ID: <CADaigPXPpiEfMOZ+h=H6e_brdK-1n0Aax34oWTaiJaDjM=EsfA@mail.gmail.com> (raw)
In-Reply-To: <20210712175352.802687-2-daniel.vetter@ffwll.ch>

On Mon, Jul 12, 2021 at 1:01 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
> This is a very confusingly named function, because not just does it
> init an object, it arms it and provides a point of no return for
> pushing a job into the scheduler. It would be nice if that's a bit
> clearer in the interface.
>
> But the real reason is that I want to push the dependency tracking
> helpers into the scheduler code, and that means drm_sched_job_init
> must be called a lot earlier, without arming the job.
>
> v2:
> - don't change .gitignore (Steven)
> - don't forget v3d (Emma)
>
> v3: Emma noticed that I leak the memory allocated in
> drm_sched_job_init if we bail out before the point of no return in
> subsequent driver patches. To be able to fix this change
> drm_sched_job_cleanup() so it can handle being called both before and
> after drm_sched_job_arm().
>
> Also improve the kerneldoc for this.
>
> v4:
> - Fix the drm_sched_job_cleanup logic, I inverted the booleans, as
>   usual (Melissa)
>
> - Christian pointed out that drm_sched_entity_select_rq() also needs
>   to be moved into drm_sched_job_arm, which made me realize that the
>   job->id definitely needs to be moved too.
>
>   Shuffle things to fit between job_init and job_arm.
>
> v5:
> Reshuffle the split between init/arm once more, amdgpu abuses
> drm_sched.ready to signal gpu reset failures. Also document this
> somewhat. (Christian)

Ack from me for the changes I was Cced on.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx