Re: [Intel-gfx] [PATCH 15/27] drm/i915/guc: Implement multi-lrc submission

From: kernel test robot <lkp@intel.com>
To: Matthew Brost <matthew.brost@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
	daniel.vetter@ffwll.ch, tony.ye@intel.com, zhengguo.xu@intel.com
Subject: Re: [Intel-gfx] [PATCH 15/27] drm/i915/guc: Implement multi-lrc submission
Date: Sat, 21 Aug 2021 22:04:11 +0800	[thread overview]
Message-ID: <202108212132.fYWbEn5Q-lkp@intel.com> (raw)
In-Reply-To: <20210820224446.30620-16-matthew.brost@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2755 bytes --]

Hi Matthew,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip next-20210820]
[cannot apply to drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.14-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20210821-065348
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-buildonly-randconfig-r002-20210821 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9e9d70591e72fc6762b4b9a226b68ed1307419bf)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/55917f6ee7575ffb033e6b19a9eb38c3210e14db
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20210821-065348
        git checkout 55917f6ee7575ffb033e6b19a9eb38c3210e14db
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:1467:6: warning: no previous prototype for function 'need_tasklet' [-Wmissing-prototypes]
   bool need_tasklet(struct intel_guc *guc, struct i915_request *rq)
        ^
   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:1467:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   bool need_tasklet(struct intel_guc *guc, struct i915_request *rq)
   ^
   static 
   1 warning generated.

vim +/need_tasklet +1467 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

  1466	
> 1467	bool need_tasklet(struct intel_guc *guc, struct i915_request *rq)
  1468	{
  1469		struct i915_sched_engine *sched_engine = rq->engine->sched_engine;
  1470		struct intel_context *ce = request_to_scheduling_context(rq);
  1471	
  1472		return submission_disabled(guc) || guc->stalled_request ||
  1473			!i915_sched_engine_is_empty(sched_engine) ||
  1474			!lrc_desc_registered(guc, ce->guc_id.id);
  1475	}
  1476	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39742 bytes --]