* [Intel-gfx] [PATCH v2] drm/i915: Flush buffer pools on driver remove
@ 2021-09-24 16:38 Janusz Krzysztofik
2021-09-24 21:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Flush buffer pools on driver remove (rev4) Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Janusz Krzysztofik @ 2021-09-24 16:38 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel, Chris Wilson, Matt Roper, Janusz Krzysztofik
We currently do an explicit flush of the buffer pools within the call path
of drm_driver.release(); this removes all buffers, regardless of their age,
freeing the buffers' associated resources (objects, adress space areas).
However there is other code that runs within the drm_driver.release() call
chain that expects objects and their associated address space areas have
already been flushed.
Since buffer pools auto-flush old buffers once per second in a worker
thread, there's a small window where if we remove the driver while there
are still objects in buffers with an age of less than one second, the
assumptions of the other release code may be violated.
By moving the flush to driver remove (which executes earlier via the
pci_driver.remove() flow) we're ensuring that all buffers are flushed and
their associated objects freed before some other code in
pci_driver.remove() flushes those objects so they are released before
_any_ code in drm_driver.release() that check completness of those
flushes executes.
v2: Reword commit descriptiom as suggested by Matt.
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++
drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
index 4037c3778225..5b3acf2b064e 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt.c
@@ -741,6 +741,8 @@ void intel_gt_driver_remove(struct intel_gt *gt)
intel_uc_driver_remove(>->uc);
intel_engines_release(gt);
+
+ intel_gt_flush_buffer_pool(gt);
}
void intel_gt_driver_unregister(struct intel_gt *gt)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c b/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
index aa0a59c5b614..acc49c56a9f3 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
@@ -245,8 +245,6 @@ void intel_gt_fini_buffer_pool(struct intel_gt *gt)
struct intel_gt_buffer_pool *pool = >->buffer_pool;
int n;
- intel_gt_flush_buffer_pool(gt);
-
for (n = 0; n < ARRAY_SIZE(pool->cache_list); n++)
GEM_BUG_ON(!list_empty(&pool->cache_list[n]));
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Flush buffer pools on driver remove (rev4)
2021-09-24 16:38 [Intel-gfx] [PATCH v2] drm/i915: Flush buffer pools on driver remove Janusz Krzysztofik
@ 2021-09-24 21:30 ` Patchwork
2021-09-24 22:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2021-09-24 21:30 UTC (permalink / raw)
To: Janusz Krzysztofik; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Flush buffer pools on driver remove (rev4)
URL : https://patchwork.freedesktop.org/series/91177/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
80eda1143f5e drm/i915: Flush buffer pools on driver remove
-:8: WARNING:TYPO_SPELLING: 'adress' may be misspelled - perhaps 'address'?
#8:
freeing the buffers' associated resources (objects, adress space areas).
^^^^^^
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Flush buffer pools on driver remove (rev4)
2021-09-24 16:38 [Intel-gfx] [PATCH v2] drm/i915: Flush buffer pools on driver remove Janusz Krzysztofik
2021-09-24 21:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Flush buffer pools on driver remove (rev4) Patchwork
@ 2021-09-24 22:02 ` Patchwork
2021-09-25 1:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-09-25 2:58 ` [Intel-gfx] [PATCH v2] drm/i915: Flush buffer pools on driver remove Matt Roper
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2021-09-24 22:02 UTC (permalink / raw)
To: Janusz Krzysztofik; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5233 bytes --]
== Series Details ==
Series: drm/i915: Flush buffer pools on driver remove (rev4)
URL : https://patchwork.freedesktop.org/series/91177/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10642 -> Patchwork_21156
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/index.html
Known issues
------------
Here are the changes found in Patchwork_21156 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-rkl-guc: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/fi-rkl-guc/igt@amdgpu/amd_basic@cs-gfx.html
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][2] ([fdo#109271]) +27 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][3] ([i915#3718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][4] -> [INCOMPLETE][5] ([i915#2940])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][7] ([fdo#109271] / [i915#1436] / [i915#2722] / [i915#3428])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/fi-bsw-nick/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- {fi-tgl-dsi}: [DMESG-FAIL][8] ([i915#1993]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/fi-tgl-dsi/igt@i915_selftest@live@execlists.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/fi-tgl-dsi/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_timelines:
- fi-rkl-guc: [INCOMPLETE][10] ([i915#4034]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/fi-rkl-guc/igt@i915_selftest@live@gt_timelines.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/fi-rkl-guc/igt@i915_selftest@live@gt_timelines.html
* igt@kms_frontbuffer_tracking@basic:
- fi-rkl-guc: [SKIP][12] ([i915#3180]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/fi-rkl-guc/igt@kms_frontbuffer_tracking@basic.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/fi-rkl-guc/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-rkl-guc: [SKIP][14] ([i915#3919]) -> [PASS][15] +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/fi-rkl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/fi-rkl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1993]: https://gitlab.freedesktop.org/drm/intel/issues/1993
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3180]: https://gitlab.freedesktop.org/drm/intel/issues/3180
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718
[i915#3919]: https://gitlab.freedesktop.org/drm/intel/issues/3919
[i915#4034]: https://gitlab.freedesktop.org/drm/intel/issues/4034
Participating hosts (41 -> 34)
------------------------------
Missing (7): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-4 fi-bdw-samus bat-jsl-2 bat-jsl-1
Build changes
-------------
* Linux: CI_DRM_10642 -> Patchwork_21156
CI-20190529: 20190529
CI_DRM_10642: 2a3c613bd8e7f86660b9d61665569eeb0dfb1caf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6218: 8d4169d9543d8e5c01f0c746f603801a4d65ead0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21156: 80eda1143f5e534d896eb9504c6fd7e114e821ac @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
80eda1143f5e drm/i915: Flush buffer pools on driver remove
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/index.html
[-- Attachment #2: Type: text/html, Size: 6213 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Flush buffer pools on driver remove (rev4)
2021-09-24 16:38 [Intel-gfx] [PATCH v2] drm/i915: Flush buffer pools on driver remove Janusz Krzysztofik
2021-09-24 21:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Flush buffer pools on driver remove (rev4) Patchwork
2021-09-24 22:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-09-25 1:59 ` Patchwork
2021-09-25 2:58 ` [Intel-gfx] [PATCH v2] drm/i915: Flush buffer pools on driver remove Matt Roper
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2021-09-25 1:59 UTC (permalink / raw)
To: Janusz Krzysztofik; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30275 bytes --]
== Series Details ==
Series: drm/i915: Flush buffer pools on driver remove (rev4)
URL : https://patchwork.freedesktop.org/series/91177/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10642_full -> Patchwork_21156_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_21156_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-skl: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [FAIL][48], [PASS][49], [PASS][50]) ([i915#3174])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl9/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl9/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl8/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl8/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl8/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl6/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl5/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl5/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl4/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl4/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl4/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl3/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl3/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl2/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl2/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl2/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl1/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl1/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl10/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl10/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl9/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl9/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl8/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl8/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl7/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl6/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl6/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl6/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl5/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl5/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl4/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl3/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl3/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl3/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl2/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl2/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl1/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl1/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl1/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl10/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl10/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl10/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-tglb: NOTRUN -> [DMESG-WARN][51] ([i915#3002])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb2/igt@gem_create@create-massive.html
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-apl: [PASS][52] -> [DMESG-WARN][53] ([i915#180]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-apl2/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl6/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#1099]) +5 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-snb7/igt@gem_ctx_persistence@legacy-engines-mixed-process.html
* igt@gem_eio@unwedge-stress:
- shard-skl: [PASS][55] -> [TIMEOUT][56] ([i915#2369] / [i915#3063])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl6/igt@gem_eio@unwedge-stress.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl9/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][57] -> [FAIL][58] ([i915#2842])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][59] -> [FAIL][60] ([i915#2842]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-glk: [PASS][61] -> [FAIL][62] ([i915#2842]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-snb: NOTRUN -> [SKIP][63] ([fdo#109271]) +294 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-snb5/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#2190])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl2/igt@gem_huc_copy@huc-copy.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][65] ([i915#2724])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-snb2/igt@gem_userptr_blits@vma-merge.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#658])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb7/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][67] -> [FAIL][68] ([i915#454])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
* igt@i915_suspend@debugfs-reader:
- shard-kbl: NOTRUN -> [DMESG-WARN][69] ([i915#180])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl6/igt@i915_suspend@debugfs-reader.html
* igt@kms_big_fb@linear-8bpp-rotate-90:
- shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271]) +22 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl4/igt@kms_big_fb@linear-8bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-16bpp-rotate-0:
- shard-glk: [PASS][71] -> [DMESG-WARN][72] ([i915#118] / [i915#95]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-glk5/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-glk3/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#3777])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl1/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#3886])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl4/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#3886]) +7 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl7/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#3886]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl6/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][77] ([i915#3689] / [i915#3886])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb1/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#3689]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb2/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [fdo#111827]) +17 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl2/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
* igt@kms_chamelium@hdmi-hpd:
- shard-skl: NOTRUN -> [SKIP][80] ([fdo#109271] / [fdo#111827]) +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl4/igt@kms_chamelium@hdmi-hpd.html
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-snb: NOTRUN -> [SKIP][81] ([fdo#109271] / [fdo#111827]) +19 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-snb2/igt@kms_chamelium@vga-hpd-without-ddc.html
* igt@kms_color@pipe-a-ctm-0-25:
- shard-skl: [PASS][82] -> [DMESG-WARN][83] ([i915#1982])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl9/igt@kms_color@pipe-a-ctm-0-25.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl6/igt@kms_color@pipe-a-ctm-0-25.html
* igt@kms_content_protection@atomic-dpms:
- shard-kbl: NOTRUN -> [TIMEOUT][84] ([i915#1319])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl6/igt@kms_content_protection@atomic-dpms.html
* igt@kms_cursor_crc@pipe-b-cursor-512x170-onscreen:
- shard-tglb: NOTRUN -> [SKIP][85] ([fdo#109279] / [i915#3359]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb1/igt@kms_cursor_crc@pipe-b-cursor-512x170-onscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen:
- shard-kbl: NOTRUN -> [SKIP][86] ([fdo#109271]) +34 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl6/igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][87] -> [INCOMPLETE][88] ([i915#155] / [i915#180] / [i915#636])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile:
- shard-iclb: [PASS][89] -> [SKIP][90] ([i915#3701])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-iclb6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-apl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2672])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109280]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt:
- shard-tglb: NOTRUN -> [SKIP][93] ([fdo#111825]) +4 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#533]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][95] -> [DMESG-WARN][96] ([i915#180]) +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][97] ([fdo#108145] / [i915#265]) +3 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][98] -> [FAIL][99] ([fdo#108145] / [i915#265])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: NOTRUN -> [SKIP][100] ([i915#3536])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_plane_lowres@pipe-b-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][101] ([i915#3536]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb8/igt@kms_plane_lowres@pipe-b-tiling-none.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-apl: NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#658]) +5 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#2920])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][104] -> [SKIP][105] ([fdo#109441]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb5/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-tglb: [PASS][106] -> [INCOMPLETE][107] ([i915#456]) +2 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-tglb8/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb7/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-skl: [PASS][108] -> [INCOMPLETE][109] ([i915#146] / [i915#198])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl9/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl6/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-d-wait-forked-hang:
- shard-apl: NOTRUN -> [SKIP][110] ([fdo#109271]) +261 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl2/igt@kms_vblank@pipe-d-wait-forked-hang.html
* igt@kms_writeback@writeback-fb-id:
- shard-tglb: NOTRUN -> [SKIP][111] ([i915#2437])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb2/igt@kms_writeback@writeback-fb-id.html
* igt@nouveau_crc@pipe-d-source-rg:
- shard-tglb: NOTRUN -> [SKIP][112] ([i915#2530])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb1/igt@nouveau_crc@pipe-d-source-rg.html
* igt@prime_nv_pcopy@test1_micro:
- shard-iclb: NOTRUN -> [SKIP][113] ([fdo#109291])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb7/igt@prime_nv_pcopy@test1_micro.html
* igt@sysfs_clients@busy:
- shard-skl: NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#2994])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl4/igt@sysfs_clients@busy.html
* igt@sysfs_clients@fair-0:
- shard-kbl: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#2994])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl6/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#2994]) +3 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl8/igt@sysfs_clients@fair-1.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][117] ([i915#2842]) -> [PASS][118] +2 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][119] ([i915#2842]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-glk6/igt@gem_exec_fair@basic-throttle@rcs0.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html
- shard-iclb: [FAIL][121] ([i915#2849]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@i915_pm_backlight@fade_with_suspend:
- shard-tglb: [INCOMPLETE][123] ([i915#4173] / [i915#456]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-tglb7/igt@i915_pm_backlight@fade_with_suspend.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb1/igt@i915_pm_backlight@fade_with_suspend.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-skl: [DMESG-WARN][125] ([i915#1982]) -> [PASS][126] +1 similar issue
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl4/igt@kms_color@pipe-a-ctm-0-75.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [INCOMPLETE][127] ([i915#146] / [i915#300]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-tglb: [INCOMPLETE][129] ([i915#2411] / [i915#4173] / [i915#456]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-tglb7/igt@kms_flip@flip-vs-suspend@a-edp1.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-tglb2/igt@kms_flip@flip-vs-suspend@a-edp1.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][131] ([i915#180]) -> [PASS][132] +1 similar issue
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
- shard-apl: [DMESG-WARN][133] ([i915#180]) -> [PASS][134] +1 similar issue
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-apl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][135] ([fdo#108145] / [i915#265]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][137] ([fdo#109441]) -> [PASS][138] +1 similar issue
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@perf@blocking:
- shard-skl: [FAIL][139] ([i915#1542]) -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl8/igt@perf@blocking.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl3/igt@perf@blocking.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][141] ([i915#1804] / [i915#2684]) -> [WARN][142] ([i915#2684])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][143] ([i915#2684]) -> [WARN][144] ([i915#1804] / [i915#2684])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-iclb8/igt@i915_pm_rc6_residency@rc6-idle.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][145] ([i915#2920]) -> [SKIP][146] ([i915#658])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb5/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: [SKIP][147] ([i915#658]) -> [SKIP][148] ([i915#2920]) +5 similar issues
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-iclb6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [FAIL][149] ([i915#4148]) -> [SKIP][150] ([fdo#109642] / [fdo#111068] / [i915#658])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-iclb2/igt@kms_psr2_su@page_flip.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-iclb3/igt@kms_psr2_su@page_flip.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156]) ([fdo#109271] / [i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#602]) -> ([FAIL][157], [FAIL][158], [FAIL][159], [FAIL][160], [FAIL][161], [FAIL][162], [FAIL][163], [FAIL][164]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#602] / [i915#92])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-kbl1/igt@runner@aborted.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-kbl6/igt@runner@aborted.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-kbl3/igt@runner@aborted.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-kbl3/igt@runner@aborted.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-kbl1/igt@runner@aborted.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-kbl1/igt@runner@aborted.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl1/igt@runner@aborted.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl2/igt@runner@aborted.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl1/igt@runner@aborted.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl1/igt@runner@aborted.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl7/igt@runner@aborted.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl6/igt@runner@aborted.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl6/igt@runner@aborted.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-kbl7/igt@runner@aborted.html
- shard-apl: ([FAIL][165], [FAIL][166], [FAIL][167], [FAIL][168], [FAIL][169], [FAIL][170]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][171], [FAIL][172], [FAIL][173], [FAIL][174], [FAIL][175]) ([fdo#109271] / [i915#180] / [i915#3363])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-apl7/igt@runner@aborted.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-apl2/igt@runner@aborted.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-apl6/igt@runner@aborted.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-apl1/igt@runner@aborted.html
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-apl3/igt@runner@aborted.html
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-apl2/igt@runner@aborted.html
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl6/igt@runner@aborted.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl1/igt@runner@aborted.html
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl7/igt@runner@aborted.html
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl8/igt@runner@aborted.html
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-apl3/igt@runner@aborted.html
- shard-skl: ([FAIL][176], [FAIL][177]) ([i915#3002] / [i915#3363]) -> ([FAIL][178], [FAIL][179], [FAIL][180]) ([i915#1814] / [i915#2029] / [i915#3002] / [i915#3363])
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl7/igt@runner@aborted.html
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10642/shard-skl4/igt@runner@aborted.html
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/shard-skl3/igt@runner@aborted.html
[179]: https://intel-gfx-ci.01.org/tree/drm-
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21156/index.html
[-- Attachment #2: Type: text/html, Size: 33094 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Flush buffer pools on driver remove
2021-09-24 16:38 [Intel-gfx] [PATCH v2] drm/i915: Flush buffer pools on driver remove Janusz Krzysztofik
` (2 preceding siblings ...)
2021-09-25 1:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-09-25 2:58 ` Matt Roper
3 siblings, 0 replies; 5+ messages in thread
From: Matt Roper @ 2021-09-25 2:58 UTC (permalink / raw)
To: Janusz Krzysztofik; +Cc: intel-gfx, dri-devel, Chris Wilson
On Fri, Sep 24, 2021 at 06:38:25PM +0200, Janusz Krzysztofik wrote:
> We currently do an explicit flush of the buffer pools within the call path
> of drm_driver.release(); this removes all buffers, regardless of their age,
> freeing the buffers' associated resources (objects, adress space areas).
> However there is other code that runs within the drm_driver.release() call
> chain that expects objects and their associated address space areas have
> already been flushed.
>
> Since buffer pools auto-flush old buffers once per second in a worker
> thread, there's a small window where if we remove the driver while there
> are still objects in buffers with an age of less than one second, the
> assumptions of the other release code may be violated.
>
> By moving the flush to driver remove (which executes earlier via the
> pci_driver.remove() flow) we're ensuring that all buffers are flushed and
> their associated objects freed before some other code in
> pci_driver.remove() flushes those objects so they are released before
> _any_ code in drm_driver.release() that check completness of those
> flushes executes.
>
> v2: Reword commit descriptiom as suggested by Matt.
>
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
and applied to drm-intel-gt-next (with a couple minor spelling fixes in
the commit message). Thanks for the patch.
Matt
> ---
> drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++
> drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
> index 4037c3778225..5b3acf2b064e 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
> @@ -741,6 +741,8 @@ void intel_gt_driver_remove(struct intel_gt *gt)
> intel_uc_driver_remove(>->uc);
>
> intel_engines_release(gt);
> +
> + intel_gt_flush_buffer_pool(gt);
> }
>
> void intel_gt_driver_unregister(struct intel_gt *gt)
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c b/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
> index aa0a59c5b614..acc49c56a9f3 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
> @@ -245,8 +245,6 @@ void intel_gt_fini_buffer_pool(struct intel_gt *gt)
> struct intel_gt_buffer_pool *pool = >->buffer_pool;
> int n;
>
> - intel_gt_flush_buffer_pool(gt);
> -
> for (n = 0; n < ARRAY_SIZE(pool->cache_list); n++)
> GEM_BUG_ON(!list_empty(&pool->cache_list[n]));
> }
> --
> 2.25.1
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-25 2:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 16:38 [Intel-gfx] [PATCH v2] drm/i915: Flush buffer pools on driver remove Janusz Krzysztofik
2021-09-24 21:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Flush buffer pools on driver remove (rev4) Patchwork
2021-09-24 22:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-25 1:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-09-25 2:58 ` [Intel-gfx] [PATCH v2] drm/i915: Flush buffer pools on driver remove Matt Roper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).