* [Intel-gfx] [PATCH 0/3] drm/i915: Fix header test and log spam on !x86
@ 2022-01-26 0:43 Lucas De Marchi
2022-01-26 0:43 ` [Intel-gfx] [PATCH 1/3] drm: Stop spamming log with drm_cache message Lucas De Marchi
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Lucas De Marchi @ 2022-01-26 0:43 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel
Some minor fixes and changes to help porting i915 to arm64, or even
anything !x86.
Lucas De Marchi (3):
drm: Stop spamming log with drm_cache message
drm/i915: Do not spam log with missiing arch support
drm/i915: Fix header test for !CONFIG_X86
drivers/gpu/drm/drm_cache.c | 3 ---
drivers/gpu/drm/i915/i915_mm.h | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH 1/3] drm: Stop spamming log with drm_cache message
2022-01-26 0:43 [Intel-gfx] [PATCH 0/3] drm/i915: Fix header test and log spam on !x86 Lucas De Marchi
@ 2022-01-26 0:43 ` Lucas De Marchi
2022-01-26 18:24 ` Jani Nikula
2022-01-26 0:43 ` [Intel-gfx] [PATCH 2/3] drm/i915: Do not spam log with missiing arch support Lucas De Marchi
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Lucas De Marchi @ 2022-01-26 0:43 UTC (permalink / raw)
To: intel-gfx; +Cc: David Airlie, Maxime Ripard, dri-devel, Thomas Zimmermann
Only x86 and in some cases PPC have support added in drm_cache.c for the
clflush class of functions. However warning once is sufficient to taint
the log instead of spamming it with "Architecture has no drm_cache.c
support" every few millisecond.
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/drm_cache.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
index f19d9acbe959..2d5a4c463a4f 100644
--- a/drivers/gpu/drm/drm_cache.c
+++ b/drivers/gpu/drm/drm_cache.c
@@ -112,7 +112,6 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages)
kunmap_atomic(page_virtual);
}
#else
- pr_err("Architecture has no drm_cache.c support\n");
WARN_ON_ONCE(1);
#endif
}
@@ -143,7 +142,6 @@ drm_clflush_sg(struct sg_table *st)
if (wbinvd_on_all_cpus())
pr_err("Timed out waiting for cache flush\n");
#else
- pr_err("Architecture has no drm_cache.c support\n");
WARN_ON_ONCE(1);
#endif
}
@@ -177,7 +175,6 @@ drm_clflush_virt_range(void *addr, unsigned long length)
if (wbinvd_on_all_cpus())
pr_err("Timed out waiting for cache flush\n");
#else
- pr_err("Architecture has no drm_cache.c support\n");
WARN_ON_ONCE(1);
#endif
}
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH 2/3] drm/i915: Do not spam log with missiing arch support
2022-01-26 0:43 [Intel-gfx] [PATCH 0/3] drm/i915: Fix header test and log spam on !x86 Lucas De Marchi
2022-01-26 0:43 ` [Intel-gfx] [PATCH 1/3] drm: Stop spamming log with drm_cache message Lucas De Marchi
@ 2022-01-26 0:43 ` Lucas De Marchi
2022-01-26 0:43 ` [Intel-gfx] [PATCH 3/3] drm/i915: Fix header test for !CONFIG_X86 Lucas De Marchi
2022-01-26 3:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix header test and log spam on !x86 Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Lucas De Marchi @ 2022-01-26 0:43 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel
Following what was done in drm_cache.c, when the stub for
remap_io_mapping() was added in commit 67c430bbaae1 ("drm/i915: Skip
remap_io_mapping() for non-x86 platforms"), it was added a log message.
However the WARN_ON_ONCE() should already be enough - we don't want to
spam the log with those messages.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/i915_mm.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_mm.h b/drivers/gpu/drm/i915/i915_mm.h
index 76f1d53bdf34..ed04fc756271 100644
--- a/drivers/gpu/drm/i915/i915_mm.h
+++ b/drivers/gpu/drm/i915/i915_mm.h
@@ -22,7 +22,6 @@ int remap_io_mapping(struct vm_area_struct *vma,
unsigned long addr, unsigned long pfn, unsigned long size,
struct io_mapping *iomap)
{
- pr_err("Architecture has no %s() and shouldn't be calling this function\n", __func__);
WARN_ON_ONCE(1);
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915: Fix header test for !CONFIG_X86
2022-01-26 0:43 [Intel-gfx] [PATCH 0/3] drm/i915: Fix header test and log spam on !x86 Lucas De Marchi
2022-01-26 0:43 ` [Intel-gfx] [PATCH 1/3] drm: Stop spamming log with drm_cache message Lucas De Marchi
2022-01-26 0:43 ` [Intel-gfx] [PATCH 2/3] drm/i915: Do not spam log with missiing arch support Lucas De Marchi
@ 2022-01-26 0:43 ` Lucas De Marchi
2022-01-26 3:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix header test and log spam on !x86 Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Lucas De Marchi @ 2022-01-26 0:43 UTC (permalink / raw)
To: intel-gfx; +Cc: Siva Mullati, dri-devel
Architectures others than x86 have a stub implementation calling
WARN_ON_ONCE(). The appropriate headers need to be included, otherwise
the header-test target will fail with:
HDRTEST drivers/gpu/drm/i915/i915_mm.h
In file included from <command-line>:
./drivers/gpu/drm/i915/i915_mm.h: In function ‘remap_io_mapping’:
./drivers/gpu/drm/i915/i915_mm.h:26:2: error: implicit declaration of function ‘WARN_ON_ONCE’ [-Werror=implicit-function-declaration]
26 | WARN_ON_ONCE(1);
| ^~~~~~~~~~~~
v2: Do not include <linux/printk.h> since call to pr_err() has been
removed
Fixes: 67c430bbaae1 ("drm/i915: Skip remap_io_mapping() for non-x86 platforms")
Cc: Siva Mullati <siva.mullati@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/i915_mm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_mm.h b/drivers/gpu/drm/i915/i915_mm.h
index ed04fc756271..bc30581b20f6 100644
--- a/drivers/gpu/drm/i915/i915_mm.h
+++ b/drivers/gpu/drm/i915/i915_mm.h
@@ -6,6 +6,7 @@
#ifndef __I915_MM_H__
#define __I915_MM_H__
+#include <linux/bug.h>
#include <linux/types.h>
struct vm_area_struct;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix header test and log spam on !x86
2022-01-26 0:43 [Intel-gfx] [PATCH 0/3] drm/i915: Fix header test and log spam on !x86 Lucas De Marchi
` (2 preceding siblings ...)
2022-01-26 0:43 ` [Intel-gfx] [PATCH 3/3] drm/i915: Fix header test for !CONFIG_X86 Lucas De Marchi
@ 2022-01-26 3:48 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-01-26 3:48 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6868 bytes --]
== Series Details ==
Series: drm/i915: Fix header test and log spam on !x86
URL : https://patchwork.freedesktop.org/series/99344/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11136 -> Patchwork_22106
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_22106 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_22106, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/index.html
Participating hosts (45 -> 44)
------------------------------
Additional (2): fi-icl-u2 fi-pnv-d510
Missing (3): fi-ctg-p8600 fi-bdw-samus fi-hsw-4200u
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22106:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s0@smem:
- fi-kbl-soraka: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11136/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0@smem.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0@smem.html
Known issues
------------
Here are the changes found in Patchwork_22106 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][3] ([fdo#109315]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-icl-u2/igt@amdgpu/amd_cs_nop@fork-gfx0.html
* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-icl-u2/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][6] ([i915#2927] / [i915#4528])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][7] ([fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][8] ([fdo#109278]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][9] ([fdo#109285])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][10] ([fdo#109271]) +39 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-pnv-d510/igt@prime_vgem@basic-userptr.html
- fi-icl-u2: NOTRUN -> [SKIP][11] ([i915#3301])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-icl-u2/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][12] ([fdo#109271] / [i915#2403] / [i915#4312])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-pnv-d510/igt@runner@aborted.html
- fi-bdw-5557u: NOTRUN -> [FAIL][13] ([i915#2426] / [i915#4312])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-bdw-5557u/igt@runner@aborted.html
#### Warnings ####
* igt@i915_selftest@live:
- fi-skl-6600u: [INCOMPLETE][14] ([i915#4794]) -> [FAIL][15] ([i915#4547])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11136/fi-skl-6600u/igt@i915_selftest@live.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-skl-6600u/igt@i915_selftest@live.html
* igt@runner@aborted:
- fi-skl-6600u: [FAIL][16] ([i915#1436] / [i915#2722] / [i915#4312]) -> [FAIL][17] ([i915#1436] / [i915#4312])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11136/fi-skl-6600u/igt@runner@aborted.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/fi-skl-6600u/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4794]: https://gitlab.freedesktop.org/drm/intel/issues/4794
[i915#4898]: https://gitlab.freedesktop.org/drm/intel/issues/4898
Build changes
-------------
* Linux: CI_DRM_11136 -> Patchwork_22106
CI-20190529: 20190529
CI_DRM_11136: 06ca272153ea97bf87eb490ecd540dd8527d5497 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6332: 27c9c3f5181a840c777399be7681d2cadd7940cd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22106: 08c832c7702cd00aef2adcfd2aa612fa412671f5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
08c832c7702c drm/i915: Fix header test for !CONFIG_X86
92a5026ff92b drm/i915: Do not spam log with missiing arch support
b1a7549c96e5 drm: Stop spamming log with drm_cache message
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22106/index.html
[-- Attachment #2: Type: text/html, Size: 8025 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm: Stop spamming log with drm_cache message
2022-01-26 0:43 ` [Intel-gfx] [PATCH 1/3] drm: Stop spamming log with drm_cache message Lucas De Marchi
@ 2022-01-26 18:24 ` Jani Nikula
2022-01-26 20:14 ` Lucas De Marchi
0 siblings, 1 reply; 7+ messages in thread
From: Jani Nikula @ 2022-01-26 18:24 UTC (permalink / raw)
To: Lucas De Marchi, intel-gfx
Cc: David Airlie, Thomas Zimmermann, dri-devel, Maxime Ripard
On Tue, 25 Jan 2022, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> Only x86 and in some cases PPC have support added in drm_cache.c for the
> clflush class of functions. However warning once is sufficient to taint
> the log instead of spamming it with "Architecture has no drm_cache.c
> support" every few millisecond.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/drm_cache.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
> index f19d9acbe959..2d5a4c463a4f 100644
> --- a/drivers/gpu/drm/drm_cache.c
> +++ b/drivers/gpu/drm/drm_cache.c
> @@ -112,7 +112,6 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages)
> kunmap_atomic(page_virtual);
> }
> #else
> - pr_err("Architecture has no drm_cache.c support\n");
> WARN_ON_ONCE(1);
An alternative would be to replace the two lines with:
WARN_ONCE(1, "Architecture has no drm_cache.c support\n");
But I'm not insisting.
BR,
Jani.
> #endif
> }
> @@ -143,7 +142,6 @@ drm_clflush_sg(struct sg_table *st)
> if (wbinvd_on_all_cpus())
> pr_err("Timed out waiting for cache flush\n");
> #else
> - pr_err("Architecture has no drm_cache.c support\n");
> WARN_ON_ONCE(1);
> #endif
> }
> @@ -177,7 +175,6 @@ drm_clflush_virt_range(void *addr, unsigned long length)
> if (wbinvd_on_all_cpus())
> pr_err("Timed out waiting for cache flush\n");
> #else
> - pr_err("Architecture has no drm_cache.c support\n");
> WARN_ON_ONCE(1);
> #endif
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm: Stop spamming log with drm_cache message
2022-01-26 18:24 ` Jani Nikula
@ 2022-01-26 20:14 ` Lucas De Marchi
0 siblings, 0 replies; 7+ messages in thread
From: Lucas De Marchi @ 2022-01-26 20:14 UTC (permalink / raw)
To: Jani Nikula
Cc: David Airlie, Thomas Zimmermann, intel-gfx, dri-devel, Maxime Ripard
On Wed, Jan 26, 2022 at 08:24:54PM +0200, Jani Nikula wrote:
>On Tue, 25 Jan 2022, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>> Only x86 and in some cases PPC have support added in drm_cache.c for the
>> clflush class of functions. However warning once is sufficient to taint
>> the log instead of spamming it with "Architecture has no drm_cache.c
>> support" every few millisecond.
>>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: David Airlie <airlied@linux.ie>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>> drivers/gpu/drm/drm_cache.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
>> index f19d9acbe959..2d5a4c463a4f 100644
>> --- a/drivers/gpu/drm/drm_cache.c
>> +++ b/drivers/gpu/drm/drm_cache.c
>> @@ -112,7 +112,6 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages)
>> kunmap_atomic(page_virtual);
>> }
>> #else
>> - pr_err("Architecture has no drm_cache.c support\n");
>> WARN_ON_ONCE(1);
>
>An alternative would be to replace the two lines with:
>
> WARN_ONCE(1, "Architecture has no drm_cache.c support\n");
>
>But I'm not insisting.
I actually like that suggestion. I will change that in the next version.
Thanks
Lucas De Marchi
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-01-26 20:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-26 0:43 [Intel-gfx] [PATCH 0/3] drm/i915: Fix header test and log spam on !x86 Lucas De Marchi
2022-01-26 0:43 ` [Intel-gfx] [PATCH 1/3] drm: Stop spamming log with drm_cache message Lucas De Marchi
2022-01-26 18:24 ` Jani Nikula
2022-01-26 20:14 ` Lucas De Marchi
2022-01-26 0:43 ` [Intel-gfx] [PATCH 2/3] drm/i915: Do not spam log with missiing arch support Lucas De Marchi
2022-01-26 0:43 ` [Intel-gfx] [PATCH 3/3] drm/i915: Fix header test for !CONFIG_X86 Lucas De Marchi
2022-01-26 3:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix header test and log spam on !x86 Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).