* [Intel-gfx] [PATCH] Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd"
@ 2022-02-23 8:18 Ville Syrjala
2022-02-23 8:29 ` Jani Nikula
2022-02-23 9:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Ville Syrjala @ 2022-02-23 8:18 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
This reverts commit 9bc34b4d0f3cb368241684cc5e0445d435dded44.
Just oopses on most machines.
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 929e9b6febf1..1046e7fe310a 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4455,12 +4455,6 @@ intel_dp_detect(struct drm_connector *connector,
memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance));
memset(intel_dp->dsc_dpcd, 0, sizeof(intel_dp->dsc_dpcd));
- /* Reset VRR Capable property */
- drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s] VRR capable: FALSE\n",
- connector->base.id, connector->name);
- drm_connector_set_vrr_capable_property(connector,
- false);
-
if (intel_dp->is_mst) {
drm_dbg_kms(&dev_priv->drm,
"MST device may have disappeared %d vs %d\n",
@@ -4575,18 +4569,15 @@ static int intel_dp_get_modes(struct drm_connector *connector)
{
struct intel_connector *intel_connector = to_intel_connector(connector);
struct edid *edid;
- struct drm_i915_private *i915 = to_i915(connector->dev);
int num_modes = 0;
edid = intel_connector->detect_edid;
if (edid) {
- bool vrr_capable;
-
num_modes = intel_connector_update_modes(connector, edid);
- vrr_capable = intel_vrr_is_capable(connector);
- drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
- connector->base.id, connector->name, yesno(vrr_capable));
- drm_connector_set_vrr_capable_property(connector, vrr_capable);
+
+ if (intel_vrr_is_capable(connector))
+ drm_connector_set_vrr_capable_property(connector,
+ true);
}
/* Also add fixed mode, which may or may not be present in EDID */
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd"
2022-02-23 8:18 [Intel-gfx] [PATCH] Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd" Ville Syrjala
@ 2022-02-23 8:29 ` Jani Nikula
2022-02-23 19:26 ` Navare, Manasi
2022-02-23 9:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
1 sibling, 1 reply; 4+ messages in thread
From: Jani Nikula @ 2022-02-23 8:29 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On Wed, 23 Feb 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This reverts commit 9bc34b4d0f3cb368241684cc5e0445d435dded44.
>
> Just oopses on most machines.
>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Auch, "ERROR: It appears as if the changes made in Patchwork_22288
prevented too many machines from booting." [1].
Acked-by: Jani Nikula <jani.nikula@intel.com>
[1] https://lore.kernel.org/r/164506400291.18053.4904919379639827273@emeril.freedesktop.org
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 17 ++++-------------
> 1 file changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 929e9b6febf1..1046e7fe310a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -4455,12 +4455,6 @@ intel_dp_detect(struct drm_connector *connector,
> memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance));
> memset(intel_dp->dsc_dpcd, 0, sizeof(intel_dp->dsc_dpcd));
>
> - /* Reset VRR Capable property */
> - drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s] VRR capable: FALSE\n",
> - connector->base.id, connector->name);
> - drm_connector_set_vrr_capable_property(connector,
> - false);
> -
> if (intel_dp->is_mst) {
> drm_dbg_kms(&dev_priv->drm,
> "MST device may have disappeared %d vs %d\n",
> @@ -4575,18 +4569,15 @@ static int intel_dp_get_modes(struct drm_connector *connector)
> {
> struct intel_connector *intel_connector = to_intel_connector(connector);
> struct edid *edid;
> - struct drm_i915_private *i915 = to_i915(connector->dev);
> int num_modes = 0;
>
> edid = intel_connector->detect_edid;
> if (edid) {
> - bool vrr_capable;
> -
> num_modes = intel_connector_update_modes(connector, edid);
> - vrr_capable = intel_vrr_is_capable(connector);
> - drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
> - connector->base.id, connector->name, yesno(vrr_capable));
> - drm_connector_set_vrr_capable_property(connector, vrr_capable);
> +
> + if (intel_vrr_is_capable(connector))
> + drm_connector_set_vrr_capable_property(connector,
> + true);
> }
>
> /* Also add fixed mode, which may or may not be present in EDID */
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd"
2022-02-23 8:18 [Intel-gfx] [PATCH] Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd" Ville Syrjala
2022-02-23 8:29 ` Jani Nikula
@ 2022-02-23 9:18 ` Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2022-02-23 9:18 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 22591 bytes --]
== Series Details ==
Series: Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd"
URL : https://patchwork.freedesktop.org/series/100623/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11269 -> Patchwork_22368
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/index.html
Participating hosts (16 -> 31)
------------------------------
Additional (21): fi-bdw-gvtdvm fi-skl-6600u fi-cml-u2 fi-bdw-5557u fi-bsw-n3050 fi-glk-dsi fi-ilk-650 fi-kbl-7500u fi-hsw-4770 fi-ivb-3770 fi-elk-e7500 fi-bsw-nick fi-skl-6700k2 fi-kbl-7567u fi-skl-guc fi-cfl-8700k fi-cfl-guc fi-kbl-guc fi-kbl-x1275 fi-cfl-8109u fi-kbl-8809g
Missing (6): bat-dg1-6 bat-dg1-5 bat-dg2-8 bat-adlp-6 bat-rpls-1 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_22368 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-cfl-guc: NOTRUN -> [SKIP][1] ([fdo#109271]) +28 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-guc/igt@amdgpu/amd_basic@cs-compute.html
* igt@amdgpu/amd_basic@cs-gfx:
- fi-skl-6700k2: NOTRUN -> [SKIP][2] ([fdo#109271]) +28 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-6700k2/igt@amdgpu/amd_basic@cs-gfx.html
* igt@amdgpu/amd_basic@cs-sdma:
- fi-cfl-8109u: NOTRUN -> [SKIP][3] ([fdo#109271]) +28 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-8109u/igt@amdgpu/amd_basic@cs-sdma.html
- fi-kbl-7500u: NOTRUN -> [SKIP][4] ([fdo#109271]) +28 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-7500u/igt@amdgpu/amd_basic@cs-sdma.html
* igt@amdgpu/amd_basic@memory-alloc:
- fi-cml-u2: NOTRUN -> [SKIP][5] ([fdo#109315]) +17 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cml-u2/igt@amdgpu/amd_basic@memory-alloc.html
* igt@amdgpu/amd_cs_nop@nop-compute0:
- fi-ilk-650: NOTRUN -> [SKIP][6] ([fdo#109271]) +39 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-ilk-650/igt@amdgpu/amd_cs_nop@nop-compute0.html
* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-cfl-8700k: NOTRUN -> [SKIP][7] ([fdo#109271]) +28 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-8700k/igt@amdgpu/amd_cs_nop@sync-fork-gfx0.html
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-x1275: NOTRUN -> [SKIP][8] ([fdo#109271]) +28 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-x1275/igt@amdgpu/amd_prime@amd-to-i915.html
* igt@fbdev@write:
- fi-bdw-gvtdvm: NOTRUN -> [SKIP][9] ([fdo#109271]) +5 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-bdw-gvtdvm/igt@fbdev@write.html
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-skl-6600u: NOTRUN -> [SKIP][10] ([fdo#109271]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-6600u/igt@gem_exec_fence@basic-busy@bcs0.html
- fi-cml-u2: NOTRUN -> [SKIP][11] ([i915#1208]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cml-u2/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_suspend@basic-s0@smem:
- fi-bdw-gvtdvm: NOTRUN -> [INCOMPLETE][12] ([i915#4831])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-bdw-gvtdvm/igt@gem_exec_suspend@basic-s0@smem.html
- fi-kbl-8809g: NOTRUN -> [DMESG-WARN][13] ([i915#4962]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-8809g/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: NOTRUN -> [FAIL][14] ([i915#4547])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-6600u/igt@gem_flink_basic@bad-flink.html
* igt@gem_huc_copy@huc-copy:
- fi-cml-u2: NOTRUN -> [SKIP][15] ([i915#2190])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cml-u2/igt@gem_huc_copy@huc-copy.html
- fi-hsw-4770: NOTRUN -> [SKIP][16] ([fdo#109271]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-hsw-4770/igt@gem_huc_copy@huc-copy.html
- fi-skl-6700k2: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#2190])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-6700k2/igt@gem_huc_copy@huc-copy.html
- fi-glk-dsi: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#2190])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-glk-dsi/igt@gem_huc_copy@huc-copy.html
- fi-kbl-x1275: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#2190])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-x1275/igt@gem_huc_copy@huc-copy.html
- fi-kbl-7500u: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#2190])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-7500u/igt@gem_huc_copy@huc-copy.html
- fi-kbl-8809g: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#2190])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
- fi-kbl-7567u: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#2190])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-7567u/igt@gem_huc_copy@huc-copy.html
- fi-cfl-8109u: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#2190])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-8109u/igt@gem_huc_copy@huc-copy.html
- fi-cfl-8700k: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#2190])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-8700k/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-skl-guc: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4613]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-guc/igt@gem_lmem_swapping@basic.html
- fi-kbl-7567u: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#4613]) +3 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-7567u/igt@gem_lmem_swapping@basic.html
- fi-elk-e7500: NOTRUN -> [SKIP][27] ([fdo#109271]) +53 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-elk-e7500/igt@gem_lmem_swapping@basic.html
- fi-glk-dsi: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#4613]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-glk-dsi/igt@gem_lmem_swapping@basic.html
- fi-kbl-guc: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#4613]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-guc/igt@gem_lmem_swapping@basic.html
- fi-kbl-7500u: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#4613]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-7500u/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-cfl-8700k: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#4613]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-8700k/igt@gem_lmem_swapping@parallel-random-engines.html
- fi-cfl-guc: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#4613]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-guc/igt@gem_lmem_swapping@parallel-random-engines.html
- fi-cml-u2: NOTRUN -> [SKIP][33] ([i915#4613]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cml-u2/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@random-engines:
- fi-ivb-3770: NOTRUN -> [SKIP][34] ([fdo#109271]) +35 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-ivb-3770/igt@gem_lmem_swapping@random-engines.html
- fi-skl-6700k2: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#4613]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-6700k2/igt@gem_lmem_swapping@random-engines.html
- fi-kbl-8809g: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#4613]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-8809g/igt@gem_lmem_swapping@random-engines.html
- fi-cfl-8109u: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#4613]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-8109u/igt@gem_lmem_swapping@random-engines.html
* igt@gem_lmem_swapping@verify-random:
- fi-kbl-x1275: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#4613]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-x1275/igt@gem_lmem_swapping@verify-random.html
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3012])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-hsw-4770/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: NOTRUN -> [INCOMPLETE][40] ([i915#4785])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@kms_busy@basic:
- fi-kbl-guc: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#1845])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-guc/igt@kms_busy@basic.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +8 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +8 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
- fi-skl-guc: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +8 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-guc/igt@kms_chamelium@dp-crc-fast.html
- fi-kbl-7567u: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +8 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-7567u/igt@kms_chamelium@dp-crc-fast.html
- fi-bsw-nick: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827]) +8 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-bsw-nick/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@dp-edid-read:
- fi-cfl-guc: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +8 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-guc/igt@kms_chamelium@dp-edid-read.html
* igt@kms_chamelium@dp-hpd-fast:
- fi-ilk-650: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) +8 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-ilk-650/igt@kms_chamelium@dp-hpd-fast.html
- fi-ivb-3770: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +8 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-ivb-3770/igt@kms_chamelium@dp-hpd-fast.html
- fi-cml-u2: NOTRUN -> [SKIP][50] ([fdo#109284] / [fdo#111827]) +8 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cml-u2/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-skl-6700k2: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +8 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-6700k2/igt@kms_chamelium@hdmi-crc-fast.html
- fi-bsw-n3050: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +8 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-bsw-n3050/igt@kms_chamelium@hdmi-crc-fast.html
- fi-kbl-x1275: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +8 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-x1275/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-8809g: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +8 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-8809g/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-glk-dsi: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +8 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-glk-dsi/igt@kms_chamelium@hdmi-hpd-fast.html
- fi-cfl-8109u: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#111827]) +8 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-8109u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_chamelium@vga-edid-read:
- fi-cfl-8700k: NOTRUN -> [SKIP][57] ([fdo#109271] / [fdo#111827]) +8 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-8700k/igt@kms_chamelium@vga-edid-read.html
* igt@kms_chamelium@vga-hpd-fast:
- fi-kbl-guc: NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +8 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-guc/igt@kms_chamelium@vga-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-skl-guc: NOTRUN -> [SKIP][59] ([fdo#109271]) +28 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-cml-u2: NOTRUN -> [SKIP][60] ([fdo#109278]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cml-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-cml-u2: NOTRUN -> [SKIP][61] ([fdo#109285])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cml-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: NOTRUN -> [DMESG-WARN][62] ([i915#4269])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-hsw-4770: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#533])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-kbl-7500u: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#533])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-7500u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-kbl-guc: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#533])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-cml-u2: NOTRUN -> [SKIP][66] ([fdo#109278] / [i915#533])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cml-u2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-cfl-8700k: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#533])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-8700k/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-cfl-guc: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#533])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-skl-6700k2: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#533])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-6700k2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-kbl-x1275: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#533])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-x1275/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-cfl-8109u: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#533])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-glk-dsi: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#533])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-glk-dsi/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-kbl-8809g: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#533])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-kbl-7567u: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#533])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-7567u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-skl-guc: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#533])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-bsw-n3050: NOTRUN -> [SKIP][76] ([fdo#109271]) +46 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-bsw-n3050/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-kbl-guc: NOTRUN -> [SKIP][77] ([fdo#109271]) +40 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-guc/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
- fi-kbl-7567u: NOTRUN -> [SKIP][78] ([fdo#109271]) +59 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
* igt@kms_psr@cursor_plane_move:
- fi-kbl-8809g: NOTRUN -> [SKIP][79] ([fdo#109271]) +54 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-kbl-8809g/igt@kms_psr@cursor_plane_move.html
* igt@kms_psr@primary_mmap_gtt:
- fi-hsw-4770: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#1072]) +3 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-hsw-4770/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_psr@primary_page_flip:
- fi-glk-dsi: NOTRUN -> [SKIP][81] ([fdo#109271]) +30 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-glk-dsi/igt@kms_psr@primary_page_flip.html
* igt@prime_vgem@basic-fence-flip:
- fi-bsw-nick: NOTRUN -> [SKIP][82] ([fdo#109271]) +67 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-bsw-nick/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-userptr:
- fi-cml-u2: NOTRUN -> [SKIP][83] ([i915#3301])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-cml-u2/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][84] ([i915#4312])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-skl-6600u/igt@runner@aborted.html
- fi-bdw-5557u: NOTRUN -> [FAIL][85] ([i915#2426] / [i915#4312])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-bdw-5557u/igt@runner@aborted.html
- fi-hsw-4770: NOTRUN -> [FAIL][86] ([fdo#109271] / [i915#1436] / [i915#4312])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-hsw-4770/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@perf:
- {fi-tgl-dsi}: [DMESG-WARN][87] ([i915#2867]) -> [PASS][88] +17 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11269/fi-tgl-dsi/igt@i915_selftest@live@perf.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/fi-tgl-dsi/igt@i915_selftest@live@perf.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1208]: https://gitlab.freedesktop.org/drm/intel/issues/1208
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4831]: https://gitlab.freedesktop.org/drm/intel/issues/4831
[i915#4962]: https://gitlab.freedesktop.org/drm/intel/issues/4962
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_11269 -> Patchwork_22368
CI-20190529: 20190529
CI_DRM_11269: 09d2de01f86139b074e80a1245e824311157aae9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6352: 11b4d227d8f0efad522519c8fd9525774247c8d8 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22368: 64a1c5ec2786363899c6e6bacceddb7bdb1b6be4 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
64a1c5ec2786 Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22368/index.html
[-- Attachment #2: Type: text/html, Size: 32736 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd"
2022-02-23 8:29 ` Jani Nikula
@ 2022-02-23 19:26 ` Navare, Manasi
0 siblings, 0 replies; 4+ messages in thread
From: Navare, Manasi @ 2022-02-23 19:26 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Feb 23, 2022 at 10:29:16AM +0200, Jani Nikula wrote:
> On Wed, 23 Feb 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > This reverts commit 9bc34b4d0f3cb368241684cc5e0445d435dded44.
> >
> > Just oopses on most machines.
> >
> > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Auch, "ERROR: It appears as if the changes made in Patchwork_22288
> prevented too many machines from booting." [1].
Why would it prevent machines from booting where this only sets the property to false and we tested this
on VRR panels and it works as expected and infact is needed to turn VRR off if disabled from
the panel and also on the connector disconnect.
Our customers already want this.
We should look at whther this prevented the machines from booting or this just revealed some other issue.
>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
>
>
> [1] https://lore.kernel.org/r/164506400291.18053.4904919379639827273@emeril.freedesktop.org
>
>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp.c | 17 ++++-------------
> > 1 file changed, 4 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 929e9b6febf1..1046e7fe310a 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -4455,12 +4455,6 @@ intel_dp_detect(struct drm_connector *connector,
> > memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance));
> > memset(intel_dp->dsc_dpcd, 0, sizeof(intel_dp->dsc_dpcd));
> >
> > - /* Reset VRR Capable property */
> > - drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s] VRR capable: FALSE\n",
> > - connector->base.id, connector->name);
> > - drm_connector_set_vrr_capable_property(connector,
> > - false);
Do we perhaps need a condition here to reset this only if it was set previously or if it is a VRR panel?
Manasi
> > -
> > if (intel_dp->is_mst) {
> > drm_dbg_kms(&dev_priv->drm,
> > "MST device may have disappeared %d vs %d\n",
> > @@ -4575,18 +4569,15 @@ static int intel_dp_get_modes(struct drm_connector *connector)
> > {
> > struct intel_connector *intel_connector = to_intel_connector(connector);
> > struct edid *edid;
> > - struct drm_i915_private *i915 = to_i915(connector->dev);
> > int num_modes = 0;
> >
> > edid = intel_connector->detect_edid;
> > if (edid) {
> > - bool vrr_capable;
> > -
> > num_modes = intel_connector_update_modes(connector, edid);
> > - vrr_capable = intel_vrr_is_capable(connector);
> > - drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
> > - connector->base.id, connector->name, yesno(vrr_capable));
> > - drm_connector_set_vrr_capable_property(connector, vrr_capable);
> > +
> > + if (intel_vrr_is_capable(connector))
> > + drm_connector_set_vrr_capable_property(connector,
> > + true);
> > }
> >
> > /* Also add fixed mode, which may or may not be present in EDID */
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-23 19:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 8:18 [Intel-gfx] [PATCH] Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd" Ville Syrjala
2022-02-23 8:29 ` Jani Nikula
2022-02-23 19:26 ` Navare, Manasi
2022-02-23 9:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).