* [Intel-gfx] [PATCH] drm/i915/selftests: add over-fetch padding to store_dw batchbuffer
@ 2022-10-26 16:23 Andrzej Hajda
2022-10-26 17:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-10-26 17:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Andrzej Hajda @ 2022-10-26 16:23 UTC (permalink / raw)
To: intel-gfx
Cc: Andrzej Hajda, Lucas De Marchi, Chris Wilson, Matthew Auld, Rodrigo Vivi
Due to batch buffer over-fetch mechanism up to 4KB beyond the last
command in the buffer can be read by engine executing the buffer.
On the other side if memory is accessed during TLB invalidation proper
TLB invalidation is not guaranteed. Both conditions can occur when two
buffers are bound to adjacent PTEs and during execution of the 1st buffer
(overfetch tries to access PTE of the 2nd buffer) 2nd buffer is removed
(memory is unmapped and TLB is invalidated during memory access, not fully).
As a result engine tries to access unmapped memory and causes DMAR faults
and catastrophic errors.
The simplest solution of this issue is to allocate buffers big enough, to
avoid over-fetch crossing buffer boundary.
BSpec: 45718, 44393
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5278
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c
index 3c55e77b0f1b00..42966e3855a5a5 100644
--- a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c
+++ b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c
@@ -44,13 +44,14 @@ igt_emit_store_dw(struct i915_vma *vma,
unsigned long count,
u32 val)
{
+#define BB_OVERFETCH_SIZE (PAGE_SIZE)
struct drm_i915_gem_object *obj;
const int ver = GRAPHICS_VER(vma->vm->i915);
unsigned long n, size;
u32 *cmd;
int err;
- size = (4 * count + 1) * sizeof(u32);
+ size = (4 * count + 1) * sizeof(u32) + BB_OVERFETCH_SIZE;
size = round_up(size, PAGE_SIZE);
obj = i915_gem_object_create_internal(vma->vm->i915, size);
if (IS_ERR(obj))
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: add over-fetch padding to store_dw batchbuffer
2022-10-26 16:23 [Intel-gfx] [PATCH] drm/i915/selftests: add over-fetch padding to store_dw batchbuffer Andrzej Hajda
@ 2022-10-26 17:15 ` Patchwork
2022-10-26 17:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2022-10-26 17:15 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: add over-fetch padding to store_dw batchbuffer
URL : https://patchwork.freedesktop.org/series/110186/
State : warning
== Summary ==
Error: dim checkpatch failed
9a15ae121ad3 drm/i915/selftests: add over-fetch padding to store_dw batchbuffer
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13:
(memory is unmapped and TLB is invalidated during memory access, not fully).
total: 0 errors, 1 warnings, 0 checks, 15 lines checked
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: add over-fetch padding to store_dw batchbuffer
2022-10-26 16:23 [Intel-gfx] [PATCH] drm/i915/selftests: add over-fetch padding to store_dw batchbuffer Andrzej Hajda
2022-10-26 17:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2022-10-26 17:38 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2022-10-26 17:38 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8555 bytes --]
== Series Details ==
Series: drm/i915/selftests: add over-fetch padding to store_dw batchbuffer
URL : https://patchwork.freedesktop.org/series/110186/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12297 -> Patchwork_110186v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_110186v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_110186v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/index.html
Participating hosts (40 -> 41)
------------------------------
Additional (3): fi-bdw-gvtdvm fi-bxt-dsi fi-tgl-dsi
Missing (2): fi-ctg-p8600 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_110186v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-bdw-gvtdvm: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-bdw-gvtdvm/igt@i915_suspend@basic-s2idle-without-i915.html
Known issues
------------
Here are the changes found in Patchwork_110186v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-bxt-dsi: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-bxt-dsi/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-apl-guc/igt@gem_lmem_swapping@basic.html
- fi-bdw-gvtdvm: NOTRUN -> [SKIP][4] ([fdo#109271]) +37 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-bdw-gvtdvm/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-bxt-dsi: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-bxt-dsi/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_tiled_blits@basic:
- fi-bxt-dsi: NOTRUN -> [SKIP][6] ([fdo#109271]) +12 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-bxt-dsi/igt@gem_tiled_blits@basic.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: NOTRUN -> [DMESG-FAIL][7] ([i915#5334])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
- fi-bxt-dsi: NOTRUN -> [DMESG-FAIL][8] ([i915#5334])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][9] -> [INCOMPLETE][10] ([i915#4785])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12297/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-apl-guc: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-apl-guc/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-bxt-dsi: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-bxt-dsi/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-bdw-gvtdvm: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-bdw-gvtdvm/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_psr@sprite_plane_onoff:
- fi-apl-guc: NOTRUN -> [SKIP][14] ([fdo#109271]) +11 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-apl-guc/igt@kms_psr@sprite_plane_onoff.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][15] ([fdo#109271] / [i915#4312] / [i915#5594])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-hsw-4770/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- {bat-rplp-1}: [DMESG-WARN][16] ([i915#2867]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12297/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_huc_copy@huc-copy:
- {bat-dg2-8}: [FAIL][18] ([i915#7029]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12297/bat-dg2-8/igt@gem_huc_copy@huc-copy.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/bat-dg2-8/igt@gem_huc_copy@huc-copy.html
* igt@gem_render_tiled_blits@basic:
- fi-apl-guc: [INCOMPLETE][20] ([i915#7056]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12297/fi-apl-guc/igt@gem_render_tiled_blits@basic.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-apl-guc/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_blits@basic:
- fi-pnv-d510: [SKIP][22] ([fdo#109271]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12297/fi-pnv-d510/igt@gem_tiled_blits@basic.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/fi-pnv-d510/igt@gem_tiled_blits@basic.html
* igt@i915_selftest@live@reset:
- {bat-rpls-1}: [DMESG-FAIL][24] ([i915#4983]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12297/bat-rpls-1/igt@i915_selftest@live@reset.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/bat-rpls-1/igt@i915_selftest@live@reset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7029]: https://gitlab.freedesktop.org/drm/intel/issues/7029
[i915#7056]: https://gitlab.freedesktop.org/drm/intel/issues/7056
Build changes
-------------
* Linux: CI_DRM_12297 -> Patchwork_110186v1
CI-20190529: 20190529
CI_DRM_12297: 04810514e57a8a21242682ea8aae25a2ec164720 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7026: ce0f97e7e0aa54c40049a8365b3d61773c92e588 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110186v1: 04810514e57a8a21242682ea8aae25a2ec164720 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
ef57968ca325 drm/i915/selftests: add over-fetch padding to store_dw batchbuffer
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110186v1/index.html
[-- Attachment #2: Type: text/html, Size: 9892 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-26 17:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26 16:23 [Intel-gfx] [PATCH] drm/i915/selftests: add over-fetch padding to store_dw batchbuffer Andrzej Hajda
2022-10-26 17:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-10-26 17:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).