From: Lee Jones <lee@kernel.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@gmail.com>
Subject: Re: [Intel-gfx] [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@'
Date: Wed, 5 Apr 2023 14:45:26 +0100 [thread overview]
Message-ID: <20230405134526.GE8371@google.com> (raw)
In-Reply-To: <878rf80ynz.fsf@intel.com>
On Tue, 04 Apr 2023, Jani Nikula wrote:
> On Mon, 03 Apr 2023, Lee Jones <lee@kernel.org> wrote:
> > On Mon, 03 Apr 2023, Jani Nikula wrote:
> >
> >> On Fri, 31 Mar 2023, Lee Jones <lee@kernel.org> wrote:
> >> > Fixes the following W=1 kernel build warning(s):
> >> >
> >> > drivers/gpu/drm/i915/i915_scatterlist.c:62: warning: Function parameter or member 'size' not described in 'i915_refct_sgt_init'
> >> >
> >> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> >> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> >> > Cc: David Airlie <airlied@gmail.com>
> >> > Cc: Daniel Vetter <daniel@ffwll.ch>
> >> > Cc: intel-gfx@lists.freedesktop.org
> >> > Cc: dri-devel@lists.freedesktop.org
> >> > Signed-off-by: Lee Jones <lee@kernel.org>
> >>
> >> Thanks for the patches!
> >>
> >> Applied all but one of the drm/i915 patches to drm-intel-next or
> >> drm-intel-gt-next depending on the area. There were a couple of issues
> >> that I fixed while applying. There was a conflict with patch 5/19
> >> against drm-intel-gt-next so I left that one out.
> >
> > Thanks Jani. I'll rebase and see what's left.
>
> We also took notice and aim to track this more aggressively [1].
Thanks.
I did clean-up all of the GPU warnings already a couple of years ago,
but they seem to have crept back over time. It would be great if we
could put some extra checks in place to prevent them in the future.
My aim, albeit ambitious, is to clean-up all of the W=1 warnings in the
kernel, then have them promoted to W=0, so they warn more loudly during
development, thus keeping them from reappearing.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-04-05 13:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230331092607.700644-1-lee@kernel.org>
2023-03-31 9:25 ` [Intel-gfx] [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@' Lee Jones
2023-04-03 15:35 ` Jani Nikula
2023-04-03 16:20 ` Lee Jones
2023-04-04 9:44 ` Jani Nikula
2023-04-05 13:45 ` Lee Jones [this message]
2023-04-05 16:06 ` Jani Nikula
2023-04-05 16:41 ` Lee Jones
2023-03-31 9:25 ` [Intel-gfx] [PATCH 02/19] drm/i915/intel_region_ttm: Provide missing description for 'offset' param Lee Jones
2023-03-31 9:25 ` [Intel-gfx] [PATCH 04/19] drm/i915/display/intel_display_debugfs: Fix incorrect param naming for 'intel_connector' Lee Jones
2023-03-31 9:25 ` [Intel-gfx] [PATCH 05/19] drm/i915/gt/intel_engine_cs: Fix a couple of incorrectly named functions Lee Jones
2023-03-31 9:25 ` [Intel-gfx] [PATCH 06/19] drm/i915/gt/intel_rps: Demote a kerneldoc abuse for ips_ping_for_i915_load() Lee Jones
2023-03-31 9:25 ` [Intel-gfx] [PATCH 07/19] drm/i915/gem/i915_gem_create: Provide the function names for proper kerneldoc headers Lee Jones
2023-03-31 15:18 ` kernel test robot
2023-03-31 9:25 ` [Intel-gfx] [PATCH 08/19] drm/i915/gem/i915_gem_domain: Provide function names to complete proper kerneldoc Lee Jones
2023-03-31 9:25 ` [Intel-gfx] [PATCH 09/19] drm/i915/gem/i915_gem_ttm_pm: Provide a couple of missing descriptions for 'flags' and remove some superfluous ones Lee Jones
2023-03-31 9:25 ` [Intel-gfx] [PATCH 10/19] drm/i915/gem/i915_gem_ttm: Demote half-filled kerneldoc Lee Jones
2023-03-31 9:25 ` [Intel-gfx] [PATCH 11/19] drm/i915/gem/i915_gem_ttm_move: Provide a couple of missing descriptions for 'num_pages' and 'ctx' Lee Jones
2023-03-31 9:26 ` [Intel-gfx] [PATCH 12/19] drm/i915/gem/i915_gem_wait: Provide function name to validate the kerneldoc header Lee Jones
2023-03-31 9:26 ` [Intel-gfx] [PATCH 13/19] drm/i915/gem/i915_gem_object: Demote non-kerneldoc header with no param descriptions Lee Jones
2023-03-31 9:26 ` [Intel-gfx] [PATCH 14/19] drm/i915/i915_gem: Provide function names to complete the expected kerneldoc format Lee Jones
2023-03-31 17:52 ` kernel test robot
2023-03-31 9:26 ` [Intel-gfx] [PATCH 15/19] drm/i915/gt/uc/intel_guc_hwconfig: Demote a few non-conforming kerneldoc headers Lee Jones
2023-03-31 9:26 ` [Intel-gfx] [PATCH 16/19] drm/i915/i915_vma: Provide one missing param and demote another non-kerneldoc header Lee Jones
2023-03-31 9:26 ` [Intel-gfx] [PATCH 17/19] drm/i915/display/intel_display_power: Fix incorrectly documented function __intel_display_power_put_async() Lee Jones
2023-03-31 9:26 ` [Intel-gfx] [PATCH 19/19] drm/i915/display/intel_wm: Fix a little doc-rot in intel_update_watermarks() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405134526.GE8371@google.com \
--to=lee@kernel.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).