* [Intel-gfx] [PATCH] drm/i915: eliminate warnings
@ 2023-11-13 3:36 heminhong
2023-11-13 19:06 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: heminhong @ 2023-11-13 3:36 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin,
airlied, daniel, ville.syrjala, animesh.manna, uma.shankar,
ankit.k.nautiyal
Cc: intel-gfx, linux-kernel, dri-devel, heminhong
Current, the dewake_scanline variable is defined as unsigned int,
an unsigned int variable that is always greater than or equal to 0.
when _intel_dsb_commit function is called by intel_dsb_commit function,
the dewake_scanline variable may have an int value.
So the dewake_scanline variable is necessary to defined as an int.
Signed-off-by: heminhong <heminhong@kylinos.cn>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index 78b6fe24dcd8..7fd6280c54a7 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -340,7 +340,7 @@ static int intel_dsb_dewake_scanline(const struct intel_crtc_state *crtc_state)
}
static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
- unsigned int dewake_scanline)
+ int dewake_scanline)
{
struct intel_crtc *crtc = dsb->crtc;
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: eliminate warnings
2023-11-13 3:36 [Intel-gfx] [PATCH] drm/i915: eliminate warnings heminhong
@ 2023-11-13 19:06 ` Patchwork
2023-11-13 20:31 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-11-13 19:06 UTC (permalink / raw)
To: heminhong; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9000 bytes --]
== Series Details ==
Series: drm/i915: eliminate warnings
URL : https://patchwork.freedesktop.org/series/126338/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13869 -> Patchwork_126338v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_126338v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_126338v1, please notify your bug team (lgci.bug.filing@intel.com) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/index.html
Participating hosts (35 -> 34)
------------------------------
Additional (1): bat-dg1-5
Missing (2): fi-snb-2520m fi-pnv-d510
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_126338v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13869/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@vgem_basic@unload:
- fi-hsw-4770: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13869/fi-hsw-4770/igt@vgem_basic@unload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/fi-hsw-4770/igt@vgem_basic@unload.html
Known issues
------------
Here are the changes found in Patchwork_126338v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][5] ([i915#4083])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@gem_mmap@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][6] ([i915#4077]) +2 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][7] ([i915#4079]) +1 other test skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-dg1-5: NOTRUN -> [SKIP][8] ([i915#6621])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@i915_pm_rps@basic-api.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-tgl-1115g4: [PASS][9] -> [ABORT][10] ([i915#8213])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13869/fi-tgl-1115g4/igt@i915_suspend@basic-s2idle-without-i915.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/fi-tgl-1115g4/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][11] ([i915#4212]) +7 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@kms_addfb_basic@basic-x-tiled-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][12] ([i915#4215])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][13] ([i915#4103] / [i915#4213]) +1 other test skip
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_dsc@dsc-basic:
- bat-dg1-5: NOTRUN -> [SKIP][14] ([i915#3555] / [i915#3840])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-5: NOTRUN -> [SKIP][15] ([fdo#109285])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_hdmi_inject@inject-audio:
- bat-dg1-5: NOTRUN -> [SKIP][16] ([i915#433])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_psr@sprite_plane_onoff:
- bat-dg1-5: NOTRUN -> [SKIP][17] ([i915#1072] / [i915#4078]) +3 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-5: NOTRUN -> [SKIP][18] ([i915#3555])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][19] ([i915#3708]) +3 other tests skip
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-5: NOTRUN -> [SKIP][20] ([i915#3708] / [i915#4077]) +1 other test skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg1-5/igt@prime_vgem@basic-gtt.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@lmem0:
- bat-dg2-9: [INCOMPLETE][21] ([i915#9275]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13869/bat-dg2-9/igt@gem_exec_suspend@basic-s0@lmem0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg2-9/igt@gem_exec_suspend@basic-s0@lmem0.html
* igt@i915_selftest@live@mman:
- bat-dg2-9: [DMESG-WARN][23] -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13869/bat-dg2-9/igt@i915_selftest@live@mman.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-dg2-9/igt@i915_selftest@live@mman.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [ABORT][25] ([i915#8668]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13869/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
* igt@kms_psr@sprite_plane_onoff:
- bat-jsl-3: [SKIP][27] ([i915#9648]) -> [PASS][28] +3 other tests pass
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13869/bat-jsl-3/igt@kms_psr@sprite_plane_onoff.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/bat-jsl-3/igt@kms_psr@sprite_plane_onoff.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#9275]: https://gitlab.freedesktop.org/drm/intel/issues/9275
[i915#9648]: https://gitlab.freedesktop.org/drm/intel/issues/9648
Build changes
-------------
* Linux: CI_DRM_13869 -> Patchwork_126338v1
CI-20190529: 20190529
CI_DRM_13869: 3d1e36691e73b3946b4a9ca8132a34f0319ff984 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7584: 30e6ded90039edde8aa6c435001f8d63159356bb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_126338v1: 3d1e36691e73b3946b4a9ca8132a34f0319ff984 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
c33f0cbbeed3 drm/i915: eliminate warnings
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v1/index.html
[-- Attachment #2: Type: text/html, Size: 10305 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: eliminate warnings
2023-11-13 3:36 [Intel-gfx] [PATCH] drm/i915: eliminate warnings heminhong
2023-11-13 19:06 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2023-11-13 20:31 ` Rodrigo Vivi
2023-11-14 2:43 ` [Intel-gfx] [PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit() heminhong
2023-11-17 19:31 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: eliminate warnings (rev2) Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2023-11-13 20:31 UTC (permalink / raw)
To: heminhong
Cc: Ville Syrjälä,
linux-kernel, dri-devel, daniel, airlied, intel-gfx
On Mon, Nov 13, 2023 at 11:36:13AM +0800, heminhong wrote:
> Current, the dewake_scanline variable is defined as unsigned int,
> an unsigned int variable that is always greater than or equal to 0.
> when _intel_dsb_commit function is called by intel_dsb_commit function,
> the dewake_scanline variable may have an int value.
> So the dewake_scanline variable is necessary to defined as an int.
A good catch. But this patch deserves a better commit subject since
it is not just fixing 'warnings' but the behavior of this function
accounts on the -1 that is explicitly given as input in some cases.
>
> Signed-off-by: heminhong <heminhong@kylinos.cn>
also perhaps:
Fixes: f83b94d23770 ("drm/i915/dsb: Use DEwake to combat PkgC latency")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
?
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 78b6fe24dcd8..7fd6280c54a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -340,7 +340,7 @@ static int intel_dsb_dewake_scanline(const struct intel_crtc_state *crtc_state)
> }
>
> static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
> - unsigned int dewake_scanline)
> + int dewake_scanline)
> {
> struct intel_crtc *crtc = dsb->crtc;
> struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()
2023-11-13 3:36 [Intel-gfx] [PATCH] drm/i915: eliminate warnings heminhong
2023-11-13 19:06 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-11-13 20:31 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
@ 2023-11-14 2:43 ` heminhong
2023-11-29 17:26 ` Jani Nikula
2023-11-17 19:31 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: eliminate warnings (rev2) Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: heminhong @ 2023-11-14 2:43 UTC (permalink / raw)
To: heminhong
Cc: linux-kernel, dri-devel, daniel, rodrigo.vivi, airlied, intel-gfx
Current, the dewake_scanline variable is defined as unsigned int,
an unsigned int variable that is always greater than or equal to 0.
when _intel_dsb_commit function is called by intel_dsb_commit function,
the dewake_scanline variable may have an int value.
So the dewake_scanline variable is necessary to defined as an int.
Fixes: f83b94d23770 ("drm/i915/dsb: Use DEwake to combat PkgC latency")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310052201.AnVbpgPr-lkp@intel.com/
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: heminhong <heminhong@kylinos.cn>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index 78b6fe24dcd8..7fd6280c54a7 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -340,7 +340,7 @@ static int intel_dsb_dewake_scanline(const struct intel_crtc_state *crtc_state)
}
static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
- unsigned int dewake_scanline)
+ int dewake_scanline)
{
struct intel_crtc *crtc = dsb->crtc;
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: eliminate warnings (rev2)
2023-11-13 3:36 [Intel-gfx] [PATCH] drm/i915: eliminate warnings heminhong
` (2 preceding siblings ...)
2023-11-14 2:43 ` [Intel-gfx] [PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit() heminhong
@ 2023-11-17 19:31 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-11-17 19:31 UTC (permalink / raw)
To: heminhong; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6609 bytes --]
== Series Details ==
Series: drm/i915: eliminate warnings (rev2)
URL : https://patchwork.freedesktop.org/series/126338/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13888 -> Patchwork_126338v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_126338v2 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_126338v2, please notify your bug team (lgci.bug.filing@intel.com) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/index.html
Participating hosts (38 -> 35)
------------------------------
Missing (3): fi-hsw-4770 fi-snb-2520m fi-pnv-d510
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_126338v2:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@guc:
- fi-kbl-soraka: NOTRUN -> [ABORT][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/fi-kbl-soraka/igt@i915_selftest@live@guc.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-cfl-8109u: [PASS][2] -> [ABORT][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13888/fi-cfl-8109u/igt@i915_suspend@basic-s3-without-i915.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/fi-cfl-8109u/igt@i915_suspend@basic-s3-without-i915.html
Known issues
------------
Here are the changes found in Patchwork_126338v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@mman:
- bat-rpls-1: [PASS][4] -> [TIMEOUT][5] ([i915#6794] / [i915#7392])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13888/bat-rpls-1/igt@i915_selftest@live@mman.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/bat-rpls-1/igt@i915_selftest@live@mman.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-1: [PASS][6] -> [WARN][7] ([i915#8747])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13888/bat-rpls-1/igt@i915_suspend@basic-s2idle-without-i915.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/bat-rpls-1/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [PASS][8] -> [FAIL][9] ([fdo#103375])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13888/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_hdmi_inject@inject-audio:
- fi-kbl-guc: [PASS][10] -> [FAIL][11] ([IGT#3])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13888/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][12] ([i915#5334] / [i915#7872]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13888/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- fi-kbl-soraka: [INCOMPLETE][14] ([i915#9527]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13888/fi-kbl-soraka/igt@i915_selftest@live@hangcheck.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/fi-kbl-soraka/igt@i915_selftest@live@hangcheck.html
* {igt@kms_psr@psr_cursor_plane_move@edp-1}:
- bat-jsl-3: [SKIP][16] ([i915#9648]) -> [PASS][17] +3 other tests pass
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13888/bat-jsl-3/igt@kms_psr@psr_cursor_plane_move@edp-1.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/bat-jsl-3/igt@kms_psr@psr_cursor_plane_move@edp-1.html
- bat-jsl-1: [SKIP][18] ([i915#9648]) -> [PASS][19] +3 other tests pass
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13888/bat-jsl-1/igt@kms_psr@psr_cursor_plane_move@edp-1.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/bat-jsl-1/igt@kms_psr@psr_cursor_plane_move@edp-1.html
#### Warnings ####
* igt@gem_lmem_swapping@verify-random:
- fi-kbl-soraka: [INCOMPLETE][20] -> [SKIP][21] ([fdo#109271] / [i915#4613])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13888/fi-kbl-soraka/igt@gem_lmem_swapping@verify-random.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/fi-kbl-soraka/igt@gem_lmem_swapping@verify-random.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#8747]: https://gitlab.freedesktop.org/drm/intel/issues/8747
[i915#8981]: https://gitlab.freedesktop.org/drm/intel/issues/8981
[i915#9527]: https://gitlab.freedesktop.org/drm/intel/issues/9527
[i915#9648]: https://gitlab.freedesktop.org/drm/intel/issues/9648
Build changes
-------------
* Linux: CI_DRM_13888 -> Patchwork_126338v2
CI-20190529: 20190529
CI_DRM_13888: 71624dec921946f36029faeb0f35022940a11b82 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7594: 8478eefdaa3eef02b4370339ef0d1970d44a67a2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_126338v2: 71624dec921946f36029faeb0f35022940a11b82 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
3c7e932f5f75 drm/i915: correct the input parameter on _intel_dsb_commit()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126338v2/index.html
[-- Attachment #2: Type: text/html, Size: 7434 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()
2023-11-14 2:43 ` [Intel-gfx] [PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit() heminhong
@ 2023-11-29 17:26 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2023-11-29 17:26 UTC (permalink / raw)
To: heminhong, heminhong
Cc: linux-kernel, dri-devel, daniel, rodrigo.vivi, airlied, intel-gfx
On Tue, 14 Nov 2023, heminhong <heminhong@kylinos.cn> wrote:
> Current, the dewake_scanline variable is defined as unsigned int,
> an unsigned int variable that is always greater than or equal to 0.
> when _intel_dsb_commit function is called by intel_dsb_commit function,
> the dewake_scanline variable may have an int value.
> So the dewake_scanline variable is necessary to defined as an int.
>
> Fixes: f83b94d23770 ("drm/i915/dsb: Use DEwake to combat PkgC latency")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310052201.AnVbpgPr-lkp@intel.com/
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
>
> Signed-off-by: heminhong <heminhong@kylinos.cn>
Pushed to drm-intel-next, thanks for the patch.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 78b6fe24dcd8..7fd6280c54a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -340,7 +340,7 @@ static int intel_dsb_dewake_scanline(const struct intel_crtc_state *crtc_state)
> }
>
> static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
> - unsigned int dewake_scanline)
> + int dewake_scanline)
> {
> struct intel_crtc *crtc = dsb->crtc;
> struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-29 17:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-13 3:36 [Intel-gfx] [PATCH] drm/i915: eliminate warnings heminhong
2023-11-13 19:06 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-11-13 20:31 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2023-11-14 2:43 ` [Intel-gfx] [PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit() heminhong
2023-11-29 17:26 ` Jani Nikula
2023-11-17 19:31 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: eliminate warnings (rev2) Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).