From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 00/10] gmbus/dp aux irqfication
Date: Sat, 01 Dec 2012 16:47:46 +0000 [thread overview]
Message-ID: <275ffc$7lm2dh@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1354366429-2324-1-git-send-email-daniel.vetter@ffwll.ch>
On Sat, 1 Dec 2012 13:53:39 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Hi all,
>
> Irq-drive gmbus/dp aux transfer, simply because we can (and at least in the case
> of gmbus, it's quite a bit faster than the msleep(1) loop - we now reliably
> transfer at full wire speed insteaf of sometimes 2-3x slower).
>
> Compared to the older version I've floated on irc way back and which Chris has
> carried around in his wip branchs (and inflicted upon tons of unsuspecting bug
> reporters) there are a few differences:
> - handle the hpd vs. setup race - even the current code enables hpd processing
> before the fbdev is set up, which is too early.
> - fix the gen4 gmbus support, was totally busted.
> - tested on hsw (although all the relevant bits are a 100% match with cpt/ivb).
> - disable dp aux irq on vlv - too complicated to get at the docs (moved again,
> old access revoked) and I don't have the hw.
>
> While reviewing this patch series I've also noticed two small things in the irq
> handling code in general, patches for that at the beginning of the series.
>
> Comment&review highgly welcome.
gm45 appears to be functioning big time, good start. The init sequence
looks less convoluted and better understood now, so I am reasonably
happy with this series. Will report back later after more testing.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-01 16:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-01 12:53 [PATCH 00/10] gmbus/dp aux irqfication Daniel Vetter
2012-12-01 12:53 ` [PATCH 01/10] drm/i915: haswell has the same irq handlers as ivb Daniel Vetter
2012-12-01 12:53 ` [PATCH 02/10] drm/i915: don't handle PIPE_LEGACY_BLC_EVENT_STATUS on vlv Daniel Vetter
2012-12-03 15:49 ` Jesse Barnes
2012-12-04 14:37 ` Imre Deak
2012-12-04 15:13 ` Daniel Vetter
2012-12-01 12:53 ` [PATCH 03/10] drm/i915: reorder setup sequence to have irqs for output setup Daniel Vetter
2012-12-01 20:03 ` [PATCH 1/2] drm/i915: setup the hangcheck timer early Daniel Vetter
2012-12-01 20:03 ` [PATCH 2/2] drm/i915: reorder setup sequence to have irqs for output setup Daniel Vetter
2012-12-01 12:53 ` [PATCH 04/10] drm/i915: extract gmbus_wait_hw_status Daniel Vetter
2012-12-01 12:53 ` [PATCH 05/10] drm/i915: wire up gmbus irq handler Daniel Vetter
2012-12-01 12:53 ` [PATCH 06/10] drm/i915: use the gmbus irq for waits Daniel Vetter
2012-12-01 12:53 ` [PATCH 07/10] drm/i915: use gmbus irq to wait for gmbus idle Daniel Vetter
2012-12-01 12:53 ` [PATCH 08/10] drm/i915: wire up do aux channel done interrupt Daniel Vetter
2012-12-01 12:53 ` [PATCH 09/10] drm/i915: irq-drive the dp aux communication Daniel Vetter
2012-12-01 12:53 ` [PATCH 10/10] drm/i915: use _NOTRACE for gmbus/dp aux wait loops Daniel Vetter
2012-12-01 16:35 ` Chris Wilson
2012-12-01 20:03 ` [PATCH] " Daniel Vetter
2012-12-01 16:47 ` Chris Wilson [this message]
2012-12-01 18:01 ` [PATCH 00/10] gmbus/dp aux irqfication Chris Wilson
2012-12-01 20:15 ` Daniel Vetter
2012-12-04 9:20 ` Chris Wilson
2012-12-04 16:04 ` Imre Deak
2012-12-05 10:59 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='275ffc$7lm2dh@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).